Re: D6728: config: add experimental argument to the config registrar

2019-08-19 Thread Pierre-Yves David
This change breaks contrib/perf.py on older version (that extension is special and we expect it to be compatible with older version). Can you follow up with a fix ? (note: when doing this kind of change it is often useful to have different patch for adding the feature and using it. It help to

D6728: config: add experimental argument to the config registrar

2019-08-18 Thread navaneeth.suresh (Navaneeth Suresh)
navaneeth.suresh added inline comments. INLINE COMMENTS > pulkit wrote in perf.py:244 > This breaks `contrib/perf.py` with older versions of mercurial. Can you send > a compatibility fix as followup? I'm not sure I understood that. Do you want me to remove the changes in `contrib/perf.py`?

D6728: config: add experimental argument to the config registrar

2019-08-17 Thread pulkit (Pulkit Goyal)
pulkit added inline comments. INLINE COMMENTS > perf.py:244 > default=mercurial.configitems.dynamicdefault, > +experimental=True, > ) This breaks `contrib/perf.py` with older versions of mercurial. Can you send a compatibility fix as followup? REPOSITORY rHG Mercurial

D6728: config: add experimental argument to the config registrar

2019-08-15 Thread navaneeth.suresh (Navaneeth Suresh)
Closed by commit rHGe67d9b6bad4d: config: add experimental argument to the config registrar (authored by navaneeth.suresh). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY

D6728: config: add experimental argument to the config registrar

2019-08-15 Thread navaneeth.suresh (Navaneeth Suresh)
navaneeth.suresh created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Until now, there are almost 28 config items which are considered as `experimental` but, not present in the `experimental` section of the registrar.