D6836: interfaces: introduce an interface for dirstate implementations

2019-09-14 Thread durin42 (Augie Fackler)
Closed by commit rHGd459cd8ea42d: interfaces: introduce an interface for dirstate implementations (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6836?vs=16504&

D6836: interfaces: introduce an interface for dirstate implementations

2019-09-13 Thread Raphaël Gomès
Alphare added inline comments. INLINE COMMENTS > dirstate.py:37 > + > +_map = interfaceutil.Attribute( > +"""Return the dirstate contents (see documentation for dirstatemap). Shouldn't this be removed? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-sc

D6836: interfaces: introduce an interface for dirstate implementations

2019-09-10 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY As usual with adding interface definitions, this describes the way things are, not the way we'd like things to be. There are some clear problems in the interface