D7324: index: add a `rev` method (API)

Closed by commit rHGb43a685edbc7: index: add a `rev` method (API) (authored by marmoute). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7324?vs=17883=17889 CHANGES SINCE LAST

D7324: index: add a `rev` method (API)

This revision now requires changes to proceed. indygreg added a comment. indygreg requested changes to this revision. I'm fine ignoring the `RevlogError` quirk, since it already exists. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7324/new/ REVISION

D7324: index: add a `rev` method (API)

marmoute updated this revision to Diff 17883. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7324?vs=17837=17883 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7324/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7324 AFFECTED FILES

D7324: index: add a `rev` method (API)

martinvonz added a comment. Perhaps it's best to bump the version number in this patch and the `get_rev` patch as well? I don't feel strongly, but I'll queue all the `has_node` patches to start with. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION

D7324: index: add a `rev` method (API)

marmoute updated this revision to Diff 17837. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7324?vs=17822=17837 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7324/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7324 AFFECTED FILES

D7324: index: add a `rev` method (API)

marmoute updated this revision to Diff 17822. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7324?vs=17745=17822 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7324/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7324 AFFECTED FILES

D7324: index: add a `rev` method (API)

marmoute added a comment. marmoute requested review of this revision. In D7324#107591 , @indygreg wrote: > The code is fine. But since I've already left a number of comments on this series, I thought I'd ask about raising a better exception

D7324: index: add a `rev` method (API)

This revision now requires changes to proceed. indygreg added a comment. indygreg requested changes to this revision. The code is fine. But since I've already left a number of comments on this series, I thought I'd ask about raising a better exception than `RevlogError`. I thought we had

D7324: index: add a `rev` method (API)

marmoute created this revision. Herald added a reviewer: indygreg. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The new `index.rev(node)` is to be preferred over using `node index.nodemap[node]`. This get us closer to be able to