On 10/16/2016 08:14 PM, Gregory Szorc wrote:
# HG changeset patch # User Gregory Szorc <gregory.sz...@gmail.com> # Date 1476641421 25200 # Sun Oct 16 11:10:21 2016 -0700 # Node ID 23457f8910d43bd637b945ced2f963ab71255844 # Parent 3f18f7464e651128a5f8d9c9312805adbc22f547 wireproto: compress data from a generator
Pushed, thanks. It would be great to have some performance number on this,
[…] To avoid duplicate code, the HTTP groupchunks() has been reimplemented in terms of compresschunks().
I would have been happier to take a first patch introducing the new function and reimplementing groupchunkgs with it, followed by a second patch dropping chunkbuffer. That was minor to ignore but consider doing so in the future.
-- Pierre-Yves David _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
