Re: hg archive (files) performance regression.

On 3/03/2018 1:32 PM, Matt Harbison wrote: AFAICT, the code prior to this vfs call didn't do atomic files, and didn't mention why the atomic aspect changed. I guess it's just something that was overlooked during refactoring to use the vfs? It looks like archive doesn't check for an empty

Re: hg archive (files) performance regression.

On Fri, 02 Mar 2018 02:13:18 -0500, Vincent Parrett wrote: On 2/03/2018 4:31 PM, Vincent Parrett wrote: I'm not a python dev (mostly c# and delphi), so still getting my head around the hg code base, but I'm curious why the atomictemp=true is used in

Re: hg archive (files) performance regression.

On 2/03/2018 4:31 PM, Vincent Parrett wrote: I'm not a python dev (mostly c# and delphi), so still getting my head around the hg code base, but I'm curious why the atomictemp=true is used in fileit.addfile? I get that it's in the vfs to work around file locking issues, but with the archive

hg archive (files) performance regression.

Somewhere between hg 4.2.2 and 4.5 the archive (files, to empty folder) command gotten around 10-13% slower. Testing on windows 10 x64 (latest updates), between two ssd drives : hg 4.5 : - "C:\Program