Module: Mesa
Branch: master
Commit: 186988e28f9fe31ad4d08626586d5167051a14e7
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=186988e28f9fe31ad4d08626586d5167051a14e7
Author: Timothy Arceri <tarc...@itsqueeze.com>
Date: Thu Jun 7 09:49:37 2018 +1000
radv: fix Coverity no effect control flow issue
swizzle is unsigned so "desc->swizzle[c] < 0" is never true.
Reviewed-by: Bas Nieuwenhuizen <b...@basnieuwenhuizen.nl>
---
src/amd/vulkan/radv_formats.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/amd/vulkan/radv_formats.c b/src/amd/vulkan/radv_formats.c
index 50ec904d51..958f2a2c82 100644
--- a/src/amd/vulkan/radv_formats.c
+++ b/src/amd/vulkan/radv_formats.c
@@ -921,7 +921,7 @@ bool radv_format_pack_clear_color(VkFormat format,
uint64_t clear_val = 0;
for (unsigned c = 0; c < 4; ++c) {
- if (desc->swizzle[c] < 0 || desc->swizzle[c] >= 4)
+ if (desc->swizzle[c] >= 4)
continue;
const struct vk_format_channel_description *channel =
&desc->channel[desc->swizzle[c]];
_______________________________________________
mesa-commit mailing list
mesa-commit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-commit
