Module: Mesa
Branch: master
Commit: 2ba4c7e1548c6251085cd75563c182cc6708eaab
URL:    
http://cgit.freedesktop.org/mesa/mesa/commit/?id=2ba4c7e1548c6251085cd75563c182cc6708eaab

Author: Rob Clark <robcl...@freedesktop.org>
Date:   Thu Dec  1 10:57:24 2016 -0800

egl: un-fallthrough sync attr parsing

Doesn't work so well when you start having more than one possible
attrib.  Prep-work for next patch.

Signed-off-by: Rob Clark <robdcl...@gmail.com>
Tested-by: Rafael Antognolli <rafael.antogno...@intel.com>
Reviewed-by: Chad Versace <chadvers...@chromium.org>
Tested-by: Chad Versace <chadvers...@chromium.org>

---

 src/egl/main/eglsync.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/egl/main/eglsync.c b/src/egl/main/eglsync.c
index 005cb31..7b2c882 100644
--- a/src/egl/main/eglsync.c
+++ b/src/egl/main/eglsync.c
@@ -55,11 +55,11 @@ _eglParseSyncAttribList(_EGLSync *sync, const EGLAttrib 
*attrib_list)
       case EGL_CL_EVENT_HANDLE_KHR:
          if (sync->Type == EGL_SYNC_CL_EVENT_KHR) {
             sync->CLEvent = val;
-            break;
+         } else {
+            err = EGL_BAD_ATTRIBUTE;
          }
-         /* fall through */
+         break;
       default:
-         (void) val;
          err = EGL_BAD_ATTRIBUTE;
          break;
       }

_______________________________________________
mesa-commit mailing list
mesa-commit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-commit

Reply via email to