[Mesa-dev] [Bug 38716] Can't build, error: undefined reference to `_eglFilterConfigArray'

2011-06-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=38716 --- Comment #1 from Chia-I Wu olva...@gmail.com 2011-06-27 23:26:47 PDT --- The command for linking wrongly put the local library search path after the system's. It should be fixed with 24137af. Please test. -- Configure bugmail:

[Mesa-dev] [Bug 38716] Can't build, error: undefined reference to `_eglFilterConfigArray'

2011-06-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=38716 Alexandre Demers alexandre.f.dem...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED

[Mesa-dev] [Bug 38699] Can't compile with d3d1x since commit 73df31eedd0f33c8a9907855cb247c8f87964c48

2011-06-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=38699 Alexandre Demers alexandre.f.dem...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED

[Mesa-dev] [Bug 38716] Can't build, error: undefined reference to `_eglFilterConfigArray'

2011-06-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=38716 --- Comment #4 from Chia-I Wu olva...@gmail.com 2011-06-28 04:30:59 PDT --- Is your i386-linux-gnu/libEGL.so outdated? It should have the symbol. (another place to check is src/egl/main/eglconfig.o where the symbol is defined) -- Configure

[Mesa-dev] [Bug 38716] Can't build, error: undefined reference to `_eglFilterConfigArray'

2011-06-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=38716 --- Comment #5 from Alexandre Demers alexandre.f.dem...@gmail.com 2011-06-28 04:41:56 PDT --- Obviously, after verifying, i386-linux-gnu/libEGL.so shouldn't be outdated since I always make a make realclean at the beginning and the file is then

[Mesa-dev] [Bug 38716] Can't build, error: undefined reference to `_eglFilterConfigArray'

2011-06-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=38716 --- Comment #6 from Chia-I Wu olva...@gmail.com 2011-06-28 05:04:06 PDT --- You can still use nm like $ nm src/egl/main/eglconfig.o Could you also attach your build log of building src/egl/main? It might shed some light. -- Configure

[Mesa-dev] [PATCH 1/2] st-api: Rework how drawables are invalidated

2011-06-28 Thread Thomas Hellstrom
The api and the state tracker manager code as well as the state tracker code assumed that only a single context could be bound to a drawable. That is not a valid assumption, since multiple contexts can bind to the same drawable. Fix this by making it the state tracker's responsibility to update

[Mesa-dev] [PATCH 2/2] st/dri: Get rid of the evil struct dri_drawable::context member

2011-06-28 Thread Thomas Hellstrom
It's incorrect to assume a single context bound to a drawable. Signed-off-by: Thomas Hellstrom thellst...@vmware.com --- .../state_trackers/dri/common/dri_context.c|4 .../state_trackers/dri/common/dri_drawable.h |1 - 2 files changed, 0 insertions(+), 5 deletions(-)

Re: [Mesa-dev] [PATCH 2/2] glsl: Rewrote _mesa_glsl_process_extension to use table-driven logic.

2011-06-28 Thread Paul Berry
On 27 June 2011 18:30, Ian Romanick i...@freedesktop.org wrote: I like this a lot.  It's a really good clean up of a rotting cesspool. Thanks!   that are avaiable in geometry shaders.             available *smacks forehead* Oops. +   /* Name of the extension when referred to in a GLSL

Re: [Mesa-dev] [PATCH 1/2] st-api: Rework how drawables are invalidated

2011-06-28 Thread Jose Fonseca
Looks good to me Thomas. Jose - Original Message - The api and the state tracker manager code as well as the state tracker code assumed that only a single context could be bound to a drawable. That is not a valid assumption, since multiple contexts can bind to the same drawable.

[Mesa-dev] [Bug 38716] Can't build, error: undefined reference to `_eglFilterConfigArray'

2011-06-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=38716 --- Comment #7 from Alexandre Demers alexandre.f.dem...@gmail.com 2011-06-28 09:02:33 PDT --- I'll look at it when I'll get home tonight. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this

Re: [Mesa-dev] [PATCH 6/6] glsl: Generate IR for switch statements

2011-06-28 Thread Paul Berry
On 27 June 2011 17:35, Keith Packard kei...@keithp.com wrote: I'd write the simplest possible code that works now and then consider optimizing it later. This has the advantage that you can get a bunch of tests working and then use those to validate a later, more complicated, implementation. I

Re: [Mesa-dev] [PATCH 1/2] st-api: Rework how drawables are invalidated

2011-06-28 Thread Thomas Hellstrom
On 06/28/2011 04:27 PM, Jose Fonseca wrote: Looks good to me Thomas. Jose Jakob pointed out that the state trackers (vega mesa) will actually create a window system draw buffer / framebuffer per context, even if they represent the same window system drawable, so I need to do some

Re: [Mesa-dev] [PATCH v2] glsl: Track initial mask in constant propagation live set

2011-06-28 Thread Eric Anholt
On Mon, 27 Jun 2011 19:51:51 -0700, Ian Romanick i...@freedesktop.org wrote: From: Ian Romanick ian.d.roman...@intel.com The set of values initially available (before any kills) must be tracked with each constant in the set. Otherwise the wrong component can be selected after earlier

Re: [Mesa-dev] [PATCH] mesa: Don't clamp GetTexImage results post RGB-L if !ClampReadColor.

2011-06-28 Thread Eric Anholt
On Sat, 18 Jun 2011 17:43:16 -0700, Eric Anholt e...@anholt.net wrote: Fixes oglconform failure about our ARB_texture_float GetTexImage. Note that clamping does not appear in the Conversion to L stage of the GL 3.2 spec, and the next stage of Final conversion does clamping according to

Re: [Mesa-dev] [PATCH 6/6] glsl: Generate IR for switch statements

2011-06-28 Thread Dan McCabe
On 06/28/2011 09:12 AM, Paul Berry wrote: On 27 June 2011 17:35, Keith Packardkei...@keithp.com wrote: I'd write the simplest possible code that works now and then consider optimizing it later. This has the advantage that you can get a bunch of tests working and then use those to validate a

[Mesa-dev] [PATCH] glsl: permit explicit locations on fragment shader outputs, not inputs

2011-06-28 Thread Paul Berry
From the OpenGL docs for GL_ARB_explicit_attrib_location: This extension provides a method to pre-assign attribute locations to named vertex shader inputs and color numbers to named fragment shader outputs. This was accidentally implemented for fragment shader inputs. This patch

Re: [Mesa-dev] [PATCH 2/2] glsl: Rewrote _mesa_glsl_process_extension to use table-driven logic.

2011-06-28 Thread Paul Berry
On 28 June 2011 10:01, Eric Anholt e...@anholt.net wrote: If I stumbled on this code, I'd have no idea what was going on.  A short version of this description near the code might help us poor C developers who stumble on it that have never seen this stuff before. Will do. +   case

[Mesa-dev] [PATCH] glsl: Rewrote _mesa_glsl_process_extension to use table-driven logic.

2011-06-28 Thread Paul Berry
Instead of using a chain of manually maintained if/else blocks to handle #extension directives, we now consult a table that specifies, for each extension, the circumstances under which it is available, and what flags in _mesa_glsl_parse_state need to be set in order to activate it. This makes it

Re: [Mesa-dev] [PATCH] glsl: permit explicit locations on fragment shader outputs, not inputs

2011-06-28 Thread Kenneth Graunke
On 06/28/2011 10:50 AM, Paul Berry wrote: From the OpenGL docs for GL_ARB_explicit_attrib_location: This extension provides a method to pre-assign attribute locations to named vertex shader inputs and color numbers to named fragment shader outputs. This was accidentally

Re: [Mesa-dev] [PATCH] glsl: permit explicit locations on fragment shader outputs, not inputs

2011-06-28 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/28/2011 10:50 AM, Paul Berry wrote: From the OpenGL docs for GL_ARB_explicit_attrib_location: This extension provides a method to pre-assign attribute locations to named vertex shader inputs and color numbers to named fragment

Re: [Mesa-dev] [PATCH 2/2] glsl: Rewrote _mesa_glsl_process_extension to use table-driven logic.

2011-06-28 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/28/2011 10:01 AM, Eric Anholt wrote: On Tue, 28 Jun 2011 06:49:57 -0700, Paul Berry stereotype...@gmail.com wrote: On 27 June 2011 18:30, Ian Romanick i...@freedesktop.org wrote: I like this a lot. It's a really good clean up of a rotting

Re: [Mesa-dev] [PATCH] mesa: Don't clamp GetTexImage results post RGB-L if !ClampReadColor.

2011-06-28 Thread Roland Scheidegger
Am 28.06.2011 19:21, schrieb Eric Anholt: On Sat, 18 Jun 2011 17:43:16 -0700, Eric Anholt e...@anholt.net wrote: Fixes oglconform failure about our ARB_texture_float GetTexImage. Note that clamping does not appear in the Conversion to L stage of the GL 3.2 spec, and the next stage of Final

Re: [Mesa-dev] [PATCH] glsl: Rewrote _mesa_glsl_process_extension to use table-driven logic.

2011-06-28 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/28/2011 11:47 AM, Paul Berry wrote: Nice work. Reviewed-by: Ian Romanick ian.d.roman...@intel.com I think we will want to cherry pick this to 7.11 and 7.10, but I want to give it a little time to settle on master first. I don't want to

[Mesa-dev] [PATCH 0/5] glsl: Add switch statement support to GLSL compiler

2011-06-28 Thread Dan McCabe
This patch set adds support for switch statements to the GLSL compiler. We modify the grammar for the compiler with productions for switch statements and case labels, while adding supporting supporting productions not already present. New AST classes are defined to support those productions.

[Mesa-dev] [PATCH 2/5] glsl: Add productions to GLSL grammar for switch statement

2011-06-28 Thread Dan McCabe
The grammar is modified to support switch statements. Rather than follow the grammar in the appendix, which allows case labels to be placed ANYWHERE as a regular statement, we follow the development of the grammar as described in the body of the GLSL. In this variation, the switch statement has a

[Mesa-dev] [PATCH 3/5] glsl: Create AST structs corresponding to new productions in grammar

2011-06-28 Thread Dan McCabe
Previously we added productions for: switch_body case_label_list case_statement case_statement_list Now add AST structs corresponding to those productions. --- src/glsl/ast.h | 59 1 files changed, 59

[Mesa-dev] [PATCH 4/5] glsl: Reference data structure ctors in grammar

2011-06-28 Thread Dan McCabe
We now tie the grammar to the ctors of the ASTs they reference. This requires that we actually have definitions of the ctors. In addition, we also need to define print and hir methods for the AST classes. The Print methods are pretty simple to flesh out. However, at this stage of the

Re: [Mesa-dev] [PATCH 1/2] st-api: Rework how drawables are invalidated

2011-06-28 Thread Chia-I Wu
On Tue, Jun 28, 2011 at 9:19 PM, Thomas Hellstrom thellst...@vmware.com wrote: The api and the state tracker manager code as well as the state tracker code assumed that only a single context could be bound to a drawable. That is not a valid assumption, since multiple contexts can bind to the

[Mesa-dev] [PATCH 3/3] mesa: Remove extra NULL Check on glFeedbackBuffer().

2011-06-28 Thread Eric Anholt
This error result doesn't appear in the GL 2.1 or 3.2 compatibility specs, and triggers an unexpected GL error in Intel's oglconform when it tries to reset the feedback state after usage so that the diff the state at error time vs. context init time code doesn't generate spurious diffs. The

[Mesa-dev] oglconform VP_binding.c fix series

2011-06-28 Thread Eric Anholt
Here's a series to fix the non-oglconform bugs revealed by our oglconform's VP_binding.c test, and a couple of testcases I had to make along the way. I'm curious how others feel about the piglit tests -- would you rather see them named by the full function name being tested, or would you rather

[Mesa-dev] [PATCH 1/2] getenv4d-with-error: New test for a bug in glGetProgramEnvParameter4dARB().

2011-06-28 Thread Eric Anholt
--- tests/all.tests|4 + tests/spec/CMakeLists.txt |1 + tests/spec/arb_vertex_program/CMakeLists.gl.txt| 16 tests/spec/arb_vertex_program/CMakeLists.txt |1 +

[Mesa-dev] [PATCH 2/3] mesa: Don't skip glGetProgramLocalParam4dvARB if there was already an error.

2011-06-28 Thread Eric Anholt
Like the previous commit, but fixes ARB_vertex_program/getlocal4d-with-error. --- src/mesa/main/arbprogram.c | 116 +-- 1 files changed, 57 insertions(+), 59 deletions(-) diff --git a/src/mesa/main/arbprogram.c b/src/mesa/main/arbprogram.c index

[Mesa-dev] [PATCH 1/3] mesa: Don't skip glGetProgramEnvParam4dvARB if there was already an error.

2011-06-28 Thread Eric Anholt
Fixes a bug caught by oglconform, and now piglit ARB_vertex_program/getenv4d-with-error. The wrapping of an existing GL function made it so that we couldn't distinguish an error in looking up our arguments from an existing error. Instead, make a helper function to choose the param, and use it

[Mesa-dev] [PATCH 2/2] getlocal4d-with-error: New test for a bug in glGetProgramLocalParameter4dARB()

2011-06-28 Thread Eric Anholt
--- tests/all.tests|1 + tests/spec/arb_vertex_program/CMakeLists.gl.txt|1 + .../arb_vertex_program/getlocal4d-with-error.c | 88 3 files changed, 90 insertions(+), 0 deletions(-) create mode 100644

Re: [Mesa-dev] [PATCH 0/6] glsl: Add support for switch statements

2011-06-28 Thread Dan McCabe
Comments at the end (where they are supposed to be :). On 06/17/2011 05:54 PM, Dan McCabe wrote: There are three changes from the patch set I published on 6/15: 1) Removed IR pointers from AST classes and moved them to glsl_parser_state, 2) Manage the new IR in a stack-like manner to properly

Re: [Mesa-dev] [PATCH 3/3] mesa: Remove extra NULL Check on glFeedbackBuffer().

2011-06-28 Thread Brian Paul
On Tue, Jun 28, 2011 at 5:49 PM, Eric Anholt e...@anholt.net wrote: This error result doesn't appear in the GL 2.1 or 3.2 compatibility specs, and triggers an unexpected GL error in Intel's oglconform when it tries to reset the feedback state after usage so that the diff the state at error

[Mesa-dev] [PATCH 2/2] Gallium:draw:aaline and aapoint: Don't free the tokens.

2011-06-28 Thread Stéphane Marchesin
We didn't allocate them, and the driver will try to free them at the end of the pipeline stage, so leave them alone. --- src/gallium/auxiliary/draw/draw_pipe_aaline.c |1 - src/gallium/auxiliary/draw/draw_pipe_aapoint.c |1 - 2 files changed, 0 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [Bug 38716] Can't build, error: undefined reference to `_eglFilterConfigArray'

2011-06-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=38716 --- Comment #8 from Alexandre Demers alexandre.f.dem...@gmail.com 2011-06-28 21:05:19 PDT --- Here are some different results: -nm -D src/egl/main/eglconfig.o | grep eglFilter nm: src/egl/main/eglconfig.o: No symbols -nm

[Mesa-dev] [Bug 38716] Can't build, error: undefined reference to `_eglFilterConfigArray'

2011-06-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=38716 --- Comment #9 from Alexandre Demers alexandre.f.dem...@gmail.com 2011-06-28 22:22:29 PDT --- Created an attachment (id=48539) -- (https://bugs.freedesktop.org/attachment.cgi?id=48539) Full log using: make realclean ./autogen.sh

Re: [Mesa-dev] [PATCH 2/5] glsl: Add productions to GLSL grammar for switch statement

2011-06-28 Thread Kenneth Graunke
On 06/28/2011 02:48 PM, Dan McCabe wrote: The grammar is modified to support switch statements. Rather than follow the grammar in the appendix, which allows case labels to be placed ANYWHERE as a regular statement, we follow the development of the grammar as described in the body of the GLSL.

Re: [Mesa-dev] [PATCH 3/5] glsl: Create AST structs corresponding to new productions in grammar

2011-06-28 Thread Kenneth Graunke
On 06/28/2011 02:48 PM, Dan McCabe wrote: Previously we added productions for: switch_body case_label_list case_statement case_statement_list Now add AST structs corresponding to those productions. Both 1/3 and 3/3 look good. You might actually want to squash