[Mesa-dev] [PATCH 1/3] intel: Recognize GL_DEPTH_COMPONENT32 in get_teximage_readbuffer.

2011-06-30 Thread Kenneth Graunke
gl_texture_image::InternalFormat is actually the user requested internal format, not what the texture actually is. Thus, even though we don't support 32-bit depth buffers, we need to recognize the enumeration here. Otherwise, it wrongly returns the color read buffer instead of the depth read

[Mesa-dev] [PATCH 2/3] intel: Remove restriction against Y-tiling in intel_copy_texsubimage.

2011-06-30 Thread Kenneth Graunke
intelEmitCopyBlit already checks for this, so the check is redundant and unnecessary. This consolidates the logic (which will soon change). NOTE: This is a candidate for the 7.10 and 7.11 branches. Signed-off-by: Kenneth Graunke kenn...@whitecape.org ---

[Mesa-dev] [PATCH 3/3] intel: Add support copying Y-tiled buffers with the Gen6 blitter.

2011-06-30 Thread Kenneth Graunke
According to the Sandybridge PRM, Volume 1, Part 5, Section 1.9.15, Gen6's blitter supports Y-tiled buffers as well as X-tiled. Pitch is specified in 512-byte granularity for X-tiled, but 128-byte for Y-tiled. Gen5 and earlier unfortunately only support X-tiled buffers. Fixes a software

[Mesa-dev] [PATCH 1/9] svga: Flush when switching between HW to SW TNL, after updating need_swtnl.

2011-06-30 Thread Thomas Hellstrom
From: José Fonseca jfons...@vmware.com Also, only flush when going from HW TNL to SW TNL, given it is impossible for the buffers resulting from SWTNL to be ever referred by HW TNL path. --- src/gallium/drivers/svga/svga_context.h |3 --- src/gallium/drivers/svga/svga_pipe_draw.c | 23

[Mesa-dev] [PATCH 2/9] gallium/util: Upload manager optimizations

2011-06-30 Thread Thomas Hellstrom
Make sure that the upload manager doesn't upload data that's not dirty. This speeds up the viewperf test proe-04/1 a factor 5 or so on svga. Also introduce an u_upload_unmap() function that can be used instead of u_upload_flush() so that we can pack even more data in upload buffers. With this we

[Mesa-dev] [PATCH 3/9] gallium/svga: Make use of u_upload_flush().

2011-06-30 Thread Thomas Hellstrom
This enables us to pack more data into single upload buffers. Signed-off-by: Thomas Hellstrom thellst...@vmware.com --- src/gallium/drivers/svga/svga_context.c |8 src/gallium/drivers/svga/svga_draw.c|4 ++-- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [PATCH 4/9] gallium/svga: Upload only parts of user-buffers that we actually use

2011-06-30 Thread Thomas Hellstrom
Stream user buffer contents rather than trying to maintain persistent host / hardware copies. Resulting negative array offsets are not allowed by the hardware, (well, at least not according to header files), so adjust index bias to make all array offsets positive. Signed-off-by: Thomas Hellstrom

[Mesa-dev] [PATCH 5/9] svga: Handle null buffers in svga_buffer_is_user_buffer().

2011-06-30 Thread Thomas Hellstrom
From: José Fonseca jfons...@vmware.com --- src/gallium/drivers/svga/svga_resource_buffer.h |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/src/gallium/drivers/svga/svga_resource_buffer.h b/src/gallium/drivers/svga/svga_resource_buffer.h index 2ae44d2..69d6f72

[Mesa-dev] [PATCH 6/9] svga: fix incorrect user buffer size computation

2011-06-30 Thread Thomas Hellstrom
From: Brian Paul bri...@vmware.com Viewperf uses some unusual vertex arrays where the stride is less than the element size. In this case, the stride was 4 while the element size was 12. The difference of 8 bytes causes us to miss uploading the tail bit of the array data. Typically the stride

[Mesa-dev] [PATCH 7/9] svga: fix incorrect user buffer size computation for instance divisor case

2011-06-30 Thread Thomas Hellstrom
From: Brian Paul bri...@vmware.com See preceeding commit for more info. --- src/gallium/drivers/svga/svga_pipe_draw.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/svga/svga_pipe_draw.c b/src/gallium/drivers/svga/svga_pipe_draw.c index

[Mesa-dev] [PATCH 9/9] svga: Fix multiple uploads of the same user-buffer.

2011-06-30 Thread Thomas Hellstrom
If a user-buffer was referenced twice by a draw command, the affected ranges were uploaded separately, with only the last one being referenced by the hardware. Make sure we upload only a single range. Signed-off-by: Thomas Hellstrom thellst...@vmware.com ---

Re: [Mesa-dev] [PATCH] llvmpipe: Optimize new fs state setup

2011-06-30 Thread Thomas Hellstrom
Hmm. Forgive my ignorance, but isn't memcmp() on structs pretty prone to give incorrect != results, given that there may be padding between members in structs and that IIRC gcc struct assignment is member-wise. What happens if there's padding between the jit_context and variant members of

Re: [Mesa-dev] [PATCH 3/3] intel: Add support copying Y-tiled buffers with the Gen6 blitter.

2011-06-30 Thread Chris Wilson
On Wed, 29 Jun 2011 23:04:04 -0700, Kenneth Graunke kenn...@whitecape.org wrote: According to the Sandybridge PRM, Volume 1, Part 5, Section 1.9.15, Gen6's blitter supports Y-tiled buffers as well as X-tiled. Pitch is specified in 512-byte granularity for X-tiled, but 128-byte for Y-tiled.

Re: [Mesa-dev] [PATCH] llvmpipe: Optimize new fs state setup

2011-06-30 Thread Keith Whitwell
On Wed, 2011-06-29 at 16:16 -0700, Corbin Simpson wrote: Okay, so maybe I'm failing to recognize the exact situation here, but wouldn't it be possible to mark the FS state with a serial number and just compare those? Or are these FS states not CSO-cached? No, the struct being compared is

Re: [Mesa-dev] [PATCH] llvmpipe: Optimize new fs state setup

2011-06-30 Thread Keith Whitwell
On Thu, 2011-06-30 at 03:36 +0200, Roland Scheidegger wrote: Ok in fact there's a gcc bug about memcmp: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43052 In short gcc's memcmp builtin is totally lame and loses to glibc's memcmp (including call overhead, no knowledge about alignment etc.) even

Re: [Mesa-dev] [PATCH] llvmpipe: Optimize new fs state setup

2011-06-30 Thread Jose Fonseca
Great work Roland! And thanks Ajax to finding this hot spot. We use memcmp a lot -- all CSO caching, so we should use this everywhere. We should also code a sse2 version with intrinsics for x86-64, which is guaranteed to always have SSE2. Jose - Original Message - Actually I ran some

Re: [Mesa-dev] [PATCH] llvmpipe: Optimize new fs state setup

2011-06-30 Thread Jose Fonseca
- Original Message - Hmm. Forgive my ignorance, but isn't memcmp() on structs pretty prone to give incorrect != results, given that there may be padding between members in structs and that IIRC gcc struct assignment is member-wise. There's no alternative to bitwise comparison on

Re: [Mesa-dev] [PATCH] llvmpipe: Optimize new fs state setup

2011-06-30 Thread Jose Fonseca
- Original Message - On Thu, 2011-06-30 at 03:36 +0200, Roland Scheidegger wrote: Ok in fact there's a gcc bug about memcmp: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43052 In short gcc's memcmp builtin is totally lame and loses to glibc's memcmp (including call overhead, no

Re: [Mesa-dev] [PATCH 1/3] intel: Recognize GL_DEPTH_COMPONENT32 in get_teximage_readbuffer.

2011-06-30 Thread Brian Paul
On Thu, Jun 30, 2011 at 12:04 AM, Kenneth Graunke kenn...@whitecape.org wrote: gl_texture_image::InternalFormat is actually the user requested internal format, not what the texture actually is.  Thus, even though we don't support 32-bit depth buffers, we need to recognize the enumeration here.

[Mesa-dev] [Bug 37177] Mathematica Plot3D Crash

2011-06-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37177 --- Comment #3 from Mark van Rossum mvanr...@inf.ed.ac.uk 2011-06-30 05:34:57 PDT --- Confirmed for me on Fedora 15 with Mathematica 7 on VGA compatible controller: Intel Corporation Mobile GM965/GL960 Integrated Graphics Controller (rev 0c).

Re: [Mesa-dev] [PATCH] llvmpipe: Optimize new fs state setup

2011-06-30 Thread Keith Whitwell
On Thu, 2011-06-30 at 03:27 -0700, Jose Fonseca wrote: - Original Message - On Thu, 2011-06-30 at 03:36 +0200, Roland Scheidegger wrote: Ok in fact there's a gcc bug about memcmp: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43052 In short gcc's memcmp builtin is totally lame

Re: [Mesa-dev] [PATCH] llvmpipe: Optimize new fs state setup

2011-06-30 Thread Adam Jackson
On Thu, 2011-06-30 at 03:36 +0200, Roland Scheidegger wrote: Ok in fact there's a gcc bug about memcmp: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43052 In short gcc's memcmp builtin is totally lame and loses to glibc's memcmp (including call overhead, no knowledge about alignment etc.) even

Re: [Mesa-dev] [PATCH] llvmpipe: Optimize new fs state setup

2011-06-30 Thread Roland Scheidegger
Am 30.06.2011 12:14, schrieb Jose Fonseca: - Original Message - Hmm. Forgive my ignorance, but isn't memcmp() on structs pretty prone to give incorrect != results, given that there may be padding between members in structs and that IIRC gcc struct assignment is member-wise.

[Mesa-dev] [Bug 37177] Mathematica Plot3D Crash

2011-06-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37177 --- Comment #4 from Ivan Iakoupov vox...@gmail.com 2011-06-30 07:43:07 PDT --- I did a bisect and it worked prior to this commit: commit dea5e57861ec998cb7ee913a8819752cb9fa946b Author: Eric Anholt Date: Mon Feb 14 18:57:49 2011 -0800

Re: [Mesa-dev] [PATCH] r600g: fix check for empty cs

2011-06-30 Thread Vadim Girlin
On Wed, 2011-06-29 at 16:29 +0400, Vadim Girlin wrote: --- There is ~20% fps boost with the etqw timenetdemo after this patch. Btw, it seems that bad performance without that patch is caused by the occlusion queries, so probably they need some fixes too. I've added some counters to check it

Re: [Mesa-dev] [PATCH] llvmpipe: Optimize new fs state setup

2011-06-30 Thread Roland Scheidegger
Am 30.06.2011 16:14, schrieb Adam Jackson: On Thu, 2011-06-30 at 03:36 +0200, Roland Scheidegger wrote: Ok in fact there's a gcc bug about memcmp: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43052 In short gcc's memcmp builtin is totally lame and loses to glibc's memcmp (including call

Re: [Mesa-dev] [PATCH] llvmpipe: Optimize new fs state setup

2011-06-30 Thread Keith Whitwell
On Thu, 2011-06-30 at 17:53 +0200, Roland Scheidegger wrote: Am 30.06.2011 16:14, schrieb Adam Jackson: On Thu, 2011-06-30 at 03:36 +0200, Roland Scheidegger wrote: Ok in fact there's a gcc bug about memcmp: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43052 In short gcc's memcmp builtin

Re: [Mesa-dev] [PATCH 1/3] intel: Recognize GL_DEPTH_COMPONENT32 in get_teximage_readbuffer.

2011-06-30 Thread Eric Anholt
On Thu, 30 Jun 2011 06:28:13 -0600, Brian Paul brian.e.p...@gmail.com wrote: On Thu, Jun 30, 2011 at 12:04 AM, Kenneth Graunke kenn...@whitecape.org wrote: gl_texture_image::InternalFormat is actually the user requested internal format, not what the texture actually is.  Thus, even though

[Mesa-dev] [Bug 38842] New: Various valid GLX attributes are rejected by MESA glxChooseFBConfig

2011-06-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=38842 Summary: Various valid GLX attributes are rejected by MESA glxChooseFBConfig Product: Mesa Version: 7.10 Platform: x86 (IA32) OS/Version: Linux (All) Status: NEW

[Mesa-dev] mesa master: commit 2699fce0d69db5158427c8b6c8194b2eefc5e58b

2011-06-30 Thread Gustaw Smolarczyk
Commit 2699fce0d69db5158427c8b6c8194b2eefc5e58b: The first chunk (/common.py) looks really strange. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 1/2] st/mesa: use the first non-VOID channel in st_format_datatype

2011-06-30 Thread Marek Olšák
Otherwise PIPE_FORMAT_X8B8G8R8_UNORM and friends would fail. NOTE: This is a candidate for the 7.10 and 7.11 branches. --- src/mesa/state_tracker/st_format.c | 19 --- 1 files changed, 16 insertions(+), 3 deletions(-) diff --git a/src/mesa/state_tracker/st_format.c

[Mesa-dev] [PATCH 2/2] st/mesa: handle float formats in st_format_datatype

2011-06-30 Thread Marek Olšák
NOTE: This is a candidate for the 7.11 branch. --- src/mesa/state_tracker/st_format.c | 16 ++-- 1 files changed, 14 insertions(+), 2 deletions(-) diff --git a/src/mesa/state_tracker/st_format.c b/src/mesa/state_tracker/st_format.c index 3260297..d1995f1 100644 ---

[Mesa-dev] [PATCH] i965/gen7: Remove gratuitous dirty flags from WM and PS state.

2011-06-30 Thread Kenneth Graunke
Commit b46dc45ceef3deb17ba2b0b4300eeb93e9cf7833 claimed that NEW_POLYGONSTIPPLE is gratuitous, but somehow just changed comments and whitespace instead of actually removing the flag. While we're at it, 3DSTATE_PS doesn't appear to need NEW_LINE or NEW_POLYGON either (those are in 3DSTATE_WM).

[Mesa-dev] [PATCH 00/13] Floating-point depth buffers

2011-06-30 Thread Marek Olšák
Hi, this patch series implements ARB_depth_buffer_float in Mesa and Gallium. There is complete r600g/r600-r700 support in my private branch, which passes the same tests that pass for Z24S8. Softpipe has only sampler support. This has turned out to be not so trivial, so it's possible I missed

[Mesa-dev] [PATCH 01/13] mesa: initial ARB_depth_buffer_float support

2011-06-30 Thread Marek Olšák
Using GL_NONE as DataType of Z32_FLOAT_X24S8, not sure what I should put there. The spec says the type is n/a. --- src/mesa/main/fbobject.c | 19 +++ src/mesa/main/formats.c | 29 + src/mesa/main/formats.h |3 +++

[Mesa-dev] [PATCH 02/13] mesa: implement texfetch functions for depth_buffer_float

2011-06-30 Thread Marek Olšák
--- src/mesa/main/texfetch.c | 16 src/mesa/main/texfetch_tmp.h | 23 +++ 2 files changed, 31 insertions(+), 8 deletions(-) diff --git a/src/mesa/main/texfetch.c b/src/mesa/main/texfetch.c index 4b85bc3..72283eb 100644 --- a/src/mesa/main/texfetch.c

[Mesa-dev] [PATCH 03/13] mesa: implement stencil unpacking for GL_FLOAT_32_UNSIGNED_INT_24_8_REV

2011-06-30 Thread Marek Olšák
--- src/mesa/main/pack.c | 35 --- 1 files changed, 32 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/pack.c b/src/mesa/main/pack.c index a232a51..c284c7d 100644 --- a/src/mesa/main/pack.c +++ b/src/mesa/main/pack.c @@ -1971,7 +1971,8 @@

[Mesa-dev] [PATCH 04/13] mesa: implement depth unpacking for GL_FLOAT_32_UNSIGNED_INT_24_8_REV

2011-06-30 Thread Marek Olšák
--- src/mesa/main/pack.c | 27 +-- 1 files changed, 25 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/pack.c b/src/mesa/main/pack.c index c284c7d..d42ae7b 100644 --- a/src/mesa/main/pack.c +++ b/src/mesa/main/pack.c @@ -4827,6 +4827,20 @@

[Mesa-dev] [PATCH 05/13] mesa: implement texstore for DEPTH_COMPONENT32F

2011-06-30 Thread Marek Olšák
--- src/mesa/main/texstore.c | 12 +++- 1 files changed, 7 insertions(+), 5 deletions(-) diff --git a/src/mesa/main/texstore.c b/src/mesa/main/texstore.c index f1de31a..cdac214 100644 --- a/src/mesa/main/texstore.c +++ b/src/mesa/main/texstore.c @@ -1002,15 +1002,17 @@

[Mesa-dev] [PATCH 06/13] mesa: implement texstore for DEPTH32F_STENCIL8

2011-06-30 Thread Marek Olšák
--- src/mesa/main/texstore.c | 68 +- 1 files changed, 67 insertions(+), 1 deletions(-) diff --git a/src/mesa/main/texstore.c b/src/mesa/main/texstore.c index cdac214..7e2cafc 100644 --- a/src/mesa/main/texstore.c +++ b/src/mesa/main/texstore.c @@

[Mesa-dev] [PATCH 07/13] mesa: implement generatemipmap for GL_FLOAT_32_UNSIGNED_INT_24_8_REV

2011-06-30 Thread Marek Olšák
--- src/mesa/main/mipmap.c | 20 1 files changed, 20 insertions(+), 0 deletions(-) diff --git a/src/mesa/main/mipmap.c b/src/mesa/main/mipmap.c index f2724db..8a811cb 100644 --- a/src/mesa/main/mipmap.c +++ b/src/mesa/main/mipmap.c @@ -706,6 +706,17 @@ do_row(GLenum

[Mesa-dev] [PATCH 09/13] st/mesa: initial ARB_depth_buffer_float support

2011-06-30 Thread Marek Olšák
--- src/mesa/state_tracker/st_cb_clear.c |6 -- src/mesa/state_tracker/st_extensions.c | 11 +++ src/mesa/state_tracker/st_format.c | 19 +++ 3 files changed, 34 insertions(+), 2 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_clear.c

[Mesa-dev] [PATCH 10/13] st/mesa: implement read/draw/copypixels for Z32F and Z32F_S8X24

2011-06-30 Thread Marek Olšák
--- src/mesa/state_tracker/st_cb_drawpixels.c | 64 + src/mesa/state_tracker/st_cb_readpixels.c | 43 +++ 2 files changed, 98 insertions(+), 9 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_drawpixels.c

[Mesa-dev] [PATCH 11/13] gallium/util: implement pack functions for Z32F and Z32F_S8X24

2011-06-30 Thread Marek Olšák
The suffix of 64 means it returns uint64_t. --- src/gallium/auxiliary/util/u_pack_color.h | 64 + 1 files changed, 64 insertions(+), 0 deletions(-) diff --git a/src/gallium/auxiliary/util/u_pack_color.h b/src/gallium/auxiliary/util/u_pack_color.h index

[Mesa-dev] [PATCH 12/13] gallium/util: implement software Z32F_S8X24 depth-stencil clear

2011-06-30 Thread Marek Olšák
--- src/gallium/auxiliary/util/u_surface.c | 35 +++- 1 files changed, 34 insertions(+), 1 deletions(-) diff --git a/src/gallium/auxiliary/util/u_surface.c b/src/gallium/auxiliary/util/u_surface.c index 4c5cc4d..8fcf6b9 100644 ---

[Mesa-dev] [PATCH 13/13] gallium/util: handle Z32F_FLOAT_S8X24_USCALED in pipe_tile_raw_to_rgba

2011-06-30 Thread Marek Olšák
And make pipe_put_tile_rgba_format no-op like the other Z formats. --- src/gallium/auxiliary/util/u_tile.c | 35 +++ 1 files changed, 35 insertions(+), 0 deletions(-) diff --git a/src/gallium/auxiliary/util/u_tile.c b/src/gallium/auxiliary/util/u_tile.c index

[Mesa-dev] [PATCH 08/13] mesa: implement depth/stencil renderbuffer wrapper accessors for Z32F_X24S8

2011-06-30 Thread Marek Olšák
--- src/mesa/main/depthstencil.c | 322 +++--- src/mesa/main/depthstencil.h |5 + src/mesa/main/framebuffer.c | 10 +- 3 files changed, 313 insertions(+), 24 deletions(-) diff --git a/src/mesa/main/depthstencil.c b/src/mesa/main/depthstencil.c index

[Mesa-dev] [Bug 5002] indirect rendering of glDrawArrays() to an NVidia machine is broke.

2011-06-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=5002 Trevor Forbes t...@internode.on.net changed: What|Removed |Added CC|

Re: [Mesa-dev] [PATCH 08/13] mesa: implement depth/stencil renderbuffer wrapper accessors for Z32F_X24S8

2011-06-30 Thread Kenneth Graunke
On 06/30/2011 05:29 PM, Marek Olšák wrote: --- src/mesa/main/depthstencil.c | 322 +++--- src/mesa/main/depthstencil.h |5 + src/mesa/main/framebuffer.c | 10 +- 3 files changed, 313 insertions(+), 24 deletions(-) diff --git

[Mesa-dev] [Bug 37177] Mathematica Plot3D Crash

2011-06-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37177 Jason Tibbitts ti...@math.uh.edu changed: What|Removed |Added CC||ti...@math.uh.edu --

Re: [Mesa-dev] [PATCH 00/13] Floating-point depth buffers

2011-06-30 Thread Kenneth Graunke
On 06/30/2011 05:29 PM, Marek Olšák wrote: Hi, this patch series implements ARB_depth_buffer_float in Mesa and Gallium. There is complete r600g/r600-r700 support in my private branch, which passes the same tests that pass for Z24S8. Softpipe has only sampler support. This has turned out

[Mesa-dev] [Bug 5002] indirect rendering of glDrawArrays() to an NVidia machine is broke.

2011-06-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=5002 --- Comment #8 from Trevor Forbes t...@internode.on.net 2011-06-30 21:39:59 PDT --- I also keep running into this problem with workstations running NVIDIA drivers 180. Try running Googleearth from a remote server for example.. Some people are