Re: [Mesa-dev] [PATCH 2/2] mesa: add hard limits for the number of varyings and uniforms for the linker

2011-11-24 Thread Marek Olšák
On Wed, Nov 23, 2011 at 7:25 PM, Ian Romanick i...@freedesktop.org wrote: Let me paraphrase this a little bit in a way that I think concisely captures the intention:    We need to work really hard to make things work on older hardware. I don't think anyone disagrees with that.  However, the

Re: [Mesa-dev] [PATCH 2/2] mesa: add hard limits for the number of varyings and uniforms for the linker

2011-11-24 Thread Dave Airlie
By this same logic, malloc should never return NULL because most apps can't handle it.  Instead it should mmap /dev/null and return a pointer to that.  That analogy isn't as far off as it may seem:  in both cases the underlying infrastructure has lied to the application that an operation

Re: [Mesa-dev] [PATCH 2/2] mesa: add hard limits for the number of varyings and uniforms for the linker

2011-11-24 Thread Alan Coopersmith
On 11/24/11 05:25, Dave Airlie wrote: On UNIX malloc generally hasn't returned NULL since overcommit was invented, what happens now is some time in the future you attempt to use a page and your app dies. s/UNIX/Linux/ - other Unixes still prefer reliability over random OOM crashes. --

Re: [Mesa-dev] [Piglit] [PATCH] Add a simple testcase to test that GL_ELEMENT_ARRAY_BUFFER is per vao

2011-11-24 Thread Eric Anholt
On Wed, 23 Nov 2011 12:24:37 -0700, Brian Paul bri...@vmware.com wrote: On 11/23/2011 12:12 PM, Eric Anholt wrote: On Wed, 23 Nov 2011 17:34:30 +0800, Yuanhan Liuyuanhan@linux.intel.com wrote: From 9a1da8748f0faa23f34398213ff7ee45fda6bf36 Mon Sep 17 00:00:00 2001 From: Yuanhan

Re: [Mesa-dev] [PATCH] mesa: fix frag shader generation for alpha test with no color buffers

2011-11-24 Thread Eric Anholt
On Wed, 23 Nov 2011 15:08:23 -0800, Ian Romanick i...@freedesktop.org wrote: On 11/23/2011 02:35 PM, Brian Paul wrote: If alpha test is enabled and there's no color buffers we still need the fragment shader to emit a color. Fixes piglit fbo-alphatest-nocolor-ff failures with Gallium

Re: [Mesa-dev] [PATCH 2/2] mesa: add hard limits for the number of varyings and uniforms for the linker

2011-11-24 Thread Kenneth Graunke
On 11/24/2011 04:47 AM, Marek Olšák wrote: On Wed, Nov 23, 2011 at 7:25 PM, Ian Romanick i...@freedesktop.org wrote: Let me paraphrase this a little bit in a way that I think concisely captures the intention: We need to work really hard to make things work on older hardware. I don't

Re: [Mesa-dev] [PATCH] mesa: check for null ptr in _mesa_is_bufferobj()

2011-11-24 Thread Kenneth Graunke
On 11/23/2011 02:35 PM, Brian Paul wrote: This simplifies a few callers. And it adds a bit of robustness. --- src/mesa/main/bufferobj.c|6 +++--- src/mesa/main/bufferobj.h|2 +- src/mesa/state_tracker/st_draw.c | 10 +- 3 files changed, 9 insertions(+), 9

[Mesa-dev] [PATCH] mesa: add MESA_FORMAT_RGBX8888 and MESA_FORMAT_RGBX8888_REV

2011-11-24 Thread Chia-I Wu
From: Chia-I Wu o...@lunarg.com MESA_FORMAT_RGBX_REV is one of the opaque pixel formats used on Android. Thanks to texture-from-pixmap, drivers may actually see texture images with this format on Android. MESA_FORMAT_RGBX is added only for completeness. --- src/mesa/main/format_unpack.c