[Mesa-dev] [PATCH] util: Move dereference after null check in util_resource_copy_region.

2012-08-03 Thread Vinson Lee
Fixes deference before null check defect reported by Coverity. Signed-off-by: Vinson Lee --- src/gallium/auxiliary/util/u_surface.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gallium/auxiliary/util/u_surface.c b/src/gallium/auxiliary/util/u_surface.c index a54

Re: [Mesa-dev] [PATCH 3/5] egl_dri2: Refactor dereference of dri2_ctx_shared

2012-08-03 Thread Kristian Høgsberg
On Fri, Aug 3, 2012 at 2:58 PM, Chad Versace wrote: > On 08/01/2012 05:21 PM, Ian Romanick wrote: >> From: Ian Romanick >> >> Signed-off-by: Ian Romanick >> Cc: Kristian Høgsberg >> Cc: Matt Turner >> --- >> src/egl/drivers/dri2/egl_dri2.c | 11 +-- >> 1 files changed, 5 insertions(

[Mesa-dev] [Bug 52167] llvmpipe test programs link fails when ld --as-needed option is used

2012-08-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=52167 --- Comment #4 from Olivier Blin 2012-08-03 22:44:42 UTC --- Created attachment 65103 --> https://bugs.freedesktop.org/attachment.cgi?id=65103 gallium: only link static archives between ld start/end group options The attached patch fixes the

[Mesa-dev] [Bug 52167] llvmpipe test programs link fails when ld --as-needed option is used

2012-08-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=52167 --- Comment #3 from Olivier Blin 2012-08-03 22:13:24 UTC --- Actually, only static archives should be listed between the --start-group and --end-group options. We should list static archives and dynamic libraries in different variables, like don

Re: [Mesa-dev] [PATCH 1/5] dri2: Fix bug in attribute handling for non-desktop OpenGL contexts

2012-08-03 Thread Matt Turner
Series is Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 5/5] egl: Import eglext.h version 14

2012-08-03 Thread Chad Versace
On 08/01/2012 05:21 PM, Ian Romanick wrote: > From: Ian Romanick > > This is necessary for EGL_KHR_create_context work (including writing > piglit tests). > > Signed-off-by: Ian Romanick > Cc: Matt Turner > --- > include/EGL/eglext.h | 157 > +

Re: [Mesa-dev] [PATCH 1/5] dri2: Fix bug in attribute handling for non-desktop OpenGL contexts

2012-08-03 Thread Chad Versace
On 08/01/2012 05:21 PM, Ian Romanick wrote: > From: Ian Romanick > > Previously an error would be generated if any attributes were specified when > creating a non-desktop OpenGL context. This was a mistake, and it will > prevent old drivers from working with new EGL libraries that add support fo

Re: [Mesa-dev] [PATCH 3/5] egl_dri2: Refactor dereference of dri2_ctx_shared

2012-08-03 Thread Chad Versace
On 08/01/2012 05:21 PM, Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick > Cc: Kristian Høgsberg > Cc: Matt Turner > --- > src/egl/drivers/dri2/egl_dri2.c | 11 +-- > 1 files changed, 5 insertions(+), 6 deletions(-) Personally, I prefer the const. Anway, wit

Re: [Mesa-dev] [PATCH 2/5] egl_dri2: Remove swrast version >= 2 checks

2012-08-03 Thread Chad Versace
On 08/01/2012 05:21 PM, Ian Romanick wrote: > From: Ian Romanick > > Since support for swrast version 2 was added (f55d027a), it has also been > required. In swrast_driver_extensions, version 2 is set for __DRI_SWRAST > extension. Remove the spurious version checks sprinked through the code. >

Re: [Mesa-dev] [PATCH 7/7] Make shared-glapi the default

2012-08-03 Thread Chad Versace
On 08/01/2012 05:07 PM, Ian Romanick wrote: > From: Ian Romanick > > You can't practically have desktop OpenGL and OpenGL ES on the same system > without this. The benefits of not having it (e.g., a more compact dispatch > table) are irrelevant. > > Signed-off-by: Ian Romanick > --- > configu

Re: [Mesa-dev] [PATCH 1/2] winsys/radeon: fix VA allocation

2012-08-03 Thread Jerome Glisse
On Fri, Aug 3, 2012 at 11:06 AM, Christian König wrote: > Wait for VA use to end before reusing it. > > Should fix: https://bugs.freedesktop.org/show_bug.cgi?id=45018 > > Signed-off-by: Christian König Actually you right mesa can't free right away va, it needs to wait kernel is done. But kernel

Re: [Mesa-dev] [PATCH 1/2] winsys/radeon: fix VA allocation

2012-08-03 Thread Jerome Glisse
On Fri, Aug 3, 2012 at 11:06 AM, Christian König wrote: > Wait for VA use to end before reusing it. > > Should fix: https://bugs.freedesktop.org/show_bug.cgi?id=45018 > > Signed-off-by: Christian König > --- > src/gallium/winsys/radeon/drm/radeon_drm_bo.c | 64 > + > 1

[Mesa-dev] [PATCH] r600g: atomize sampler state v2

2012-08-03 Thread j . glisse
From: Jerome Glisse Use atom for sampler state. Does not provide new functionality or fix any bug. Just a step toward full atom base r600g. v2: Split seamless on r6xx/r7xx into it's own atom. Make sure it's emited after sampler and with a pipeline flush before otherwise it does not take

Re: [Mesa-dev] [PATCH 2/2] radeonsi: fix memory leak and/or segfaults

2012-08-03 Thread Alex Deucher
On Fri, Aug 3, 2012 at 11:06 AM, Christian König wrote: > Fix a stupid typo that could lead to memory > leaks and/or segfaults. > > Signed-off-by: Christian König Reviewed-by: Alex Deucher > --- > src/gallium/drivers/radeonsi/radeonsi_pm4.c |2 +- > 1 file changed, 1 insertion(+), 1 delet

Re: [Mesa-dev] [PATCH 1/2] winsys/radeon: fix VA allocation

2012-08-03 Thread Marek Olšák
FYI, you can find my reply to this patch in the bug report. Marek On Fri, Aug 3, 2012 at 5:06 PM, Christian König wrote: > Wait for VA use to end before reusing it. > > Should fix: https://bugs.freedesktop.org/show_bug.cgi?id=45018 > > Signed-off-by: Christian König > --- > src/gallium/winsys/

[Mesa-dev] [PATCH 2/2] radeonsi: fix memory leak and/or segfaults

2012-08-03 Thread Christian König
Fix a stupid typo that could lead to memory leaks and/or segfaults. Signed-off-by: Christian König --- src/gallium/drivers/radeonsi/radeonsi_pm4.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/radeonsi_pm4.c b/src/gallium/drivers/radeonsi/ra

[Mesa-dev] [PATCH 1/2] winsys/radeon: fix VA allocation

2012-08-03 Thread Christian König
Wait for VA use to end before reusing it. Should fix: https://bugs.freedesktop.org/show_bug.cgi?id=45018 Signed-off-by: Christian König --- src/gallium/winsys/radeon/drm/radeon_drm_bo.c | 64 + 1 file changed, 43 insertions(+), 21 deletions(-) diff --git a/src/gallium

[Mesa-dev] [PATCH 6/6] st/mesa: add sampler/texture support for geometry shaders

2012-08-03 Thread Brian Paul
--- src/mesa/state_tracker/st_atom_sampler.c |2 -- src/mesa/state_tracker/st_atom_texture.c | 24 src/mesa/state_tracker/st_context.c |5 + src/mesa/state_tracker/st_context.h |8 ++-- 4 files changed, 35 insertions(+), 4 deletions(-) diff

[Mesa-dev] [PATCH 5/6] st/mesa: merge fragment/vertex sampler update code

2012-08-03 Thread Brian Paul
--- src/mesa/state_tracker/st_atom_sampler.c | 109 +++--- 1 files changed, 54 insertions(+), 55 deletions(-) diff --git a/src/mesa/state_tracker/st_atom_sampler.c b/src/mesa/state_tracker/st_atom_sampler.c index c219b21..8dc45fd 100644 --- a/src/mesa/state_tracker/st_at

[Mesa-dev] [PATCH 4/6] st/mesa: massage update_vertex_samplers() code

2012-08-03 Thread Brian Paul
...to look like the update_fragment_samplers() code, as with the previous commit. The next step will be to merge the two functions. --- src/mesa/state_tracker/st_atom_sampler.c | 36 - 1 files changed, 20 insertions(+), 16 deletions(-) diff --git a/src/mesa/state_tr

[Mesa-dev] [PATCH 3/6] st/mesa: merge fragment/vertex texture update code

2012-08-03 Thread Brian Paul
--- src/mesa/state_tracker/st_atom_texture.c | 100 +- 1 files changed, 42 insertions(+), 58 deletions(-) diff --git a/src/mesa/state_tracker/st_atom_texture.c b/src/mesa/state_tracker/st_atom_texture.c index b35f470..e88675d 100644 --- a/src/mesa/state_tracker/st_at

[Mesa-dev] [PATCH 2/6] st/mesa: massage the update_vertex_textures() code

2012-08-03 Thread Brian Paul
...to look like the update_fragment_textures() code. The next step will be to merge the two functions. --- src/mesa/state_tracker/st_atom_texture.c | 18 ++ 1 files changed, 14 insertions(+), 4 deletions(-) diff --git a/src/mesa/state_tracker/st_atom_texture.c b/src/mesa/state

[Mesa-dev] [PATCH 1/6] st/mesa: rename some vertex/fragment state fields for better consistency

2012-08-03 Thread Brian Paul
--- src/mesa/state_tracker/st_atom_sampler.c |8 src/mesa/state_tracker/st_atom_texture.c | 17 + src/mesa/state_tracker/st_cb_bitmap.c| 12 +++- src/mesa/state_tracker/st_context.c | 10 -- src/mesa/state_tracker/st_context.h | 12

Re: [Mesa-dev] [PATCH] draw: Ensure channel in convert_to_soa is initialized.

2012-08-03 Thread Brian Paul
On 08/02/2012 11:47 PM, Vinson Lee wrote: Fixes uninitialized pointer read defect reported by Coverity. Signed-off-by: Vinson Lee --- src/gallium/auxiliary/draw/draw_llvm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/draw/draw_llvm.c b/src/galliu

Re: [Mesa-dev] [PATCH] u_blitter: Move a pointer dereference after null check.

2012-08-03 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Fri, Aug 3, 2012 at 8:35 AM, Vinson Lee wrote: > Fixes dereference before null check defect reported by Coverity. > > Signed-off-by: Vinson Lee > --- > src/gallium/auxiliary/util/u_blitter.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > dif

Re: [Mesa-dev] [BUG]: calloc (nmemb=1, size=0)

2012-08-03 Thread Lucas Stach
Am Freitag, den 03.08.2012, 07:57 +0200 schrieb Johann Klammer: > Hello, > > I tried to replace the memory allocator for a program > linked against mesa. With the libc allocators the app shows some > textured and shaded triangles, but with the custom allocators, it's all > black triangles. Sorry

Re: [Mesa-dev] [PATCH 00/16 v2] i965: Enable winsys MSAA on gen >= 6

2012-08-03 Thread Tapani Pälli
Hello; On 08/03/2012 04:39 AM, Chad Versace wrote: > For test results, see the commit message in patch 16. The summary is that > piglit, oglconform, and xonotic are all happy. It was nice to play xonotic > without seeing ugly, jagged edges. > > Many of these patches have already been reviewed. I'

[Mesa-dev] [PATCH] u_blitter: Move a pointer dereference after null check.

2012-08-03 Thread Vinson Lee
Fixes dereference before null check defect reported by Coverity. Signed-off-by: Vinson Lee --- src/gallium/auxiliary/util/u_blitter.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/gallium/auxiliary/util/u_blitter.c b/src/gallium/auxiliary/util/u_blitter.c index b3

[Mesa-dev] [BUG]: calloc (nmemb=1, size=0)

2012-08-03 Thread Johann Klammer
Hello, I tried to replace the memory allocator for a program linked against mesa. With the libc allocators the app shows some textured and shaded triangles, but with the custom allocators, it's all black triangles. Sorry, I cannot post the program source as it is rather large, but will try to

[Mesa-dev] [PATCH] draw: Ensure channel in convert_to_soa is initialized.

2012-08-03 Thread Vinson Lee
Fixes uninitialized pointer read defect reported by Coverity. Signed-off-by: Vinson Lee --- src/gallium/auxiliary/draw/draw_llvm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/draw/draw_llvm.c b/src/gallium/auxiliary/draw/draw_llvm.c index 8d9b530..3