Re: [Mesa-dev] [PATCH] gallivm: fix srgb format fetch

2012-12-01 Thread Brian Paul
On Sat, Dec 1, 2012 at 9:04 AM, wrote: > From: Roland Scheidegger > > we need to rely on util code for fetching those, just like before > 9f06061d50f90bf425a5337cea1b0adb94a46d25. > Fixes bugs 57699 and 57756. > --- > src/gallium/auxiliary/gallivm/lp_bld_format_aos.c |3 ++- > 1 file change

Re: [Mesa-dev] [PATCH] mesa: remove warning message in _mesa_reference_renderbuffer_()

2012-12-01 Thread Brian Paul
On Sat, Dec 1, 2012 at 1:43 PM, Ian Romanick wrote: > On 12/01/2012 09:56 AM, Brian Paul wrote: >> >> From: Brian Paul >> >> We were warning when there was no current context and we're about >> to delete a renderbuffer, but that happens fairly often and isn't >> really a problem. >> >> Fixes http

Re: [Mesa-dev] [PATCH] mesa: Use _mesa_lookup_enum_by_nr in tex*_error_check

2012-12-01 Thread Kenneth Graunke
On 11/30/2012 11:55 AM, Brian Paul wrote: On 11/30/2012 12:26 PM, Matt Turner wrote: --- src/mesa/main/teximage.c |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index 347b3e2..6401824 100644 --- a/src/mesa/m

Re: [Mesa-dev] [PATCH] mesa: remove warning message in _mesa_reference_renderbuffer_()

2012-12-01 Thread Ian Romanick
On 12/01/2012 09:56 AM, Brian Paul wrote: From: Brian Paul We were warning when there was no current context and we're about to delete a renderbuffer, but that happens fairly often and isn't really a problem. Fixes http://bugs.freedesktop.org/show_bug.cgi?id=57754 I'm really confused. A pre

Re: [Mesa-dev] [PATCH 1/2] mesa: Only require Gen'ed name for glBindFramebuffer on desktop

2012-12-01 Thread Kenneth Graunke
On 12/01/2012 11:10 AM, Ian Romanick wrote: From: Ian Romanick Desktop OpenGL implementations that support either GL_ARB_framebuffer_object or OpenGL 3.0 must require names from glGenFramebuffers for glBindFramebuffer. We have enforced this rule for quite some time. However, OpenGL ES 1.0, 2.

Re: [Mesa-dev] [PATCH 09/26] glsl: parse GLSL ES 3.00 keywords correctly.

2012-12-01 Thread Kenneth Graunke
On 12/01/2012 11:40 AM, Ian Romanick wrote: On 11/30/2012 03:47 PM, Kenneth Graunke wrote: On 11/30/2012 10:07 AM, Ian Romanick wrote: From: Paul Berry GLSL ES 3.00 adds the following keywords over GLSL 1.00: uint, uvec[2-4], matNxM, centroid, flat, smooth, various samplers, layout, switch, d

Re: [Mesa-dev] [PATCH 09/26] glsl: parse GLSL ES 3.00 keywords correctly.

2012-12-01 Thread Ian Romanick
On 11/30/2012 03:47 PM, Kenneth Graunke wrote: On 11/30/2012 10:07 AM, Ian Romanick wrote: From: Paul Berry GLSL ES 3.00 adds the following keywords over GLSL 1.00: uint, uvec[2-4], matNxM, centroid, flat, smooth, various samplers, layout, switch, default, and case. Additionally, it reserves

Re: [Mesa-dev] [PATCH 01/26] mesa: Add ARB_ES3_compatibility flag.

2012-12-01 Thread Ian Romanick
On 11/30/2012 01:39 PM, Paul Berry wrote: On 30 November 2012 12:11, Ian Romanick mailto:i...@freedesktop.org>> wrote: This represents a rebase of the gles3 branch that moves the completed GLSL to be first. I'd like to get these bits merged to master sooner rather than later. Once

[Mesa-dev] [PATCH 2/2] intel: Always enable GL_ARB_framebuffer_object

2012-12-01 Thread Ian Romanick
From: Ian Romanick Now that _mesa_BindFramebuffer does the right thing in ES contexts when the gl_extensions::ARB_framebuffer_object bit is set, the Intel driver doesn't need this hack. No piglit or GLES2 conformance regressions observed on IVB. Signed-off-by: Ian Romanick Cc: Chad Versace Cc

[Mesa-dev] [PATCH 1/2] mesa: Only require Gen'ed name for glBindFramebuffer on desktop

2012-12-01 Thread Ian Romanick
From: Ian Romanick Desktop OpenGL implementations that support either GL_ARB_framebuffer_object or OpenGL 3.0 must require names from glGenFramebuffers for glBindFramebuffer. We have enforced this rule for quite some time. However, OpenGL ES 1.0, 2.0, and 3.0 implementations are required to all

[Mesa-dev] [PATCH] mesa: remove warning message in _mesa_reference_renderbuffer_()

2012-12-01 Thread Brian Paul
From: Brian Paul We were warning when there was no current context and we're about to delete a renderbuffer, but that happens fairly often and isn't really a problem. Fixes http://bugs.freedesktop.org/show_bug.cgi?id=57754 --- src/mesa/main/renderbuffer.c |5 + 1 files changed, 1 insert

[Mesa-dev] [PATCH] gallivm: fix srgb format fetch

2012-12-01 Thread sroland
From: Roland Scheidegger we need to rely on util code for fetching those, just like before 9f06061d50f90bf425a5337cea1b0adb94a46d25. Fixes bugs 57699 and 57756. --- src/gallium/auxiliary/gallivm/lp_bld_format_aos.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gall

Re: [Mesa-dev] [PATCH 01/26] mesa: Add ARB_ES3_compatibility flag.

2012-12-01 Thread Kenneth Graunke
I've run out of time for now, so... Patches 1-8, 10-14 are: Reviewed-by: Kenneth Graunke I'll try and finish reviewing these in the next few days. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/m

Re: [Mesa-dev] [PATCH 09/26] glsl: parse GLSL ES 3.00 keywords correctly.

2012-12-01 Thread Kenneth Graunke
On 11/30/2012 10:07 AM, Ian Romanick wrote: From: Paul Berry GLSL ES 3.00 adds the following keywords over GLSL 1.00: uint, uvec[2-4], matNxM, centroid, flat, smooth, various samplers, layout, switch, default, and case. Additionally, it reserves a large number of keywords, some of which were a

Re: [Mesa-dev] leak in loop_analysis

2012-12-01 Thread Dave Airlie
On Sat, Dec 1, 2012 at 4:18 AM, Ian Romanick wrote: > On 11/30/2012 02:20 AM, Dave Airlie wrote: >> >> Coverity pointed out >> src/glsl/loop_analysis.cpp >> >> loop_analysis::loop_analysis() >> { >> this->loops = new loop_state; >> >> >> This loops is never freed anywhere, probably need a dest

Re: [Mesa-dev] [PATCH 23/26] glsl: add determinant() functions.

2012-12-01 Thread Kenneth Graunke
On 11/30/2012 10:07 AM, Ian Romanick wrote: From: Paul Berry These functions are defined in GLSL 1.50 and GLES 3.00 ES. The formulas have been extracted from the existing implementation of inverse(). Reviewed-by: Ian Romanick --- src/glsl/builtins/glsl/determinant.glsl | 70 +++

[Mesa-dev] [Bug 57746] build test failure: nouveau_fbo.c:198:3: error: too few arguments to function 'nouveau_renderbuffer_del'

2012-12-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=57746 Darxus changed: What|Removed |Added Status|RESOLVED|VERIFIED --- Comment #3 from Darxus --- Verifi

Re: [Mesa-dev] [PATCH 1/2] mesa: Return INVALID_OPERATION when type is known but not allowed

2012-12-01 Thread Kenneth Graunke
On 11/30/2012 03:13 PM, Matt Turner wrote: INVALID_ENUM is for when the type is simply not known. Fixes part of es3conform's packed_depth_stencil_error test. --- src/mesa/main/glformats.c | 12 +++- 1 files changed, 11 insertions(+), 1 deletions(-) diff --git a/src/mesa/main/glform

[Mesa-dev] [Bug 57754] New: [swrast] Mesa 9.1-devel implementation error: Unable to delete renderbuffer, no context

2012-12-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=57754 Priority: medium Bug ID: 57754 CC: bri...@vmware.com Assignee: mesa-dev@lists.freedesktop.org Summary: [swrast] Mesa 9.1-devel implementation error: Unable to delete re

[Mesa-dev] [Bug 57755] New: [llvmpipe] src/gallium/auxiliary/gallivm/lp_bld_arit.c:1051:lp_build_lerp: Assertion `!type.sign' failed.

2012-12-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=57755 Priority: medium Bug ID: 57755 CC: jfons...@vmware.com Assignee: mesa-dev@lists.freedesktop.org Summary: [llvmpipe] src/gallium/auxiliary/gallivm/lp_bld_arit.c:1051:lp_

Re: [Mesa-dev] [PATCH 18/26] glsl: Fix linker checks for GLSL ES 3.00.

2012-12-01 Thread Kenneth Graunke
On 11/30/2012 10:07 AM, Ian Romanick wrote: From: Paul Berry This patch updates the following linker checks to do the right thing in GLSL 3.00 ES: - Failing to write to gl_Position is allowed in GLSL 1.40+ as well as GLSL 3.00 ES. - It is an error to write to both gl_ClipVertex and gl_Clip

[Mesa-dev] [Bug 57746] build test failure: nouveau_fbo.c:198:3: error: too few arguments to function 'nouveau_renderbuffer_del'

2012-12-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=57746 --- Comment #1 from Brian Paul --- Can you try this patch: diff --git a/src/mesa/drivers/dri/nouveau/nouveau_fbo.c b/src/mesa/drivers/dri/no index c47bce8..156b4a3 100644 --- a/src/mesa/drivers/dri/nouveau/nouveau_fbo.c +++ b/src/mesa/drivers/d

Re: [Mesa-dev] [PATCH 16/26] glsl: Clean up shading language mixing check for GLSL 3.00 ES.

2012-12-01 Thread Kenneth Graunke
On 11/30/2012 10:07 AM, Ian Romanick wrote: From: Paul Berry Previously, we prohibited mixing of shading language versions if min_version == 100 or max_version >= 130. This was technically correct (since desktop GLSL 1.30 and beyond prohibit mixing of shading language versions, as does GLSL 1.

[Mesa-dev] [Bug 57756] New: [llvmpipe] piglit arb_sampler_objects-srgb-decode regression

2012-12-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=57756 Priority: medium Bug ID: 57756 CC: jfons...@vmware.com Assignee: mesa-dev@lists.freedesktop.org Summary: [llvmpipe] piglit arb_sampler_objects-srgb-decode regression

Re: [Mesa-dev] [PATCH 2/4] glx/dri2: add and use new driver hook flush_with_flags

2012-12-01 Thread Marek Olšák
On Fri, Nov 30, 2012 at 11:40 PM, Eric Anholt wrote: > The mixing of the factoring out of the protocol bits with the flush > change in this commit is irritating, but I'm fine with the overall flush Ah, sorry, I based it on my previous series and didn't notice it was superfluous. > interface of t

Re: [Mesa-dev] Proposal: allow hidden security bugs on Mesa's Bugzilla

2012-12-01 Thread Brian Paul
On 11/30/2012 01:16 PM, Benoit Jacob wrote: On 12-11-30 12:13 PM, Jerome Glisse wrote: On Fri, Nov 30, 2012 at 7:43 AM, Benoit Jacob wrote: On 12-11-23 02:21 PM, Benoit Jacob wrote: On 12-11-21 12:48 PM, Chad Versace wrote: On 11/20/2012 09:29 AM, Benoit Jacob wrote: Any questions? Do you

[Mesa-dev] [Bug 57746] build test failure: nouveau_fbo.c:198:3: error: too few arguments to function 'nouveau_renderbuffer_del'

2012-12-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=57746 Vinson Lee changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH] gallivm: drop border wrap clamping code

2012-12-01 Thread Brian Paul
On 11/30/2012 12:49 PM, srol...@vmware.com wrote: From: Roland Scheidegger The border clamping code is unnecessary, since we don't care if a wrapped coord value is -1 or<-1 (same for length vs.>length), in either case the border handling code will mask out the offset and replace the texel value

Re: [Mesa-dev] Proposal: allow hidden security bugs on Mesa's Bugzilla

2012-12-01 Thread Benoit Jacob
On 12-11-30 06:46 PM, Brian Paul wrote: > On 11/30/2012 01:16 PM, Benoit Jacob wrote: >> On 12-11-30 12:13 PM, Jerome Glisse wrote: >>> On Fri, Nov 30, 2012 at 7:43 AM, Benoit Jacob >>> wrote: On 12-11-23 02:21 PM, Benoit Jacob wrote: > On 12-11-21 12:48 PM, Chad Versace wrote: >> On

Re: [Mesa-dev] [PATCH 17/26] glsl: Record in gl_shader_program whether the program uses GLSL ES.

2012-12-01 Thread Kenneth Graunke
On 11/30/2012 03:20 PM, Eric Anholt wrote: Ian Romanick writes: From: Paul Berry Previously we recorded just the GLSL version (or the max version, if GLSL 1.10 and GLSL 1.20 programs were linked together). Reviewed-by: Ian Romanick --- src/glsl/linker.cpp| 1 + src/mesa/main/mtypes.

Re: [Mesa-dev] [PATCH] glcpp: Rewrite line-continuation support to act globally.

2012-12-01 Thread Kenneth Graunke
On 11/30/2012 03:20 PM, Carl Worth wrote: Kenneth Graunke writes: Other than than, looks good to me...thanks Carl! Reviewed-by: Kenneth Graunke Thanks, Ken. Pushed now. Someday we may want to use ralloc's rewrite_tail functions to avoid the extra strlen() overhead. But that can be done s