[Mesa-dev] [Bug 65173] segfault in _mesa_get_format_datatype and _mesa_get_color_read_type when state dumping with glretrace

2013-05-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=65173 --- Comment #11 from José Fonseca --- (In reply to comment #10) > >What does nVidia proprietary driver return for > >IMPLEMENTATION_COLOR_READ_{FORMAT,TYPE} on that call? That is, what is the > >output of > > glretrace -D 137078 wine-preloader.

Re: [Mesa-dev] [v6 2/9] intel: do not create renderbuffers out of planar images

2013-05-30 Thread Daniel Vetter
On Thu, May 30, 2013 at 9:49 AM, Pohjolainen, Topi wrote: > On Tue, May 28, 2013 at 01:33:18PM -0700, Eric Anholt wrote: >> Topi Pohjolainen writes: >> >> > Signed-off-by: Topi Pohjolainen >> > --- >> > src/mesa/drivers/dri/intel/intel_fbo.c | 4 >> > 1 file changed, 4 insertions(+) >> > >

Re: [Mesa-dev] [PATCH] intel: Fix copying of separate stencil data in glCopyTexSubImage().

2013-05-30 Thread Jordan Justen
On Thu, May 30, 2013 at 3:47 PM, Eric Anholt wrote: > We were copying the source stencil data onto the destination depth data. > > Fixes piglit copyteximage other than 1D_ARRAY. > --- > src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 10 -- > 1 file changed, 8 insertions(+), 2 deletions(-)

[Mesa-dev] [PATCH] intel: Fix copying of separate stencil data in glCopyTexSubImage().

2013-05-30 Thread Eric Anholt
We were copying the source stencil data onto the destination depth data. Fixes piglit copyteximage other than 1D_ARRAY. --- src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_blorp_blit.cpp b/s

[Mesa-dev] [Bug 65173] segfault in _mesa_get_format_datatype and _mesa_get_color_read_type when state dumping with glretrace

2013-05-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=65173 --- Comment #10 from Vedran Rodic --- >What does nVidia proprietary driver return for >IMPLEMENTATION_COLOR_READ_{FORMAT,TYPE} on that call? That is, what is the >output of > glretrace -D 137078 wine-preloader.137078.trim.trace | grep >IMPLEME

[Mesa-dev] [Bug 65173] segfault in _mesa_get_format_datatype and _mesa_get_color_read_type when state dumping with glretrace

2013-05-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=65173 --- Comment #9 from José Fonseca --- (In reply to comment #8) > Created attachment 80070 [details] > fix-v2 > > I'm happier with this new version of the patch, I'm afraid that version 2 assumes C99 and will break MSVC. > but I'm still not sur

[Mesa-dev] [Bug 65173] segfault in _mesa_get_format_datatype and _mesa_get_color_read_type when state dumping with glretrace

2013-05-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=65173 Vedran Rodic changed: What|Removed |Added Attachment #80036|0 |1 is obsolete|

[Mesa-dev] [Bug 60518] glDrawElements segfault when compiled into display list

2013-05-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=60518 --- Comment #7 from José Fonseca --- I suspect the problem are these lines in setup_glsl_generate_mipmap(): _mesa_BindAttribLocation(mipmap->ShaderProg, 0, "position"); _mesa_BindAttribLocation(mipmap->ShaderProg, 1, "texcoords"); _mesa

[Mesa-dev] [Bug 60518] glDrawElements segfault when compiled into display list

2013-05-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=60518 --- Comment #6 from José Fonseca --- Sounds like the glGenerateMipmap implementation (likely Meta module) is clobbering the GL_VERTEX_ATTRIB_ARRAY_ENABLED* state. > The two calls to glVertexAttribPointer are not done by the application btw. > I

[Mesa-dev] [Bug 65173] segfault in _mesa_get_format_datatype and _mesa_get_color_read_type when state dumping with glretrace

2013-05-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=65173 --- Comment #7 from José Fonseca --- (In reply to comment #6) > Hmm, could we get another person (Jose?) to try this too? Yep, it happens here too. ctx->ReadBuffer->_ColorReadBuffer is NULL in _mesa_get_color_read_type. This is the full stack ba

Re: [Mesa-dev] [PATCH 2/2] meta: Fix temporary image type for float depth/stencil.

2013-05-30 Thread Chad Versace
On 05/30/2013 12:16 PM, Eric Anholt wrote: Fixes assertion failure in piglit copyteximage. --- src/mesa/drivers/common/meta.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) Reviewed-by: Chad Versace ___ mesa-dev mailing

Re: [Mesa-dev] [PATCH 1/2] intel: Fix performance regression from miptree blit changes.

2013-05-30 Thread Chad Versace
On 05/30/2013 12:16 PM, Eric Anholt wrote: When making v2 of da2880bea05bfc87109477ab026a7f5401fc8f0c, I carefully checked all of the calls in that commit to see that I'd updated them, but forgot to update the new calls in the later commits such as .e845c5cf7abce55759501a473459aff3bf25c9ca. As a

[Mesa-dev] [PATCH 2/2] meta: Fix temporary image type for float depth/stencil.

2013-05-30 Thread Eric Anholt
Fixes assertion failure in piglit copyteximage. --- src/mesa/drivers/common/meta.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/common/meta.c b/src/mesa/drivers/common/meta.c index ca5f5a1..fd87fc0 100644 --- a/src/mesa/drivers/common/met

[Mesa-dev] [PATCH 1/2] intel: Fix performance regression from miptree blit changes.

2013-05-30 Thread Eric Anholt
When making v2 of da2880bea05bfc87109477ab026a7f5401fc8f0c, I carefully checked all of the calls in that commit to see that I'd updated them, but forgot to update the new calls in the later commits such as .e845c5cf7abce55759501a473459aff3bf25c9ca. As a result, we were getting Y tiled temporaries

[Mesa-dev] [Bug 65173] segfault in _mesa_get_format_datatype and _mesa_get_color_read_type when state dumping with glretrace

2013-05-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=65173 --- Comment #6 from Brian Paul --- Hmm, could we get another person (Jose?) to try this too? -- You are receiving this mail because: You are the assignee for the bug. ___ mesa-dev mailing list mesa-de

[Mesa-dev] [Bug 65173] segfault in _mesa_get_format_datatype and _mesa_get_color_read_type when state dumping with glretrace

2013-05-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=65173 --- Comment #5 from Vedran Rodic --- I'm using glretrace from latest apitrace git, mesa from latest git. I was able to reproduce this on nouveau driver, intel driver and gallium swrast driver. -- You are receiving this mail because: You are th

Re: [Mesa-dev] [PATCH] mesa: fix error checking of DXT sRGB formats in _mesa_base_tex_format()

2013-05-30 Thread Brian Paul
On 05/30/2013 09:56 AM, Eric Anholt wrote: Brian Paul writes: For formats such as GL_COMPRESSED_SRGB_S3TC_DXT1_EXT we need to have both the GL_EXT_texture_sRGB and GL_EXT_texture_compression_s3tc extensions. This patch adds the missing check for the later. Found when checking out https://bug

[Mesa-dev] [Bug 65173] segfault in _mesa_get_format_datatype and _mesa_get_color_read_type when state dumping with glretrace

2013-05-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=65173 --- Comment #4 from Vedran Rodic --- mesa git version, i'll check if libtxc_dxtn.so was present here On Thu, May 30, 2013 at 5:09 PM, wrote: > Comment # 3 on bug 65173 from Brian Paul > > Which version of Mesa, and which driver? > > I tested w

Re: [Mesa-dev] [PATCH] mesa: fix error checking of DXT sRGB formats in _mesa_base_tex_format()

2013-05-30 Thread Eric Anholt
Brian Paul writes: > For formats such as GL_COMPRESSED_SRGB_S3TC_DXT1_EXT we need to > have both the GL_EXT_texture_sRGB and GL_EXT_texture_compression_s3tc > extensions. This patch adds the missing check for the later. > > Found when checking out https://bugs.freedesktop.org/show_bug.cgi?id=651

Re: [Mesa-dev] [PATCH] mesa: fix error checking of DXT sRGB formats in _mesa_base_tex_format()

2013-05-30 Thread Jose Fonseca
- Original Message - > For formats such as GL_COMPRESSED_SRGB_S3TC_DXT1_EXT we need to > have both the GL_EXT_texture_sRGB and GL_EXT_texture_compression_s3tc > extensions. This patch adds the missing check for the later. > > Found when checking out https://bugs.freedesktop.org/show_bug

[Mesa-dev] [PATCH] mesa: fix error checking of DXT sRGB formats in _mesa_base_tex_format()

2013-05-30 Thread Brian Paul
For formats such as GL_COMPRESSED_SRGB_S3TC_DXT1_EXT we need to have both the GL_EXT_texture_sRGB and GL_EXT_texture_compression_s3tc extensions. This patch adds the missing check for the later. Found when checking out https://bugs.freedesktop.org/show_bug.cgi?id=65173 NOTE: This is a candidate

[Mesa-dev] [Bug 65173] segfault in _mesa_get_format_datatype and _mesa_get_color_read_type when state dumping with glretrace

2013-05-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=65173 --- Comment #3 from Brian Paul --- Which version of Mesa, and which driver? I tested with Mesa/master and the 9.1 branch and didn't see this problem. However, I did find a problem when the libtxc_dxtn.so library wasn't present. I'll post a pat

[Mesa-dev] [PATCH 2/2] intel: flush fake front buffer more robustly.

2013-05-30 Thread Paul Berry
When a fake front buffer is in use, if we request the front buffer (using screen->dri2.loader->getBuffersWithFormat()), the X server copies the real front buffer to the fake front buffer and returns the fake front buffer. We sometimes make redundant requests for the front buffer (due to using a si

[Mesa-dev] [PATCH 1/2] intel: make intel_flush_front safe to call during initial MakeCurrent

2013-05-30 Thread Paul Berry
The patch that follows will fix a bug that prevents intel_flush_front() from being called often enough. In doing so, it will create a situation where intel_flush_front() during the initial call to glXMakeCurrent(). In this circumstance, ctx->DrawBuffer hasn't been initialized yet and is NULL. Fo

[Mesa-dev] [PATCH] glapi: Add some missing static_dispatch="false" annotations to es_EXT.xml

2013-05-30 Thread Andreas Boll
This fixes the following build errors on powerpc: CC glapi_dispatch.lo In file included from glapi_dispatch.c:90:0: ../../../../../src/mapi/glapi/glapitemp.h:1640:1: error: no previous prototype for 'glReadBufferNV' [-Werror=missing-prototypes] ../../../../../src/mapi/glapi/glapitemp

[Mesa-dev] [Bug 65173] segfault in _mesa_get_format_datatype and _mesa_get_color_read_type when state dumping with glretrace

2013-05-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=65173 --- Comment #2 from Vedran Rodic --- nVidia proprietary driver doesn't crash with the same command. -- You are receiving this mail because: You are the assignee for the bug. ___ mesa-dev mailing list

[Mesa-dev] [Bug 65173] segfault in _mesa_get_format_datatype and _mesa_get_color_read_type when state dumping with glretrace

2013-05-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=65173 --- Comment #1 from Vedran Rodic --- Created attachment 80037 --> https://bugs.freedesktop.org/attachment.cgi?id=80037&action=edit gdb full backtrace of the crash -- You are receiving this mail because: You are the assignee for the bug. _

[Mesa-dev] [Bug 65173] New: segfault in _mesa_get_format_datatype and _mesa_get_color_read_type when state dumping with glretrace

2013-05-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=65173 Priority: medium Bug ID: 65173 Assignee: mesa-dev@lists.freedesktop.org Summary: segfault in _mesa_get_format_datatype and _mesa_get_color_read_type when state dumping with

[Mesa-dev] [Bug 60518] glDrawElements segfault when compiled into display list

2013-05-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=60518 --- Comment #5 from cor...@gmx.net --- (In reply to comment #4) > The link to the trace doesn't work. Can you attach the trace to this bug > report? > > Which Mesa driver are you using? (II) intel(0): [DRI2] DRI driver: i965 OpenGL info (two m

[Mesa-dev] [PATCH] i965: fix problem with constant out of bounds access (v3)

2013-05-30 Thread Dave Airlie
Okay I now understand why Frank would want to run away, this is my attempt at fixing the CVE out of bounds access to constants outside the range. This attempt converts any illegal constants to constant 0 as per the GL spec, and is undefined behaviour. A future patch should add some debug for users

Re: [Mesa-dev] [v6 2/9] intel: do not create renderbuffers out of planar images

2013-05-30 Thread Pohjolainen, Topi
On Tue, May 28, 2013 at 01:33:18PM -0700, Eric Anholt wrote: > Topi Pohjolainen writes: > > > Signed-off-by: Topi Pohjolainen > > --- > > src/mesa/drivers/dri/intel/intel_fbo.c | 4 > > 1 file changed, 4 insertions(+) > > > > diff --git a/src/mesa/drivers/dri/intel/intel_fbo.c > > b/src/m

Re: [Mesa-dev] [PATCH] i965: fix problem with constant out of bounds access (v2)

2013-05-30 Thread Dave Airlie
On Thu, May 30, 2013 at 4:35 PM, Kenneth Graunke wrote: > On 05/29/2013 05:44 PM, Dave Airlie wrote: >> >> From: Dave Airlie >> >> This is my attempt at fixing this as the CVE is making RH security team >> care enough to make me look at this. (please upstream, security fixes are >> more important