Re: [Mesa-dev] [PATCH] glsl: disable ARB_texture_cube_map_array_enable keywords for glsl es

2013-07-25 Thread Chris Forbes
>+samplerCubeArray KEYWORD_WITH_ALT(130, 0, 150, 0, >yyextra->ARB_texture_cube_map_array_enable, SAMPLERCUBEARRAY); >+isamplerCubeArray KEYWORD_WITH_ALT(130, 0, 150, 0, >yyextra->ARB_texture_cube_map_array_enable, ISAMPLERCUBEARRAY); >+usamplerCubeArray KEYWORD_WITH_ALT(130, 0, 150, 0, >yyextr

[Mesa-dev] [PATCH] egl/dri2: support for creating images out of dma buffers

2013-07-25 Thread Topi Pohjolainen
v2: - upon success close the given file descriptors v3: - use specific entry for dma buffers instead of the basic for primes, and enable the extension based on the availability of the hook v4 (Chad): - use ARRAY_SIZE - improve the comment about the number of file descriptors

Re: [Mesa-dev] [PATCH] i965: Initialize brw_blorp_const_color_program::prog_data.

2013-07-25 Thread Kenneth Graunke
On 07/25/2013 10:48 PM, Vinson Lee wrote: Fixes "Uninitialized scalar field" defect reported by Coverity. Signed-off-by: Vinson Lee --- src/mesa/drivers/dri/i965/brw_blorp_clear.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_blorp_clea

[Mesa-dev] [PATCH] glsl: disable ARB_texture_cube_map_array_enable keywords for glsl es

2013-07-25 Thread Tapani Pälli
Patch fixes a crash with Webgl 'shader-with-non-reserved-words' conformance test by ignoring desktop extension keywords on GLSL ES. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=64087 Signed-off-by: Tapani Pälli --- src/glsl/glsl_lexer.ll | 29 + 1 file chang

[Mesa-dev] [PATCH] i965: Initialize brw_blorp_const_color_program::prog_data.

2013-07-25 Thread Vinson Lee
Fixes "Uninitialized scalar field" defect reported by Coverity. Signed-off-by: Vinson Lee --- src/mesa/drivers/dri/i965/brw_blorp_clear.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_blorp_clear.cpp b/src/mesa/drivers/dri/i965/brw_blorp_c

Re: [Mesa-dev] [PATCH] i965/vs: Fix flaky texture swizzling

2013-07-25 Thread Kenneth Graunke
On 07/23/2013 03:26 AM, Chris Forbes wrote: If any component used the ZERO or ONE swizzle, its corresponding member in the `swizzle` array would never be initialized. We *mostly* got away with this, except when that memory happened to contain a value that clobbered another channel when combined u

Re: [Mesa-dev] [PATCH v3] build: unify mesa version by using a VERSION file

2013-07-25 Thread Kenneth Graunke
On 07/25/2013 03:45 PM, Emil Velikov wrote: Rather than having to keep track of all the build systems and their respecitve definition of the mesa version, use a single top file VERSION. Every build system is responsible for reading/parsing the file and using it v2: * remove useless bulletpoint f

[Mesa-dev] [PATCH] Fix generate_mipmap_compressed memory leaks.

2013-07-25 Thread Vinson Lee
Fixes "Resource leak" defects reported by Coverity. Signed-off-by: Vinson Lee --- src/mesa/main/mipmap.c | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/main/mipmap.c b/src/mesa/main/mipmap.c index 5839632..0ef6536 100644 --- a/src/mesa/main/mipmap.c +++ b/src/mesa/main/mipmap.c

Re: [Mesa-dev] [PATCH] glsl: Be consistent about '\n', '.', and capitalization in errors/warnings.

2013-07-25 Thread Matt Turner
On Thu, Jul 25, 2013 at 8:01 PM, Paul Berry wrote: > The majority of calls to _mesa_glsl_error(), _mesa_glsl_warning(), and > _mesa_glsl_parse_state::check_version() use a message that begins with > a lower case letter and ends without a period. This patch makes all > messages follow that convent

[Mesa-dev] [PATCH] glsl: Be consistent about '\n', '.', and capitalization in errors/warnings.

2013-07-25 Thread Paul Berry
The majority of calls to _mesa_glsl_error(), _mesa_glsl_warning(), and _mesa_glsl_parse_state::check_version() use a message that begins with a lower case letter and ends without a period. This patch makes all messages follow that convention. Also, error/warning messages shouldn't end in '\n', si

Re: [Mesa-dev] [PATCH] st/clover: Allow double precision operations

2013-07-25 Thread Tom Stellard
On Tue, Jul 02, 2013 at 10:44:37AM +0200, Niels Ole Salscheider wrote: > Pass "cl_khr_fp64" preprocessor definition to clang Pushed, thanks. -Tom > > Signed-off-by: Niels Ole Salscheider > --- > src/gallium/state_trackers/clover/llvm/invocation.cpp | 1 + > 1 Datei geändert, 1 Zeile hinzugefü

Re: [Mesa-dev] [PATCH 1/2] clover: Added missing address space checking of kernel parameters

2013-07-25 Thread Tom Stellard
Hi Francisco, I just realized that this breaks constant buffers on r600g. The main problem is that there is no way for r600g to return a handle for constant buffers like it can for global buffers. This is also a problem for sampler_views and resources, which are used for images. Do you have any

Re: [Mesa-dev] [PATCH 1/2] gallium/util: comments, var renaming in u_inlines.h

2013-07-25 Thread Roland Scheidegger
Am 25.07.2013 19:37, schrieb Brian Paul: > The variable 'usage' was being used for two different things. > Sometimes for PIPE_USAGE_x and other times for PIPE_TRANSFER_x. > This renames usage to access when we're talking about PIPE_TRANSFER_x > flags. Plus, add a bunch of comments to remind us wha

Re: [Mesa-dev] [PATCH] mesa: Remove broken assertion about enabled texture targets.

2013-07-25 Thread Brian Paul
On 07/25/2013 03:47 PM, Kenneth Graunke wrote: For GLSL programs, enabledTargets can have more than one bit set. For example, a shader that uses sampler2D and samplerCube uniforms will have both TEXTURE_2D_BIT and TEXTURE_CUBE_BIT set. The code that sets _ReallyEnabled already handles this, sel

[Mesa-dev] [PATCH v3] build: unify mesa version by using a VERSION file

2013-07-25 Thread Emil Velikov
Rather than having to keep track of all the build systems and their respecitve definition of the mesa version, use a single top file VERSION. Every build system is responsible for reading/parsing the file and using it v2: * remove useless bulletpoint from the documentation, suggested by Matt * "An

[Mesa-dev] [PATCH] i965: Only use brw_draw.c's trim() function when necessary.

2013-07-25 Thread Paul Berry
brw_draw.c contains a trim() function which modifies the vertex count for quads and quad strips in order to discard dangling vertices. In principle this shouldn't be necessary, since hardware since Gen4 is capable of discarding dangling vertices by itself. However, it's necessary because as a hac

Re: [Mesa-dev] [PATCH] i965: Don't create a swrast context on ES2+.

2013-07-25 Thread Chad Versace
On 07/25/2013 11:31 AM, Kenneth Graunke wrote: We already skip this for API_OPENGL_CORE; ES2+ is very similar. The primary user of the swrast context is GL_SELECT and GL_FEEDBACK, which have never existed in ES. This saves approximately 18MB of memory in GLBenchmark 2.7 Egypt (ES2). No regressio

[Mesa-dev] [PATCH] mesa: Remove broken assertion about enabled texture targets.

2013-07-25 Thread Kenneth Graunke
For GLSL programs, enabledTargets can have more than one bit set. For example, a shader that uses sampler2D and samplerCube uniforms will have both TEXTURE_2D_BIT and TEXTURE_CUBE_BIT set. The code that sets _ReallyEnabled already handles this, selecting the "highest priority" texture target. We

Re: [Mesa-dev] [PATCH v2] build: unify mesa version by using a VERSION file

2013-07-25 Thread Chad Versace
On 07/25/2013 01:28 PM, Kenneth Graunke wrote: On 07/25/2013 12:39 PM, Emil Velikov wrote: Rather than having to keep track of all the build systems and their respecitve definition of the mesa version, use a single top file VERSION. Every build system is responsible for reading/parsing the file

Re: [Mesa-dev] [PATCH v2] build: unify mesa version by using a VERSION file

2013-07-25 Thread Emil Velikov
On 25/07/13 21:28, Kenneth Graunke wrote: > On 07/25/2013 12:39 PM, Emil Velikov wrote: >> Rather than having to keep track of all the build systems and their >> respecitve >> definition of the mesa version, use a single top file VERSION. Every >> build >> system is responsible for reading/parsing

Re: [Mesa-dev] [PATCH v2] build: unify mesa version by using a VERSION file

2013-07-25 Thread Kenneth Graunke
On 07/25/2013 12:39 PM, Emil Velikov wrote: Rather than having to keep track of all the build systems and their respecitve definition of the mesa version, use a single top file VERSION. Every build system is responsible for reading/parsing the file and using it v2: * remove useless bulletpoint f

[Mesa-dev] [PATCH v2] build: unify mesa version by using a VERSION file

2013-07-25 Thread Emil Velikov
Rather than having to keep track of all the build systems and their respecitve definition of the mesa version, use a single top file VERSION. Every build system is responsible for reading/parsing the file and using it v2: * remove useless bulletpoint from the documentation, suggested by Matt * "An

Re: [Mesa-dev] [PATCH] docs: Remove obfuscation on public mailing list addresses.

2013-07-25 Thread Brian Paul
On 07/25/2013 12:45 PM, Kenneth Graunke wrote: Wrapping every character of an email address in looks bizarre, and makes it impossible to read the text. Apparently Brian did this in 2003 to try and obfuscate email addresses and avoid spam. Of course, mesa-*@lists.freedesktop.org are public mai

Re: [Mesa-dev] [PATCH] i965: Don't create a swrast context on ES2+.

2013-07-25 Thread Matt Turner
On Thu, Jul 25, 2013 at 11:31 AM, Kenneth Graunke wrote: > We already skip this for API_OPENGL_CORE; ES2+ is very similar. > The primary user of the swrast context is GL_SELECT and GL_FEEDBACK, > which have never existed in ES. > > This saves approximately 18MB of memory in GLBenchmark 2.7 Egypt (

[Mesa-dev] [PATCH] docs: Remove obfuscation on public mailing list addresses.

2013-07-25 Thread Kenneth Graunke
Wrapping every character of an email address in looks bizarre, and makes it impossible to read the text. Apparently Brian did this in 2003 to try and obfuscate email addresses and avoid spam. Of course, mesa-*@lists.freedesktop.org are public mailing lists and trivial to find on the internet. S

Re: [Mesa-dev] [PATCH] build: unify mesa version by using a VERSION file

2013-07-25 Thread Chad Versace
On 07/25/2013 11:22 AM, Matt Turner wrote: On Fri, Jul 19, 2013 at 4:35 PM, Emil Velikov wrote: Rather than having to keep track of all the build systems and their respecitve definition of the mesa version, use a single top file VERSION. Every build system is responsible for reading/parsing the

[Mesa-dev] [PATCH] i965: Don't create a swrast context on ES2+.

2013-07-25 Thread Kenneth Graunke
We already skip this for API_OPENGL_CORE; ES2+ is very similar. The primary user of the swrast context is GL_SELECT and GL_FEEDBACK, which have never existed in ES. This saves approximately 18MB of memory in GLBenchmark 2.7 Egypt (ES2). No regressions in es3conform on Ivybridge. Signed-off-by: Ke

Re: [Mesa-dev] [PATCH] build: unify mesa version by using a VERSION file

2013-07-25 Thread Matt Turner
On Fri, Jul 19, 2013 at 4:35 PM, Emil Velikov wrote: > Rather than having to keep track of all the build systems and their respecitve > definition of the mesa version, use a single top file VERSION. Every build > system is responsible for reading/parsing the file and using it > > Signed-off-by: Em

[Mesa-dev] [PATCH 2/2] gallium/util: reformat, comment util_get_offset()

2013-07-25 Thread Brian Paul
--- src/gallium/auxiliary/util/u_inlines.h | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/gallium/auxiliary/util/u_inlines.h b/src/gallium/auxiliary/util/u_inlines.h index f6ba8ae..7a82f05 100644 --- a/src/gallium/auxiliary/util/u_inlines.h +++ b/src/gallium/

[Mesa-dev] [PATCH 1/2] gallium/util: comments, var renaming in u_inlines.h

2013-07-25 Thread Brian Paul
The variable 'usage' was being used for two different things. Sometimes for PIPE_USAGE_x and other times for PIPE_TRANSFER_x. This renames usage to access when we're talking about PIPE_TRANSFER_x flags. Plus, add a bunch of comments to remind us what's going on. Also, use unsigned for PIPE_TRANSF

Re: [Mesa-dev] [v8 8/9] egl/dri2: support for creating images out of dma buffers

2013-07-25 Thread Chad Versace
On 07/24/2013 11:22 PM, Pohjolainen, Topi wrote: On Wed, Jul 24, 2013 at 05:02:50PM -0700, Chad Versace wrote: On 07/24/2013 03:23 AM, Topi Pohjolainen wrote: + + /** +* The spec says: +* +* "If is EGL_LINUX_DMA_BUF_EXT, and the EGL_LINUX_DRM_FOURCC_EXT +* attribute indica

Re: [Mesa-dev] [PATCH 2/3] softpipe: don't ignore pipe_constant_buffer::buffer_offset

2013-07-25 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Thu, Jul 25, 2013 at 5:32 PM, Brian Paul wrote: > This was never a problem since the Mesa state tracker always gives > us a user-space constant buffer with buffer_offset=0. But if another > state tracker ever gave us a "HW" constant buffer with non-zero > buff

Re: [Mesa-dev] [PATCH 1/3] gallium/docs: clarify definition of PIPE_CAP_USER_CONSTANT_BUFFERS

2013-07-25 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Thu, Jul 25, 2013 at 5:32 PM, Brian Paul wrote: > The cap means _can_ accept user-space constant buffers; it doesn't > mean _only_ accepts user-space constant buffers. > --- > src/gallium/docs/source/screen.rst |7 --- > 1 file changed, 4 insertions(+)

[Mesa-dev] [PATCH 3/3] softpipe: use new softpipe_resource_data() accessor

2013-07-25 Thread Brian Paul
We should probably be using map()/unmap() when accessing resource data, but this is a little better. --- src/gallium/drivers/softpipe/sp_draw_arrays.c |6 +++--- src/gallium/drivers/softpipe/sp_state_shader.c |2 +- src/gallium/drivers/softpipe/sp_texture.h | 12 3 fil

[Mesa-dev] [PATCH 1/3] gallium/docs: clarify definition of PIPE_CAP_USER_CONSTANT_BUFFERS

2013-07-25 Thread Brian Paul
The cap means _can_ accept user-space constant buffers; it doesn't mean _only_ accepts user-space constant buffers. --- src/gallium/docs/source/screen.rst |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/gallium/docs/source/screen.rst b/src/gallium/docs/source/scr

[Mesa-dev] [PATCH 2/3] softpipe: don't ignore pipe_constant_buffer::buffer_offset

2013-07-25 Thread Brian Paul
This was never a problem since the Mesa state tracker always gives us a user-space constant buffer with buffer_offset=0. But if another state tracker ever gave us a "HW" constant buffer with non-zero buffer_offset we'd mis-render. Also, use the correct buffer size. And move an assertion to the t

Re: [Mesa-dev] [PATCH] gallivm: Remove NoFramePointerElimNonLeaf for LLVM >= 3.4.

2013-07-25 Thread Jose Fonseca
- Original Message - > TargetOptions::NoFramePointerElimNonLeaf was removed in LLVM 3.4 > r187093. > > Signed-off-by: Vinson Lee > --- > src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/gallium/auxiliary/gallivm/lp_bld_misc.c

Re: [Mesa-dev] [PATCH] draw: fix vertex id computation

2013-07-25 Thread Jose Fonseca
Looks good. Thanks. Jose - Original Message - > vertex id has to be unaffected by the start index (i.e. when calling > draw arrays with start_index = 5, the first vertex_id has to still > be 0, not 5) and it has to be equal to the index when performing > indexed rendering (in which case i

Re: [Mesa-dev] [PATCH] gallium/vl: add prime support

2013-07-25 Thread Armin K.
On 07/25/2013 05:31 AM, Dave Airlie wrote: > From: Dave Airlie > > This fixes the dri2 opening to check if DRI_PRIME is set, > and picks the correct drm device path to open, this along > with a change to libvdpau allows vdpauinfo to work at least, > > Martin Peres tested with nouveau, and there

Re: [Mesa-dev] [PATCH] gallium/vl: add prime support

2013-07-25 Thread Andreas Boll
Candidate for 9.2? Please add: Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=67283 2013/7/25, Dave Airlie : > From: Dave Airlie > > This fixes the dri2 opening to check if DRI_PRIME is set, > and picks the correct drm device path to open, this along > with a change to libvdpau allows vd

Re: [Mesa-dev] [PATCH] gallium/vl: add prime support

2013-07-25 Thread Christian König
Am 25.07.2013 05:31, schrieb Dave Airlie: From: Dave Airlie This fixes the dri2 opening to check if DRI_PRIME is set, and picks the correct drm device path to open, this along with a change to libvdpau allows vdpauinfo to work at least, Martin Peres tested with nouveau, and there seems to be a