Re: [Mesa-dev] Mesa Library questions

2013-07-28 Thread Pierre Moreau
Hello Li Zhi, I have done a quick search, and it seems that glBegin is mapped to vbo_exec_Begin. I'm not using the same version of Mesa as you, but here is how it works for me. In vbo_exec_api.c, function vbo_exec_vtxfmt_init, you get vfmt-Begin = vbo_exec_Begin; And after, in vtxfmt.c,

Re: [Mesa-dev] [PATCH 0/5] glsl: Clean up linker error checking.

2013-07-28 Thread Jordan Justen
Reviewed-by: Jordan Justen jordan.l.jus...@intel.com On Sat, Jul 27, 2013 at 3:59 PM, Paul Berry stereotype...@gmail.com wrote: I recently discovered a bug in my geometry shader branch wherein we were responding to certain kinds of link errors by calling linker_error(), but the program was

Re: [Mesa-dev] [PATCH 1/2] mesa: Treat glBindRenderbuffer and glBindRenderbufferEXT correctly

2013-07-28 Thread Jordan Justen
On Fri, Jul 26, 2013 at 10:55 PM, Ian Romanick i...@freedesktop.org wrote: From: Ian Romanick ian.d.roman...@intel.com Allow user-generated names for glBindRenderbufferEXT on desktop GL. Disallow its use altogether for core profiles. Signed-off-by: Ian Romanick ian.d.roman...@intel.com Cc:

[Mesa-dev] [PATCH 1/4] mesa: Remove stray debug printfs in attachment completeness code

2013-07-28 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Signed-off-by: Ian Romanick ian.d.roman...@intel.com Cc: mesa-sta...@lists.freedesktop.org --- src/mesa/main/fbobject.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index 29c3c50..a55b56c

[Mesa-dev] [PATCH 2/4] mesa: Don't call driver RenderTexture for really broken textures

2013-07-28 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com This fixes the segfault in the '0x0 texture' subtest of piglit's fbo-incomplete test. Signed-off-by: Ian Romanick ian.d.roman...@intel.com Cc: mesa-sta...@lists.freedesktop.org --- src/mesa/main/fbobject.c | 22 -- 1 file changed,

[Mesa-dev] [PATCH 3/4] mesa: Don't call driver RenderTexture for invalid zoffset

2013-07-28 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com This fixes the segfault in the 'invalid slice of 3D texture' and 'invalid layer of an array texture' subtests of piglit's fbo-incomplete test. The 'invalid layer of an array texture' subtest still fails. Signed-off-by: Ian Romanick

[Mesa-dev] [PATCH 4/4] mesa: Validate the layer selection of an array texture too

2013-07-28 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Previously only the slice of a 3D texture was validated in the FBO completeness check. This fixes the failure in the 'invalid layer of an array texture' subtest of piglit's fbo-incomplete test. Signed-off-by: Ian Romanick ian.d.roman...@intel.com Cc:

Re: [Mesa-dev] [PATCH 1/2] mesa: Return GL_FRAMEBUFFER_UNDEFINED if the winsys fbo is incomplete.

2013-07-28 Thread Jordan Justen
Series Reviewed-by: Jordan Justen jordan.l.jus...@intel.com On Fri, Jul 26, 2013 at 4:36 PM, Matt Turner matts...@gmail.com wrote: Specified by ARB_framebuffer_object, GL 3.0, and ES 3.0. --- src/mesa/main/fbobject.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [PATCH 5/4] mesa: Generate a renderbuffer wrapper even if the texture has no image

2013-07-28 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com This prevents a segfault in check_begin_texture_render when an FBO is rebound while in this state. This fixes the piglit test fbo-incomplete-invalid-texture. Signed-off-by: Ian Romanick ian.d.roman...@intel.com Cc: mesa-sta...@lists.freedesktop.org

Re: [Mesa-dev] [PATCH 2/4] mesa: Don't call driver RenderTexture for really broken textures

2013-07-28 Thread Jordan Justen
On Sun, Jul 28, 2013 at 12:56 PM, Ian Romanick i...@freedesktop.org wrote: From: Ian Romanick ian.d.roman...@intel.com This fixes the segfault in the '0x0 texture' subtest of piglit's fbo-incomplete test. Signed-off-by: Ian Romanick ian.d.roman...@intel.com Cc:

Re: [Mesa-dev] [PATCH 3/4] mesa: Don't call driver RenderTexture for invalid zoffset

2013-07-28 Thread Chris Forbes
+ if (att-Zoffset texImage-Depth) Shouldn't this be =, same as in your later array patch? -- Chris ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/2] mesa: Treat glBindRenderbuffer and glBindRenderbufferEXT correctly

2013-07-28 Thread Kenneth Graunke
On 07/26/2013 10:55 PM, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com Allow user-generated names for glBindRenderbufferEXT on desktop GL. Disallow its use altogether for core profiles. Signed-off-by: Ian Romanick ian.d.roman...@intel.com Cc: mesa-sta...@lists.freedesktop.org

Re: [Mesa-dev] [PATCH 1/4] mesa: Remove stray debug printfs in attachment completeness code

2013-07-28 Thread Kenneth Graunke
On 07/28/2013 12:56 PM, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com Signed-off-by: Ian Romanick ian.d.roman...@intel.com Cc: mesa-sta...@lists.freedesktop.org --- src/mesa/main/fbobject.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/mesa/main/fbobject.c

Re: [Mesa-dev] [PATCH 1/2] mesa: Return GL_FRAMEBUFFER_UNDEFINED if the winsys fbo is incomplete.

2013-07-28 Thread Kenneth Graunke
On 07/26/2013 04:36 PM, Matt Turner wrote: Specified by ARB_framebuffer_object, GL 3.0, and ES 3.0. --- src/mesa/main/fbobject.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index a29f1ab..bf7e85c 100644 ---

Re: [Mesa-dev] Mesa Library questions

2013-07-28 Thread Kenneth Graunke
On 07/26/2013 06:18 PM, ZhiLi wrote: Hello everyone, I am an university student working on school project related to OpenGL. Now I am using mesa library (version 9.0.3) as an implementation of OpenGL. I have a few questions about Mesa library. glBegin()/glEnd() pair is used for immediate mode

Re: [Mesa-dev] [PATCH 2/4] mesa: Don't call driver RenderTexture for really broken textures

2013-07-28 Thread Ian Romanick
On 07/28/2013 03:24 PM, Jordan Justen wrote: On Sun, Jul 28, 2013 at 12:56 PM, Ian Romanick i...@freedesktop.org wrote: From: Ian Romanick ian.d.roman...@intel.com This fixes the segfault in the '0x0 texture' subtest of piglit's fbo-incomplete test. Signed-off-by: Ian Romanick

Re: [Mesa-dev] [PATCH 3/4] mesa: Don't call driver RenderTexture for invalid zoffset

2013-07-28 Thread Ian Romanick
On 07/28/2013 03:32 PM, Chris Forbes wrote: + if (att-Zoffset texImage-Depth) Shouldn't this be =, same as in your later array patch? Yes. Good catch. Off-by-one error for the lose. :( -- Chris ___ mesa-dev mailing list