pp_free_bos dereferences ppq without a null check.
Fixes Dereference before null check defect reported by Coverity.
Signed-off-by: Vinson Lee v...@freedesktop.org
---
src/gallium/auxiliary/postprocess/pp_init.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git
Well, I should have been more clear. If I do this:
263: value[3] = 0;
290: expected[3] = 1.0;
The test always passes, but if I only do this:
290: expected[3] = 1.0;
The test fails with this error:
texture-integer: failure with format GL_RGB8I_EXT:
texture color = 92, 126, 14, 104
expected
INTEL_DEBUG=vue now emits a listing of each slot in the VUE map,
and the corresponding interpolation mode.
Signed-off-by: Chris Forbes chr...@ijw.co.nz
---
src/mesa/drivers/dri/i965/brw_interpolation_map.c | 28 +++
src/mesa/drivers/dri/i965/intel_context.c | 1 +
Makes this flag appear in the output for INTEL_DEBUG=state
Signed-off-by: Chris Forbes chr...@ijw.co.nz
---
src/mesa/drivers/dri/i965/brw_state_upload.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/mesa/drivers/dri/i965/brw_state_upload.c
This series adds support for GLSL-1.30-style clipping using gl_ClipDistance on
Gen4/5.
All of the interpolation piglits now pass, but there are still a couple of
things I need to do:
* Get rid of clip plane compaction
* Add similar support for clipping lines
There's no need to use a clip flag for NEGW on these gens, so
no reason we can't just enable 8 planes.
V2: Bump (and document!) MAX_VERTS in the clip code.
Signed-off-by: Chris Forbes chr...@ijw.co.nz
---
src/mesa/drivers/dri/i965/brw_clip.h | 6 +-
The SF never gets to see the clip distances. If we didn't ignore them
here, we got confused about the correct offsets for any varyings laid
out after them. (user-defined varyings would break, but gl_FrontColor
etc worked properly).
Signed-off-by: Chris Forbes chr...@ijw.co.nz
---
Also adjust the SF URB read offset to account for there being two
additional slots of stuff it doesn't care about.
Signed-off-by: Chris Forbes chr...@ijw.co.nz
---
src/mesa/drivers/dri/i965/brw_sf.h | 2 +-
src/mesa/drivers/dri/i965/brw_vs.c | 2 ++
2 files changed, 3 insertions(+), 1
Previously we had disabled interpolation of the clip distances as a
special case, since they were unused.
Signed-off-by: Chris Forbes chr...@ijw.co.nz
---
src/mesa/drivers/dri/i965/brw_clip_util.c | 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git
We need to produce clip flags for the vertex header on Gen4/5, so
clip plane lowering has to be done before we try to emit the flags/psiz
attribute.
Signed-off-by: Chris Forbes chr...@ijw.co.nz
---
src/mesa/drivers/dri/i965/brw_vec4.h | 2 +-
Signed-off-by: Chris Forbes chr...@ijw.co.nz
---
src/mesa/drivers/dri/i965/brw_clip.h | 3 +++
src/mesa/drivers/dri/i965/brw_clip_tri.c | 9 +
2 files changed, 12 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/brw_clip.h
b/src/mesa/drivers/dri/i965/brw_clip.h
index
Signed-off-by: Chris Forbes chr...@ijw.co.nz
---
src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 25 ++---
1 file changed, 14 insertions(+), 11 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp
b/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp
index
Soon the dp4 is only going to be used for fixed clip planes.
Signed-off-by: Chris Forbes chr...@ijw.co.nz
---
src/mesa/drivers/dri/i965/brw_clip_tri.c | 26 ++
1 file changed, 14 insertions(+), 12 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_clip_tri.c
Signed-off-by: Chris Forbes chr...@ijw.co.nz
---
src/mesa/drivers/dri/i965/brw_clip_tri.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_clip_tri.c
b/src/mesa/drivers/dri/i965/brw_clip_tri.c
index bd3ffb3..4d2eb0a 100644
---
Nothing in the clipper uses gl_ClipVertex any more, so we don't care
where it is.
Signed-off-by: Chris Forbes chr...@ijw.co.nz
---
src/mesa/drivers/dri/i965/brw_clip_tri.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_clip_tri.c
15 matches
Mail list logo
