[Mesa-dev] [Bug 62647] Wrong rendering of Dota 2 on Wine (apitrace attached) - Intel IVB HD4000

2013-08-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=62647 Vedran Rodic vro...@gmail.com changed: What|Removed |Added CC||auke-jan.h@intel.com

[Mesa-dev] [PATCH 1/2] glsl: Add new overload of program_resource_visitor::visit_field method

2013-08-17 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com The outer-most record is passed into the visit_field method for the first field. In other words, in the following structure: struct S1 { vec4 v; float f; }; struct S { S1 s1; S1 s2; }; uniform Ubo

[Mesa-dev] [PATCH 2/2] glsl: Use alignment of container record for its first field

2013-08-17 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com The first field of a record in a UBO has the aligment of the record itself. Fixes piglit vs-struct-pad, fs-struct-pad, and (with the patch posted to the piglit list that extends the test) layout-std140. NOTE: The bit of strangeness with the version of

[Mesa-dev] [PATCH] glsl: Disallow embedded structure definitions

2013-08-17 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Continue to allow them in GLSL 1.10 because the spec allows it. Generate an error in all other versions because the specs specifically disallow it. Signed-off-by: Ian Romanick ian.d.roman...@intel.com Cc: 9.2 mesa-sta...@lists.freedesktop.org ---

Re: [Mesa-dev] [PATCH] st/vdpau: drop unnecessary variable prof

2013-08-17 Thread Christian König
Am 16.08.2013 22:41, schrieb Emil Velikov: Signed-off-by: Emil Velikov emil.l.veli...@gmail.com Well, any halve way sane compiler should be able to optimize that anyway, but on the other hand the patch looks good to me. Reviewed-by: Christian König christian.koe...@amd.com ---

Re: [Mesa-dev] [PATCH] glsl: don't eliminate texcoords that can be set by GL_COORD_REPLACE

2013-08-17 Thread Henri Verbeet
On 9 August 2013 22:40, Marek Olšák mar...@gmail.com wrote: Tested by examining generated TGSI shaders from piglit/glsl-routing. This fixes the relevant Wine d3d9 test, thanks. No piglit changes on Cayman. Reviewed-by: Henri Verbeet hverb...@gmail.com Tested-by: Henri Verbeet

Re: [Mesa-dev] nouveau: xvmc on nv43

2013-08-17 Thread Ilia Mirkin
On Sat, Aug 17, 2013 at 11:56 AM, Pali Rohár pali.ro...@gmail.com wrote: Now I compiled mesa from git master again and installed kernel 3.11-rc5. After that mpeg2play_accel not crashing anymore. It looks like I forgot to install mesa with your xvmc patches (only compiled), so I had in system

[Mesa-dev] [PATCH 1/1] mesa: Properly set the fog scale (gl_Fog.scale) to +INF when fog start and end are equal.

2013-08-17 Thread Henri Verbeet
This was originally introduced by commit ba47aabc9868b410cdfe3bc8b6d25a44a598cba2, but unfortunately the commit message doesn't go into much detail about why +INF would be a problem here. I don't see anything in the spec that would allow 1.0f here. A similar issue exists for

[Mesa-dev] auxiliary/vl and st/vdpau, xvmc trivial fixes and cleanups

2013-08-17 Thread Emil Velikov
Hello list, This patch-set sets the proper width/height for 442 chroma formats(Andy Furniss), prevents all sort of chaos if create_video_buffer() fails, adds a check after memory allocation and a few trivial oneliners to improve code readability. Not sure how many of those are suiteable

[Mesa-dev] [PATCH 1/7] vdpau/vl 422 chroma width/height mix up

2013-08-17 Thread Emil Velikov
From: Andy Furniss adf.li...@gmail.com I was looking into some minor 422 issues/discrepencies I noticed long ago using vdpau on my rv790. I noticed that there is code that is halving height rather than width - 422 is full height AFAIK. Making the changes below doesn't actually make any

[Mesa-dev] [PATCH 2/7] st/vdpau: exit gracefully if we fail to create video buffer

2013-08-17 Thread Emil Velikov
Otherwise we risk causing memory corruption. v2: forgot the mutex_unlock() Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- src/gallium/state_trackers/vdpau/surface.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/gallium/state_trackers/vdpau/surface.c

[Mesa-dev] [PATCH 3/7] st/xvmc: exit gracefully if we fail to create video buffer

2013-08-17 Thread Emil Velikov
Free any allocated memory and return BadAlloc if create_video_buffer() has failed to create a buffer. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- src/gallium/state_trackers/xvmc/surface.c | 4 1 file changed, 4 insertions(+) diff --git

[Mesa-dev] [PATCH 4/7] vl/buffer: add sanity check after CALLOC_STRUCT

2013-08-17 Thread Emil Velikov
Check if we have successfully allocated memory. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- src/gallium/auxiliary/vl/vl_video_buffer.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/auxiliary/vl/vl_video_buffer.c b/src/gallium/auxiliary/vl/vl_video_buffer.c index

[Mesa-dev] [PATCH 5/7] vl/idct: cleanup all idct buffers

2013-08-17 Thread Emil Velikov
Code should loop through and cleanup the three (VL_NUM_COMPONENTS) idct buffers, rather than doing the first one three times. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- src/gallium/auxiliary/vl/vl_mpeg12_decoder.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 6/7] st/vdpau: drop unnecessary variable prof

2013-08-17 Thread Emil Velikov
Any decent compiler will do this for us, although doing this will make grepping through the code alot easier. v2: In both mixer and query interface Reviewed-by: Christian König christian.koe...@amd.com [v1] Signed-off-by: Emil Velikov emil.l.veli...@gmail.com ---

[Mesa-dev] [PATCH 7/7] vl/buffers: consistent use on VL_MAX_SURFACES

2013-08-17 Thread Emil Velikov
Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- src/gallium/auxiliary/vl/vl_video_buffer.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gallium/auxiliary/vl/vl_video_buffer.c b/src/gallium/auxiliary/vl/vl_video_buffer.c index 22e618a..9264194 100644 ---

[Mesa-dev] [PATCH] nouveau: Copy m4x4 and m8x8 separately.

2013-08-17 Thread Vinson Lee
Silences Coverity Out-of-bounds access defect. Signed-off-by: Vinson Lee v...@freedesktop.org --- src/gallium/drivers/nouveau/nouveau_vp3_video_vp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/nouveau/nouveau_vp3_video_vp.c

[Mesa-dev] [PATCH] radeonsi: Ensure fmask_format is initialized in release builds.

2013-08-17 Thread Vinson Lee
Fixes Uninitialized scalar variable defect reported by Coverity. Signed-off-by: Vinson Lee v...@freedesktop.org --- src/gallium/drivers/radeonsi/si_state.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c index

Re: [Mesa-dev] [PATCH] glsl: don't eliminate texcoords that can be set by GL_COORD_REPLACE

2013-08-17 Thread Ian Romanick
On 08/09/2013 01:40 PM, Marek Olšák wrote: Tested by examining generated TGSI shaders from piglit/glsl-routing. Cc: mesa-sta...@lists.freedesktop.org This patch was in my review-queue, and I forgot about it. Sorry. :( Reviewed-by: Ian Romanick ian.d.roman...@intel.com Since this also fixes