Reviewed-by: Matt Turner matts...@gmail.com
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Hi Federico,
Just FYI you should send the piglit test to the piglit mailing list:
http://lists.freedesktop.org/mailman/listinfo/piglit
Also to allow easy review you should use git send-email rather than
attaching it to the email.
Timothy Arceri
On Mon, 2013-10-21 at 17:37 -0500, Federico Mena
From: Dave Airlie airl...@redhat.com
Limit the max glsl version level to what the state tracker supports.
Signed-off-by: Dave Airlie airl...@redhat.com
---
src/mesa/state_tracker/st_extensions.c | 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git
From: =?UTF-8?q?J=C3=B8rgen=20Lind?= jorgen.l...@digia.com
Date: Tue, 22 Oct 2013 09:21:05 +0200
Subject: [PATCH] Don't use gbm_dri_device when its not there
---
src/egl/drivers/dri2/egl_dri2.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/egl/drivers/dri2/egl_dri2.c
On Fri, Oct 18, 2013 at 8:09 AM, Kenneth Graunke kenn...@whitecape.org wrote:
DrawTransformFeedback() needs to obtain the number of vertices written
to a particular stream during the last Begin/EndTransformFeedback block.
The new driver hook returns exactly that information.
Gallium drivers
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au
---
src/glsl/ast_array_index.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/glsl/ast_array_index.cpp b/src/glsl/ast_array_index.cpp
index b457ec8..107c29e 100644
--- a/src/glsl/ast_array_index.cpp
+++
The main purpose of this patch is to increase readability of
the array code. A redundent is_array() check is also removed.
The introduction of is_unsized_array() should also make the
ARB_arrays_of_arrays code simpler and more readable when it arrives.
Signed-off-by: Timothy Arceri
In commit 800610f (i965/fs: Improve accuracy of dFdy() to match
dFdx()) I unrolled the high-accuracy dFdy() computation from a single
SIMD16 instruction to two SIMD8 instructions because of text I found
in the i965 (gen4) PRM saying that instruction compression could not
be used in align16 mode.
- Original Message -
Silence a bunch of MSVC type conversion warnings.
Changed return type of S_FIXED to int32_t (signed). The result
is the same. It just seems more intuitive that a signed conversion
function should return a signed value.
---
src/mesa/main/macros.h |6
On 21 October 2013 18:34, Eric Anholt e...@anholt.net wrote:
Paul Berry stereotype...@gmail.com writes:
On 18 October 2013 17:04, Eric Anholt e...@anholt.net wrote:
Putting these fixups for a couple of weird cases in just MOV and ADD
feels wrong to me, but maybe when I understand better
On 10/22/2013 02:06 AM, Dave Airlie wrote:
From: Dave Airlie airl...@redhat.com
Limit the max glsl version level to what the state tracker supports.
Signed-off-by: Dave Airlie airl...@redhat.com
---
src/mesa/state_tracker/st_extensions.c | 10 +++---
1 file changed, 3 insertions(+), 7
https://bugs.freedesktop.org/show_bug.cgi?id=70743
Brian Paul bri...@vmware.com changed:
What|Removed |Added
Status|NEW |RESOLVED
https://bugs.freedesktop.org/show_bug.cgi?id=70766
Priority: medium
Bug ID: 70766
Assignee: mesa-dev@lists.freedesktop.org
Summary: Run-time link error in swrast_dri.so
Severity: major
Classification: Unclassified
OS: Linux
On 10/16/2013 10:40 AM, Ian Romanick wrote:
On 10/15/2013 07:50 PM, Kenneth Graunke wrote:
On 10/15/2013 01:58 PM, Ian Romanick wrote:
On 10/15/2013 01:50 PM, Anuj Phogat wrote:
On Tue, Oct 15, 2013 at 10:02 AM, Ian Romanick i...@freedesktop.org
wrote:
On 10/14/2013 10:12 AM, Anuj Phogat
On 10/22/2013 07:48 AM, Ian Romanick wrote:
On 10/16/2013 10:40 AM, Ian Romanick wrote:
On 10/15/2013 07:50 PM, Kenneth Graunke wrote:
On 10/15/2013 01:58 PM, Ian Romanick wrote:
On 10/15/2013 01:50 PM, Anuj Phogat wrote:
On Tue, Oct 15, 2013 at 10:02 AM, Ian Romanick i...@freedesktop.org
On Mon, 2013-10-21 at 22:20 -0700, Francisco Jerez wrote:
Jan Vesely jan.ves...@rutgers.edu writes:
the specs say that clCreateContext reutrns error
if platform value specified in properties is not a valid platform
The orignal approach fials if invalid valu other than NULL pointer is
I'm curious about what the proper behavior should be for extensions that
have been integrated into core. In particular I'm looking at
ARB_texture_cube_map as we are using that in one of the ARB_texture_view
piglit tests and when run on the Mesa driver the piglit
function
On Tue, Oct 22, 2013 at 6:37 AM, Paul Berry stereotype...@gmail.com wrote:
In commit 800610f (i965/fs: Improve accuracy of dFdy() to match
dFdx()) I unrolled the high-accuracy dFdy() computation from a single
SIMD16 instruction to two SIMD8 instructions because of text I found
in the i965
On 10/22/2013 09:00 AM, Courtney Goeltzenleuchter wrote:
I'm curious about what the proper behavior should be for extensions that
have been integrated into core. In particular I'm looking at
ARB_texture_cube_map as we are using that in one of the ARB_texture_view
piglit tests and when run on
On 10/21/2013 11:48 AM, Kenneth Graunke wrote:
On 10/21/2013 08:40 AM, Ian Romanick wrote:
On 10/17/2013 11:09 PM, Kenneth Graunke wrote:
Here's my implementation of ARB_transform_feedback2. I believe it's
complete; it passes all of our Piglit tests and a lot of Intel's
oglconform tests.
On 22 October 2013 10:07, Ian Romanick i...@freedesktop.org wrote:
On 10/21/2013 11:48 AM, Kenneth Graunke wrote:
On 10/21/2013 08:40 AM, Ian Romanick wrote:
On 10/17/2013 11:09 PM, Kenneth Graunke wrote:
Here's my implementation of ARB_transform_feedback2. I believe it's
complete; it
From the GLSL 1.50 spec, section 4.3.8.1 (Input Layout Qualifiers):
The layout qualifier identifiers for geometry shader inputs are
layout-qualifier-id
points
lines
lines_adjacency
triangles
triangles_adjacency
And from
On Tue, Oct 22, 2013 at 11:01 AM, Ian Romanick i...@freedesktop.org wrote:
On 10/22/2013 09:00 AM, Courtney Goeltzenleuchter wrote:
I'm curious about what the proper behavior should be for extensions that
have been integrated into core. In particular I'm looking at
ARB_texture_cube_map as
Paul Berry stereotype...@gmail.com writes:
On 21 October 2013 18:34, Eric Anholt e...@anholt.net wrote:
Another option: How about instead of that assert in brw_eu_emit.c, we
just smash the vstride to be width * hstride? We know the vstride
doesn't matter, because you're only using execsize
Paul Berry stereotype...@gmail.com writes:
In commit 800610f (i965/fs: Improve accuracy of dFdy() to match
dFdx()) I unrolled the high-accuracy dFdy() computation from a single
SIMD16 instruction to two SIMD8 instructions because of text I found
in the i965 (gen4) PRM saying that instruction
On 10/18/2013 01:14 PM, Paul Berry wrote:
On 11 October 2013 11:18, Ian Romanick i...@freedesktop.org
mailto:i...@freedesktop.org wrote:
From: Ian Romanick ian.d.roman...@intel.com
mailto:ian.d.roman...@intel.com
Checks that the variables generated meet certain criteria.
---
src/mesa/drivers/dri/i965/brw_fs_copy_propagation.cpp | 2 +-
src/mesa/drivers/dri/i965/brw_fs_cse.cpp | 2 +-
src/mesa/drivers/dri/i965/brw_fs_live_variables.cpp | 2 +-
src/mesa/drivers/dri/i965/brw_vec4_live_variables.cpp | 2 +-
4 files changed, 4 insertions(+), 4
total instructions in shared programs: 1645011 - 1644938 (-0.00%)
instructions in affected programs: 17543 - 17470 (-0.42%)
---
src/mesa/drivers/dri/i965/brw_fs_cse.cpp | 26 +++---
1 file changed, 23 insertions(+), 3 deletions(-)
diff --git
---
src/mesa/drivers/dri/i965/brw_fs.cpp | 8
src/mesa/drivers/dri/i965/brw_fs.h | 1 +
2 files changed, 9 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp
b/src/mesa/drivers/dri/i965/brw_fs.cpp
index 65a4b66..77b898b 100644
--- a/src/mesa/drivers/dri/i965/brw_fs.cpp
---
src/mesa/drivers/dri/i965/brw_fs.cpp | 16
src/mesa/drivers/dri/i965/brw_fs.h | 3 +++
2 files changed, 19 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp
b/src/mesa/drivers/dri/i965/brw_fs.cpp
index 77b898b..9b56764 100644
---
An future commit will enable CSE for CMP instructions. It operates on
the following code
cmp.ge.f0(8) null g458,8,1F 0F
(+f0) sel(8)g501F g408,8,1F g108,8,1F
cmp.ge.f0(8) null g458,8,1F 0F
(+f0) sel(8)g511F g418,8,1F g118,8,1F
cmp.ge.f0(8) null
---
src/mesa/drivers/dri/i965/brw_fs.cpp | 9 +
1 file changed, 9 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp
b/src/mesa/drivers/dri/i965/brw_fs.cpp
index 5336851..a03acae 100644
--- a/src/mesa/drivers/dri/i965/brw_fs.cpp
+++ b/src/mesa/drivers/dri/i965/brw_fs.cpp
@@
The example code's final state after the last three changes is
cmp.ge.f0(8) g301F g458,8,1F 0F
(+f0) sel(8)g501F g408,8,1F g108,8,1F
(+f0) sel(8)g511F g418,8,1F g118,8,1F
(+f0) sel(8)g521F g428,8,1F g128,8,1F
(+f0) sel(8)g531F g438,8,1F g138,8,1F
On 22 October 2013 13:00, Ian Romanick i...@freedesktop.org wrote:
On 10/18/2013 01:14 PM, Paul Berry wrote:
On 11 October 2013 11:18, Ian Romanick i...@freedesktop.org
mailto:i...@freedesktop.org wrote:
From: Ian Romanick ian.d.roman...@intel.com
I'm unsure if it makes sense to build EGL with Wayland support
but without GBM support. That is, to configure Mesa with
--with-egl-platforms=wayland # no drm
Also, the patch is corrupt. `git am` is unable to apply it.
Did you copy-paste the patch into your email client? Instead,
use `git
On 10/18/2013 01:31 PM, Paul Berry wrote:
On 11 October 2013 11:18, Ian Romanick i...@freedesktop.org
mailto:i...@freedesktop.org wrote:
From: Ian Romanick ian.d.roman...@intel.com
mailto:ian.d.roman...@intel.com
This required fixing the out-of-date prototype in linker.h.
On 10/22/2013 01:07 PM, Matt Turner wrote:
---
src/mesa/drivers/dri/i965/brw_fs.cpp | 16
src/mesa/drivers/dri/i965/brw_fs.h | 3 +++
2 files changed, 19 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp
b/src/mesa/drivers/dri/i965/brw_fs.cpp
index
On 10/22/2013 10:41 AM, Paul Berry wrote:
From the GLSL 1.50 spec, section 4.3.8.1 (Input Layout Qualifiers):
The layout qualifier identifiers for geometry shader inputs are
layout-qualifier-id
points
lines
lines_adjacency
Jan Vesely jan.ves...@rutgers.edu writes:
On Mon, 2013-10-21 at 22:20 -0700, Francisco Jerez wrote:
Jan Vesely jan.ves...@rutgers.edu writes:
the specs say that clCreateContext reutrns error
if platform value specified in properties is not a valid platform
The orignal approach fials
On Tue, Oct 22, 2013 at 1:30 PM, Ian Romanick i...@freedesktop.org wrote:
On 10/22/2013 01:07 PM, Matt Turner wrote:
---
src/mesa/drivers/dri/i965/brw_fs.cpp | 16
src/mesa/drivers/dri/i965/brw_fs.h | 3 +++
2 files changed, 19 insertions(+)
diff --git
This was a hack to avoid choosing to schedule all texturing before
consumption of any texture results due to the way dependency chains worked
out in the presence of MRFs. On gen7, we don't have MRFs, so the problem
doesn't apply, and this was just badly constraining our scheduling.
total
The LIFO plan was simple: Take the most recently made available
instructions, and pick those first.
But because of the order we were pushing things onto our list of
available-to-schedule instructions, it meant that when a set of
instructions was made available at the same time (for example,
Reviewed-by: Ian Romanick ian.d.roman...@intel.com
On 09/15/2013 12:10 AM, Francisco Jerez wrote:
Add XML file for the dispatch code generator, update the
dispatch_sanity test and add stub definition for the new entry point.
---
src/mapi/glapi/gen/ARB_shader_atomic_counters.xml | 47
On 09/15/2013 12:10 AM, Francisco Jerez wrote:
This patch implements the common support code required for the
ARB_shader_atomic_counters extension. It defines the necessary data
structures for tracking atomic counter buffer objects (from now on
ABOs) associated with some specific context or
Reviewed-by: Ian Romanick ian.d.roman...@intel.com
On 09/15/2013 12:10 AM, Francisco Jerez wrote:
---
src/glsl/glsl_parser_extras.cpp | 1 +
src/glsl/glsl_parser_extras.h | 2 ++
2 files changed, 3 insertions(+)
diff --git a/src/glsl/glsl_parser_extras.cpp
Matt Turner matts...@gmail.com writes:
An future commit will enable CSE for CMP instructions. It operates on
the following code
cmp.ge.f0(8) null g458,8,1F 0F
(+f0) sel(8)g501F g408,8,1F g108,8,1F
cmp.ge.f0(8) null g458,8,1F 0F
(+f0) sel(8)g511F
On Tue, Oct 22, 2013 at 1:56 PM, Eric Anholt e...@anholt.net wrote:
Matt Turner matts...@gmail.com writes:
An future commit will enable CSE for CMP instructions. It operates on
the following code
cmp.ge.f0(8) null g458,8,1F 0F
(+f0) sel(8)g501F g408,8,1F g108,8,1F
Matt Turner matts...@gmail.com writes:
---
src/mesa/drivers/dri/i965/brw_fs.cpp | 16
src/mesa/drivers/dri/i965/brw_fs.h | 3 +++
2 files changed, 19 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp
b/src/mesa/drivers/dri/i965/brw_fs.cpp
index
Matt Turner matts...@gmail.com writes:
total instructions in shared programs: 1645011 - 1644938 (-0.00%)
instructions in affected programs: 17543 - 17470 (-0.42%)
---
src/mesa/drivers/dri/i965/brw_fs_cse.cpp | 26 +++---
1 file changed, 23 insertions(+), 3
Hi Vincent,
Here is an updated patch. I wasn't sure where to put the assertion to
check that UnscheduledNoLiveOut{Defs,Uses} is empty when switching to a
new clause. I tried adding it to R600SchedStartegy::schedNode() behind
the if (NextInstKind != CurInstKind) condition, but it always failed.
Reviewed-by: Ian Romanick ian.d.roman...@intel.com
On 10/01/2013 07:15 PM, Francisco Jerez wrote:
v2: Fix GLSL version in which the type became available. Add
contains_atomic() convenience method. Split off atomic counter
comparison error checking to a separate patch that will handle
On 10/01/2013 07:15 PM, Francisco Jerez wrote:
v2: Mark atomic counters as read-only variables. Move offset overlap
code to the linker. Use the contains_atomic() convenience method.
---
src/glsl/ast.h| 15
src/glsl/ast_to_hir.cpp | 57
Reviewed-by: Ian Romanick ian.d.roman...@intel.com
On 10/01/2013 07:15 PM, Francisco Jerez wrote:
Fix the linker to deal with intrinsic functions which are undefined
all the way down to the driver back-end, and introduce intrinsic
definition helpers in the built-in generator.
We still need
On 10/01/2013 07:15 PM, Francisco Jerez wrote:
---
src/glsl/ir_builder.cpp | 25 +
src/glsl/ir_builder.h | 8
2 files changed, 33 insertions(+)
diff --git a/src/glsl/ir_builder.cpp b/src/glsl/ir_builder.cpp
index 98b4322..1913c72 100644
---
Reviewed-by: Ian Romanick ian.d.roman...@intel.com
On 10/01/2013 07:15 PM, Francisco Jerez wrote:
Almost a trivial change, it boils down to renaming a few identifiers
so their names still make sense for opaque types other than sampler.
---
src/glsl/opt_function_inlining.cpp | 66
On 22 October 2013 13:22, Ian Romanick i...@freedesktop.org wrote:
On 10/18/2013 01:31 PM, Paul Berry wrote:
On 11 October 2013 11:18, Ian Romanick i...@freedesktop.org
mailto:i...@freedesktop.org wrote:
From: Ian Romanick ian.d.roman...@intel.com
Future patches will need to call this function when there isn't an
ir_varible present to refer to.
---
src/glsl/ast_to_hir.cpp| 4 ++--
src/glsl/ir.cpp| 4 ++--
src/glsl/ir.h | 30 --
src/glsl/link_varyings.cpp | 4 ++--
4 files changed,
In future patches, we will need this in order to interpret
interpolation qualifiers that appear inside interface blocks.
---
src/glsl/ast_to_hir.cpp | 70 +
1 file changed, 42 insertions(+), 28 deletions(-)
diff --git a/src/glsl/ast_to_hir.cpp
Later patches will use this information to do proper error checking of
interpolation qualifiers that appear inside of interface blocks.
---
src/glsl/ast_to_hir.cpp | 39 +++
1 file changed, 23 insertions(+), 16 deletions(-)
diff --git a/src/glsl/ast_to_hir.cpp
The gallium vbuf module, which we've been using for some time now, takes
care of uploading user-space vertex/index data into real buffers. The
upload code in the svga driver was unused.
---
src/gallium/drivers/svga/svga_context.c | 34 +
src/gallium/drivers/svga/svga_context.h
---
src/glsl/builtin_variables.cpp |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/glsl/builtin_variables.cpp b/src/glsl/builtin_variables.cpp
index fc1115b..1f62fcf 100644
--- a/src/glsl/builtin_variables.cpp
+++ b/src/glsl/builtin_variables.cpp
@@ -888,8 +888,8 @@
With 6/7 dead, this patch has no users, so drop it for now.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
From: Tom Stellard thomas.stell...@amd.com
---
lib/Target/R600/AMDGPU.td| 2 ++
lib/Target/R600/AMDGPUAsmPrinter.cpp | 16 ++--
lib/Target/R600/AMDGPUCallingConv.td | 4 ++--
lib/Target/R600/AMDGPUSubtarget.h| 3 ++-
lib/Target/R600/Processors.td| 6 +++---
Pushed, thanks.
-Tom
On Tue, Oct 22, 2013 at 02:15:01AM +0200, Marek Olk wrote:
From: Marek Olk marek.ol...@amd.com
This fixes piglit:
- shaders/glsl-fs-texture2d-masked
- shaders/glsl-fs-texture2d-masked-4
Signed-off-by: Marek Olk marek.ol...@amd.com
Reviewed-by: Tom
On 10/22/2013 07:32 PM, Paul Berry wrote:
All geometry shaders begin this instruction:
mov(1) g0.21:ud 0x0:ud { align1 }
which sets up GRF0 properly for scratch reads and writes. Since this
instruction has a SIMD size of 1, it will only have an effect if the
first channel is enabled.
When a geometry shader is present, the fragment shader gl_PrimitiveID
input acts like an ordinary varying, receiving data from the gs
gl_PrimitiveID output. When there's no geometry shader, we have to
ask the fixed function SF hardware to provide the primitive ID to the
fragment shader instead.
---
v2: Clean up style (Ian) and check for FS_OPCODE_MOV_DISPATCH_TO_FLAGS (Eric).
src/mesa/drivers/dri/i965/brw_fs.cpp | 12
src/mesa/drivers/dri/i965/brw_fs.h | 3 +++
2 files changed, 15 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp
---
src/mesa/drivers/dri/i965/brw_schedule_instructions.cpp | 16
1 file changed, 4 insertions(+), 12 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_schedule_instructions.cpp
b/src/mesa/drivers/dri/i965/brw_schedule_instructions.cpp
index 84b74ff..9cc752e 100644
---
We'd like to CSE some instructions, like CMP, that often have null
destinations. Instead of replacing them with MOVs to null, just don't
emit the MOV.
---
This patch replaces [PATCH 6/7] i965/fs: Dead code eliminate MOV null.
but is now number 5/7 in the series.
Since compare instructions write the flag register, they should not be
considered dead even if their destination is never read. Instead of
removing them if found to be dead, set their destination to null to free
a register.
---
v2: New commit message. This is now patch 6/7.
Optimizes
cmp.ge.f0(8) null g458,8,1F 0F
(+f0) sel(8)g501F g408,8,1F g108,8,1F
cmp.ge.f0(8) null g458,8,1F 0F
(+f0) sel(8)g511F g418,8,1F g118,8,1F
cmp.ge.f0(8) null g458,8,1F 0F
(+f0) sel(8)g521F g428,8,1F g128,8,1F
On Tue, Oct 22, 2013 at 4:30 PM, Matt Turner matts...@gmail.com wrote:
With 6/7 dead, this patch has no users, so drop it for now.
I'm now using is_null() is the new [PATCH 5/7] i965/fs: Don't emit
null MOVs in CSE. so this patch is back on.
___
72 matches
Mail list logo
