Re: [Mesa-dev] [PATCH] r600/llvm: Store inputs in function arguments

2013-11-14 Thread Andy Furniss
Vincent Lejeune wrote: --- src/gallium/drivers/r600/r600_llvm.c | 119 +++ src/gallium/drivers/r600/r600_shader.c | 1 + src/gallium/drivers/radeon/radeon_llvm.h | 1 + 3 files changed, 121 insertions(+) Looks like this or whatever version went in to

[Mesa-dev] [Bug 71591] Second Life shaders fail to compile

2013-11-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=71591 --- Comment #2 from MirceaKitsune sonichedgehog_hyperblas...@yahoo.com --- I understand. Still strange that proprietary drivers compile them while Mesa does not. Even if they're written poorly, I imagine Mesa could add compatibility support to

Re: [Mesa-dev] [PATCH 23/27] i965: Start and stop OA counters as necessary.

2013-11-14 Thread Daniel Vetter
On Wed, Nov 13, 2013 at 09:05:48PM -0800, Kenneth Graunke wrote: We need to start OA at the beginning of each batch where monitors are active. OACONTROL isn't part of the hardware context, so to avoid leaving counters enabled for other applications, we turn them off at the end of the batch

Re: [Mesa-dev] [PATCH 1/4] mesa: Update a comment about valid values of a field.

2013-11-14 Thread Brian Paul
On 11/13/2013 04:11 PM, Eric Anholt wrote: Notably, ENV and LOCAL aren't used any more (replaced by STATE_VAR), but apparently CONSTANT is. --- src/mesa/program/program_parser.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/program/program_parser.h

[Mesa-dev] [PATCH] clover: Support multiple devices in clCreateContextFromType() v2

2013-11-14 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com v2: - Use clGetDeviceIDs to query devices. CC: 10.0 mesa-sta...@lists.freedesktop.org --- src/gallium/state_trackers/clover/api/context.cpp | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git

[Mesa-dev] [PATCH] radeon/compute: Unconditionally inline all functions

2013-11-14 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com We need to do this until function calls are supported. https://bugs.freedesktop.org/show_bug.cgi?id=64225 CC: 10.0 mesa-sta...@lists.freedesktop.org --- src/gallium/drivers/radeon/radeon_llvm_util.c | 24 ++-- 1 file changed, 22

[Mesa-dev] [Bug 71591] Second Life shaders fail to compile

2013-11-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=71591 José Fonseca jfons...@vmware.com changed: What|Removed |Added CC||bri...@vmware.com,

Re: [Mesa-dev] [PATCH] clover: Support multiple devices in clCreateContextFromType() v2

2013-11-14 Thread Francisco Jerez
Tom Stellard t...@stellard.net writes: From: Tom Stellard thomas.stell...@amd.com v2: - Use clGetDeviceIDs to query devices. CC: 10.0 mesa-sta...@lists.freedesktop.org Thank you, this patch is: Reviewed-by: Francisco Jerez curroje...@riseup.net ---

Re: [Mesa-dev] [PATCH] radeon/compute: Unconditionally inline all functions

2013-11-14 Thread Aaron Watry
On Thu, Nov 14, 2013 at 10:29 AM, Tom Stellard t...@stellard.net wrote: From: Tom Stellard thomas.stell...@amd.com We need to do this until function calls are supported. https://bugs.freedesktop.org/show_bug.cgi?id=64225 CC: 10.0 mesa-sta...@lists.freedesktop.org ---

Re: [Mesa-dev] [PATCH] radeon/compute: Unconditionally inline all functions

2013-11-14 Thread Tom Stellard
On Thu, Nov 14, 2013 at 11:38:06AM -0600, Aaron Watry wrote: On Thu, Nov 14, 2013 at 10:29 AM, Tom Stellard t...@stellard.net wrote: From: Tom Stellard thomas.stell...@amd.com We need to do this until function calls are supported. https://bugs.freedesktop.org/show_bug.cgi?id=64225

[Mesa-dev] [PATCH 0/3 v2] More radeon/llvm memory leak fixes

2013-11-14 Thread Aaron Watry
With the 3 attached patches and a previous series of 6 patches, I can now launch glxgears on Evergreen without any definite memory leaks according to: valgrind --leak-check=full glxgears I've run this through piglit/tests/quick.tests without any regressions. I don't have commit access (yet), so

[Mesa-dev] [PATCH 3/3] radeon/llvm: Free elf_buffer after use

2013-11-14 Thread Aaron Watry
Prevents a memory leak. v2: Remove null check --- src/gallium/drivers/radeon/radeon_llvm_emit.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/radeon/radeon_llvm_emit.c b/src/gallium/drivers/radeon/radeon_llvm_emit.c index d2e5642..92e7dbc 100644 ---

[Mesa-dev] [PATCH 1/3] r600/llvm: initialize radeon_llvm_binary

2013-11-14 Thread Aaron Watry
use memset to initialize to 0's... otherwise code_size and config_size could be uninitialized when read later in this method. It's also hard to do NULL checks on uninitialized pointers. Reviewed-by: Tom Stellard thomas.stell...@amd.com v2: Fix indentation ---

[Mesa-dev] [PATCH 2/3] r600/llvm: Free binary.code/binary.config in r600_llvm_compile

2013-11-14 Thread Aaron Watry
radeon_llvm_compile allocates memory for binary.code, binary.config, or neither depending on what's being done. We need to make sure to free that memory after it's no longer needed. v2: Don't bother checking for null before FREE() --- src/gallium/drivers/r600/r600_llvm.c | 3 +++ 1 file

Re: [Mesa-dev] [Mesa-stable] [PATCH] haiku/swrast: Inherit gl_config, fix flush

2013-11-14 Thread Francisco Jerez
Alexander von Gluck IV kallis...@unixzen.com writes: * Inherit gl_context so we always have access to it * Thanks curro for the idea. * Last Haiku cannidate for 10.0.0 If you remove the redundant 'if (!this) {...}', this patch is: Reviewed-by: Francisco Jerez curroje...@riseup.net ---

[Mesa-dev] [PATCH] i965: Assert that IF with cmod is Gen6 only.

2013-11-14 Thread Matt Turner
--- src/mesa/drivers/dri/i965/brw_fs.cpp | 4 ++-- src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp index 292eeb3..2cc1da5 100644 ---

Re: [Mesa-dev] [PATCH] i965: Assert that IF with cmod is Gen6 only.

2013-11-14 Thread Kenneth Graunke
On 11/14/2013 10:42 AM, Matt Turner wrote: --- src/mesa/drivers/dri/i965/brw_fs.cpp | 4 ++-- src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp

Re: [Mesa-dev] [PATCH 1/2] Increase array sizes to what they should be.

2013-11-14 Thread Eric Anholt
Petri Latvala petri.latv...@intel.com writes: vec4_visitor's uniform_size and uniform_vector_size arrays contain information about uniforms. Their size should be the number of uniform components (MAX_UNIFORMS * 4) instead of number of uniform vec4s (MAX_UNIFORMS). Instead of making our giant

[Mesa-dev] [PATCH 2/2] svga: print warning for unsupported indirect dest reg indexing

2013-11-14 Thread Brian Paul
For DX9-level shaders, there's only limited support for indirect indexing of registers (with the loop counter register, not the general address register.) --- src/gallium/drivers/svga/svga_tgsi_insn.c |4 1 file changed, 4 insertions(+) diff --git

[Mesa-dev] [PATCH 1/2] svga: mark dest image as defined in svga_surface_copy()

2013-11-14 Thread Brian Paul
After we blit/copy to a dest texture image we need to mark it as being defined. This fixes broken mipmap generation for quite a few texture formats. Mipgen involves making texture views and svga_texture_view_surface() skips texture images that are undefined. ---

Re: [Mesa-dev] [PATCH] i965/gen7: Emit workaround flush when changing GS enable state.

2013-11-14 Thread Kenneth Graunke
On 11/04/2013 08:10 PM, Paul Berry wrote: --- src/mesa/drivers/dri/i965/brw_context.h | 44 +++ src/mesa/drivers/dri/i965/gen7_blorp.cpp | 8 + src/mesa/drivers/dri/i965/gen7_gs_state.c | 18 +++ src/mesa/drivers/dri/i965/gen7_urb.c

Re: [Mesa-dev] [PATCH] glsl: Rework interface block linking.

2013-11-14 Thread Ian Romanick
Man... linkers are the most complex pieces of software. :( I only have one significant comment (the second below) and three nits / questions. With at least the first one resolved, this patch is Reviewed-by: Ian Romanick ian.d.roman...@intel.com On 10/30/2013 04:33 PM, Paul Berry wrote:

Re: [Mesa-dev] [PATCH 2/4] i965: Use drm_intel_get_aperture_sizes instead of hard-coded 2GiB

2013-11-14 Thread Kenneth Graunke
On 11/11/2013 11:19 AM, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com Systems with little physical memory installed will report less than 2GiB, and some systems may (hypothetically?) have a larger address space for the GPU. My IVB still reports 1534. Signed-off-by: Ian

Re: [Mesa-dev] [PATCH 1/2] Increase array sizes to what they should be.

2013-11-14 Thread Kenneth Graunke
On 11/14/2013 01:19 PM, Eric Anholt wrote: Petri Latvala petri.latv...@intel.com writes: vec4_visitor's uniform_size and uniform_vector_size arrays contain information about uniforms. Their size should be the number of uniform components (MAX_UNIFORMS * 4) instead of number of uniform vec4s

Re: [Mesa-dev] [PATCH 1/4] mesa: Update a comment about valid values of a field.

2013-11-14 Thread Ian Romanick
On 11/13/2013 03:11 PM, Eric Anholt wrote: Notably, ENV and LOCAL aren't used any more (replaced by STATE_VAR), but apparently CONSTANT is. Good times. Reviewed-by: Ian Romanick ian.d.roman...@intel.com --- src/mesa/program/program_parser.h | 2 +- 1 file changed, 1 insertion(+), 1

Re: [Mesa-dev] [PATCH 06/27] mesa: Store the performance monitor object's name.

2013-11-14 Thread Ian Romanick
Patches 6, 7, 8, and 9 are Reviewed-by: Ian Romanick ian.d.roman...@intel.com On 11/13/2013 05:52 PM, Kenneth Graunke wrote: Being able to print monitor-Name is really useful for debugging. Signed-off-by: Kenneth Graunke kenn...@whitecape.org Cc: Eric Anholt e...@anholt.net Cc: Carl Worth

Re: [Mesa-dev] [PATCH 2/2] mesa: move glDraw-related functions into new draw.[ch] files

2013-11-14 Thread Ian Romanick
On 11/13/2013 10:38 AM, Brian Paul wrote: To trim down the varray.c file so it's just vertex array functions. Is that the only motivation? This will prevent us from optimizing the implementation of, say, _mesa_MultiDrawArrays. It also seems weird that _mesa_MultiDrawModeDrawArraysIBM

Re: [Mesa-dev] [PATCH] i965: Assert that IF with cmod is Gen6 only.

2013-11-14 Thread Eric Anholt
Reviewed-by: Eric Anholt e...@anholt.net pgpf66DHKGzLM.pgp Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/2] mesa: move glDraw-related functions into new draw.[ch] files

2013-11-14 Thread Brian Paul
On 11/14/2013 04:14 PM, Ian Romanick wrote: On 11/13/2013 10:38 AM, Brian Paul wrote: To trim down the varray.c file so it's just vertex array functions. Is that the only motivation? For now, yes. I'm just trying to de-clutter varray.[ch] This will prevent us from optimizing the

Re: [Mesa-dev] [PATCH] R600: Make sure OQAP defs and uses happen in the same clause

2013-11-14 Thread Vincent Lejeune
This patch is : reviewed-by: Vincent Lejeunevljn at ovi.com - Mail original - De : Tom Stellard t...@stellard.net À : Vincent Lejeune v...@ovi.com Cc : mesa-dev@lists.freedesktop.org mesa-dev@lists.freedesktop.org; llvm-comm...@cs.uiuc.edu llvm-comm...@cs.uiuc.edu; Tom Stellard

Re: [Mesa-dev] [PATCH] R600/SI: Add processor type for Hawaii

2013-11-14 Thread Tom Stellard
On Wed, Nov 13, 2013 at 03:13:55PM -0500, Alex Deucher wrote: On Wed, Nov 13, 2013 at 1:12 PM, Tom Stellard t...@stellard.net wrote: On Wed, Nov 13, 2013 at 12:27:05PM -0500, Alex Deucher wrote: Signed-off-by: Alex Deucher alexander.deuc...@amd.com Reviewed-by: Tom Stellard

[Mesa-dev] [PATCH 1/2] mesa: Add gl_formats to cover all GLUser provided format/type combinations

2013-11-14 Thread Mark Mueller
This and the subsequent patch are the first steps in adding support to load textures via GPU instead of CPU. This patch expands Mesa's gl_formats such that all GLUser format/type combinations are represented and thus can be communicated to lower levels within dri drivers. The new formats are

[Mesa-dev] [i965] Allow blorp to make decisions about the formats that it supports where it can

2013-11-14 Thread Mark Mueller
This patch consolidates the decision about formats that blorp_blt does and does not support to blorp instead of leaving that decision to callers. This opens the door to adding more functionality to blorp, including support for using GPU acceleration of processing and loading textures. This patch

[Mesa-dev] [PATCH 2/2] i965: Allow blorp to make decisions about the formats that it supports where it can

2013-11-14 Thread Mark Mueller
fixed subject line On Thu, Nov 14, 2013 at 4:15 PM, Mark Mueller markkmuel...@gmail.comwrote: This patch consolidates the decision about formats that blorp_blt does and does not support to blorp instead of leaving that decision to callers. This opens the door to adding more functionality to

Re: [Mesa-dev] [PATCH 2/2] i965: Allow blorp to make decisions about the formats that it supports where it can

2013-11-14 Thread Chris Forbes
Why does this affect that piglit test? -- Chris On Fri, Nov 15, 2013 at 2:01 PM, Mark Mueller markkmuel...@gmail.com wrote: fixed subject line On Thu, Nov 14, 2013 at 4:15 PM, Mark Mueller markkmuel...@gmail.com wrote: This patch consolidates the decision about formats that blorp_blt does

Re: [Mesa-dev] [PATCH 2/2] i965: Allow blorp to make decisions about the formats that it supports where it can

2013-11-14 Thread Mark Mueller
On Thu, Nov 14, 2013 at 5:18 PM, Chris Forbes chr...@ijw.co.nz wrote: Why does this affect that piglit test? Oh wait, it was patch 1/2 that fixed that test. Do I still need to answer the question? :) 1/2 made no significant functional changes so I don't have an explanation, but I will do some

Re: [Mesa-dev] [PATCH 2/2] i965: Allow blorp to make decisions about the formats that it supports where it can

2013-11-14 Thread Matt Turner
On Thu, Nov 14, 2013 at 5:39 PM, Mark Mueller markkmuel...@gmail.com wrote: On Thu, Nov 14, 2013 at 5:18 PM, Chris Forbes chr...@ijw.co.nz wrote: Why does this affect that piglit test? Oh wait, it was patch 1/2 that fixed that test. Do I still need to answer the question? :) 1/2 made no

[Mesa-dev] [PATCH] i965/gen7: Emit workaround flush when changing GS enable state.

2013-11-14 Thread Paul Berry
v2: Don't go to extra work to avoid extraneous flushes. (Previous experiments in the kernel have suggested that flushing the pipeline when it is already empty is extremely cheap). Cc: 10.0 mesa-sta...@lists.freedesktop.org --- src/mesa/drivers/dri/i965/brw_context.c | 1 +

Re: [Mesa-dev] [PATCH 1/5] glsl: Move the CSE equality functions to the ir class.

2013-11-14 Thread Jordan Justen
I think you mentioned that you've merged Chris's d2573509 into this already. With that change, Reviewed-by: Jordan Justen jordan.l.jus...@intel.com On Thu, Nov 7, 2013 at 1:58 PM, Eric Anholt e...@anholt.net wrote: I want to reuse them in opt_algebraic. --- src/glsl/Makefile.sources | 1 +

[Mesa-dev] [PATCH] i965: Add missing break in SHADER_OPCODE_GEN7_SCRATCH_READ case.

2013-11-14 Thread Vinson Lee
Fixes Missing break in switch defect reported by Coverity. Signed-off-by: Vinson Lee v...@freedesktop.org --- src/mesa/drivers/dri/i965/brw_schedule_instructions.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_schedule_instructions.cpp