[Mesa-dev] [PATCH] [RFC] st/mesa: overhaul texture maxlevel handling and fallout

2014-04-10 Thread Dave Airlie
So I wanted to implement ARB_texture_query_levels, in order to get the right answers I had to make sure the gallium texture has the same levels as the mesa one, so the hw is programmed correctly. This led to some fallout as we were suddenly hitting the finalize texture reallocation path in cases

[Mesa-dev] [Bug 77263] New: [BDW GT3]System hangs while running glxgear with SNA

2014-04-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77263 Priority: medium Bug ID: 77263 Assignee: mesa-dev@lists.freedesktop.org Summary: [BDW GT3]System hangs while running glxgear with SNA Severity: normal Classification: Unclassified

[Mesa-dev] [Bug 77263] [BDW GT3]System hangs while running glxgear with SNA

2014-04-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77263 Guo Jinxian jinxianx@intel.com changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop.

Re: [Mesa-dev] [PATCH 1/5] mesa: use malloc/free instead of MALLOC/FREE in attrib stack code

2014-04-10 Thread Jakob Bornecrantz
On Thu, Apr 10, 2014 at 4:41 AM, Kenneth Graunke kenn...@whitecape.org wrote: On 04/09/2014 06:39 PM, Brian Paul wrote: We moved away from MALLOC/FREE in the rest of core Mesa a while ago. --- src/mesa/main/attrib.c | 20 ++-- 1 file changed, 10 insertions(+), 10

Re: [Mesa-dev] [PATCH] st/mesa: fix sampler_view REALLOC/FREE macro mix-up

2014-04-10 Thread Jakob Bornecrantz
On Thu, Apr 10, 2014 at 3:26 AM, Brian Paul bri...@vmware.com wrote: We were using REALLOC() from u_memory.h but FREE() from imports.h. This mismatch caused us to trash the heap on Windows after we deleted a texture object. This fixes a regression from commit 6c59be7776e4d. ---

Re: [Mesa-dev] [PATCH 03/10] mesa: add new enum MAX_UNIFORM_LOCATIONS

2014-04-10 Thread Tapani Pälli
On 04/09/2014 02:17 PM, Petri Latvala wrote: On 04/09/2014 12:56 PM, Tapani Pälli wrote: diff --git a/src/mesa/main/get_hash_params.py b/src/mesa/main/get_hash_params.py index 06d0bba..5709d42 100644 --- a/src/mesa/main/get_hash_params.py +++ b/src/mesa/main/get_hash_params.py @@ -474,6

Re: [Mesa-dev] [PATCH] i965: fix MakeCurrent when switching a context between multiple drawables.

2014-04-10 Thread Iago Toral
Hi Kristian, On Tue, 2014-04-08 at 10:14 -0700, Kristian Høgsberg wrote: On Mon, Apr 7, 2014 at 9:24 AM, Eric Anholt e...@anholt.net wrote: Iago Toral Quiroga ito...@igalia.com writes: Commit 11baad35088dfd4bdabc1710df650dbfb413e7a3 produces a regression when switching a single context

[Mesa-dev] [RFC] r600g/radeonsi: Use caching buffer manager for textures as well

2014-04-10 Thread Michel Dänzer
From: Michel Dänzer michel.daen...@amd.com --- This is just an RFC; if other developers approve of this approach, I can make a more extensive patch removing the use_reusable_pool parameters. The x11perf numbers below compare ShmGet/PutImage before and after this change with glamor from keithp's

Re: [Mesa-dev] [PATCH 3/5] mesa: s/FREE/free/ in vdpau code

2014-04-10 Thread Christian König
Am 10.04.2014 03:39, schrieb Brian Paul: --- src/mesa/main/vdpau.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mesa/main/vdpau.c b/src/mesa/main/vdpau.c index c2cf206..d974593 100644 --- a/src/mesa/main/vdpau.c +++ b/src/mesa/main/vdpau.c @@ -88,7 +88,7

Re: [Mesa-dev] [PATCH] i965: fix MakeCurrent when switching a context between multiple drawables.

2014-04-10 Thread Iago Toral
On Thu, 2014-04-10 at 10:31 +0200, Iago Toral wrote: Hi Kristian, On Tue, 2014-04-08 at 10:14 -0700, Kristian Høgsberg wrote: On Mon, Apr 7, 2014 at 9:24 AM, Eric Anholt e...@anholt.net wrote: Iago Toral Quiroga ito...@igalia.com writes: Commit

Re: [Mesa-dev] [RFC] r600g/radeonsi: Use caching buffer manager for textures as well

2014-04-10 Thread Marek Olšák
Hi Michel, I was thinking of doing this for transfers only, because Glamor does a lot of transfers. What do you think? Marek On Thu, Apr 10, 2014 at 11:23 AM, Michel Dänzer mic...@daenzer.net wrote: From: Michel Dänzer michel.daen...@amd.com --- This is just an RFC; if other developers

Re: [Mesa-dev] [PATCH] st/mesa: fix sampler_view REALLOC/FREE macro mix-up

2014-04-10 Thread Christian König
Am 10.04.2014 03:26, schrieb Brian Paul: We were using REALLOC() from u_memory.h but FREE() from imports.h. This mismatch caused us to trash the heap on Windows after we deleted a texture object. This fixes a regression from commit 6c59be7776e4d. Reviewed-by: Christian König

Re: [Mesa-dev] [PATCH 2/2] mesa/st: set min/max texture gather offset to driver-reported value

2014-04-10 Thread Marek Olšák
For the series: Reviewed-by: Marek Olšák marek.ol...@amd.com Marek On Thu, Apr 10, 2014 at 5:30 AM, Ilia Mirkin imir...@alum.mit.edu wrote: It was always getting set to -8/7 unconditionally. Use the driver-reported value instead. Signed-off-by: Ilia Mirkin imir...@alum.mit.edu ---

Re: [Mesa-dev] [RFC] r600g/radeonsi: Use caching buffer manager for textures as well

2014-04-10 Thread Grigori Goronzy
On 10.04.2014 11:23, Michel Dänzer wrote: From: Michel Dänzer michel.daen...@amd.com --- This is just an RFC; if other developers approve of this approach, I can make a more extensive patch removing the use_reusable_pool parameters. The x11perf numbers below compare ShmGet/PutImage before and

Re: [Mesa-dev] [PATCH 1/5] i965: Add writes_accumulator flag

2014-04-10 Thread Juha-Pekka Heikkilä
Hi Matt, the changed set looks good to me, I did side by side comparison on what had changed but did not try to run it today. I realized immediately when seeing your comment I had not understood to consider the WAR vs. RAW comments in the scheduler. I was thinking when I made the latest set the

Re: [Mesa-dev] [PATCH] st/mesa: fix sampler_view REALLOC/FREE macro mix-up

2014-04-10 Thread Jose Fonseca
To prevent this to ocurr again in the future we should be probably using os_malloc/os_free and friends instead of the overloaded MALLOC/FREE/etc macros. We should probably kill MALLOC/FREE completely. Jose - Original Message - We were using REALLOC() from u_memory.h but FREE() from

Re: [Mesa-dev] [PATCH 3/3] i965: Add writes_accumulator flag

2014-04-10 Thread Juha-Pekka Heikkilä
On Thu, Apr 10, 2014 at 1:18 AM, Kenneth Graunke kenn...@whitecape.org wrote: On 04/09/2014 01:47 PM, Matt Turner wrote: From: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com Our hardware has an accumulator register, which can be used to store intermediate results across multiple

Re: [Mesa-dev] [PATCH 0/8] Native GBM backends and map/unmap support

2014-04-10 Thread Jammy Zhou
2014-03-24 19:55 GMT+08:00 Ander Conselvan de Oliveira conselv...@gmail.com : On 03/17/2014 11:05 AM, Jammy Zhou wrote: Hi Ander, Some comments inline. And I have some further thinking about current GBM support, which is tied to specific implementation closely, although the GBM APIs are

Re: [Mesa-dev] [PATCH] st/mesa: fix sampler_view REALLOC/FREE macro mix-up

2014-04-10 Thread Brian Paul
On 04/10/2014 01:43 AM, Jakob Bornecrantz wrote: On Thu, Apr 10, 2014 at 3:26 AM, Brian Paul bri...@vmware.com wrote: We were using REALLOC() from u_memory.h but FREE() from imports.h. This mismatch caused us to trash the heap on Windows after we deleted a texture object. This fixes a

Re: [Mesa-dev] [PATCH 1/4] glxinfo: Print XFB, TBO, and UBO limits

2014-04-10 Thread Brian Paul
On 04/09/2014 07:51 PM, Fredrik Höglund wrote: --- src/xdemos/glxinfo.c | 22 ++ 1 file changed, 22 insertions(+) For the series: Reviewed-by: Brian Paul bri...@vmware.com ___ mesa-dev mailing list

[Mesa-dev] R600/OpenCL - kernel_param resource

2014-04-10 Thread Dorrington, Albert
I am having an issue with a memory leak in an OpenCL program I am testing. In the program I call the same kernel repeatedly, for every pixel in an image. (Probably not the most efficient code, but it is a learning/testing thing.) One thing in particular I have not yet been able to figure out, is

Re: [Mesa-dev] [PATCH] st/mesa: fix sampler_view REALLOC/FREE macro mix-up

2014-04-10 Thread Jakob Bornecrantz
On 10 Apr 2014 15:56, Brian Paul bri...@vmware.com wrote: On 04/10/2014 01:43 AM, Jakob Bornecrantz wrote: On Thu, Apr 10, 2014 at 3:26 AM, Brian Paul bri...@vmware.com wrote: We were using REALLOC() from u_memory.h but FREE() from imports.h. This mismatch caused us to trash the heap on

[Mesa-dev] [PATCH] i965: Fix missing _NEW_SCISSOR in Broadwell SF_CLIP_VIEWPORT state.

2014-04-10 Thread Kenneth Graunke
The _Xmin/_Xmax/_Ymin/_Ymax values need to be guarded by _NEW_SCISSOR. Fixes Piglit's scissor-many, and rendering in GNOME Shell. Hopefully fixes similar issues with Unity and ChromeOS. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=75879 Signed-off-by: Kenneth Graunke

Re: [Mesa-dev] [PATCH 4/4] glxinfo: Remove the ARB suffixes from core enums

2014-04-10 Thread Ian Romanick
On 04/09/2014 06:51 PM, Fredrik Höglund wrote: The suffix is only removed from the printed names in case someone wants to build glxinfo against an old implementation. Isn't that already impossible due to GL_MAX_VERTEX_OUTPUT_COMPONENTS? To be honest... I'd like to see all of the '#ifdef

Re: [Mesa-dev] [PATCH 5/7] linker: Set block bindings based on UniformBlocks rather than UniformStorage

2014-04-10 Thread Ian Romanick
On 04/09/2014 08:09 AM, Kenneth Graunke wrote: On 04/04/2014 02:01 PM, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com For blocks, gl_shader_program::UniformStorage isn't very useful. The names stored there are the names of the elements of the block, so finding blocks with

Re: [Mesa-dev] [PATCH 3/7] linker: Fold set_uniform_binding into call site

2014-04-10 Thread Ian Romanick
On 04/09/2014 08:02 AM, Kenneth Graunke wrote: On 04/04/2014 02:01 PM, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com In the next patch, we'll see that using gl_shader_program::UniformStorage is not correct for uniform blocks. That means we can't use ::UniformStorage to

Re: [Mesa-dev] [PATCH 1/7] linker: Split set_uniform_binding into separate functions for blocks and samplers

2014-04-10 Thread Ian Romanick
On 04/09/2014 09:10 AM, Kenneth Graunke wrote: On 04/04/2014 02:01 PM, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com The two code paths are quite different, and there are some problems in the handling of uniform blocks. Future changes will cause these paths to diverge

Re: [Mesa-dev] [PATCH] i965: Fix missing _NEW_SCISSOR in Broadwell SF_CLIP_VIEWPORT state.

2014-04-10 Thread Eric Anholt
Kenneth Graunke kenn...@whitecape.org writes: The _Xmin/_Xmax/_Ymin/_Ymax values need to be guarded by _NEW_SCISSOR. Fixes Piglit's scissor-many, and rendering in GNOME Shell. Hopefully fixes similar issues with Unity and ChromeOS. Bugzilla:

Re: [Mesa-dev] [PATCH] i965: fix MakeCurrent when switching a context between multiple drawables.

2014-04-10 Thread Ian Romanick
On 04/10/2014 03:39 AM, Iago Toral wrote: On Thu, 2014-04-10 at 10:31 +0200, Iago Toral wrote: Hi Kristian, On Tue, 2014-04-08 at 10:14 -0700, Kristian Høgsberg wrote: On Mon, Apr 7, 2014 at 9:24 AM, Eric Anholt e...@anholt.net wrote: Iago Toral Quiroga ito...@igalia.com writes: Commit

[Mesa-dev] [Bug 77286] New: Missing GLES 1.x symbols

2014-04-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77286 Priority: medium Bug ID: 77286 Assignee: mesa-dev@lists.freedesktop.org Summary: Missing GLES 1.x symbols Severity: normal Classification: Unclassified OS: Linux (All)

[Mesa-dev] [Bug 77286] Missing GLES 1.x symbols

2014-04-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77286 Dylan baker.dyla...@gmail.com changed: What|Removed |Added CC||baker.dyla...@gmail.com,

[Mesa-dev] [Bug 77286] Missing GLES 1.x symbols

2014-04-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77286 Dylan baker.dyla...@gmail.com changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |i...@freedesktop.org

Re: [Mesa-dev] [PATCH 1/7] linker: Split set_uniform_binding into separate functions for blocks and samplers

2014-04-10 Thread Ian Romanick
On 04/10/2014 12:04 PM, Ian Romanick wrote: On 04/09/2014 09:10 AM, Kenneth Graunke wrote: On 04/04/2014 02:01 PM, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com The two code paths are quite different, and there are some problems in the handling of uniform blocks. Future

[Mesa-dev] [Bug 77288] New: [swrast] piglit glean glsl1 regression

2014-04-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77288 Priority: medium Bug ID: 77288 Keywords: have-backtrace, regression CC: e...@anholt.net, kenn...@whitecape.org Assignee: mesa-dev@lists.freedesktop.org Summary: [swrast] piglit

Re: [Mesa-dev] [PATCH] i965: Fill in a bunch of gen7/hsw data cache-related disasm.

2014-04-10 Thread Matt Turner
On Mon, Mar 31, 2014 at 1:48 PM, Eric Anholt e...@anholt.net wrote: This gets us disasm of atomic ops. --- src/mesa/drivers/dri/i965/brw_disasm.c | 113 +++-- 1 file changed, 106 insertions(+), 7 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_disasm.c

Re: [Mesa-dev] [PATCH 3/7] linker: Fold set_uniform_binding into call site

2014-04-10 Thread Kenneth Graunke
On 04/10/2014 11:42 AM, Ian Romanick wrote: On 04/09/2014 08:02 AM, Kenneth Graunke wrote: On 04/04/2014 02:01 PM, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com In the next patch, we'll see that using gl_shader_program::UniformStorage is not correct for uniform blocks.

[Mesa-dev] [PATCH 3/4] mesa: use _mesa_get_srgb_format_linear() in sRGB texstore functions

2014-04-10 Thread Brian Paul
Instead of switch statements. --- src/mesa/main/texstore.c | 30 +- 1 file changed, 5 insertions(+), 25 deletions(-) diff --git a/src/mesa/main/texstore.c b/src/mesa/main/texstore.c index fe3b072..d9096ab 100644 --- a/src/mesa/main/texstore.c +++

[Mesa-dev] [PATCH 4/4] softpipe: add PIPE_CAP_MIN/MAX_TEXTURE_GATHER_OFFSET query cases

2014-04-10 Thread Brian Paul
To silence compiler warnings. --- src/gallium/drivers/softpipe/sp_screen.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/drivers/softpipe/sp_screen.c b/src/gallium/drivers/softpipe/sp_screen.c index ce04fb8..b4ca728 100644 --- a/src/gallium/drivers/softpipe/sp_screen.c

[Mesa-dev] [PATCH 1/4] swrast: fix more fetch_texel function names

2014-04-10 Thread Brian Paul
These were missed/typo'd in the previous patch series: s/R8G8B8A/R8G8B8A8/ s/rgba_16/RGBA_UNORM16/ s/rgba_uint/RGBA_UINT/ s/rgba_int/RGBA_SINT/ --- src/mesa/swrast/s_texfetch.c | 48 +++--- src/mesa/swrast/s_texfetch_tmp.h | 26 ++--- 2

[Mesa-dev] [PATCH 2/4] swrast: use macros to initialize texfetch_funcs[] table

2014-04-10 Thread Brian Paul
--- src/mesa/swrast/s_texfetch.c | 1109 +++--- 1 file changed, 172 insertions(+), 937 deletions(-) diff --git a/src/mesa/swrast/s_texfetch.c b/src/mesa/swrast/s_texfetch.c index 2a6eee0..90a514c 100644 --- a/src/mesa/swrast/s_texfetch.c +++

Re: [Mesa-dev] [PATCH 4/4] softpipe: add PIPE_CAP_MIN/MAX_TEXTURE_GATHER_OFFSET query cases

2014-04-10 Thread Ilia Mirkin
On Thu, Apr 10, 2014 at 9:04 PM, Brian Paul bri...@vmware.com wrote: To silence compiler warnings. Reviewed-by: Ilia Mirkin imir...@alum.mit.edu Sorry I missed sp_screen.c :( I thought I had gotten everything. --- src/gallium/drivers/softpipe/sp_screen.c |3 +++ 1 file changed, 3

Re: [Mesa-dev] [PATCH 3/4] mesa: use _mesa_get_srgb_format_linear() in sRGB texstore functions

2014-04-10 Thread Chris Forbes
I was about to get to this, really! :P This patch is: Reviewed-by: Chris Forbes chr...@ijw.co.nz On Fri, Apr 11, 2014 at 1:04 PM, Brian Paul bri...@vmware.com wrote: Instead of switch statements. --- src/mesa/main/texstore.c | 30 +- 1 file changed, 5

Re: [Mesa-dev] [PATCH] i965: fix MakeCurrent when switching a context between multiple drawables.

2014-04-10 Thread Michel Dänzer
On Don, 2014-04-10 at 12:22 -0700, Ian Romanick wrote: On 04/10/2014 03:39 AM, Iago Toral wrote: On Thu, 2014-04-10 at 10:31 +0200, Iago Toral wrote: Hi Kristian, On Tue, 2014-04-08 at 10:14 -0700, Kristian Høgsberg wrote: On Mon, Apr 7, 2014 at 9:24 AM, Eric Anholt e...@anholt.net

[Mesa-dev] [PATCH] gallium/targets: #include radeon_winsys.h in a couple of more places

2014-04-10 Thread Michel Dänzer
From: Michel Dänzer michel.daen...@amd.com Fixes the build since Marek's recent radeon winsys reorganization. Signed-off-by: Michel Dänzer michel.daen...@amd.com --- src/gallium/targets/egl-static/egl_pipe.c | 1 + src/gallium/targets/pipe-loader/pipe_r300.c | 1 +