[Mesa-dev] [PATCH] st/xa: Fix performance regression introduced by commit Cache render target surface

2014-05-08 Thread Thomas Hellstrom
The mentioned commit has the nasty side-effect of turning off accelerated copies. Cc: 10.1 10.2 mesa-sta...@lists.freedekstop.org Signed-off-by: Thomas Hellstrom thellst...@vmware.com --- src/gallium/state_trackers/xa/xa_context.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH 0/8] Radeon various patches

2014-05-08 Thread Michel Dänzer
On 07.05.2014 22:53, Marek Olšák wrote: This patch set mostly contains cosmetic changes that I made while adding support for sample shading. Marek Olšák (8): r600g: simplify framebuffer state size computation radeonsi: use DRAW_PREAMBLE on CIK radeonsi: remove unused

Re: [Mesa-dev] [PATCH 2/4] i965/Gen8: Set up layer constraints properly for renderbuffers

2014-05-08 Thread Kenneth Graunke
On 05/07/2014 10:21 PM, Chris Forbes wrote: Fixing the same issues the previous commit does for Gen7. Note that I can't test this one, since I don't have a Broadwell. Signed-off-by: Chris Forbes chr...@ijw.co.nz --- src/mesa/drivers/dri/i965/gen8_surface_state.c | 15 +-- 1

Re: [Mesa-dev] Mixing of hardware and software renderers

2014-05-08 Thread Erik Faye-Lund
On Tue, May 6, 2014 at 6:51 AM, Patrick McMunn doctorwho...@gmail.com wrote: I'm using some older hardware - an ATI Radeon 9200 - which can only handle up to OpenGL 1.2. I was wondering if it's possible to use the hardware renderer generally and have the driver hand off the handling of

[Mesa-dev] [PATCH] i965: Avoid redundant call to brw_merge_inputs() in brw_try_draw_prims()

2014-05-08 Thread Iago Toral Quiroga
We always call brw_merge_inputs() right before looping over the primitives but this can be called inside the loop for each primitive too. In the case we do it for the first primitive the call is redundant and can be skipped. --- src/mesa/drivers/dri/i965/brw_draw.c | 13 ++--- 1 file

[Mesa-dev] [Bug 78393] Black zebra like lines while playing games on open source drivers

2014-05-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=78393 --- Comment #2 from Henri Verbeet hverb...@gmail.com --- It's pretty hard to say anything useful without logs, but one thing that regularly seems to cause this kind of thing for people is missing S3TC support. -- You are receiving this mail

Re: [Mesa-dev] [PATCH] st/xa: Fix performance regression introduced by commit Cache render target surface

2014-05-08 Thread Jakob Bornecrantz
On Thu, May 8, 2014 at 9:15 AM, Thomas Hellstrom thellst...@vmware.com wrote: The mentioned commit has the nasty side-effect of turning off accelerated copies. Cc: 10.1 10.2 mesa-sta...@lists.freedekstop.org Signed-off-by: Thomas Hellstrom thellst...@vmware.com ---

Re: [Mesa-dev] [PATCH] st/xa: Fix performance regression introduced by commit Cache render target surface

2014-05-08 Thread Jakob Bornecrantz
On Thu, May 8, 2014 at 9:15 AM, Thomas Hellstrom thellst...@vmware.com wrote: The mentioned commit has the nasty side-effect of turning off accelerated copies. Cc: 10.1 10.2 mesa-sta...@lists.freedekstop.org Signed-off-by: Thomas Hellstrom thellst...@vmware.com ---

[Mesa-dev] [PATCH] mesa/st: provide native integers implementation of ir_unop_any

2014-05-08 Thread Ilia Mirkin
Previously, ir_unop_any was implemented via a dot-product call, which uses floating point multiplication and addition. The multiplication was completely pointless, and the addition can just as well be done with an or. Since we know that the inputs are booleans, they must already be in canonical

[Mesa-dev] [PATCH] i965: fix size assert for gen7 in brw_init_compaction_tables()

2014-05-08 Thread Samuel Iglesias Gonsalvez
It should compare with it's own size. Signed-off-by: Samuel Iglesias Gonsalvez sigles...@igalia.com --- src/mesa/drivers/dri/i965/brw_eu_compact.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_eu_compact.c

Re: [Mesa-dev] odd translation from glsl to tgsi for ir_unop_any_nequal

2014-05-08 Thread Ilia Mirkin
On Wed, May 7, 2014 at 10:55 PM, Ilia Mirkin imir...@alum.mit.edu wrote: On Wed, May 7, 2014 at 8:38 PM, Ilia Mirkin imir...@alum.mit.edu wrote: So... this shader (from generated_tests/spec/glsl-1.10/execution/built-in-functions/fs-op-eq-mat2-mat2.shader_test): uniform mat2 arg0; uniform

[Mesa-dev] [Bug 78393] Black zebra like lines while playing games on open source drivers

2014-05-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=78393 --- Comment #3 from incarnated...@gmail.com --- I just read your other email this morning Michel. I would love to provide but I do not know how to do that for mesa or bisecting. -- You are receiving this mail because: You are the assignee for

Re: [Mesa-dev] [PATCH] i965: fix size assert for gen7 in brw_init_compaction_tables()

2014-05-08 Thread Eric Anholt
Samuel Iglesias Gonsalvez sigles...@igalia.com writes: It should compare with it's own size. Signed-off-by: Samuel Iglesias Gonsalvez sigles...@igalia.com Reviewed-by: Eric Anholt e...@anholt.net pgp9MskEc4CUk.pgp Description: PGP signature ___

[Mesa-dev] [Bug 78393] Black zebra like lines while playing games on open source drivers

2014-05-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=78393 --- Comment #4 from incarnated...@gmail.com --- Holy cow enabling S3TC made it all work! -- You are receiving this mail because: You are the assignee for the bug. ___ mesa-dev mailing list

[Mesa-dev] [PATCH] egl_dri2: cleanup memory leak in dri2_create_context()

2014-05-08 Thread Emil Velikov
Cc: Kristian Høgsberg k...@bitplanet.net Cc: Chad Versace chad.vers...@linux.intel.com Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- src/egl/drivers/dri2/egl_dri2.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/egl/drivers/dri2/egl_dri2.c

Re: [Mesa-dev] [PATCH] i965: Avoid redundant call to brw_merge_inputs() in brw_try_draw_prims()

2014-05-08 Thread Eric Anholt
Iago Toral Quiroga ito...@igalia.com writes: We always call brw_merge_inputs() right before looping over the primitives but this can be called inside the loop for each primitive too. In the case we do it for the first primitive the call is redundant and can be skipped. Reviewed-by: Eric

[Mesa-dev] [Bug 78393] Black zebra like lines while playing games on open source drivers

2014-05-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=78393 Alex Deucher ag...@yahoo.com changed: What|Removed |Added Status|NEW |RESOLVED

[Mesa-dev] [PATCH 2/2] clover: Destory pipe_screen when device does not support compute

2014-05-08 Thread Tom Stellard
--- src/gallium/state_trackers/clover/core/device.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/clover/core/device.cpp b/src/gallium/state_trackers/clover/core/device.cpp index 2f84677..70b5caf 100644 ---

[Mesa-dev] [PATCH 1/2] pipe-loader: Don't destroy the winsys in the sw loader

2014-05-08 Thread Tom Stellard
The screen takes ownership of the winsys, and is responsible for destroying it. Users of pipe-loader should make sure they destory and screens they've created to avoid memory leaks. This fixes a crash in clover introduced by ce6c17c0833032e91a2d1b34f9eb80c738a854a2 where the pipe-loader was

Re: [Mesa-dev] [PATCH 1/2] pipe-loader: Don't destroy the winsys in the sw loader

2014-05-08 Thread Emil Velikov
On 09/05/14 02:17, Tom Stellard wrote: The screen takes ownership of the winsys, and is responsible for destroying it. Users of pipe-loader should make sure they destory and screens they've created to avoid memory leaks. I was under false impression that our current sw screens do not

Re: [Mesa-dev] [PATCH 2/2] clover: Destory pipe_screen when device does not support compute

2014-05-08 Thread Emil Velikov
On 09/05/14 02:17, Tom Stellard wrote: --- src/gallium/state_trackers/clover/core/device.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/clover/core/device.cpp b/src/gallium/state_trackers/clover/core/device.cpp index 2f84677..70b5caf

Re: [Mesa-dev] [PATCH] egl_dri2: cleanup memory leak in dri2_create_context()

2014-05-08 Thread Kristian Høgsberg
On Thu, May 8, 2014 at 8:49 AM, Emil Velikov emil.l.veli...@gmail.com wrote: Cc: Kristian Høgsberg k...@bitplanet.net Cc: Chad Versace chad.vers...@linux.intel.com Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- src/egl/drivers/dri2/egl_dri2.c | 5 +++-- 1 file changed, 3

[Mesa-dev] [PATCH] ilo: destroy the mutex, if winsys creation fails

2014-05-08 Thread Emil Velikov
Cc: Chia-I Wu olva...@gmail.com Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- src/gallium/winsys/intel/drm/intel_drm_winsys.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/winsys/intel/drm/intel_drm_winsys.c b/src/gallium/winsys/intel/drm/intel_drm_winsys.c index

[Mesa-dev] [PATCH] clover: Destory pipe_screen when device does not support compute v2

2014-05-08 Thread Tom Stellard
v2: - Make sure screen was successfully created before destroying it. --- src/gallium/state_trackers/clover/core/device.cpp | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/clover/core/device.cpp

[Mesa-dev] [PATCH 1/2] pipe-loader: Don't destroy the winsys in the sw loader

2014-05-08 Thread Tom Stellard
The screen takes ownership of the winsys, and is responsible for destroying it. Users of pipe-loader should make sure they destory and screens they've created to avoid memory leaks. This fixes a crash in clover introduced by ce6c17c0833032e91a2d1b34f9eb80c738a854a2 where the pipe-loader was

[Mesa-dev] [PATCH 2/2] clover: Destory pipe_screen when device does not support compute

2014-05-08 Thread Tom Stellard
--- src/gallium/state_trackers/clover/core/device.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/clover/core/device.cpp b/src/gallium/state_trackers/clover/core/device.cpp index 2f84677..70b5caf 100644 ---

[Mesa-dev] [PATCH] clover: Destory pipe_screen when device does not support compute v2

2014-05-08 Thread Tom Stellard
v2: - Make sure screen was successfully created before destroying it. --- src/gallium/state_trackers/clover/core/device.cpp | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/clover/core/device.cpp

Re: [Mesa-dev] [PATCH 1/2] pipe-loader: Don't destroy the winsys in the sw loader

2014-05-08 Thread Tom Stellard
On Thu, May 08, 2014 at 11:38:13PM -0400, Tom Stellard wrote: The screen takes ownership of the winsys, and is responsible for destroying it. Users of pipe-loader should make sure they destory and screens they've created to avoid memory leaks. I did not mean to send this whole series

Re: [Mesa-dev] [PATCH] clover: Destory pipe_screen when device does not support compute v2

2014-05-08 Thread Francisco Jerez
Tom Stellard thomas.stell...@amd.com writes: v2: - Make sure screen was successfully created before destroying it. Thanks, Reviewed-by: Francisco Jerez curroje...@riseup.net --- src/gallium/state_trackers/clover/core/device.cpp | 5 - 1 file changed, 4 insertions(+), 1 deletion(-)

Re: [Mesa-dev] [PATCH] egl_dri2: cleanup memory leak in dri2_create_context()

2014-05-08 Thread Chad Versace
On Thu, May 08, 2014 at 11:06:01AM -0700, Kristian Høgsberg wrote: On Thu, May 8, 2014 at 8:49 AM, Emil Velikov emil.l.veli...@gmail.com wrote: Cc: Kristian Høgsberg k...@bitplanet.net Cc: Chad Versace chad.vers...@linux.intel.com Signed-off-by: Emil Velikov emil.l.veli...@gmail.com ---

Re: [Mesa-dev] [PATCH] mesa/st: provide native integers implementation of ir_unop_any

2014-05-08 Thread Roland Scheidegger
Am 08.05.2014 15:18, schrieb Ilia Mirkin: Previously, ir_unop_any was implemented via a dot-product call, which uses floating point multiplication and addition. The multiplication was completely pointless, and the addition can just as well be done with an or. Since we know that the inputs are

Re: [Mesa-dev] [PATCH] mesa/st: provide native integers implementation of ir_unop_any

2014-05-08 Thread Marek Olšák
This looks good to me. Marek On Thu, May 8, 2014 at 3:18 PM, Ilia Mirkin imir...@alum.mit.edu wrote: Previously, ir_unop_any was implemented via a dot-product call, which uses floating point multiplication and addition. The multiplication was completely pointless, and the addition can just as

[Mesa-dev] [Bug 77493] lp_test_arit fails with llvm = llvm-3.5svn r206094

2014-05-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77493 --- Comment #2 from Vinson Lee v...@freedesktop.org --- mesa: 74388dd24bc7fdb9e62ec18096163f5426e03fbf (master 10.3.0-devel) lp_test_arit is still failing with llvm-3.5.0svn. -- You are receiving this mail because: You are the assignee for the

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/2] i965: Fix depth (array slices) computation for 1D_ARRAY render targets.

2014-05-08 Thread Chris Forbes
This won't work correctly with 1D array views which constrain NumLayers. On Thu, May 8, 2014 at 9:35 AM, Kenneth Graunke kenn...@whitecape.org wrote: 1D array targets store the number of slices in the Height field. Fixes Piglit's spec/!OpenGL 3.2/layered-rendering/clear-color-all-types

[Mesa-dev] [Bug 73846] [llvmpipe] lp_test_format fails with llvm-3.5svn = r199602

2014-05-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=73846 --- Comment #2 from Vinson Lee v...@freedesktop.org --- mesa: 74388dd24bc7fdb9e62ec18096163f5426e03fbf (master 10.3.0-devel) llvm: 3.5.0svn r208355 lp_test_format is still failing with latest mesa and llvm. -- You are receiving this mail

Re: [Mesa-dev] [PATCH] st/xa: Fix performance regression introduced by commit Cache render target surface

2014-05-08 Thread Rob Clark
On Thu, May 8, 2014 at 3:15 AM, Thomas Hellstrom thellst...@vmware.com wrote: The mentioned commit has the nasty side-effect of turning off accelerated copies. Cc: 10.1 10.2 mesa-sta...@lists.freedekstop.org Signed-off-by: Thomas Hellstrom thellst...@vmware.com Reviewed-by: Rob Clark

[Mesa-dev] [PATCH 2/3] gallium: replace pipe_type enum with tgsi_type enum

2014-05-08 Thread Brian Paul
The only place the enum pipe_type was used is for the TGSI sampler view return type. So make it a TGSI type. --- src/gallium/auxiliary/tgsi/tgsi_build.c|8 src/gallium/auxiliary/tgsi/tgsi_strings.c |3 ++- src/gallium/auxiliary/tgsi/tgsi_strings.h |2 +-

[Mesa-dev] [PATCH 3/3] gallium: update comment for enum pipe_format

2014-05-08 Thread Brian Paul
--- src/gallium/include/pipe/p_format.h |7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/gallium/include/pipe/p_format.h b/src/gallium/include/pipe/p_format.h index b438134..ea16899 100644 --- a/src/gallium/include/pipe/p_format.h +++

[Mesa-dev] [PATCH 1/3] tgsi: rename TGSI_TYPE_x - TGSI_OPCODE_TYPE_x

2014-05-08 Thread Brian Paul
To avoid conflicts with coming TGSI_TYPE_x enums. --- src/gallium/auxiliary/gallivm/lp_bld_tgsi.c| 26 +- src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c| 54 ++-- src/gallium/auxiliary/tgsi/tgsi_info.c | 14 ++---

[Mesa-dev] [PATCH] glsl: Rename linker's is_varying_var

2014-05-08 Thread Chris Forbes
Both the ast-IR and linker have functions with this name, but different behavior. Rename the linker's version to var_counts_against_varying_limit to be closer to what it is actually used for. Suggested by Ian a while back. Signed-off-by: Chris Forbes chr...@ijw.co.nz --- Note that there's

[Mesa-dev] [PATCH 1/2] configure.ac: Add LLVM_VERSION_PATCH to DEFINES

2014-05-08 Thread Tom Stellard
--- configure.ac | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index d6f21ea..c68db00 100644 --- a/configure.ac +++ b/configure.ac @@ -1605,6 +1605,12 @@ if test x$enable_gallium_llvm = xyes; then

[Mesa-dev] [PATCH 2/2] radeonsi: Enable geometry shaders with LLVM 3.4.1

2014-05-08 Thread Tom Stellard
--- I tested this patch with LLVM 3.4, 3.4.1, and 3.5 and observed the correct behavior for all three versions. src/gallium/drivers/radeonsi/si_descriptors.c | 4 ++-- src/gallium/drivers/radeonsi/si_pipe.c| 4 ++-- src/gallium/drivers/radeonsi/si_pipe.h| 4

[Mesa-dev] [PATCH] i965: Fix GPU hangs on Broadwell in shaders with some control flow.

2014-05-08 Thread Kenneth Graunke
According to the documentation, we need to set the source 0 register type to IMM for flow control instructions that have both JIP and UIP. Fixes GPU hangs in approximately 10 Piglit tests, 5 es3conform tests, Unigine Crypt, a WebGL raytracer demo, and several Steam titles. Cc: 10.2

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/2] i965: Fix depth (array slices) computation for 1D_ARRAY render targets.

2014-05-08 Thread Kenneth Graunke
On 05/08/2014 02:48 PM, Chris Forbes wrote: This won't work correctly with 1D array views which constrain NumLayers. Right, and I guess your change to use irb-num_layers makes this irrelevant. I already pushed it, but feel free to revert it before pushing your code... --Ken signature.asc

[Mesa-dev] [PATCH v2] mesa/st: provide native integers implementation of ir_unop_any

2014-05-08 Thread Ilia Mirkin
Previously, ir_unop_any was implemented via a dot-product call, which uses floating point multiplication and addition. The multiplication was completely pointless, and the addition can just as well be done with an or. Since we know that the inputs are booleans, they must already be in canonical

Re: [Mesa-dev] [PATCH] i965: Fix GPU hangs on Broadwell in shaders with some control flow.

2014-05-08 Thread Matt Turner
On Thu, May 8, 2014 at 4:44 PM, Kenneth Graunke kenn...@whitecape.org wrote: According to the documentation, we need to set the source 0 register type to IMM for flow control instructions that have both JIP and UIP. Fixes GPU hangs in approximately 10 Piglit tests, 5 es3conform tests, Unigine

Re: [Mesa-dev] [PATCH] i965: Fix GPU hangs on Broadwell in shaders with some control flow.

2014-05-08 Thread Kenneth Graunke
On 05/08/2014 05:34 PM, Matt Turner wrote: On Thu, May 8, 2014 at 4:44 PM, Kenneth Graunke kenn...@whitecape.org wrote: According to the documentation, we need to set the source 0 register type to IMM for flow control instructions that have both JIP and UIP. Fixes GPU hangs in approximately

Re: [Mesa-dev] [PATCH] i965: Fix GPU hangs on Broadwell in shaders with some control flow.

2014-05-08 Thread Matt Turner
On Thu, May 8, 2014 at 5:45 PM, Kenneth Graunke kenn...@whitecape.org wrote: On 05/08/2014 05:34 PM, Matt Turner wrote: On Thu, May 8, 2014 at 4:44 PM, Kenneth Graunke kenn...@whitecape.org wrote: According to the documentation, we need to set the source 0 register type to IMM for flow

Re: [Mesa-dev] [PATCH 1/2] configure.ac: Add LLVM_VERSION_PATCH to DEFINES

2014-05-08 Thread Michel Dänzer
These changes should also go to stable. With that, both are Reviewed-by: Michel Dänzer michel.daen...@amd.com -- Earthling Michel Dänzer| http://www.amd.com Libre software enthusiast |Mesa and X developer

Re: [Mesa-dev] [PATCH 1/2] configure.ac: Add LLVM_VERSION_PATCH to DEFINES

2014-05-08 Thread Michel Dänzer
On 09.05.2014 11:23, Michel Dänzer wrote: These changes should also go to stable. BTW, I mean: CC: 10.1 10.2 mesa-sta...@lists.freedesktop.org Otherwise it will only be considered for the 10.2 branch at this point. -- Earthling Michel Dänzer|

Re: [Mesa-dev] [PATCH] ilo: destroy the mutex, if winsys creation fails

2014-05-08 Thread Chia-I Wu
On Fri, May 9, 2014 at 2:09 AM, Emil Velikov emil.l.veli...@gmail.com wrote: Cc: Chia-I Wu olva...@gmail.com Signed-off-by: Emil Velikov emil.l.veli...@gmail.com Reviewed-by: Chia-I Wu olva...@gmail.com --- src/gallium/winsys/intel/drm/intel_drm_winsys.c | 1 + 1 file changed, 1