Urgh, sorry about that :-(
I'll be more careful when manipulating the state flags next time.
Iago
On Tue, 2014-06-10 at 20:12 -0700, Kenneth Graunke wrote:
In commit dc2d3a7f5c217a7cee92380fbf503924a9591bea, Iago accidentally
moved fire_fb_write() above the brw_pop_insn_state(), which caused
Reviewed-by: Tapani Pälli tapani.pa...@intel.com
On 06/11/2014 05:14 AM, Ian Romanick wrote:
From: Ian Romanick ian.d.roman...@intel.com
And delete the incorrect comment.
Signed-off-by: Ian Romanick ian.d.roman...@intel.com
---
src/glsl/ir_uniform.h| 7 ++-
src/mesa/main/uniforms.c
On Wednesday, June 11, 2014 08:00:13 AM Iago Toral wrote:
Urgh, sorry about that :-(
I'll be more careful when manipulating the state flags next time.
Iago
No worries! This kind of stuff happens, and I didn't catch it either. It's
just part of development.
This is one reason I've been
On Tuesday, June 10, 2014 09:57:23 PM Matt Turner wrote:
Allows the compiler to cut dead code and simplify when we know the
driver will run on a single platform. Perhaps useful for distributions
wanting to ship new hardware support without the risk involved in
updating Mesa for existing
On 06/10/2014 10:20 PM, Ian Romanick wrote:
I did a little more research. Looking at the commit history, it must
just be an MSVC thing:
commit 78d3cfb5b4fe1dbe052f87458e62cc2be2ecf171
Author: Brian Paul bri...@vmware.com
Date: Sun Nov 4 16:43:44 2012 -0700
glsl: remove incorrect
---
src/glsl/link_varyings.h | 10 ++
1 file changed, 10 insertions(+)
diff --git a/src/glsl/link_varyings.h b/src/glsl/link_varyings.h
index 4e485c3..167363e 100644
--- a/src/glsl/link_varyings.h
+++ b/src/glsl/link_varyings.h
@@ -112,6 +112,16 @@ public:
return
Outputs that are linked to inputs in the next stage must be output to stream 0,
otherwise we should fail to link.
---
src/glsl/link_varyings.cpp | 7 +++
1 file changed, 7 insertions(+)
diff --git a/src/glsl/link_varyings.cpp b/src/glsl/link_varyings.cpp
index 9883c0b..0066b4e 100644
---
If this is detected, fail to link.
---
src/glsl/link_varyings.cpp | 17 +
1 file changed, 17 insertions(+)
diff --git a/src/glsl/link_varyings.cpp b/src/glsl/link_varyings.cpp
index 0066b4e..1a69897 100644
--- a/src/glsl/link_varyings.cpp
+++ b/src/glsl/link_varyings.cpp
@@
On Intel hardware when a geometry shader outputs GL_POINTS primitives we
only need to emit vertex control bits if it emits vertices to non-zero
streams, so use a flag to track this.
This flag will be set to TRUE when a geometry shader calls EmitStreamVertex()
or EndStreamPrimitive() with a
Inter-shader outputs must be on stream 0, which is the default.
---
src/glsl/link_varyings.cpp | 12 +---
src/glsl/link_varyings.h | 7 +++
2 files changed, 16 insertions(+), 3 deletions(-)
diff --git a/src/glsl/link_varyings.cpp b/src/glsl/link_varyings.cpp
index f765d37..9883c0b
From the ARB_gpu_shader5 spec:
Multiple vertex streams are supported only if the output primitive
type is declared to be points. A program will fail to link if it
contains a geometry shader calling EmitStreamVertex() or
EndStreamPrimitive() if its output primitive type is not points.
For now initialized to the default stream 0.
---
src/glsl/link_varyings.cpp | 1 +
src/mesa/main/mtypes.h | 1 +
2 files changed, 2 insertions(+)
diff --git a/src/glsl/link_varyings.cpp b/src/glsl/link_varyings.cpp
index 6863298..f765d37 100644
--- a/src/glsl/link_varyings.cpp
+++
Configure hardware to read vertex data for all streams and have all streams
write their varyings to the corresponsing output buffers.
---
src/mesa/drivers/dri/i965/gen7_sol_state.c | 65 +++---
1 file changed, 41 insertions(+), 24 deletions(-)
diff --git
From: Samuel Iglesias Gonsalvez sigles...@igalia.com
Signed-off-by: Samuel Iglesias Gonsalvez sigles...@igalia.com
---
src/glsl/ir_print_visitor.cpp | 7 +--
src/glsl/ir_reader.cpp| 6 ++
2 files changed, 11 insertions(+), 2 deletions(-)
diff --git
This should be ensured by the parser, so assert on that.
---
src/glsl/link_varyings.cpp | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/glsl/link_varyings.cpp b/src/glsl/link_varyings.cpp
index 1a69897..aed069a 100644
--- a/src/glsl/link_varyings.cpp
+++ b/src/glsl/link_varyings.cpp
---
src/glsl/ast_function.cpp | 37 +-
src/glsl/builtin_functions.cpp | 60 ++
src/glsl/ir.h | 18 -
3 files changed, 103 insertions(+), 12 deletions(-)
diff --git a/src/glsl/ast_function.cpp
It should be possible to query the number of primitives written to each
individual stream by a geometry shader in a single draw call. For that
we need to have up to MAX_VERTEX_STREAM separate query objects.
---
src/mesa/main/mtypes.h | 2 +-
src/mesa/main/queryobj.c | 17 +
2
---
src/mesa/main/context.c | 2 +-
src/mesa/main/mtypes.h | 1 +
src/mesa/main/queryobj.c | 1 +
3 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/mesa/main/context.c b/src/mesa/main/context.c
index 8eb426d..82b00eb 100644
--- a/src/mesa/main/context.c
+++
This series brings multi-stream support to geometry shaders as defined by
ARB_gpu_shader5. It also covers some missing multi-stream functionality from
ARB_transform_feedback3. This is combined work from Samuel Iglesias and
myself.
The series includes both required infrastructure in Mesa and
If the geometry shader is indeed using streams then we need 2 control data
bits per vertex for the StreamID. If the shader is not using streams then
we don't need control data bits.
---
src/mesa/drivers/dri/i965/brw_vec4_gs.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff
---
src/glsl/ir_print_visitor.cpp | 8
src/glsl/ir_reader.cpp| 18 ++
2 files changed, 18 insertions(+), 8 deletions(-)
diff --git a/src/glsl/ir_print_visitor.cpp b/src/glsl/ir_print_visitor.cpp
index c4a6f9c..23960e0 100644
--- a/src/glsl/ir_print_visitor.cpp
From: Samuel Iglesias Gonsalvez sigles...@igalia.com
This implements parsing requirements for multi-stream support in
geometry shaders as defined in ARB_gpu_shader5.
Signed-off-by: Samuel Iglesias Gonsalvez sigles...@igalia.com
---
src/glsl/ast.h | 5 +
src/glsl/ast_to_hir.cpp |
---
src/mesa/drivers/dri/i965/gen6_queryobj.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/gen6_queryobj.c
b/src/mesa/drivers/dri/i965/gen6_queryobj.c
index 06ac645..0cb64ca 100644
--- a/src/mesa/drivers/dri/i965/gen6_queryobj.c
+++
In stream mode we have to set control data bits with the StreamID
information for every vertex.
---
src/mesa/drivers/dri/i965/brw_vec4_gs_visitor.cpp | 51 ++-
src/mesa/drivers/dri/i965/brw_vec4_gs_visitor.h | 1 +
2 files changed, 51 insertions(+), 1 deletion(-)
diff
https://bugs.freedesktop.org/show_bug.cgi?id=79907
Priority: medium
Bug ID: 79907
Assignee: mesa-dev@lists.freedesktop.org
Summary: Mesa 10.2.1 --enable-vdpau default=auto broken
Severity: normal
Classification: Unclassified
On Wed, Jun 11, 2014 at 7:49 PM, Iago Toral Quiroga ito...@igalia.com wrote:
@@ -509,6 +509,8 @@ struct ast_type_qualifier {
/** \name Layout qualifiers for GL_ARB_gpu_shader5 */
/** \{ */
unsigned invocations:1;
+ unsigned streamId:1; /* Has streamId
This would appear to prohibit the use of multiple streams in separable
programs entirely. I don't think that's the right thing.
On Wed, Jun 11, 2014 at 7:49 PM, Iago Toral Quiroga ito...@igalia.com wrote:
Outputs that are linked to inputs in the next stage must be output to stream
0,
I think you need to set this if *any* geometry shader in the program
tries to use a nonzero stream. Currently it looks like the last shader
wins.
On Wed, Jun 11, 2014 at 7:49 PM, Iago Toral Quiroga ito...@igalia.com wrote:
On Intel hardware when a geometry shader outputs GL_POINTS primitives we
This is pretty weird.
We should be able to generate a normal builtin function body here
which consists of just the ir_emit_vertex, passing the stream
parameter to it. This would then get inlined like any other function
leaving a bare ir_emit_vertex / ir_end_primitive with a constant
operand. If
On Wed, Jun 11, 2014 at 7:49 PM, Iago Toral Quiroga ito...@igalia.com wrote:
---
src/mesa/main/context.c | 2 +-
src/mesa/main/mtypes.h | 1 +
src/mesa/main/queryobj.c | 1 +
3 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/mesa/main/context.c b/src/mesa/main/context.c
On Wed, Jun 11, 2014 at 7:49 PM, Iago Toral Quiroga ito...@igalia.com wrote:
It should be possible to query the number of primitives written to each
individual stream by a geometry shader in a single draw call. For that
we need to have up to MAX_VERTEX_STREAM separate query objects.
---
I sent comments on patches 1, 3, 5, 9, 11, 16, 18
Patches 2, 4, 6-8, 10, 12-15, 17 are:
Reviewed-by: Chris Forbes chr...@ijw.co.nz
You should also include a patch to docs/GL3.txt marking off this
subfeature for i965 :)
Do you have a bunch of piglits which exercise all the tricky corners
of
Hi Chris,
thanks for the quick review!
On Wed, 2014-06-11 at 21:45 +1200, Chris Forbes wrote:
I sent comments on patches 1, 3, 5, 9, 11, 16, 18
We will look into these.
Patches 2, 4, 6-8, 10, 12-15, 17 are:
Reviewed-by: Chris Forbes chr...@ijw.co.nz
You should also include a patch to
I am a bit confused here:
Reading the code it looks like input_var should be NULL if there is no
consumer stage. In that case, if this is a separable program and there
is no consumer, then input_var must be NULL too, in which case the
linker_error would never take place.
If input_var is not NULL
https://bugs.freedesktop.org/show_bug.cgi?id=79885
Marc Dietrich marvi...@gmx.de changed:
What|Removed |Added
Status|NEW |RESOLVED
Piglit report an error in glsl-link-initializer-03 test when
a shader without an initializer is linked in two different programs with
shaders that have differing initializers. Linking with the first will
modify the shader, and linking with the second will fail.
To make it work, the patch detects
Hi,
Thank you very much.
On Tue, Jun 10, 2014 at 5:28 PM, Marek Olšák mar...@gmail.com wrote:
On Tue, Jun 10, 2014 at 10:45 PM, Aditya Avinash
adityaavina...@gmail.com wrote:
Hi,
Thank you very much!!
On Mon, Jun 9, 2014 at 10:19 AM, Marek Olšák mar...@gmail.com wrote:
This is
That commit made possible that the items could be one just
after the other when their size was a multiple of ITEM_ALIGNMENT.
But compute_memory_prealloc_chunk still looked to leave a gap
between items. Resulting in that we got an infinite loop when
trying to add an item which would left no space
Backport last round of piglit fixes to 10.2. These have been soaking
on master for a couple weeks, and I've not found any regression yet.
And they get us from 80% pass up to nearly 83% pass, so a bit more
progress in the right direction. (For reference, at end of Feb we
were at 50% pass ;-))
On Wed, Jun 11, 2014 at 2:49 AM, Iago Toral ito...@igalia.com wrote:
Hi Chris,
thanks for the quick review!
On Wed, 2014-06-11 at 21:45 +1200, Chris Forbes wrote:
I sent comments on patches 1, 3, 5, 9, 11, 16, 18
We will look into these.
Patches 2, 4, 6-8, 10, 12-15, 17 are:
Thanks a lot for your help.!
CFLAGS='-O0 -ggdb3' CXXFLAGS='-O0 -ggdb3' ./autogen.sh --prefix=/usr
--libdir=/usr/lib/i386-linux-gnu --with-gallium-drivers=svga
--with-dri-drivers= --enable-xa --disable-dri3; make;
did the trick.
On Thu, Jun 5, 2014 at 9:01 AM, Ian Romanick i...@freedesktop.org
Adding mesa-dev in CC.
On Wed, Jun 11, 2014 at 10:39 AM, Courtney Goeltzenleuchter
court...@lunarg.com wrote:
On Fri, Jun 6, 2014 at 5:57 PM, Anuj Phogat anuj.pho...@gmail.com wrote:
Fixes many failures in gles3 Khronos CTS test: packed_pixels
Khronos bug# 9807
Cc:
Adding mesa-dev to the conversation.
On Wed, Jun 11, 2014 at 10:52 AM, Anuj Phogat anuj.pho...@gmail.com wrote:
On Wed, Jun 11, 2014 at 10:28 AM, Courtney Goeltzenleuchter
court...@lunarg.com wrote:
On Fri, Jun 6, 2014 at 5:57 PM, Anuj Phogat anuj.pho...@gmail.com wrote:
Fixes many
Very good. I thought there might be something limiting the inputs but
wasn't immediately obvious.
On Wed, Jun 11, 2014 at 12:09 PM, Anuj Phogat anuj.pho...@gmail.com wrote:
Adding mesa-dev to the conversation.
On Wed, Jun 11, 2014 at 10:52 AM, Anuj Phogat anuj.pho...@gmail.com
wrote:
On
On Tue, Jun 10, 2014 at 3:34 PM, Matt Turner matts...@gmail.com wrote:
On Wed, May 28, 2014 at 4:44 PM, Connor Abbott cwabbo...@gmail.com wrote:
On Tue, May 27, 2014 at 9:47 PM, Matt Turner matts...@gmail.com wrote:
Here's a respin of my load_payload series from mid-April with some
feedback
GL_TEXTURE_CUBE_MAP is an allowed texture target in glTexStorage2D()
and is allowed to be used (like GL_TEXTURE_2D) with compressed internal
formats.
Cc: mesa-sta...@lists.freedesktop.org
Signed-off-by: Anuj Phogat anuj.pho...@gmail.com
---
src/mesa/main/teximage.c | 1 +
1 file changed, 1
Too many levels of indirection.
Signed-off-by: Kenneth Graunke kenn...@whitecape.org
---
src/mesa/drivers/dri/i965/brw_blorp_clear.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/drivers/dri/i965/brw_blorp_clear.cpp
Reviewed-by: Matt Turner matts...@gmail.com
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
I had misread it -- yes, this looks correct.
On Thu, Jun 12, 2014 at 12:02 AM, Iago Toral ito...@igalia.com wrote:
I am a bit confused here:
Reading the code it looks like input_var should be NULL if there is no
consumer stage. In that case, if this is a separable program and there
is no
Reviewed-by: Marek Olšák marek.ol...@amd.com
Marek
On Wed, Jun 11, 2014 at 9:02 PM, Anuj Phogat anuj.pho...@gmail.com wrote:
GL_TEXTURE_CUBE_MAP is an allowed texture target in glTexStorage2D()
and is allowed to be used (like GL_TEXTURE_2D) with compressed internal
formats.
Cc:
On 10/06/14 16:56, Niels Ole Salscheider wrote:
On Tuesday 10 June 2014, 16:18:56, Emil Velikov wrote:
On 10/06/14 15:17, Niels Ole Salscheider wrote:
This fixes automake builds which are broken since
b52a530ce2aada1967bc8fefa83ab53e6a737dae.
Not sure what I was smoking with the above
https://bugs.freedesktop.org/show_bug.cgi?id=79688
Eugene Shalygin eugene.shalygin+bugzilla@gmail.com changed:
What|Removed |Added
CC|
On Tue, Jun 10, 2014 at 6:00 PM, Ian Romanick i...@freedesktop.org wrote:
On 06/09/2014 07:48 AM, Robert Bragg wrote:
This makes sure to use a no-op swizzle while iteratively rendering each
level of a mipmap otherwise we may loose components and effectively
apply the swizzle twice by the time
On Tue, Jun 10, 2014 at 09:57:20PM -0700, Matt Turner wrote:
From: Kenneth Graunke kenn...@whitecape.org
This allows GCC (at least with LTO) to eliminate more unused code, such
as brw_clip* on Gen6+.
If we compile with STATIC_GEN, then the if-else ladder in brw_init_state()
turns into just
This fixes automake builds which are broken since
b52a530ce2aada1967bc8fefa83ab53e6a737dae.
v2: This patch also adds the FEATURE_* defines back to targets/egl-static for
Android and Scons that have been removed in the mentioned commit.
Signed-off-by: Niels Ole Salscheider
On Tue, Jun 10, 2014 at 09:57:17PM -0700, Matt Turner wrote:
Except patch 4, series
Reviewed-by: Kristian Høgsberg k...@bitplanet.net
---
src/mesa/main/macros.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/mesa/main/macros.h b/src/mesa/main/macros.h
index
On Tue, Jun 10, 2014 at 07:37:42PM -0700, Matt Turner wrote:
Please stop adding them.
Reviewed-by: Kristian Høgsberg k...@bitplanet.net
---
configure.ac | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/configure.ac b/configure.ac
index eaca378..c6664b9 100644
---
On Tue, Jun 10, 2014 at 07:37:43PM -0700, Matt Turner wrote:
This isn't supposed to be difficult.
Snarky-snark.
Reviewed-by: Kristian Høgsberg k...@bitplanet.net
---
configure.ac | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/configure.ac
On Tue, Jun 10, 2014 at 07:37:44PM -0700, Matt Turner wrote:
Reviewed-by: Kristian Høgsberg k...@bitplanet.net
---
configure.ac | 12 +++-
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/configure.ac b/configure.ac
index 17e9e9c..4b27455 100644
--- a/configure.ac
On Wed, Jun 11, 2014 at 12:59:21PM +0900, Michel Dänzer wrote:
From: Michel Dänzer michel.daen...@amd.com
GBM_BO_USE_CURSOR_64X64 is kept so that existing users of GBM continue to
build, but it no longer rejects widths or heights other than 64.
Bugzilla:
On Tue, Jun 10, 2014 at 11:21:26AM -0600, Courtney Goeltzenleuchter wrote:
The code that parses LIBGL_DRIVERS_PATH was printing an
error for every attempted dlopen. It's not an error to
have to check multiple items in the path, only an error if
no suitable library is found. Reduced the load
Commit e62b7d38a1d (configure: autodetect video state-trackers
when non swrast driver is present) added a check that caused
the autodetection to be omitted when we have the swrast gallium
driver. Whereas it should have skipped the VL targets when only
swrast was selected.
Bugzilla:
https://bugs.freedesktop.org/show_bug.cgi?id=79907
--- Comment #1 from Emil Velikov emil.l.veli...@gmail.com ---
Thanks for reporting, a silly thinko on my behalf is causing this behaviour.
Can you confirm that the patch [1] fixes the issue on your system ?
[1]
On 11/06/14 03:37, Matt Turner wrote:
Please stop adding them.
Believe I contributed the latter one :)
The series looks good imho
Reviewed-by: Emil Velikov emil.l.veli...@gmail.com
---
configure.ac | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/configure.ac
On Wed, Jun 11, 2014 at 2:12 PM, Kristian Høgsberg hoegsb...@gmail.com wrote:
On Tue, Jun 10, 2014 at 09:57:20PM -0700, Matt Turner wrote:
From: Kenneth Graunke kenn...@whitecape.org
This allows GCC (at least with LTO) to eliminate more unused code, such
as brw_clip* on Gen6+.
If we compile
On Tue, Jun 10, 2014 at 11:00:43AM -0700, Matt Turner wrote:
Our most frequently used list implementation was only usable from
C by manipulating the members of the structs. This series adds a
C API, wraps the C API with the C++ member functions (so no change
for C++ code), makes the
On 06/11/2014 01:40 AM, Chris Forbes wrote:
On Wed, Jun 11, 2014 at 7:49 PM, Iago Toral Quiroga ito...@igalia.com wrote:
@@ -509,6 +509,8 @@ struct ast_type_qualifier {
/** \name Layout qualifiers for GL_ARB_gpu_shader5 */
/** \{ */
unsigned invocations:1;
+
On 06/11/2014 12:49 AM, Iago Toral Quiroga wrote:
From: Samuel Iglesias Gonsalvez sigles...@igalia.com
This implements parsing requirements for multi-stream support in
geometry shaders as defined in ARB_gpu_shader5.
Signed-off-by: Samuel Iglesias Gonsalvez sigles...@igalia.com
---
From: Marek Olšák marek.ol...@amd.com
This adds a new type of intrinsic and SDNode: SampleRaw.
All fields of the MIMG opcodes are exposed and can be set by Mesa,
even DMASK. All GATHER4 variants are added and there are a lot of them.
v2: document DMASK behavior
---
From: Marek Olšák marek.ol...@amd.com
---
test/CodeGen/R600/llvm.SI.gather4.ll | 508 +++
1 file changed, 508 insertions(+)
create mode 100644 test/CodeGen/R600/llvm.SI.gather4.ll
diff --git a/test/CodeGen/R600/llvm.SI.gather4.ll
Anuj Phogat anuj.pho...@gmail.com writes:
Fixes piglit tests in spec/glsl-es-3.00/compile:
undef-__FILE__.vert
undef-GL_ES.vert
undef-__LINE__.vert
undef-__VERSION__.vert
I see the code that will fix __FILE__, __LINE__, and __VERSION__, but
not GL_ES. Should that line be dropped from the
Currently verifying that an #undef of __FILE__, __LINE__, or __VERSION__ will
generate an error.
---
src/glsl/glcpp/tests/120-undef-builtin.c | 3 +++
src/glsl/glcpp/tests/120-undef-builtin.c.expected | 7 +++
2 files changed, 10 insertions(+)
create mode 100644
I've been looking at this is a bit since last week, and I have some
concerns about the overall way things are structured. There are also
almost no checks that the values being de-serialized are valid. What
happens if an ir_expression::operation is 0xDEADBEEF? I think I know
where we want to be
On Wed, Jun 11, 2014 at 5:32 PM, Carl Worth cwo...@cworth.org wrote:
Anuj Phogat anuj.pho...@gmail.com writes:
Fixes piglit tests in spec/glsl-es-3.00/compile:
undef-__FILE__.vert
undef-GL_ES.vert
undef-__LINE__.vert
undef-__VERSION__.vert
I see the code that will fix __FILE__, __LINE__,
Anuj Phogat anuj.pho...@gmail.com writes:
This patch specifically fixes redefinition condition for white space
changes. #define and #undef functionality in GLSL follows the standard
for C++ preprocessors for macro definitions.
Thanks! That fix took some close reading of the specification, and
https://bugs.freedesktop.org/show_bug.cgi?id=54372
--- Comment #22 from danm...@gmail.com ---
Ok, so this patch fixes glxUseXFont for glxwindows.
Any idea when these patches will go in?
diff --git a/src/glx/xfont.c b/src/glx/xfont.c
index 316c585..3c34b1d 100644
--- a/src/glx/xfont.c
+++
Previously, the test suite was expecting the compiler to allow a redefintion
of a macro with whitespace added, but gcc is more strict and allows only for
changes in the amounts of whitespace, (but insists that whitespace exist or
not in exactly the same places).
See:
Anuj Phogat anuj.pho...@gmail.com writes:
#if 0
#else garbage
#endif
The Khronos test contains two tokens after #else. I'm not sure if that
is the difference or not.
Khronos is testing many different cases. Failing case tests:
#if 1
#else garbage
#endif
It is the #if 1 that causes the
On Wed, Jun 11, 2014 at 6:51 PM, Carl Worth cwo...@cworth.org wrote:
Anuj Phogat anuj.pho...@gmail.com writes:
#if 0
#else garbage
#endif
The Khronos test contains two tokens after #else. I'm not sure if that
is the difference or not.
Khronos is testing many different cases.
Anuj Phogat anuj.pho...@gmail.com writes:
Following changes in above code will also fix the GL_ES macro case:
- || strcmp(__VERSION__, $3) == 0)
+ || strcmp(__VERSION__, $3) == 0
+ || (parser-is_gles strcmp(GL_ES, $3) == 0))
Great.
Do
Carl Worth cwo...@cworth.org writes:
I'll poke around at the existing code to see why the garbage after #else
is caught with #if 0, but not with #if 1.
The difference is fairly straightforward, but it's going to be tricky to
fix.
Currently, the parser has a production for HASH_ELSE and NEWLINE
Without this, in the PP state, we would hit Flex's default rule, which
prints tokens to stdout, rather than returning them as tokens.
This manifested as a weird bug where shaders with semicolons after
extension directives, such as:
#extension GL_foo_bar : enable;
would print semicolons to
Ian Romanick i...@freedesktop.org writes:
On 06/09/2014 12:36 AM, Kenneth Graunke wrote:
We have this wonderful thing called an optimizer---maybe we should
consider calling it?
That's really weird. The *only* place this is called is in ir_to_mesa.
It seems like the assember should just
Hi;
On 06/02/2014 03:05 PM, Tapani Pälli wrote:
Hello;
This series provides a disk cache for the shader compiler and is used
to 'skip glLinkProgram' like GL_ARB_get_program_binary does but under
the hood without api for the client.
With the series I get 50% improvement for L4D2 startup
84 matches
Mail list logo
