How did you notice this? (More specifically than semicolons being
printed in your terminals!)
Reviewed-by: Matt Turner matts...@gmail.com
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Am 11.06.2014 23:46, schrieb Emil Velikov:
Commit e62b7d38a1d (configure: autodetect video state-trackers
when non swrast driver is present) added a check that caused
the autodetection to be omitted when we have the swrast gallium
driver. Whereas it should have skipped the VL targets when only
On Wed, 2014-06-11 at 15:29 -0700, Ian Romanick wrote:
On 06/11/2014 12:49 AM, Iago Toral Quiroga wrote:
From: Samuel Iglesias Gonsalvez sigles...@igalia.com
This implements parsing requirements for multi-stream support in
geometry shaders as defined in ARB_gpu_shader5.
It may be a bit less confusing to read if I take the inner if out, so
I'll rewrite it like this:
if (input_var || (prog-SeparateShader consumer == NULL)) {
matches.record(output_var, input_var);
}
if (input_var output_var-data.streamId != 0) {
linker_error(prog, ...);
return false;
}
On 06/05/2014 08:08 AM, Tapani Pälli wrote:
Patch adds a preprocessor define for the extension and stores explicit
location data for uniforms during AST-HIR conversion. It also sets
layout token to be available when having the extension in place.
v2: change parser check to require GLSL 330 or
On 06/12/2014 09:44 AM, Petri Latvala wrote:
On 06/05/2014 08:08 AM, Tapani Pälli wrote:
Patch adds a preprocessor define for the extension and stores explicit
location data for uniforms during AST-HIR conversion. It also sets
layout token to be available when having the extension in place.
Reviewed-by: Petri Latvala petri.latv...@intel.com
On 06/09/2014 01:06 PM, Tapani Pälli wrote:
v2: enable also for i915 (Ian)
Signed-off-by: Tapani Pälli tapani.pa...@intel.com
---
src/mesa/drivers/dri/i915/intel_extensions.c | 1 +
src/mesa/drivers/dri/i965/intel_extensions.c | 1 +
Reviewed-by: Petri Latvala petri.latv...@intel.com
On 04/09/2014 12:56 PM, Tapani Pälli wrote:
Signed-off-by: Tapani Pälli tapani.pa...@intel.com
---
docs/GL3.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/GL3.txt b/docs/GL3.txt
index bf51e3a..245a045 100644
---
On Thu, 2014-06-12 at 08:32 +0200, Samuel Iglesias Gonsálvez wrote:
On Wed, 2014-06-11 at 15:29 -0700, Ian Romanick wrote:
On 06/11/2014 12:49 AM, Iago Toral Quiroga wrote:
From: Samuel Iglesias Gonsalvez sigles...@igalia.com
This implements parsing requirements for multi-stream
Patch adds a preprocessor define for the extension and stores explicit
location data for uniforms during AST-HIR conversion. It also sets
layout token to be available when having the extension in place.
v2: change parser check to require GLSL 330 or enabling
GL_ARB_explicit_attrib_location
Previously we disallowed any combination of layout with interpolation,
invariant, or precise qualifiers. There is very little spec guidance on
exactly which combinations should be allowed, but with ARB_sso it's
useful to allow these qualifiers with rendezvous-by-location.
Since it's unclear
I'm pretty sure that p_atomic_dec_zero should return 1 if the count drops to
zero.
Cc: 10.2 10.1 10.0 mesa-sta...@lists.freedesktop.org
Signed-off-by: Maarten Lankhorst maarten.lankho...@canonical.com
---
diff --git a/src/gallium/auxiliary/util/u_atomic.h
On Wednesday, June 11, 2014 11:02:34 PM Matt Turner wrote:
How did you notice this? (More specifically than semicolons being
printed in your terminals!)
Reviewed-by: Matt Turner matts...@gmail.com
I wrote a patch that altered the Meta GLSL clear shaders, and ran Piglit.
Basically all of
Reviewed-by: Petri Latvala petri.latv...@intel.com
On 06/12/2014 10:46 AM, Tapani Pälli wrote:
Patch adds a preprocessor define for the extension and stores explicit
location data for uniforms during AST-HIR conversion. It also sets
layout token to be available when having the extension in
This only makes any sense on the GS input or output layout declaration,
nowhere else.
Fixes the piglit tests:
*
spec/glsl-1.50/compiler/incorrect-in-layout-qualifiers-with-variable-declarations.geom
*
spec/glsl-1.50/compiler/incorrect-out-layout-qualifiers-with-variable-declarations.geom
Patch adds a type check between switch init-expression and case label
and performs a implicit signed-unsigned type conversion when possible.
v2: add GLSL spec reference, do implicit conversion if possible (Matt)
Signed-off-by: Tapani Pälli tapani.pa...@intel.com
Bugzilla:
Thanks for the review.
I'm working on incorporating the changes into a v2 patch series. However
I'm a bit stuck with what to do about enabling the extension assuming
there is no Gallium implementation for now. I couldn't find a convenient
place to enable the extension for all DRI-based drivers
On Thu, Jun 12, 2014 at 11:08 AM, Neil Roberts n...@linux.intel.com wrote:
+ if (ctx-Version = 30 || ctx-Extensions.EXT_texture_integer) {
+ /* both source and dest must be integer-valued, or neither */
+ if (_mesa_is_format_integer_color(texImage-TexFormat) !=
+
Signed-off-by: Leo Liu leo@amd.com
---
src/gallium/include/pipe/p_video_codec.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/gallium/include/pipe/p_video_codec.h
b/src/gallium/include/pipe/p_video_codec.h
index d4cdacb..196d00b 100644
--- a/src/gallium/include/pipe/p_video_codec.h
Signed-off-by: Leo Liu leo@amd.com
---
src/gallium/state_trackers/omx/vid_enc.c | 32
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/src/gallium/state_trackers/omx/vid_enc.c
b/src/gallium/state_trackers/omx/vid_enc.c
index d16fa01..70f63d1
Signed-off-by: Leo Liu leo@amd.com
---
src/gallium/drivers/radeon/radeon_vce.c | 60 +++--
src/gallium/drivers/radeon/radeon_vce.h | 3 +-
2 files changed, 58 insertions(+), 5 deletions(-)
diff --git a/src/gallium/drivers/radeon/radeon_vce.c
Signed-off-by: Leo Liu leo@amd.com
---
src/gallium/drivers/radeon/radeon_vce_40_2_2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/drivers/radeon/radeon_vce_40_2_2.c
b/src/gallium/drivers/radeon/radeon_vce_40_2_2.c
index c67f8f9..ecb4b0d 100644
---
Signed-off-by: Leo Liu leo@amd.com
---
src/gallium/state_trackers/omx/vid_enc.c | 39
1 file changed, 39 insertions(+)
diff --git a/src/gallium/state_trackers/omx/vid_enc.c
b/src/gallium/state_trackers/omx/vid_enc.c
index 70f63d1..db4fc8f 100644
---
Am 12.06.2014 18:27, schrieb Leo Liu:
Signed-off-by: Leo Liu leo@amd.com
---
src/gallium/drivers/radeon/radeon_vce.c | 60 +++--
src/gallium/drivers/radeon/radeon_vce.h | 3 +-
2 files changed, 58 insertions(+), 5 deletions(-)
diff --git
v2: add error check for cpb size 0
Signed-off-by: Leo Liu leo@amd.com
---
src/gallium/drivers/radeon/radeon_vce.c | 63 +++--
src/gallium/drivers/radeon/radeon_vce.h | 3 +-
2 files changed, 61 insertions(+), 5 deletions(-)
diff --git
Fixed. Thanks for the review.
My account is still not activated.
Leo
-Original Message-
From: Christian König [mailto:deathsim...@vodafone.de]
Sent: Thursday, June 12, 2014 12:35 PM
To: Liu, Leo; mesa-dev@lists.freedesktop.org
Subject: Re: [Mesa-dev] [PATCH 5/5] radeon/vce: set number of
The comment for _mesa_is_type_integer is confusing because it says that it
returns whether the type is an “integer (non-normalized)” format. I don't
think it makes sense to say whether a type is normalized or not because it
depends on what format it is used with. For example,
From: Roland Scheidegger srol...@vmware.com
Gallium (but not OpenGL) does allow nesting of queries, but there's no
limit specified (d3d10 has no limit neither). Nevertheless, for practical
purposes we need some limit in llvmpipe, otherwise we'd need more complex
handling of queries as we need to
On 11/06/14 22:13, Niels Ole Salscheider wrote:
This fixes automake builds which are broken since
b52a530ce2aada1967bc8fefa83ab53e6a737dae.
v2: This patch also adds the FEATURE_* defines back to targets/egl-static for
Android and Scons that have been removed in the mentioned commit.
https://bugs.freedesktop.org/show_bug.cgi?id=79885
--- Comment #7 from Emil Velikov emil.l.veli...@gmail.com ---
commit 607bc899701dda25f7c91ebd2ec2136d4dab0448
Author: Niels Ole Salscheider niels_...@salscheider-online.de
Date: Wed Jun 11 23:13:12 2014 +0200
egl/gallium: Set defines for
https://bugs.freedesktop.org/show_bug.cgi?id=79907
Emil Velikov emil.l.veli...@gmail.com changed:
What|Removed |Added
Status|NEW |RESOLVED
On 12/06/14 07:30, Christian König wrote:
Am 11.06.2014 23:46, schrieb Emil Velikov:
Commit e62b7d38a1d (configure: autodetect video state-trackers
when non swrast driver is present) added a check that caused
the autodetection to be omitted when we have the swrast gallium
driver. Whereas it
https://bugs.freedesktop.org/show_bug.cgi?id=79469
Emil Velikov emil.l.veli...@gmail.com changed:
What|Removed |Added
Status|NEW |RESOLVED
https://bugs.freedesktop.org/show_bug.cgi?id=79039
Bug 79039 depends on bug 79230, which changed state.
Bug 79230 Summary: After upgrade from 10.1.4 to 10.2-rc4 cross-compile fails
https://bugs.freedesktop.org/show_bug.cgi?id=79230
What|Removed |Added
https://bugs.freedesktop.org/show_bug.cgi?id=79230
Emil Velikov emil.l.veli...@gmail.com changed:
What|Removed |Added
Status|NEW |RESOLVED
Previously, a line such as:
#else garbage
would flag an error if it followed #if 0, but not if it followed #if 1.
We fix this by setting a new bit of state (lexing_else) that allows the lexer
to defer switching to the SKIP start state until after the NEWLINE following
the #else
- Original Message -
From: Roland Scheidegger srol...@vmware.com
Gallium (but not OpenGL) does allow nesting of queries, but there's no
limit specified (d3d10 has no limit neither). Nevertheless, for practical
purposes we need some limit in llvmpipe, otherwise we'd need more
Commit 17c7ead7 exposed a bug in how uniform loading happens in the
presence of discard. It manifested itself in an application as randomly
incorrect pixels on the borders of conditional areas.
We believe it is due to how discards jump to the end of the shader
incorrectly for some channels. The
On Thu, Jun 12, 2014 at 11:26 AM, Carl Worth cwo...@cworth.org wrote:
Previously, a line such as:
#else garbage
would flag an error if it followed #if 0, but not if it followed #if 1.
We fix this by setting a new bit of state (lexing_else) that allows the lexer
to defer switching
Hi all,
These patches add support for building (grouping) the various targets per
API, meaning that only one library will be created for e.g. vdpau
(libvdpau_gallium) with individual ones (libvdpau_r600) being a hardlink
to it.
This allows us to have substantial space savings as the
- gallium_pipe_loader_winsys_libs
Will be used in upcomming commits to reduce duplication
in the build.
v2: Drop the megadriver/static_target variables.
Signed-off-by: Emil Velikov emil.l.veli...@gmail.com
---
src/gallium/Automake.inc | 16
1 file changed, 16 insertions(+)
If memory serves me right, at least one debug wrapper does
not return the base screen on failure.
Signed-off-by: Emil Velikov emil.l.veli...@gmail.com
---
src/gallium/auxiliary/target-helpers/inline_debug_helper.h | 4
1 file changed, 4 insertions(+)
diff --git
Signed-off-by: Emil Velikov emil.l.veli...@gmail.com
---
src/gallium/targets/pipe-loader/Makefile.am | 28 +---
1 file changed, 25 insertions(+), 3 deletions(-)
diff --git a/src/gallium/targets/pipe-loader/Makefile.am
b/src/gallium/targets/pipe-loader/Makefile.am
index
Signed-off-by: Emil Velikov emil.l.veli...@gmail.com
---
src/gallium/targets/pipe-loader/pipe_nouveau.c | 25 -
src/gallium/targets/pipe-loader/pipe_r300.c | 25 -
src/gallium/targets/pipe-loader/pipe_r600.c | 25 -
The string is malloc'd (strdup) in loader_get_driver_for_fd().
Signed-off-by: Emil Velikov emil.l.veli...@gmail.com
---
src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c
Required for the dri state-tracker. Will be used to retrieve
driver specific configuration parameters:
- share_fd (dmabuf) capability
- throttle
Signed-off-by: Emil Velikov emil.l.veli...@gmail.com
---
src/gallium/auxiliary/pipe-loader/pipe_loader.c| 7 +++
Will be used by gallium targets that statically link the
pipe-drivers in the final library. Provides identical
functionality to device_descriptor.create_screan.
Signed-off-by: Emil Velikov emil.l.veli...@gmail.com
---
.../auxiliary/target-helpers/inline_drm_helper.h | 218 +
To match their original dri-* targets, respectively.
Signed-off-by: Emil Velikov emil.l.veli...@gmail.com
---
src/gallium/targets/pipe-loader/pipe_i915.c | 3 +++
src/gallium/targets/pipe-loader/pipe_vmwgfx.c | 3 +++
2 files changed, 6 insertions(+)
diff --git
Will be used to control the linking mode of pipe-drivers
in gallium targets.
XXX: Do we want to expose this via configure option ?
I'm personally inclined to use pipe-drivers despite the
unstable interface between them and the rest of mesa.
Signed-off-by: Emil Velikov emil.l.veli...@gmail.com
Create a single library (for the vdpau api) thus reducing
the overall size of mesa. Current commit converts
vdpau-nouveau, with upcomming commits handling the rest.
The library can be built with the relevant pipe-drivers
statically linked in, or loaded as shared modules.
Currently we default to
Similar to previous commit, this allows us to minimise some
of the duplication by compacting all vdpau targets into a
single library.
Cc: Christian König christian.koe...@amd.com
Signed-off-by: Emil Velikov emil.l.veli...@gmail.com
---
configure.ac| 3 +-
The number of components and their names/roles should
be kept constant as all of that information cached.
Cc: Leo Liu leo@amd.com
Cc: Christian König christian.koe...@amd.com
Signed-off-by: Emil Velikov emil.l.veli...@gmail.com
---
src/gallium/state_trackers/omx/entrypoint.c | 15
Similar to previous commits, this allows us to minimise some
of the duplication by compacting all vdpau targets into a
single library.
Cc: Christian König christian.koe...@amd.com
Signed-off-by: Emil Velikov emil.l.veli...@gmail.com
---
configure.ac| 3 +-
Strictly speaking we should not have done this in the
first place, as all of the above should be static across
the system.
Currently this may cause some minor issues, which will be
resolved in the following patches, by providing a single
library for the OMX api.
Cleanup a few unneeded strcpy
The flags are not specific to the video targets plus
we can reuse them for targets/xa and targets/gbm.
Signed-off-by: Emil Velikov emil.l.veli...@gmail.com
---
src/gallium/Automake.inc | 2 +-
src/gallium/targets/omx/Makefile.am | 2 +-
src/gallium/targets/vdpau/Makefile.am | 2 +-
Move the gbm target code to the state-tracker, similar
to other - dri, omx, vdpau... ST.
Cc: Chia-I Wu o...@lunarg.com
Signed-off-by: Emil Velikov emil.l.veli...@gmail.com
---
src/gallium/state_trackers/gbm/Makefile.am | 10 +-
src/gallium/state_trackers/gbm/gbm_drm.c | 65
The radeonsi counterpart of previous commit - now libomx-radeonsi is
built into the libomx-mesa library. Providing a single library per API.
Cc: Leo Liu leo@amd.com
Cc: Christian König christian.koe...@amd.com
Signed-off-by: Emil Velikov emil.l.veli...@gmail.com
---
configure.ac
Add a couple of helpers to be used by the dri targets when
built with static pipe-drivers. Both functions provide
functionality required by the dri state-tracker.
With this patch ilo, nouveau and r300 gain support for
throttle dri configuration.
Signed-off-by: Emil Velikov
Update all three build systems, and add freedreno to the android
build. Pending future work on the ST we can convert egl-static
to provide either static or dynamic access to the pipe-drivers.
There is no functional change with this patch.
Cc: Chia-I Wu o...@lunarg.com
Signed-off-by: Emil Velikov
The r600 counterpart of previous commit - now the libomx-r600 is
built into the libomx-mesa library. Providing a single library per API.
Cc: Leo Liu leo@amd.com
Cc: Christian König christian.koe...@amd.com
Signed-off-by: Emil Velikov emil.l.veli...@gmail.com
---
configure.ac
The r600 equivalent of previous commit.
Cc: Christian König christian.koe...@amd.com
Signed-off-by: Emil Velikov emil.l.veli...@gmail.com
---
configure.ac | 3 +-
src/gallium/Automake.inc | 20 -
src/gallium/targets/Makefile.am
Similar to vdpau targets, we're going to convert the individual
target libraries into a single one.
The library can be built with the relevant pipe-drivers
statically linked in, or loaded as shared modules.
Currently we default to static.
Cc: Ilia Mirkin imir...@alum.mit.edu
Signed-off-by: Emil
Required for the conversion stage of all VL targets to
a single library per API (static/shared pipe-drivers).
No longer required as per last commit.
Signed-off-by: Emil Velikov emil.l.veli...@gmail.com
---
src/gallium/auxiliary/vl/vl_winsys_dri.c | 8
1 file changed, 8 deletions(-)
Similar to the vdpau/xvmc targets, we're going to convert the
multiple target libraries into a single one.
The library can be built with the relevant pipe-drivers
statically linked in, or loaded as shared modules.
Currently we default to static.
Signed-off-by: Emil Velikov
Drop ~50 lines of buildsystem mayhem.
Signed-off-by: Emil Velikov emil.l.veli...@gmail.com
---
src/gallium/targets/gbm/Makefile.am| 14 +-
src/gallium/targets/opencl/Makefile.am | 18 --
src/gallium/targets/xa/Makefile.am | 14 +-
Now we can build the xa target (libxatracker) with either static
pipe-drivers or shared ones. Currently we default to static.
- Remove the unused CFLAGS/CPPFLAGS.
- Use GALLIUM_TARGET_CFLAGS where applicable.
Cc: Jakob Bornecrantz ja...@vmware.com
Cc: Rob Clark robcl...@freedesktop.org
Cc:
On Wed, Jun 11, 2014 at 05:28:01PM +0200, Bruno Jiménez wrote:
That commit made possible that the items could be one just
after the other when their size was a multiple of ITEM_ALIGNMENT.
But compute_memory_prealloc_chunk still looked to leave a gap
between items. Resulting in that we got an
Previously, a line such as:
#else garbage
would flag an error if it followed #if 0, but not if it followed #if 1.
We fix this by setting a new bit of state (lexing_else) that allows the lexer
to defer switching to the SKIP start state until after the NEWLINE following
the #else
On Thu, Jun 12, 2014 at 12:58 PM, Carl Worth cwo...@cworth.org wrote:
Previously, a line such as:
#else garbage
would flag an error if it followed #if 0, but not if it followed #if 1.
We fix this by setting a new bit of state (lexing_else) that allows the lexer
to defer switching
The preprocessor defines a notions of a preprocessing number that
starts with either a digit or a decimal point, and continues with zero
or more of digits, decimal points, identifier characters, or the sign
symbols, ('-' and '+').
Prior to this change, preprocessing numbers were lexed as some
On Fri, May 30, 2014 at 05:31:09PM +0200, Bruno Jiménez wrote:
This series allows clover to answer the query for the number of
max compute units of the devices.
The data has been extracted from:
AMD Accelerated Parallel Processing OpenCL Programming Guide (rev 2.7)
Appendix D: Device
On Thu, Jun 12, 2014 at 3:13 PM, Carl Worth cwo...@cworth.org wrote:
The preprocessor defines a notions of a preprocessing number that
starts with either a digit or a decimal point, and continues with zero
or more of digits, decimal points, identifier characters, or the sign
symbols, ('-' and
On Thu, Jun 12, 2014 at 12:58 PM, Carl Worth cwo...@cworth.org wrote:
Previously, a line such as:
#else garbage
would flag an error if it followed #if 0, but not if it followed #if 1.
We fix this by setting a new bit of state (lexing_else) that allows the lexer
to defer switching
From: Michel Dänzer michel.daen...@amd.com
This way, the compiler warns about unhandled caps.
Signed-off-by: Michel Dänzer michel.daen...@amd.com
---
src/gallium/drivers/radeon/r600_pipe_common.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git
On 12.06.2014 17:00, Maarten Lankhorst wrote:
I'm pretty sure that p_atomic_dec_zero should return 1 if the count
drops to zero.
Cc: 10.2 10.1 10.0 mesa-sta...@lists.freedesktop.org
I don't think the stable tag is justified: These bugs have been there
for more than four years. Nothing in
75 matches
Mail list logo
