Re: [Mesa-dev] [PATCH] gbm: Replace GBM_DRIVERS_PATH with LIBGL_DRIVERS_PATH

2014-07-21 Thread Eric Anholt
Emil Velikov emil.l.veli...@gmail.com writes: On 18/07/14 17:27, Kenneth Graunke wrote: On Friday, July 18, 2014 07:41:57 AM Dylan Baker wrote: Currently mesa searches for two different environment variables, LIBGL_DRIVERS_PATH and GBM_DRIVERS_PATH. The first is used for search for DRI

Re: [Mesa-dev] [PATCH 04/14] i965/gen7: Don't allocate hiz miptree structure

2014-07-21 Thread Pohjolainen, Topi
On Sat, Jul 19, 2014 at 07:08:59PM -0700, Jordan Justen wrote: On Fri, Jul 18, 2014 at 1:58 AM, Pohjolainen, Topi topi.pohjolai...@intel.com wrote: On Tue, Jul 15, 2014 at 06:32:12PM -0700, Jordan Justen wrote: We now skip allocating a hiz miptree for gen7. Instead, we calculate the

Re: [Mesa-dev] [PATCH 0/5] radeon: Write-combined CPU mappings of BOs in GTT

2014-07-21 Thread Christian König
Am 19.07.2014 03:15, schrieb Michel Dänzer: On 19.07.2014 00:47, Christian König wrote: Am 18.07.2014 05:07, schrieb Michel Dänzer: [PATCH 5/5] drm/radeon: Use VRAM for indirect buffers on = SI I'm still not very keen with this change since I still don't understand the reason why it's faster

[Mesa-dev] [PATCH 08/14] egl: enable building freedreno under Android

2014-07-21 Thread Emil Velikov
For all everyone willing to give the freedreno driver a go they can now build it under Android. Cc: 10.1 10.2 mesa-sta...@lists.freedesktop.org Cc: Rob Clark robcl...@freedesktop.org Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- src/egl/main/Android.mk | 6 ++

[Mesa-dev] [PATCH 04/14] gallium/radeon: attempt to fix the android build

2014-07-21 Thread Emil Velikov
From: Paulo Sergio Travaglia pstg...@gmail.com - add missing includes (android build uses the source tree) - add a new buildscript for the common radeon folder Cc: 10.1 10.2 mesa-sta...@lists.freedesktop.org [Emil Velikov] Split up and add commit message. Signed-off-by: Emil Velikov

[Mesa-dev] [PATCH 12/14] automake: handle gallium SUBDIRs in gallium/Makefile

2014-07-21 Thread Emil Velikov
Considering the way we've been consolidating things it makes sense to add the final two (aux and tests) in here. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- src/Makefile.am | 10 +- src/gallium/Makefile.am | 16 2 files changed, 17 insertions(+), 9

[Mesa-dev] [PATCH 02/14] egl/main: fixup android + nouveau build

2014-07-21 Thread Emil Velikov
For a while the nouveau pipe driver has been a static library and it has been using STL for even longer. Correct add the link and cleanup the gallium_DRIVERS. Cc: 10.1 10.2 mesa-sta...@lists.freedesktop.org Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- src/egl/main/Android.mk | 8

[Mesa-dev] [PATCH 13/14] android: reorder gallium SUBDIRS

2014-07-21 Thread Emil Velikov
To be closer to its automake counterpart. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- src/gallium/Android.mk | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/src/gallium/Android.mk b/src/gallium/Android.mk index 767361a..bf99e4f 100644 ---

[Mesa-dev] [PATCH 01/14] egl/main: Bring in the Makefile.sources

2014-07-21 Thread Emil Velikov
Rather than having the sources list duplicated across all three build systems, define it once and use it whenever needed. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- src/egl/main/Android.mk | 23 --- src/egl/main/Makefile.am | 40

[Mesa-dev] [PATCH 06/14] gallium/freedreno: automake: drop spurious include dirs

2014-07-21 Thread Emil Velikov
Rather than including two extra folders only for two headers, correctly prefix the headers. Cc: 10.1 10.2 mesa-sta...@lists.freedesktop.org Cc: Rob Clark robcl...@freedesktop.org Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- src/gallium/drivers/freedreno/Makefile.am| 2 --

[Mesa-dev] [PATCH 03/14] gallium/nouveau: link against libstlport to fix the android build

2014-07-21 Thread Emil Velikov
nouveau uses STL for a while now thus we need to include external/stlport/libstlport.mk in order to get the build at least partially working. Cc: 10.1 10.2 mesa-sta...@lists.freedesktop.org Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- src/gallium/drivers/nouveau/Android.mk | 7

[Mesa-dev] [PATCH 05/14] egl/main: resolve radeon+android linking issues

2014-07-21 Thread Emil Velikov
From: Paulo Sergio Travaglia pstg...@gmail.com - link against libdrm_radeon - link the r600 driver against libstlport - linkin the newly added libmesa_pipe_radeon library required by r600 and radeonsi drivers Cc: 10.1 10.2 mesa-sta...@lists.freedesktop.org [Emil Velikov] Split up and add

[Mesa-dev] Android build fixes dropping three automake makefiles

2014-07-21 Thread Emil Velikov
As usual trying to bring some order and symmetry to the build chaos that mesa is. Prefixed with a few fixes that make the android build in gallium a step closer to functional, thus tagged as stable material. Note: The patches are on top of Giovanni's egl-drm series, so the automake (patches

[Mesa-dev] [PATCH 11/14] automake: compact gallium/target/Makefile into gallium/Makefile

2014-07-21 Thread Emil Velikov
Yet another makefile less to worry about. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- configure.ac| 1 - src/Makefile.am | 3 +- src/gallium/Makefile.am | 25 --- src/gallium/targets/Makefile.am | 71

[Mesa-dev] [PATCH 07/14] gallium/freedreno: add preliminary android build-system

2014-07-21 Thread Emil Velikov
For all the people interested in testing the freedreno driver on their Android devices. The next commit will hook these up within the libEGL driver (via the gallium-egl backend). There may be some rough edges but those can be sorted when a willing builder/tester comes along. Cc: 10.1 10.2

[Mesa-dev] [PATCH 09/14] automake: compact gallium/drivers and gallium/winsys makefiles

2014-07-21 Thread Emil Velikov
Rather than having two separate almost empty and identical makefiles, compact them thus improving the configure and build time. Additionally this makes the automake build symmetrical to the scons and android one. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- configure.ac

[Mesa-dev] [PATCH 10/14] automake: merge gallium/state_trackers/Makefile into gallium/Makefile

2014-07-21 Thread Emil Velikov
One makefile less, with the potential of further compacting the automake build. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- configure.ac | 1 - src/Makefile.am| 1 - src/gallium/Makefile.am| 49

[Mesa-dev] [PATCH 14/14] scons: group state-trackers' and targets' scons

2014-07-21 Thread Emil Velikov
Both share the identical dependencies, as such we can simplify the scons script. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- src/gallium/SConscript | 42 +++--- 1 file changed, 11 insertions(+), 31 deletions(-) diff --git a/src/gallium/SConscript

Re: [Mesa-dev] [PATCH v4 0/3] Software rendering in EGL-DRM

2014-07-21 Thread Emil Velikov
Giovanni can you test the series that I've not butchered anything else during the rebase ? Thanks Emil On 11/07/14 18:19, Emil Velikov wrote: Hello all, Here is hopefully the last iteration of Giovanni's patches, rebased on top of the buildsystem mayhem that I've caused recently. I've a

[Mesa-dev] [Bug 77966] Trails / Tracks when rendering OpenGL ES 2 moving objects (Android-x86 / Mesa 10.0.4/5)

2014-07-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77966 Emil Velikov emil.l.veli...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED

[Mesa-dev] [Bug 81500] wrong color in flightgear for the c172p if Atmospheric light scattering is used

2014-07-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=81500 --- Comment #24 from Barto mister.free...@laposte.net --- (In reply to comment #22) From what I can see, this commit has nothing to do with any issues introduced by the originally bad commit... this will require some investigation. Could

[Mesa-dev] Odd issue caused by commit d030a3404ca (linker: Sort shader I/O variables into a canonical order)

2014-07-21 Thread Ilia Mirkin
Hi Ian, A user has bisected an issue with the color of the rendered plane in fgfs to your commit d030a3404ca (and has verified that reverting it on top of 10.2.x resolves the problem). The issue also disappears on master starting with commit 1d9f74eda7 (glsl: Rebalance expression trees that are

[Mesa-dev] More big-endian patches

2014-07-21 Thread Richard Sandiford
Hi, Sorry for the much longer than intended delay, but I've finally got back to the big-endian stuff that Adam an I started last year. To recap, the initial patches were enough to get a gnome desktop working on big-endian PowerPC and System z, which was the initial goal, but due to time

Re: [Mesa-dev] [PATCH] gbm: Replace GBM_DRIVERS_PATH with LIBGL_DRIVERS_PATH

2014-07-21 Thread Kristian Høgsberg
On Sun, Jul 20, 2014 at 11:36 PM, Eric Anholt e...@anholt.net wrote: Emil Velikov emil.l.veli...@gmail.com writes: On 18/07/14 17:27, Kenneth Graunke wrote: On Friday, July 18, 2014 07:41:57 AM Dylan Baker wrote: Currently mesa searches for two different environment variables,

Re: [Mesa-dev] [PATCH] gbm: Replace GBM_DRIVERS_PATH with LIBGL_DRIVERS_PATH

2014-07-21 Thread Ilia Mirkin
On Mon, Jul 21, 2014 at 11:23 AM, Kristian Høgsberg k...@bitplanet.net wrote: On Sun, Jul 20, 2014 at 11:36 PM, Eric Anholt e...@anholt.net wrote: Emil Velikov emil.l.veli...@gmail.com writes: On 18/07/14 17:27, Kenneth Graunke wrote: On Friday, July 18, 2014 07:41:57 AM Dylan Baker wrote:

[Mesa-dev] [PATCH 4/6] util: Add big-endian layout for 4444 formats

2014-07-21 Thread Richard Sandiford
--- src/gallium/auxiliary/util/u_format.csv | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/auxiliary/util/u_format.csv b/src/gallium/auxiliary/util/u_format.csv index 1dec8ce..c43210e 100644 --- a/src/gallium/auxiliary/util/u_format.csv +++

[Mesa-dev] [PATCH 3/6] util: Add big-endian layout for 10/10/10/2 formats

2014-07-21 Thread Richard Sandiford
--- src/gallium/auxiliary/util/u_format.csv | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/src/gallium/auxiliary/util/u_format.csv b/src/gallium/auxiliary/util/u_format.csv index 834b08b..1dec8ce 100644 ---

[Mesa-dev] [PATCH 1/6] util: Add big-endian layout for depth/stencil formats

2014-07-21 Thread Richard Sandiford
This patch builds on 6c8f547f66e68b495c708f8ffcb67370caa5ffe8 and previous patches by allowing u_format.csv to specify separate big-endian and little-endian layouts. It then uses this to specify the correct layouts for various depth/stencil formats. Later patches handle other formats. To recap,

[Mesa-dev] [PATCH 0/6] util: Fix packed layouts for big-endian

2014-07-21 Thread Richard Sandiford
This series adds a way of specifying a separate big-endian layout in u_format.csv and uses it for the formats where the layout depends on endianness. Richard Sandiford (6): util: Add big-endian layout for depth/stencil formats util: Add big-endian layout for 5551 and 565 formats util: Add

[Mesa-dev] [PATCH 5/6] util: Add big-endian layout for 233 format

2014-07-21 Thread Richard Sandiford
--- src/gallium/auxiliary/util/u_format.csv | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/util/u_format.csv b/src/gallium/auxiliary/util/u_format.csv index c43210e..b68f6c2 100644 --- a/src/gallium/auxiliary/util/u_format.csv +++

[Mesa-dev] [PATCH 2/6] util: Add big-endian layout for 5551 and 565 formats

2014-07-21 Thread Richard Sandiford
--- src/gallium/auxiliary/util/u_format.csv | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/gallium/auxiliary/util/u_format.csv b/src/gallium/auxiliary/util/u_format.csv index c596de9..834b08b 100644 --- a/src/gallium/auxiliary/util/u_format.csv +++

[Mesa-dev] [PATCH 3/5] util: Define PIPE_FORMAT_{LA, AL, RG, GR}nn aliases

2014-07-21 Thread Richard Sandiford
...i.e. formats in which the first listed component is in the least significant half of the integer. --- src/gallium/include/pipe/p_format.h | 32 1 file changed, 32 insertions(+) diff --git a/src/gallium/include/pipe/p_format.h

[Mesa-dev] [PATCH 5/5] Fix handling of LA and RG formats for big-endian

2014-07-21 Thread Richard Sandiford
MESA_FORMAT_LnAn puts the luminance in the least significant part of the containing integer, which is equivalent to PIPE_FORMAT_LAnn. PIPE_FORMAT_LnAn puts the luminance first in memory. This patch fixes up the mesa-gallium mapping accordingly. --- src/mesa/state_tracker/st_format.c | 64

[Mesa-dev] [PATCH 4/5] Add MESA_FORMAT_A8L8_{SNORM,SRGB}

2014-07-21 Thread Richard Sandiford
The associated UNORM format already existed. This means that each LnAn format has a reversed counterpart, which is necessary for handling big-endian mesa-gallium mappings. --- src/mesa/drivers/dri/i965/brw_surface_formats.c | 2 ++ src/mesa/main/format_pack.c | 37

[Mesa-dev] [PATCH 2/5] util: Add PIPE_FORMAT_AnLn and PIPE_FORMAT_GnRn formats

2014-07-21 Thread Richard Sandiford
...i.e. formats in which the alpha or green channel is first in memory. This means that each LnAn and RnGn format has a reversed counterpart, which is necessary for handling big-endian mesa-gallium mappings. --- src/gallium/auxiliary/util/u_format.csv | 9 +

[Mesa-dev] [PATCH 1/5] swrast: Fix handling of MESA_FORMAT_L8A8_SRGB for big-endian

2014-07-21 Thread Richard Sandiford
Luminance is the least-significant byte of the uint16, rather than the lowest byte in memory. Other parts of mesa already handle this correctly for big-endian, and swrast already handles other MESA_FORMAT_x8y8 formats correctly. This case was just an odd-one-out. ---

[Mesa-dev] [PATCH 0/5] Fix handling of LnAn and RnGn formats for big-endian

2014-07-21 Thread Richard Sandiford
MESA_FORMAT_LnAn_* puts the luminance in the low part of the integer and the alpha in the high part. The same goes for MESA_FORMAT_RnGn with the red and green channels. This series fixes gallium to be consistent with that layout on big-endian. Following the convention established last year,

[Mesa-dev] [PATCH 0/7] Fix handling of 8-bits-per-channel SRGB and SNORM formats

2014-07-21 Thread Richard Sandiford
Similar to the L/A and R/G series I just posted, this one fixes the SNORM and SRGB formats. The UNORM ones were done last year as part of the original big-endian work. Richard Sandiford (7): util: Add PIPE_FORMAT_x8B8G8R8_SNORM formats util: Define PIPE_FORMAT_xyzw_{SNORM,SRGB}

[Mesa-dev] [PATCH 7/7] Fix handling of 8888 SNORM and SRGB formats for big-endian

2014-07-21 Thread Richard Sandiford
MESA_FORMAT_x8y8z8w8 puts the x channel in the least significant part of the containing 32-bit integer, which is equivalent to PIPE_FORMAT_xyzw. PIPE_FORMAT_x8y8z8w8 puts the x channel first in memory. This patch fixes up the mesa-gallium mapping accordingly. ---

[Mesa-dev] [PATCH 6/7] Add MESA_FORMAT_{A8R8G8B8, X8R8G8B8, X8B8G8R8}_SRGB

2014-07-21 Thread Richard Sandiford
This means that each SRGB format has a reversed counterpart, which is necessary for handling big-endian mesa-gallium mappings. --- src/mesa/drivers/dri/i965/brw_surface_formats.c | 1 + src/mesa/main/format_pack.c | 60 +

[Mesa-dev] [PATCH 5/7] main: Fix _mesa_texstore_signed_rgb?8888 for big-endian

2014-07-21 Thread Richard Sandiford
MESA_FORMAT_x8y8z8w8 means a format in which x is the least signficant byte and w is the most significant byte. Most functions get that right, but the signed ones access the bytes from an array rather than an integer, so they need to take endianness into account. This isn't too onerous since

[Mesa-dev] [PATCH 2/7] util: Define PIPE_FORMAT_xyzw8888_{SNORM, SRGB} aliases

2014-07-21 Thread Richard Sandiford
...i.e. formats in which the first listed component is in the least significant byte of the integer. The corresponding UNORM aliases already exist. --- src/gallium/include/pipe/p_format.h | 24 1 file changed, 24 insertions(+) diff --git

[Mesa-dev] [PATCH 3/7] main: Tweak unpack name for MESA_FORMAT_R8G8B8X8_SNORM

2014-07-21 Thread Richard Sandiford
MESA_FORMAT_R8G8B8X8_SNORM used a function called unpack_X8B8G8R8_SNORM while MESA_FORMAT_R8G8B8X8_SRGB used a function called unpack_R8G8B8X8_SRGB. This patch renames the SNORM function to have the same order as the MESA_FORMAT name, like the SRGB function does. --- src/mesa/main/format_unpack.c

[Mesa-dev] [PATCH 1/7] util: Add PIPE_FORMAT_x8B8G8R8_SNORM formats

2014-07-21 Thread Richard Sandiford
This means that each RnGnBnxn format has a reversed counterpart, which is necessary for handling big-endian mesa-gallium mappings. The associated UNORM and SRGB formats already exist. --- src/gallium/auxiliary/util/u_format.csv | 3 +++ src/gallium/include/pipe/p_format.h | 3 +++ 2 files

[Mesa-dev] [PATCH 4/7] main: Fix alpha component in unpack_R8G8B8X8_SRGB

2014-07-21 Thread Richard Sandiford
The function was using the X component as the alpha channel, rather than setting alpha to 1.0. --- src/mesa/main/format_unpack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/format_unpack.c b/src/mesa/main/format_unpack.c index ae14478..fddb067 100644 ---

[Mesa-dev] [PATCH] llvmpipe: Fix PIPE_FORMAT_Z32_FLOAT_S8X24_UINT handling for big-endian.

2014-07-21 Thread Richard Sandiford
llvmpipe treats PIPE_FORMAT_Z32_FLOAT_S8X24_UINT as a bit of a special case, handling it as two 32-bit pieces rather than a single 64-bit block: /* 64bit d/s format is special already extracted 32 bits */ total_bits = format_desc-block.bits 32 ? 32 : format_desc-block.bits; The

[Mesa-dev] [PATCH] util: Fix 64-bit depth/stencil packs for big-endian

2014-07-21 Thread Richard Sandiford
The pack64 routines were hardwired for little-endian layout. On big-endian, loading a PIPE_FORMAT_Z32_FLOAT_S8X24_UINT as a 64-bit integer puts the depth float in the high 32 bits and the stencil in the low 8 bits, like for the associated MESA_FORMAT_*. Signed-off-by: Richard Sandiford

[Mesa-dev] [PATCH] gallivm: Fix uses of 2^24

2014-07-21 Thread Richard Sandiford
Fallback cases in lp_bld_arit.c used 2^24 to mean 2 to the power 24, but in C it's 2 xor 24, i.e. 26. Fixed by using 1 instead. Signed-off-by: Richard Sandiford rsand...@linux.vnet.ibm.com --- src/gallium/auxiliary/gallivm/lp_bld_arit.c | 8 1 file changed, 4 insertions(+), 4

[Mesa-dev] [PATCH] gallivm: Add SNORM clamping to lp_build_{add, sub}

2014-07-21 Thread Richard Sandiford
...fixing the associated TODO. Signed-off-by: Richard Sandiford rsand...@linux.vnet.ibm.com --- src/gallium/auxiliary/gallivm/lp_bld_arit.c | 34 - 1 file changed, 28 insertions(+), 6 deletions(-) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_arit.c

[Mesa-dev] [PATCH] util: Fix fallback iround handling of integral inputs

2014-07-21 Thread Richard Sandiford
lp_build_iround has a fallback case that tries to emulate a round-to-nearest float-int conversion by adding 0.5 and using a truncating fptosi. For odd numbers in the range [2^23, 2^24], which are already integral, this has the effect of adding 1 to the integer, since the result of adding 0.5 is

[Mesa-dev] [PATCH 6/6] util: Add big-endian layout for 44 formats

2014-07-21 Thread Richard Sandiford
--- src/gallium/auxiliary/util/u_format.csv | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gallium/auxiliary/util/u_format.csv b/src/gallium/auxiliary/util/u_format.csv index b68f6c2..1cd4954 100644 --- a/src/gallium/auxiliary/util/u_format.csv +++

Re: [Mesa-dev] State of llvmpipe geometry shaders?

2014-07-21 Thread Ceniza
Hi again. It seems I finally found out the trick, even though the render tests in OpenGL Extensions Viewer for OpenGL 3 will still remain disabled. The following environment variable must be defined in order to get OpenGL 3.3 support with a forward context: MESA_GL_VERSION_OVERRIDE=3.3FC I can

Re: [Mesa-dev] [PATCH 06/14] gallium/freedreno: automake: drop spurious include dirs

2014-07-21 Thread Rob Clark
On Mon, Jul 21, 2014 at 6:40 AM, Emil Velikov emil.l.veli...@gmail.com wrote: Rather than including two extra folders only for two headers, correctly prefix the headers. Cc: 10.1 10.2 mesa-sta...@lists.freedesktop.org Cc: Rob Clark robcl...@freedesktop.org Signed-off-by: Emil Velikov

Re: [Mesa-dev] [PATCH 07/14] gallium/freedreno: add preliminary android build-system

2014-07-21 Thread Matt Turner
On Mon, Jul 21, 2014 at 3:40 AM, Emil Velikov emil.l.veli...@gmail.com wrote: For all the people interested in testing the freedreno driver on their Android devices. The next commit will hook these up within the libEGL driver (via the gallium-egl backend). There may be some rough edges but

[Mesa-dev] [PATCH 3/3] i965/fs: Decide predicate/predicate_inverse outside of the for loop.

2014-07-21 Thread Matt Turner
--- src/mesa/drivers/dri/i965/brw_fs_sel_peephole.cpp | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_sel_peephole.cpp b/src/mesa/drivers/dri/i965/brw_fs_sel_peephole.cpp index c0bba8e..03c7ee6 100644 ---

[Mesa-dev] [PATCH 1/3] i965: Improve dead control flow elimination.

2014-07-21 Thread Matt Turner
... to eliminate an ELSE instruction followed immediately by an ENDIF. instructions in affected programs: 704 - 700 (-0.57%) --- .../drivers/dri/i965/brw_dead_control_flow.cpp | 25 +- 1 file changed, 15 insertions(+), 10 deletions(-) diff --git

[Mesa-dev] [PATCH 2/3] i965/fs: Swap if/else conditions in SEL peephole.

2014-07-21 Thread Matt Turner
Will clarify make the next commit easier to read. --- src/mesa/drivers/dri/i965/brw_fs_sel_peephole.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_sel_peephole.cpp b/src/mesa/drivers/dri/i965/brw_fs_sel_peephole.cpp index

Re: [Mesa-dev] [PATCH] gallivm: Add SNORM clamping to lp_build_{add, sub}

2014-07-21 Thread Roland Scheidegger
Am 21.07.2014 17:53, schrieb Richard Sandiford: ...fixing the associated TODO. Signed-off-by: Richard Sandiford rsand...@linux.vnet.ibm.com --- src/gallium/auxiliary/gallivm/lp_bld_arit.c | 34 - 1 file changed, 28 insertions(+), 6 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] gallivm: Fix uses of 2^24

2014-07-21 Thread Roland Scheidegger
Am 21.07.2014 17:53, schrieb Richard Sandiford: Fallback cases in lp_bld_arit.c used 2^24 to mean 2 to the power 24, but in C it's 2 xor 24, i.e. 26. Fixed by using 1 instead. Signed-off-by: Richard Sandiford rsand...@linux.vnet.ibm.com --- src/gallium/auxiliary/gallivm/lp_bld_arit.c | 8

Re: [Mesa-dev] [PATCH] llvmpipe: Fix PIPE_FORMAT_Z32_FLOAT_S8X24_UINT handling for big-endian.

2014-07-21 Thread Roland Scheidegger
Am 21.07.2014 17:53, schrieb Richard Sandiford: llvmpipe treats PIPE_FORMAT_Z32_FLOAT_S8X24_UINT as a bit of a special case, handling it as two 32-bit pieces rather than a single 64-bit block: /* 64bit d/s format is special already extracted 32 bits */ total_bits =

Re: [Mesa-dev] [PATCH] gbm: Replace GBM_DRIVERS_PATH with LIBGL_DRIVERS_PATH

2014-07-21 Thread Emil Velikov
On 21/07/14 16:25, Ilia Mirkin wrote: On Mon, Jul 21, 2014 at 11:23 AM, Kristian Høgsberg k...@bitplanet.net wrote: On Sun, Jul 20, 2014 at 11:36 PM, Eric Anholt e...@anholt.net wrote: Emil Velikov emil.l.veli...@gmail.com writes: On 18/07/14 17:27, Kenneth Graunke wrote: On Friday, July

[Mesa-dev] [Bug 81500] wrong color in flightgear for the c172p if Atmospheric light scattering is used

2014-07-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=81500 Ian Romanick i...@freedesktop.org changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment

Re: [Mesa-dev] [PATCH 1/3] i965: Improve dead control flow elimination.

2014-07-21 Thread Kenneth Graunke
On Monday, July 21, 2014 11:42:18 AM Matt Turner wrote: ... to eliminate an ELSE instruction followed immediately by an ENDIF. instructions in affected programs: 704 - 700 (-0.57%) --- .../drivers/dri/i965/brw_dead_control_flow.cpp | 25 +- 1 file changed, 15

[Mesa-dev] [Bug 64324] memory leak of visual info

2014-07-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=64324 --- Comment #1 from Andy Skinner askin...@mathworks.com --- Any chance someone could look at this? We still get it reported as a leak, though it is in a large system and it would be hard to send a repro case. I admit we have't updated in a

Re: [Mesa-dev] [PATCH 26/26] glsl: Add Bloom filter to get_static_name

2014-07-21 Thread Dylan Baker
On Monday, July 14, 2014 03:48:58 PM Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com The use of the Bloom filter rejects the vast majority of strings that are not in the table before expensive comparisons are performed. This Bloom filter uses two hashes. One is explicit

Re: [Mesa-dev] [PATCH 25/26] glsl: Keep common variable names in static storage

2014-07-21 Thread Dylan Baker
On Monday, July 14, 2014 03:48:57 PM Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com Valgrind massif results for a trimmed apitrace of dota2: ntime(i) total(B) useful-heap(B) extra-heap(B)stacks(B) Before (32-bit): 52 40,521,071,734

[Mesa-dev] [PATCH 09/16] linker: Add padding after the last field of a structure

2014-07-21 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com This causes the thing following the structure to be vec4-aligned. Fixes gles3conform failures in: ES3-CTS.shaders.uniform_block.random.nested_structs.2 ES3-CTS.shaders.uniform_block.random.all_shared_buffer.5 Signed-off-by: Ian Romanick

[Mesa-dev] [PATCH 00/16] Many UBO fixes

2014-07-21 Thread Ian Romanick
Around the time OpenGL ES 3.1 was released, Khronos made some significant updates to the OpenGL ES 3.0 conformance suite. These updates uncovered a number of bugs in our implementation of UBOs. This patch series fixes all 147 failing tests that I could attribute to UBO related problems. With

[Mesa-dev] [PATCH 11/16] glsl: Track matrix layout of structure fields using two bits

2014-07-21 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Signed-off-by: Ian Romanick ian.d.roman...@intel.com --- src/glsl/ast_to_hir.cpp| 8 +++-- src/glsl/builtin_types.cpp | 74 +- src/glsl/builtin_variables.cpp | 2 +- src/glsl/glsl_types.cpp|

[Mesa-dev] [PATCH 14/16] linker: Use the matrix layout information in ir_variable and glsl_type for UBO layout

2014-07-21 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Use the data that is stored in the ir_variable and the glsl_type to determine whether or not a UBO member is row-major. Fixes gles3conform failures in: ES3-CTS.shaders.uniform_block.instance_array_basic_type.shared.row_major_mat2

[Mesa-dev] [PATCH 02/16] mesa: Fix the name in the error message

2014-07-21 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Obvious copy-and-paste bug. Signed-off-by: Ian Romanick ian.d.roman...@intel.com --- src/mesa/main/uniform_query.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/uniform_query.cpp b/src/mesa/main/uniform_query.cpp

[Mesa-dev] [PATCH 06/16] glsl: Do not eliminate 'shared' or 'std140' blocks or block members

2014-07-21 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Commit 32f32292 (glsl: Allow elimination of uniform block members) enabled elimination of unused uniform block members to fix a gles3 conformance test failure. This went too far the other way. Section 2.11.6 (Uniform Variables) of the OpenGL ES 3.0.3

[Mesa-dev] [PATCH 05/16] glsl: Use the is_..._or_array_of predicates added in the previous commit

2014-07-21 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Signed-off-by: Ian Romanick ian.d.roman...@intel.com --- src/glsl/ast_to_hir.cpp| 3 +-- src/glsl/glsl_types.cpp| 3 +-- src/glsl/link_uniforms.cpp | 22 +++--- src/glsl/link_varyings.cpp | 6 ++ 4 files changed, 11

[Mesa-dev] [PATCH 12/16] glsl: Also track matrix layout information into structures

2014-07-21 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Signed-off-by: Ian Romanick ian.d.roman...@intel.com --- src/glsl/ast_to_hir.cpp | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index 1fb4274..eeafb44 100644 ---

[Mesa-dev] [PATCH 07/16] mesa: Do not list inactive block members as active

2014-07-21 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Fixes gles3conform failures in: ES3-CTS.shaders.uniform_block.single_nested_struct.per_block_buffer_packed ES3-CTS.shaders.uniform_block.single_nested_struct_array.per_block_buffer_packed ES3-CTS.shaders.uniform_block.random.scalar_types.7

[Mesa-dev] [PATCH 10/16] glsl: Correctly load columns of a row-major matrix

2014-07-21 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com For a row-major matrix, the next column starts at the next element. Fixes gles3conform failures in: ES3-CTS.shaders.uniform_block.single_basic_array.shared.row_major_mat2 ES3-CTS.shaders.uniform_block.single_basic_array.shared.row_major_mat3

[Mesa-dev] [PATCH 15/16] glsl: Correctly determine when the field of a UBO is row-major

2014-07-21 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Previously if a field of an block with an instance name was marked row-major (but block itself was not), we would think the field (and it's sub-fields) were column-major. Fixes gles3conform failures in:

[Mesa-dev] [PATCH 13/16] glsl: Track matrix layout of variables using two bits

2014-07-21 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Fixes gles3conform failures in: ES3-CTS.shaders.uniform_block.random.nested_structs_arrays_instance_arrays.3 ES3-CTS.shaders.uniform_block.random.all_per_block_buffers.13 Causes gles3conform failures in:

[Mesa-dev] [PATCH 04/16] glsl: Add is_{matrix, record, interface}_or_array_of predicates

2014-07-21 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com There are a bunch of places, especially in the UBO code, where we check whether something is a matrix (or record) when we actually want to know if it a matrix or an array of matrices (ditto for records). This will be used in later patches in this

[Mesa-dev] [PATCH 08/16] linker: Add a last_field parameter to various program_resource_visitor methods

2014-07-21 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com I also considered renaming visit_field(const glsl_struct_field *) to entry_record and adding an exit_record method. This would be more similar to the hierarchical visitor. Signed-off-by: Ian Romanick ian.d.roman...@intel.com ---

[Mesa-dev] [PATCH 03/16] glsl: Use constant_expression_value instead of as_constant

2014-07-21 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Just a few lines earlier we may have wrapped the index expression with ir_unop_i2u expression. Whenever that happens, as_constant will return NULL, and that almost always happens. Signed-off-by: Ian Romanick ian.d.roman...@intel.com ---

[Mesa-dev] [PATCH 01/16] glsl: Fix some bad indentation

2014-07-21 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Signed-off-by: Ian Romanick ian.d.roman...@intel.com --- src/glsl/link_uniform_blocks.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/glsl/link_uniform_blocks.cpp b/src/glsl/link_uniform_blocks.cpp index

[Mesa-dev] [PATCH 16/16] glsl: Do not add extra padding to structures

2014-07-21 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com This code was attemping to align the base of the structure to the required alignment of the structure. However, it had two problems: 1. It was aligning the target structure member, not the base of the structure. 2. It was calculating the alignment

Re: [Mesa-dev] [PATCH] util: Fix fallback iround handling of integral inputs

2014-07-21 Thread Roland Scheidegger
Am 21.07.2014 17:53, schrieb Richard Sandiford: lp_build_iround has a fallback case that tries to emulate a round-to-nearest float-int conversion by adding 0.5 and using a truncating fptosi. For odd numbers in the range [2^23, 2^24], which are already integral, this has the effect of adding 1

Re: [Mesa-dev] [PATCH 06/16] glsl: Do not eliminate 'shared' or 'std140' blocks or block members

2014-07-21 Thread Matt Turner
On Mon, Jul 21, 2014 at 2:04 PM, Ian Romanick i...@freedesktop.org wrote: From: Ian Romanick ian.d.roman...@intel.com Commit 32f32292 (glsl: Allow elimination of uniform block members) enabled elimination of unused uniform block members to fix a gles3 conformance test failure. This went too

Re: [Mesa-dev] [PATCH 26/26] glsl: Add Bloom filter to get_static_name

2014-07-21 Thread Ian Romanick
On 07/21/2014 01:56 PM, Dylan Baker wrote: On Monday, July 14, 2014 03:48:58 PM Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com The use of the Bloom filter rejects the vast majority of strings that are not in the table before expensive comparisons are performed. This Bloom

Re: [Mesa-dev] [PATCH 26/26] glsl: Add Bloom filter to get_static_name

2014-07-21 Thread Ilia Mirkin
On Mon, Jul 21, 2014 at 5:36 PM, Ian Romanick i...@freedesktop.org wrote: On 07/21/2014 01:56 PM, Dylan Baker wrote: 3) this is a silly function, all you need is: filter = range(0, filter_bits / 32) But that will be different... that's the same as filter = [0, 1, 2, 3, ...] but I want

Re: [Mesa-dev] [PATCH 1/2] i965/fs: Fix gl_SampleID for 2x MSAA and SIMD16 mode.

2014-07-21 Thread Kenneth Graunke
On Friday, July 18, 2014 02:32:10 PM Matt Turner wrote: On Fri, Jul 18, 2014 at 1:19 PM, Kenneth Graunke kenn...@whitecape.org wrote: We might be able to do this without an extra program key field, but this is non-invasive and fixes the bug, for now. This fixes the following Piglit

Re: [Mesa-dev] [PATCH] mesa: Don't use memcpy() in _mesa_texstore() for depth texture data

2014-07-21 Thread Anuj Phogat
On Fri, Jul 18, 2014 at 5:54 PM, Marek Olšák mar...@gmail.com wrote: Shouldn't the function return TRUE for floating-point depth textures only? Depth texture data needs clamping in following two cases: 1. Float texture format supplied with signed data needs clamping to [0.0, 1.0]. 2. Fixed

Re: [Mesa-dev] [PATCH 11/16] glsl: Track matrix layout of structure fields using two bits

2014-07-21 Thread Matt Turner
On Mon, Jul 21, 2014 at 2:04 PM, Ian Romanick i...@freedesktop.org wrote: +enum glsl_matrix_layout { + GLSL_MATRIX_LAYOUT_DEFAULT, Does this mean language-default, or does it really means the inherited layout? E.g., for layout(row_major) uniform a { mat4 m; }; m's .matrix_layout is

Re: [Mesa-dev] [PATCH] mesa: Don't use memcpy() in _mesa_texstore() for depth texture data

2014-07-21 Thread Marek Olšák
On Tue, Jul 22, 2014 at 12:09 AM, Anuj Phogat anuj.pho...@gmail.com wrote: On Fri, Jul 18, 2014 at 5:54 PM, Marek Olšák mar...@gmail.com wrote: Shouldn't the function return TRUE for floating-point depth textures only? Depth texture data needs clamping in following two cases: 1. Float

Re: [Mesa-dev] [PATCH 15/16] glsl: Correctly determine when the field of a UBO is row-major

2014-07-21 Thread Matt Turner
On Mon, Jul 21, 2014 at 3:28 PM, Matt Turner matts...@gmail.com wrote: On Mon, Jul 21, 2014 at 2:04 PM, Ian Romanick i...@freedesktop.org wrote: From: Ian Romanick ian.d.roman...@intel.com Previously if a field of an block with an instance name was marked row-major (but block itself was not),

Re: [Mesa-dev] [PATCH 1/2] radeon/llvm: enable unsafe math for graphics shaders

2014-07-21 Thread Grigori Goronzy
On 17.07.2014 21:24, Tom Stellard wrote: On Thu, Jul 17, 2014 at 06:44:25PM +0200, Grigori Goronzy wrote: Accuracy of some operations was recently improved in the R600 backend, at the cost of slower code. This is required for compute shaders, but not for graphics shaders. Add unsafe-fp-math

Re: [Mesa-dev] [PATCH 0/7] Fix handling of 8-bits-per-channel SRGB and SNORM formats

2014-07-21 Thread Marek Olšák
Hi Richard, For anything that changes the shared core code in src/gallium, the commit message prefix should be gallium:. You can also use gallium/util: if you just change auxiliary/util. For anything that changes src/mesa/state_tracker, the prefix should be st/mesa:. For anything that changes

Re: [Mesa-dev] [PATCH 03/16] glsl: Use constant_expression_value instead of as_constant

2014-07-21 Thread Matt Turner
On Mon, Jul 21, 2014 at 2:04 PM, Ian Romanick i...@freedesktop.org wrote: From: Ian Romanick ian.d.roman...@intel.com Just a few lines earlier we may have wrapped the index expression with ir_unop_i2u expression. Whenever that happens, as_constant will return NULL, and that almost always

Re: [Mesa-dev] [PATCH 00/16] Many UBO fixes

2014-07-21 Thread Matt Turner
On Mon, Jul 21, 2014 at 2:04 PM, Ian Romanick i...@freedesktop.org wrote: Around the time OpenGL ES 3.1 was released, Khronos made some significant updates to the OpenGL ES 3.0 conformance suite. These updates uncovered a number of bugs in our implementation of UBOs. This patch series fixes

Re: [Mesa-dev] [PATCH 11/16] glsl: Track matrix layout of structure fields using two bits

2014-07-21 Thread Matt Turner
On Mon, Jul 21, 2014 at 3:17 PM, Matt Turner matts...@gmail.com wrote: On Mon, Jul 21, 2014 at 2:04 PM, Ian Romanick i...@freedesktop.org wrote: +enum glsl_matrix_layout { + GLSL_MATRIX_LAYOUT_DEFAULT, Does this mean language-default, or does it really means the inherited layout? E.g., for

Re: [Mesa-dev] [PATCH] mesa: Don't use memcpy() in _mesa_texstore() for depth texture data

2014-07-21 Thread Anuj Phogat
On Mon, Jul 21, 2014 at 3:27 PM, Marek Olšák mar...@gmail.com wrote: On Tue, Jul 22, 2014 at 12:09 AM, Anuj Phogat anuj.pho...@gmail.com wrote: On Fri, Jul 18, 2014 at 5:54 PM, Marek Olšák mar...@gmail.com wrote: Shouldn't the function return TRUE for floating-point depth textures only?

Re: [Mesa-dev] [PATCH] mesa: Don't use memcpy() in _mesa_texstore() for depth texture data

2014-07-21 Thread Marek Olšák
On Tue, Jul 22, 2014 at 12:50 AM, Anuj Phogat anuj.pho...@gmail.com wrote: On Mon, Jul 21, 2014 at 3:27 PM, Marek Olšák mar...@gmail.com wrote: On Tue, Jul 22, 2014 at 12:09 AM, Anuj Phogat anuj.pho...@gmail.com wrote: On Fri, Jul 18, 2014 at 5:54 PM, Marek Olšák mar...@gmail.com wrote:

[Mesa-dev] [PATCH] i965/fs: Set LastRT on the final FB write on Broadwell.

2014-07-21 Thread Kenneth Graunke
In Piglit's EXT_framebuffer_multisample/alpha-to-coverage-dual-src-blend test, key-nr_color_regions == 2, but the dual source blend FB write has ir-target set to 0. So we failed to set Last Render Target Select on any FB write message. We only emit one FB write per render target, so my comment

  1   2   >