[Mesa-dev] [Bug 82327] New: FAIL: glcpp/tests/glcpp-test-cr-lf

https://bugs.freedesktop.org/show_bug.cgi?id=82327 Priority: medium Bug ID: 82327 CC: cwo...@cworth.org, i...@freedesktop.org Assignee: mesa-dev@lists.freedesktop.org Summary: FAIL: glcpp/tests/glcpp-test-cr-lf Severity: normal

[Mesa-dev] [PATCH 0/3] clover: some fixes for compat

Hello Please find some fixes regarding compat class EdB (3): clover: fix _logs string creation clover: stdify compat::vector a little more clover: unsure compat::string is \0 terminated src/gallium/state_trackers/clover/core/module.cpp | 2 +- src/gallium/state_trackers/clover/core/pro

[Mesa-dev] [PATCH 1/3] clover: fix _logs string creation

compact::string is not \0 terminated. size() need to be used for std::string creation --- src/gallium/state_trackers/clover/core/program.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/state_trackers/clover/core/program.cpp b/src/gallium/state_trackers/clov

[Mesa-dev] [PATCH 3/3] clover: unsure compat::string is \0 terminated

otherwise c_str() is not safe --- src/gallium/state_trackers/clover/util/compat.hpp | 54 --- 1 file changed, 48 insertions(+), 6 deletions(-) diff --git a/src/gallium/state_trackers/clover/util/compat.hpp b/src/gallium/state_trackers/clover/util/compat.hpp index 6f0f7cc..7ca

[Mesa-dev] [PATCH 2/3] clover: stdify compat::vector a little more

make resize work like std::vector reserve take advantage of capacity rename members to be uniform with other class --- src/gallium/state_trackers/clover/core/module.cpp | 2 +- src/gallium/state_trackers/clover/util/compat.hpp | 113 +++--- 2 files changed, 78 insertions(+), 37 d

Re: [Mesa-dev] [PATCH] st/mesa: fix DrawPixels(GL_STENCIL_INDEX)

On 08.08.2014 05:44, Marek Olšák wrote: > From: Marek Olšák > > This is a bug which was probably uncovered recently by Jason's commits > and broke this. > > The problem is _mesa_base_tex_format(GL_STENCIL_INDEX) returns -1. Tested-by: Michel Dänzer -- Earthling Michel Dänzer|

Re: [Mesa-dev] [PATCH] radeonsi: fix CMASK and HTILE allocation on Tahiti

On 08.08.2014 05:44, Marek Olšák wrote: > From: Marek Olšák > > Tahiti has 12 tile pipes, but P8 pipe config. > > It looks like there is no way to get the pipe config except for reading > GB_TILE_MODE. The TILING_CONFIG ioctl doesn't return more than 8 pipes, > so we can't use that for Hawaii. >

Re: [Mesa-dev] Is the r600 llvm backend supposed to behave exactly the same as the radeonsi llvm?

On Fri, Aug 08, 2014 at 04:53:46AM +0300, Kertesz Laszlo wrote: > Is the r600 llvm backend supposed to behave exactly the same as the > radeonsi llvm? > Support for r600 in LLVM is experimental, but for radeonsi it should work well. -Tom > > -- > O zi buna, > > Kertesz Laszlo > _

[Mesa-dev] Is the r600 llvm backend supposed to behave exactly the same as the radeonsi llvm?

Is the r600 llvm backend supposed to behave exactly the same as the radeonsi llvm? -- O zi buna, Kertesz Laszlo ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] Mesa build fails after commit "gallivm: Fix build with latest LLVM"

On 08.08.2014 10:22, Kertesz Laszlo wrote: > Today i observer that building mesa fails with > > gallivm/lp_bld_debug.cpp: In function 'size_t disassemble(const void*, > llvm::raw_ostream&)': > gallivm/lp_bld_debug.cpp:279:57: error: 'class > llvm::TargetSubtargetInfo' has no member named 'getInstr

[Mesa-dev] [PATCH 1/3] nvc0/ir: add base tex offset for fermi indirect tex case

Signed-off-by: Ilia Mirkin --- .../drivers/nouveau/codegen/nv50_ir_lowering_nvc0.cpp| 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nvc0.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nvc0.

[Mesa-dev] [PATCH 3/3] nvc0/ir: describe the tex arguments for fermi/kepler

Signed-off-by: Ilia Mirkin --- .../nouveau/codegen/nv50_ir_lowering_nvc0.cpp | 25 ++ 1 file changed, 25 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nvc0.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nvc0.cpp index ade315

[Mesa-dev] [PATCH 2/3] nvc0/ir: add kepler+ support for indirect texture references

Signed-off-by: Ilia Mirkin --- .../nouveau/codegen/nv50_ir_lowering_nvc0.cpp | 34 +- 1 file changed, 27 insertions(+), 7 deletions(-) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nvc0.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nvc0.

[Mesa-dev] Mesa build fails after commit "gallivm: Fix build with latest LLVM"

Today i observer that building mesa fails with gallivm/lp_bld_debug.cpp: In function 'size_t disassemble(const void*, llvm::raw_ostream&)': gallivm/lp_bld_debug.cpp:279:57: error: 'class llvm::TargetSubtargetInfo' has no member named 'getInstrInfo' const TargetInstrInfo *TII = TM->getSubtarget

Re: [Mesa-dev] [PATCH] st/mesa: fix blit-based partial TexSubImage for 1D arrays

Ah right. That's why it didn't matter then :-) Roland Am 08.08.2014 02:30, schrieb Marek Olšák: > Hi Roland, > > This code isn't used by llvmpipe, because it returns > PIPE_CAP_PREFER_BLIT_BASED_TEXTURE_TRANSFER = 0. > > Marek > > On Fri, Aug 8, 2014 at 1:33 AM, Roland Scheidegger wrote: >> L

Re: [Mesa-dev] [PATCH] st/mesa: fix blit-based partial TexSubImage for 1D arrays

Hi Roland, This code isn't used by llvmpipe, because it returns PIPE_CAP_PREFER_BLIT_BASED_TEXTURE_TRANSFER = 0. Marek On Fri, Aug 8, 2014 at 1:33 AM, Roland Scheidegger wrote: > Looks good to me too. I guess on llvmpipe we got lucky because > row_stride and layer_stride were equal so the math

[Mesa-dev] [PATCH 4/5] i965: Add support for ARB_copy_image

This, together with the meta path, provides a almost-complete implemetation of ARB_copy_image. The only case that won't work is if one of the textures is compressed and has a pitch greater than INT16_MAX. I think that's good enough to justify turning on the extension. v2: Add a fallback memcpy p

[Mesa-dev] [PATCH 5/5] docs/GL3: Mark ARB_copy_image as implemented on i965

--- docs/GL3.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index e241257..32c530c 100644 --- a/docs/GL3.txt +++ b/docs/GL3.txt @@ -158,7 +158,7 @@ GL 4.3: GL_ARB_ES3_compatibility DONE (i965) GL_ARB_clear_buffe

Re: [Mesa-dev] [PATCH 2/9] i915: Fix GL_DOT3_RGBA a bit

I double checked with the existing code and the extension spec. I believe this change is correct. If GL_DOT3_RGBA is used, the alpha mode is ignored. Reviewed-by: Ian Romanick On 08/06/2014 11:56 AM, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > The spec says using DOT4 for

Re: [Mesa-dev] [PATCH] st/mesa: fix blit-based partial TexSubImage for 1D arrays

Looks good to me too. I guess on llvmpipe we got lucky because row_stride and layer_stride were equal so the math worked out the same in the end :-). Reviewed-by: Roland Scheidegger Am 08.08.2014 01:18, schrieb Ilia Mirkin: > Reviewed-by: Ilia Mirkin > > Makes sense and also fixes the new pigl

Re: [Mesa-dev] [PATCH] exec_list: add a list_foreach_typed_reverse() macro

Reviewed-by: Ian Romanick But you should wait to push it until you push a patch that uses it... otherwise some may send a patch to remove the unused macro. :) On 07/30/2014 03:52 PM, Connor Abbott wrote: > Signed-off-by: Connor Abbott > --- > src/glsl/list.h | 6 ++ > 1 file changed, 6 ins

Re: [Mesa-dev] [PATCH] st/mesa: fix blit-based partial TexSubImage for 1D arrays

Reviewed-by: Ilia Mirkin Makes sense and also fixes the new piglit on nvc0. On Thu, Aug 7, 2014 at 6:49 PM, Marek Olšák wrote: > From: Marek Olšák > > This fixes piglit spec/EXT_texture_array/render-1darray. > > Cc: mesa-sta...@lists.freedesktop.org > --- > src/mesa/state_tracker/st_cb_textur

[Mesa-dev] [PATCH] st/mesa: fix blit-based partial TexSubImage for 1D arrays

From: Marek Olšák This fixes piglit spec/EXT_texture_array/render-1darray. Cc: mesa-sta...@lists.freedesktop.org --- src/mesa/state_tracker/st_cb_texture.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/state_tracker/st_cb_texture.c b/src/mesa/state_tracker/st_cb_texture.c inde

Re: [Mesa-dev] [PATCH 1/4] gallium: add basic support for BPTC formats

The software fallback for GenerateMipmap is entirely done in mesa/main, so you don't have to worry about it. Marek On Fri, Aug 8, 2014 at 12:34 AM, Ilia Mirkin wrote: > Thanks, will do. I'm also a little concerned that my claims of the > pack/unpack functions not being used are false... I'll nee

Re: [Mesa-dev] [PATCH] glsl: Remove unused initialized field from gl_uniform_storage.

On 08/07/2014 10:36 AM, Matt Turner wrote: > --- > Should this have been used somewhere? It seems like it was used at one point... did you try any git archaeology? > src/glsl/ir_uniform.h | 5 - > src/glsl/link_uniform_initializers.cpp | 4 > src/glsl/link_uniforms.cpp

Re: [Mesa-dev] [PATCH 1/4] gallium: add basic support for BPTC formats

Thanks, will do. I'm also a little concerned that my claims of the pack/unpack functions not being used are false... I'll need to test whether e.g. the generate-mipmap stuff doesn't hit it. I don't think the piglits were ready before, but now they hopefully are. (I should probably also rebase on th

Re: [Mesa-dev] [PATCH] RFC: glsl/glcpp: Allow for '#' characters to appear in shader body

Erik Faye-Lund writes: > On Tue, Aug 5, 2014 at 11:22 PM, Carl Worth wrote: > >> Now, what we could do if we were so inclined, would be to defer the >> errors for illegal characters until they actually appeared in the >> pre-processor output. > > What you describe here seems to actually be what t

Re: [Mesa-dev] [PATCH 3/4] mesa/st: add BPTC formats, expose ARB_texture_compression_bptc

On Fri, Aug 8, 2014 at 12:27 AM, Ilia Mirkin wrote: > Yeah, I noticed those later on. The latest patch is at > > https://github.com/imirkin/mesa/commit/1a2f6dc41dae3df8d332ce4675e072ee0d9f37c7 > > Or did you have something else in mind? No. It looks great. Reviewed-by: Marek Olšák Marek __

Re: [Mesa-dev] [PATCH 3/4] mesa/st: add BPTC formats, expose ARB_texture_compression_bptc

Yeah, I noticed those later on. The latest patch is at https://github.com/imirkin/mesa/commit/1a2f6dc41dae3df8d332ce4675e072ee0d9f37c7 Or did you have something else in mind? On Thu, Aug 7, 2014 at 6:23 PM, Marek Olšák wrote: > See st_GetTexImage and search for BPTC. There is a TODO comment whi

Re: [Mesa-dev] [PATCH 3/4] mesa/st: add BPTC formats, expose ARB_texture_compression_bptc

See st_GetTexImage and search for BPTC. There is a TODO comment which says what to do. All formats except for SRGBA must be added there. Marek On Wed, Jul 23, 2014 at 3:11 AM, Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin > --- > > This trivially depends on Neil's patches which add the mesa/c

Re: [Mesa-dev] [PATCH 1/4] gallium: add basic support for BPTC formats

These functions should be updated too: util_format_srgb util_format_linear util_format_fits_8unorm Marek On Wed, Jul 23, 2014 at 3:11 AM, Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin > --- > > So... the pack/unpack functions just assert. As far as I can tell, these are > entirely unused unt

[Mesa-dev] [PATCH 7/6] glsl/glcpp: Add testing of illegal characters in macro replacement lists

The desired behavior here is that there is no error for an illegal character appearing in the replacement list of a macro definition. However, any expansion of such a macro, causing the illegal character to appear in the preprocessed source, should emit an error. These two tests exercise both of

[Mesa-dev] [PATCH 5/6 v2.] glsl/glcpp: Emit an error for any illegal GLSL character.

The GLSL Language Specification (version 4.30.6) is quite clear about the GLSL character set and the expected behavior for other characters: Section 3.1 Character Set The source character set used for the OpenGL shading languages, outside of comments, is a subset of UTF-8. It includes

Re: [Mesa-dev] [PATCH 11/11] glsl: Optimize X / X == 1

It also doesn't hold true for inf and nan inputs with ieee754 math (just like 0 should be all nan, and in particular making a 1.0 out of a nan that way sounds sort of broken). Earlier glsl versions though had pretty much undefined behavior for infs/nans. Newer versions have more clearly defined beh

Re: [Mesa-dev] [PATCH 11/11] glsl: Optimize X / X == 1

On Thu, Aug 7, 2014 at 2:13 PM, Patrick Baggett wrote: > Would this be conformant to GLSL spec if X had a runtime value of 0? Seems > unsafe to replace X / X with 1 without a runtime test...maybe GLSL spec > allows such optimizations. The GLSL spec says > Dividing by zero does not cause an excep

Re: [Mesa-dev] [PATCH 11/11] glsl: Optimize X / X == 1

Would this be conformant to GLSL spec if X had a runtime value of 0? Seems unsafe to replace X / X with 1 without a runtime test...maybe GLSL spec allows such optimizations. On Thu, Aug 7, 2014 at 3:51 PM, wrote: > From: Thomas Helland > > Shows no changes for shader-db. > > Signed-off-by: Tho

[Mesa-dev] [Bug 79472] [llvmpipe] [softpipe] SIGSEGV src/gallium/auxiliary/draw/draw_cliptest_tmp.h:91

https://bugs.freedesktop.org/show_bug.cgi?id=79472 Roland Scheidegger changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH 2/2] draw: hack around weird primitive id input in gs

On 08/07/2014 02:50 PM, srol...@vmware.com wrote: From: Roland Scheidegger The distinction between system values and ordinary inputs is not very obvious in gallium - further fueled by the fact that they use the same semantic names. Still, if there's any value which imho really is a system value

Re: [Mesa-dev] [PATCH 1/2] draw: fix prim id float cast for non-llvm path

On 08/07/2014 02:50 PM, srol...@vmware.com wrote: From: Roland Scheidegger These values are always uints, casting them to floats does no good. Fixes piglit glsl-1.50-geometry-primitive-id-restart tests for softpipe. --- src/gallium/auxiliary/draw/draw_gs.c | 12 1 file changed,

[Mesa-dev] [PATCH 11/11] glsl: Optimize X / X == 1

From: Thomas Helland Shows no changes for shader-db. Signed-off-by: Thomas Helland --- src/glsl/opt_algebraic.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/glsl/opt_algebraic.cpp b/src/glsl/opt_algebraic.cpp index 21bf332..a49752d 100644 --- a/src/glsl/opt_algebraic.cpp +++ b/s

[Mesa-dev] [PATCH 10/11] glsl: Optimize X + neg(X) == 0 and the other way around

From: Thomas Helland Since we lower A - B to A + neg(B) on some architectures lets add a optimization for this pattern. This yields some gains in a shader-db run with extra shaders added from Team Fortress 2 and Portal. helped: shaders/tf2/1684.shader_test fs16: 62 -> 60 (-3.23%) helpe

[Mesa-dev] [PATCH v3 09/11] glsl: Optimize logic operation A || (A && B)

From: Thomas Helland Let's cut the needless A && B here. v1 -> v2: Correct the comments, return A instead of A && B v2 -> v3: Rebase on top of this series Signed-off-by: Thomas Helland --- This was originally posted here: http://lists.freedesktop.org/archives/mesa-dev/2014-July/063129.html v2

[Mesa-dev] [PATCH v2 05/11] glsl: Optimize log(x) + log(y) == log(x*y)

From: Thomas Helland And the log2() equivalent. v1 -> v2: Correct trailing whitespace Signed-off-by: Thomas Helland Reviewed-by: Eric Anholt --- src/glsl/opt_algebraic.cpp | 12 1 file changed, 12 insertions(+) diff --git a/src/glsl/opt_algebraic.cpp b/src/glsl/opt_algebraic.cp

[Mesa-dev] [PATCH v2 08/11] glsl: Optimize A - neg(B) = A + B

From: Thomas Helland v1 -> v2: Drop the neg(A) - B == neg(A+B) part Signed-off-by: Thomas Helland --- src/glsl/opt_algebraic.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/glsl/opt_algebraic.cpp b/src/glsl/opt_algebraic.cpp index 0ecadbe..c673495 100644 --- a/src/glsl/opt_algeb

[Mesa-dev] [PATCH 06/11] glsl: Optimize exp(x) * exp(y) == exp(x*y)

From: Thomas Helland And it's exp2() equivalent. Signed-off-by: Thomas Helland Reviewed-by: Eric Anholt --- src/glsl/opt_algebraic.cpp | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/glsl/opt_algebraic.cpp b/src/glsl/opt_algebraic.cpp index 141b930..0e21ff8 100644 --- a/s

[Mesa-dev] [PATCH v2 04/11] glsl: Optimize (A || B) && A == A

From: Thomas Helland And it's cousins v1 -> v2: Correct indentation Correct returned operand from second if statement Signed-off-by: Thomas Helland Reviewed-by: Eric Anholt --- src/glsl/opt_algebraic.cpp | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/glsl/opt_a

[Mesa-dev] [PATCH v2 07/11] glsl: Optimize some more pow() special cases

From: Thomas Helland Specifically x^-1 = rcp(x) .0^x = 0 .x^0 = 1 v1 -> v2: Correct indentation Signed-off-by: Thomas Helland Reviewed-by: Eric Anholt --- src/glsl/opt_algebraic.cpp | 15 +++ 1 file changed, 15 insertions(+) diff --git a/src/glsl/opt_al

[Mesa-dev] [PATCH 03/11] glsl: Optimize !A && A == 0

From: Thomas Helland Signed-off-by: Thomas Helland Reviewed-by: Eric Anholt --- src/glsl/opt_algebraic.cpp | 8 1 file changed, 8 insertions(+) diff --git a/src/glsl/opt_algebraic.cpp b/src/glsl/opt_algebraic.cpp index 67326c5..cdabdb8 100644 --- a/src/glsl/opt_algebraic.cpp +++ b/sr

[Mesa-dev] [PATCH v2 02/11] glsl: Optimize !A || A == 1

From: Thomas Helland v1 -> v2: Correct indentation Signed-off-by: Thomas Helland Reviewed-by: Eric Anholt --- src/glsl/opt_algebraic.cpp | 12 1 file changed, 12 insertions(+) diff --git a/src/glsl/opt_algebraic.cpp b/src/glsl/opt_algebraic.cpp index c179d53..67326c5 100644 ---

[Mesa-dev] [PATCH v2 01/11] glsl: Optimize X - X == 0

From: Thomas Helland v1 -> v2: Corrected indentation. Signed-off-by: Thomas Helland Reviewed-by: Eric Anholt --- src/glsl/opt_algebraic.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/glsl/opt_algebraic.cpp b/src/glsl/opt_algebraic.cpp index ac7514a..c179d53 100644 --- a/src/gl

[Mesa-dev] [PATCH 00/11] glsl: Collection of algebraic optimizations

From: Thomas Helland Some of these patches have been posted to the list before. Eric showed interest in these being merged, so I addressed his points. Pathces 1 - 7 I've added Eric's R-B on. Patch 8 drops the part that people had doubt on. Patch 9 has been posted before, and seemed to be accept

[Mesa-dev] [PATCH 2/2] draw: hack around weird primitive id input in gs

From: Roland Scheidegger The distinction between system values and ordinary inputs is not very obvious in gallium - further fueled by the fact that they use the same semantic names. Still, if there's any value which imho really is a system value, it's the primitive id input into the gs (while ear

[Mesa-dev] [PATCH 1/2] draw: fix prim id float cast for non-llvm path

From: Roland Scheidegger These values are always uints, casting them to floats does no good. Fixes piglit glsl-1.50-geometry-primitive-id-restart tests for softpipe. --- src/gallium/auxiliary/draw/draw_gs.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/src/gall

[Mesa-dev] [PATCH] radeonsi: fix CMASK and HTILE allocation on Tahiti

From: Marek Olšák Tahiti has 12 tile pipes, but P8 pipe config. It looks like there is no way to get the pipe config except for reading GB_TILE_MODE. The TILING_CONFIG ioctl doesn't return more than 8 pipes, so we can't use that for Hawaii. This fixes a regression caused by 9b046474c95f15338d4c

[Mesa-dev] [PATCH] st/mesa: fix DrawPixels(GL_STENCIL_INDEX)

From: Marek Olšák This is a bug which was probably uncovered recently by Jason's commits and broke this. The problem is _mesa_base_tex_format(GL_STENCIL_INDEX) returns -1. --- src/mesa/state_tracker/st_cb_drawpixels.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git

Re: [Mesa-dev] Mesa (master): mesa/formats: Add layout and swizzle information

Am 07.08.2014 20:25, schrieb Jason Ekstrand: > Michel, > > On Thu, Aug 7, 2014 at 12:04 AM, Michel Dänzer > wrote: > > On 07.08.2014 02:02, Jason Ekstrand wrote: > > Michael, > > Close, but no cigar. :) > > > I'm sorry about that. I must have read too q

Re: [Mesa-dev] Mesa (master): mesa/formats: Add layout and swizzle information

I think I know where the problem is. I'll send a patch. Marek On Thu, Aug 7, 2014 at 8:38 PM, Jason Ekstrand wrote: > > > > On Wed, Aug 6, 2014 at 11:09 AM, Marek Olšák wrote: >> >> FYI, it seems to be DrawPixels(GL_STENCIL_INDEX) that is broken. We >> actually use S8 texturing for DrawPixels a

Re: [Mesa-dev] Mesa (master): mesa/formats: Add layout and swizzle information

On Wed, Aug 6, 2014 at 11:09 AM, Marek Olšák wrote: > FYI, it seems to be DrawPixels(GL_STENCIL_INDEX) that is broken. We > actually use S8 texturing for DrawPixels and some of the functions you > changed probably don't support S8 anymore. > Marek, Would you mind being a bit more specific? I do

Re: [Mesa-dev] [PATCH] glsl: Remove unused initialized field from gl_uniform_storage.

On Thu, Aug 7, 2014 at 11:08 AM, Anuj Phogat wrote: > On Thu, Aug 7, 2014 at 10:36 AM, Matt Turner wrote: >> --- >> Should this have been used somewhere? >> > src/mesa/state_tracker/st_draw.c uses this to generate a _mesa_warning(). Ah, okay. I didn't see that because I didn't build gallium. ___

Re: [Mesa-dev] Mesa (master): mesa/formats: Add layout and swizzle information

Michel, On Thu, Aug 7, 2014 at 12:04 AM, Michel Dänzer wrote: > On 07.08.2014 02:02, Jason Ekstrand wrote: > > Michael, > > Close, but no cigar. :) > I'm sorry about that. I must have read too quickly. :-/ > > > Could you please point me at the failing tests. > > spec/!OpenGL 1.1/depthstenci

Re: [Mesa-dev] [PATCH v2 3/9] i915: Use L8A8 instead of I8 to simulate A8 on gen2

ville.syrj...@linux.intel.com writes: > From: Ville Syrjälä > > Gen2 doesn't support the A8 texture format. Currently the driver > substitutes it with I8, but that results in incorrect RGB values. > Use A8L8 instead. We end up wasting a bit of memory, but at least > we should get the correct resu

Re: [Mesa-dev] [PATCH] docs: List GL+GLSL versions as parts of a whole.

On Thu, Aug 7, 2014 at 10:35 AM, Matt Turner wrote: > Listing the GLSL version as an individual component of a GL version, > separate from the extensions isn't really right. The GLSL changes are > (almost?) entirely comprised of changes listed in the extensions. > --- > docs/GL3.txt | 27

Re: [Mesa-dev] [PATCH] i965/vec4: Remove unused emit_bool_comparison method.

On Thu, Aug 7, 2014 at 10:35 AM, Matt Turner wrote: > Apparently unused since it was added in commit af3c9803. > --- > src/mesa/drivers/dri/i965/brw_vec4.h | 1 - > src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 14 -- > 2 files changed, 15 deletions(-) > > diff --git a/s

Re: [Mesa-dev] [PATCH] glsl: Remove unused initialized field from gl_uniform_storage.

On Thu, Aug 7, 2014 at 10:36 AM, Matt Turner wrote: > --- > Should this have been used somewhere? > src/mesa/state_tracker/st_draw.c uses this to generate a _mesa_warning(). > src/glsl/ir_uniform.h | 5 - > src/glsl/link_uniform_initializers.cpp | 4 > src/glsl/link_uni

Re: [Mesa-dev] [PATCH] docs: List GL+GLSL versions as parts of a whole.

Reviewed-by: Marek Olšák Marek On Thu, Aug 7, 2014 at 7:35 PM, Matt Turner wrote: > Listing the GLSL version as an individual component of a GL version, > separate from the extensions isn't really right. The GLSL changes are > (almost?) entirely comprised of changes listed in the extensions. >

[Mesa-dev] [PATCH] glsl: Remove unused initialized field from gl_uniform_storage.

--- Should this have been used somewhere? src/glsl/ir_uniform.h | 5 - src/glsl/link_uniform_initializers.cpp | 4 src/glsl/link_uniforms.cpp | 1 - src/mesa/main/uniform_query.cpp| 4 4 files changed, 14 deletions(-) diff --git a/src/glsl/ir_un

[Mesa-dev] [PATCH] i965/vec4: Remove unused emit_bool_comparison method.

Apparently unused since it was added in commit af3c9803. --- src/mesa/drivers/dri/i965/brw_vec4.h | 1 - src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 14 -- 2 files changed, 15 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4.h b/src/mesa/drivers/dri/i965/b

[Mesa-dev] [PATCH] docs: List GL+GLSL versions as parts of a whole.

Listing the GLSL version as an individual component of a GL version, separate from the extensions isn't really right. The GLSL changes are (almost?) entirely comprised of changes listed in the extensions. --- docs/GL3.txt | 27 +-- 1 file changed, 9 insertions(+), 18 deleti

Re: [Mesa-dev] [PATCH] winsys/radeon: use zero sized buffers for fences if the kernel supports it

On Thu, Aug 7, 2014 at 4:31 PM, Christian König wrote: > From: Christian König > > Signed-off-by: Christian König > --- > src/gallium/auxiliary/pipebuffer/pb_buffer.h | 2 +- > src/gallium/winsys/radeon/drm/radeon_drm_bo.c | 2 +- > src/gallium/winsys/radeon/drm/radeon_drm_cs.c | 3 ++- > 3 fi

Re: [Mesa-dev] [PATCH] util: add src/util/format_srgb.c to .gitignore

Reviewed-by: Marek Olšák Marek On Thu, Aug 7, 2014 at 2:58 PM, Juha-Pekka Heikkila wrote: > format_srgb.c is generated by format_srgb.py python script, having > format_srgb.c in git ignore list will silence git complaints about > untracked file. > > Signed-off-by: Juha-Pekka Heikkila > --- >

Re: [Mesa-dev] [PATCH 0/3] cl workdim v2

On Thu, Aug 07, 2014 at 04:02:40PM +0300, Francisco Jerez wrote: > Jan Vesely writes: > > > This respin includes Francisco's approach of providing implicit > > in the arg vector passed from clover, and Tom's idea of appending > > implicit args after the kernel args. > > > > Hmmm... Maybe it wou

Re: [Mesa-dev] [PATCH 14/20] i965/fs: Preserve CFG in register allocation.

On Thu, Jul 24, 2014 at 07:54:21PM -0700, Matt Turner wrote: > --- > src/mesa/drivers/dri/i965/brw_fs.h| 4 ++-- > src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp | 20 > 2 files changed, 14 insertions(+), 10 deletions(-) Reviewed-by: Topi Pohjolainen

Re: [Mesa-dev] [PATCH] mesa: Drop USE_IEEE define.

On Thu, Aug 7, 2014 at 5:35 AM, Brian Paul wrote: > On 08/06/2014 05:54 PM, Matt Turner wrote: >> >> I think OpenVMS was the only platform that Mesa ran on that used a >> non-IEEE representation for floats. We removed OpenVMS support a while >> back, and this should alleviate the need to continue

Re: [Mesa-dev] [PATCH 12/20] i965: Add invalidate_cfg parameter to invalidate_live_intervals().

On Thu, Jul 24, 2014 at 07:54:19PM -0700, Matt Turner wrote: > Will let us avoid invalidating the CFG if the optimization pass has > removed instructions using the new basic block methods. > --- > src/mesa/drivers/dri/i965/brw_fs.h| 2 +- > src/mesa/drivers/dri/i965/brw_fs_live

Re: [Mesa-dev] [PATCH 13/20] i965: Use basic-block aware insertion/removal functions.

On Thu, Jul 24, 2014 at 07:54:20PM -0700, Matt Turner wrote: > To avoid invalidating and recreating the control flow graph. Also stop > invalidating the CFG in places we didn't add or remove an instruction. > > cfg calculations: 202951 -> 80307 (-60.43%) > --- > src/mesa/drivers/dri/i965/brw_

Re: [Mesa-dev] [PATCH] RFC: glsl/glcpp: Allow for '#' characters to appear in shader body

On Tue, Aug 5, 2014 at 11:22 PM, Carl Worth wrote: > Kenneth Graunke writes: >> I agree that this is pretty bogus. > > I'm coming around to thinking it's totally bogus. > >> How about emitting a warning in the RETURN_TOKEN ('#') case? > > Thanks for the review, and thanks for suggesting the warni

[Mesa-dev] [PATCH v2] clover: Add support for CL_MAP_WRITE_INVALIDATE_REGION

OpenCL 1.2 CL_MAP_WRITE_INVALIDATE_REGION sounds a lot like PIPE_TRANSFER_DISCARD_RANGE: >From OpenCL 1.2 spec: The contents of the region being mapped are to be discarded. >From p_defines.h: Discards the memory within the mapped region. v2: Move the code for validating flags to the fron

Re: [Mesa-dev] [PATCH 0/6] Add support for BPTC texture compression

Am 07.08.2014 14:30, schrieb Neil Roberts: > Kristian Høgsberg writes: > >> That's a great reference image. Do you have a version of the image >> compressed with nVidias online compressor? > > I finally got access to an NVidia card last night so I've added an image > from their online compresso

[Mesa-dev] [PATCH] winsys/radeon: use zero sized buffers for fences if the kernel supports it

From: Christian König Signed-off-by: Christian König --- src/gallium/auxiliary/pipebuffer/pb_buffer.h | 2 +- src/gallium/winsys/radeon/drm/radeon_drm_bo.c | 2 +- src/gallium/winsys/radeon/drm/radeon_drm_cs.c | 3 ++- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/gallium/

Re: [Mesa-dev] [PATCH] clover: Add support for CL_MAP_WRITE_INVALIDATE_REGION

On Thu, 2014-08-07 at 14:57 +0300, Francisco Jerez wrote: > Bruno Jiménez writes: > > > OpenCL 1.2 CL_MAP_WRITE_INVALIDATE_REGION sounds a lot like > > PIPE_TRANSFER_DISCARD_RANGE: > > > > From OpenCL 1.2 spec: > > The contents of the region being mapped are to be discarded. > > > > From p_de

Re: [Mesa-dev] [PATCH 1/6] r600g: remove useless r600_resource_va calls

On Wed, Aug 6, 2014 at 5:49 PM, Marek Olšák wrote: > From: Marek Olšák > > R600-R700 don't support virtual memory. For consistency, it might be nice to use gpu_address here as well, but just set it to 0 for 6xx/7xx. Either way, series is: Reviewed-by: Alex Deucher > --- > src/gallium/drivers

Re: [Mesa-dev] [PATCH 0/3] cl workdim v2

Jan Vesely writes: > This respin includes Francisco's approach of providing implicit > in the arg vector passed from clover, and Tom's idea of appending > implicit args after the kernel args. > Hmmm... Maybe it would make sense to add some sort of versioning (e.g. as part of the target triple)

[Mesa-dev] [PATCH] util: add src/util/format_srgb.c to .gitignore

format_srgb.c is generated by format_srgb.py python script, having format_srgb.c in git ignore list will silence git complaints about untracked file. Signed-off-by: Juha-Pekka Heikkila --- src/util/.gitignore | 1 + 1 file changed, 1 insertion(+) create mode 100644 src/util/.gitignore diff --g

Re: [Mesa-dev] [PATCH] mesa: Drop USE_IEEE define.

On 08/06/2014 05:54 PM, Matt Turner wrote: I think OpenVMS was the only platform that Mesa ran on that used a non-IEEE representation for floats. We removed OpenVMS support a while back, and this should alleviate the need to continue updating the this-platform-uses-IEEE list. The one bit of this

Re: [Mesa-dev] [PATCH 0/6] Add support for BPTC texture compression

Kristian Høgsberg writes: > That's a great reference image. Do you have a version of the image > compressed with nVidias online compressor? I finally got access to an NVidia card last night so I've added an image from their online compressor to the bottom of that page. http://busydoingnothing.

Re: [Mesa-dev] [PATCH 04/12] mesa/format_info: Add support for the BPTC layout

Jason Ekstrand writes: > Sorry, said that just a little early. Do we really want 4 bits for a > floating-point format? How many bits does nvidia report? NVidia reports the RGB components as 8/8/8 for the two normalized formats and 32/32/32 for the two half-float formats. I think the 8 makes so

Re: [Mesa-dev] [PATCH v2 0/12] Add support for BPTC texture compression

Chris Forbes writes: > Does this actually work on all Gen7? > > The IVB PRM Vol 4 Part 1 Page 83 says: > >Errata: BC6H_SF16, BC6H_UF16, and BC7_SRGB are not supported and > may result in data corruption if used. I'm pretty sure this is referring to pre-production hardware and unfortunately t

Re: [Mesa-dev] [PATCH] clover: Add support for CL_MAP_WRITE_INVALIDATE_REGION

Bruno Jiménez writes: > OpenCL 1.2 CL_MAP_WRITE_INVALIDATE_REGION sounds a lot like > PIPE_TRANSFER_DISCARD_RANGE: > > From OpenCL 1.2 spec: > The contents of the region being mapped are to be discarded. > > From p_defines.h: > Discards the memory within the mapped region. > --- > src/ga

Re: [Mesa-dev] [PATCH 05/20] i965/cfg: Add a foreach_inst_in_block_safe macro.

On Wed, Aug 06, 2014 at 11:16:20AM -0700, Matt Turner wrote: > On Wed, Aug 6, 2014 at 5:22 AM, Pohjolainen, Topi > wrote: > > On Tue, Aug 05, 2014 at 09:14:55PM +0300, Pohjolainen, Topi wrote: > >> On Thu, Jul 24, 2014 at 07:54:12PM -0700, Matt Turner wrote: > >> > --- > >> > src/mesa/drivers/dri

[Mesa-dev] [PATCH] clover: Add support for CL_MAP_WRITE_INVALIDATE_REGION

OpenCL 1.2 CL_MAP_WRITE_INVALIDATE_REGION sounds a lot like PIPE_TRANSFER_DISCARD_RANGE: >From OpenCL 1.2 spec: The contents of the region being mapped are to be discarded. >From p_defines.h: Discards the memory within the mapped region. --- src/gallium/state_trackers/clover/core/resourc

Re: [Mesa-dev] [PATCH 08/20] i965/cfg: Add functions to test if a block is a successor/predecessor.

On Wed, Aug 06, 2014 at 03:03:55PM -0700, Matt Turner wrote: > On Wed, Aug 6, 2014 at 11:19 AM, Matt Turner wrote: > > On Tue, Aug 5, 2014 at 10:21 AM, Pohjolainen, Topi > > wrote: > >> On Thu, Jul 24, 2014 at 07:54:15PM -0700, Matt Turner wrote: > >>> --- > >>> src/mesa/drivers/dri/i965/brw_cfg

[Mesa-dev] [PATCH] r600g/compute: Add information about how compute_memory_pool works

--- NOTE: if the two patches I have just send for tracking how buffers are mapped are good, we may drop the last item from the TODO list. src/gallium/drivers/r600/compute_memory_pool.c | 47 ++ 1 file changed, 47 insertions(+) diff --git a/src/gallium/drivers/r600/com

Re: [Mesa-dev] [PATCH] r600g/radeon: Don't try to allocate CMASK BO of size 0

I would rather like to find the core problem. r600_num_tile_pipes might be 0 for some reason. This recent commit could cause the issue: http://cgit.freedesktop.org/mesa/mesa/commit/?id=9b046474c95f15338d4c748df9b62871bba6f36f Marek On Thu, Aug 7, 2014 at 7:46 AM, Michel Dänzer wrote: > From:

[Mesa-dev] [PATCH 2/2] r600g/compute: Decrement map_count when unmapping items

This patch adds a new struct: r600_transfer_global. It will act as a wrapper around an r600_resource_global and an r600_transfer. It will be used for calling r600_compute_global_transfer_unmap when transfer_unmap is called. And at the same time, keep all the transfer information, so we can call r6

[Mesa-dev] [PATCH 0/2] [RFC] r600g/compute: Track better how items are mapped

Hi, This series adds support for actually knowing when an item is not mapped. Previously, when an item was marked as 'MAPPED_FOR_READING' we couldn't really remove that status because although we controlled how items were mapped, we didn't control how they were unmapped. Patch 1 modifies how item

[Mesa-dev] [PATCH 1/2] r600g/compute: Add a member to the items to track how many maps it has

This will be necessary to know how many mappings for read it has, as the spec allows to have as many as desired. --- src/gallium/drivers/r600/compute_memory_pool.c | 5 +++-- src/gallium/drivers/r600/compute_memory_pool.h | 1 + src/gallium/drivers/r600/evergreen_compute.c | 3 +-- 3 files chang

[Mesa-dev] [PATCH] r600g/compute: Fix Warnings

I have followed the following convention: - Positions in the pool are now 'int' (start_in_dw and related) - Sizes are 'unsigned' (size_in_dw and related) - IDs are 'unsigned' The pool and item's status are left as uint32_t The shadow has been also left as a pointer to an uint32_t --- src/gallium/

[Mesa-dev] [PATCH v2 3/9] i915: Use L8A8 instead of I8 to simulate A8 on gen2

From: Ville Syrjälä Gen2 doesn't support the A8 texture format. Currently the driver substitutes it with I8, but that results in incorrect RGB values. Use A8L8 instead. We end up wasting a bit of memory, but at least we should get the correct results. v2: Handle the fallback in _mesa_choose_tex_

Re: [Mesa-dev] [PATCH 8/9] i915: Don't call _mesa_meta_glsl_Clear() on gen2

On Wed, Aug 06, 2014 at 01:44:45PM -0700, Eric Anholt wrote: > ville.syrj...@linux.intel.com writes: > > > From: Ville Syrjälä > > > > Gen2 doesn't have fragmnts shaders so we shouldn't be calling > > spelling^ Fixed locally. > > Other than that, patches 4-9 are: > > Reviewed-by:

[Mesa-dev] [Bug 82253] JanusVR Browser rendering misses floors on radeonsi, works on intel

https://bugs.freedesktop.org/show_bug.cgi?id=82253 --- Comment #5 from Christoph Haag --- (In reply to comment #4) > Could be an issue in st/mesa or other driver-independent Gallium code then. > > Does glretrace also report a few OpenGL API errors like these on intel? > > 5946: message: major a

  1   2   >