Re: [Mesa-dev] [PATCH] glsl: Fix memory leak in glsl_lexer.ll

2014-09-04 Thread Aras Pranckevicius
--- a/src/glsl/glsl_lexer.ll +++ b/src/glsl/glsl_lexer.ll @@ -232,7 +232,8 @@ HASH^{SPC}#{SPC} PP[ \t\r]* { } PP: return COLON; PP[_a-zA-Z][_a-zA-Z0-9]* { - yylval-identifier =

Re: [Mesa-dev] [PATCH 01/37] i965/gs: Use single dispatch mode as fallback to dual object mode when possible.

2014-09-04 Thread Iago Toral Quiroga
On mié, 2014-09-03 at 17:49 -0700, Jordan Justen wrote: On Thu, Aug 14, 2014 at 4:11 AM, Iago Toral Quiroga ito...@igalia.com wrote: Currently, when a geometry shader can't use dual object mode we fall back to dual instance mode, however, when invocations == 1, single dispatch mode is more

Re: [Mesa-dev] [PATCH 02/37] i965/gen6/gs: refactor gen6_gs_state

2014-09-04 Thread Iago Toral Quiroga
On mié, 2014-09-03 at 18:51 -0700, Jordan Justen wrote: Rather than: i965/gen6/gs: refactor gen6_gs_state How about something like: i965/gen6/gs: Skeleton for user GS program support Sure, that sounds good to me. (more below) On Thu, Aug 14, 2014 at 4:11 AM, Iago Toral Quiroga

Re: [Mesa-dev] [PATCH 01/37] i965/gs: Use single dispatch mode as fallback to dual object mode when possible.

2014-09-04 Thread Jordan Justen
On Wed, Sep 3, 2014 at 11:28 PM, Iago Toral Quiroga ito...@igalia.com wrote: On mié, 2014-09-03 at 17:49 -0700, Jordan Justen wrote: On Thu, Aug 14, 2014 at 4:11 AM, Iago Toral Quiroga ito...@igalia.com wrote: Currently, when a geometry shader can't use dual object mode we fall back to

[Mesa-dev] [PATCH 3/3] i965: Handle ir_binop_ubo_load in boolean expression code.

2014-09-04 Thread Kenneth Graunke
UBO loads can be boolean-valued expressions, too, so we need to handle them in emit_bool_to_cond_code() and emit_if_gen6(). However, unlike most expressions, it doesn't make sense to evaluate their operands, then do something with the results. We just want to evaluate the UBO load as a

[Mesa-dev] [PATCH 2/3] i965/fs: Make emit_if_gen6 never fall back to emit_bool_to_cond_code.

2014-09-04 Thread Kenneth Graunke
Matt and I believe that Sandybridge actually uses 0x for a true comparison result, similar to Ivybridge. This matches the internal documentation, and empirical results, but contradicts the PRM. So, the comment is inaccurate, and we can actually just handle these directly without ever

[Mesa-dev] [PATCH 1/3] i965: Handle ir_triop_csel in emit_if_gen6().

2014-09-04 Thread Kenneth Graunke
ir_triop_csel can return a boolean expression, so we need to handle it here; we simply forgot when we added ir_triop_csel, and forgot again when adding it to emit_bool_to_cond_code. Fixes Piglit's EXT_shader_integer_mix/{vs,fs}-mix-if-bool on Sandybridge. Signed-off-by: Kenneth Graunke

Re: [Mesa-dev] [PATCH 01/37] i965/gs: Use single dispatch mode as fallback to dual object mode when possible.

2014-09-04 Thread Iago Toral Quiroga
On jue, 2014-09-04 at 00:07 -0700, Jordan Justen wrote: On Wed, Sep 3, 2014 at 11:28 PM, Iago Toral Quiroga ito...@igalia.com wrote: On mié, 2014-09-03 at 17:49 -0700, Jordan Justen wrote: On Thu, Aug 14, 2014 at 4:11 AM, Iago Toral Quiroga ito...@igalia.com wrote: Currently, when a

[Mesa-dev] [PATCH] i965: Mark cfg dumping functions const.

2014-09-04 Thread Kenneth Graunke
The dump() methods don't alter the CFG or basic blocks, so we should mark them as const. This lets you call them even if you have a const cfg_t - which is the case in certain portions of the code (such as live interval handling). Signed-off-by: Kenneth Graunke kenn...@whitecape.org ---

[Mesa-dev] [PATCH] i965/fs: Pass block to insert and remove functions missed earlier.

2014-09-04 Thread Kenneth Graunke
From: Matt Turner matts...@gmail.com Otherwise, the basic block start/end IPs don't get updated properly, leading to a broken CFG. This usually results in the following assertion failure: brw_fs_live_variables.cpp:141: void brw::fs_live_variables::setup_def_use(): Assertion `ip ==

Re: [Mesa-dev] [PATCH 02/37] i965/gen6/gs: refactor gen6_gs_state

2014-09-04 Thread Jordan Justen
On Wed, Sep 3, 2014 at 11:33 PM, Iago Toral Quiroga ito...@igalia.com wrote: On mié, 2014-09-03 at 18:51 -0700, Jordan Justen wrote: Rather than: i965/gen6/gs: refactor gen6_gs_state How about something like: i965/gen6/gs: Skeleton for user GS program support Sure, that sounds good to me.

Re: [Mesa-dev] [PATCH] r600g, radeonsi: make sure there's enough CS space before resuming queries

2014-09-04 Thread Michel Dänzer
On 04.09.2014 07:07, Marek Olšák wrote: From: Marek Olšák marek.ol...@amd.com Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=83432 Cc: mesa-sta...@lists.freedesktop.org If the fix should go to the 10.2 branch as well, that should be Cc: 10.2 10.3 mesa-sta...@lists.freedesktop.org

[Mesa-dev] [PATCH 1/3] i965: Handle ir_triop_csel in emit_if_gen6().

2014-09-04 Thread Kenneth Graunke
ir_triop_csel can return a boolean expression, so we need to handle it here; we simply forgot when we added ir_triop_csel, and forgot again when adding it to emit_bool_to_cond_code. Fixes Piglit's EXT_shader_integer_mix/{vs,fs}-mix-if-bool on Sandybridge. Signed-off-by: Kenneth Graunke

[Mesa-dev] [PATCH 2/3] i965/fs: Make emit_if_gen6 never fall back to emit_bool_to_cond_code.

2014-09-04 Thread Kenneth Graunke
Matt and I believe that Sandybridge actually uses 0x for a true comparison result, similar to Ivybridge. This matches the internal documentation, and empirical results, but contradicts the PRM. So, the comment is inaccurate, and we can actually just handle these directly without ever

[Mesa-dev] [PATCH 3/3] i965: Handle ir_binop_ubo_load in boolean expression code.

2014-09-04 Thread Kenneth Graunke
UBO loads can be boolean-valued expressions, too, so we need to handle them in emit_bool_to_cond_code() and emit_if_gen6(). However, unlike most expressions, it doesn't make sense to evaluate their operands, then do something with the results. We just want to evaluate the UBO load as a

Re: [Mesa-dev] [PATCH 01/37] i965/gs: Use single dispatch mode as fallback to dual object mode when possible.

2014-09-04 Thread Jordan Justen
On Thu, Sep 4, 2014 at 12:36 AM, Iago Toral Quiroga ito...@igalia.com wrote: On jue, 2014-09-04 at 00:07 -0700, Jordan Justen wrote: On Wed, Sep 3, 2014 at 11:28 PM, Iago Toral Quiroga ito...@igalia.com wrote: On mié, 2014-09-03 at 17:49 -0700, Jordan Justen wrote: On Thu, Aug 14, 2014 at

Re: [Mesa-dev] [PATCH 02/37] i965/gen6/gs: refactor gen6_gs_state

2014-09-04 Thread Iago Toral Quiroga
On jue, 2014-09-04 at 00:44 -0700, Jordan Justen wrote: On Wed, Sep 3, 2014 at 11:33 PM, Iago Toral Quiroga ito...@igalia.com wrote: On mié, 2014-09-03 at 18:51 -0700, Jordan Justen wrote: Rather than: i965/gen6/gs: refactor gen6_gs_state How about something like: i965/gen6/gs:

Re: [Mesa-dev] SandyBridge issue likely related to fast color clears using meta operations

2014-09-04 Thread Samuel Iglesias Gonsálvez
On Wed, 2014-09-03 at 15:00 -0700, Jordan Justen wrote: On 2014-09-03 10:41:02, Kenneth Graunke wrote: On Tuesday, September 02, 2014 06:16:01 PM Samuel Iglesias Gonsálvez wrote: Hello, Two weeks ago, Iago and myself sent a batch of patches that added geometry shader support for

[Mesa-dev] [Bug 83485] Requesting a New Account

2014-09-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83485 Samuel Iglesias sigles...@igalia.com changed: What|Removed |Added Assignee|sitewranglers@lists.freedes

Re: [Mesa-dev] [PATCH] configure.ac: Add AC_SYS_LARGEFILE

2014-09-04 Thread Emil Velikov
On 03/09/14 04:38, Michel Dänzer wrote: On 03.09.2014 06:50, Emil Velikov wrote: On 02/09/14 08:17, Michel Dänzer wrote: diff --git a/src/gallium/auxiliary/os/os_mman.h b/src/gallium/auxiliary/os/os_mman.h index b48eb053..19478d2 100644 --- a/src/gallium/auxiliary/os/os_mman.h +++

[Mesa-dev] [Bug 82882] [swrast] piglit glsl-fs-uniform-bool-1 regression

2014-09-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=82882 Pavel Ondračka pavel.ondra...@email.cz changed: What|Removed |Added CC|

[Mesa-dev] [PATCH] winsys/svga: Fix incorrect type usage in IOCTL

2014-09-04 Thread Thomas Hellstrom
While similar in layout, the size of the SVGA3dSize type may be smaller than the struct drm_vmw_size type that is part of the ioctl interface. The kernel driver could accordingly overwrite a memory area following the size variable on the stack. Typically that would be another local variable,

Re: [Mesa-dev] [PATCH 01/20] glapi: add ARB_gpu_shader_fp64 (v2)

2014-09-04 Thread Kai Wasserbäch
Hi Dave, just a small comment, since I'm not really the right person to review this patch: Dave Airlie schrieb am 04.09.2014 06:15: [...] diff --git a/src/mesa/main/tests/dispatch_sanity.cpp b/src/mesa/main/tests/dispatch_sanity.cpp index 04fa86b..00f9b19 100644 ---

[Mesa-dev] [PATCH] winsys/svga: Fix incorrect type usage in IOCTL v2

2014-09-04 Thread Thomas Hellstrom
While similar in layout, the size of the SVGA3dSize type may be smaller than the struct drm_vmw_size type that is part of the ioctl interface. The kernel driver could accordingly overwrite a memory area following the size variable on the stack. Typically that would be another local variable,

[Mesa-dev] [Bug 82882] [swrast] piglit glsl-fs-uniform-bool-1 regression

2014-09-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=82882 --- Comment #2 from Marek Olšák mar...@gmail.com --- Created attachment 105739 -- https://bugs.freedesktop.org/attachment.cgi?id=105739action=edit r300g hack Pavel, does this patch fix r300g? It's a hack, I just need to confirm whether it

[Mesa-dev] [Bug 82882] [swrast] piglit glsl-fs-uniform-bool-1 regression

2014-09-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=82882 Marek Olšák mar...@gmail.com changed: What|Removed |Added Attachment #105739|0 |1 is obsolete|

[Mesa-dev] [Bug 82882] [swrast] piglit glsl-fs-uniform-bool-1 regression

2014-09-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=82882 --- Comment #4 from Marek Olšák mar...@gmail.com --- Created attachment 105743 -- https://bugs.freedesktop.org/attachment.cgi?id=105743action=edit swrast fix Vinson, could you please test if this attached patch fixes classic swrast? Thanks.

[Mesa-dev] [Bug 82538] Super Maryo Chronicles fails with st/mesa assertion failure

2014-09-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=82538 Marek Olšák mar...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED

[Mesa-dev] [Bug 82882] [swrast] piglit glsl-fs-uniform-bool-1 regression

2014-09-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=82882 --- Comment #5 from Pavel Ondračka pavel.ondra...@email.cz --- (In reply to comment #3) Created attachment 105742 [details] [review] gallium fix Scratch that. A new patch is attached. Could you please test it on r300g? Yes, that fixes it.

[Mesa-dev] [PATCH 2/2] st/mesa: use 1.0f as boolean true on drivers without integer support

2014-09-04 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=82882 Cc: 10.2 10.3 mesa-sta...@lists.freedesktop.org --- src/mesa/state_tracker/st_extensions.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [PATCH 1/2] mesa: set UniformBooleanTrue = 1.0f by default

2014-09-04 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com because NativeIntegers is 0 by default. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=82882 Cc: 10.2 10.3 mesa-sta...@lists.freedesktop.org --- Untested. This should fix swrast. See the bugzilla link above. The second patch fixes the same issue

Re: [Mesa-dev] Mesa (10.2): gallivm: Fix build with LLVM = 3.6 r215967.

2014-09-04 Thread Emil Velikov
On 03/09/14 04:45, Michel Dänzer wrote: On 03.09.2014 04:53, Emil Velikov wrote: Module: Mesa Branch: 10.2 Commit: 3fe59905fc684f64508982d405031771e273e656 URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=3fe59905fc684f64508982d405031771e273e656 Author: Vinson Lee

Re: [Mesa-dev] [PATCH 1/1] configure.ac: Fix build with git-svn llvm version string

2014-09-04 Thread Jan Vesely
On Thu, 2014-08-14 at 11:15 -0400, Jan Vesely wrote: On Thu, 2014-08-14 at 06:35 -0700, Tom Stellard wrote: On Wed, Aug 13, 2014 at 04:46:56PM -0400, Jan Vesely wrote: Signed-off-by: Jan Vesely jan.ves...@rutgers.edu --- My llvm-config --version is 3.6.0git-svn-r215564-cd35a3b3

Re: [Mesa-dev] Mesa (10.2): gallivm: Fix build with LLVM = 3.6 r215967.

2014-09-04 Thread Marek Olšák
Yeah, Michel is right. Marek On Thu, Sep 4, 2014 at 4:35 PM, Emil Velikov emil.l.veli...@gmail.com wrote: On 03/09/14 04:45, Michel Dänzer wrote: On 03.09.2014 04:53, Emil Velikov wrote: Module: Mesa Branch: 10.2 Commit: 3fe59905fc684f64508982d405031771e273e656 URL:

Re: [Mesa-dev] [PATCH 05/20] mesa: add double uniform support. (v2)

2014-09-04 Thread Brian Paul
On 09/03/2014 10:15 PM, Dave Airlie wrote: From: Dave Airlie airl...@redhat.com This adds support for the new uniform interfaces from ARB_gpu_shader_fp64. v2: support ARB_separate_shader_objects ProgramUniform*d* (Ian) don't allow boolean uniforms to be updated (issue 15) (Ian) Signed-off-by:

Re: [Mesa-dev] [PATCH 03/20] mesa: add mesa_type_is_double helper function (v2)

2014-09-04 Thread Brian Paul
On 09/03/2014 10:15 PM, Dave Airlie wrote: This is a helper to return if a type is based on a double. v2: GLboolean-bool (Ian) Reviewed-by: Ian Romanick ian.d.roman...@intel.com Signed-off-by: Dave Airlie airl...@redhat.com --- src/mesa/program/prog_parameter.h | 22 ++

Re: [Mesa-dev] Please clean your old patches out of Patchwork

2014-09-04 Thread Marek Olšák
I'd like to be an administrator, so that I can clear out other people's patches that I committed with changes or rejected. Marek On Thu, Sep 4, 2014 at 12:21 AM, Matt Turner matts...@gmail.com wrote: We're up to 16 pages of patches. Please take a look at your patches and clear out the old

Re: [Mesa-dev] [PATCH 03/20] mesa: add mesa_type_is_double helper function (v2)

2014-09-04 Thread Brian Paul
On 09/04/2014 09:12 AM, Brian Paul wrote: On 09/03/2014 10:15 PM, Dave Airlie wrote: This is a helper to return if a type is based on a double. v2: GLboolean-bool (Ian) Reviewed-by: Ian Romanick ian.d.roman...@intel.com Signed-off-by: Dave Airlie airl...@redhat.com ---

[Mesa-dev] [Bug 83485] Requesting a New Account

2014-09-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83485 Brian Paul bri...@vmware.com changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop.

Re: [Mesa-dev] [PATCH 1/2] mesa: set UniformBooleanTrue = 1.0f by default

2014-09-04 Thread Brian Paul
On 09/04/2014 08:21 AM, Marek Olšák wrote: From: Marek Olšák marek.ol...@amd.com because NativeIntegers is 0 by default. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=82882 Cc: 10.2 10.3 mesa-sta...@lists.freedesktop.org --- Untested. This should fix swrast. See the bugzilla link

Re: [Mesa-dev] [PATCH] state_tracker: Fix bug in conditional discards with native ints.

2014-09-04 Thread Brian Paul
On 09/03/2014 03:04 PM, Eric Anholt wrote: A bool is 0 or ~0, and KILL_IF takes a float arg that's 0 for discard or = 0 for not. By negating it, we ended up doing a floating point subtract of (0 - ~0), which ended up as an inf. To make this actually work, we need to convert the bool to a

[Mesa-dev] [PATCH 1/5] mesa: s/INLINE/inline/

2014-09-04 Thread Brian Paul
--- src/mesa/main/api_arrayelt.c |4 ++-- src/mesa/main/compiler.h |2 +- src/mesa/main/macros.h |4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/mesa/main/api_arrayelt.c b/src/mesa/main/api_arrayelt.c index ebeba88..536326f 100644 ---

[Mesa-dev] [PATCH 2/5] meta: s/INLINE/inline/

2014-09-04 Thread Brian Paul
--- src/mesa/drivers/common/meta.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/common/meta.c b/src/mesa/drivers/common/meta.c index 85f934d..7a8e627 100644 --- a/src/mesa/drivers/common/meta.c +++ b/src/mesa/drivers/common/meta.c @@ -1220,7 +1220,7 @@

[Mesa-dev] [PATCH 3/5] xlib: s/INLINE/inline/

2014-09-04 Thread Brian Paul
--- src/mesa/drivers/x11/xmesaP.h |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/x11/xmesaP.h b/src/mesa/drivers/x11/xmesaP.h index b47934d..d7a934e 100644 --- a/src/mesa/drivers/x11/xmesaP.h +++ b/src/mesa/drivers/x11/xmesaP.h @@ -375,7 +375,7 @@

[Mesa-dev] [PATCH 4/5] osmesa: s/INLINE/inline/

2014-09-04 Thread Brian Paul
--- src/mesa/drivers/osmesa/osmesa.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/osmesa/osmesa.c b/src/mesa/drivers/osmesa/osmesa.c index ab9ac31..74cbb5a 100644 --- a/src/mesa/drivers/osmesa/osmesa.c +++ b/src/mesa/drivers/osmesa/osmesa.c @@ -83,7

[Mesa-dev] [PATCH 5/5] swrast: s/INLINE/inline/

2014-09-04 Thread Brian Paul
--- src/mesa/swrast/s_texfilter.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/swrast/s_texfilter.c b/src/mesa/swrast/s_texfilter.c index c3fd900..65cf52e 100644 --- a/src/mesa/swrast/s_texfilter.c +++ b/src/mesa/swrast/s_texfilter.c @@ -804,7 +804,7 @@

Re: [Mesa-dev] [PATCH 1/2] mesa: set UniformBooleanTrue = 1.0f by default

2014-09-04 Thread Matt Turner
Thanks Marek, Both are Reviewed-by: Matt Turner matts...@gmail.com ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] i965: Mark cfg dumping functions const.

2014-09-04 Thread Matt Turner
Reviewed-by: Matt Turner matts...@gmail.com ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] i965/fs: Pass block to insert and remove functions missed earlier.

2014-09-04 Thread Matt Turner
I guess I can put a Reviewed-by on my own patch? :) Reviewed-by: Matt Turner matts...@gmail.com ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/3] i965: Handle ir_triop_csel in emit_if_gen6().

2014-09-04 Thread Matt Turner
Okay, this time I definitely know I already reviewed this patch :) ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 1/1] clover: Remove compat::string::c_str

2014-09-04 Thread Jan Vesely
It's unsafe as compat::string is not null terminated. Fixes garbage log on successful build. Signed-off-by: Jan Vesely jan.ves...@rutgers.edu --- It's obviously not needed in program::build, but I'm not sure if runtime_error solution is the best one.

Re: [Mesa-dev] [PATCH 2/3] i965/fs: Make emit_if_gen6 never fall back to emit_bool_to_cond_code.

2014-09-04 Thread Matt Turner
On Thu, Sep 4, 2014 at 12:18 AM, Kenneth Graunke kenn...@whitecape.org wrote: Matt and I believe that Sandybridge actually uses 0x for a true comparison result, similar to Ivybridge. This matches the internal documentation, and empirical results, but contradicts the PRM. So, the

Re: [Mesa-dev] [PATCH 3/3] i965: Handle ir_binop_ubo_load in boolean expression code.

2014-09-04 Thread Matt Turner
Reviewed-by: Matt Turner matts...@gmail.com ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] state_tracker: Fix bug in conditional discards with native ints.

2014-09-04 Thread Eric Anholt
Brian Paul bri...@vmware.com writes: On 09/03/2014 03:04 PM, Eric Anholt wrote: A bool is 0 or ~0, and KILL_IF takes a float arg that's 0 for discard or = 0 for not. By negating it, we ended up doing a floating point subtract of (0 - ~0), which ended up as an inf. To make this actually

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/3 v2] mesa: Handle uninitialized textures like other textures in get_tex_level_parameter_image

2014-09-04 Thread Carl Worth
Carl Worth cwo...@cworth.org writes: Emil Velikov emil.l.veli...@gmail.com writes: I will not have the chance to run piglit on a i965 system until next week so I would love if someone can take a look at this. I should be able to take a look at this today or tomorrow. I didn't see any

Re: [Mesa-dev] [PATCH 1/2] Eliminate several cases of multiplication in arguments to calloc

2014-09-04 Thread Carl Worth
Matt Turner matts...@gmail.com writes: - configs = calloc(1, (num_modes + 1) * sizeof *configs); + configs = calloc((num_modes + 1), sizeof *configs); I'd drop the extra parentheses. Thanks for reading carefully, Matt! With that, both are Reviewed-by: Matt Turner matts...@gmail.com

[Mesa-dev] [Bug 79706] [TRACKER] Mesa regression tracker

2014-09-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79706 Vinson Lee v...@freedesktop.org changed: What|Removed |Added Depends on||77288 -- You are

[Mesa-dev] [Bug 77288] [swrast] piglit glean glsl1 regression

2014-09-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77288 Vinson Lee v...@freedesktop.org changed: What|Removed |Added Blocks||79706 -- You are

Re: [Mesa-dev] [PATCH 1/5] mesa: s/INLINE/inline/

2014-09-04 Thread Kenneth Graunke
On Thursday, September 04, 2014 09:38:19 AM Brian Paul wrote: --- src/mesa/main/api_arrayelt.c |4 ++-- src/mesa/main/compiler.h |2 +- src/mesa/main/macros.h |4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) Series is: Reviewed-by: Kenneth Graunke

Re: [Mesa-dev] Please clean your old patches out of Patchwork

2014-09-04 Thread Kenneth Graunke
On Thursday, September 04, 2014 05:16:02 PM Marek Olšák wrote: I'd like to be an administrator, so that I can clear out other people's patches that I committed with changes or rejected. Marek Great :) I've added you. signature.asc Description: This is a digitally signed message part.

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/3 v2] mesa: Handle uninitialized textures like other textures in get_tex_level_parameter_image

2014-09-04 Thread Emil Velikov
On 04/09/14 02:50, Carl Worth wrote: Carl Worth cwo...@cworth.org writes: Emil Velikov emil.l.veli...@gmail.com writes: I will not have the chance to run piglit on a i965 system until next week so I would love if someone can take a look at this. I should be able to take a look at this today

Re: [Mesa-dev] [PATCH 20/20] i965: Add and use functions to get next/prev blocks.

2014-09-04 Thread Matt Turner
On Tue, Sep 2, 2014 at 9:34 PM, Matt Turner matts...@gmail.com wrote: diff --git a/src/mesa/drivers/dri/i965/brw_dead_control_flow.cpp b/src/mesa/drivers/dri/i965/brw_dead_control_flow.cpp index 557c3ad..8a7f42a 100644 --- a/src/mesa/drivers/dri/i965/brw_dead_control_flow.cpp +++

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/3 v2] mesa: Handle uninitialized textures like other textures in get_tex_level_parameter_image

2014-09-04 Thread Kenneth Graunke
On Wednesday, September 03, 2014 06:50:39 PM Carl Worth wrote: Carl Worth cwo...@cworth.org writes: Emil Velikov emil.l.veli...@gmail.com writes: I will not have the chance to run piglit on a i965 system until next week so I would love if someone can take a look at this. I should be

[Mesa-dev] [PATCH v2] r600g: Implement GL_ARB_sample_shading

2014-09-04 Thread Glenn Kennard
Also fixes two sided lighting which was broken at least on pre-evergreen by commit b1eb00. Signed-off-by: Glenn Kennard glenn.kenn...@gmail.com --- Changes since patch v1: Factor out and set sample positions also for pre-evergreen Misc r600 breakage fixes Some cleanup Passes piglit without

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/3 v2] mesa: Handle uninitialized textures like other textures in get_tex_level_parameter_image

2014-09-04 Thread Brian Paul
On 09/04/2014 03:17 PM, Kenneth Graunke wrote: On Wednesday, September 03, 2014 06:50:39 PM Carl Worth wrote: Carl Worth cwo...@cworth.org writes: Emil Velikov emil.l.veli...@gmail.com writes: I will not have the chance to run piglit on a i965 system until next week so I would love if

Re: [Mesa-dev] [PATCH 1/5] mesa: s/INLINE/inline/

2014-09-04 Thread Brian Paul
On 09/04/2014 11:57 AM, Kenneth Graunke wrote: On Thursday, September 04, 2014 09:38:19 AM Brian Paul wrote: --- src/mesa/main/api_arrayelt.c |4 ++-- src/mesa/main/compiler.h |2 +- src/mesa/main/macros.h |4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-)

[Mesa-dev] [PATCH 1/2] gallium: Drop software-only primitive restart support.

2014-09-04 Thread Eric Anholt
The drivers not flagging primitive restart support are r300 swtcl, svga, nv30, and vc4. The point of primitive restart is to slightly reduce draw call overhead for apps by batching multiple draws. If we do an extra pass to read the index buffer and split back into multiple draws, we've entirely

[Mesa-dev] [PATCH 2/2] mesa: Drop the always-software-primitive-restart paths.

2014-09-04 Thread Eric Anholt
The core sw primitive restart code is still around, because i965 uses it in some cases, but there are no drivers that want it on all the time. --- src/mesa/drivers/dri/i965/brw_primitive_restart.c | 8 src/mesa/main/context.c | 3 -- src/mesa/main/mtypes.h

[Mesa-dev] X.Org looking for projects and mentors for the Outreach Program for Women

2014-09-04 Thread Peter Hutterer
Hi everyone, X.Org will join the Outreach Program for Women (OPW) in Round 9 (December 2014 - March 2015). The OPW is open to anyone who was assigned female at birth and anyone who identifies as a woman, genderqueer, genderfluid, or genderfree regardless of gender presentation or assigned sex at

Re: [Mesa-dev] [PATCH 0/8] More format conversion reworking

2014-09-04 Thread Jason Ekstrand
Brian, Did you want to look over these or should I try and find someone else to review them? I'm most concerned with the 565 and 5551 patches since those touch corners of mesa with which I am very unfamiliar. --Jason On Sat, Aug 23, 2014 at 3:27 PM, Jason Ekstrand ja...@jlekstrand.net wrote:

[Mesa-dev] [PATCH] i965/fs: Fix basic block tracking in try_rep_send().

2014-09-04 Thread Matt Turner
The 'start' instruction is always in the current block, except for the case of shader time, which emits code in a pattern seen no where else. --- src/mesa/drivers/dri/i965/brw_fs.cpp | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git

Re: [Mesa-dev] [PATCH v2] r600g: Implement GL_ARB_sample_shading

2014-09-04 Thread Alexandre Demers
I've been testing your patch v2 on cayman. Here are my results. For now, my piglit runs are not conclusive because a quick run fails even without your patch: almost at the end of the run, X crashes. However, using Tesseract as you suggested gave good results. First, it fixes a visual glitch

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/3 v2] mesa: Handle uninitialized textures like other textures in get_tex_level_parameter_image

2014-09-04 Thread Kenneth Graunke
On Thursday, September 04, 2014 04:16:47 PM Brian Paul wrote: On 09/04/2014 03:17 PM, Kenneth Graunke wrote: On Wednesday, September 03, 2014 06:50:39 PM Carl Worth wrote: Carl Worth cwo...@cworth.org writes: Emil Velikov emil.l.veli...@gmail.com writes: I will not have the chance to

[Mesa-dev] [PATCH 00/10] i965: Add a width field to fs_inst

2014-09-04 Thread Jason Ekstrand
This is the first chunk of patches in my work on adding instruction and register widths to the fs backend. Eventually, this will allow us to more easily emit 8-wide instructions in SIMD16 mode from the fs_visitor level. More patches will be coming to add a width field to the registers and allow

[Mesa-dev] [PATCH 01/10] i965/fs: Clean up emitting of untyped atomic and sruface reads

2014-09-04 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com --- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp b/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp index

[Mesa-dev] [PATCH 05/10] i965/fs: Derive force_uncompressed from instruction width

2014-09-04 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com --- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp b/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp index ad89914..3c798f1 100644 ---

[Mesa-dev] [PATCH 03/10] i965/fs: Properly set the instruction width for atomics and surface reads

2014-09-04 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com --- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 30 +++- 1 file changed, 16 insertions(+), 14 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp b/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp

[Mesa-dev] [PATCH 04/10] i965/fs: Set instruction widths in a variety of places

2014-09-04 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com --- src/mesa/drivers/dri/i965/brw_fs.cpp | 6 ++ src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 5 - 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp

[Mesa-dev] [PATCH 09/10] i965/fs: Determine partial writes with instruction widths

2014-09-04 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com --- src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp b/src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp index

[Mesa-dev] [PATCH 02/10] i965/fs: Add a width field to fs_inst

2014-09-04 Thread Jason Ekstrand
This will, eventually, allow us to manage execution widths of instructions in a much more natural way from the fs_visitor level. Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com --- src/mesa/drivers/dri/i965/brw_blorp_blit_eu.cpp | 10 +-- src/mesa/drivers/dri/i965/brw_blorp_blit_eu.h

[Mesa-dev] [PATCH 08/10] i965/fs: Use instruction width instead of heuristics

2014-09-04 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com --- src/mesa/drivers/dri/i965/brw_fs.cpp | 30 -- .../drivers/dri/i965/brw_fs_live_variables.cpp | 10 .../drivers/dri/i965/brw_schedule_instructions.cpp | 4 +-- 3 files changed, 16

[Mesa-dev] [PATCH 06/10] i965/fs: Remove unneeded uses of force_uncompressed

2014-09-04 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com --- src/mesa/drivers/dri/i965/brw_blorp_blit_eu.h | 2 -- src/mesa/drivers/dri/i965/brw_fs.cpp | 4 src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 4 3 files changed, 10 deletions(-) diff --git

[Mesa-dev] [PATCH 10/10] i965/fs: Use instruction width directly for texture generation

2014-09-04 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com --- src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_generator.cpp b/src/mesa/drivers/dri/i965/brw_fs_generator.cpp index

Re: [Mesa-dev] [PATCH 01/10] i965/fs: Clean up emitting of untyped atomic and sruface reads

2014-09-04 Thread Matt Turner
Reviewed-by: Matt Turner matts...@gmail.com ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 01/10] i965/fs: Clean up emitting of untyped atomic and sruface reads

2014-09-04 Thread Matt Turner
On Thu, Sep 4, 2014 at 10:38 PM, Matt Turner matts...@gmail.com wrote: Reviewed-by: Matt Turner matts...@gmail.com That is, with the typo in the subject fixed. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH 02/10] i965/fs: Add a width field to fs_inst

2014-09-04 Thread Matt Turner
On Thu, Sep 4, 2014 at 10:19 PM, Jason Ekstrand ja...@jlekstrand.net wrote: This will, eventually, allow us to manage execution widths of instructions in a much more natural way from the fs_visitor level. Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com Adding a width field to fs_inst

[Mesa-dev] [PATCH 07/10] i965/fs: Use instruction widths to set compression state

2014-09-04 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com --- src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_generator.cpp b/src/mesa/drivers/dri/i965/brw_fs_generator.cpp

Re: [Mesa-dev] [PATCH 10/10] i965/fs: Use instruction width directly for texture generation

2014-09-04 Thread Matt Turner
On Thu, Sep 4, 2014 at 10:19 PM, Jason Ekstrand ja...@jlekstrand.net wrote: Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com --- src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 02/10] i965/fs: Add a width field to fs_inst

2014-09-04 Thread Jason Ekstrand
On Sep 4, 2014 10:45 PM, Matt Turner matts...@gmail.com wrote: On Thu, Sep 4, 2014 at 10:19 PM, Jason Ekstrand ja...@jlekstrand.net wrote: This will, eventually, allow us to manage execution widths of instructions in a much more natural way from the fs_visitor level. Signed-off-by: Jason