[Mesa-dev] [Bug 85203] [DRI2][RadeonSI] Pageflip completion event has impossible msc.

2014-11-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=85203 Michel Dänzer changed: What|Removed |Added CC||mario.klei...@tuebingen.mpg

Re: [Mesa-dev] [PATCH] util/hash_table: Rework the API to know about hashing

2014-11-24 Thread Connor Abbott
On Tue, Nov 25, 2014 at 1:19 AM, Jason Ekstrand wrote: > Previously, the hash_table API required the user to do all of the hashing > of keys as it passed them in. Since the hashing function is intrinsicly > tied to the comparison function, it makes sense for the hash table to know > about it. Al

Re: [Mesa-dev] [PATCH 3/3] glx/dri3: Request non-vsynced Present for swapinterval zero.

2014-11-24 Thread Axel Davy
Hi, This patch removes the tripple buffering behaviour that the GLX implementation has with DRI3. I understand your concern for Medical softwares, but perhaps this would be better handled with an user option. Axel Davy On 25/11/2014 04:00, Mario Kleiner wrote : Restores proper immediate tear

Re: [Mesa-dev] [PATCH] util/hash_table: Rework the API to know about hashing

2014-11-24 Thread Jason Ekstrand
If people like this change, I'll do the same thing to the hash set implementation. --Jason On Mon, Nov 24, 2014 at 10:19 PM, Jason Ekstrand wrote: > Previously, the hash_table API required the user to do all of the hashing > of keys as it passed them in. Since the hashing function is intrinsicl

[Mesa-dev] [PATCH] util/hash_table: Rework the API to know about hashing

2014-11-24 Thread Jason Ekstrand
Previously, the hash_table API required the user to do all of the hashing of keys as it passed them in. Since the hashing function is intrinsicly tied to the comparison function, it makes sense for the hash table to know about it. Also, it makes for a somewhat clumsy API as the user is constantly

[Mesa-dev] [PATCH 4/6] i965/fs: Pass key->render_to_fbo via src1 of FS_OPCODE_DDY_*.

2014-11-24 Thread Kenneth Graunke
This means the generator doesn't have to look at the key, which is a little nicer - we're pretty close to no key dependencies at all. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_defines.h| 4 src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 9 ++--- src/mesa

[Mesa-dev] [PATCH 1/6] i965: Fix missing CACHE_NEW_WM_PROG in 3DSTATE_PS_EXTRA.

2014-11-24 Thread Kenneth Graunke
brw->wm.prog_data is covered by CACHE_NEW_WM_PROG, not BRW_NEW_FRAGMENT_PROGRAM. So, we should listen to it. However, I believe that BRW_NEW_FRAGMENT_PROGRAM is sufficient to cover all the necessary cases - CACHE_NEW_WM_PROG happens in a subset of cases. So, the code being wrong shouldn't have t

[Mesa-dev] [PATCH 2/6] i965: Create prog_data temporary variables in PS state upload code.

2014-11-24 Thread Kenneth Graunke
prog_data->foo is a bit more readable than brw->wm.prog_data->foo. The local variable definition is also a great location to put the obligatory /* CACHE_NEW_WM_PROG */ comment. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_wm_state.c | 31 +++-- src/mesa/drive

[Mesa-dev] [PATCH 3/6] i965/fs: Handle derivative quality decisions in the front-end.

2014-11-24 Thread Kenneth Graunke
Kristian noted that there's very little use of brw_wm_prog_key in the generator, and that it basically just generates what it's told, without caring about what stage it's handling. One exception to this is derivative handling. When handling dFdxCoarse and dFdxFine, we packed an enum value in a se

[Mesa-dev] [PATCH 5/6] i965: Use brw_wm_prog_data::uses_kill, not gl_fragment_program::UsesKill

2014-11-24 Thread Kenneth Graunke
Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_wm_state.c | 3 ++- src/mesa/drivers/dri/i965/gen6_wm_state.c| 2 +- src/mesa/drivers/dri/i965/gen7_wm_state.c| 2 +- src/mesa/drivers/dri/i965/gen8_depth_state.c | 4 ++-- src/mesa/drivers/dri/i965/gen8_ps_state.c|

[Mesa-dev] [PATCH 6/6] i965: Set prog_data->uses_kill if simulating alpha test via discards.

2014-11-24 Thread Kenneth Graunke
When using MRT on Gen4-5, we have to simulate GL's alpha test feature by emitting discards in the fragment shader. In this case, it makes sense to set prog_data->uses_kill, which means the fragment shader may kill pixels via the discard mechanism. This saves us from having to look an extra key va

[Mesa-dev] [PATCH v3] st/nine: Use gallium caps to get if queries are supported. (v2)

2014-11-24 Thread David Heidelberg
From: Axel Davy Some queries need the driver to advertise a cap to be supported. For example r300 doesn't support them. v2 (David): check also for PIPE_CAP_QUERY_PIPELINE_STATISTICS, fix wine tests on r300g Cc: "10.4" Reviewed-by: David Heidelberg Signed-off-by: Axel Davy --- sr

[Mesa-dev] [PATCH 3/3] glx/dri3: Request non-vsynced Present for swapinterval zero.

2014-11-24 Thread Mario Kleiner
Restores proper immediate tearing swap behaviour for OpenGL bufferswap under DRI3/Present. Cc: "10.3 10.4" Signed-off-by: Mario Kleiner --- src/glx/dri3_glx.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/glx/dri3_glx.c b/src/glx/dri3_glx.c index 5796491..c53be1b

[Mesa-dev] DRI3/Present fixes for Mesa 10.3+

2014-11-24 Thread Mario Kleiner
Hi Here three patches against mesa to fix use of the OML_sync_control extension under DRI3/Present and restore behaviour compatible to the DRI2 implementation, so applications like mine, which were written and tested against DRI2, don't fail miserably under the new backend. Tested on Intel HD Iro

[Mesa-dev] [PATCH 2/3] glx/dri3: Track separate (ust, msc) for PresentPixmap vs. PresentNotifyMsc

2014-11-24 Thread Mario Kleiner
Prevent calls to glXGetSyncValuesOML() and glXWaitForMscOML() from overwriting the (ust,msc) values of the last successfull swapbuffers call (PresentPixmapCompleteNotify event), as glXWaitForSbcOML() relies on those values corresponding to the most recent completed swap, not to whatever was last re

[Mesa-dev] [PATCH 1/3] glx/dri3: Fix glXWaitForSbcOML() to handle targetSBC==0 correctly.

2014-11-24 Thread Mario Kleiner
targetSBC == 0 is a special case, which asks the function to block until all pending OpenGL bufferswap requests have completed. Currently the function just falls through for targetSBC == 0, returning bogus results. This breaks applications originally written and tested against DRI2 which also rel

[Mesa-dev] [Bug 71199] [llvmpipe] piglit gl-1.4-polygon-offset regression

2014-11-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=71199 --- Comment #7 from Roland Scheidegger --- (In reply to Laura Ekstrand from comment #6) > I recently ported this test from Glean to Piglit, and I took another look at > it just now. From my understanding, I think the logic of the test is > corre

[Mesa-dev] [Bug 80848] [dri3] Building mesa fails with dri3 enabled

2014-11-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=80848 --- Comment #27 from Emil Velikov --- Guys if you're still having fun with this can attach the output with the following patch ? It should make ld a bit more chatty on the topic :) diff --git a/src/glx/Makefile.am b/src/glx/Makefile.am index 451

[Mesa-dev] [Bug 80848] [dri3] Building mesa fails with dri3 enabled

2014-11-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=80848 --- Comment #26 from Emil Velikov --- Scratch-out comment 25. Seems like I've got a bit confused there :) -- You are receiving this mail because: You are the assignee for the bug. ___ mesa-dev mailing

Re: [Mesa-dev] [PATCH 3/4] nine: handle D3DISSUE_END without previous D3DISSUE_BEGIN

2014-11-24 Thread John Ettedgui
On Sun Nov 23 2014 at 2:51:42 AM Marek Olšák wrote: > A few Gallium queries don't need and it's invalid to call begin_query. > Those are PIPE_QUERY_GPU_FINISHED (D3DQUERYTYPE_EVENT) and > PIPE_QUERY_TIMESTAMP (D3DQUERYTYPE_TIMESTAMP). > > Right, Axel explained that to me on irc as well. I didn't

Re: [Mesa-dev] [PATCH 2/2] nouveau: Avoid pasting TGSI_OPCODE_ tokens together.

2014-11-24 Thread Ilia Mirkin
I like the macros Nouveau, and probably other drivers, do lits of token pasting on all sorts of gallium tokens. I think it makes the code considerably easier to read. On Nov 24, 2014 7:07 PM, "Eric Anholt" wrote: > This made it harder to modify TGSI_OPCODE_ enums without breaking the > driver

[Mesa-dev] [Bug 80848] [dri3] Building mesa fails with dri3 enabled

2014-11-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=80848 Emil Velikov changed: What|Removed |Added CC||emil.l.veli...@gmail.com --- Comment #25

[Mesa-dev] [PATCH 6/7] util: Use stdbool.h's bool rather than "boolean".

2014-11-24 Thread Matt Turner
--- src/util/u_atomic.h | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/util/u_atomic.h b/src/util/u_atomic.h index 13b264f..620191c 100644 --- a/src/util/u_atomic.h +++ b/src/util/u_atomic.h @@ -9,6 +9,8 @@ #ifndef U_ATOMIC_H #define U_ATOMIC_H +#include + /*

[Mesa-dev] [PATCH 5/7] util: Remove u_atomic.h's GCC inline assembly.

2014-11-24 Thread Matt Turner
GCC >= 4.1 support the __sync_* intrinsics. That seems like a sufficiently old baseline. --- src/util/u_atomic.h | 122 1 file changed, 122 deletions(-) diff --git a/src/util/u_atomic.h b/src/util/u_atomic.h index f326bd1..13b264f 100644 --- a/

[Mesa-dev] [PATCH 7/7] util: Make u_atomic.h typeless.

2014-11-24 Thread Matt Turner
like how C11's stdatomic.h provides generic functions. GCC's __sync_* builtins already take a variety of types, so that's simple. MSVC and Sun Studio don't, but we can implement it with something that looks a little crazy but is actually quite readable. --- src/util/u_atomic.h | 202 +

[Mesa-dev] [PATCH 4/7] util: Remove u_atomic.h's MSVC inline assembly.

2014-11-24 Thread Matt Turner
There was already an intrinsics path that implemented all of the same functions, plus more. --- src/util/u_atomic.h | 70 - 1 file changed, 70 deletions(-) diff --git a/src/util/u_atomic.h b/src/util/u_atomic.h index 51e799e..f326bd1 100644 ---

[Mesa-dev] [PATCH 3/7] util: Remove u_atomic.h's Gallium dependence.

2014-11-24 Thread Matt Turner
--- src/util/u_atomic.h | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/src/util/u_atomic.h b/src/util/u_atomic.h index 8653e73..51e799e 100644 --- a/src/util/u_atomic.h +++ b/src/util/u_atomic.h @@ -9,26 +9,23 @@ #ifndef U_ATOMIC_H #define U_ATOMIC_H -#incl

[Mesa-dev] [PATCH 2/7] util: s/INLINE/inline/ in u_atomic.h.

2014-11-24 Thread Matt Turner
--- src/util/u_atomic.h | 58 ++--- 1 file changed, 29 insertions(+), 29 deletions(-) diff --git a/src/util/u_atomic.h b/src/util/u_atomic.h index 2500bc7..8653e73 100644 --- a/src/util/u_atomic.h +++ b/src/util/u_atomic.h @@ -45,7 +45,7 @@ extern "

[Mesa-dev] [PATCH 0/7] util: Move u_atomic.h to src/util and modify API

2014-11-24 Thread Matt Turner
I've got some thread-safety fixes queued up after this and thought I'd be a good Mesa citizen and pull some code into src/util. I did some clean ups like replacing INLINE (MSVC knows about "inline" these days, right?) and used stdbool.h instead of the "boolean" type. I also removed the inline ass

[Mesa-dev] [PATCH 1/7] util: Move u_atomic.h to src/util.

2014-11-24 Thread Matt Turner
To be shared outside of Gallium. --- src/gallium/Automake.inc | 2 + src/gallium/auxiliary/util/u_atomic.h | 401 -- src/util/u_atomic.h | 401 ++ 3 files changed, 403 insertions(+), 401 deletions(-)

Re: [Mesa-dev] [PATCH] main, glsl: Bump max known desktop glsl version to 4.50

2014-11-24 Thread Matt Turner
On Mon, Nov 24, 2014 at 3:06 PM, Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > src/glsl/glsl_parser_extras.cpp | 10 +++--- > src/glsl/glsl_parser_extras.h | 2 +- > src/mesa/main/getstring.c | 6 ++ > 3 files changed, 14 insertions(+), 4 deletions(-) > > diff --g

[Mesa-dev] [PATCH 1/2] freedreno: Avoid pasting TGSI_OPCODE_ tokens together.

2014-11-24 Thread Eric Anholt
This made it harder to modify TGSI_OPCODE_ enums without breaking the driver. --- src/gallium/drivers/freedreno/ir3/ir3_compiler.c | 172 ++--- .../drivers/freedreno/ir3/ir3_compiler_old.c | 74 - 2 files changed, 123 insertions(+), 123 deletions(-) diff --git a/s

[Mesa-dev] [PATCH 2/2] nouveau: Avoid pasting TGSI_OPCODE_ tokens together.

2014-11-24 Thread Eric Anholt
This made it harder to modify TGSI_OPCODE_ enums without breaking the driver. --- .../drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp | 278 ++--- 1 file changed, 139 insertions(+), 139 deletions(-) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp b/src/galli

[Mesa-dev] [Bug 71199] [llvmpipe] piglit gl-1.4-polygon-offset regression

2014-11-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=71199 --- Comment #6 from Laura Ekstrand --- I recently ported this test from Glean to Piglit, and I took another look at it just now. From my understanding, I think the logic of the test is correct, but perhaps you are correct that the implementation

[Mesa-dev] [PATCH v3 19/19] st/nine: Queries: Always return D3D_OK when issuing with D3DISSUE_BEGIN

2014-11-24 Thread David Heidelberg
From: Axel Davy This is the behaviour that wine tests. Cc: "10.4" Reviewed-by: David Heidelberg Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/query9.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/nine/query9.c b/src/gall

[Mesa-dev] [PATCH v3 18/19] st/nine: Queries: always succeed for D3DQUERYTYPE_TIMESTAMP when flushing

2014-11-24 Thread David Heidelberg
From: Axel Davy This is the behaviour that Wine tests Cc: "10.4" Tested-by: David Heidelberg Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/query9.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/state_trackers/nine/query9.c b/src/gallium/state_trackers/nin

[Mesa-dev] [PATCH v3 16/19] st/nine: Queries: Fix D3DISSUE_END behaviour.

2014-11-24 Thread David Heidelberg
From: Axel Davy Issuing D3DISSUE_END should: . reset previous queries if possible . end the query Previous behaviour wasn't calling end_query for queries not needing D3DISSUE_BEGIN, no resetting previous queries. Cc: "10.4" Tested-by: David Heidelberg Signed-off-by: Axel Davy --- src/galliu

[Mesa-dev] [PATCH v3 15/19] st/nine: return S_FALSE instead of INVALIDCALL when in building query state

2014-11-24 Thread David Heidelberg
From: Axel Davy It is the same behaviour as wine has. Cc: "10.4" Reviewed-by: David Heidelberg Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/query9.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/nine/query9.c b/src/gallium

[Mesa-dev] [PATCH v3 17/19] st/nine: Queries: allow app to call GetData without Issuing first

2014-11-24 Thread David Heidelberg
From: Axel Davy Nine was allowing that behaviour, but was not filling the result. Cc: "10.4" Tested-by: David Heidelberg Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/query9.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/src/gallium/state

[Mesa-dev] [PATCH v3 12/19] st/nine: if query needs flush, try again get_query_result after flush

2014-11-24 Thread David Heidelberg
From: Axel Davy Cc: "10.4" Tested-by: David Heidelberg Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/query9.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/src/gallium/state_trackers/nine/query9.c b/src/gallium/state_trackers/nine/quer

[Mesa-dev] [PATCH v3 14/19] st/nine: Use gallium caps to get if queries are supported.

2014-11-24 Thread David Heidelberg
From: Axel Davy Some queries need the driver to advertise a cap to be supported. For example r300 doesn't support them. Cc: "10.4" Tested-by: David Heidelberg Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/device9.c | 2 +- src/gallium/state_trackers/nine/query9.c | 43 ++

[Mesa-dev] [PATCH v3 11/19] st/nine: remove dummy queries

2014-11-24 Thread David Heidelberg
From: Axel Davy Applications are supposed to call CreateQuery with a NULL ppQuery to know if the query is supported. We supported that. However when ppQuery was not NULL, we were accepting to create the query and were creating a dummy query even when the query is not supported. Wine has differe

[Mesa-dev] [PATCH v3 13/19] st/nine: fix formatting in query9 (cosmetic)

2014-11-24 Thread David Heidelberg
From: Axel Davy Cc: "10.4" Reviewed-by: David Heidelberg Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/query9.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gallium/state_trackers/nine/query9.c b/src/gallium/state_trackers/nine/query9.c index 7

[Mesa-dev] [PATCH v3 10/19] st/nine: Fix setting of the shift modifier in nine_shader

2014-11-24 Thread David Heidelberg
From: Axel Davy It is an sint_4, but it was stored in a uint_8... The code using it was acting as if it was signed. Problem found thanks to Coverity Cc: "10.4" Tested-by: David Heidelberg Reviewed-by: Ilia Mirkin Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/nine_shader.c |

[Mesa-dev] [PATCH v3 08/19] st/nine: fix wrong variable reset

2014-11-24 Thread David Heidelberg
From: Axel Davy Error detected by Coverity (COPY_PASTE_ERROR) Cc: "10.4" Reviewed-by: Ilia Mirkin Signed-off-by: Axel Davy Signed-off-by: David Heidelberg --- src/gallium/state_trackers/nine/nine_state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_t

[Mesa-dev] [PATCH v3 09/19] st/nine: remove unused pipe_viewport_state::translate[3] and scale[3]

2014-11-24 Thread David Heidelberg
2efabd9f5a711a7f6cd1846630244b7814bf25b3 removed them as unused. This caused random memory overwrites (reported by Coverity). Cc: "10.4" Reviewed-by: Ilia Mirkin Reviewed-by: Marek Olšák Reviewed-by: Axel Davy Signed-off-by: David Heidelberg --- src/gallium/state_trackers/nine/nine_state.c

[Mesa-dev] [PATCH v3 07/19] st/nine: return GetAvailableTextureMem in bytes as expected (v2)

2014-11-24 Thread David Heidelberg
PIPE_CAP_VIDEO_MEMORY returns the amount of video memory in megabytes, so need to converted it to bytes. Fixed Warframe memory detection. v2: also prepare for cards with more than 4GB memory Cc: "10.4" Tested-by: Yaroslav Andrusyak Reviewed-by: Ilia Mirkin Reviewed-by: Axel Davy Signed-off-b

[Mesa-dev] [PATCH v3 03/19] st/nine: rework the way D3DPOOL_SYSTEMMEM is handled

2014-11-24 Thread David Heidelberg
From: Axel Davy This patch moves the data field from Resource9 to Surface9 and cleans D3DPOOL_SYSTEMMEM handling in Texture9. This fixes HL2 lost coast. It also removes in Texture9 some code written to support importing and exporting non D3DPOOL_SYSTEMMEM shared buffers. This code hadn't the des

[Mesa-dev] [PATCH v3 06/19] st/nine: Add pool check to SetTexture (v2)

2014-11-24 Thread David Heidelberg
From: Axel Davy D3DPOOL_SCRATCH is disallowed according to spec. D3DPOOL_SYSTEMMEM should be allowed but we don't handle it right for now. v2: Fixes segfault in SetTexture when unsetting the texture Cc: "10.4" Tested-by: David Heidelberg Signed-off-by: Axel Davy --- src/gallium/state_tracke

[Mesa-dev] [PATCH v3 04/19] st/nine: call DBG() at more external entry points

2014-11-24 Thread David Heidelberg
From: Stanislaw Halik Cc: "10.4" Reviewed-by: Ilia Mirkin Reviewed-by: David Heidelberg Reviewed-by: Axel Davy Signed-off-by: Stanislaw Halik --- src/gallium/state_trackers/nine/basetexture9.c | 17 src/gallium/state_trackers/nine/cubetexture9.c | 17 src/gallium/s

[Mesa-dev] [PATCH v3 05/19] st/nine: propertly declare constants (v2)

2014-11-24 Thread David Heidelberg
From: Axel Davy Fixes "Error : CONST[20]: Undeclared source register" when running dx9_alpha_blending_material. Also artifacts on ilo. v2: also remove unused MISC_CONST Cc: "10.4" Tested-by: David Heidelberg Reviewed-by: Ilia Mirkin Signed-off-by: Axel Davy --- src/gallium/state_trackers/n

[Mesa-dev] [PATCH v3 02/19] st/nine: Rework Basetexture9 and Resource9.

2014-11-24 Thread David Heidelberg
From: Axel Davy Instead of having parts of the structures initialised by the parents, have them initialised by the children. Cc: "10.4" Tested-by: David Heidelberg Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/basetexture9.c | 19 +++ src/gallium/state_tracke

[Mesa-dev] [PATCH v3 01/19] st/nine: clean device9ex.

2014-11-24 Thread David Heidelberg
From: Axel Davy Pass ex specific parameters as arguments to device9 ctor instead of passing them by filling the structure. Cc: "10.4" Reviewed-by: David Heidelberg Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/adapter9.c | 2 +- src/gallium/state_trackers/nine/device9.c |

[Mesa-dev] [PATCH] main, glsl: Bump max known desktop glsl version to 4.50

2014-11-24 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/glsl/glsl_parser_extras.cpp | 10 +++--- src/glsl/glsl_parser_extras.h | 2 +- src/mesa/main/getstring.c | 6 ++ 3 files changed, 14 insertions(+), 4 deletions(-) diff --git a/src/glsl/glsl_parser_extras.cpp b/src/glsl/glsl_parser_extras.cpp

Re: [Mesa-dev] [PATCH] llvmpipe: fix lp_test_arit denorm handling

2014-11-24 Thread Jose Fonseca
Reviewed-by: Jose Fonseca Jose On 24/11/14 22:37, srol...@vmware.com wrote: From: Roland Scheidegger llvmpipe disables denorms on purpose (on x86/sse only), because denorms are generally neither required nor desired for graphic apis (and in case of d3d10, they are forbidden). However, this c

[Mesa-dev] [PATCH] llvmpipe: fix lp_test_arit denorm handling

2014-11-24 Thread sroland
From: Roland Scheidegger llvmpipe disables denorms on purpose (on x86/sse only), because denorms are generally neither required nor desired for graphic apis (and in case of d3d10, they are forbidden). However, this caused some arithmetic tests using denorms to fail on some systems, because the re

[Mesa-dev] [Bug 71199] [llvmpipe] piglit gl-1.4-polygon-offset regression

2014-11-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=71199 --- Comment #5 from Roland Scheidegger --- (In reply to José Fonseca from comment #4) > This test was renamed, but the issue is still there: > > $ ./bin/gl-1.4-polygon-offset -auto > Actual MRD is too small (may cause incorrect results) >

[Mesa-dev] [Bug 55343] [st/dri][llvmpipe] compiz crasher in drisw_update_tex_buffer()

2014-11-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=55343 José Fonseca changed: What|Removed |Added CC||jfons...@vmware.com Summary|[l

[Mesa-dev] [PATCH] i965/Gen6-7: Do not replace texcoords with point coord if not drawing points

2014-11-24 Thread Chris Forbes
Partially fixes broken rendering in Windows-based QtQuick2 apps run through Wine. This library sets all texture units' GL_COORD_REPLACE, leaves point sprite mode enabled, and then draws a triangle fan. Will need a slightly different fix for Gen4-5, but I don't have my old machines in a usable sta

Re: [Mesa-dev] [PATCH 1/3] nine: Don't use the otherwise-dead SFL opcode in an unreachable path.

2014-11-24 Thread Eric Anholt
Axel Davy writes: > Hi, > > Series looks good. You can add my r-b. > > Do you want also to remove the DP2A reference like > did Jose patch ? The rest of my series doesn't touch DP2A, so I wasn't planning on it. pgpq8Vu6pmNT9.pgp Description: PGP signature __

Re: [Mesa-dev] [PATCH] i965/Gen6-7: Do not replace texcoords with point coord if not drawing points

2014-11-24 Thread Chris Forbes
Oops -- this is what I get for dropping that comment in at the last minute while reviewing the mail and forgetting to adjust the header. Will resend. On Tue, Nov 25, 2014 at 9:22 AM, Ilia Mirkin wrote: > On Mon, Nov 24, 2014 at 2:33 PM, Chris Forbes wrote: >> Partially fixes broken rendering in

[Mesa-dev] [Bug 78914] [llvmpipe] Front/Backfaces do not get the same depth values when interpolated

2014-11-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=78914 José Fonseca changed: What|Removed |Added Summary|[llvmpipe] Front/Backfaces |[llvmpipe] Front/Backfaces

Re: [Mesa-dev] [PATCH] i965/Gen6-7: Do not replace texcoords with point coord if not drawing points

2014-11-24 Thread Ilia Mirkin
On Mon, Nov 24, 2014 at 2:33 PM, Chris Forbes wrote: > Partially fixes broken rendering in Windows-based QtQuick2 apps run through > Wine. > This library sets all texture units' GL_COORD_REPLACE, leaves point > sprite mode enabled, and then draws a triangle fan. > > Will need a slightly different

[Mesa-dev] [Bug 71199] [llvmpipe] piglit gl-1.4-polygon-offset regression

2014-11-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=71199 José Fonseca changed: What|Removed |Added Summary|[llvmpipe] piglit glean |[llvmpipe] piglit |poly

[Mesa-dev] [Bug 67672] [llvmpipe] lp_test_arit fails on old CPUs

2014-11-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=67672 José Fonseca changed: What|Removed |Added CC||jfons...@vmware.com Assignee|me

[Mesa-dev] [PATCH] i965/Gen6-7: Do not replace texcoords with point coord if not drawing points

2014-11-24 Thread Chris Forbes
Partially fixes broken rendering in Windows-based QtQuick2 apps run through Wine. This library sets all texture units' GL_COORD_REPLACE, leaves point sprite mode enabled, and then draws a triangle fan. Will need a slightly different fix for Gen4-5, but I don't have my old machines in a usable sta

Re: [Mesa-dev] glsl es question: invalid pragma debug argument

2014-11-24 Thread Matt Turner
On Mon, Nov 24, 2014 at 2:13 AM, Samuel Iglesias Gonsálvez wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Hello, > > I found a GLSL ES test that provides an invalid argument to #pragma > debug() such as: > > #pragma debug (1.23) > > And it expects a compilation error. Mesa doesn'

Re: [Mesa-dev] [PATCH 03/11] st/nine: propertly declare constants

2014-11-24 Thread Axel Davy
On 24/11/2014 06:54, Ilia Mirkin wrote : On Sun, Nov 23, 2014 at 5:40 PM, David Heidelberg wrote: From: Axel Davy Fixes "Error : CONST[20]: Undeclared source register" when running dx9_alpha_blending_material. Also artifacts on ilo. Cc: "10.4" Tested-by: David Heidelberg Signed-off-by: Axe

Re: [Mesa-dev] [PATCH] glsl: Make lower_constant_arrays_to_uniforms require dereferences.

2014-11-24 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 4/4] i965: Precompile ARB programs.

2014-11-24 Thread Matt Turner
Thanks Ken. These look good, and they let the new shader-db runner compile fp/vp programs! The series is Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 4/4] i965: Precompile ARB programs.

2014-11-24 Thread Kristian Høgsberg
On Mon, Nov 24, 2014 at 12:28 AM, Kenneth Graunke wrote: > We already precompile GLSL programs; it seems logical to precompile ARB > programs as well. We just never hooked it up. > > This also makes the programs compile even if no drawing occurs, which is > useful for shader-db. > > Signed-off-by

Re: [Mesa-dev] [PATCH 3/4] i965: Make precompile functions accessible from C.

2014-11-24 Thread Kristian Høgsberg
On Mon, Nov 24, 2014 at 12:28 AM, Kenneth Graunke wrote: > Previously, the prototypes for brw_vs/gs/fs_precompile were scattered > between brw_vs.h (C), brw_gs.h (C), and brw_fs.h (C++ only). Also, > brw_fs_precompile had C++ linkage, while the others were C. > > This patch moves all the prototyp

Re: [Mesa-dev] [PATCH 2/4] i965: Pass gl_program pointers into precompile functions.

2014-11-24 Thread Kristian Høgsberg
On Mon, Nov 24, 2014 at 12:28 AM, Kenneth Graunke wrote: > We'd like to do precompiling for ARB vertex and fragment programs, > which only have gl_program structures - gl_shader_program is NULL. > > This patch makes the various precompile functions take a gl_program > parameter directly, rather th

Re: [Mesa-dev] [PATCH 1/4] i965: Move brw->precompile checks out a level.

2014-11-24 Thread Kristian Høgsberg
On Mon, Nov 24, 2014 at 12:28 AM, Kenneth Graunke wrote: > brw_shader_precompile should just do a precompile; it makes more sense > for the caller to decide whether we should do one. Simpler. That makes a lot more sense, Reviewed-by: Kristian Høgsberg > Signed-off-by: Kenneth Graunke > --- >

[Mesa-dev] glsl es question: invalid pragma debug argument

2014-11-24 Thread Samuel Iglesias Gonsálvez
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hello, I found a GLSL ES test that provides an invalid argument to #pragma debug() such as: #pragma debug (1.23) And it expects a compilation error. Mesa doesn't complain about it, just ignore the whole thing. The allowed keywords are 'on' and '

Re: [Mesa-dev] [PATCH] mesa: Fix Get(GL_TRANSPOSE_CURRENT_MATRIX_ARB) to transpose

2014-11-24 Thread Jose Fonseca
On 24/11/14 08:53, Kenneth Graunke wrote: On Monday, November 24, 2014 09:44:38 PM Chris Forbes wrote: This was just returning the same value as GL_CURRENT_MATRIX_ARB. Spotted while investigating something else in apitrace. Signed-off-by: Chris Forbes Cc: "10.3 10.4" --- src/mesa/main/get_h

Re: [Mesa-dev] Using the 'f' suffix to create a float from an integer literal

2014-11-24 Thread Iago Toral
On Thu, 2014-11-20 at 09:33 -0800, Ian Romanick wrote: > On 11/20/2014 05:33 AM, Neil Roberts wrote: > > For what it's worth, I did a quick grep through the internal and public > > shader-db and I couldn't find anything using this. > > > > git grep -P '\b(? > > > If AMD disallows it then it seem

Re: [Mesa-dev] [PATCH] mesa: Fix Get(GL_TRANSPOSE_CURRENT_MATRIX_ARB) to transpose

2014-11-24 Thread Kenneth Graunke
On Monday, November 24, 2014 09:44:38 PM Chris Forbes wrote: > This was just returning the same value as GL_CURRENT_MATRIX_ARB. > Spotted while investigating something else in apitrace. > > Signed-off-by: Chris Forbes > Cc: "10.3 10.4" > --- > src/mesa/main/get_hash_params.py | 2 +- > 1 file c

[Mesa-dev] [PATCH] mesa: Fix Get(GL_TRANSPOSE_CURRENT_MATRIX_ARB) to transpose

2014-11-24 Thread Chris Forbes
This was just returning the same value as GL_CURRENT_MATRIX_ARB. Spotted while investigating something else in apitrace. Signed-off-by: Chris Forbes Cc: "10.3 10.4" --- src/mesa/main/get_hash_params.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/get_hash_pa

[Mesa-dev] [PATCH 4/4] i965: Precompile ARB programs.

2014-11-24 Thread Kenneth Graunke
We already precompile GLSL programs; it seems logical to precompile ARB programs as well. We just never hooked it up. This also makes the programs compile even if no drawing occurs, which is useful for shader-db. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_program.c | 11 +

[Mesa-dev] [PATCH 1/4] i965: Move brw->precompile checks out a level.

2014-11-24 Thread Kenneth Graunke
brw_shader_precompile should just do a precompile; it makes more sense for the caller to decide whether we should do one. Simpler. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_shader.cpp | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mesa/dri

[Mesa-dev] [PATCH 3/4] i965: Make precompile functions accessible from C.

2014-11-24 Thread Kenneth Graunke
Previously, the prototypes for brw_vs/gs/fs_precompile were scattered between brw_vs.h (C), brw_gs.h (C), and brw_fs.h (C++ only). Also, brw_fs_precompile had C++ linkage, while the others were C. This patch moves all the prototypes to a central location (brw_shader.h) and makes brw_fs_precompile

[Mesa-dev] [PATCH 2/4] i965: Pass gl_program pointers into precompile functions.

2014-11-24 Thread Kenneth Graunke
We'd like to do precompiling for ARB vertex and fragment programs, which only have gl_program structures - gl_shader_program is NULL. This patch makes the various precompile functions take a gl_program parameter directly, rather than accessing it via gl_shader_program. Signed-off-by: Kenneth Grau