[Mesa-dev] [Bug 80848] [dri3] Building mesa fails with dri3 enabled

2014-11-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=80848 --- Comment #28 from Juha-Pekka Heikkilä juhapekka.heikk...@gmail.com --- Created attachment 110039 -- https://bugs.freedesktop.org/attachment.cgi?id=110039action=edit log of failed dri3 build with Emil's patch included Here is the log with

[Mesa-dev] [Bug 77449] Tracker bug for all bugs related to Steam titles

2014-11-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77449 Felix Schwarz felix.schw...@oss.schwarz.eu changed: What|Removed |Added Depends on||86720 --

Re: [Mesa-dev] [PATCH 0/7] util: Move u_atomic.h to src/util and modify API

2014-11-26 Thread Jose Fonseca
On 26/11/14 01:01, Matt Turner wrote: On Mon, Nov 24, 2014 at 4:39 PM, Matt Turner matts...@gmail.com wrote: I've got some thread-safety fixes queued up after this and thought I'd be a good Mesa citizen and pull some code into src/util. I did some clean ups like replacing INLINE (MSVC knows

[Mesa-dev] [PATCH] Add support for following Texture Float extensions.

2014-11-26 Thread Kalyan Kondapally
This patch is based on initial work done by Kevin Rogovin here: http://lists.freedesktop.org/archives/mesa-dev/2014-May/059012.html Piglit tests can be found here: http://lists.freedesktop.org/archives/piglit/2014-July/011964.html The main changes in this patch are: 1)Add boolean flags to toggle

[Mesa-dev] [PATCH] Add support for following Texture Float extensions: 1)GL_OES_texture_float, 2)GL_OES_texture_half_float, 3)GL_OES_texture_float_linear, 4)GL_OES_texture_half_float_linear.

2014-11-26 Thread Kalyan Kondapally
Support for these extensions need to be explicitly enabled per driver and this patch enables support for i965 drivers. Signed-off-by: Kevin Rogovin kevin.rogo...@intel.com Signed-off-by: Kalyan Kondapally kalyan.kondapa...@intel.com --- src/mesa/drivers/dri/i965/intel_extensions.c | 6 +++

Re: [Mesa-dev] [PATCH] Add support for following Texture Float extensions: 1)GL_OES_texture_float, 2)GL_OES_texture_half_float, 3)GL_OES_texture_float_linear, 4)GL_OES_texture_half_float_linear.

2014-11-26 Thread kalyan kondapally
Hi, Please ignore this patch. Will re-send with the commit message fixed. Thanks, Kalyan On Wed, Nov 26, 2014 at 5:31 AM, Kalyan Kondapally kondapallykalyancontrib...@gmail.com wrote: Support for these extensions need to be explicitly enabled per driver and this patch enables support for i965

[Mesa-dev] [PATCH] Add support for GLES2 Texture Float extensions.

2014-11-26 Thread Kalyan Kondapally
This patch is based on initial work done by Kevin Rogovin here: http://lists.freedesktop.org/archives/mesa-dev/2014-May/059012.html Piglit tests can be found here: http://lists.freedesktop.org/archives/piglit/2014-July/011964.html The main changes in this patch are: 1)Add boolean flags to toggle

[Mesa-dev] [PATCH] Add support for Texture Float extensions.

2014-11-26 Thread Kalyan Kondapally
This patch adds support for following GLES2 Texture Float extensions: 1)GL_OES_texture_float, 2)GL_OES_texture_half_float, 3)GL_OES_texture_float_linear, 4)GL_OES_texture_half_float_linear. Support for these extensions need to be explicitly enabled per driver and this patch enables support for

Re: [Mesa-dev] [PATCH] Add support for Texture Float extensions.

2014-11-26 Thread Brian Paul
The subject line of the patch should be something like mesa: add support for GL_OES_texture_*float* extensions A bunch of other nitpicks below... On 11/26/2014 06:55 AM, Kalyan Kondapally wrote: This patch adds support for following GLES2 Texture Float extensions: 1)GL_OES_texture_float,

[Mesa-dev] [Bug 80848] [dri3] Building mesa fails with dri3 enabled

2014-11-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=80848 --- Comment #29 from Emil Velikov emil.l.veli...@gmail.com --- OK so it seems that, on relink, libtool prepends an extra -L or two prior to -L/opt/lib thus gcc/ld might end up finding the system library thus never bothers searching in /opt/lib.

[Mesa-dev] [PATCH 2/5] i965: Initialize compaction tables once per process.

2014-11-26 Thread Matt Turner
--- src/mesa/drivers/dri/i965/brw_eu_compact.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_eu_compact.c b/src/mesa/drivers/dri/i965/brw_eu_compact.c index 7117890..8e33bcb 100644 --- a/src/mesa/drivers/dri/i965/brw_eu_compact.c +++

[Mesa-dev] [PATCH 4/5] ra: Don't use regs as the ralloc context.

2014-11-26 Thread Matt Turner
The i965 backends pass something out of 'screen', which is allocated per-process, making using this as a ralloc context not thread-safe. All callers ra_alloc_interference_graph() already ralloc_free() its return value. --- src/util/register_allocate.c | 2 +- 1 file changed, 1 insertion(+), 1

[Mesa-dev] [PATCH 1/5] glsl: Initialize static temporaries_allocate_names once per process.

2014-11-26 Thread Matt Turner
--- src/glsl/glsl_parser_extras.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/glsl/glsl_parser_extras.cpp b/src/glsl/glsl_parser_extras.cpp index 27e3301..5772d13 100644 --- a/src/glsl/glsl_parser_extras.cpp +++ b/src/glsl/glsl_parser_extras.cpp @@ -29,6 +29,7 @@

[Mesa-dev] [PATCH 3/5] i965: Initialize INTEL_DEBUG once per process.

2014-11-26 Thread Matt Turner
--- src/mesa/drivers/dri/i965/intel_debug.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/intel_debug.c b/src/mesa/drivers/dri/i965/intel_debug.c index a283357..6391cf7 100644 --- a/src/mesa/drivers/dri/i965/intel_debug.c +++

[Mesa-dev] [PATCH 5/5] i965/fs: Clean up some whitespace in reg_allocate.

2014-11-26 Thread Matt Turner
--- src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp b/src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp index 44c74a3..0813f64 100644 ---

[Mesa-dev] [PATCH 1/9] scons: Remove dead code/comments.

2014-11-26 Thread jfonseca
From: José Fonseca jfons...@vmware.com - Remove no-op if-clause. - -mstackrealign has been enabled again on MinGW for quite some time and appears to work alright nowadays. - Drop -mmmx option as it is implied my -msse, and we don't use MMX intrinsics anyway. --- scons/gallium.py | 5 +

[Mesa-dev] [PATCH 4/9] draw, gallivm, llvmpipe: Avoid implicit casts of 32-bit shifts to 64-bits.

2014-11-26 Thread jfonseca
From: José Fonseca jfons...@vmware.com Addresses MSVC warnings result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?), which can often be symptom of bugs, but in these cases were all benign. --- src/gallium/auxiliary/draw/draw_llvm.c| 4 ++--

[Mesa-dev] [PATCH 7/9] mapi/glapi: Fix dll linkage of GLES1 symbols.

2014-11-26 Thread jfonseca
From: José Fonseca jfons...@vmware.com This fixes several MSVC warnings like: warning C4273: 'glClearColorx' : inconsistent dll linkage In fact, we should avoid using `declspec(dllexport)` altogether, and use exclusively the .DEF instead, which gives more precise control of which symbols must

[Mesa-dev] [PATCH 3/9] scons: Disable MSVC signed/unsigned mismatch warnings.

2014-11-26 Thread jfonseca
From: José Fonseca jfons...@vmware.com Unfortunately gcc completely ignores the issue, and as result code that mixes signed/unsigned is so widespread through the code base end up being little more than noise, potentially obscuring more pertinent warnings. This change disables them. ---

[Mesa-dev] [PATCH 2/9] scons: Generate SSE2 floating-point arithmetic.

2014-11-26 Thread jfonseca
From: José Fonseca jfons...@vmware.com - SSE2 is available on all x86 processors we care about. - It's recommended by Intel: https://software.intel.com/en-us/blogs/2012/09/26/gcc-x86-performance-hints - And has been the default since MSVC 2012:

[Mesa-dev] [PATCH 8/9] st/wgl: Don't export wglGetExtensionsStringARB.

2014-11-26 Thread jfonseca
From: José Fonseca jfons...@vmware.com It's not exported by the official opengl32.dll neither. Applications are supposed to get it via wglGetProcAddress(), not GetProcAddress(). --- src/gallium/state_trackers/wgl/opengl32.def | 1 - 1 file changed, 1 deletion(-) diff --git

[Mesa-dev] [PATCH 6/9] util/u_snprintf: Don't redefine HAVE_STDINT_H as 0.

2014-11-26 Thread jfonseca
From: José Fonseca jfons...@vmware.com We now always guarantee availability of stdint.h on MSVC -- if MSVC doesn't supply one we use our own. --- src/gallium/auxiliary/util/u_snprintf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/util/u_snprintf.c

[Mesa-dev] [PATCH 5/9] gallivm: Removed unused variable.

2014-11-26 Thread jfonseca
From: José Fonseca jfons...@vmware.com --- src/gallium/auxiliary/gallivm/lp_bld_tgsi_aos.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_tgsi_aos.c b/src/gallium/auxiliary/gallivm/lp_bld_tgsi_aos.c index 2ef5db1..738d5e9 100644 ---

[Mesa-dev] [PATCH 9/9] mesa/gdi: Don't pretend mesadef.py is auto generated.

2014-11-26 Thread jfonseca
From: José Fonseca jfons...@vmware.com Just use the same entrypoints we use for st/wgl's opengl32.dll. --- src/mesa/drivers/windows/gdi/mesa.def | 839 -- 1 file changed, 192 insertions(+), 647 deletions(-) diff --git a/src/mesa/drivers/windows/gdi/mesa.def

Re: [Mesa-dev] [PATCH 4/5] ra: Don't use regs as the ralloc context.

2014-11-26 Thread Jason Ekstrand
On Wed, Nov 26, 2014 at 10:39 AM, Matt Turner matts...@gmail.com wrote: The i965 backends pass something out of 'screen', which is allocated per-process, making using this as a ralloc context not thread-safe. All callers ra_alloc_interference_graph() already ralloc_free() its return value.

Re: [Mesa-dev] [PATCH 4/5] ra: Don't use regs as the ralloc context.

2014-11-26 Thread Matt Turner
On Wed, Nov 26, 2014 at 10:56 AM, Jason Ekstrand ja...@jlekstrand.net wrote: On Wed, Nov 26, 2014 at 10:39 AM, Matt Turner matts...@gmail.com wrote: The i965 backends pass something out of 'screen', which is allocated per-process, making using this as a ralloc context not thread-safe. All

Re: [Mesa-dev] [PATCH 2/5] i965: Initialize compaction tables once per process.

2014-11-26 Thread Jason Ekstrand
On Wed, Nov 26, 2014 at 10:39 AM, Matt Turner matts...@gmail.com wrote: --- src/mesa/drivers/dri/i965/brw_eu_compact.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_eu_compact.c b/src/mesa/drivers/dri/i965/brw_eu_compact.c index 7117890..8e33bcb

Re: [Mesa-dev] [PATCH 9/9] mesa/gdi: Don't pretend mesadef.py is auto generated.

2014-11-26 Thread Matt Turner
On Wed, Nov 26, 2014 at 10:47 AM, jfons...@vmware.com wrote: From: José Fonseca jfons...@vmware.com Just use the same entrypoints we use for st/wgl's opengl32.dll. --- Subject: s/mesadef.py/mesa.def/ If mesadef.py is indeed dead after this, maybe you'd like to grab the patch that deletes it

Re: [Mesa-dev] [PATCH 4/5] ra: Don't use regs as the ralloc context.

2014-11-26 Thread Jason Ekstrand
On Wed, Nov 26, 2014 at 10:59 AM, Matt Turner matts...@gmail.com wrote: On Wed, Nov 26, 2014 at 10:56 AM, Jason Ekstrand ja...@jlekstrand.net wrote: On Wed, Nov 26, 2014 at 10:39 AM, Matt Turner matts...@gmail.com wrote: The i965 backends pass something out of 'screen', which is

Re: [Mesa-dev] [PATCH 1/9] scons: Remove dead code/comments.

2014-11-26 Thread Brian Paul
The series LGTM. Reviewed-by: Brian Paul bri...@vmware.com On 11/26/2014 11:47 AM, jfons...@vmware.com wrote: From: José Fonseca jfons...@vmware.com - Remove no-op if-clause. - -mstackrealign has been enabled again on MinGW for quite some time and appears to work alright nowadays. -

Re: [Mesa-dev] [PATCH 2/5] i965: Initialize compaction tables once per process.

2014-11-26 Thread Matt Turner
On Wed, Nov 26, 2014 at 10:59 AM, Jason Ekstrand ja...@jlekstrand.net wrote: On Wed, Nov 26, 2014 at 10:39 AM, Matt Turner matts...@gmail.com wrote: --- src/mesa/drivers/dri/i965/brw_eu_compact.c | 5 + 1 file changed, 5 insertions(+) diff --git

Re: [Mesa-dev] [PATCH 3/9] scons: Disable MSVC signed/unsigned mismatch warnings.

2014-11-26 Thread Jan Vesely
On Wed, 2014-11-26 at 18:47 +, jfons...@vmware.com wrote: From: José Fonseca jfons...@vmware.com Unfortunately gcc completely ignores the issue, and as result code that mixes signed/unsigned is so widespread through the code base end up being little more than noise, potentially obscuring

Re: [Mesa-dev] [PATCH 2/5] i965: Initialize compaction tables once per process.

2014-11-26 Thread Jason Ekstrand
On Wed, Nov 26, 2014 at 11:10 AM, Matt Turner matts...@gmail.com wrote: On Wed, Nov 26, 2014 at 10:59 AM, Jason Ekstrand ja...@jlekstrand.net wrote: On Wed, Nov 26, 2014 at 10:39 AM, Matt Turner matts...@gmail.com wrote: --- src/mesa/drivers/dri/i965/brw_eu_compact.c | 5 + 1

Re: [Mesa-dev] [PATCH 3/9] scons: Disable MSVC signed/unsigned mismatch warnings.

2014-11-26 Thread Roland Scheidegger
Am 26.11.2014 um 19:47 schrieb jfons...@vmware.com: From: José Fonseca jfons...@vmware.com Unfortunately gcc completely ignores the issue, and as result code that mixes signed/unsigned is so widespread through the code base end up being little more than noise, potentially obscuring more

Re: [Mesa-dev] [PATCH 4/9] draw, gallivm, llvmpipe: Avoid implicit casts of 32-bit shifts to 64-bits.

2014-11-26 Thread Roland Scheidegger
I guess we could do explicit cast after the shift but we probably don't care enough about the slight performance hit on 32bit platforms (though actually some compilers might be smart enough to figure out a 32bit shift is really all that's needed). In any case, for the series: Reviewed-by: Roland

Re: [Mesa-dev] [PATCH 3/9] scons: Disable MSVC signed/unsigned mismatch warnings.

2014-11-26 Thread Emil Velikov
On 26/11/14 19:16, Jan Vesely wrote: On Wed, 2014-11-26 at 18:47 +, jfons...@vmware.com wrote: From: José Fonseca jfons...@vmware.com Unfortunately gcc completely ignores the issue, and as result code that mixes signed/unsigned is so widespread through the code base end up being little

Re: [Mesa-dev] [PATCH 3/9] scons: Disable MSVC signed/unsigned mismatch warnings.

2014-11-26 Thread Jose Fonseca
On 26/11/14 19:16, Jan Vesely wrote: On Wed, 2014-11-26 at 18:47 +, jfons...@vmware.com wrote: From: José Fonseca jfons...@vmware.com Unfortunately gcc completely ignores the issue, and as result code that mixes signed/unsigned is so widespread through the code base end up being little

[Mesa-dev] [PATCH 2/2] glsl: Use | action in the lexer source to avoid duplicating the float action

2014-11-26 Thread Neil Roberts
Flex and lex have a special action ‘|’ which means to use the same action as the next rule. We can use this to reduce a bit of code duplication in the rules for the various float literal formats. --- src/glsl/glsl_lexer.ll | 15 +++ 1 file changed, 3 insertions(+), 12 deletions(-)

[Mesa-dev] [PATCH 1/2] glsl: Disallow float literals with the 'f' suffix but no point or exponent

2014-11-26 Thread Neil Roberts
According to the GLSL spec float literals like ‘1f’ shouldn't be allowed without adding a decimal point or an exponent. Apparently the AMD driver also disallows this so it seems unlikely that anything would be relying on it. --- This was discussed here:

Re: [Mesa-dev] [PATCH 3/3] glapi: Remove dead mesadef.py.

2014-11-26 Thread Jose Fonseca
Reviewed-by: Jose Fonseca jfons...@vmware.com On 21/11/14 18:35, Matt Turner wrote: Dead since commit 4e120c97, in which apiparser (which mesadef.py imports) was removed. --- src/mapi/glapi/gen/Makefile.am | 1 - src/mapi/glapi/gen/mesadef.py | 215

Re: [Mesa-dev] [PATCH 9/9] mesa/gdi: Don't pretend mesadef.py is auto generated.

2014-11-26 Thread Jose Fonseca
On 26/11/14 19:01, Matt Turner wrote: On Wed, Nov 26, 2014 at 10:47 AM, jfons...@vmware.com wrote: From: José Fonseca jfons...@vmware.com Just use the same entrypoints we use for st/wgl's opengl32.dll. --- Subject: s/mesadef.py/mesa.def/ Ah, yes. If mesadef.py is indeed dead after this,

Re: [Mesa-dev] [PATCH 9/9] mesa/gdi: Don't pretend mesadef.py is auto generated.

2014-11-26 Thread Matt Turner
On Wed, Nov 26, 2014 at 12:14 PM, Jose Fonseca jfons...@vmware.com wrote: On 26/11/14 19:01, Matt Turner wrote: On Wed, Nov 26, 2014 at 10:47 AM, jfons...@vmware.com wrote: From: José Fonseca jfons...@vmware.com Just use the same entrypoints we use for st/wgl's opengl32.dll. ---

Re: [Mesa-dev] [Mesa-stable] [PATCH v3 01/19] st/nine: clean device9ex.

2014-11-26 Thread Emil Velikov
Hi guys, I've picked up patches 1-10 13 for master. Afaict there is still a comment on two on the topic of queries, so I'll leave these out for now. Patches 12 does not seem to be mesa-stable material based on the commit message, yet they seem to be a requirement for #3. Can you add a couple of

Re: [Mesa-dev] [PATCH 1/2] glsl: Disallow float literals with the 'f' suffix but no point or exponent

2014-11-26 Thread Matt Turner
On Wed, Nov 26, 2014 at 12:02 PM, Neil Roberts n...@linux.intel.com wrote: According to the GLSL spec float literals like ‘1f’ shouldn't be allowed without adding a decimal point or an exponent. Apparently the AMD driver also disallows this so it seems unlikely that anything would be relying on

Re: [Mesa-dev] [PATCH] r600: fix texture gradients instruction emission (v2)

2014-11-26 Thread Emil Velikov
Hello Dave, Cherry picking this commit for the 10.3 branch resulted in a number of non-trivial conflicts. Can you or anyone else familiar with the code backport this for 10.3 ? Thanks Emil On 18/11/14 22:53, Dave Airlie wrote: From: Dave Airlie airl...@redhat.com The piglit tests were

Re: [Mesa-dev] [PATCH] r600g: do all CUBE ALU operations before gradient texture operations (v2)

2014-11-26 Thread Emil Velikov
Hello Dave, Cherry picking this commit for the 10.3 branch resulted in a number of non-trivial conflicts. Can you or anyone else familiar with the code backport this for 10.3 ? Thanks Emil On 24/11/14 00:32, Dave Airlie wrote: From: Dave Airlie airl...@redhat.com This moves all the CUBE

Re: [Mesa-dev] [Mesa-stable] [PATCH v3 01/19] st/nine: clean device9ex.

2014-11-26 Thread Axel Davy
Thanks, patch 1 is not needed for patch 2 and 3. As for patch 2, I'm 99% sure it's not needed for patch 3. Axel On 26/11/2014 21:14, Emil Velikov wrote : Hi guys, I've picked up patches 1-10 13 for master. Afaict there is still a comment on two on the topic of queries, so I'll leave these

Re: [Mesa-dev] [PATCH V2] mesa: Permanently enable features supported by target CPU at compile time.

2014-11-26 Thread Emil Velikov
On 21/11/14 09:02, Siavash Eliasi wrote: On 11/10/2014 04:28 AM, Emil Velikov wrote: I'm not sure did you just said that you've checked it, or that's what it ought to do ? There is a reason why I'm so picky - this bizarre (as one might call it) setup is just the tip of the iceberg when it

Re: [Mesa-dev] [PATCH] util/hash_table: Rework the API to know about hashing

2014-11-26 Thread Eric Anholt
Timothy Arceri t_arc...@yahoo.com.au writes: On the subject of the hash table performance I spent way to much time looking into this recently. In the end it was taking up to much time benchmarking and profiling for what it was worth (at least in my test cases) so I've moved on for now. However

Re: [Mesa-dev] [PATCH] r600g: merge the TXQ and BUFFER constant buffers

2014-11-26 Thread Glenn Kennard
On Mon, 24 Nov 2014 04:36:06 +0100, Dave Airlie airl...@gmail.com wrote: From: Dave Airlie airl...@redhat.com We are using 1 more buffer than we have, although in the future the driver should just end up using one buffer in total probably, this is a good first step, it merges the txq cube

Re: [Mesa-dev] [PATCH] Set llvmpipe and softpipe note only for MSAA.

2014-11-26 Thread Romain Failliot
Hi! I'm not familiar with the patch and merge process, I just wonder if it is normal that my patch isn't merged yet (it's been more than 20 days). I can wait, but I just want to be sure I'm not waiting for nothing :D Thanks! 2014-11-03 6:02 GMT-05:00 Roland Scheidegger srol...@vmware.com: Am

[Mesa-dev] [PATCH] [RFC] MESA_shading_language_130: is this it?

2014-11-26 Thread Dave Airlie
Glamor is 4x faster on my ILK using glsl 130 at core text using x11perf -ftext. Ian started writing a spec for this extension a while back, which seems like most of the work, this patch seems to do enough, to advertise GLSL 1.30. TODO: fix extension numbering get piglit to execute tests on this

Re: [Mesa-dev] [PATCH 1/2] glsl: Disallow float literals with the 'f' suffix but no point or exponent

2014-11-26 Thread Iago Toral
Thanks Neil! I was planning to fix this once I was done with the format conversion stuff, so you saved me some work :) I tested the patch and it fixes the following dEQP tests: dEQP-GLES3.functional.shaders.constants.float_int_f_suffix_0_vertex