[Mesa-dev] [PATCH] st/mesa: avoid exposing EXT_texture_integer for pre-GLSL 1.30

2014-11-29 Thread Ilia Mirkin
For drivers building up to GL(ES)3, only expose the actual extension if the API will let it be used (e.g. via overrides/debug flags that enable higher versions). Signed-off-by: Ilia Mirkin --- Technically this can also be used with EXT_gpu_shader4 and NV_gpu_shader4, neither of which mesa suppor

[Mesa-dev] [PATCH 1/3] glsl: Disallow `pragma STDGL invariant(all)` in fragment shaders

2014-11-29 Thread Chris Forbes
Fixes the piglit test: spec/glsl-es-3.00/compiler/invariant_all.frag Signed-off-by: Chris Forbes --- src/glsl/glsl_parser.yy | 4 1 file changed, 4 insertions(+) diff --git a/src/glsl/glsl_parser.yy b/src/glsl/glsl_parser.yy index dbab815..6592a84 100644 --- a/src/glsl/glsl_parser.yy +++ b

[Mesa-dev] [PATCH 2/3] glcpp: Disallow undefining GL_* builtin macros.

2014-11-29 Thread Chris Forbes
Fixes the piglit test: spec/glsl-es-3.00/compiler/undef-GL_ES.vert Signed-off-by: Chris Forbes --- src/glsl/glcpp/glcpp-parse.y | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/glsl/glcpp/glcpp-parse.y b/src/glsl/glcpp/glcpp-parse.y index e0ec3b6..bd34faf 100644 --- a/sr

[Mesa-dev] [PATCH 3/3] glsl: Disallow use of interface block names for other purposes

2014-11-29 Thread Chris Forbes
Fixes the piglit tests: spec/glsl-1.50/compiler/interface-blocks-name-reused-globally* The error reporting is still poor in some cases (where the grammar enforces use of a new identifier, for example). Signed-off-by: Chris Forbes --- src/glsl/glsl_symbol_table.cpp | 4 1 file changed, 4 in

Re: [Mesa-dev] [PATCH] i965: avoid anonymous struct in float <-> VF conversions

2014-11-29 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] sampler types in tgsi

2014-11-29 Thread Ilia Mirkin
Adding "DCL SVIEW[0], 2D, UINT" would be precisely what I need. I just wanted to clarify that what Marek is talking about is way more complex than what my immediate needs are. However ARB_shader_image_load_store is "around the corner", so probably should start thinking about it. I had already impl

Re: [Mesa-dev] sampler types in tgsi

2014-11-29 Thread Jose Fonseca
Why can't you just get the type information from the t#0's declaration in this case too, as I was suggesting? Jose From: ibmir...@gmail.com [ibmir...@gmail.com] on behalf of Ilia Mirkin [imir...@alum.mit.edu] Sent: 29 November 2014 18:05 To: Marek Olšák

Re: [Mesa-dev] sampler types in tgsi

2014-11-29 Thread Ilia Mirkin
This is the next level of sophistication... to be clear I was talking about distinguishing sampler2D from isampler2D in glsl (and, if possible usampler2D, but I'm pretty sure that wouldn't actually matter). The issue is that the instructions are like sam (f32)(xyzw)r0.x, r0.z, s#0, t#0 vs sam (u

Re: [Mesa-dev] [PATCH 2/2] clover: clCompileProgram CL_INVALID_COMPILER_OPTIONS

2014-11-29 Thread EdB
On Monday 10 November 2014 19:04:54 Francisco Jerez wrote: > EdB writes: > > clCompileProgram should return CL_INVALID_COMPILER_OPTIONS > > instead of CL_INVALID_BUILD_OPTIONS > > Looks good to me, > Reviewed-by: Francisco Jerez I don't have commit access. Can someone push it for me? > > > --

[Mesa-dev] [PATCH 1/2 v2] clover: add CL_MEM_HOST_* flags checks

2014-11-29 Thread EdB
those flags have been introduced in OpenCL 1.2 --- src/gallium/state_trackers/clover/api/memory.cpp | 15 -- src/gallium/state_trackers/clover/api/transfer.cpp | 32 -- 2 files changed, 42 insertions(+), 5 deletions(-) diff --git a/src/gallium/state_trackers/clover/a

Re: [Mesa-dev] [PATCH] ir_to_mesa: Don't optimize clamp into saturate when target is GL_VERTEX_PROGRAM_ARB

2014-11-29 Thread Marek Olšák
FYI, if you use saturate in a vertex shader on r300-r400 (SM2), it will fail to compile. Marek On Sat, Nov 29, 2014 at 11:10 AM, Kenneth Graunke wrote: > On Thursday, November 27, 2014 10:45:00 AM Abdiel Janulgue wrote: >> Add the the same restriction as in the previous try_emit_sat when trying

Re: [Mesa-dev] sampler types in tgsi

2014-11-29 Thread Marek Olšák
GLSL allows specifying sampler formats in shaders too, but it only appears to be allowed for GL_ARB_shader_image_load_store and it must match the sample view format, so that drivers can ignore it if they want. The format specification is complete except for component ordering. e.g. a shader can dec

Re: [Mesa-dev] [PATCH] ir_to_mesa: Don't optimize clamp into saturate when target is GL_VERTEX_PROGRAM_ARB

2014-11-29 Thread Kenneth Graunke
On Thursday, November 27, 2014 10:45:00 AM Abdiel Janulgue wrote: > Add the the same restriction as in the previous try_emit_sat when trying > to optimize clamp. Fixes an infinite loop in swrast where the lowering > pass unpacks saturate into clamp but the opt_algebraic pass tries to do > the oppos

[Mesa-dev] [PATCH] i965: avoid anonymous struct in float <-> VF conversions

2014-11-29 Thread Jonathan Gray
Anonymous structures are only supported with newer versions of GCC. They will not work with GCC 4.2.1 used by OpenBSD or GCC 4.4.7 shipped with RHEL6 going by a commit to fix a similiar problem in radeonsi earlier in the year (74388dd24bc7fdb9e62ec18096163f5426e03fbf). Signed-off-by: Jonathan Gra