Thomas Helland thomashellan...@gmail.com writes:
2015-02-02 19:18 GMT+01:00 Jason Ekstrand ja...@jlekstrand.net:
Hi all,
I wanted to send out a quick message about naming conventions for mesa
entrypoints and dd table fallbacks. There has been some confusion and
disagreement about this with
On 02/02/2015 12:49 PM, Laura Ekstrand wrote:
After a very thorough search, I did find two lines in i965/intel_fbo.c
that had ctx-DrawBuffer when they were supposed to have drawFb. Here's
the new commit:
I wanted to use it for nir-to-tgsi. The equivalent ureg_src_register() is
also located here.
---
src/gallium/auxiliary/tgsi/tgsi_ureg.c | 28
src/gallium/auxiliary/tgsi/tgsi_ureg.h | 25 +
2 files changed, 25 insertions(+), 28 deletions(-)
Am 02.02.2015 um 20:39 schrieb Eric Anholt:
I wanted all of these for NIR-to-TGSI.
---
src/gallium/auxiliary/tgsi/tgsi_opcode_tmp.h | 4
1 file changed, 4 insertions(+)
diff --git a/src/gallium/auxiliary/tgsi/tgsi_opcode_tmp.h
b/src/gallium/auxiliary/tgsi/tgsi_opcode_tmp.h
index
Oops, what I meant to say was Make the bufferobj lookup function static.
The lookup transform feedback function doesn't have to be static.
On Mon, Feb 2, 2015 at 6:09 AM, Ilia Mirkin imir...@alum.mit.edu wrote:
On Mon, Feb 2, 2015 at 6:00 AM, Martin Peres
martin.pe...@linux.intel.com wrote:
On Mon, Feb 2, 2015 at 3:30 AM, Martin Peres martin.pe...@linux.intel.com
wrote:
v2: review from Laura Ekstrand
- use the refactored code to lookup the objects
- improve some error messages
- factor out the gl method name computation
- better handle the spec differences between the DSA and
On Mon, Feb 2, 2015 at 2:58 AM, Martin Peres martin.pe...@linux.intel.com
wrote:
v2: Review from Laura Ekstrand
- generate the name of the gl method once
- shorten some lines to stay in the 78 chars limit
v3: Review from Fredrik Höglund fred...@kde.org
- rename gl_mthd_name to func
- set
I wanted all of these for NIR-to-TGSI.
---
src/gallium/auxiliary/tgsi/tgsi_opcode_tmp.h | 4
1 file changed, 4 insertions(+)
diff --git a/src/gallium/auxiliary/tgsi/tgsi_opcode_tmp.h
b/src/gallium/auxiliary/tgsi/tgsi_opcode_tmp.h
index 147d989..d8752ce 100644
---
Eric Anholt e...@anholt.net writes:
Francisco Jerez curroje...@riseup.net writes:
This reverts commit 3fad0868f023f1d726e230968a4df3327de38823.
This test doesn't make any sense to me, it begins quoting the GLSL
1.30 spec on the interaction of the discard keyword with control flow:
[...]
2015-02-02 19:18 GMT+01:00 Jason Ekstrand ja...@jlekstrand.net:
Hi all,
I wanted to send out a quick message about naming conventions for mesa
entrypoints and dd table fallbacks. There has been some confusion and
disagreement about this with some of the stuff Laura has been doing to
After a very thorough search, I did find two lines in i965/intel_fbo.c that
had ctx-DrawBuffer when they were supposed to have drawFb. Here's the new
commit:
http://cgit.freedesktop.org/~ldeks/mesa/commit/?h=adsa-framebuffersid=d9d7e65cd6a0fe2c864803a77e34d0f52e8609b6
.
Roland Scheidegger srol...@vmware.com writes:
Am 02.02.2015 um 20:39 schrieb Eric Anholt:
I wanted all of these for NIR-to-TGSI.
---
src/gallium/auxiliary/tgsi/tgsi_opcode_tmp.h | 4
1 file changed, 4 insertions(+)
diff --git a/src/gallium/auxiliary/tgsi/tgsi_opcode_tmp.h
On 02/02/2015 12:22 PM, Eric Anholt wrote:
Jason Ekstrand ja...@jlekstrand.net writes:
Hi all,
I wanted to send out a quick message about naming conventions for mesa
entrypoints and dd table fallbacks. There has been some confusion and
disagreement about this with some of the stuff Laura has
Erik Faye-Lund kusmab...@gmail.com writes:
On Sun, Feb 1, 2015 at 10:17 PM, Eric Anholt e...@anholt.net wrote:
This could be done in a separate pass like we do in GLSL IR, but it seems
to me like having the definitions of the transformations in the two
directions next to each other makes a
https://bugs.freedesktop.org/show_bug.cgi?id=79629
fangxun xunx.f...@intel.com changed:
What|Removed |Added
Status|NEW |RESOLVED
A few comments here...
1. We should really split this up into a patch that adds
nir_shader_compiler_options (which would be empty at this point) and
the nir_algebraic infrastructure for conditionalizing transforms
(actually, maybe we should split these up into two patches) and a
patch which adds
This will be used to give the optimization passes a chance to customize
behavior for the particular target device.
---
I had things as one giant patch before because I thought you couldn't
have a struct with no members, and having a temporary version with a
dummy member seemed ugly. Turns out
This will be used so that we can customize the transforms for the target
GPU, so we don't un-lower expressions that had already been lowered (or
introduce new lowering transformations that not all GPUs want)
---
src/glsl/nir/nir_algebraic.py | 44 ---
1
On 02/02/2015 07:18 PM, Jason Ekstrand wrote:
1) The entrypoint itself (currently _mesa_EntryPoint)
2) the internal entrypoint (Laura chose _mesa_entry_point)
3) the software fallback for the DD table entry (Laura chose
_mesa_TableEntry_sw)
I already objected to _mesa_TableEntry_sw because
https://bugs.freedesktop.org/show_bug.cgi?id=0
--- Comment #1 from Matt Turner matts...@gmail.com ---
Would be nice to explain why you decided the bug was invalid.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
Connor Abbott cwabbo...@gmail.com writes:
I mentioned this on IRC, but it would be good to add the ability to
append the sequence of instructions before/after an instruction as
well as at the beginning or end of a basic block. We would need to
store the current basic block, the current
Connor Abbott cwabbo...@gmail.com writes:
A few comments here...
1. We should really split this up into a patch that adds
nir_shader_compiler_options (which would be empty at this point) and
the nir_algebraic infrastructure for conditionalizing transforms
(actually, maybe we should split
Unclear circumstances lead to undefined symbols on x86.
Bugzilla: https://bugs.gentoo.org/show_bug.cgi?id=536916
---
src/gallium/auxiliary/util/u_math.h | 4
1 file changed, 4 deletions(-)
diff --git a/src/gallium/auxiliary/util/u_math.h
b/src/gallium/auxiliary/util/u_math.h
index
---
src/glsl/list.h | 4
1 file changed, 4 insertions(+)
diff --git a/src/glsl/list.h b/src/glsl/list.h
index 85368a4..6f1a57b 100644
--- a/src/glsl/list.h
+++ b/src/glsl/list.h
@@ -51,6 +51,10 @@
* Therefore, if \c head-next is \c NULL or \c tail_prev-prev is \c NULL,
* the list is
On Mon, Feb 2, 2015 at 5:30 PM, Ilia Mirkin imir...@alum.mit.edu wrote:
Reviewed-by: Ilia Mirkin imir...@alum.mit.edu
Oh well. Nothing requiring high throughput uses this afaik... constant
folding in nouveau (for the relevant glsl instruction), that's
probably about it. Would be nice to
https://bugs.freedesktop.org/show_bug.cgi?id=79629
fangxun xunx.f...@intel.com changed:
What|Removed |Added
Status|RESOLVED|VERIFIED
--- Comment #11
On Mon, Feb 2, 2015 at 2:38 PM, Ian Romanick i...@freedesktop.org wrote:
On 02/02/2015 07:18 PM, Jason Ekstrand wrote:
1) The entrypoint itself (currently _mesa_EntryPoint)
2) the internal entrypoint (Laura chose _mesa_entry_point)
3) the software fallback for the DD table entry (Laura
Emil Velikov, le Mon 02 Feb 2015 18:24:29 +, a écrit :
Did you had the change to try the patch - does it cause issues on your
setup (build and/or runtime-wise) ?
My setup has neither HAVE_LIBDRM nor HAVE_DRM_PLATFORM so it can't break
it :)
Samuel
Previously PTHREAD_MUTEX_RECURSIVE_NP had been used on linux for
compatibility with old glibc. Since mesa defines __GNU_SOURCE__
on linux PTHREAD_MUTEX_RECURSIVE is also available since at least
1998. So we can unconditionally use the portable version
PTHREAD_MUTEX_RECURSIVE.
---
Previous patch
Reviewed-by: Ilia Mirkin imir...@alum.mit.edu
Oh well. Nothing requiring high throughput uses this afaik... constant
folding in nouveau (for the relevant glsl instruction), that's
probably about it. Would be nice to clarify the circumstances, but...
wtvr. Cc 10.4 stable too?
On Mon, Feb 2, 2015
You're welcome Marek. Let's not keep these workarounds specific to some
drivers ;)
In any case, please review the new version, the one called introduce
the equivalent of MESA_EXTENSION_OVERRIDE to drirc. I prefer this
solution better and this one should be dropped.
Sorry for the noise.
v2: Review from Laura Ekstrand
- give more helpful error messages
- factor the lookup code for the xfb and objBuf
- replace some already-existing tabs with spaces
- add comments to explain the cases where xfb == 0 or buffer == 0
- fix the condition for binding the transform buffer or not
v3:
On 02/02/15 11:54, Michel Dänzer wrote:
On 30.01.2015 23:19, Martin Peres wrote:
When both MESA_EXTENSION_OVERRIDE and drirc's mesa_extension_override are
set, the environment variable takes precedence.
This will be used to fix Unigine Tropics and Sanctuary.
Signed-off-by: Martin Peres
On Mon, Feb 2, 2015 at 6:00 AM, Martin Peres
martin.pe...@linux.intel.com wrote:
+static struct gl_transform_feedback_object *
+_mesa_lookup_transform_feedback_object_err(struct gl_context *ctx,
+ GLuint xfb, const char* func)
+{
+ struct
On 30/01/15 23:20, Marek Olšák wrote:
The commit message prefix should be intel: in this case.
Marek
Fair point, it will be in v2.
Thanks,
Martin
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
On 30.01.2015 23:19, Martin Peres wrote:
When both MESA_EXTENSION_OVERRIDE and drirc's mesa_extension_override are
set, the environment variable takes precedence.
This will be used to fix Unigine Tropics and Sanctuary.
Signed-off-by: Martin Peres martin.pe...@linux.intel.com
[...]
diff
v2: review from Laura Ekstrand
- use the refactored code to lookup the objects
- improve some error messages
- factor out the gl method name computation
- better handle the spec differences between the DSA and non-DSA cases
- quote the spec a little more
v3: review from Laura Ekstrand
- use the
On Sun, Feb 1, 2015 at 10:17 PM, Eric Anholt e...@anholt.net wrote:
This could be done in a separate pass like we do in GLSL IR, but it seems
to me like having the definitions of the transformations in the two
directions next to each other makes a lot of sense.
---
v2: Review from Laura Ekstrand
- generate the name of the gl method once
- shorten some lines to stay in the 78 chars limit
v3: Review from Fredrik Höglund fred...@kde.org
- rename gl_mthd_name to func
- set EverBound in _mesa_create_transform_feedbacks in the dsa case
Signed-off-by: Martin
From: Dave Airlie airl...@redhat.com
Like the RGTC code sharing this could be done nicer in the util lib.
This slighty increase i965_dri.so size by ~100 bytes,
but it decreases the combined gallium driver by over 1k,
and its just nicer to avoid TAG().
Signed-off-by: Dave Airlie
On Thursday, January 29, 2015 01:40:19 PM Jason Ekstrand wrote:
Now that we can scalarize with NIR, there's no need for all this code
anymore. Let's get rid of it and just do scalar operations.
v2: run copy prop before lowering phi nodes
v3: Get rid of the emit(...)-saturate = foo pattern
On Mon, Feb 2, 2015 at 9:08 PM, Kenneth Graunke kenn...@whitecape.org
wrote:
On Thursday, January 29, 2015 01:40:18 PM Jason Ekstrand wrote:
[snip]
diff --git a/src/glsl/nir/nir_lower_phis_to_scalar.c
b/src/glsl/nir/nir_lower_phis_to_scalar.c
new file mode 100644
index 000..bf65f5a
GLX_ARB_create_context spec says:
If either draw or read are not a valid GLX drawable, a GLXBadDrawable
error is generated, unless draw and read are both None and the OpenGL
version supported by ctx is 3.0 or greater.
So when both draw and read are None, it could pass NULL drawable into
driver
https://bugs.freedesktop.org/show_bug.cgi?id=88930
Bug ID: 88930
Summary: [osmesa] osbuffer-textures should be indexed by
attachment type
Product: Mesa
Version: git
Hardware: All
OS: All
Status:
On Mon, 2015-02-02 at 13:22 -0800, Eric Anholt wrote:
Thomas Helland thomashellan...@gmail.com writes:
2015-02-02 19:18 GMT+01:00 Jason Ekstrand ja...@jlekstrand.net:
Hi all,
I wanted to send out a quick message about naming conventions for mesa
entrypoints and dd table fallbacks.
Hi Felix,
On 2 February 2015 at 19:04, Felix Janda felix.ja...@posteo.de wrote:
Previously PTHREAD_MUTEX_RECURSIVE_NP had been used on linux for
compatibility with old glibc. Since mesa defines __GNU_SOURCE__
on linux PTHREAD_MUTEX_RECURSIVE is also available since at least
1998. So we can
On Thursday, January 29, 2015 01:40:20 PM Jason Ekstrand wrote:
Originally, get_alu_src was supposed to handle resolving swizzles and
things like that. However, now that basically every instruction we have
only takes scalar sources, we don't really need it anymore. The only case
where it's
On Mon, Dec 8, 2014 at 9:50 PM, Ben Widawsky b...@bwidawsk.net wrote:
Thanks. All the requests look good, and I'll post it in v3.
What happened to this patch? It was pretty close... should be easy to
add gallium support for it too once it's in...
___
On Thursday, January 29, 2015 01:40:18 PM Jason Ekstrand wrote:
[snip]
diff --git a/src/glsl/nir/nir_lower_phis_to_scalar.c
b/src/glsl/nir/nir_lower_phis_to_scalar.c
new file mode 100644
index 000..bf65f5a
--- /dev/null
+++ b/src/glsl/nir/nir_lower_phis_to_scalar.c
@@ -0,0 +1,278 @@
On Mon, Feb 2, 2015 at 10:00 PM, Kenneth Graunke kenn...@whitecape.org
wrote:
On Thursday, January 29, 2015 01:40:20 PM Jason Ekstrand wrote:
Originally, get_alu_src was supposed to handle resolving swizzles and
things like that. However, now that basically every instruction we have
only
Acked-by: Brian Paul bri...@vmware.com
On 01/29/2015 02:11 PM, Rob Clark wrote:
From: Rob Clark robcl...@freedesktop.org
Enable the 'sphinx.ext.graphviz' extension, and add in a section for
driver specific docs, with freedreno compiler docs beneath. The
goal is for more complete compiler
Please add some bit about this in screen.rst gallium docs.
Other than that 4/6 and 5/6 are
Reviewed-by: Roland Scheidegger srol...@vmware.com
Am 01.02.2015 um 16:18 schrieb Ilia Mirkin:
Signed-off-by: Ilia Mirkin imir...@alum.mit.edu
---
src/gallium/drivers/freedreno/freedreno_screen.c | 1 +
I'd have put the swrast whitespace changes in a separate commit, but
it's not a big deal.
Reviewed-by: Brian Paul bri...@vmware.com
On 01/30/2015 05:25 PM, Laura Ekstrand wrote:
In preparation for glBlitNamedFramebuffer, the DD table function
BlitFramebuffer needs to accept two arbitrary
For 1-4, Reviewed-by: Brian Paul bri...@vmware.com
On 02/01/2015 10:15 AM, Marek Olšák wrote:
From: Marek Olšák marek.ol...@amd.com
---
src/gallium/auxiliary/tgsi/tgsi_parse.c | 12
src/gallium/auxiliary/tgsi/tgsi_parse.h | 2 ++
I don't think this is really correct. llvmpipe will return all zeros on
purpose, because this is d3d10 behavior (and dummy textures cannot work
correctly with d3d10). Traditionally both d3d9 and gl state trackers
used dummy textures, though I'm unsure what values they required (if
any). (For d3d9
This removes phi nodes whose sources all point to the same thing.
Only compile tested.
Signed-off-by: Connor Abbott cwabbo...@gmail.com
---
src/glsl/Makefile.sources | 1 +
src/glsl/nir/nir.h | 2 +
src/glsl/nir/nir_opt_remove_phis.c | 111
Signed-off-by: Connor Abbott cwabbo...@gmail.com
---
src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp
b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp
index de0d780..4305e14 100644
---
On Monday, February 02, 2015 10:28:22 PM Jason Ekstrand wrote:
On Mon, Feb 2, 2015 at 9:08 PM, Kenneth Graunke kenn...@whitecape.org
wrote:
On Thursday, January 29, 2015 01:40:18 PM Jason Ekstrand wrote:
[snip]
+static bool
+is_phi_src_scalarizable(nir_phi_src *src,
+
On Tue, Feb 3, 2015 at 1:54 AM, Connor Abbott cwabbo...@gmail.com wrote:
This removes phi nodes whose sources all point to the same thing.
Only compile tested.
Signed-off-by: Connor Abbott cwabbo...@gmail.com
---
src/glsl/Makefile.sources | 1 +
src/glsl/nir/nir.h
Actually, since ARB_robust_buffer_access_behavior, GL requires some
specfic values, but it's - odd...
In all the above cases, if the context was created with robust buffer
access enabled then instead of undefined behavior the result of the
texel fetch is zero. For the case of a texel fetch on an
On Mon, Feb 2, 2015 at 9:53 AM, Jason Ekstrand ja...@jlekstrand.net wrote:
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=88841
---
src/mesa/drivers/dri/i965/intel_pixel_read.c | 7 +++
src/mesa/drivers/dri/i965/intel_tex_image.c | 7 +++
2 files changed, 14 insertions(+)
Hi all,
I wanted to send out a quick message about naming conventions for mesa
entrypoints and dd table fallbacks. There has been some confusion and
disagreement about this with some of the stuff Laura has been doing to
implement DSA. Instead of side-track one of those patches for this
I broke out some of the whitespace:
http://cgit.freedesktop.org/~ldeks/mesa/commit/?h=adsa-framebuffersid=ebe159fa9a6b1d98d63862bf89044028e67a4377
.
Here is the (hopefully cleaner) BlitFramebuffers refactor:
On 22/01/15 20:53, Samuel Thibault wrote:
Emil Velikov, le Thu 22 Jan 2015 16:52:06 +, a écrit :
On 14/01/15 19:36, Axel Davy wrote:
To fix build when libdrm is not found,
commit a594cec7e3ef275c386054127a357110a19dd823 did put several
parts of egl code under #ifdef HAVE_DRM_PLATFORM.
https://bugs.freedesktop.org/show_bug.cgi?id=0
Heinrich Schuchardt xypron.g...@gmx.de changed:
What|Removed |Added
Status|NEW |RESOLVED
Francisco Jerez curroje...@riseup.net writes:
Eric Anholt e...@anholt.net writes:
Francisco Jerez curroje...@riseup.net writes:
This reverts commit 3fad0868f023f1d726e230968a4df3327de38823.
This test doesn't make any sense to me, it begins quoting the GLSL
1.30 spec on the interaction of
On Mon, Feb 2, 2015 at 3:00 AM, Martin Peres martin.pe...@linux.intel.com
wrote:
v2: Review from Laura Ekstrand
- give more helpful error messages
- factor the lookup code for the xfb and objBuf
- replace some already-existing tabs with spaces
- add comments to explain the cases where xfb ==
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=88841
---
src/mesa/drivers/dri/i965/intel_pixel_read.c | 7 +++
src/mesa/drivers/dri/i965/intel_tex_image.c | 7 +++
2 files changed, 14 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/intel_pixel_read.c
Jason Ekstrand ja...@jlekstrand.net writes:
Hi all,
I wanted to send out a quick message about naming conventions for mesa
entrypoints and dd table fallbacks. There has been some confusion and
disagreement about this with some of the stuff Laura has been doing to
implement DSA. Instead of
On 01.02.2015 01:45, Neil Roberts wrote:
This limits the style changes to modes inherited from prog-mode. The
main reason to do this is to avoid setting fill-column for people
using Emacs to edit commit messages because 78 characters is too many
to make it wrap properly in git log. Note that
On 02.02.2015 02:37, Marek Olšák wrote:
From: Marek Olšák marek.ol...@amd.com
The stipple texture is bound to slot 16, so there are 17 sampler states and
34 sampler views now (17 normal slots + 17 fmask slots).
[...]
@@ -2742,16 +2743,26 @@ static int si_generate_gs_copy_shader(struct
71 matches
Mail list logo
