Re: [Mesa-dev] [PATCH] i965: Use new/delete instead of realloc() in brw_ir_allocator.h

2015-02-11 Thread Francisco Jerez
Matt Turner matts...@gmail.com writes: On Wed, Feb 11, 2015 at 6:37 AM, Juha-Pekka Heikkila juhapekka.heikk...@gmail.com wrote: There is no error path available thus instead of giving realloc possibility to fail use new which will never return null pointer and throws bad_alloc on failure.

[Mesa-dev] [Bug 89068] glTexImage2D regression by texstore_rgba switch to _mesa_format_convert

2015-02-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89068 --- Comment #6 from Brad King brad.k...@kitware.com --- Thanks for taking a look! I've just run a debug session with commit 1e02f2ba checked out. what GPU are you running on? I'm building software-only: ./autogen.sh --prefix=... \

Re: [Mesa-dev] [PATCH] gallium: add PIPE_SHADER_CAP_MAX_UNROLL_ITERATIONS

2015-02-11 Thread Brian Paul
On 02/11/2015 07:23 AM, Marek Olšák wrote: From: Marek Olšák marek.ol...@amd.com This is the same as the Mesa core setting. This avoids a serious r600g bug. Bugzilla:_https://bugs.freedesktop.org/show_bug.cgi?id=86720 Cc: 10.5 10.4 10.3 mesa-sta...@lists.freedesktop.org ---

[Mesa-dev] [PATCH 2/2] st/nine: Mark end of non-void function unreachable

2015-02-11 Thread Tobias Klausmann
Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- src/gallium/state_trackers/nine/nine_pipe.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/nine/nine_pipe.h b/src/gallium/state_trackers/nine/nine_pipe.h index

Re: [Mesa-dev] [PATCH] i965: Use new/delete instead of realloc() in brw_ir_allocator.h

2015-02-11 Thread Francisco Jerez
Juha-Pekka Heikkila juhapekka.heikk...@gmail.com writes: There is no error path available thus instead of giving realloc possibility to fail use new which will never return null pointer and throws bad_alloc on failure. Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com ---

Re: [Mesa-dev] [PATCH] i965: Use new/delete instead of realloc() in brw_ir_allocator.h

2015-02-11 Thread Matt Turner
On Wed, Feb 11, 2015 at 6:37 AM, Juha-Pekka Heikkila juhapekka.heikk...@gmail.com wrote: There is no error path available thus instead of giving realloc possibility to fail use new which will never return null pointer and throws bad_alloc on failure. The problem was that we weren't checking if

Re: [Mesa-dev] [PATCH] gallium: add PIPE_SHADER_CAP_MAX_UNROLL_ITERATIONS

2015-02-11 Thread Marek Olšák
I completely agree with you. Turning off the R600 optimizing Shader Backend would also work, but the performance drop would be unpleasant. Marek On Wed, Feb 11, 2015 at 4:11 PM, Roland Scheidegger srol...@vmware.com wrote: I don't think this is a good idea. This pollutes the gallium interface

Re: [Mesa-dev] [PATCH 02/11] i965/blorp: round to nearest when converting float to integer

2015-02-11 Thread Matt Turner
On Tue, Feb 10, 2015 at 11:00 PM, Samuel Iglesias Gonsálvez sigles...@igalia.com wrote: On Tuesday 10 February 2015 11:32:32 Matt Turner wrote: On Tue, Feb 10, 2015 at 10:52 AM, Matt Turner matts...@gmail.com wrote: + /* Round floating point values to nearest integer to avoid off by one

Re: [Mesa-dev] [PATCH] i965: Use new/delete instead of realloc() in brw_ir_allocator.h

2015-02-11 Thread Juha-Pekka Heikkila
On 11.02.2015 19:02, Matt Turner wrote: On Wed, Feb 11, 2015 at 6:37 AM, Juha-Pekka Heikkila juhapekka.heikk...@gmail.com wrote: There is no error path available thus instead of giving realloc possibility to fail use new which will never return null pointer and throws bad_alloc on failure.

Re: [Mesa-dev] [PATCH] i965: Use new/delete instead of realloc() in brw_ir_allocator.h

2015-02-11 Thread Jason Ekstrand
On Wed, Feb 11, 2015 at 12:30 PM, Francisco Jerez curroje...@riseup.net wrote: Matt Turner matts...@gmail.com writes: On Wed, Feb 11, 2015 at 9:16 AM, Francisco Jerez curroje...@riseup.net wrote: Matt Turner matts...@gmail.com writes: On Wed, Feb 11, 2015 at 6:37 AM, Juha-Pekka

Re: [Mesa-dev] [PATCHv4 32/32] i965: Don't compact instructions with unmapped bits.

2015-02-11 Thread Matt Turner
Reviewed-by: Matt Turner matts...@gmail.com ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] i965: Use new/delete instead of realloc() in brw_ir_allocator.h

2015-02-11 Thread Matt Turner
On Wed, Feb 11, 2015 at 9:16 AM, Francisco Jerez curroje...@riseup.net wrote: Matt Turner matts...@gmail.com writes: On Wed, Feb 11, 2015 at 6:37 AM, Juha-Pekka Heikkila juhapekka.heikk...@gmail.com wrote: There is no error path available thus instead of giving realloc possibility to fail

Re: [Mesa-dev] [PATCH] i965: Use new/delete instead of realloc() in brw_ir_allocator.h

2015-02-11 Thread Francisco Jerez
Matt Turner matts...@gmail.com writes: On Wed, Feb 11, 2015 at 9:16 AM, Francisco Jerez curroje...@riseup.net wrote: Matt Turner matts...@gmail.com writes: On Wed, Feb 11, 2015 at 6:37 AM, Juha-Pekka Heikkila juhapekka.heikk...@gmail.com wrote: There is no error path available thus

Re: [Mesa-dev] [PATCH 1/3] nir: Add support for CSE on textures.

2015-02-11 Thread Connor Abbott
On Wed, Feb 11, 2015 at 2:36 PM, Eric Anholt e...@anholt.net wrote: Connor Abbott cwabbo...@gmail.com writes: On Tue, Feb 10, 2015 at 1:32 PM, Eric Anholt e...@anholt.net wrote: Connor Abbott cwabbo...@gmail.com writes: On Sat, Feb 7, 2015 at 12:16 AM, Eric Anholt e...@anholt.net wrote: NIR

Re: [Mesa-dev] [PATCH] nir: Recognize open-coded fmin/fmax.

2015-02-11 Thread Kenneth Graunke
On Wednesday, February 11, 2015 09:58:28 AM Matt Turner wrote: And unfortunately other shaders do the same thing but with =/= which we can't apply this optimization to because of NaNs. instructions in affected programs: 23309 - 22938 (-1.59%) --- src/glsl/nir/nir_opt_algebraic.py | 2

Re: [Mesa-dev] [PATCH] i965: Use new/delete instead of realloc() in brw_ir_allocator.h

2015-02-11 Thread Kenneth Graunke
On Wednesday, February 11, 2015 04:56:56 PM Juha-Pekka Heikkila wrote: There is no error path available thus instead of giving realloc possibility to fail use new which will never return null pointer and throws bad_alloc on failure. Signed-off-by: Juha-Pekka Heikkila

[Mesa-dev] [Bug 88880] glxextensions.c: buffer overflow and incorrect zeroing

2015-02-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=0 --- Comment #2 from Ian Romanick i...@freedesktop.org --- It's invalid because the code referenced in the bug report was removed by commit 7ef4a07 in July 2006. I think it's time for any upgrade. :) See also bug #7353. -- You are receiving

Re: [Mesa-dev] [PATCH] i965: Use new/delete instead of realloc() in brw_ir_allocator.h

2015-02-11 Thread Matt Turner
On Wed, Feb 11, 2015 at 9:35 AM, Jason Ekstrand ja...@jlekstrand.net wrote: On Wed, Feb 11, 2015 at 12:30 PM, Francisco Jerez curroje...@riseup.net wrote: Matt Turner matts...@gmail.com writes: On Wed, Feb 11, 2015 at 9:16 AM, Francisco Jerez curroje...@riseup.net wrote: Matt Turner

Re: [Mesa-dev] [PATCH] i965/vs/skl: Use vec4 datatypes for message header

2015-02-11 Thread Kenneth Graunke
On Wednesday, February 11, 2015 10:35:04 AM Ben Widawsky wrote: On Wed, Feb 11, 2015 at 05:08:33AM -0800, Kenneth Graunke wrote: On Tuesday, February 10, 2015 05:22:45 PM Ben Widawsky wrote: Since we can be in this code with SIMD4x2, the execsize will be 4, and so the register width

Re: [Mesa-dev] [PATCH] i965: Add a function to disassemble an instruction from the 4 dwords.

2015-02-11 Thread Ian Romanick
Reviewed-by: Ian Romanick ian.d.roman...@intel.com On 02/06/2015 12:36 AM, Kenneth Graunke wrote: I used this a while back when debugging GPU hangs, and it seems like it could be useful, so I figured I'd add it so people can use it in the debugger. Signed-off-by: Kenneth Graunke

Re: [Mesa-dev] [PATCH] i965/vs/skl: Use vec4 datatypes for message header

2015-02-11 Thread Ben Widawsky
On Wed, Feb 11, 2015 at 05:08:33AM -0800, Kenneth Graunke wrote: On Tuesday, February 10, 2015 05:22:45 PM Ben Widawsky wrote: Since we can be in this code with SIMD4x2, the execsize will be 4, and so the register width must be = 4. If you use a vec8, the width is 8, and we'll assert

[Mesa-dev] [Bug 89088] Mesa fails to build if indent does not support requested arguments (eg: -nut)

2015-02-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89088 Bug ID: 89088 Summary: Mesa fails to build if indent does not support requested arguments (eg: -nut) Product: Mesa Version: 10.4 Hardware: Other OS: All

Re: [Mesa-dev] [PATCH v5 03/29] glsl: Add double builtin type

2015-02-11 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick ian.d.roman...@intel.com On 02/10/2015 03:58 AM, Ilia Mirkin wrote: This causes a lot of warnings about unchecked type in switch statements - fix them later. Signed-off-by: Dave Airlie airl...@redhat.com Reviewed-by: Matt Turner matts...@gmail.com

Re: [Mesa-dev] [PATCH] nir/lower_phis_to_scalar: Fix some logic in is_phi_scalarizable

2015-02-11 Thread Matt Turner
Reviewed-by: Matt Turner matts...@gmail.com ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] nir/lower_phis_to_scalar: Fix some logic in is_phi_scalarizable

2015-02-11 Thread Kenneth Graunke
On Monday, February 09, 2015 02:23:25 PM Jason Ekstrand wrote: --- src/glsl/nir/nir_lower_phis_to_scalar.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/glsl/nir/nir_lower_phis_to_scalar.c b/src/glsl/nir/nir_lower_phis_to_scalar.c index 3bb5cc7..7cd93ea

Re: [Mesa-dev] [PATCH] program: Remove _mesa_nop_vertex_program/_mesa_nop_fragment_program.

2015-02-11 Thread Eric Anholt
Kenneth Graunke kenn...@whitecape.org writes: On Tuesday, February 10, 2015 08:08:38 PM Matt Turner wrote: Dead since commit 284ce20901b0c2cfab1d952cc129b8f3cd068f12 Author: Eric Anholt e...@anholt.net Date: Fri Aug 20 10:52:14 2010 -0700 Remove remnants of the old

Re: [Mesa-dev] [PATCH 1/3] nir: Add support for CSE on textures.

2015-02-11 Thread Eric Anholt
Connor Abbott cwabbo...@gmail.com writes: On Tue, Feb 10, 2015 at 1:32 PM, Eric Anholt e...@anholt.net wrote: Connor Abbott cwabbo...@gmail.com writes: On Sat, Feb 7, 2015 at 12:16 AM, Eric Anholt e...@anholt.net wrote: NIR instruction count results on i965: total instructions in shared

[Mesa-dev] [PATCH] nir: Recognize open-coded fmin/fmax.

2015-02-11 Thread Matt Turner
And unfortunately other shaders do the same thing but with =/= which we can't apply this optimization to because of NaNs. instructions in affected programs: 23309 - 22938 (-1.59%) --- src/glsl/nir/nir_opt_algebraic.py | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [Mesa-dev] [PATCH] darwin: Fix install name of libOSMesa

2015-02-11 Thread Jeremy Huddleston Sequoia
On Feb 11, 2015, at 05:02, Emil Velikov emil.l.veli...@gmail.com wrote: On 11 February 2015 at 10:32, Jeremy Huddleston Sequoia jerem...@apple.com wrote: libOSMesa is a library, not a module Fwiw I'm not 100% sure that's the case. But considering it's been like that* for a long time we

[Mesa-dev] [PATCH] mesa: fix AtomicBuffer typo in _mesa_DeleteBuffers

2015-02-11 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com Cc: 10.5 10.4 10.3 mesa-sta...@lists.freedesktop.org --- src/mesa/main/bufferobj.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index 0c1ce98..0c23b42 100644 ---

[Mesa-dev] [PATCH] i965: Use new/delete instead of realloc() in brw_ir_allocator.h

2015-02-11 Thread Juha-Pekka Heikkila
There is no error path available thus instead of giving realloc possibility to fail use new which will never return null pointer and throws bad_alloc on failure. Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/mesa/drivers/dri/i965/brw_ir_allocator.h | 19

[Mesa-dev] [PATCH 1/2] gallium: define unreachable macro

2015-02-11 Thread Tobias Klausmann
This is done the same way for glsl et al. already Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- src/gallium/include/pipe/p_compiler.h | 23 +++ 1 file changed, 23 insertions(+) diff --git a/src/gallium/include/pipe/p_compiler.h

[Mesa-dev] [PATCH] i965: Use new/delete instead of realloc() in brw_ir_allocator.h

2015-02-11 Thread Juha-Pekka Heikkila
There is no error path available thus instead of giving realloc possibility to fail use new which will never return null pointer and throws bad_alloc on failure. Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/mesa/drivers/dri/i965/brw_ir_allocator.h | 16

Re: [Mesa-dev] [PATCH] gallium: add PIPE_SHADER_CAP_MAX_UNROLL_ITERATIONS

2015-02-11 Thread Roland Scheidegger
I don't think this is a good idea. This pollutes the gallium interface (albeit in some rather minor way, but still) to just cover up a driver bug. It does not do anything to actually fix the root cause of the bug (presumably it would still just lock up if the loop would actually have 256

Re: [Mesa-dev] [PATCH 1/2] gallium: define unreachable macro

2015-02-11 Thread Ilia Mirkin
It's already defined in src/util/macros.h which you can include via #include util/macros.h -- I suspect some key gallium file should include that... On Wed, Feb 11, 2015 at 10:47 AM, Tobias Klausmann tobias.johannes.klausm...@mni.thm.de wrote: This is done the same way for glsl et al. already

[Mesa-dev] [PATCH 3/4] radeonsi: small fix in SPI state

2015-02-11 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com Cc: 10.4 mesa-sta...@lists.freedesktop.org --- src/gallium/drivers/radeonsi/si_state_shaders.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state_shaders.c

[Mesa-dev] [PATCH] gallium: add PIPE_SHADER_CAP_MAX_UNROLL_ITERATIONS

2015-02-11 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com This is the same as the Mesa core setting. This avoids a serious r600g bug. Bugzilla:_https://bugs.freedesktop.org/show_bug.cgi?id=86720 Cc: 10.5 10.4 10.3 mesa-sta...@lists.freedesktop.org --- src/gallium/auxiliary/gallivm/lp_bld_limits.h| 2 ++

[Mesa-dev] [PATCH 2/4] r600g, radeonsi: use fences to implement PIPE_QUERY_GPU_FINISHED

2015-02-11 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- src/gallium/drivers/radeon/r600_query.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_query.c b/src/gallium/drivers/radeon/r600_query.c index 4571b3c..8d80612 100644 ---

[Mesa-dev] [PATCH 1/4] r600g, radeonsi: demote TIMESTAMP_DISJOINT query to be a software query

2015-02-11 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com The query result is always constant. --- src/gallium/drivers/radeon/r600_query.c | 27 +-- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_query.c

[Mesa-dev] [PATCH 4/4] radeonsi: initialize TC_L2_dirty to false after buffer allocation

2015-02-11 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com I forgot to do this, though true should have no effect on correctness. --- src/gallium/drivers/radeon/r600_buffer_common.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/radeon/r600_buffer_common.c

Re: [Mesa-dev] [PATCH] mesa: fix AtomicBuffer typo in _mesa_DeleteBuffers

2015-02-11 Thread Brian Paul
On 02/11/2015 07:24 AM, Marek Olšák wrote: From: Marek Olšák marek.ol...@amd.com Cc: 10.5 10.4 10.3 mesa-sta...@lists.freedesktop.org --- src/mesa/main/bufferobj.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index

Re: [Mesa-dev] [PATCH] i965: Use new/delete instead of realloc() in brw_ir_allocator.h

2015-02-11 Thread Francisco Jerez
Matt Turner matts...@gmail.com writes: [...] Indeed. And another thing to consider is that we've discussed compiling with -fno-exceptions. Heh, the benefit you get from doing that is virtually zero. And in cases like this where failure would have to be handled many levels up in the stack and

[Mesa-dev] [Bug 89088] Mesa fails to build if indent does not support requested arguments (eg: -nut)

2015-02-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89088 --- Comment #1 from Matt Turner matts...@gmail.com --- A commit was made recently to require GNU indent: commit efef6c828092702b1f928f98d15fb90b4544a85c Author: Samuel Iglesias Gonsalvez sigles...@igalia.com Date: Tue Jan 13 11:02:27 2015

[Mesa-dev] [PATCH] glext.h: Add missing include of stddef.h for ptrdiff_t

2015-02-11 Thread Jeremy Huddleston Sequoia
Signed-off-by: Jeremy Huddleston Sequoia jerem...@apple.com --- include/GL/glext.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/GL/glext.h b/include/GL/glext.h index 256ad35..0328cf6 100644 --- a/include/GL/glext.h +++ b/include/GL/glext.h @@ -4470,6 +4470,7 @@ GLAPI void APIENTRY

Re: [Mesa-dev] [PATCH 1/3] nir: Add support for CSE on textures.

2015-02-11 Thread Connor Abbott
On Wed, Feb 11, 2015 at 3:17 PM, Eric Anholt e...@anholt.net wrote: Connor Abbott cwabbo...@gmail.com writes: On Wed, Feb 11, 2015 at 2:36 PM, Eric Anholt e...@anholt.net wrote: Connor Abbott cwabbo...@gmail.com writes: On Tue, Feb 10, 2015 at 1:32 PM, Eric Anholt e...@anholt.net wrote:

Re: [Mesa-dev] [PATCH 1/3] nir: Add support for CSE on textures.

2015-02-11 Thread Eric Anholt
Connor Abbott cwabbo...@gmail.com writes: On Wed, Feb 11, 2015 at 2:36 PM, Eric Anholt e...@anholt.net wrote: Connor Abbott cwabbo...@gmail.com writes: On Tue, Feb 10, 2015 at 1:32 PM, Eric Anholt e...@anholt.net wrote: Connor Abbott cwabbo...@gmail.com writes: On Sat, Feb 7, 2015 at 12:16

Re: [Mesa-dev] [PATCH] glext.h: Add missing include of stddef.h for ptrdiff_t

2015-02-11 Thread Matt Turner
On Wed, Feb 11, 2015 at 12:36 PM, Jeremy Huddleston Sequoia jerem...@freedesktop.org wrote: Signed-off-by: Jeremy Huddleston Sequoia jerem...@apple.com The file comes from Khronos. We can't update it. ___ mesa-dev mailing list

[Mesa-dev] [PATCH 2.1/3?] squash! nir_algebraic.py: don't store a dictionary of indexes

2015-02-11 Thread Kenneth Graunke
Since condition_list is an ordered list, we can just use enumerate() when walking through it to get (index, value) pairs, rather than storing a second dictionary mapping items to their indices. When looking for an existing entry, use list.index() to get the index of that item. ---

[Mesa-dev] [PATCH 1/6] mesa: implement GL_AMD_pinned_memory

2015-02-11 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com It's not possible to query the current buffer binding, because the extension doesn't define GL_..._BUFFER__BINDING_AMD. Drivers should check the target parameter of Drivers.BufferData. If it's equal to GL_EXTERNAL_VIRTUAL_MEMORY_BUFFER_AMD, the memory should

[Mesa-dev] [PATCH 3/6] winsys/radeon: allow mapping a user buffer by returning the same pointer

2015-02-11 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com OpenGL requires this. --- src/gallium/winsys/radeon/drm/radeon_drm_bo.c | 5 + src/gallium/winsys/radeon/drm/radeon_drm_bo.h | 1 + src/gallium/winsys/radeon/drm/radeon_winsys.h | 4 ++-- 3 files changed, 8 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [PATCH 2/6] gallium: add interface and state tracker support for GL_AMD_pinned_memory

2015-02-11 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- src/gallium/docs/source/screen.rst | 5 + src/gallium/drivers/i915/i915_screen.c | 1 + src/gallium/drivers/ilo/ilo_screen.c | 1 + src/gallium/drivers/llvmpipe/lp_screen.c | 1 +

[Mesa-dev] [PATCH 4/6] winsys/radeon: allow unaligned size for user-memory buffers

2015-02-11 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com This is not required, but being user-friendly doesn't hurt. --- src/gallium/winsys/radeon/drm/radeon_drm_bo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/winsys/radeon/drm/radeon_drm_bo.c

[Mesa-dev] [PATCH 5/6] winsys/radeon: test the userptr ioctl to see if it's present

2015-02-11 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com There seems to be no other way to check for support. The DRM version wasn't bumped. --- src/gallium/winsys/radeon/drm/radeon_drm_bo.c | 18 -- src/gallium/winsys/radeon/drm/radeon_drm_cs.h | 1 -

[Mesa-dev] [PATCH 6/6] r600g, radeonsi: implement GL_AMD_pinned_memory

2015-02-11 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- src/gallium/drivers/r600/r600_pipe.c| 3 ++ src/gallium/drivers/radeon/r600_buffer_common.c | 47 ++--- src/gallium/drivers/radeon/r600_pipe_common.c | 1 + src/gallium/drivers/radeon/r600_pipe_common.h | 4 +++

[Mesa-dev] [PATCH] nir: Zero-init our structures.

2015-02-11 Thread Eric Anholt
We were filling out almost all fields of almost all instructions, but leaving out a couple of them. This simplifies the source code, cuts 700 bytes from the compiled binary, and prevents developer surprise when one field of your otherwise-containing-defaults struct is actually uninitialized. ---

[Mesa-dev] [PATCH 1/3] glsl: Propagate negates through multiplication chains.

2015-02-11 Thread Matt Turner
We propagate negations to the right-most leaves of the multiplication expression trees: - mul(neg(x), neg(y)) - mul(x, y) - mul(neg(x), y) - neg(mul(x, y)) - mul(x, neg(y)) - neg(mul(x, y)) total instructions in shared programs: 5943123 - 5937229 (-0.10%) instructions in affected programs:

[Mesa-dev] [PATCH 1/3] i965/fs: Add unit tests for saturate propagation pass.

2015-02-11 Thread Matt Turner
Cc: mesa-sta...@lists.freedesktop.org --- src/mesa/drivers/dri/i965/Makefile.am | 7 + .../dri/i965/test_fs_saturate_propagation.cpp | 355 + 2 files changed, 362 insertions(+) create mode 100644 src/mesa/drivers/dri/i965/test_fs_saturate_propagation.cpp

[Mesa-dev] [PATCH 2/3] i965/fs: Use fs_inst::overwrites_reg() in saturate propagation.

2015-02-11 Thread Matt Turner
This is safer and matches the conditional_mod propagation pass. Cc: mesa-sta...@lists.freedesktop.org --- .../dri/i965/brw_fs_saturate_propagation.cpp | 8 ++--- .../dri/i965/test_fs_saturate_propagation.cpp | 40 ++ 2 files changed, 44 insertions(+), 4

[Mesa-dev] [PATCH 3/3] i965: Emit MUL with a negated src for neg(mul(...)).

2015-02-11 Thread Matt Turner
total instructions in shared programs: 5932832 - 5932736 (-0.00%) instructions in affected programs: 8184 - 8088 (-1.17%) helped:52 HURT: 14 GAINED:1 ---

[Mesa-dev] [PATCH 3/3] i965/fs: Consider MOV.SAT to interfere if it has a source modifier.

2015-02-11 Thread Matt Turner
The saturate propagation pass recognizes that the second instruction below does not interfere with an attempt to propagate the saturate modifier from instruction 3 to 1. 1: add(8) dst0 src0 src1 2: mov.sat(8) dst1 dst0 3: mov.sat(8) dst2 dst0 Unfortunately, we did not consider

[Mesa-dev] [PATCH 2/3] i965/fs: Allow CSE to handle MULs with negated arguments.

2015-02-11 Thread Matt Turner
mul x, -y is equivalent to mul -x, y; and mul x, y is the negation of mul x, -y. total instructions in shared programs: 5937689 - 5929512 (-0.14%) instructions in affected programs: 871152 - 862975 (-0.94%) helped:4228 HURT: 17

Re: [Mesa-dev] [PATCH 1/2] gallium: define unreachable macro

2015-02-11 Thread Tobias Klausmann
On 11.02.2015 16:50, Ilia Mirkin wrote: It's already defined in src/util/macros.h which you can include via #include util/macros.h -- I suspect some key gallium file should include that... Mh, i was under the expression these should be duped, as we already have STATIC_ASSERT and

[Mesa-dev] [Bug 89050] [HSW DRI3] Piglit glx_GLX_ARB_create_context_current_with_no_framebuffer fails

2015-02-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89050 Chris Wilson ch...@chris-wilson.co.uk changed: What|Removed |Added Status|NEEDINFO|RESOLVED

[Mesa-dev] [Bug 79629] [Dri3 bisected] piglit glx_GLX_ARB_create_context_current_with_no_framebuffer fail

2015-02-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79629 --- Comment #18 from Chris Wilson ch...@chris-wilson.co.uk --- *** Bug 89050 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.

[Mesa-dev] [Bug 88852] macros.h(181) : error C2143: syntax error : missing '{' before 'enum [tag]'

2015-02-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=88852 Ian Romanick i...@freedesktop.org changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment

[Mesa-dev] [Bug 88535] Mesa 10.3.0 implementation error: gen7_update_renderbuffer_surface: renderbuffer format MESA_FORMAT_RGBX_UNORM16 unsupported

2015-02-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=88535 Ian Romanick i...@freedesktop.org changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment

[Mesa-dev] [Bug 89088] Mesa fails to build if indent does not support requested arguments (eg: -nut)

2015-02-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89088 Matt Turner matts...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED

Re: [Mesa-dev] [PATCH 10/10] i965/fs: Add algebraic optimizations for MAD.

2015-02-11 Thread Matt Turner
On Mon, Feb 9, 2015 at 6:00 PM, Kenneth Graunke kenn...@whitecape.org wrote: With that fixed, and the shader-db numbers confirmed, patches 9-10 are: Reviewed-by: Kenneth Graunke kenn...@whitecape.org To close the loop, the shader-db results are unchanged after the fix.

Re: [Mesa-dev] [PATCH 1/3] glsl: Propagate negates through multiplication chains.

2015-02-11 Thread Ian Romanick
On 02/11/2015 02:54 PM, Matt Turner wrote: We propagate negations to the right-most leaves of the multiplication expression trees: - mul(neg(x), neg(y)) - mul(x, y) - mul(neg(x), y) - neg(mul(x, y)) - mul(x, neg(y)) - neg(mul(x, y)) total instructions in shared programs: 5943123 -

[Mesa-dev] [Bug 63717] Poor performance in games with Intel 965GM

2015-02-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=63717 Matt Turner matts...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED

Re: [Mesa-dev] [PATCH 3/3] i965: Emit MUL with a negated src for neg(mul(...)).

2015-02-11 Thread Ian Romanick
On 02/11/2015 02:54 PM, Matt Turner wrote: total instructions in shared programs: 5932832 - 5932736 (-0.00%) instructions in affected programs: 8184 - 8088 (-1.17%) helped:52 HURT: 14 GAINED:1

Re: [Mesa-dev] [PATCH 1/3] glsl: Propagate negates through multiplication chains.

2015-02-11 Thread Ian Romanick
On 02/11/2015 04:05 PM, Matt Turner wrote: On Wed, Feb 11, 2015 at 3:51 PM, Ian Romanick i...@freedesktop.org wrote: On 02/11/2015 02:54 PM, Matt Turner wrote: We propagate negations to the right-most leaves of the multiplication expression trees: - mul(neg(x), neg(y)) - mul(x, y) -

[Mesa-dev] [Bug 88885] Transform feedback uses incorrect interleaving if a previous draw did not write gl_Position

2015-02-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=5 Carl Worth cwo...@cworth.org changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |cwo...@cworth.org

Re: [Mesa-dev] [PATCH] nir: Zero-init our structures.

2015-02-11 Thread Jason Ekstrand
I didn't look through it close enough to call it a review, but I like it. Especially getting rid of src/def_init. Acked-by: Jason Ekstrand jason.ekstr...@intel.com On Wed, Feb 11, 2015 at 4:32 PM, Eric Anholt e...@anholt.net wrote: We were filling out almost all fields of almost all

[Mesa-dev] [Bug 89088] Mesa fails to build if indent does not support requested arguments (eg: -nut)

2015-02-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89088 --- Comment #2 from Jeremy Huddleston jerem...@freedesktop.org --- No, I was encountering this on the MacPorts Snow Leopard buildbot after updating mesa from 8.0.5 to 10.4.4. We should probably cherry-pick that into 10.5 and 10.4. -- You are

Re: [Mesa-dev] [PATCH v3 01/12] nir/dominance: Expose the dominance intersection function

2015-02-11 Thread Connor Abbott
Reviewed-by: Connor Abbott cwabbo...@gmail.com On Mon, Feb 9, 2015 at 11:24 PM, Jason Ekstrand ja...@jlekstrand.net wrote: Being able to find the least common anscestor in the dominance tree is a useful thing that we may want to do in other passes. In particular, we need it for GCM. v2:

Re: [Mesa-dev] [PATCH 1/3] glsl: Propagate negates through multiplication chains.

2015-02-11 Thread Matt Turner
On Wed, Feb 11, 2015 at 3:51 PM, Ian Romanick i...@freedesktop.org wrote: On 02/11/2015 02:54 PM, Matt Turner wrote: We propagate negations to the right-most leaves of the multiplication expression trees: - mul(neg(x), neg(y)) - mul(x, y) - mul(neg(x), y) - neg(mul(x, y)) - mul(x,

[Mesa-dev] [Bug 89050] [HSW DRI3] Piglit glx_GLX_ARB_create_context_current_with_no_framebuffer fails

2015-02-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89050 Ian Romanick i...@freedesktop.org changed: What|Removed |Added Status|NEW |NEEDINFO

[Mesa-dev] [Bug 88852] macros.h(181) : error C2143: syntax error : missing '{' before 'enum [tag]'

2015-02-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=88852 Jason Ekstrand ja...@jlekstrand.net changed: What|Removed |Added Status|NEEDINFO|RESOLVED

[Mesa-dev] [Bug 86944] glsl_parser_extras.cpp, line 1455: Error: Badly formed expression.

2015-02-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=86944 Ian Romanick i...@freedesktop.org changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment

[Mesa-dev] [Bug 82477] [softpipe] piglit fp-long-alu regression

2015-02-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=82477 --- Comment #3 from Ian Romanick i...@freedesktop.org --- *** Bug 82471 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___

[Mesa-dev] [Bug 82471] [swrast] piglit fp-condition_codes-01 regression

2015-02-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=82471 Ian Romanick i...@freedesktop.org changed: What|Removed |Added Status|NEW |RESOLVED

[Mesa-dev] [Bug 79706] [TRACKER] Mesa regression tracker

2015-02-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79706 Bug 79706 depends on bug 82471, which changed state. Bug 82471 Summary: [swrast] piglit fp-condition_codes-01 regression https://bugs.freedesktop.org/show_bug.cgi?id=82471 What|Removed |Added

Re: [Mesa-dev] [PATCH 1/6] mesa: implement GL_AMD_pinned_memory

2015-02-11 Thread Ian Romanick
I was wondering when you'd get around to implementing this. :) This patch is Reviewed-by: Ian Romanick ian.d.roman...@intel.com On 02/11/2015 12:18 PM, Marek Olšák wrote: From: Marek Olšák marek.ol...@amd.com It's not possible to query the current buffer binding, because the extension

Re: [Mesa-dev] [PATCH] i965: Use new/delete instead of realloc() in brw_ir_allocator.h

2015-02-11 Thread Ian Romanick
On 02/11/2015 12:15 PM, Francisco Jerez wrote: Matt Turner matts...@gmail.com writes: [...] Indeed. And another thing to consider is that we've discussed compiling with -fno-exceptions. Heh, the benefit you get from doing that is virtually zero. And in cases like this where failure would

Re: [Mesa-dev] [PATCH 3/3] i965: Emit MUL with a negated src for neg(mul(...)).

2015-02-11 Thread Matt Turner
On Wed, Feb 11, 2015 at 3:57 PM, Ian Romanick i...@freedesktop.org wrote: On 02/11/2015 02:54 PM, Matt Turner wrote: total instructions in shared programs: 5932832 - 5932736 (-0.00%) instructions in affected programs: 8184 - 8088 (-1.17%) helped:52 HURT:

[Mesa-dev] [PATCH 5/5] r200: Drop unused variable.

2015-02-11 Thread Eric Anholt
Quiets compiler warning since e7f2f2dea5acdbd1a12ed88914e64a38a97432f0. --- src/mesa/drivers/dri/r200/r200_ioctl.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/mesa/drivers/dri/r200/r200_ioctl.c b/src/mesa/drivers/dri/r200/r200_ioctl.c index 515be92..d665c8b 100644 ---

[Mesa-dev] [PATCH 3/5] i965: Move some asserts to unreachable.

2015-02-11 Thread Eric Anholt
If execution was supposed to be supported in this case, we'd run into trouble from completely uninitialized sat_imm values. Shuts up compiler warnings. --- src/mesa/drivers/dri/i965/brw_shader.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [PATCH 4/5] i965: Quiet another compiler warning about uninitialized values.

2015-02-11 Thread Eric Anholt
The compiler can't tell that we're always going to hit the first if block on the first time through the loop. --- src/mesa/drivers/dri/i965/brw_vec4.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4.cpp

[Mesa-dev] [PATCH 1/5] gallium/dri: Shut up a compiler warning.

2015-02-11 Thread Eric Anholt
The compiler doesn't see that buffers is set in the !image case and used in the !image case. --- src/gallium/state_trackers/dri/dri2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/dri/dri2.c b/src/gallium/state_trackers/dri/dri2.c index

[Mesa-dev] [PATCH 2/5] i965: Shut up a compiler warning about uninitialized var.

2015-02-11 Thread Eric Anholt
We always pass this argument, even if it won't be used by the particular texture op. --- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp index

Re: [Mesa-dev] [PATCH 3/3] dri/common: Fix returned value of __DRI2_RENDERER_PREFERRED_PROFILE

2015-02-11 Thread Ian Romanick
On 02/09/2015 04:19 AM, Andreas Boll wrote: If the renderer supports the core profile the query returned incorrectly 0x8 as value, because it was using (1U __DRI_API_OPENGL_CORE) for the returned value. The same happened with the compatibility profile. It returned 0x1 (1U

Re: [Mesa-dev] [PATCH 1/7] mesa: Add gallium include dirs to more parts of the tree.

2015-02-11 Thread Eric Anholt
Matt Turner matts...@gmail.com writes: On Wed, Feb 11, 2015 at 4:48 PM, Eric Anholt e...@anholt.net wrote: --- Maybe I just read what I wanted to read in the cover letter, but I was expecting you to move u_math.h to src/util instead of this patch. That doesn't work because of u_math's

[Mesa-dev] [PATCH 18/23] main: Add entry point for FlushMappedNamedBufferRange.

2015-02-11 Thread Laura Ekstrand
--- src/mapi/glapi/gen/ARB_direct_state_access.xml | 6 ++ src/mesa/main/bufferobj.c | 16 src/mesa/main/bufferobj.h | 4 src/mesa/main/tests/dispatch_sanity.cpp| 1 + 4 files changed, 27 insertions(+) diff --git

[Mesa-dev] [PATCH 19/23] main: Refactor GetBufferParameteri[64]v.

2015-02-11 Thread Laura Ekstrand
v2: Split into a refactor commit and an entry point commit. --- src/mesa/main/bufferobj.c | 119 ++ 1 file changed, 45 insertions(+), 74 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index 9b3d2ea..dfeda21 100644 ---

[Mesa-dev] [PATCH 02/23] main: Add entry point for TextureBufferRange.

2015-02-11 Thread Laura Ekstrand
--- src/mapi/glapi/gen/ARB_direct_state_access.xml | 8 +++ src/mesa/main/tests/dispatch_sanity.cpp| 1 + src/mesa/main/teximage.c | 90 ++ src/mesa/main/teximage.h | 4 ++ 4 files changed, 103 insertions(+) diff

[Mesa-dev] [PATCH 23/23] main: Cosmetic changes to GetBufferSubData.

2015-02-11 Thread Laura Ekstrand
--- src/mesa/main/bufferobj.c | 2 +- src/mesa/main/bufferobj.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index 0272704..38d8b5a 100644 --- a/src/mesa/main/bufferobj.c +++ b/src/mesa/main/bufferobj.c @@ -1668,7

[Mesa-dev] [PATCH 14/23] main: Refactor MapBuffer[Range].

2015-02-11 Thread Laura Ekstrand
v2: review from Jason Ekstrand - Split refactor from addition of DSA entry points. review from Ian Romanick - Remove _mesa from static software fallback map_buffer_range - Restore VBO_DEBUG and BOUNDS_CHECK --- src/mesa/main/bufferobj.c | 286

[Mesa-dev] [PATCH 03/23] main: Add utility function _mesa_lookup_bufferobj_err.

2015-02-11 Thread Laura Ekstrand
--- src/mesa/main/bufferobj.c | 19 +++ src/mesa/main/bufferobj.h | 4 2 files changed, 23 insertions(+) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index 0c1ce98..b7dce0e 100644 --- a/src/mesa/main/bufferobj.c +++ b/src/mesa/main/bufferobj.c @@

[Mesa-dev] [PATCH 12/23] main: Add entry points for ClearNamedBuffer[Sub]Data.

2015-02-11 Thread Laura Ekstrand
--- src/mapi/glapi/gen/ARB_direct_state_access.xml | 18 + src/mesa/main/bufferobj.c | 35 ++ src/mesa/main/bufferobj.h | 11 src/mesa/main/tests/dispatch_sanity.cpp| 2 ++ 4 files changed, 66

  1   2   >