Re: [Mesa-dev] [PATCH 2/9] radeonsi: use V_BFE for extracting a sample index

2015-03-02 Thread Tom Stellard
On Mon, Mar 02, 2015 at 10:14:00PM +0100, Marek Olšák wrote: On Mon, Mar 2, 2015 at 10:05 PM, Tom Stellard t...@stellard.net wrote: On Mon, Mar 02, 2015 at 12:54:16PM +0100, Marek Olšák wrote: From: Marek Olšák marek.ol...@amd.com --- src/gallium/drivers/radeonsi/si_shader.c | 22

Re: [Mesa-dev] [PATCH 2/9] radeonsi: use V_BFE for extracting a sample index

2015-03-02 Thread Tom Stellard
On Mon, Mar 02, 2015 at 12:54:16PM +0100, Marek Olšák wrote: From: Marek Olšák marek.ol...@amd.com --- src/gallium/drivers/radeonsi/si_shader.c | 22 -- 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c

Re: [Mesa-dev] [PATCH 2/2] tgsi: handle bitwise opcodes in tgsi_opcode_infer_type

2015-03-02 Thread Ilia Mirkin
On Mon, Mar 2, 2015 at 4:48 PM, Roland Scheidegger srol...@vmware.com wrote: Maybe this is a somewhat artificial distinction. Honestly I'm not quite sure why for some of the opcodes signed or unsigned was chosen, Ilja wrote it so he might know. I picked whatever made sense for the return value

[Mesa-dev] [PATCH excerpt] mesa: Wrap unlikely() around conditions leading to _mesa_error().

2015-03-02 Thread Kenneth Graunke
Generated by the following Coccinelle semantic patch: @@ expression E; @@ if ( -E +unlikely(E) ) { ... _mesa_error(...) ... } Improves performance in OglBatch7 (a CPU-bound microbenchmark) on an i7 4750HQ (Haswell) by 1.08546% +/- 0.519734% (n=292). Signed-off-by: Kenneth Graunke

Re: [Mesa-dev] [PATCH 1/2] i965/fs: Don't use backend_visitor::instructions after creating the CFG.

2015-03-02 Thread Matt Turner
On Fri, Jan 23, 2015 at 1:38 PM, Matt Turner matts...@gmail.com wrote: On Sat, Jan 17, 2015 at 12:07 AM, Kenneth Graunke kenn...@whitecape.org wrote: With an updated commit message and Piglit passing (I'll test and let you know), Reviewed-by: Kenneth Graunke kenn...@whitecape.org Reminder

Re: [Mesa-dev] [PATCH 4/9] radeonsi: implement gl_SampleMaskIn

2015-03-02 Thread Glenn Kennard
On Mon, 02 Mar 2015 12:54:18 +0100, Marek Olšák mar...@gmail.com wrote: From: Marek Olšák marek.ol...@amd.com --- docs/GL3.txt | 2 +- src/gallium/drivers/radeonsi/si_shader.c | 4 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/docs/GL3.txt

Re: [Mesa-dev] [PATCH 2/2] tgsi: handle bitwise opcodes in tgsi_opcode_infer_type

2015-03-02 Thread Roland Scheidegger
Am 02.03.2015 um 20:38 schrieb Marek Olšák: On Mon, Mar 2, 2015 at 5:12 PM, Roland Scheidegger srol...@vmware.com wrote: Am 02.03.2015 um 12:52 schrieb Marek Olšák: From: Marek Olšák marek.ol...@amd.com --- src/gallium/auxiliary/tgsi/tgsi_info.c | 8 1 file changed, 8

Re: [Mesa-dev] [PATCH 2/9] radeonsi: use V_BFE for extracting a sample index

2015-03-02 Thread Matt Arsenault
On Mar 2, 2015, at 1:19 PM, Tom Stellard t...@stellard.net wrote: On Mon, Mar 02, 2015 at 10:14:00PM +0100, Marek Olšák wrote: On Mon, Mar 2, 2015 at 10:05 PM, Tom Stellard t...@stellard.net wrote: On Mon, Mar 02, 2015 at 12:54:16PM +0100, Marek Olšák wrote: From: Marek Olšák

Re: [Mesa-dev] [PATCH excerpt] mesa: Wrap unlikely() around conditions leading to _mesa_error().

2015-03-02 Thread Eric Anholt
Kenneth Graunke kenn...@whitecape.org writes: Generated by the following Coccinelle semantic patch: @@ expression E; @@ if ( -E +unlikely(E) ) { ... _mesa_error(...) ... } Improves performance in OglBatch7 (a CPU-bound microbenchmark) on an i7 4750HQ (Haswell) by 1.08546% +/-

Re: [Mesa-dev] [PATCH 2/9] radeonsi: use V_BFE for extracting a sample index

2015-03-02 Thread Marek Olšák
On Mon, Mar 2, 2015 at 10:05 PM, Tom Stellard t...@stellard.net wrote: On Mon, Mar 02, 2015 at 12:54:16PM +0100, Marek Olšák wrote: From: Marek Olšák marek.ol...@amd.com --- src/gallium/drivers/radeonsi/si_shader.c | 22 -- 1 file changed, 16 insertions(+), 6

Re: [Mesa-dev] [PATCH 2/2] tgsi: handle bitwise opcodes in tgsi_opcode_infer_type

2015-03-02 Thread Marek Olšák
We're just talking about unused and useless things here. I think that TGSI_TYPE_UNSIGNED should be removed and TGSI_TYPE_SIGNED should be renamed to TGSI_TYPE_INT. Until then, this type distiction serves no purpose. I'll gladly move all those opcodes under TGSI_TYPE_SIGNED, but please don't try

Re: [Mesa-dev] [PATCH excerpt] mesa: Wrap unlikely() around conditions leading to _mesa_error().

2015-03-02 Thread Dave Airlie
On 3 March 2015 at 10:37, Brian Paul bri...@vmware.com wrote: On 03/02/2015 04:03 PM, Eric Anholt wrote: Kenneth Graunke kenn...@whitecape.org writes: Generated by the following Coccinelle semantic patch: @@ expression E; @@ if ( -E +unlikely(E) ) { ... _mesa_error(...) ... }

Re: [Mesa-dev] [PATCH excerpt] mesa: Wrap unlikely() around conditions leading to _mesa_error().

2015-03-02 Thread Matt Turner
On Mon, Mar 2, 2015 at 4:45 PM, Dave Airlie airl...@gmail.com wrote: why can't we just do _mesa_error - __mesa_error, #define _mesa_error unlikely(__mesa_error) or some such. I don't think wrapping the function call in unlikely() does anything. ___

[Mesa-dev] [PATCH] nir/worklist: Don't change the start index when computing the tail index

2015-03-02 Thread Jason Ekstrand
--- src/glsl/nir/nir_worklist.c | 10 +- src/glsl/nir/nir_worklist.h | 4 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/glsl/nir/nir_worklist.c b/src/glsl/nir/nir_worklist.c index a8baae9..3087a1d 100644 --- a/src/glsl/nir/nir_worklist.c +++

[Mesa-dev] [PATCH] i965: Fix uint64_t overflow in intel_client_wait_sync()

2015-03-02 Thread Kristian Høgsberg
DRM_IOCTL_I915_GEM_WAIT takes an int64_t for the timeout value but GL_ARB_sync takes an uint64_t. Further, the ioctl used to wait indefinitely when passed a negative timeout, but it's been broken and now returns immediately in that case. Thus, if an application passes UINT64_MAX to wait forever,

Re: [Mesa-dev] [PATCH 1/5] mesa: add GL_AMD_compressed_ATC_texture support

2015-03-02 Thread Ilia Mirkin
On Mon, Mar 2, 2015 at 2:36 PM, Matt Turner matts...@gmail.com wrote: On Sun, Mar 1, 2015 at 7:08 PM, Ilia Mirkin imir...@alum.mit.edu wrote: Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- IP Status Please contact AMD regarding any intellectual property questions/issues

Re: [Mesa-dev] [PATCH excerpt] mesa: Wrap unlikely() around conditions leading to _mesa_error().

2015-03-02 Thread Brian Paul
On 03/02/2015 03:48 PM, Kenneth Graunke wrote: Generated by the following Coccinelle semantic patch: @@ expression E; @@ if ( -E +unlikely(E) ) { ... _mesa_error(...) ... } Improves performance in OglBatch7 (a CPU-bound microbenchmark) on an i7 4750HQ (Haswell) by 1.08546% +/- 0.519734%

Re: [Mesa-dev] [PATCH excerpt] mesa: Wrap unlikely() around conditions leading to _mesa_error().

2015-03-02 Thread Brian Paul
On 03/02/2015 04:03 PM, Eric Anholt wrote: Kenneth Graunke kenn...@whitecape.org writes: Generated by the following Coccinelle semantic patch: @@ expression E; @@ if ( -E +unlikely(E) ) { ... _mesa_error(...) ... } Improves performance in OglBatch7 (a CPU-bound microbenchmark) on an i7

Re: [Mesa-dev] [PATCH excerpt] mesa: Wrap unlikely() around conditions leading to _mesa_error().

2015-03-02 Thread Matt Turner
On Mon, Mar 2, 2015 at 4:37 PM, Brian Paul bri...@vmware.com wrote: On 03/02/2015 04:03 PM, Eric Anholt wrote: Kenneth Graunke kenn...@whitecape.org writes: Generated by the following Coccinelle semantic patch: @@ expression E; @@ if ( -E +unlikely(E) ) { ... _mesa_error(...) ... }

Re: [Mesa-dev] [PATCH excerpt] mesa: Wrap unlikely() around conditions leading to _mesa_error().

2015-03-02 Thread Eric Anholt
Brian Paul bri...@vmware.com writes: On 03/02/2015 04:03 PM, Eric Anholt wrote: Kenneth Graunke kenn...@whitecape.org writes: Generated by the following Coccinelle semantic patch: @@ expression E; @@ if ( -E +unlikely(E) ) { ... _mesa_error(...) ... } Improves performance in

Re: [Mesa-dev] egl dma-buf export extension again

2015-03-02 Thread Dave Airlie
On 3 March 2015 at 13:57, Dave Airlie airl...@gmail.com wrote: Okay I've revised this to add some more info to the interface, essentially I need to get the fourcc back so I can later pass it across the wire to the EGL_EXT_image_dma_buf_import, also the number of planes (though for my usecase

[Mesa-dev] [PATCH] [RFC] egl: propose simple EGL_MESA_image_dma_buf_export v2.2

2015-03-02 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com (just resending with some cleanups/updates). At the moment to get an EGL image to a dma-buf file descriptor, you have to use EGL_MESA_drm_image, and then use libdrm to convert this to a file descriptor. This extension just provides an API modelled on

[Mesa-dev] [PATCH] configure: ax_check_python_mako_module.m4 sets output variable

2015-03-02 Thread Samuel Iglesias Gonsalvez
This output variables gives more flexibility for future changes in autoconf to detect if it is needed to auto-generate files and check for the auto-generation dependencies. It is still returning error when Python is not installed. Signed-off-by: Samuel Iglesias Gonsalvez sigles...@igalia.com ---

Re: [Mesa-dev] [PATCH] c99_alloca.h: Include stdlib.h on all non-Windows.

2015-03-02 Thread Alan Coopersmith
On 03/ 2/15 08:20 AM, Brian Paul wrote: On 03/01/2015 02:00 PM, Alan Coopersmith wrote: On 03/ 1/15 12:52 PM, Vinson Lee wrote: Fix build on FreeBSD. Bugzilla:

Re: [Mesa-dev] [PATCH] configure: simplify visibility compiler flag detection

2015-03-02 Thread Alan Coopersmith
On 03/ 1/15 02:31 PM, Emil Velikov wrote: - Considering the lack of -fvisibility, what is the normal visibility level - hidden or default ? If the latter this means that every library/module built exports a ton of internal symbols. Default, unless you pass the -xldscope=hidden flag to

[Mesa-dev] egl dma-buf export extension again

2015-03-02 Thread Dave Airlie
Okay I've revised this to add some more info to the interface, essentially I need to get the fourcc back so I can later pass it across the wire to the EGL_EXT_image_dma_buf_import, also the number of planes (though for my usecase I don't care so much). The problem with EGL_MESA_drm_image is that

[Mesa-dev] [PATCH] [RFC] egl: propose simple EGL_MESA_image_dma_buf_export v2

2015-03-02 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com At the moment to get an EGL image to a dma-buf file descriptor, you have to use EGL_MESA_drm_image, and then use libdrm to convert this to a file descriptor. This extension just provides an API modelled on EGL_MESA_drm_image, to return a dma-buf file

Re: [Mesa-dev] [PATCH 1/2] gallium: add TGSI_OPCODE_FMA

2015-03-02 Thread Marek Olšák
On Mon, Mar 2, 2015 at 9:16 PM, Roland Scheidegger srol...@vmware.com wrote: Am 02.03.2015 um 20:50 schrieb Ilia Mirkin: On Mon, Mar 2, 2015 at 2:44 PM, Marek Olšák mar...@gmail.com wrote: On Mon, Mar 2, 2015 at 5:09 PM, Ilia Mirkin imir...@alum.mit.edu wrote: Like Roland mentioned, you need

Re: [Mesa-dev] [PATCH V2 1/3] glsl: move array validation into its own function

2015-03-02 Thread Mark Janes
The series is Reviewed-by: Mark Janes mark.a.ja...@intel.com Timothy Arceri t_arc...@yahoo.com.au writes: V2: return true when var-type is unsized by max access is within valid range --- src/glsl/linker.cpp | 89 ++--- src/glsl/linker.h

[Mesa-dev] GSoC 2015: The X.Org Foundation has been accepted as a mentoring organisation

2015-03-02 Thread Martin Peres
Hello, I have the pleasure to announce you that the X.Org Foundation has been accepted as a mentoring organisation for the Google Summer of Code 2015. This means that your project can receive students again this year! Here are the important dates coming[0]: - 16 March: Student application

Re: [Mesa-dev] [PATCH 1/9] gallium/radeon: don't use LLVMReadOnlyAttribute for ALU

2015-03-02 Thread Tom Stellard
On Mon, Mar 02, 2015 at 12:54:15PM +0100, Marek Olšák wrote: From: Marek Olšák marek.ol...@amd.com For some reason I thought doing this would require changes to LLVM, but I guess I was wrong. Reviewed-by: Tom Stellard thomas.stell...@amd.com None of the instructions use a pointer argument.

Re: [Mesa-dev] [PATCH 1/2] gallium: add TGSI_OPCODE_FMA

2015-03-02 Thread Roland Scheidegger
Am 02.03.2015 um 21:27 schrieb Marek Olšák: On Mon, Mar 2, 2015 at 9:16 PM, Roland Scheidegger srol...@vmware.com wrote: Am 02.03.2015 um 20:50 schrieb Ilia Mirkin: On Mon, Mar 2, 2015 at 2:44 PM, Marek Olšák mar...@gmail.com wrote: On Mon, Mar 2, 2015 at 5:09 PM, Ilia Mirkin

Re: [Mesa-dev] [PATCH] i965/skl: Ignore the vertical alignment for the qpitch of 1D textures

2015-03-02 Thread Neil Roberts
Ben Widawsky b...@bwidawsk.net writes: I guess I'd appreciate a comment about how the total_width is guaranteed to be a multiple of 64, and therefore is a multiple of all possible H_ALIGNS. This is required to meet the qpitch restraint in the surface format, This field must be set to an

Re: [Mesa-dev] [PATCH] meta/TexSubImage: Stash everything other than PIXEL_TRANSFER/store in meta_begin

2015-03-02 Thread Jason Ekstrand
Ping. I don't want this one to get lost in the header file churn. --Jason On Feb 27, 2015 12:33 PM, Jason Ekstrand ja...@jlekstrand.net wrote: Alternatively, it's probably safe (and faster) to just save/restore the scissor in meta_begin/end. The _mesa_meta_BlitFramebuffer implementation

[Mesa-dev] [PATCH 5/9] radeonsi: add support for FMA

2015-03-02 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c | 2 ++ src/gallium/drivers/radeonsi/si_pipe.c | 3 ++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c

[Mesa-dev] [PATCH 9/9] radeonsi: implement bit-finding opcodes from ARB_gpu_shader5

2015-03-02 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- docs/GL3.txt | 2 +- .../drivers/radeon/radeon_setup_tgsi_llvm.c| 92 ++ 2 files changed, 93 insertions(+), 1 deletion(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index 0487cdf..8fd2f4a

[Mesa-dev] [PATCH 7/9] radeonsi: add support for easy opcodes from ARB_gpu_shader5

2015-03-02 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c | 8 1 file changed, 8 insertions(+) diff --git a/src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c b/src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c index 385d3ad..034095f 100644 ---

[Mesa-dev] [PATCH 4/9] radeonsi: implement gl_SampleMaskIn

2015-03-02 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- docs/GL3.txt | 2 +- src/gallium/drivers/radeonsi/si_shader.c | 4 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index 43bbf85..0487cdf 100644 --- a/docs/GL3.txt +++

[Mesa-dev] [PATCH 8/9] radeonsi: implement TGSI_OPCODE_BFI

2015-03-02 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- .../drivers/radeon/radeon_setup_tgsi_llvm.c| 28 ++ 1 file changed, 28 insertions(+) diff --git a/src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c b/src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c index

[Mesa-dev] [PATCH 3/9] radeonsi: use S_BFE/V_BFE for extracting bitfields from parameters

2015-03-02 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com And use AND/OR in special cases. This universal helper will be used a lot (especially by tessellation). --- src/gallium/drivers/radeonsi/si_shader.c | 48 +--- 1 file changed, 32 insertions(+), 16 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] docs: describe the NVC0_COMPUTE envvar

2015-03-02 Thread Samuel Pitoiset
On 03/01/2015 11:06 PM, Ilia Mirkin wrote: On Sun, Mar 1, 2015 at 4:55 PM, Samuel Pitoiset samuel.pitoi...@gmail.com wrote: On 03/01/2015 07:21 PM, Ilia Mirkin wrote: Why wouldn't they always just be enabled :) Also, do you have to set it to get MP counters on kepler+? And why is it called

[Mesa-dev] [Bug 89372] [softpipe] piglit glsl-1.50 generate-zero-primitives regression

2015-03-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89372 Marek Olšák mar...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED

[Mesa-dev] [PATCH 1/9] gallium/radeon: don't use LLVMReadOnlyAttribute for ALU

2015-03-02 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com None of the instructions use a pointer argument. (+ small cosmetic changes) --- .../drivers/radeon/radeon_setup_tgsi_llvm.c| 25 -- 1 file changed, 9 insertions(+), 16 deletions(-) diff --git

[Mesa-dev] [PATCH 1/2] gallium: add TGSI_OPCODE_FMA

2015-03-02 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com Needed by ARB_gpu_shader5. --- src/gallium/auxiliary/gallivm/lp_bld_limits.h| 1 + src/gallium/auxiliary/tgsi/tgsi_exec.h | 1 + src/gallium/auxiliary/tgsi/tgsi_info.c | 2 +- src/gallium/auxiliary/tgsi/tgsi_util.c | 1 +

[Mesa-dev] [PATCH 6/9] radeonsi: add support for SQRT

2015-03-02 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c | 2 ++ src/gallium/drivers/radeonsi/si_pipe.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c

[Mesa-dev] [PATCH 2/9] radeonsi: use V_BFE for extracting a sample index

2015-03-02 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- src/gallium/drivers/radeonsi/si_shader.c | 22 -- 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index b0417ed..f125483 100644 ---

[Mesa-dev] [PATCH 2/2] tgsi: handle bitwise opcodes in tgsi_opcode_infer_type

2015-03-02 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- src/gallium/auxiliary/tgsi/tgsi_info.c | 8 1 file changed, 8 insertions(+) diff --git a/src/gallium/auxiliary/tgsi/tgsi_info.c b/src/gallium/auxiliary/tgsi/tgsi_info.c index e6e0a60..258173d 100644 --- a/src/gallium/auxiliary/tgsi/tgsi_info.c

Re: [Mesa-dev] [PATCH 2/3] i965/fs: Consider cmod when propagating to inst with different type.

2015-03-02 Thread Iago Toral Quiroga
Hi Matt, On vie, 2015-02-27 at 11:38 -0800, Matt Turner wrote: On Fri, Feb 27, 2015 at 11:34 AM, Matt Turner matts...@gmail.com wrote: We can safely propagate the conditional mod to an instruction with a different type if the conditional mod does not involve comparing for equality with

Re: [Mesa-dev] [PATCH] mesa: Indent break statements and add a missing one.

2015-03-02 Thread Iago Toral
This looks good. Sorry for the missing break :-( Iago On Sat, 2015-02-28 at 11:02 -0800, Matt Turner wrote: Always indenting break statements makes spotting missing ones easier. Cc: 10.5 mesa-sta...@lists.freedesktop.org --- src/mesa/main/pack.c | 11 ++- 1 file changed, 6

Re: [Mesa-dev] [PATCH] mesa: Free memory allocated for luminance in readpixels.

2015-03-02 Thread Iago Toral
On Sat, 2015-02-28 at 11:10 -0800, Matt Turner wrote: --- src/mesa/main/readpix.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/main/readpix.c b/src/mesa/main/readpix.c index 2e4a460..ed0104c 100644 --- a/src/mesa/main/readpix.c +++ b/src/mesa/main/readpix.c @@ -594,6

[Mesa-dev] [Bug 89311] [regression, bisected] dEQP: Added entry points for glCompressedTextureSubImage*D.

2015-03-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89311 Samuel Iglesias sigles...@igalia.com changed: What|Removed |Added Status|NEW |RESOLVED

[Mesa-dev] [Bug 89312] [regression, bisected] main: Added entry points for CopyTextureSubImage*D. (d6b7c40cecfe01)

2015-03-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89312 Samuel Iglesias sigles...@igalia.com changed: What|Removed |Added Status|NEW |RESOLVED

[Mesa-dev] [PATCH 1/6] mesa/main: update .gitignore

2015-03-02 Thread Emil Velikov
Drop the no longer present get_es{1,2}.c from the list. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- src/mesa/main/.gitignore | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/mesa/main/.gitignore b/src/mesa/main/.gitignore index e65472d..8256ad7 100644 ---

[Mesa-dev] [PATCH 5/6] mapi: fix shared-glapi dependency tracking

2015-03-02 Thread Emil Velikov
I.e. add shared-glapi/glapi_mapi_tmp.h to the SOURCES list. Otherwise there will be no knowledge that the file is required by others for the build. Thus autotools won't pick it up for the distribution tarball. Cc: 10.5 mesa-sta...@lists.freedesktop.org Signed-off-by: Emil Velikov

Re: [Mesa-dev] [PATCH 2/2] configure: Leverage gcc warn options to enable safe use of C99 features where possible.

2015-03-02 Thread Jose Fonseca
On 27/02/15 15:59, Ian Romanick wrote: I like the idea as it should prevent future thrash. There are a couple comments below. On 02/26/2015 08:51 AM, Jose Fonseca wrote: The main objective of this change is to enable Linux developers to use more of C99 throughout Mesa, with confidence that

Re: [Mesa-dev] [PATCH] meta/TexSubImage: Stash everything other than PIXEL_TRANSFER/store in meta_begin

2015-03-02 Thread Neil Roberts
This looks good to me. It does seem a shame to save everything though when so little state affects glBlitFramebuffer. However I think even if we changed it to just save the scissor state we'd still have a problem with not saving the the GL_FRAMEBUFFER_SRGB state which I think we also need to do. I

Re: [Mesa-dev] [PATCH 1/2] nir: Use alloca instead of variable length arrays.

2015-03-02 Thread Jose Fonseca
On 27/02/15 22:50, Jason Ekstrand wrote: On Fri, Feb 27, 2015 at 6:04 AM, Jose Fonseca jfons...@vmware.com mailto:jfons...@vmware.com wrote: On 26/02/15 18:07, Brian Paul wrote: On 02/26/2015 09:51 AM, Jose Fonseca wrote: This is to enable the code to build with

[Mesa-dev] [PATCH] clover: always return number of devices in clGetDeviceIDs

2015-03-02 Thread Giuseppe Bilotta
When no devices of the requested type are available, clGetDeviceIDs() returns a CL_DEVICE_NOT_FOUND, as per the specification. The specification does not mention explictly wether the number of devices (return parameter) should be set to 0 in this case, but some applications will crash (segfault)

[Mesa-dev] [PATCH 0/6] Try harder to use the generated sources

2015-03-02 Thread Emil Velikov
As mentioned in bug https://bugs.freedesktop.org/show_bug.cgi?id=89328 there are some cases in mesa, where we generate sources for distribution builds (yet we should not). This series attempts to tackle that, with one file outstanding - options.h. Afaict the last patch ought to fix this, but it

[Mesa-dev] [PATCH 3/6] mesa: fix dependency tracking of generated sources

2015-03-02 Thread Emil Velikov
Some of the files generated were not in the SOURCES variable, thus although generated prior to compilation the dependency tracking was incomplete. The latter of which resulted in the files missing from the distribution tarball. Cc: 10.5 mesa-sta...@lists.freedesktop.org Signed-off-by: Emil

Re: [Mesa-dev] [PATCH 1/2] gallium: add TGSI_OPCODE_FMA

2015-03-02 Thread Roland Scheidegger
Am 02.03.2015 um 12:52 schrieb Marek Olšák: From: Marek Olšák marek.ol...@amd.com Needed by ARB_gpu_shader5. --- src/gallium/auxiliary/gallivm/lp_bld_limits.h| 1 + src/gallium/auxiliary/tgsi/tgsi_exec.h | 1 + src/gallium/auxiliary/tgsi/tgsi_info.c | 2 +-

[Mesa-dev] [PATCH 6/6] xmlpool: make sure we ship options.h

2015-03-02 Thread Emil Velikov
The header is included in ../xmlpool.h. With the latter of which used directly in a number of places in mesa. Note that we can also add it (alongside t_option.h) to noinst_HEADERS, but neither solution fixes the issue that brough us here - namely: Do not regenerate the headers, if it already

[Mesa-dev] [PATCH] egl: Report correct GBM formats

2015-03-02 Thread Tom Stellard
From: Daniel Stone dani...@collabora.com This fixes almost all piglit regressions when running with PIGLIT_PLATFORM=gbm Tom Stellard: - Fix ARGB2101010 format Cc: 10.4 10.5 mesa-sta...@lists.freedesktop.org --- I'm not sure if the commit message makes sense, I'm open to suggestions.

Re: [Mesa-dev] [PATCH 2/2] configure: Leverage gcc warn options to enable safe use of C99 features where possible.

2015-03-02 Thread Jose Fonseca
On 28/02/15 00:25, Kenneth Graunke wrote: On Friday, February 27, 2015 09:58:51 PM Jose Fonseca wrote: Sorry, this didn't pop up when I built it here. And I'm afraid I won't have time to look into this today, and possibly the weekend. If there's not an obvious fix feel free to push a commit

[Mesa-dev] [PATCH] egl: Report correct GBM formats

2015-03-02 Thread Tom Stellard
From: Daniel Stone dani...@collabora.com This fixes almost all piglit regressions when running with PIGLIT_PLATFORM=gbm Tom Stellard: - Fix ARGB2101010 format Cc: 10.4 10.5 mesa-sta...@lists.freedesktop.org --- I'm not sure if the commit message makes sense, I'm open to suggestions.

Re: [Mesa-dev] [PATCH] egl: Report correct GBM formats

2015-03-02 Thread Ilia Mirkin
On Mon, Mar 2, 2015 at 9:23 AM, Tom Stellard thomas.stell...@amd.com wrote: From: Daniel Stone dani...@collabora.com This fixes almost all piglit regressions when running with PIGLIT_PLATFORM=gbm Tom Stellard: - Fix ARGB2101010 format Cc: 10.4 10.5 mesa-sta...@lists.freedesktop.org ---

Re: [Mesa-dev] [PATCH 1/2] nir: Use alloca instead of variable length arrays.

2015-03-02 Thread Jose Fonseca
On 27/02/15 16:15, Brian Paul wrote: On 02/27/2015 09:10 AM, Ian Romanick wrote: On 02/26/2015 10:07 AM, Brian Paul wrote: On 02/26/2015 09:51 AM, Jose Fonseca wrote: This is to enable the code to build with -Werror=vla in the short term, and enable the code to build with MSVC2013 soon after.

Re: [Mesa-dev] [PATCH] c99_alloca.h: Include stdlib.h on all non-Windows.

2015-03-02 Thread Brian Paul
On 03/01/2015 01:52 PM, Vinson Lee wrote: Fix build on FreeBSD. Bugzilla:

Re: [Mesa-dev] [PATCH 1/2] gallium: add TGSI_OPCODE_FMA

2015-03-02 Thread Ilia Mirkin
Like Roland mentioned, you need to add DFMA, and the relevant cases to glsl_to_tgsi_visitor::get_opcode so that it can be selected. On Mon, Mar 2, 2015 at 6:52 AM, Marek Olšák mar...@gmail.com wrote: From: Marek Olšák marek.ol...@amd.com Needed by ARB_gpu_shader5. ---

Re: [Mesa-dev] [PATCH] c99_alloca.h: Include stdlib.h on all non-Windows.

2015-03-02 Thread Brian Paul
On 03/01/2015 02:00 PM, Alan Coopersmith wrote: On 03/ 1/15 12:52 PM, Vinson Lee wrote: Fix build on FreeBSD. Bugzilla:

Re: [Mesa-dev] [PATCH 1/5] mesa: add GL_AMD_compressed_ATC_texture support

2015-03-02 Thread Roland Scheidegger
I'll have to say I don't particularly like this. Not only is this a proprietary format but it's also undisclosed (the encoding is secret). Is this really all that useful? You enable it only on a3xx, it looks to me like it would have been mostly interesting for a lot older chips (pre-a2xx) as the

[Mesa-dev] [PATCH 2/6] mesa: rename format_info.c to format_info.h

2015-03-02 Thread Emil Velikov
The file is auto-generated, and #included by formats.c. Let's rename it to reflect the latter. This will also help up fix the dependency tracking by adding it to the _SOURCES variable, without the side effect of it being compiled (twice). Cc: 10.4, 10.5 mesa-sta...@lists.freedesktop.org

Re: [Mesa-dev] [PATCH 1/5] mesa: add GL_AMD_compressed_ATC_texture support

2015-03-02 Thread Ilia Mirkin
While it is proprietary, there's a guide on how to convert it to the relevant DXTn format: http://www.guildsoftware.com/papers/2012.Converting.DXTC.to.ATC.pdf My understanding is that a lot of android games still make use of it, so it made sense to provide. While freedreno doesn't currently run

[Mesa-dev] [PATCH 4/6] mesa: drop Makefile from get_hash.h dependency list

2015-03-02 Thread Emil Velikov
Not required. Additionally this had the side effect of generating the file, despite it's existence. Cc: 10.5 mesa-sta...@lists.freedesktop.org Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- src/mesa/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH 1/2] gallium: add TGSI_OPCODE_FMA

2015-03-02 Thread Marek Olšák
On Mon, Mar 2, 2015 at 4:55 PM, Roland Scheidegger srol...@vmware.com wrote: Am 02.03.2015 um 12:52 schrieb Marek Olšák: From: Marek Olšák marek.ol...@amd.com Needed by ARB_gpu_shader5. --- src/gallium/auxiliary/gallivm/lp_bld_limits.h| 1 + src/gallium/auxiliary/tgsi/tgsi_exec.h

Re: [Mesa-dev] [PATCH 2/2] tgsi: handle bitwise opcodes in tgsi_opcode_infer_type

2015-03-02 Thread Roland Scheidegger
Am 02.03.2015 um 12:52 schrieb Marek Olšák: From: Marek Olšák marek.ol...@amd.com --- src/gallium/auxiliary/tgsi/tgsi_info.c | 8 1 file changed, 8 insertions(+) diff --git a/src/gallium/auxiliary/tgsi/tgsi_info.c b/src/gallium/auxiliary/tgsi/tgsi_info.c index

Re: [Mesa-dev] [PATCH 1/2] gallium: add TGSI_OPCODE_FMA

2015-03-02 Thread Roland Scheidegger
Am 02.03.2015 um 17:12 schrieb Marek Olšák: On Mon, Mar 2, 2015 at 4:55 PM, Roland Scheidegger srol...@vmware.com wrote: Am 02.03.2015 um 12:52 schrieb Marek Olšák: From: Marek Olšák marek.ol...@amd.com Needed by ARB_gpu_shader5. --- src/gallium/auxiliary/gallivm/lp_bld_limits.h| 1 +

[Mesa-dev] [PATCH 2/2] clover: Enable cl_khr_fp64 for devices that support doubles v3

2015-03-02 Thread Tom Stellard
v2: - Report correct values for CL_DEVICE_NATIVE_VECTOR_WIDTH_DOUBLE and CL_DEVICE_PREFERRED_VECTOR_WIDTH_DOUBLE. - Only define cl_khr_fp64 if the extension is supported. - Remove trailing space from extension string. - Rename device query function from cl_khr_fp86() to

[Mesa-dev] [PATCH 1/2] clover: Report a default value for CL_DEVICE_SINGLE_FP_CONFIG

2015-03-02 Thread Tom Stellard
--- src/gallium/state_trackers/clover/api/device.cpp | 3 +-- src/gallium/state_trackers/clover/core/device.cpp | 6 ++ src/gallium/state_trackers/clover/core/device.hpp | 1 + 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/gallium/state_trackers/clover/api/device.cpp

Re: [Mesa-dev] [PATCH 1/5] mesa: add GL_AMD_compressed_ATC_texture support

2015-03-02 Thread Roland Scheidegger
Interesting. The way I read this though is that this format is more or less solely used as a workaround for chips not supporting (or at least not exposing) s3tc. I guess I understand now why the encoding format wasn't published... Well ok I can live with this if it's indeed still useful (I guess

Re: [Mesa-dev] [PATCH 1/6] mesa/main: update .gitignore

2015-03-02 Thread Emil Velikov
On 02/03/15 18:19, Matt Turner wrote: On Mon, Mar 2, 2015 at 10:02 AM, Matt Turner matts...@gmail.com wrote: On Mon, Mar 2, 2015 at 10:02 AM, Matt Turner matts...@gmail.com wrote: On Mon, Mar 2, 2015 at 7:58 AM, Emil Velikov emil.l.veli...@gmail.com wrote: Drop the no longer present

Re: [Mesa-dev] [PATCH 1/6] mesa/main: update .gitignore

2015-03-02 Thread Matt Turner
On Mon, Mar 2, 2015 at 10:02 AM, Matt Turner matts...@gmail.com wrote: On Mon, Mar 2, 2015 at 7:58 AM, Emil Velikov emil.l.veli...@gmail.com wrote: Drop the no longer present get_es{1,2}.c from the list. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- src/mesa/main/.gitignore | 4

Re: [Mesa-dev] [PATCH 1/6] mesa/main: update .gitignore

2015-03-02 Thread Matt Turner
On Mon, Mar 2, 2015 at 10:02 AM, Matt Turner matts...@gmail.com wrote: On Mon, Mar 2, 2015 at 10:02 AM, Matt Turner matts...@gmail.com wrote: On Mon, Mar 2, 2015 at 7:58 AM, Emil Velikov emil.l.veli...@gmail.com wrote: Drop the no longer present get_es{1,2}.c from the list. Signed-off-by:

Re: [Mesa-dev] [PATCH 1/6] mesa/main: update .gitignore

2015-03-02 Thread Matt Turner
On Mon, Mar 2, 2015 at 10:35 AM, Emil Velikov emil.l.veli...@gmail.com wrote: Thanks for the review. If you get any ideas wrt patch#6 (stop the options.h re-generation), I'm all ears. I'll probably have to play with it myself to see what's going on. I've got ~three bugs to fix and then I'll

Re: [Mesa-dev] [PATCH 1/6] mesa/main: update .gitignore

2015-03-02 Thread Matt Turner
On Mon, Mar 2, 2015 at 7:58 AM, Emil Velikov emil.l.veli...@gmail.com wrote: Drop the no longer present get_es{1,2}.c from the list. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- src/mesa/main/.gitignore | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 5/6] mapi: fix shared-glapi dependency tracking

2015-03-02 Thread Matt Turner
On Mon, Mar 2, 2015 at 7:58 AM, Emil Velikov emil.l.veli...@gmail.com wrote: I.e. add shared-glapi/glapi_mapi_tmp.h to the SOURCES list. Otherwise there will be no knowledge that the file is required by others for the build. Thus autotools won't pick it up for the distribution tarball. Cc:

Re: [Mesa-dev] [PATCH 5/6] mapi: fix shared-glapi dependency tracking

2015-03-02 Thread Emil Velikov
On 02/03/15 18:17, Matt Turner wrote: On Mon, Mar 2, 2015 at 7:58 AM, Emil Velikov emil.l.veli...@gmail.com wrote: I.e. add shared-glapi/glapi_mapi_tmp.h to the SOURCES list. Otherwise there will be no knowledge that the file is required by others for the build. Thus autotools won't pick it up

Re: [Mesa-dev] [PATCH 1/2] gallium: add TGSI_OPCODE_FMA

2015-03-02 Thread Marek Olšák
On Mon, Mar 2, 2015 at 5:48 PM, Roland Scheidegger srol...@vmware.com wrote: Am 02.03.2015 um 17:12 schrieb Marek Olšák: On Mon, Mar 2, 2015 at 4:55 PM, Roland Scheidegger srol...@vmware.com wrote: Am 02.03.2015 um 12:52 schrieb Marek Olšák: From: Marek Olšák marek.ol...@amd.com Needed by

Re: [Mesa-dev] [PATCH 1/2] clover: Report a default value for CL_DEVICE_SINGLE_FP_CONFIG

2015-03-02 Thread Francisco Jerez
Tom Stellard thomas.stell...@amd.com writes: --- src/gallium/state_trackers/clover/api/device.cpp | 3 +-- src/gallium/state_trackers/clover/core/device.cpp | 6 ++ src/gallium/state_trackers/clover/core/device.hpp | 1 + 3 files changed, 8 insertions(+), 2 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] main/base_tex_format: Properly handle STENCIL_INDEX1/4/16

2015-03-02 Thread Ilia Mirkin
On Mon, Mar 2, 2015 at 2:32 PM, Jason Ekstrand ja...@jlekstrand.net wrote: On Mon, Mar 2, 2015 at 11:18 AM, Ilia Mirkin imir...@alum.mit.edu wrote: Hmmm... I was just looking at this code in connection to attepmting to enable ARB_texture_stencil8, and it _seems_ like that should be if

Re: [Mesa-dev] [PATCH 2/2] configure: Leverage gcc warn options to enable safe use of C99 features where possible.

2015-03-02 Thread Kenneth Graunke
On Monday, March 02, 2015 03:24:18 PM Jose Fonseca wrote: On 28/02/15 00:25, Kenneth Graunke wrote: On Friday, February 27, 2015 09:58:51 PM Jose Fonseca wrote: Sorry, this didn't pop up when I built it here. And I'm afraid I won't have time to look into this today, and possibly the

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/3] i965/fs: Consider cmod when propagating to inst with different type.

2015-03-02 Thread Matt Turner
On Fri, Feb 27, 2015 at 1:24 PM, Ian Romanick i...@freedesktop.org wrote: On 02/27/2015 11:34 AM, Matt Turner wrote: We can safely propagate the conditional mod to an instruction with a different type if the conditional mod does not involve comparing for equality with zero (or probably NaN,

Re: [Mesa-dev] [PATCH 1/5] mesa: add GL_AMD_compressed_ATC_texture support

2015-03-02 Thread Matt Turner
On Sun, Mar 1, 2015 at 7:08 PM, Ilia Mirkin imir...@alum.mit.edu wrote: Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- IP Status Please contact AMD regarding any intellectual property questions/issues associated with this extension. Ugh?

Re: [Mesa-dev] [PATCH 1/5] mesa: add GL_AMD_compressed_ATC_texture support

2015-03-02 Thread Ilia Mirkin
On Mon, Mar 2, 2015 at 12:11 PM, Roland Scheidegger srol...@vmware.com wrote: Interesting. The way I read this though is that this format is more or less solely used as a workaround for chips not supporting (or at least not exposing) s3tc. I guess I understand now why the encoding format

Re: [Mesa-dev] [PATCH] main/base_tex_format: Properly handle STENCIL_INDEX1/4/16

2015-03-02 Thread Ilia Mirkin
Hmmm... I was just looking at this code in connection to attepmting to enable ARB_texture_stencil8, and it _seems_ like that should be if (ARB_texture_stencil8) -- I didn't see what in ARB_stencil_texturing had to do with being able to have a GL_STENCIL_INDEX* internal format... -ilia On Fri,

Re: [Mesa-dev] [PATCH] main/base_tex_format: Properly handle STENCIL_INDEX1/4/16

2015-03-02 Thread Jason Ekstrand
On Mon, Mar 2, 2015 at 11:18 AM, Ilia Mirkin imir...@alum.mit.edu wrote: Hmmm... I was just looking at this code in connection to attepmting to enable ARB_texture_stencil8, and it _seems_ like that should be if (ARB_texture_stencil8) -- I didn't see what in ARB_stencil_texturing had to do

Re: [Mesa-dev] [PATCH 2/2] tgsi: handle bitwise opcodes in tgsi_opcode_infer_type

2015-03-02 Thread Marek Olšák
On Mon, Mar 2, 2015 at 5:12 PM, Roland Scheidegger srol...@vmware.com wrote: Am 02.03.2015 um 12:52 schrieb Marek Olšák: From: Marek Olšák marek.ol...@amd.com --- src/gallium/auxiliary/tgsi/tgsi_info.c | 8 1 file changed, 8 insertions(+) diff --git

Re: [Mesa-dev] [PATCH 1/2] gallium: add TGSI_OPCODE_FMA

2015-03-02 Thread Marek Olšák
On Mon, Mar 2, 2015 at 5:09 PM, Ilia Mirkin imir...@alum.mit.edu wrote: Like Roland mentioned, you need to add DFMA, and the relevant cases to glsl_to_tgsi_visitor::get_opcode so that it can be selected. I plan to add DFMA too, but it's really low priority for me right now. I can wait with this

Re: [Mesa-dev] [PATCH 1/2] gallium: add TGSI_OPCODE_FMA

2015-03-02 Thread Ilia Mirkin
On Mon, Mar 2, 2015 at 2:44 PM, Marek Olšák mar...@gmail.com wrote: On Mon, Mar 2, 2015 at 5:09 PM, Ilia Mirkin imir...@alum.mit.edu wrote: Like Roland mentioned, you need to add DFMA, and the relevant cases to glsl_to_tgsi_visitor::get_opcode so that it can be selected. I plan to add DFMA

Re: [Mesa-dev] [PATCH 1/2] nir: Use alloca instead of variable length arrays.

2015-03-02 Thread Jason Ekstrand
On Mon, Mar 2, 2015 at 8:02 AM, Jose Fonseca jfons...@vmware.com wrote: On 27/02/15 16:15, Brian Paul wrote: On 02/27/2015 09:10 AM, Ian Romanick wrote: On 02/26/2015 10:07 AM, Brian Paul wrote: On 02/26/2015 09:51 AM, Jose Fonseca wrote: This is to enable the code to build with

  1   2   >