On Fri, Mar 13, 2015 at 11:10 AM, Chris Forbes chr...@ijw.co.nz wrote:
Most of the brw_inst_* api returns 64bit values. This fixes disassembly
of sampler messages, etc.
At some point we should probably change most of the brw_inst_* API to
not return 64-bit values, but that's neither here nor
On Fri, Mar 13, 2015 at 6:20 AM, Tapani Pälli tapani.pa...@intel.com wrote:
Commit bb33a31 introduced MAD-MUL optimization which did not
take account case where one of the remaining sources is immediate
and did not report progress. Patch changes last one of the sources
to be immediate and adds
On Fri, Mar 13, 2015 at 3:41 AM, Antia Puentes apuen...@igalia.com wrote:
IvyBridge and Haswell PRM say that the JIP should be emitted
with type W but we were using UD. The previous implementation
did not show adverse effects, however changing the type to
D caused a GPU hang, see bug 84557;
On Fri, Mar 13 2015, Matt Turner wrote:
Perhaps something like the following?
Round \x to the nearest even integer (returned in floating-point
format).
I didn't read this closely enough the first time, but if I had I think
I could have short circuited a lot of the confusion.
Just include things where they're needed.
---
src/mapi/glapi/glapi_getproc.c | 4
src/mapi/glapi/glapi_nop.c | 1 +
src/mapi/glapi/glapi_priv.h| 3 ---
3 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/src/mapi/glapi/glapi_getproc.c b/src/mapi/glapi/glapi_getproc.c
index
Use the new _glapi_new_nop_table() and _glapi_set_nop_handler() to
improve how we handle calling no-op GL functions.
If there's a current context for the calling thread, generate a
GL_INVALID_OPERATION error. This will happen if the app calls an
unimplemented extension function or it calls an
_glapi_new_nop_table() creates a new dispatch table populated with
pointers to no-op functions.
_glapi_set_nop_handler() is used to register a callback function which
will be called from each of the no-op functions.
Now we always generate a separate no-op function for each GL entrypoint.
This
Never called from outside of context.c
---
src/mesa/main/api_exec.h | 4
src/mesa/main/context.c | 10 +-
2 files changed, 5 insertions(+), 9 deletions(-)
diff --git a/src/mesa/main/api_exec.h b/src/mesa/main/api_exec.h
index 1e4a9d6..12249fe 100644
--- a/src/mesa/main/api_exec.h
We should try to steer people away from just writing Piglit tests for GSoC,
unless they have a specific mentor in mind and have already talked to him
or her. In my experience, Piglit tests are difficult to do well because
each one is drastically different from the others and involves cultivating
You're welcome.
On Fri, Mar 13, 2015 at 9:00 AM, Eduardo Lima Mitev el...@igalia.com
wrote:
Hi,
I just merged the 4 patches after fixing your last comments.
Thanks a lot for your reviews and patience.
cheers,
Eduardo
On 03/12/2015 06:22 PM, Laura Ekstrand wrote:
On Thu, Mar 12,
On Fri, Mar 13, 2015 at 9:29 AM, Neil Roberts n...@linux.intel.com wrote:
Commit 0ac4c272755c7 made it add a header for the send message when
using SIMD4x2 on Skylake because without this it will end up using
SIMD8D. However the patch missed the case when a sampler is being used
to implement
Most of the brw_inst_* api returns 64bit values. This fixes disassembly
of sampler messages, etc.
Signed-off-by: Chris Forbes chr...@ijw.co.nz
---
src/mesa/drivers/dri/i965/brw_disasm.c | 48 +-
1 file changed, 24 insertions(+), 24 deletions(-)
diff --git
This allows us to get warnings from GCC when we mess up the format
strings.
Signed-off-by: Chris Forbes chr...@ijw.co.nz
---
src/mesa/drivers/dri/i965/brw_disasm.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/brw_disasm.c
On Fri, Mar 13, 2015 at 4:37 AM, Tapani Pälli tapani.pa...@intel.com wrote:
Patch adds required helper functions to shaderapi.h and
the actual implementation.
corresponding Piglit test:
arb_program_interface_query-getprograminterfaceiv
Signed-off-by: Tapani Pälli tapani.pa...@intel.com
Emil Velikov emil.l.veli...@gmail.com writes:
Hi all,
Allow me to sum all that is said here, plus elaborate on some of the
myths and alternative solutions proposed.
Considering that this is a never ending and somewhat emotional topic, I
would kindly ask people to read this while in their
On Fri, Mar 13, 2015 at 4:37 AM, Tapani Pälli tapani.pa...@intel.com wrote:
Patch adds required helper functions to shaderapi.h and
the actual implementation.
corresponding Piglit test:
arb_program_interface_query-resource-index
Signed-off-by: Tapani Pälli tapani.pa...@intel.com
---
Hi all,
Allow me to sum all that is said here, plus elaborate on some of the
myths and alternative solutions proposed.
Considering that this is a never ending and somewhat emotional topic, I
would kindly ask people to read this while in their happy place.
Myths
-
* The LLVM-enabled
On Fri, Mar 13 2015, Kenneth Graunke wrote:
This is already copied in two places, and I want to copy it to a third
place.
Reviewed-by: Carl Worth cwo...@cworth.org
-Carl
--
carl.d.wo...@intel.com
pgp5HqiGlRi7H.pgp
Description: PGP signature
___
On 03/12/2015 08:20 PM, Michel Dänzer wrote:
On 13.03.2015 03:07, Pierre-Loup A. Griffais wrote:
On 03/11/2015 09:40 AM, Ian Romanick wrote:
On 03/11/2015 09:31 AM, Tobias Klausmann wrote:
The problem in not forcing this to link statically is, that if a
distribution decides to not use this
This should improve the performance of any shaders using the KIL
instruction. I'm a bit surprised we missed this.
Unfortunately, I have not been able to measure any performance
improvements from this patch. It does make ARB_fragment_program
behave similarly to GLSL code.
Signed-off-by: Kenneth
This is already copied in two places, and I want to copy it to a third
place.
Signed-off-by: Kenneth Graunke kenn...@whitecape.org
---
src/mesa/drivers/dri/i965/brw_fs.cpp | 15 +++
src/mesa/drivers/dri/i965/brw_fs.h | 1 +
src/mesa/drivers/dri/i965/brw_fs_nir.cpp
This should give better cache locality, less memory consumption,
and should also be faster since we avoid a modulo operation.
Also change table size to be power of two.
This gives better performance as we can do bitmasking instead of
modulo operations for fitting the hash in the address space.
By
Should decrease collisions and therefore improve performance.
---
src/util/hash_table.c | 60 +--
src/util/set.c| 60 +--
2 files changed, 60 insertions(+), 60 deletions(-)
diff --git
Add a test to exercise a worst case collision scenario
that may cause us to not be able to find an empty
slot in the table even though it is not full.
This hits the bug in my last revision of the series
converting the hash table to quadratic probing.
---
src/util/tests/hash_table/collision.c | 14
So here comes the second version of this series.
I found a way to exercise the bug in the previous series.
This makes the test fail where it previously passed
and we instead ended up hitting assertions in the code.
This is not perfect, and several different tests could
be added, but at least it
The same rationale applies here as for the hash table.
Power of two size should give better performance,
and using the algorithm hash = sh + i/2 + i*i/2
should result in only distinct hash values when hitting collisions.
Should give a performance increase as we can do bitmasking instead
of a
From: Roland Scheidegger srol...@vmware.com
Before this actually ran into an infinite loop printing out invalid...
---
src/gallium/auxiliary/gallivm/lp_bld_debug.cpp | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/src/gallium/auxiliary/gallivm/lp_bld_debug.cpp
https://bugs.freedesktop.org/show_bug.cgi?id=89577
Connor Abbott cwabbo...@gmail.com changed:
What|Removed |Added
Status|NEW |RESOLVED
https://bugs.freedesktop.org/show_bug.cgi?id=89577
Bug ID: 89577
Summary: segfault using shader-db C runner
Product: Mesa
Version: git
Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: NEW
Severity: normal
On Fri, Mar 13, 2015 at 10:35 AM, Matt Turner matts...@gmail.com wrote:
On Fri, Mar 13, 2015 at 6:20 AM, Tapani Pälli tapani.pa...@intel.com wrote:
Commit bb33a31 introduced MAD-MUL optimization which did not
take account case where one of the remaining sources is immediate
and did not report
As requested - The previous patch to enable static libstdc++/libgcc
linking but now controlled by a configure option:
---
configure.ac| 29 +
src/gallium/Automake.inc|1 +
src/gallium/targets/dri/Makefile.am |5 +
3
On Friday, March 13, 2015 11:10:24 AM Kristian Høgsberg wrote:
On Fri, Mar 13, 2015 at 9:29 AM, Neil Roberts n...@linux.intel.com wrote:
Commit 0ac4c272755c7 made it add a header for the send message when
using SIMD4x2 on Skylake because without this it will end up using
SIMD8D. However the
On Fri, Mar 13, 2015 at 1:37 AM, Tapani Pälli tapani.pa...@intel.com wrote:
v2: update dispatch_sanity test (Jason Ekstrand)
+ small code cleanups
Signed-off-by: Tapani Pälli tapani.pa...@intel.com
---
src/mapi/glapi/gen/ARB_program_interface_query.xml | 109
+
Create a backend_inst::is_commutative() method to replace two static
functions that did the exact same thing.
Signed-off-by: Kenneth Graunke kenn...@whitecape.org
---
src/mesa/drivers/dri/i965/brw_fs.cpp | 22 ++
src/mesa/drivers/dri/i965/brw_fs.h | 1 +
Commit 36bc5f06dd22 began allowing immediates in MAD and LRP sources,
in any position. One unforeseen consequence is that opt_algebraic began
creating ADD and MUL instructions with src0 immediates.
For example,
mad(8) vgrf86:F, 1.00f, 1.00f, vgrf84:F
would be optimized into:
On Fri, Mar 13, 2015 at 4:16 PM, Kenneth Graunke kenn...@whitecape.org wrote:
Commit 36bc5f06dd22 began allowing immediates in MAD and LRP sources,
in any position. One unforeseen consequence is that opt_algebraic began
creating ADD and MUL instructions with src0 immediates.
For example,
On Friday, March 13, 2015 03:20:27 PM Tapani Pälli wrote:
Commit bb33a31 introduced MAD-MUL optimization which did not
take account case where one of the remaining sources is immediate
and did not report progress. Patch changes last one of the sources
to be immediate and adds progress
Nice. Both are
Reviewed-by: Matt Turner matts...@gmail.com
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Mesa 10.5.1 is now available. With this release we have over 50 commits
addressing a couple of bugs in the libEGL library, as well as various
fixes for the i965, r300g and freedreno drivers.
Note the external SHA1 library dependency, which was accidentally
included with the 10.5.0 release has
On Friday, March 13, 2015 04:40:17 PM Matt Turner wrote:
On Fri, Mar 13, 2015 at 4:16 PM, Kenneth Graunke kenn...@whitecape.org
wrote:
Commit 36bc5f06dd22 began allowing immediates in MAD and LRP sources,
in any position. One unforeseen consequence is that opt_algebraic began
creating
Create a backend_inst::is_commutative() method to replace two static
functions that did the exact same thing.
Signed-off-by: Kenneth Graunke kenn...@whitecape.org
---
src/mesa/drivers/dri/i965/brw_fs_cse.cpp | 24 +---
src/mesa/drivers/dri/i965/brw_shader.cpp | 22
i965 hardware doesn't allow immediates in src0. Normally, we have to
promote that to a separate instruction. To avoid this, we can flip
the operands of any commutative instructions.
Signed-off-by: Kenneth Graunke kenn...@whitecape.org
---
src/mesa/drivers/dri/i965/brw_fs.cpp | 22
---
Chad, you suggested it would be nice to remove the locking from
eglQueryString, but I don't see a way to do it. eglQueryString has
to generate EGL_NOT_INITIALIZED if the display is valid but not
initialized, and without locking it seems that there would be a
race between eglInitialize and
On Thu, Mar 12, 2015 at 2:59 PM, Carl Worth cwo...@cworth.org wrote:
On Thu, Mar 12 2015, Matt Turner wrote:
+/* The C standard library has functions round()/rint()/nearbyint() that
round
+ * their arguments according to the rounding mode set in the floating-point
+ * control register. While
Hello;
Here's the implementation of ARB_program_interface_query extension.
Patches add a resource list as part of gl_shader_program which contains
all different resources. List is then used to implement extension
functions as well as following existing queries:
GetActiveAttrib
Use _mesa_get_program_resource_name to get name.
Signed-off-by: Tapani Pälli tapani.pa...@intel.com
---
src/mesa/main/uniforms.c | 11 ++-
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/src/mesa/main/uniforms.c b/src/mesa/main/uniforms.c
index dc9b5a0..69f8a3f 100644
---
Patch adds required helper functions to shaderapi.h and
the actual implementation.
corresponding Piglit test:
arb_program_interface_query-resource-index
Signed-off-by: Tapani Pälli tapani.pa...@intel.com
---
src/mesa/main/program_resource.c | 91 +++-
Am Donnerstag, 12. März 2015, 19:57:39 schrieb Sedat Dilek:
On Sun, Mar 1, 2015 at 8:51 PM, Marc Dietrich marvi...@gmx.de wrote:
Am Sonntag 01 März 2015, 17:28:18 schrieb Sedat Dilek:
On Sun, Mar 1, 2015 at 3:09 PM, Marc Dietrich marvi...@gmx.de wrote:
This patch simplifies the visibility
On Fri, 2015-03-13 at 01:06 -0400, Ilia Mirkin wrote:
On Fri, Mar 13, 2015 at 12:46 AM, Matt Turner matts...@gmail.com wrote:
Here are some ideas I think might be reasonable GSoC ideas.
- GLSL linking in NIR
- Would allow us to stop doing optimizations and other expensive
things
IvyBridge and Haswell PRM say that the JIP should be emitted
with type W but we were using UD. The previous implementation
did not show adverse effects, however changing the type to
D caused a GPU hang, see bug 84557; IMHO it is safer to
follow the specification thoroughly.
---
Patch adds required helper functions to shaderapi.h and
the actual implementation.
The added functionality can be tested by tests for following
functions that are refactored by later patches:
GetFragDataIndex
Signed-off-by: Tapani Pälli tapani.pa...@intel.com
---
Use _mesa_program_resource_index to get indices.
Signed-off-by: Tapani Pälli tapani.pa...@intel.com
---
src/mesa/main/uniforms.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/mesa/main/uniforms.c b/src/mesa/main/uniforms.c
index 0c16641..f4de1df 100644
---
Patch adds ProgramResourceList to gl_shader_program structure.
List contains references to active program resources and is
constructed during linking phase.
This list will be used by follow-up patches to implement hooks
for GL_ARB_program_interface_query. It can be also used to
implement any of
Use _mesa_program_resource_location to get location.
Signed-off-by: Tapani Pälli tapani.pa...@intel.com
---
src/mesa/main/uniforms.c | 19 +--
1 file changed, 1 insertion(+), 18 deletions(-)
diff --git a/src/mesa/main/uniforms.c b/src/mesa/main/uniforms.c
index 8872344..0c16641
Patch adds required helper functions to shaderapi.h and
the actual implementation.
corresponding Piglit test:
arb_program_interface_query-resource-location
The added functionality can be tested by tests for following
functions that are refactored by later patches:
GetAttribLocation
Patch adds required helper functions to shaderapi.h and
the actual implementation.
Name generation copied from '_mesa_get_uniform_name' which can
be removed later by refactoring functions to use resource list.
The added functionality can be tested by tests for following
functions that are
Use program_resource_location to fetch location.
Signed-off-by: Tapani Pälli tapani.pa...@intel.com
---
src/mesa/main/shader_query.cpp | 28 ++--
1 file changed, 6 insertions(+), 22 deletions(-)
diff --git a/src/mesa/main/shader_query.cpp b/src/mesa/main/shader_query.cpp
Patch adds required helper functions to shaderapi.h and
the actual implementation.
The property query functionality can be tested with tests for
following functions that are refactored by later patches:
GetActiveAtomicCounterBufferiv
GetActiveUniformBlockiv
GetActiveUniformsiv
Instead of iterating IR, retrieve required information through
the new program resource functions.
Signed-off-by: Tapani Pälli tapani.pa...@intel.com
---
src/mesa/main/shader_query.cpp | 58 --
1 file changed, 27 insertions(+), 31 deletions(-)
diff --git
Signed-off-by: Tapani Pälli tapani.pa...@intel.com
---
src/mesa/main/uniform_query.cpp | 33 -
1 file changed, 16 insertions(+), 17 deletions(-)
diff --git a/src/mesa/main/uniform_query.cpp b/src/mesa/main/uniform_query.cpp
index 217473a..3a2caa2 100644
---
Use _mesa_get_program_resource_name to get name.
Signed-off-by: Tapani Pälli tapani.pa...@intel.com
---
src/mesa/main/uniforms.c | 18 +-
1 file changed, 5 insertions(+), 13 deletions(-)
diff --git a/src/mesa/main/uniforms.c b/src/mesa/main/uniforms.c
index 078e433..8872344
v2: update dispatch_sanity test (Jason Ekstrand)
+ small code cleanups
Signed-off-by: Tapani Pälli tapani.pa...@intel.com
---
src/mapi/glapi/gen/ARB_program_interface_query.xml | 109 +
src/mapi/glapi/gen/gl_API.xml | 2 +
Use _mesa_program_resource_index to get index.
Signed-off-by: Tapani Pälli tapani.pa...@intel.com
---
src/mesa/main/uniforms.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/mesa/main/uniforms.c b/src/mesa/main/uniforms.c
index f4de1df..5548d1d 100644
---
Use _mesa_program_resource_location_index to fetch index.
Signed-off-by: Tapani Pälli tapani.pa...@intel.com
---
src/mesa/main/shader_query.cpp | 25 ++---
1 file changed, 2 insertions(+), 23 deletions(-)
diff --git a/src/mesa/main/shader_query.cpp
Patch adds new function 'mesa_bufferiv' and refactors existing
GetActiveUniformBlockiv and GetActiveAtomicCounterBufferiv to
use it.
corresponding Piglit tests:
arb_uniform_buffer_object*
arb_shader_atomic_counters*
(Many tests hit the corresponding queries.)
Signed-off-by: Tapani Pälli
(and mark it as DONE in docs/GL3.txt)
Signed-off-by: Tapani Pälli tapani.pa...@intel.com
---
docs/GL3.txt | 4 ++--
src/mesa/main/extensions.c | 1 +
src/mesa/main/mtypes.h | 1 +
3 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/docs/GL3.txt b/docs/GL3.txt
index
Patch adds required helper functions to shaderapi.h and
the actual implementation.
corresponding Piglit test:
arb_program_interface_query-getprograminterfaceiv
Signed-off-by: Tapani Pälli tapani.pa...@intel.com
---
src/mesa/main/program_resource.c | 79
Use program_resource_location to fetch location.
Signed-off-by: Tapani Pälli tapani.pa...@intel.com
---
src/mesa/main/shader_query.cpp | 33 ++---
1 file changed, 10 insertions(+), 23 deletions(-)
diff --git a/src/mesa/main/shader_query.cpp
Signed-off-by: Tapani Pälli tapani.pa...@intel.com
---
src/mesa/main/uniforms.c | 39 ---
src/mesa/main/uniforms.h | 5 -
2 files changed, 44 deletions(-)
diff --git a/src/mesa/main/uniforms.c b/src/mesa/main/uniforms.c
index 69f8a3f..078e433 100644
---
Signed-off-by: Tapani Pälli tapani.pa...@intel.com
---
src/mesa/main/transformfeedback.c | 19 ---
1 file changed, 12 insertions(+), 7 deletions(-)
diff --git a/src/mesa/main/transformfeedback.c
b/src/mesa/main/transformfeedback.c
index a3e23ce..cf4de33 100644
---
Signed-off-by: Tapani Pälli tapani.pa...@intel.com
---
src/mesa/main/uniform_query.cpp | 107 ++--
1 file changed, 38 insertions(+), 69 deletions(-)
diff --git a/src/mesa/main/uniform_query.cpp b/src/mesa/main/uniform_query.cpp
index 9f82de9..217473a 100644
On 12/03/15 14:36, Brian Paul wrote:
eglcurrent.c: In function '_eglSetTSD':
eglcurrent.c:57:4: warning: passing argument 2 of 'tss_set' discards
'const' qualifier from pointer target type [enabled by default]
tss_set(_egl_TSD, (const void *) t);
^
In file included from
Tapani Pälli tapani.pa...@intel.com writes:
Commit bb33a31 introduced MAD-MUL optimization which did not
take account case where one of the remaining sources is immediate
and did not report progress. Patch changes last one of the sources
to be immediate and adds progress reporting. If both
Iago Toral Quiroga ito...@igalia.com writes:
This is a problem when we have IR like this:
(array_ref (var_ref temps) (swiz x (expression ivec4 bitcast_f2i
(swiz (array_ref (var_ref temps) (constant int (2)) ) )) )) ) )
where we are indexing an array with the result of an expression
Commit bb33a31 introduced MAD-MUL optimization which did not
take account case where one of the remaining sources is immediate
and did not report progress. Patch changes last one of the sources
to be immediate and adds progress reporting. If both are, this is
taken care of by the same
On 03/13/2015 07:52 AM, Jose Fonseca wrote:
On 12/03/15 23:08, Brian Paul wrote:
On 03/12/2015 05:03 PM, Matt Turner wrote:
On Thu, Mar 12, 2015 at 2:54 PM, Brian Paul bri...@vmware.com wrote:
---
src/gallium/auxiliary/util/u_slab.h | 13 +++--
1 file changed, 11 insertions(+), 2
On 13/03/15 00:50, Alexandre Demers wrote:
Fix typo in comment introduced by 70dc8a
Signed-off-by: Alexandre Demers alexandre.f.dem...@gmail.com
---
src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
This is a problem when we have IR like this:
(array_ref (var_ref temps) (swiz x (expression ivec4 bitcast_f2i
(swiz (array_ref (var_ref temps) (constant int (2)) ) )) )) ) )
where we are indexing an array with the result of an expression that
accesses the same array.
In this scenario,
On 13/03/15 13:58, Brian Paul wrote:
On 03/13/2015 07:52 AM, Jose Fonseca wrote:
On 12/03/15 23:08, Brian Paul wrote:
On 03/12/2015 05:03 PM, Matt Turner wrote:
On Thu, Mar 12, 2015 at 2:54 PM, Brian Paul bri...@vmware.com wrote:
---
src/gallium/auxiliary/util/u_slab.h | 13 +++--
On 12/03/15 23:08, Brian Paul wrote:
On 03/12/2015 05:03 PM, Matt Turner wrote:
On Thu, Mar 12, 2015 at 2:54 PM, Brian Paul bri...@vmware.com wrote:
---
src/gallium/auxiliary/util/u_slab.h | 13 +++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git
Hi,
I just merged the 4 patches after fixing your last comments.
Thanks a lot for your reviews and patience.
cheers,
Eduardo
On 03/12/2015 06:22 PM, Laura Ekstrand wrote:
On Thu, Mar 12, 2015 at 12:14 AM, Eduardo Lima Mitev el...@igalia.com
mailto:el...@igalia.com wrote:
On Fri, Mar 13, 2015 at 4:37 AM, Tapani Pälli tapani.pa...@intel.com wrote:
diff --git a/src/mapi/glapi/gen/gl_API.xml b/src/mapi/glapi/gen/gl_API.xml
index 1ceb60a..11b0a45 100644
--- a/src/mapi/glapi/gen/gl_API.xml
+++ b/src/mapi/glapi/gen/gl_API.xml
@@ -8339,6 +8339,8 @@
!-- ARB
On Fri, Mar 13, 2015 at 4:37 AM, Tapani Pälli tapani.pa...@intel.com wrote:
Patch adds ProgramResourceList to gl_shader_program structure.
List contains references to active program resources and is
constructed during linking phase.
This list will be used by follow-up patches to implement
Commit 0ac4c272755c7 made it add a header for the send message when
using SIMD4x2 on Skylake because without this it will end up using
SIMD8D. However the patch missed the case when a sampler is being used
to implement constant loads from a buffer surface in a SIMD4x2 vertex
shader.
This fixes 29
The render surface state command for Skylake doesn't have the surface
array spacing bit so it's not possible to select this layout. I think
it was only used in order to make it pick a tightly-packed qpitch
value that doesn't include space for the mipmaps. However this won't
be necessary after the
On Fri, Mar 13, 2015 at 12:56 AM, Ilia Mirkin imir...@alum.mit.edu wrote:
We only program in one layer size per texture, so that means that all
levels must share one size. This makes the piglit test
bin/texelFetch fs sampler2DArray
have the same breakage as its non-array version instead of
On Skylake the qpitch value is uploaded as part of the surface state
so we don't need to add the extra rows that are done for other
generations. However for 3D textures it needs to be aligned to the
tile height and for depth/stencil textures it needs to be a multiple
of 8. Unlike previous
87 matches
Mail list logo
