Re: [Mesa-dev] Correct behaviour of glDrawPixels and glBitmap when texturing is enabled.

2015-03-24 Thread Michel Dänzer
On 24.03.2015 04:28, Matthew Dawson wrote: Moving forward, I'd like to work on making piglit pass on my hardware (basically r600/radeonsi right now) for the non-skipped tests. Would that be ok to push forward within mesa, even it touches similar obscure features? Or would it be

Re: [Mesa-dev] [PATCH] nir: Handle vector arguments to logical and/or/xor.

2015-03-24 Thread Connor Abbott
We could already handle vector arguments to these -- we just couldn't handle mixed scalar and vector arguments. So change the commit message to something like nir: Handle mixed scalar/vector arguments to logical and/or/xor. and fix the typo and then this is Reviewed-by: Connor Abbott

Re: [Mesa-dev] [PATCH 04/23] i965/fs: Don't emit dumb SEL

2015-03-24 Thread Tapani Pälli
On 03/20/2015 10:58 PM, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com With previous changes to emit more ir_triop_csel, the i965 channel expressions pass can generate sequences like: mov(8) g451F 1F (+f0) sel(8)g401F g458,8,1F 1F There are

Re: [Mesa-dev] [PATCH] radeonsi/compute: Default to the same PIPE_SHADER_CAP values as other shader types v2

2015-03-24 Thread Marek Olšák
Reviewed-by: Marek Olšák marek.ol...@amd.com Marek On Mon, Mar 23, 2015 at 3:53 PM, Tom Stellard thomas.stell...@amd.com wrote: v2: - Fix typo --- src/gallium/drivers/radeonsi/si_pipe.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH] glsl: avoid calling base_alignment when samplers are involved

2015-03-24 Thread Tapani Pälli
Reviewed-by: Tapani Palli tapani.pa...@intel.com On 03/23/2015 02:00 PM, Ilia Mirkin wrote: Earlier commit 53bf7c8fd2e changed the logic to always call base_alignment on structs. 1ec715ce8b12 hacked the function to return 0 for sampler fields, but didn't handle sampler arrays. Instead of

Re: [Mesa-dev] [RFC] More ARB_arrays_of_arrays support

2015-03-24 Thread Timothy Arceri
On Sat, 2015-03-21 at 09:27 -0700, Jason Ekstrand wrote: On Mar 21, 2015 2:49 AM, Timothy Arceri t_arc...@yahoo.com.au wrote: This series adds most of the remaining glsl arrays of arrays support. Support for uniform blocks is still missing, I've played around with this but don't have

Re: [Mesa-dev] [PATCH 2/6] nir: Implement a Mesa IR - NIR translator.

2015-03-24 Thread Connor Abbott
On Mon, Mar 23, 2015 at 8:37 PM, Kenneth Graunke kenn...@whitecape.org wrote: Shamelessly ripped off from Eric Anholt's tgsi_to_nir pass. Not compiled on SCons, like the rest of NIR. Signed-off-by: Kenneth Graunke kenn...@whitecape.org --- src/mesa/Makefile.am|2 +

Re: [Mesa-dev] [PATCH 1/3] mesa: Improve validation of target, format and type of glTexSubImage[2, 3]D

2015-03-24 Thread Laura Ekstrand
On Tue, Mar 24, 2015 at 11:34 AM, Eduardo Lima Mitev el...@igalia.com wrote: Thanks for the review! Please see some comments inline: On 03/23/2015 06:53 PM, Laura Ekstrand wrote: I'm glad you found this target checking problem. I have come across the same problem in other texture

Re: [Mesa-dev] [Mesa-stable] [PATCH] clover: Call clBuildProgram() notification function when build completes

2015-03-24 Thread Francisco Jerez
Tom Stellard thomas.stell...@amd.com writes: Cc: 10.5 10.4 mesa-sta...@lists.freedesktop.org --- src/gallium/state_trackers/clover/api/program.cpp | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium/state_trackers/clover/api/program.cpp

Re: [Mesa-dev] [PATCH 04/23] i965/fs: Don't emit dumb SEL

2015-03-24 Thread Ian Romanick
On 03/24/2015 05:01 AM, Tapani Pälli wrote: On 03/20/2015 10:58 PM, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com With previous changes to emit more ir_triop_csel, the i965 channel expressions pass can generate sequences like: mov(8) g451F 1F

Re: [Mesa-dev] [PATCH 7/9] nir/peephole_ffma: Be less agressive about fusing multiply-adds

2015-03-24 Thread Connor Abbott
I think this is being both too aggressive and not aggressive enough. First, the too aggressive part. Imagine if we have something like: a = mul b, c; d = add a, 1.0; e = add a, 2.0; f = add a, 3.0; In this case, we don't want to turn this into a series of 3 mad's since the 3 load immediate

Re: [Mesa-dev] [PATCH v4 15/17] main: Added entry point for glGetNamedRenderbufferParameteriv

2015-03-24 Thread Laura Ekstrand
This looks good. Reviewed-by: Laura Ekstrand la...@jlekstrand.net On Tue, Mar 24, 2015 at 7:42 AM, Martin Peres martin.pe...@linux.intel.com wrote: v2: - improve an error message Reviewed-by: Laura Ekstrand la...@jlekstrand.net v3: - move a test to less generic functions - fix an

Re: [Mesa-dev] [PATCH 2/6] nir: Implement a Mesa IR - NIR translator.

2015-03-24 Thread Kenneth Graunke
On Tuesday, March 24, 2015 08:52:01 PM Emil Velikov wrote: Hi Ken, On 24/03/15 00:37, Kenneth Graunke wrote: Shamelessly ripped off from Eric Anholt's tgsi_to_nir pass. Not compiled on SCons, like the rest of NIR. Signed-off-by: Kenneth Graunke kenn...@whitecape.org ---

Re: [Mesa-dev] [PATCH 7/9] nir/peephole_ffma: Be less agressive about fusing multiply-adds

2015-03-24 Thread Jason Ekstrand
First off, these are all heuristics and we need to keep that in mind. On Tue, Mar 24, 2015 at 3:39 PM, Connor Abbott cwabbo...@gmail.com wrote: I think this is being both too aggressive and not aggressive enough. First, the too aggressive part. Imagine if we have something like: a = mul b, c;

Re: [Mesa-dev] [PATCH 3/6] i965/fs: Implement nir_opcode_fsub/isub support.

2015-03-24 Thread Connor Abbott
We already have a lower_negate compiler option, so I think it would be better to add the 1 line of code to lower sub - neg predicated on !lower_neg to nir_opt_algebraic. On Mon, Mar 23, 2015 at 8:37 PM, Kenneth Graunke kenn...@whitecape.org wrote: prog_to_nir uses this for OPCODE_SUB.

Re: [Mesa-dev] [PATCH v4 16/17] main: Added entry points for NamedRenderbufferStorage/Multisample

2015-03-24 Thread Laura Ekstrand
Looks good to me. Reviewed-by: Laura Ekstrand la...@jlekstrand.net On Tue, Mar 24, 2015 at 7:43 AM, Martin Peres martin.pe...@linux.intel.com wrote: v2: Review from Laura Ekstrand - get rid of a change that should not have happened in this patch - improve the error messages - fix alignments

Re: [Mesa-dev] [PATCH 8/8] util/u_atomic: Ignore warnings interlocked accesses.

2015-03-24 Thread Brian Paul
On 03/24/2015 03:16 PM, Jose Fonseca wrote: These are due how we implemented the atomic tests, not the atomic implementation itself. It's also difficult to refactor the code to avoid the warnings due to the use of macros -- the code would be quite hairy. --- src/util/u_atomic_test.c | 5 +

[Mesa-dev] [PATCH v4 16/17] main: Added entry points for NamedRenderbufferStorage/Multisample

2015-03-24 Thread Martin Peres
v2: Review from Laura Ekstrand - get rid of a change that should not have happened in this patch - improve the error messages - fix alignments - fix a capitalization in a function name in an error message v3: Review from Laura Ekstrand - move the test for the validity of the renderbuffer to less

[Mesa-dev] [Bug 89726] [Bisected] dEQP-GLES3: uniform linking logic in the presence of structs

2015-03-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89726 Ilia Mirkin imir...@alum.mit.edu changed: What|Removed |Added Status|NEW |RESOLVED

Re: [Mesa-dev] [PATCH 7/9] nir/peephole_ffma: Be less agressive about fusing multiply-adds

2015-03-24 Thread Matt Turner
On Tue, Mar 24, 2015 at 3:39 PM, Connor Abbott cwabbo...@gmail.com wrote: I think this is being both too aggressive and not aggressive enough. First, the too aggressive part. Imagine if we have something like: a = mul b, c; d = add a, 1.0; e = add a, 2.0; f = add a, 3.0; In this case, we

[Mesa-dev] [Bug 89754] vertexAttrib fails WebGL Conformance test with mesa drivers

2015-03-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89754 Bug ID: 89754 Summary: vertexAttrib fails WebGL Conformance test with mesa drivers Product: Mesa Version: unspecified Hardware: Other OS: All

[Mesa-dev] Building Mesa for Windows using Visual Studio

2015-03-24 Thread Shervin Sharifi
Hi, I'm new to Mesa. I'm trying to build Mesa for Windows using Visual Studio, but couldn't find instructions for that. The related threads on this mailing list also seem outdated. Could anyone give me some hint or point me to instructions if there is any? Thanks, Shervin

[Mesa-dev] [PATCH] mesa: Apply visibility flags to src/Makefile.am targets

2015-03-24 Thread Kristian Høgsberg
From: Kristian Høgsberg k...@bitplanet.net We were building libglsl_util.la without our visibility flags and leaking hash_table_* symbols. Signed-off-by: Kristian Høgsberg kristian.h.kristen...@intel.com --- src/Makefile.am | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/Makefile.am

Re: [Mesa-dev] [PATCH 2/6] nir: Implement a Mesa IR - NIR translator.

2015-03-24 Thread Eric Anholt
Kenneth Graunke kenn...@whitecape.org writes: Shamelessly ripped off from Eric Anholt's tgsi_to_nir pass. Not compiled on SCons, like the rest of NIR. Signed-off-by: Kenneth Graunke kenn...@whitecape.org Nice. I think at some point we'll want a lowering pass for texture projection. The

Re: [Mesa-dev] [PATCH] mesa: Apply visibility flags to src/Makefile.am targets

2015-03-24 Thread Matt Turner
Reviewed-by: Matt Turner matts...@gmail.com ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 89754] vertexAttrib fails WebGL Conformance test with mesa drivers

2015-03-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89754 --- Comment #1 from Tapani Pälli lem...@gmail.com --- test passes on i965 driver -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. ___

[Mesa-dev] [PATCH] i965/fs: Allow CSE to handle MULs with negated arguments.

2015-03-24 Thread Matt Turner
mul x, -y is equivalent to mul -x, y; and mul x, y is the negation of mul x, -y. Without NIR: total instructions in shared programs: 6192304 - 6185280 (-0.11%) instructions in affected programs: 987931 - 980907 (-0.71%) helped:4146 HURT:

Re: [Mesa-dev] [PATCH v3 15/17] main: Added entry point for glGetNamedRenderbufferParameteriv

2015-03-24 Thread Martin Peres
On 24/03/15 00:12, Laura Ekstrand wrote: On Mon, Mar 23, 2015 at 12:04 PM, Martin Peres martin.pe...@linux.intel.com mailto:martin.pe...@linux.intel.com wrote: v2: - improve an error message Reviewed-by: Laura Ekstrand la...@jlekstrand.net mailto:la...@jlekstrand.net

Re: [Mesa-dev] [PATCH v3 16/17] main: Added entry points for NamedRenderbufferStorage/Multisample

2015-03-24 Thread Martin Peres
On 24/03/15 00:37, Laura Ekstrand wrote: On Mon, Mar 23, 2015 at 12:14 PM, Martin Peres martin.pe...@linux.intel.com mailto:martin.pe...@linux.intel.com wrote: v2: Review from Laura Ekstrand - get rid of a change that should not have happened in this patch - improve the error

[Mesa-dev] [PATCH 18.2/23] glsl: Implement remaining as_foo functions with macros

2015-03-24 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com The downcast functions for non-leaf classes were previously implemented by hand. Now they are implemented using macros based on the is_foo functions added in the previous patch. Signed-off-by: Ian Romanick ian.d.roman...@intel.com Cc: Francisco Jerez

[Mesa-dev] [PATCH 18.3/23] glsl: Constify the as_foo functions

2015-03-24 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Now that they're all implemented using macros, this is trivial. Signed-off-by: Ian Romanick ian.d.roman...@intel.com Cc: Francisco Jerez curroje...@riseup.net --- src/glsl/ir.h | 10 ++ 1 file changed, 10 insertions(+) diff --git

[Mesa-dev] [PATCH 18.4/23] glsl: Constify ir_instruction::equals

2015-03-24 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com v2: Don't be lazy. Constify the as_foo functions and use those instead of ugly casts. Suggested by Curro. Signed-off-by: Ian Romanick ian.d.roman...@intel.com Cc: Francisco Jerez curroje...@riseup.net --- src/glsl/ir.h | 21

[Mesa-dev] [PATCH 18.1/23] glsl: Add is_rvalue, is_dereference, and is_jump methods

2015-03-24 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com These functions deteremine when an IR node is one of the non-leaf classes. Signed-off-by: Ian Romanick ian.d.roman...@intel.com Cc: Francisco Jerez curroje...@riseup.net --- src/glsl/ir.h | 25 + 1 file changed, 25

Re: [Mesa-dev] [PATCH 1/3] mesa: Improve validation of target, format and type of glTexSubImage[2, 3]D

2015-03-24 Thread Eduardo Lima Mitev
Thanks for the review! Please see some comments inline: On 03/23/2015 06:53 PM, Laura Ekstrand wrote: I'm glad you found this target checking problem. I have come across the same problem in other texture functions, but I have been too busy to find all instances of this. It's kind of a

Re: [Mesa-dev] [PATCH] r600g/sb: Enable SB for geometry shaders

2015-03-24 Thread Dieter Nützel
Am 20.03.2015 14:13, schrieb Glenn Kennard: Add SV_GEOMETRY_EMIT special variable type to track the implicit dependencies between CUT/EMIT_VERTEX/MEM_RING instructions so GCM/scheduler doesn't reorder them. Mark emit instructions as unkillable so DCE doesn't eat them. Signed-off-by: Glenn

Re: [Mesa-dev] [PATCH 2/2] clover: Add support for handling reqd_work_group_size attribute

2015-03-24 Thread Francisco Jerez
Tom Stellard thomas.stell...@amd.com writes: This patch enables clover to return the correct value for CL_KERNEL_COMPILE_WORK_GROUP_SIZE and also verify that the correct local_work_size is used when enqueuing kernels with this attribute. I doubt it makes sense to pass these around as kernel

[Mesa-dev] [PATCH 2/2] clover: Add support for handling reqd_work_group_size attribute

2015-03-24 Thread Tom Stellard
This patch enables clover to return the correct value for CL_KERNEL_COMPILE_WORK_GROUP_SIZE and also verify that the correct local_work_size is used when enqueuing kernels with this attribute. --- src/gallium/state_trackers/clover/api/kernel.cpp | 9 +++-

[Mesa-dev] [PATCH 1/2] clover: Use a structure to hold information about llvm kernel functions

2015-03-24 Thread Tom Stellard
--- .../state_trackers/clover/llvm/invocation.cpp | 71 +- 1 file changed, 41 insertions(+), 30 deletions(-) diff --git a/src/gallium/state_trackers/clover/llvm/invocation.cpp b/src/gallium/state_trackers/clover/llvm/invocation.cpp index 4da62b9..28198a5 100644 ---

Re: [Mesa-dev] [PATCH 1/2] clover: Use a structure to hold information about llvm kernel functions

2015-03-24 Thread Francisco Jerez
Tom Stellard thomas.stell...@amd.com writes: --- .../state_trackers/clover/llvm/invocation.cpp | 71 +- 1 file changed, 41 insertions(+), 30 deletions(-) This seems kind of ugly to me, what are you trying to achieve exactly? diff --git

Re: [Mesa-dev] [PATCH 1/2] clover: Use a structure to hold information about llvm kernel functions

2015-03-24 Thread Tom Stellard
On Tue, Mar 24, 2015 at 06:51:31PM +0200, Francisco Jerez wrote: Tom Stellard thomas.stell...@amd.com writes: --- .../state_trackers/clover/llvm/invocation.cpp | 71 +- 1 file changed, 41 insertions(+), 30 deletions(-) This seems kind of ugly to me, what

Re: [Mesa-dev] [PATCH 1/1] Fix runtime error with uClibc

2015-03-24 Thread Emil Velikov
On 23/03/15 20:45, Bernd Kuhls wrote: Matt Turner matts...@gmail.com wrote in news:caedq38ela86kqtjkagscovt70ep8ato3aeqtowbuvk-+xuf...@mail.gmail.com: so maybe uclibc just needs to add them. Hi, they did :) http://git.uclibc.org/uClibc/commit/?id=

[Mesa-dev] [Bug 89586] Drivers/DRI/swrast

2015-03-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89586 --- Comment #25 from Dan Sebald daniel.seb...@ieee.org --- I will attach an initial attempt at a Piglit test suite for glPixelZoom() in combination with glDrawPixels(). I tried (but failed) to set something up in which if a test fails the

[Mesa-dev] [Bug 89586] Drivers/DRI/swrast

2015-03-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89586 --- Comment #27 from Dan Sebald daniel.seb...@ieee.org --- Created attachment 114592 -- https://bugs.freedesktop.org/attachment.cgi?id=114592action=edit swrast legacy Piglit test images SWRAST_DRI.SO LEGACY This is the current repository

[Mesa-dev] [Bug 89586] Drivers/DRI/swrast

2015-03-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89586 --- Comment #26 from Dan Sebald daniel.seb...@ieee.org --- Created attachment 114591 -- https://bugs.freedesktop.org/attachment.cgi?id=114591action=edit Piglit pixelzoom test suite See https://bugs.freedesktop.org/show_bug.cgi?id=89586#c25 for

[Mesa-dev] [Bug 89586] Drivers/DRI/swrast

2015-03-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89586 --- Comment #28 from Dan Sebald daniel.seb...@ieee.org --- Created attachment 114593 -- https://bugs.freedesktop.org/attachment.cgi?id=114593action=edit swrast legacy with patch Piglit test images SWRAST_DRI.SO LEGACY PATCH With the Mesa

[Mesa-dev] [Bug 89586] Drivers/DRI/swrast

2015-03-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89586 --- Comment #30 from Dan Sebald daniel.seb...@ieee.org --- Created attachment 114595 -- https://bugs.freedesktop.org/attachment.cgi?id=114595action=edit swrast Gallium with patch Piglit test images SWRAST_DRI.SO GALLIUM PATCH By making that

Re: [Mesa-dev] [PATCH 2/2] st/egl: don't ship the dri2, c link at the tarball

2015-03-24 Thread Jose Fonseca
On 23/03/15 16:15, Emil Velikov wrote: During 'make dist' the path of the symbolic link (x11/dri2.c) becomes too long, and tar converts it to hard one. To make it more complicated on Haiku tar errors out (due to lack of hardlink support) rather than falling back to the next best thing. So remove

Re: [Mesa-dev] [PATCH] r600g/sb: Enable SB for geometry shaders

2015-03-24 Thread Glenn Kennard
On Tue, 24 Mar 2015 17:21:35 +0100, Dieter Nützel die...@nuetzel-hh.de wrote: Am 20.03.2015 14:13, schrieb Glenn Kennard: Add SV_GEOMETRY_EMIT special variable type to track the implicit dependencies between CUT/EMIT_VERTEX/MEM_RING instructions so GCM/scheduler doesn't reorder them. Mark

[Mesa-dev] [Bug 89586] Drivers/DRI/swrast

2015-03-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89586 --- Comment #29 from Dan Sebald daniel.seb...@ieee.org --- Created attachment 114594 -- https://bugs.freedesktop.org/attachment.cgi?id=114594action=edit swrast Gallium Piglit test images SWRAST_DRI.SO GALLIUM The test images illustrate how

[Mesa-dev] [PATCH V2 06/12] glsl: dont allow gl_PerVertex to be redeclared as an array of arrays

2015-03-24 Thread Timothy Arceri
V2: move single dimensionial array detection into a helper Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au --- src/glsl/ast.h | 8 src/glsl/ast_to_hir.cpp | 3 ++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/src/glsl/ast.h b/src/glsl/ast.h index

[Mesa-dev] [Bug 88885] Transform feedback uses incorrect interleaving if a previous draw did not write gl_Position

2015-03-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=5 --- Comment #3 from Tapani Pälli lem...@gmail.com --- Thanks Chris! This commit has fixed also rendering issues with some of the heavyweight UE4 demos where we had 'yellow tint' colors. -- You are receiving this mail because: You are the QA

Re: [Mesa-dev] [PATCH] dri3_glx.c: Pass NULL DRI drawables into driver for None GLX drawables

2015-03-24 Thread Axel Davy
Le 24/03/2015 06:50, Zhang, Xiong Y a écrit : You seem to miss the case when one is None and not the other. It should return BadDrawable too. This particular case seems not handled by the dri2 code either, and the gallium state tracker seems to handle it in bindContext, but not the intel code

Re: [Mesa-dev] [PATCH 1/2] configure.ac: move AC_MSG_RESULT reportging back into the m4 macro

2015-03-24 Thread Samuel Iglesias Gonsálvez
Thanks Emil! Reviewed-by: Samuel Iglesias Gonsalvez sigles...@igalia.com Sam On Monday 23 March 2015 17:49:23 Emil Velikov wrote: The one who does AC_MSG_CHECKING should provide the AC_MSG_RESULT. Fixed: ced9425327b (configure: Introduce new output variable to

[Mesa-dev] [PATCH V2 12/12] glsl: Add support for lowering interface block arrays of arrays

2015-03-24 Thread Timothy Arceri
V2: make array processing functions static --- src/glsl/lower_named_interface_blocks.cpp | 51 ++- 1 file changed, 37 insertions(+), 14 deletions(-) diff --git a/src/glsl/lower_named_interface_blocks.cpp b/src/glsl/lower_named_interface_blocks.cpp index

[Mesa-dev] [PATCH v4 15/17] main: Added entry point for glGetNamedRenderbufferParameteriv

2015-03-24 Thread Martin Peres
v2: - improve an error message Reviewed-by: Laura Ekstrand la...@jlekstrand.net v3: - move a test to less generic functions - fix an alignment v4: - take the caller as a parameter instead of bool dsa - check that the lookup returns a valid renderbuffer Signed-off-by: Martin Peres

Re: [Mesa-dev] [PATCH] clover: Return CL_BUILD_ERROR for CL_PROGRAM_BUILD_STATUS when compilation fails

2015-03-24 Thread Francisco Jerez
Jan Vesely jan.ves...@rutgers.edu writes: On Tue, 2015-03-24 at 22:24 +0200, Francisco Jerez wrote: Tom Stellard thomas.stell...@amd.com writes: Cc: 10.5 10.4 mesa-sta...@lists.freedesktop.org --- src/gallium/state_trackers/clover/core/program.cpp | 6 +-

Re: [Mesa-dev] [PATCH] gallium/util: Define ffsll on OpenBSD.

2015-03-24 Thread Emil Velikov
On 21/03/15 17:12, Matt Turner wrote: On Sat, Mar 21, 2015 at 10:10 AM, Emil Velikov emil.l.veli...@gmail.com wrote: On 17/03/15 23:44, Emil Velikov wrote: On 17/03/15 01:25, Jonathan Gray wrote: On Mon, Mar 16, 2015 at 08:37:28PM +, Emil Velikov wrote: On 26/02/15 13:49, Jose Fonseca

Re: [Mesa-dev] [PATCH] clover: Return CL_BUILD_ERROR for CL_PROGRAM_BUILD_STATUS when compilation fails

2015-03-24 Thread Tom Stellard
On Tue, Mar 24, 2015 at 10:36:19PM +0200, Francisco Jerez wrote: Jan Vesely jan.ves...@rutgers.edu writes: On Tue, 2015-03-24 at 22:24 +0200, Francisco Jerez wrote: Tom Stellard thomas.stell...@amd.com writes: Cc: 10.5 10.4 mesa-sta...@lists.freedesktop.org ---

Re: [Mesa-dev] [PATCH 1/3] makefile: add all headers to the tarball

2015-03-24 Thread Emil Velikov
On 23/03/15 17:16, Matt Turner wrote: Thanks Emil. For the series Reviewed-by: Matt Turner matts...@gmail.com YW. I'll get those in asap, seeing that Ken has been having fun on (somewhat related) topic. -Emil ___ mesa-dev mailing list

[Mesa-dev] [PATCH] clover: Call clBuildProgram() notification function when build completes

2015-03-24 Thread Tom Stellard
Cc: 10.5 10.4 mesa-sta...@lists.freedesktop.org --- src/gallium/state_trackers/clover/api/program.cpp | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium/state_trackers/clover/api/program.cpp b/src/gallium/state_trackers/clover/api/program.cpp index 60184ed..fcec1d7 100644 ---

Re: [Mesa-dev] [PATCH 2/6] nir: Implement a Mesa IR - NIR translator.

2015-03-24 Thread Emil Velikov
Hi Ken, On 24/03/15 00:37, Kenneth Graunke wrote: Shamelessly ripped off from Eric Anholt's tgsi_to_nir pass. Not compiled on SCons, like the rest of NIR. Signed-off-by: Kenneth Graunke kenn...@whitecape.org --- src/mesa/Makefile.am|2 + src/mesa/Makefile.sources

[Mesa-dev] [PATCH] clover: Return CL_BUILD_ERROR for CL_PROGRAM_BUILD_STATUS when compilation fails

2015-03-24 Thread Tom Stellard
Cc: 10.5 10.4 mesa-sta...@lists.freedesktop.org --- src/gallium/state_trackers/clover/core/program.cpp | 6 +- src/gallium/state_trackers/clover/core/program.hpp | 1 + 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/clover/core/program.cpp

[Mesa-dev] [Bug 89586] Drivers/DRI/swrast

2015-03-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89586 --- Comment #33 from Dan Sebald daniel.seb...@ieee.org --- Created attachment 114598 -- https://bugs.freedesktop.org/attachment.cgi?id=114598action=edit swrast Gallium Piglit test images SWRAST_DRI.SO GALLIUM The test images illustrate how

[Mesa-dev] [Bug 89586] Drivers/DRI/swrast

2015-03-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89586 --- Comment #34 from Dan Sebald daniel.seb...@ieee.org --- Created attachment 114599 -- https://bugs.freedesktop.org/attachment.cgi?id=114599action=edit swrast Gallium with patch Piglit test images SWRAST_DRI.SO GALLIUM PATCH By making that

Re: [Mesa-dev] [PATCH] clover: Return CL_BUILD_ERROR for CL_PROGRAM_BUILD_STATUS when compilation fails

2015-03-24 Thread Francisco Jerez
Tom Stellard thomas.stell...@amd.com writes: Cc: 10.5 10.4 mesa-sta...@lists.freedesktop.org --- src/gallium/state_trackers/clover/core/program.cpp | 6 +- src/gallium/state_trackers/clover/core/program.hpp | 1 + 2 files changed, 6 insertions(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH] clover: Return CL_BUILD_ERROR for CL_PROGRAM_BUILD_STATUS when compilation fails

2015-03-24 Thread Jan Vesely
On Tue, 2015-03-24 at 22:24 +0200, Francisco Jerez wrote: Tom Stellard thomas.stell...@amd.com writes: Cc: 10.5 10.4 mesa-sta...@lists.freedesktop.org --- src/gallium/state_trackers/clover/core/program.cpp | 6 +- src/gallium/state_trackers/clover/core/program.hpp | 1 + 2 files

[Mesa-dev] [Bug 89586] Drivers/DRI/swrast

2015-03-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89586 --- Comment #31 from Dan Sebald daniel.seb...@ieee.org --- Created attachment 114596 -- https://bugs.freedesktop.org/attachment.cgi?id=114596action=edit swrast legacy Piglit test images SWRAST_DRI.SO LEGACY This is the current repository

[Mesa-dev] [Bug 89586] Drivers/DRI/swrast

2015-03-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89586 --- Comment #32 from Dan Sebald daniel.seb...@ieee.org --- Created attachment 114597 -- https://bugs.freedesktop.org/attachment.cgi?id=114597action=edit swrast legacy with patch Piglit test images SWRAST_DRI.SO LEGACY PATCH With the Mesa

[Mesa-dev] [Bug 89586] Drivers/DRI/swrast

2015-03-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89586 Dan Sebald daniel.seb...@ieee.org changed: What|Removed |Added Attachment #114594|0 |1 is

[Mesa-dev] [Bug 89586] Drivers/DRI/swrast

2015-03-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89586 Dan Sebald daniel.seb...@ieee.org changed: What|Removed |Added Attachment #114593|0 |1 is

[Mesa-dev] [Bug 89586] Drivers/DRI/swrast

2015-03-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89586 Dan Sebald daniel.seb...@ieee.org changed: What|Removed |Added Attachment #114595|0 |1 is

[Mesa-dev] [Bug 89586] Drivers/DRI/swrast

2015-03-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89586 Dan Sebald daniel.seb...@ieee.org changed: What|Removed |Added Attachment #114592|0 |1 is

Re: [Mesa-dev] [PATCH] glsl: avoid calling base_alignment when samplers are involved

2015-03-24 Thread Ian Romanick
On 03/23/2015 05:00 AM, Ilia Mirkin wrote: Earlier commit 53bf7c8fd2e changed the logic to always call base_alignment on structs. 1ec715ce8b12 hacked the function to return 0 for sampler fields, but didn't handle sampler arrays. Instead of extending the hack, avoid calling base_alignment in

Re: [Mesa-dev] OpenGL ES 3.0 support

2015-03-24 Thread Shervin Sharifi
Thank you Ilia and Rob for your responses. On Mon, Mar 23, 2015 at 3:39 PM, Rob Clark robdcl...@gmail.com wrote: On Mon, Mar 23, 2015 at 3:59 PM, Ilia Mirkin imir...@alum.mit.edu wrote: On Mon, Mar 23, 2015 at 3:57 PM, Shervin Sharifi sherv...@gmail.com wrote: Hi, I'm new to Mesa and

[Mesa-dev] [PATCH] i965/fs: Use NIR by default for fragment shaders

2015-03-24 Thread Jason Ekstrand
shader-db results for fragment shaders on i965: total instructions in shared programs: 2908521 - 2921865 (0.46%) instructions in affected programs: 2203215 - 2216559 (0.61%) helped:2637 HURT: 5084 shader-db results

Re: [Mesa-dev] [PATCH] glsl: avoid calling base_alignment when samplers are involved

2015-03-24 Thread Ilia Mirkin
On Tue, Mar 24, 2015 at 1:55 PM, Ian Romanick i...@freedesktop.org wrote: On 03/23/2015 05:00 AM, Ilia Mirkin wrote: diff --git a/src/glsl/link_uniforms.cpp b/src/glsl/link_uniforms.cpp index 799c74b..59adc29 100644 --- a/src/glsl/link_uniforms.cpp +++ b/src/glsl/link_uniforms.cpp @@ -547,6

Re: [Mesa-dev] [PATCH 2/6] i965/skl: Layout a 1D miptree horizontally

2015-03-24 Thread Anuj Phogat
On Fri, Feb 20, 2015 at 2:31 PM, Neil Roberts n...@linux.intel.com wrote: On Gen9+ the 1D miptree is laid out with all of the mipmap levels in a horizontal line. --- src/mesa/drivers/dri/i965/brw_tex_layout.c | 62 +- 1 file changed, 60 insertions(+), 2

Re: [Mesa-dev] [PATCH] dri3_glx.c: Pass NULL DRI drawables into driver for None GLX drawables

2015-03-24 Thread Zhang, Xiong Y
Le 24/03/2015 06:50, Zhang, Xiong Y a écrit : You seem to miss the case when one is None and not the other. It should return BadDrawable too. This particular case seems not handled by the dri2 code either, and the gallium state tracker seems to handle it in bindContext, but not the

Re: [Mesa-dev] [PATCH] dri3_glx.c: Pass NULL DRI drawables into driver for None GLX drawables

2015-03-24 Thread Axel Davy
On 24/03/2015 08:33, Zhang, Xiong Y wrote : Yes. I imagine putting it into MakeContextCurrent is not a solution, since it means GLXBadContext will be returned instead of GLXBadDrawable. [Zhang, Xiong Y] Yes, I agree with you. But it is strange that both macro GLXBadContext and Success are

Re: [Mesa-dev] [PATCH] clover: Return CL_BUILD_ERROR for CL_PROGRAM_BUILD_STATUS when compilation fails

2015-03-24 Thread Jan Vesely
On Tue, 2015-03-24 at 22:36 +0200, Francisco Jerez wrote: Jan Vesely jan.ves...@rutgers.edu writes: On Tue, 2015-03-24 at 22:24 +0200, Francisco Jerez wrote: Tom Stellard thomas.stell...@amd.com writes: Cc: 10.5 10.4 mesa-sta...@lists.freedesktop.org ---

Re: [Mesa-dev] [PATCH 18.1/23] glsl: Add is_rvalue, is_dereference, and is_jump methods

2015-03-24 Thread Matt Turner
On Tue, Mar 24, 2015 at 11:25 AM, Ian Romanick i...@freedesktop.org wrote: From: Ian Romanick ian.d.roman...@intel.com These functions deteremine when an IR node is one of the non-leaf classes. Signed-off-by: Ian Romanick ian.d.roman...@intel.com Cc: Francisco Jerez curroje...@riseup.net

[Mesa-dev] [PATCH 2/8] scons: Don't build egl on Windows.

2015-03-24 Thread Jose Fonseca
Useless, as there are no drivers for it. --- src/SConscript | 2 +- src/egl/main/Makefile.am | 1 - src/egl/main/SConscript | 11 +-- 3 files changed, 2 insertions(+), 12 deletions(-) diff --git a/src/SConscript b/src/SConscript index 188ab08..40b7fc1 100644 ---

[Mesa-dev] [PATCH 6/8] mesa: Avoid MSVC C6334 warning in /analyze mode.

2015-03-24 Thread Jose Fonseca
MSVC's implementation of signbit(x) uses sizeof(x) with expressions to dispatch to an internal function based on the argument's type (float, double, etc), but that raises a flag with MSVC's own static analyzer, and because this is an inline function in a header it causes substantial warning spam.

[Mesa-dev] [PATCH 5/8] c99_math: Don't reimplement lrint and friends on MSVC 2013.

2015-03-24 Thread Jose Fonseca
MSVC 2013 declares these functions, both for C and C++ source files. This was caught with MSVC in analyze mode. --- include/c99_math.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/c99_math.h b/include/c99_math.h index 5b01d53..ee0dd10 100644 ---

[Mesa-dev] [PATCH 4/8] scons: Don't build osmesa.

2015-03-24 Thread Jose Fonseca
There doesn't seem much interest on osmesa on Windows, particularly classic osmesa. If there is indeed interest in osmesa on Windows, we should instead integrate src/gallium/targets/osmesa into SCons. --- src/mesa/drivers/SConscript| 2 -- src/mesa/drivers/osmesa/SConscript | 39

[Mesa-dev] [PATCH 7/8] scons: Disable MSVC warnings about inconsistent function annotation.

2015-03-24 Thread Jose Fonseca
Somehow, merely including any of the *intrin.h headers causes dozens of this warnings (when compiling pretty much every source file). MSVC does not always complain the same -- so it's possible we're doing something weird --, but silence these warnings in the meanwhile. --- scons/gallium.py | 1 +

[Mesa-dev] [PATCH 1/8] scons: Fix git_sha1.h generation fallback.

2015-03-24 Thread Jose Fonseca
I didn't meant to remove the 'if not os.path.exists(filename)' statement. --- src/mesa/SConscript | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/mesa/SConscript b/src/mesa/SConscript index a563fd2..5b80a21 100644 --- a/src/mesa/SConscript +++ b/src/mesa/SConscript

[Mesa-dev] [PATCH 3/8] scons: Don't build loader on Windows.

2015-03-24 Thread Jose Fonseca
EGL was the last user. --- src/SConscript | 3 ++- src/loader/Makefile.am | 1 - 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/SConscript b/src/SConscript index 40b7fc1..b0578e8 100644 --- a/src/SConscript +++ b/src/SConscript @@ -12,7 +12,8 @@ if env['hostonly']:

[Mesa-dev] [PATCH 8/8] util/u_atomic: Ignore warnings interlocked accesses.

2015-03-24 Thread Jose Fonseca
These are due how we implemented the atomic tests, not the atomic implementation itself. It's also difficult to refactor the code to avoid the warnings due to the use of macros -- the code would be quite hairy. --- src/util/u_atomic_test.c | 5 + 1 file changed, 5 insertions(+) diff --git

Re: [Mesa-dev] [PATCH 18.1/23] glsl: Add is_rvalue, is_dereference, and is_jump methods

2015-03-24 Thread Ian Romanick
On 03/24/2015 02:14 PM, Matt Turner wrote: On Tue, Mar 24, 2015 at 11:25 AM, Ian Romanick i...@freedesktop.org wrote: From: Ian Romanick ian.d.roman...@intel.com These functions deteremine when an IR node is one of the non-leaf classes. Signed-off-by: Ian Romanick ian.d.roman...@intel.com