Re: [Mesa-dev] [PATCH] i965: Fix SHADER_OPCODE_UNTYPED_SURFACE_WRITE to mark written surfaces

2015-05-05 Thread Francisco Jerez
Iago Toral Quiroga ito...@igalia.com writes: We can do this when the surface index is an immediate, as we do for reads. Otherwise the visitor should handle this. --- Francisco, maybe you choose not to do this for a reason? It seems a bit inconsistent with the reads though. Also, other

[Mesa-dev] [PATCH] i965: Fix SHADER_OPCODE_UNTYPED_SURFACE_WRITE to mark written surfaces

2015-05-05 Thread Iago Toral Quiroga
We can do this when the surface index is an immediate, as we do for reads. Otherwise the visitor should handle this. --- Francisco, maybe you choose not to do this for a reason? It seems a bit inconsistent with the reads though. Also, other read/write messages seem to mark surfaces in the

Re: [Mesa-dev] [PATCH 09/13] SQUASH: i965/fs: Rework fs_visitor::lower_load_payload

2015-05-05 Thread Matt Turner
On Tue, May 5, 2015 at 4:13 PM, Jason Ekstrand ja...@jlekstrand.net wrote: On Wed, Apr 15, 2015 at 6:44 PM, Matt Turner matts...@gmail.com wrote: On Wed, Apr 15, 2015 at 5:13 PM, Jason Ekstrand ja...@jlekstrand.net wrote: On Wed, Apr 15, 2015 at 1:31 PM, Matt Turner matts...@gmail.com wrote:

Re: [Mesa-dev] [PATCH 2/9] doc/egl: Remove depreciated EGL_SOFTWARE

2015-05-05 Thread Dave Airlie
On 2 May 2015 at 20:15, Axel Davy axel.d...@ens.fr wrote: EGL_SOFTWARE is not supported anywhere in the code, whereas LIBGL_ALWAYS_SOFTWARE is. Signed-off-by: Axel Davy axel.d...@ens.fr Reviewed-by: Dave Airlie airl...@redhat.com --- docs/egl.html | 8 1 file changed, 8

Re: [Mesa-dev] [PATCH 1/9] egl/wayland: properly destroy wayland objects

2015-05-05 Thread Dave Airlie
On 2 May 2015 at 20:15, Axel Davy axel.d...@ens.fr wrote: the wl_registry and the wl_queue allocated weren't destroyed. Signed-off-by: Axel Davy axel.d...@ens.fr Reviewed-by: Dave Airlie airl...@redhat.com --- src/egl/drivers/dri2/egl_dri2.c | 2 ++

[Mesa-dev] [RFC 4/6] i965: Implement INTEL_performance_query extension

2015-05-05 Thread Robert Bragg
This adds a bare-bones backend for the INTEL_performance_query extension that exposes the pipeline statistics on gen 6 and 7 hardware. Although this could be considered redundant given that the same statistics are now available via query objects, they are a simple starting point for this

[Mesa-dev] [RFC 5/6] i965: Expose OA counters via INTEL_performance_query

2015-05-05 Thread Robert Bragg
This adds support for exposing basic ('aggregate') Observation Architecture performance counters on Haswell. This support is based on the i915_oa perf kernel interface which is used to configure the OA unit, allowing Mesa to emit MI_REPORT_PERF_COUNT commands around queries to collect counter

[Mesa-dev] [RFC 2/6] Separate INTEL_performance_query frontend

2015-05-05 Thread Robert Bragg
To allow the backend interfaces for AMD_performance_monitor and INTEL_performance_query to evolve independently based on the more specific requirements of each extension this starts by separating the frontends of these extensions. Even though there wasn't much tying these frontends together, this

[Mesa-dev] [RFC 6/6] i965: Adds further support for 3D OA counters

2015-05-05 Thread Robert Bragg
This uses the i915_oa '3D' metric set to expose many more interesting OA counters including information about depth, alpha and stencil testing, sampler usage/bottlneck stats and cache throughputs. Signed-off-by: Robert Bragg rob...@sixbynine.org ---

[Mesa-dev] [Bug 90147] swrast: build error undeclared _SC_PHYS_PAGES on osx

2015-05-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90147 --- Comment #5 from Jeremy Huddleston jerem...@freedesktop.org --- Yeah, I think the sysctl() approach is probably more portable if you want to go that route. I was also thinking that this should be refactored into a more abstract layer since

Re: [Mesa-dev] [PATCH 3/9] glx/dri3: Add additional check for gpu offloading case

2015-05-05 Thread Dave Airlie
On 2 May 2015 at 20:15, Axel Davy axel.d...@ens.fr wrote: Checks blitImage is implemented. Initially having the __DRIimageExtension extension at version 9 at least meant blitImage was supported. However some implementations do advertise version = 9 without implementing it. Signed-off-by:

Re: [Mesa-dev] [PATCH 4/9] egl/wayland: Add support for render-nodes

2015-05-05 Thread Dave Airlie
On 2 May 2015 at 20:15, Axel Davy axel.d...@ens.fr wrote: It is possible the server advertises a render-node. In that case no authentication is needed, and Gem names are forbidden. Signed-off-by: Axel Davy axel.d...@ens.fr Reviewed-by: Dave Airlie airl...@redhat.com

[Mesa-dev] [PATCH v2 10/15] SQUASH: i965/fs: Rework fs_visitor::lower_load_payload

2015-05-05 Thread Jason Ekstrand
Instead of the complicated and broken-by-design pile of heuristics we had before, we now have a straightforward lowering: 1) All header sources are copied directly using force_writemask_all and, since they are guaranteed to be a single register, there are no force_sechalf issues. 2)

[Mesa-dev] [PATCH v2 03/15] i965/fs_cse: Factor out code to create copy instructions

2015-05-05 Thread Jason Ekstrand
v2: Get rid of the block parameter and make src a const reference Reviewed-by: Topi Pohjolainen topi.pohjolai...@intel.com Reviewed-by: Matt Turner matts...@gmail.com Reviewed-by: Kenneth Graunke kenn...@whitecape.org --- src/mesa/drivers/dri/i965/brw_fs_cse.cpp | 75

[Mesa-dev] [PATCH v2 01/15] i965/fs: Fix passing an immediate to half().

2015-05-05 Thread Jason Ekstrand
From: Francisco Jerez curroje...@riseup.net Immediates are generally uniform, they yield the same value to both halves of any instruction. Reviewed-by: Matt Turner matts...@gmail.com --- src/mesa/drivers/dri/i965/brw_ir_fs.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [PATCH v2 12/15] SQUASH: i965/fs_inst::is_copy_payload: Support the new-style LOAD_PAYLOAD

2015-05-05 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/brw_fs.cpp | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp index e7095c9..d0a3bdd 100644 --- a/src/mesa/drivers/dri/i965/brw_fs.cpp +++

[Mesa-dev] [PATCH v2 02/15] i965/fs: Make half(fs_reg, unsigned) handle register files more explicitly

2015-05-05 Thread Jason Ekstrand
Previously, we had a special case for uniforms and immediates and then a bunch of asserts for various other pessimal things. This commit changes it so that it explicitly does something on each register file. Some of them are disallowed and others are treated properly. ---

[Mesa-dev] [PATCH v2 00/15] Make LOAD_PAYLOAD sane again

2015-05-05 Thread Jason Ekstrand
This is a v2 of the series that I sent out a month or two ago to fix up the LOAD_PAYLOAD instruction in the i965 FS backend compiler. This new version incorporates comments from a variety of people. The last patch in the series is one that I think at least 3 of us have independantly written to

[Mesa-dev] [PATCH v2 04/15] i965: Change header_present to header_size in backend_instruction

2015-05-05 Thread Jason Ekstrand
Reviewed-by: Kenneth Graunke kenn...@whitecape.org --- src/mesa/drivers/dri/i965/brw_blorp_blit_eu.cpp | 4 +-- src/mesa/drivers/dri/i965/brw_fs.cpp | 18 ++--- src/mesa/drivers/dri/i965/brw_fs_cse.cpp | 2 +- src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 20

[Mesa-dev] [PATCH v2 14/15] i965/fs_inst: Get rid of the effective_width field

2015-05-05 Thread Jason Ekstrand
The effective_width field was an ill-concieved hack to get around issues in the LOAD_PAYLOAD instruction. Now that the LOAD_PAYLOAD instruction is far more sane, this field can die. Reviewed-by: Kenneth Graunke kenn...@whitecape.org --- src/mesa/drivers/dri/i965/brw_fs.cpp | 25

[Mesa-dev] [PATCH v2 13/15] SQUASH: i965/fs: Simplify setup_color_payload

2015-05-05 Thread Jason Ekstrand
Previously, setup_color_payload was a a big helper function that did a lot of gen-specific special casing for setting up the color sources of the LOAD_PAYLOAD instruction. Now that lower_load_payload is much more sane, most of that complexity isn't needed anymore. Instead, we can do a simple

[Mesa-dev] [PATCH v2 09/15] SQUASH: i965/fs: Make destinations of load_payload have the appropreate width

2015-05-05 Thread Jason Ekstrand
Reviewed-by: Kenneth Graunke kenn...@whitecape.org --- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp b/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp index

[Mesa-dev] [PATCH v2 06/15] i965/fs: Make emit_single_fb_write take an explicit exec_size

2015-05-05 Thread Jason Ekstrand
Reviewed-by: Kenneth Graunke kenn...@whitecape.org --- src/mesa/drivers/dri/i965/brw_fs.h | 2 +- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 16 +--- 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.h

[Mesa-dev] [PATCH v2 05/15] i965/fs_inst: Add an is_copy_payload helper

2015-05-05 Thread Jason Ekstrand
This commit adds a new is_copy_payload helper to fs_inst that takes the place of the similarly named functions in cse and register coalesce. The two is_copy_payload functions in CSE and register coalesce were subtly different and potentially subtly broken. The new version unifies the two and

Re: [Mesa-dev] [PATCH 09/13] SQUASH: i965/fs: Rework fs_visitor::lower_load_payload

2015-05-05 Thread Jason Ekstrand
On Tue, May 5, 2015 at 4:20 PM, Matt Turner matts...@gmail.com wrote: On Tue, May 5, 2015 at 4:13 PM, Jason Ekstrand ja...@jlekstrand.net wrote: On Wed, Apr 15, 2015 at 6:44 PM, Matt Turner matts...@gmail.com wrote: On Wed, Apr 15, 2015 at 5:13 PM, Jason Ekstrand ja...@jlekstrand.net wrote:

[Mesa-dev] [PATCH v2 11/15] SQUASH: i965/fs_cse: Support the new-style LOAD_PAYLOAD

2015-05-05 Thread Jason Ekstrand
Reviewed-by: Kenneth Graunke kenn...@whitecape.org --- src/mesa/drivers/dri/i965/brw_fs_cse.cpp | 31 --- 1 file changed, 24 insertions(+), 7 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_cse.cpp b/src/mesa/drivers/dri/i965/brw_fs_cse.cpp index

[Mesa-dev] [PATCH v2 07/15] i965/fs: Make LOAD_PAYLOAD take a header size

2015-05-05 Thread Jason Ekstrand
Reviewed-by: Kenneth Graunke kenn...@whitecape.org --- src/mesa/drivers/dri/i965/brw_fs.cpp | 6 +- src/mesa/drivers/dri/i965/brw_fs.h | 3 ++- src/mesa/drivers/dri/i965/brw_fs_cse.cpp | 3 ++- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 20 +++- 4

[Mesa-dev] [PATCH v2 15/15] i965/fs: Allow copy propagation on ATTR file registers.

2015-05-05 Thread Jason Ekstrand
From: Kenneth Graunke kenn...@whitecape.org This especially helps with NIR because we currently emit MOVs at the top of the shader to copy from various ATTR registers to a giant VGRF array of all inputs. (This could potentially be done better, but since there's only ever one write to each

[Mesa-dev] [PATCH v2 08/15] i965/fs: Rework fs_visitor::LOAD_PAYLOAD

2015-05-05 Thread Jason Ekstrand
We rework LOAD_PAYLOAD to verify that all of the sources that count as headers are, indeed, exactly one register and that all of the non-header sources match the destination width. We then take the exec_size for LOAD_PAYLOAD directly from the destination width. Reviewed-by: Kenneth Graunke

[Mesa-dev] [resend] one of the vertex_attrib_64bit patches

2015-05-05 Thread Dave Airlie
Mainly for Ian, this is the fix to the outstanding patch, with an R-b on this I think they due a push. Dave. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] glsl: add ARB_vertex_attrib_64bit support. (v2)

2015-05-05 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com Just more boilerplate stuff. v2: bad fallthrough on versioning, this is my ugly but self contained solution (Ian) Reviewed-by: Ilia Mirkin imir...@alum.mit.edu Signed-off-by: Dave Airlie airl...@redhat.com --- src/glsl/ast_to_hir.cpp | 3 +++

Re: [Mesa-dev] [PATCH v2 00/15] Make LOAD_PAYLOAD sane again

2015-05-05 Thread Kenneth Graunke
On Tuesday, May 05, 2015 06:28:03 PM Jason Ekstrand wrote: This is a v2 of the series that I sent out a month or two ago to fix up the LOAD_PAYLOAD instruction in the i965 FS backend compiler. This new version incorporates comments from a variety of people. The last patch in the series is

Re: [Mesa-dev] [PATCH 7/9] egl/wayland: assume EGL_WINDOW_BIT

2015-05-05 Thread Dave Airlie
On 2 May 2015 at 20:15, Axel Davy axel.d...@ens.fr wrote: Only EGL_WINDOW_BIT is supported. Remove tests related. Is this there no plans to support pixmap/pbuffer/ or any of the other bits? Seems like a step in the wrong direction if we really should be supporting other things than WINDOW_BIT

Re: [Mesa-dev] [PATCH 5/9] egl/wayland: Implement DRI_PRIME support

2015-05-05 Thread Dave Airlie
On 2 May 2015 at 20:15, Axel Davy axel.d...@ens.fr wrote: When the server gpu and requested gpu are different: . They likely don't support the same tiling modes . They likely do not have fast access to the same locations Thus we do: . render to a tiled buffer we do not share with the server

Re: [Mesa-dev] [PATCH 7/7] i965/sync: Implement DRI2_Fence extension

2015-05-05 Thread Chad Versace
On Mon 04 May 2015, Daniel Stone wrote: Hi, On 1 May 2015 at 21:02, Chad Versace chad.vers...@intel.com wrote: +static bool +brw_fence_has_completed(struct brw_fence *fence) +{ + if (fence-signalled) + return true; + + if (fence-batch_bo

[Mesa-dev] [RFC 3/6] Model INTEL perf query backend after query object BE

2015-05-05 Thread Robert Bragg
Instead of using the same backend interface as AMD_performance_monitor this defines a dedicated INTEL_performance_query interface that is based on the ARB_query_buffer_object interface (considering the similarity of the extensions) with the addition of vfuncs for enumerating queries and their

[Mesa-dev] [RFC 1/6] i965: Remove perf monitor/query backend

2015-05-05 Thread Robert Bragg
In its current state the unified i965 backend for AMD_performance_monitor and INTEL_performance_query isn't able to report meaningful Observation Architecture metrics since we haven't so far had the necessary kernel support to fully configure the OA unit, nor the corresponding support for

[Mesa-dev] [RFC 0/6] i965: INTEL_performance_query re-work

2015-05-05 Thread Robert Bragg
As we've learned more about the observability capabilities of Gen graphics we've found that it's not enough to only try and configure the OA unit from userspace without any dedicated support from the kernel. As it is currently the i965 backends for both AMD_performance_monitor and

Re: [Mesa-dev] [PATCH 01/13] nir/validate: Validate SSA def parent instructiosn

2015-05-05 Thread Connor Abbott
Typo in the subject line. On Tue, Apr 28, 2015 at 12:03 AM, Jason Ekstrand ja...@jlekstrand.net wrote: --- src/glsl/nir/nir_validate.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/glsl/nir/nir_validate.c b/src/glsl/nir/nir_validate.c index a7aa798..35a853d 100644 ---

Re: [Mesa-dev] [PATCH 01/13] nir/validate: Validate SSA def parent instructiosn

2015-05-05 Thread Jason Ekstrand
On Tue, May 5, 2015 at 5:16 PM, Connor Abbott cwabbo...@gmail.com wrote: Typo in the subject line. Fixed Locally --Jason ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 09/13] SQUASH: i965/fs: Rework fs_visitor::lower_load_payload

2015-05-05 Thread Jason Ekstrand
On Wed, Apr 15, 2015 at 6:44 PM, Matt Turner matts...@gmail.com wrote: On Wed, Apr 15, 2015 at 5:13 PM, Jason Ekstrand ja...@jlekstrand.net wrote: On Wed, Apr 15, 2015 at 1:31 PM, Matt Turner matts...@gmail.com wrote: On Wed, Apr 1, 2015 at 6:19 PM, Jason Ekstrand ja...@jlekstrand.net wrote:

Re: [Mesa-dev] [PATCH 8/9] egl/wayland: Implement swrast support

2015-05-05 Thread Dave Airlie
On 2 May 2015 at 20:15, Axel Davy axel.d...@ens.fr wrote: Signed-off-by: Axel Davy axel.d...@ens.fr I think I'd like to see the os-compatibility ported code be in a separate file, I wonder if any of it would be useful in other places, But even that isn't a major problem, Reviewed-by: Dave

Re: [Mesa-dev] [PATCH 9/9] egl/swrast: enable config extension for swrast

2015-05-05 Thread Dave Airlie
On 2 May 2015 at 20:15, Axel Davy axel.d...@ens.fr wrote: Enables to use dri config for swrast, like vblank_mode. Signed-off-by: Axel Davy axel.d...@ens.fr Reviewed-by: Dave Airlie airl...@redhat.com --- src/egl/drivers/dri2/egl_dri2.c| 21 ++---

[Mesa-dev] [PATCH] i965: Delete most of the linked GLSL IR when using NIR.

2015-05-05 Thread Kenneth Graunke
Vertex shader attribute and fragment shader output queries rely on being able to inspect top-level ir_variable objects. So, we have to keep those. However, functions and global temporary variables can be deleted with impunity. Saves 58MB of memory when replaying a Dota 2 trace on Broadwell.

Re: [Mesa-dev] [PATCH] i965: Delete most of the linked GLSL IR when using NIR.

2015-05-05 Thread Jason Ekstrand
On May 5, 2015 10:17 PM, Tapani Pälli tapani.pa...@intel.com wrote: On 05/06/2015 04:57 AM, Kenneth Graunke wrote: Vertex shader attribute and fragment shader output queries rely on being able to inspect top-level ir_variable objects. So, we have to keep those. However, functions and

Re: [Mesa-dev] [PATCH] i965: Fix SHADER_OPCODE_UNTYPED_SURFACE_WRITE to mark written surfaces

2015-05-05 Thread Iago Toral
On Tue, 2015-05-05 at 16:41 +0300, Francisco Jerez wrote: Iago Toral Quiroga ito...@igalia.com writes: We can do this when the surface index is an immediate, as we do for reads. Otherwise the visitor should handle this. --- Francisco, maybe you choose not to do this for a reason? It

Re: [Mesa-dev] [PATCH] i965: Delete most of the linked GLSL IR when using NIR.

2015-05-05 Thread Tapani Pälli
On 05/06/2015 04:57 AM, Kenneth Graunke wrote: Vertex shader attribute and fragment shader output queries rely on being able to inspect top-level ir_variable objects. So, we have to keep those. However, functions and global temporary variables can be deleted with impunity. Saves 58MB of

Re: [Mesa-dev] [PATCH] clover: add --with-icd-file-dir option

2015-05-05 Thread Emil Velikov
On 4 May 2015 at 18:11, Ilia Mirkin imir...@alum.mit.edu wrote: On Mon, May 4, 2015 at 12:47 PM, Tom Stellard t...@stellard.net wrote: On Mon, May 04, 2015 at 10:13:19AM -0400, Ilia Mirkin wrote: On Mon, May 4, 2015 at 10:04 AM, Tom Stellard t...@stellard.net wrote: On Sat, May 02, 2015 at

Re: [Mesa-dev] [PATCH] glx: Massive update of comments in struct extension_info

2015-05-05 Thread Emil Velikov
Hi Ian, On 15 April 2015 at 19:36, Ian Romanick i...@freedesktop.org wrote: From: Ian Romanick ian.d.roman...@intel.com In response to another patch, Emil asked for some clarification how this stuff works. Rather than just reply to the e-mail, I decided to update the exlanation in the code.

Re: [Mesa-dev] [PATCH] clover: add --with-icd-file-dir option

2015-05-05 Thread Tom Stellard
On Tue, May 05, 2015 at 03:48:29PM +0100, Emil Velikov wrote: On 4 May 2015 at 18:11, Ilia Mirkin imir...@alum.mit.edu wrote: On Mon, May 4, 2015 at 12:47 PM, Tom Stellard t...@stellard.net wrote: On Mon, May 04, 2015 at 10:13:19AM -0400, Ilia Mirkin wrote: On Mon, May 4, 2015 at 10:04 AM,

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965: Add XRGB8888 format to intel_screen_make_configs

2015-05-05 Thread Emil Velikov
Hi all, On 16 April 2015 at 21:06, Daniel Stone dan...@fooishbar.org wrote: Hi, On 9 April 2015 at 17:20, Kristian Høgsberg k...@bitplanet.net wrote: On Wed, Apr 8, 2015 at 11:37 AM, Emil Velikov emil.l.veli...@gmail.com wrote: Hi all, Can we get a pair of eyes on this patch please ?

Re: [Mesa-dev] [PATCH 20/20] mesa: Allow MESA_GL_VERSION_OVERRIDE with ES contexts

2015-05-05 Thread Emil Velikov
Hi Ian, On 30 April 2015 at 00:26, Ian Romanick i...@freedesktop.org wrote: From: Ian Romanick ian.d.roman...@intel.com The bulk of the change is to prevent overriding the context to API_OPENGL_CORE based on the requested version. If the context is API_OPENGL_ES2, don't change it. Wouldn't

Re: [Mesa-dev] [PATCH 2/3] st/mesa: fix st_NewPerfMonitor() declaration

2015-05-05 Thread Samuel Pitoiset
On 05/06/2015 12:03 AM, Brian Paul wrote: On 05/05/2015 04:00 PM, Ian Romanick wrote: On 05/05/2015 02:50 PM, Brian Paul wrote: Was missing the context parameter. Fixes MSVC warning. Does this then result in a GCC warning about unused parameters? Not that I've seen (only tried a debug

[Mesa-dev] [Bug 90147] swrast: build error undeclared _SC_PHYS_PAGES on osx

2015-05-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90147 Julien Isorce julien.iso...@gmail.com changed: What|Removed |Added CC|

Re: [Mesa-dev] [PATCH 10/13] util/list: Add a list validation function

2015-05-05 Thread Neil Roberts
Jason Ekstrand ja...@jlekstrand.net writes: +static inline void list_validate(struct list_head *list) +{ + assert(list-next-prev == list list-prev-next == list); + for (struct list_head *node = list-next; node != list; node = node-next) + assert(node-next-prev == node

Re: [Mesa-dev] [PATCH 09/13] util/list: Add list_empty and list_length functions

2015-05-05 Thread Jason Ekstrand
On Tue, May 5, 2015 at 11:21 AM, Neil Roberts n...@linux.intel.com wrote: Jason Ekstrand ja...@jlekstrand.net writes: +static inline bool list_empty(struct list_head *list) +{ + return list-next == list; +} It would be good if list.h also included stdbool.h in order to get the

[Mesa-dev] [Bug 90325] No static entry point for glQueryCounter and other entry points in ARB_timer_query

2015-05-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90325 Ian Romanick i...@freedesktop.org changed: What|Removed |Added Status|NEW |RESOLVED

Re: [Mesa-dev] [PATCH 3/3] st/mesa: fix pipe_query_result result initializer

2015-05-05 Thread Ilia Mirkin
Series is Reviewed-by: Ilia Mirkin imir...@alum.mit.edu On Tue, May 5, 2015 at 5:50 PM, Brian Paul bri...@vmware.com wrote: Fixes MSVC build error. --- src/mesa/state_tracker/st_cb_perfmon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH 2/3] st/mesa: fix st_NewPerfMonitor() declaration

2015-05-05 Thread Ian Romanick
On 05/05/2015 02:50 PM, Brian Paul wrote: Was missing the context parameter. Fixes MSVC warning. Does this then result in a GCC warning about unused parameters? --- src/mesa/state_tracker/st_cb_perfmon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH 1/3] glsl: add parens in shader_integer_mix() to silence compiler warning

2015-05-05 Thread Ian Romanick
Weird that I didn't notice this when I wrote the code. :( Sorry about that. This patch is Reviewed-by: Ian Romanick ian.d.roman...@intel.com On 05/05/2015 02:50 PM, Brian Paul wrote: Silences gcc warning: builtin_functions.cpp:204:23: warning: suggest parentheses around '' within '||'

Re: [Mesa-dev] [PATCH 2/3] st/mesa: fix st_NewPerfMonitor() declaration

2015-05-05 Thread Brian Paul
On 05/05/2015 04:00 PM, Ian Romanick wrote: On 05/05/2015 02:50 PM, Brian Paul wrote: Was missing the context parameter. Fixes MSVC warning. Does this then result in a GCC warning about unused parameters? Not that I've seen (only tried a debug build). -Brian

[Mesa-dev] [Bug 90325] No static entry point for glQueryCounter and other entry points in ARB_timer_query

2015-05-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90325 --- Comment #8 from Ian Romanick i...@freedesktop.org --- BTW... you should checkout libGLEW or libepoxy. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.

Re: [Mesa-dev] i965 implementation of the ARB_shader_image_load_store built-ins. (v2)

2015-05-05 Thread Matt Turner
On Tue, May 5, 2015 at 2:17 PM, Francisco Jerez curroje...@riseup.net wrote: Kenneth Graunke kenn...@whitecape.org writes: That then begs the question - could we do the format conversion and address calculations in a i965-specific NIR pass? It could simplify the backend changes. NIR also has

[Mesa-dev] [Bug 90325] No static entry point for glQueryCounter and other entry points in ARB_timer_query

2015-05-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90325 nmcve...@gmail.com changed: What|Removed |Added Resolution|NOTABUG |FIXED --- Comment #9 from

[Mesa-dev] [Bug 90147] swrast: build error undeclared _SC_PHYS_PAGES on osx

2015-05-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90147 --- Comment #3 from Brian Paul bri...@vmware.com --- So which patch do you want to use? Either looks OK to me. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.

Re: [Mesa-dev] i965 implementation of the ARB_shader_image_load_store built-ins. (v2)

2015-05-05 Thread Kenneth Graunke
On Tuesday, May 05, 2015 03:05:02 PM Matt Turner wrote: On Tue, May 5, 2015 at 2:17 PM, Francisco Jerez curroje...@riseup.net wrote: Kenneth Graunke kenn...@whitecape.org writes: That then begs the question - could we do the format conversion and address calculations in a i965-specific NIR

Re: [Mesa-dev] [PATCH 04/13] i965/fs_inst: Add an is_copy_payload helper

2015-05-05 Thread Kenneth Graunke
On Tuesday, May 05, 2015 02:31:39 PM Jason Ekstrand wrote: On Tue, May 5, 2015 at 1:34 PM, Matt Turner matts...@gmail.com wrote: On Tue, May 5, 2015 at 1:13 PM, Jason Ekstrand ja...@jlekstrand.net wrote: On Tue, Apr 14, 2015 at 1:28 AM, Kenneth Graunke kenn...@whitecape.org wrote: 2. CSE

Re: [Mesa-dev] [PATCH 4/4] i965: Introduce a context-local batch manager

2015-05-05 Thread Emil Velikov
On 1 May 2015 at 15:53, Chris Wilson ch...@chris-wilson.co.uk wrote: * where is the doubly-linked circular list? IIRC there was some patches from Jason, that move the the gallium one to src/util/list.h [1]. Not sure on the status of it though. On a related note - would be great if one day we

Re: [Mesa-dev] [PATCH 0/3] Simple Klocwork patches.

2015-05-05 Thread Anuj Phogat
On Tue, May 5, 2015 at 3:50 AM, Juha-Pekka Heikkila juhapekka.heikk...@gmail.com wrote: Just simple Klocwork found issues. /Juha-Pekka Juha-Pekka Heikkila (3): mesa/main: Remove _mesa_HashClone() mesa/main: avoid null access in format_array_table_init() mesa/main: check for null in

Re: [Mesa-dev] [PATCH 3/3] mesa/main: check for null in invalid_array_element_syntax()

2015-05-05 Thread Kenneth Graunke
On Tuesday, May 05, 2015 01:50:59 PM Juha-Pekka Heikkila wrote: name string is coming through API call, need to be careful with it. Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/mesa/main/program_resource.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [Mesa-dev] [PATCH 00/13] Fix context creation error handling

2015-05-05 Thread Anuj Phogat
On Tue, May 5, 2015 at 4:25 AM, Juha-Pekka Heikkila juhapekka.heikk...@gmail.com wrote: This is a resend, the earlier set seem to have gone into void. This set was collected with intentionally failing at context creation and then fixing all the places where segfault resulted. Some of the

Re: [Mesa-dev] [PATCH] clover: add --with-icd-file-dir option

2015-05-05 Thread Ilia Mirkin
On Tue, May 5, 2015 at 11:42 AM, Tom Stellard t...@stellard.net wrote: How about this -- get rid of --enable-opencl-icd and change it to --with-opencl-icd-dir where you must supply a directory if you want to use it. That way if you want the system one, you'd say /etc/OpenCL/vendors, if you

Re: [Mesa-dev] [PATCH] clover: add --with-icd-file-dir option

2015-05-05 Thread Emil Velikov
On 5 May 2015 at 16:42, Tom Stellard t...@stellard.net wrote: On Tue, May 05, 2015 at 03:48:29PM +0100, Emil Velikov wrote: On 4 May 2015 at 18:11, Ilia Mirkin imir...@alum.mit.edu wrote: On Mon, May 4, 2015 at 12:47 PM, Tom Stellard t...@stellard.net wrote: On Mon, May 04, 2015 at

Re: [Mesa-dev] [PATCH 03/29] i965: Define consistent interface to disable control flow execution masking.

2015-05-05 Thread Francisco Jerez
Kenneth Graunke kenn...@whitecape.org writes: On Saturday, May 02, 2015 06:29:30 PM Francisco Jerez wrote: --- src/mesa/drivers/dri/i965/brw_ir_fs.h | 10 ++ src/mesa/drivers/dri/i965/brw_ir_vec4.h | 9 + 2 files changed, 19 insertions(+) diff --git

Re: [Mesa-dev] [PATCH 09/13] util/list: Add list_empty and list_length functions

2015-05-05 Thread Neil Roberts
Jason Ekstrand ja...@jlekstrand.net writes: +static inline bool list_empty(struct list_head *list) +{ + return list-next == list; +} It would be good if list.h also included stdbool.h in order to get the declaration of bool. However, will that cause problems on MSVC? Is the Gallium code

Re: [Mesa-dev] [PATCH 08/13] util/list: Add C99-based iterator macros

2015-05-05 Thread Jason Ekstrand
On Tue, May 5, 2015 at 11:13 AM, Neil Roberts n...@linux.intel.com wrote: Jason Ekstrand ja...@jlekstrand.net writes: +#define list_for_each_entry(type, pos, head, member)\ + for (type *pos = container_of((head)-next, pos, member);\ + pos-member !=

Re: [Mesa-dev] [PATCH 00/13] i965: Make LOAD_PAYLOAD sane again

2015-05-05 Thread Kenneth Graunke
On Wednesday, April 01, 2015 06:19:11 PM Jason Ekstrand wrote: This patch series comes with two apologies. First, is for the fact that most of it has to be squashed into a single super-commit. Unfortunately, this is one of those things that can't really be done incrementally. Second, is for

Re: [Mesa-dev] [PATCH 03/13] i965/register_coalesce: Do register size checks before is_copy_payload

2015-05-05 Thread Matt Turner
On Wed, Apr 1, 2015 at 6:19 PM, Jason Ekstrand ja...@jlekstrand.net wrote: This allows us to get rid of the visitor argument in is_copy_payload --- src/mesa/drivers/dri/i965/brw_fs_register_coalesce.cpp | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 03/13] i965/register_coalesce: Do register size checks before is_copy_payload

2015-05-05 Thread Jason Ekstrand
On Tue, May 5, 2015 at 12:22 PM, Matt Turner matts...@gmail.com wrote: On Wed, Apr 1, 2015 at 6:19 PM, Jason Ekstrand ja...@jlekstrand.net wrote: This allows us to get rid of the visitor argument in is_copy_payload --- src/mesa/drivers/dri/i965/brw_fs_register_coalesce.cpp | 10 +- 1

Re: [Mesa-dev] [PATCH 28/29] i965: Define implementation constants for ARB_shader_image_load_store.

2015-05-05 Thread Kenneth Graunke
On Saturday, May 02, 2015 06:29:55 PM Francisco Jerez wrote: Reviewed-by: Paul Berry stereotype...@gmail.com v2: Drop VS support pre-Gen8, drop GS support. --- src/mesa/drivers/dri/i965/brw_context.c | 12 1 file changed, 12 insertions(+) diff --git

[Mesa-dev] [Bug 90249] Fails to build egl_dri2 on osx

2015-05-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90249 Julien Isorce julien.iso...@gmail.com changed: What|Removed |Added CC|

[Mesa-dev] [Bug 90213] glDrawPixels with GL_COLOR_INDEX never returns.

2015-05-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90213 Juha-Pekka Heikkilä juhapekka.heikk...@gmail.com changed: What|Removed |Added Status|NEW

[Mesa-dev] [Bug 90311] Fail to build libglx with clang at linking stage

2015-05-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90311 Bug ID: 90311 Summary: Fail to build libglx with clang at linking stage Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal

Re: [Mesa-dev] [PATCH 6/9] glsl: mark named uniform block arrays as active if defined with shared or std140 layout qualifier

2015-05-05 Thread Samuel Iglesias Gonsálvez
On 05/05/15 01:03, Matt Turner wrote: On Tue, Feb 24, 2015 at 10:02 AM, Eduardo Lima Mitev el...@igalia.com wrote: From: Samuel Iglesias Gonsalvez sigles...@igalia.com If the named uniform block is an array declared with a shared or std140 layout qualifier and no shader instruction has

Re: [Mesa-dev] [PATCH 5/9] mesa: fix deletion of inactive bound transform feedback object

2015-05-05 Thread Samuel Iglesias Gonsálvez
On 05/05/15 00:54, Matt Turner wrote: On Tue, Feb 24, 2015 at 10:02 AM, Eduardo Lima Mitev el...@igalia.com wrote: From: Samuel Iglesias Gonsalvez sigles...@igalia.com When a transform feedback object is bound and not active, the OpenGL ES 3.0 and GL_ARB_transform_feedback2 specs don't

[Mesa-dev] [Bug 90310] Fails to build gallium_dri.so at linking stage with clang because of multiple redefinitions

2015-05-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90310 Bug ID: 90310 Summary: Fails to build gallium_dri.so at linking stage with clang because of multiple redefinitions Product: Mesa Version: git Hardware: Other

Re: [Mesa-dev] [PATCH 1/9] glsl: don't lower fragdata array if the output data types don't match

2015-05-05 Thread Samuel Iglesias Gonsálvez
On 05/05/15 00:08, Matt Turner wrote: On Tue, Feb 24, 2015 at 10:02 AM, Eduardo Lima Mitev el...@igalia.com wrote: From: Samuel Iglesias Gonsalvez sigles...@igalia.com Commit 7e414b58640aee6e243d337e72cea290c354f632 broke the gl_FragData array into separate gl_FragData[i] variables, so

Re: [Mesa-dev] [PATCH 04/13] i965/fs_inst: Add an is_copy_payload helper

2015-05-05 Thread Matt Turner
On Tue, May 5, 2015 at 1:13 PM, Jason Ekstrand ja...@jlekstrand.net wrote: On Tue, Apr 14, 2015 at 1:28 AM, Kenneth Graunke kenn...@whitecape.org wrote: 2. CSE didn't use equals(), so it allowed things like types to differ, or source modifiers...(which are probably bogus on LOAD_PAYLOADs

[Mesa-dev] [Bug 90325] No static entry point for glQueryCounter and other entry points in ARB_timer_query

2015-05-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90325 --- Comment #2 from nmcve...@gmail.com --- Created attachment 115556 -- https://bugs.freedesktop.org/attachment.cgi?id=115556action=edit glxinfo output -- You are receiving this mail because: You are the QA Contact for the bug. You are the

[Mesa-dev] [Bug 90325] No static entry point for glQueryCounter and other entry points in ARB_timer_query

2015-05-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90325 --- Comment #3 from nmcve...@gmail.com --- Created attachment 115558 -- https://bugs.freedesktop.org/attachment.cgi?id=115558action=edit Possible fix for the problem -- You are receiving this mail because: You are the QA Contact for the bug.

[Mesa-dev] [Bug 90325] No static entry point for glQueryCounter and other entry points in ARB_timer_query

2015-05-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90325 --- Comment #4 from nmcve...@gmail.com --- Looking at gl_API.xml, it appears to me that static_dispatch=false should have been removed when the 3.3 support was added. If I remove static_dispatch from the functions in the ARB_timer_query category,

[Mesa-dev] [Bug 90325] No static entry point for glQueryCounter and other entry points in ARB_timer_query

2015-05-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90325 Bug ID: 90325 Summary: No static entry point for glQueryCounter and other entry points in ARB_timer_query Product: Mesa Version: git Hardware: x86-64 (AMD64)

[Mesa-dev] [Bug 90325] No static entry point for glQueryCounter and other entry points in ARB_timer_query

2015-05-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90325 nmcve...@gmail.com changed: What|Removed |Added CC||nmcve...@gmail.com -- You are

Re: [Mesa-dev] [PATCH 04/13] i965/fs_inst: Add an is_copy_payload helper

2015-05-05 Thread Jason Ekstrand
On Tue, Apr 14, 2015 at 1:28 AM, Kenneth Graunke kenn...@whitecape.org wrote: On Wednesday, April 01, 2015 06:19:15 PM Jason Ekstrand wrote: This allows us to combine code in CSE and register coalesce --- src/mesa/drivers/dri/i965/brw_fs.cpp | 14 ++

[Mesa-dev] [PATCH 3/5] nir: Fix indexing of atomic counter arrays with a constant value.

2015-05-05 Thread Francisco Jerez
--- src/glsl/nir/nir_lower_atomics.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/glsl/nir/nir_lower_atomics.c b/src/glsl/nir/nir_lower_atomics.c index e82df01..f6f8902 100644 --- a/src/glsl/nir/nir_lower_atomics.c +++ b/src/glsl/nir/nir_lower_atomics.c @@ -78,7 +78,8

[Mesa-dev] [PATCH 1/5] nir: Define image load, store and atomic intrinsics.

2015-05-05 Thread Francisco Jerez
--- src/glsl/nir/nir_intrinsics.h | 27 +++ 1 file changed, 27 insertions(+) diff --git a/src/glsl/nir/nir_intrinsics.h b/src/glsl/nir/nir_intrinsics.h index 8e28765..4b13c75 100644 --- a/src/glsl/nir/nir_intrinsics.h +++ b/src/glsl/nir/nir_intrinsics.h @@ -89,6 +89,33 @@

[Mesa-dev] [PATCH 4/5] nir: Translate image load, store and atomic intrinsics from GLSL IR.

2015-05-05 Thread Francisco Jerez
--- src/glsl/nir/glsl_to_nir.cpp | 125 +++ 1 file changed, 114 insertions(+), 11 deletions(-) diff --git a/src/glsl/nir/glsl_to_nir.cpp b/src/glsl/nir/glsl_to_nir.cpp index f6b8331..a01ab3b 100644 --- a/src/glsl/nir/glsl_to_nir.cpp +++

[Mesa-dev] [PATCH 2/5] nir: Add memory barrier intrinsic.

2015-05-05 Thread Francisco Jerez
--- src/glsl/nir/nir_intrinsics.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/glsl/nir/nir_intrinsics.h b/src/glsl/nir/nir_intrinsics.h index 4b13c75..3e053b3 100644 --- a/src/glsl/nir/nir_intrinsics.h +++ b/src/glsl/nir/nir_intrinsics.h @@ -68,6 +68,13 @@

[Mesa-dev] [PATCH 5/5] nir: Translate memory barrier intrinsics from GLSL IR.

2015-05-05 Thread Francisco Jerez
--- src/glsl/nir/glsl_to_nir.cpp | 4 1 file changed, 4 insertions(+) diff --git a/src/glsl/nir/glsl_to_nir.cpp b/src/glsl/nir/glsl_to_nir.cpp index a01ab3b..b4ab4ee 100644 --- a/src/glsl/nir/glsl_to_nir.cpp +++ b/src/glsl/nir/glsl_to_nir.cpp @@ -634,6 +634,8 @@ nir_visitor::visit(ir_call

[Mesa-dev] [Bug 90325] No static entry point for glQueryCounter and other entry points in ARB_timer_query

2015-05-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90325 --- Comment #1 from nmcve...@gmail.com --- Created attachment 11 -- https://bugs.freedesktop.org/attachment.cgi?id=11action=edit Simple program that demonstrates problem -- You are receiving this mail because: You are the QA Contact

  1   2   >