[Mesa-dev] Seeking advice speeding up glsl optimisation passes for AoA

2015-07-14 Thread Timothy Arceri
Hi guys, As I've mentioned a couple of times in previous patches some of the cts AoA tests are taking very long time to compile. This is due to excessive optimisation passes mainly in the glsl optimisations (there are some slowdowns in the intel backend too but these seemed to go away when I tried

Re: [Mesa-dev] [PATCH 1/5] i965: Push miptree tiling request into flags

2015-07-14 Thread Jordan Justen
Reviewed-by: Jordan Justen On 2015-07-14 09:56:09, Ben Widawsky wrote: > With the last few patches a way was provided to influence lower layer miptree > layout and allocation decisions via flags (replacing bools). For simplicity, I > chose not to touch the tiling requests because the change was s

[Mesa-dev] [PATCH] libdrm/amdgpu: Use private fd for amdgpu_device and winsys hash table to fix ZaphodHeads.

2015-07-14 Thread Mario Kleiner
The amdgpu_device for a device node needs its own dup'ed fd, instead of using the original fd passed in for a screen, to make multi-x-screen ZaphodHeads configurations work on amdgpu. The original fd's lifetime differs from that of the amdgpu_device, and from the one stored in the hash. The hash k

Re: [Mesa-dev] [PATCH 03/13] gallium/auxiliary: Use exp2(x) instead of pow(2.0, x).

2015-07-14 Thread Roland Scheidegger
Am 14.07.2015 um 04:03 schrieb Matt Turner: > On Mon, Jul 13, 2015 at 5:13 PM, Roland Scheidegger > wrote: >> Did you replace 2 of them by exp2f but one by exp2f on purpose? > > Yes, two of them are converting their results to floats so they were > converted to exp2f(). > > Upon inspection, the

Re: [Mesa-dev] [PATCH 0/5] [RFCish] Rework the miptree mapping logic

2015-07-14 Thread Ben Widawsky
On Tue, Jul 14, 2015 at 09:56:08AM -0700, Ben Widawsky wrote: > A few patches which cleanup the miptree mapping logic. I haven't heavily > tested > them yet, which is why I added the RFC label (admittedly I totally ignored the > unmap path, I hope it just works, but I'll find out). In particular,

Re: [Mesa-dev] [PATCH 02/10] i965: Reduce the scope of input in buffer tex setup

2015-07-14 Thread Ben Widawsky
On Wed, Jul 01, 2015 at 02:46:32PM +0300, Topi Pohjolainen wrote: > Signed-off-by: Topi Pohjolainen I swear I am not trying to nitpick but I don't actually understand what your goal of the patch is. Could you maybe elaborate a bit on what "reduce the scope of input in.." > --- > src/mesa/driver

[Mesa-dev] [PATCH] nir: Add a value range propagation pass

2015-07-14 Thread Thomas Helland
Signed-off-by: Thomas Helland --- src/glsl/Makefile.sources |1 + src/glsl/nir/nir.h |2 + src/glsl/nir/nir_opt_value_range.c | 1330 3 files changed, 1333 insertions(+) create mode 100644 src/glsl/nir/nir_opt_value_range.c d

Re: [Mesa-dev] [PATCH] clover: Pass image attributes to the kernel

2015-07-14 Thread Francisco Jerez
Zoltán Gilián writes: >> I have the suspicion >> that it would simplify both the OpenCL front-end and compiler back-end >> code if the image metadata was interleaved with images themselves. > > In fact this complicates the back-end, since the location of each > argument following an image argume

[Mesa-dev] [Bug 77449] Tracker bug for all bugs related to Steam titles

2015-07-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77449 acutia...@outlook.com changed: What|Removed |Added Depends on||91342 -- You are receiving this

[Mesa-dev] [PATCH 0/5] [RFC] Value range propagation for NIR

2015-07-14 Thread Thomas Helland
For now you'll just have to check my github repo at: https://github.com/thohel/mesa/tree/gsoc-range-prop2 I'll get the last patch out ASAP, but it seems like something has taken a huge crap on my send-email. It failed halfway, and is now crying about git send-email possibly being broken. Weird stu

Re: [Mesa-dev] [PATCH] clover: Pass image attributes to the kernel

2015-07-14 Thread Zoltán Gilián
> I have the suspicion > that it would simplify both the OpenCL front-end and compiler back-end > code if the image metadata was interleaved with images themselves. In fact this complicates the back-end, since the location of each argument following an image argument changes because of the metada

[Mesa-dev] [PATCH 4/5] nir: Add a helper for iterating over blocks in a cf node

2015-07-14 Thread Thomas Helland
We were already doing this internally for iterating over a function implementation, so just expose it directly. Signed-off-by: Connor Abbott --- src/glsl/nir/nir.c | 7 +++ src/glsl/nir/nir.h | 3 +++ 2 files changed, 10 insertions(+) diff --git a/src/glsl/nir/nir.c b/src/glsl/nir/nir.c ind

[Mesa-dev] [PATCH 3/5] nir: Move nir_instr_get_dest_ssa_def to nir.c / nir.h

2015-07-14 Thread Thomas Helland
This was originally located in nir_opt_cse. Move it out for reuse. Signed-off-by: Thomas Helland --- This probably is not that smart. We can ofcourse roll our own in value range pass. It was just so conventient at the time. src/glsl/nir/nir.c | 21 + src/glsl/nir/nir.

[Mesa-dev] [PATCH 2/5] nir: Add a worklist for SSA definitions

2015-07-14 Thread Thomas Helland
Signed-off-by: Connor Abbott V2: Added entry in makefile --- src/glsl/Makefile.sources | 1 + src/glsl/nir/nir_ssa_def_worklist.h | 100 2 files changed, 101 insertions(+) create mode 100644 src/glsl/nir/nir_ssa_def_worklist.h diff --git a/src/g

[Mesa-dev] [PATCH 0/5] [RFC] Value range propagation for NIR

2015-07-14 Thread Thomas Helland
The deadline for GSoC is aproaching a bit faster than I'm comfortable with, so I need to get this out on the list for some review-action. It's not yet complete, but I think it's getting there. At least it should be possible to infer what I'm trying to do I think. I haven't yet gotten to testing thi

[Mesa-dev] [PATCH 1/5] nir/worklist: Split out the type-independent parts

2015-07-14 Thread Thomas Helland
Now, nir_block_worklist is just a thin wraper around nir_worklist. We can now use nir_worklist also for SSA definitions. Signed-off-by: Connor Abbott V2: Correct comments in more places Add file to makefile Fix EOF blank line idx -> index Signed-off-by: Thomas Helland --- src/glsl

Re: [Mesa-dev] [PATCH 08/13] mesa: overhaul the glGetTexImage code

2015-07-14 Thread Ilia Mirkin
On Mon, Jul 13, 2015 at 9:21 PM, Brian Paul wrote: > 1. Reorganize the error checking code. > 2. Lay groundwork for getting sub images. > 3. Implement _mesa_GetnTexImageARB(), _mesa_GetTexImage() and >_mesa_GetTextureImage() all in terms of get_texture_image(). > --- > src/mesa/main/texgetima

Re: [Mesa-dev] [PATCH 07/13] mesa: 80-column wrapping in texgetimage.c

2015-07-14 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Mon, Jul 13, 2015 at 9:21 PM, Brian Paul wrote: > --- > src/mesa/main/texgetimage.c | 13 - > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/src/mesa/main/texgetimage.c b/src/mesa/main/texgetimage.c > index fb3c2c8..e180a4c 100644 > ---

Re: [Mesa-dev] [PATCH 06/13] mesa: replace Driver.GetCompressedTexImage() w/ GetCompressedTexSubImage()

2015-07-14 Thread Ilia Mirkin
With the depth GLint -> GLsizei type fixed, this is Reviewed-by: Ilia Mirkin On Mon, Jul 13, 2015 at 9:21 PM, Brian Paul wrote: > For now, pass offsets of zero and width/height/depth equal to the > whole image. > --- > src/mesa/drivers/common/driverfuncs.c | 2 +- > src/mesa/main/dd.h

Re: [Mesa-dev] [PATCH 05/13] mesa: make _mesa_get_[compressed_]texture_image() static

2015-07-14 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Mon, Jul 13, 2015 at 9:21 PM, Brian Paul wrote: > These functions are only called from teximage.c > --- > src/mesa/main/texgetimage.c | 24 > src/mesa/main/texgetimage.h | 7 --- > 2 files changed, 12 insertions(+), 19 deletions(-) > > d

Re: [Mesa-dev] [PATCH 1/2] mesa: Detect and provide macros for function attributes pure and const.

2015-07-14 Thread Kenneth Graunke
On Tuesday, July 14, 2015 11:45:57 AM Eric Anholt wrote: > These are really useful hints to the compiler in the absence of link-time > optimization, and I'm going to use them in VC4. > > I've made the const attribute be ATTRIBUTE_CONST unlike other function > attributes, because we have other thin

[Mesa-dev] [Bug 91337] OSMesaGetProcAdress("OSMesaPixelStore") returns nil

2015-07-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91337 Bug ID: 91337 Summary: OSMesaGetProcAdress("OSMesaPixelStore") returns nil Product: Mesa Version: 10.6 Hardware: All OS: All Status: NEW Severity: normal

Re: [Mesa-dev] [PATCH 12/14] scons: rework the EGL build

2015-07-14 Thread Matt Turner
On Jul 14, 2015 9:03 AM, "Emil Velikov" wrote: > > On 14 July 2015 at 16:20, Matt Turner wrote: > > On Tue, Jul 14, 2015 at 8:02 AM, Emil Velikov wrote: > >> The scons equivalent of the previous commit - just fold the almost > >> identical driver + main Sconscripts. > >> > >> Cc: Alexander von G

Re: [Mesa-dev] [PATCH 2/5] i965/fs: fix stride and type for hw_reg's in regs_read()

2015-07-14 Thread Connor Abbott
On Tue, Jul 14, 2015 at 6:02 AM, Francisco Jerez wrote: > Connor Abbott writes: > >> sources with file == HW_REG get all their information from the >> fixed_hw_reg field, so we need to get the stride and type from there >> when computing the size. >> >> Signed-off-by: Connor Abbott >> --- >> sr

Re: [Mesa-dev] [PATCH 14/14] egl: remove old makefile.sources

2015-07-14 Thread Matt Turner
Oh, sorry. I misread the diff. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 06/13] gallium/auxiliary: Avoid double promotion.

2015-07-14 Thread Eric Anholt
Matt Turner writes: > --- > src/gallium/auxiliary/util/u_format_rgb9e5.h | 2 +- > src/gallium/auxiliary/util/u_math.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/gallium/auxiliary/util/u_format_rgb9e5.h > b/src/gallium/auxiliary/util/u_format_rgb9e5

Re: [Mesa-dev] [PATCH 03/13] mesa: replace Driver.GetTexImage with GetTexSubImage()

2015-07-14 Thread Brian Paul
Yes. Missed that. I'll post an updated series later. Thanks for reviewing. -Brian On 07/14/2015 10:33 AM, Ilia Mirkin wrote: Don't you also have to update src/mesa/drivers/dri/i965/intel_tex_image.c:intel_get_tex_image ? On Mon, Jul 13, 2015 at 9:21 PM, Brian Paul wrote: The new driver ho

[Mesa-dev] [PATCH 2/2] vc4: Use the pure/const attributes on a bunch of our QPU functions.

2015-07-14 Thread Eric Anholt
On a release build, this makes the rest of vc4_qpu_validate.c go away (the compiler didn't know that our qpu helper function calls had no side effects). --- src/gallium/drivers/vc4/vc4_qpu.h| 30 +++--- src/gallium/drivers/vc4/vc4_tiling.h | 6 +++--- 2 files changed,

[Mesa-dev] [PATCH 1/2] mesa: Detect and provide macros for function attributes pure and const.

2015-07-14 Thread Eric Anholt
These are really useful hints to the compiler in the absence of link-time optimization, and I'm going to use them in VC4. I've made the const attribute be ATTRIBUTE_CONST unlike other function attributes, because we have other things in the tree #defining CONST for their own unrelated purposes. --

[Mesa-dev] [PATCH 0/5] [RFCish] Rework the miptree mapping logic

2015-07-14 Thread Ben Widawsky
A few patches which cleanup the miptree mapping logic. I haven't heavily tested them yet, which is why I added the RFC label (admittedly I totally ignored the unmap path, I hope it just works, but I'll find out). In particular, the last patch will have a much full list of tests and platforms before

[Mesa-dev] [PATCH 5/5] i965/miptree: Rewrite the miptree map logic

2015-07-14 Thread Ben Widawsky
This patch rewrites the logic for determining which method we using for mapping a miptree. It is my intention that that this patch, the required patches before this do not change functionality, or if they do, it's in very obscure an unobservable cases. I have two reasons why I decided to write thi

[Mesa-dev] [PATCH 1/5] i965: Push miptree tiling request into flags

2015-07-14 Thread Ben Widawsky
With the last few patches a way was provided to influence lower layer miptree layout and allocation decisions via flags (replacing bools). For simplicity, I chose not to touch the tiling requests because the change was slightly less mechanical than replacing the bools. The goal is to organize the

[Mesa-dev] [PATCH 4/5] i965/miptree: Shortcircuit writable & compressed miptrees

2015-07-14 Thread Ben Widawsky
If I am reading the code correctly, writable mappings and mappings for compressed miptrees will always end up using calling map_gtt. Signed-off-by: Ben Widawsky --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/mesa/drivers/dri/i965/in

[Mesa-dev] [PATCH 2/5] i965/miptree: Cleanup some of the miptree map logic

2015-07-14 Thread Ben Widawsky
At the crux of this change is moving whether or not we can even use the hardware blitter into the can_blit_slice check. Fundamentally this makes sense as blitting a slice is a subset in functionality of being able to use the blitter at all. NOTE: I think it's bad practice to have the assert in a f

[Mesa-dev] [PATCH 3/5] i965/miptree: Separate special miptree mappings

2015-07-14 Thread Ben Widawsky
Several mappings require special handling (stencil, etc textures, and depth). Since I am attempting to clean up the logic which chooses the way in which we map things, relegating this inflexible part to another part of the function reduces complexity. Signed-off-by: Ben Widawsky --- src/mesa/dri

Re: [Mesa-dev] [PATCH 04/13] mesa: plumb offset/size parameters through GetTexSubImage code

2015-07-14 Thread Ilia Mirkin
On Mon, Jul 13, 2015 at 9:21 PM, Brian Paul wrote: > Needed for GL_ARB_get_texture_sub_image. But at this point, the > offsets are always zero and the sizes match the whole texture image. > > v2: Fixes, suggestions from Laura Ekstrand: > * Fix calls to ctx->Driver.UnmapTextureImage() to pass the

Re: [Mesa-dev] [PATCH] glsl: free interface_types and replace old hash_table uses

2015-07-14 Thread Kenneth Graunke
On Tuesday, July 14, 2015 04:26:50 PM Timothy Arceri wrote: > On Mon, 2015-07-13 at 22:19 -0700, Kenneth Graunke wrote: > > On Monday, July 13, 2015 11:21:05 AM Iago Toral wrote: > > > On Sat, 2015-07-11 at 10:13 +1000, Timothy Arceri wrote: > > > > @@ -648,27 +653,28 @@ glsl_type::get_array_instan

Re: [Mesa-dev] [PATCH 03/13] mesa: replace Driver.GetTexImage with GetTexSubImage()

2015-07-14 Thread Ilia Mirkin
Don't you also have to update src/mesa/drivers/dri/i965/intel_tex_image.c:intel_get_tex_image ? On Mon, Jul 13, 2015 at 9:21 PM, Brian Paul wrote: > The new driver hook has x/y/zoffset and width/height/depth parameters > for the new glGetTextureSubImage() function. > > The meta code and gallium s

Re: [Mesa-dev] [PATCH 02/13] meta: add offset, width, height parameters to decompress_texture_image()

2015-07-14 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Mon, Jul 13, 2015 at 9:21 PM, Brian Paul wrote: > In preparation for decompressing texture sub images. > --- > src/mesa/drivers/common/meta.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/src/mesa/drivers/common/meta.c b/src/mesa

Re: [Mesa-dev] [PATCH 14/14] egl: remove old makefile.sources

2015-07-14 Thread Emil Velikov
On 14 July 2015 at 16:21, Matt Turner wrote: > On Tue, Jul 14, 2015 at 8:02 AM, Emil Velikov > wrote: >> Signed-off-by: Emil Velikov >> --- >> src/egl/Makefile.am | 3 +-- >> src/egl/main/Makefile.sources | 29 - >> 2 files changed, 1 insertion(+), 31 del

Re: [Mesa-dev] [PATCH 12/14] scons: rework the EGL build

2015-07-14 Thread Emil Velikov
On 14 July 2015 at 16:20, Matt Turner wrote: > On Tue, Jul 14, 2015 at 8:02 AM, Emil Velikov > wrote: >> The scons equivalent of the previous commit - just fold the almost >> identical driver + main Sconscripts. >> >> Cc: Alexander von Gluck IV >> Signed-off-by: Emil Velikov >> --- >> src/SCo

Re: [Mesa-dev] [PATCH 11/14] automake: rework the EGL build

2015-07-14 Thread Emil Velikov
On 14 July 2015 at 16:19, Matt Turner wrote: > On Tue, Jul 14, 2015 at 8:02 AM, Emil Velikov > wrote: [snip] >> +libEGL_la_SOURCES = \ >> + ${LIBEGL_C_FILES} > > I think you probably just want $(LIBEGL_C_FILES) instead of ${...} > This is what the original file in egl/main did. I'll fix it

Re: [Mesa-dev] [PATCH 12/13] mesa/math: Avoid double promotion.

2015-07-14 Thread Mike Stroyan
What we want here is c = cosf( angle * (float)(M_PI / 180.0) ); so the compiler can evaluate the constant expression and use a float representation for the result. I always find it a little awkward deciding between using OpenGL's types like GLfloat or simple language types when working with syste

Re: [Mesa-dev] [PATCH 00/14] EGL build system cleanups

2015-07-14 Thread Matt Turner
On Tue, Jul 14, 2015 at 8:02 AM, Emil Velikov wrote: > Hello all, > > This series aims at folding the separate egl/main + egl/driver/foo build > scripts into one. Thanks for doing all this -- it's something I've wanted to do for a while. It looks really nice. 2-6, 8-11 (11 has some comments) are

Re: [Mesa-dev] [PATCH 14/14] egl: remove old makefile.sources

2015-07-14 Thread Matt Turner
On Tue, Jul 14, 2015 at 8:02 AM, Emil Velikov wrote: > Signed-off-by: Emil Velikov > --- > src/egl/Makefile.am | 3 +-- > src/egl/main/Makefile.sources | 29 - > 2 files changed, 1 insertion(+), 31 deletions(-) > delete mode 100644 src/egl/main/Makefile.so

Re: [Mesa-dev] [PATCH 12/14] scons: rework the EGL build

2015-07-14 Thread Matt Turner
On Tue, Jul 14, 2015 at 8:02 AM, Emil Velikov wrote: > The scons equivalent of the previous commit - just fold the almost > identical driver + main Sconscripts. > > Cc: Alexander von Gluck IV > Signed-off-by: Emil Velikov > --- > src/SConscript | 3 +-- > src/egl/Makefile.am

Re: [Mesa-dev] [PATCH 11/14] automake: rework the EGL build

2015-07-14 Thread Matt Turner
On Tue, Jul 14, 2015 at 8:02 AM, Emil Velikov wrote: > Simplify things by merging the two makefiles. This way we can combine > the duplicated HAVE_PLATFORM_ checks, and build the library without > having a separate static library. > > Signed-off-by: Emil Velikov > --- > configure.ac

Re: [Mesa-dev] [PATCH 01/14] egl: remove the non-haiku scons build

2015-07-14 Thread Jose Fonseca
Reviewed-by: Jose Fonseca On 14/07/15 16:02, Emil Velikov wrote: It has been broken since 2011 with commit c98ea26e16b(egl: Make egl_dri2 and egl_glx built-in drivers.). When the backends got merged into the main library each entry point was guarded by a _EGL_BUILT_IN_DRIVER_* define. As the

[Mesa-dev] [PATCH 07/14] egl/haiku: remove unused DEFAULT_DRIVER_DIR define

2015-07-14 Thread Emil Velikov
Cc: Alexander von Gluck IV Signed-off-by: Emil Velikov --- src/egl/drivers/haiku/SConscript | 4 1 file changed, 4 deletions(-) diff --git a/src/egl/drivers/haiku/SConscript b/src/egl/drivers/haiku/SConscript index ec6020e..9db7ecf 100644 --- a/src/egl/drivers/haiku/SConscript +++ b/src/eg

[Mesa-dev] [PATCH 03/14] egl: remove final references of platform_null

2015-07-14 Thread Emil Velikov
Signed-off-by: Emil Velikov --- src/egl/main/Makefile.am | 4 src/egl/main/egldisplay.c | 1 - src/egl/main/egldisplay.h | 1 - 3 files changed, 6 deletions(-) diff --git a/src/egl/main/Makefile.am b/src/egl/main/Makefile.am index 9030d27..ec0f88e 100644 --- a/src/egl/main/Makefile.am +++

[Mesa-dev] [PATCH 02/14] egl: remove flatten HAVE_SHARED_GLAPI

2015-07-14 Thread Emil Velikov
It is simply not possible to use the dri backend without shared glapi, as the alternative provider (libGL) is not always present. We have fixed the build for a while now, so we can rip this out. Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/Android.mk | 1 - src/egl/drivers/dri2/Makefile

[Mesa-dev] [PATCH 05/14] egl: remove custom string functions

2015-07-14 Thread Emil Velikov
Support for Windows has been removed for a while now, and virtually every POSIX compliant system provides strcasecmp, strdup and snprintf. Signed-off-by: Emil Velikov --- src/egl/main/Makefile.sources | 2 -- src/egl/main/eglapi.c | 3 +-- src/egl/main/egldriver.c | 3 +-- src/eg

[Mesa-dev] [PATCH 08/14] egl: remove unused _EGL_DRIVER_SEARCH_DIR define

2015-07-14 Thread Emil Velikov
Signed-off-by: Emil Velikov --- src/egl/main/Android.mk | 3 +-- src/egl/main/Makefile.am | 3 +-- src/egl/main/SConscript | 4 3 files changed, 2 insertions(+), 8 deletions(-) diff --git a/src/egl/main/Android.mk b/src/egl/main/Android.mk index 4856528..270c165 100644 --- a/src/egl/main/

[Mesa-dev] [PATCH 10/14] gbm: do not build intermittent libgbm_dri static library

2015-07-14 Thread Emil Velikov
The only user of it (libgbm.la) immediately links it. Just build it directly into the library. Signed-off-by: Emil Velikov --- src/gbm/Makefile.am | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/gbm/Makefile.am b/src/gbm/Makefile.am index da4195d..9a584ca 100644 --

[Mesa-dev] [PATCH 09/14] egl: automake: remove unused HAVE_XCB_DRI2 define

2015-07-14 Thread Emil Velikov
Signed-off-by: Emil Velikov --- src/egl/main/Makefile.am | 1 - 1 file changed, 1 deletion(-) diff --git a/src/egl/main/Makefile.am b/src/egl/main/Makefile.am index 03fb826..32fed81 100644 --- a/src/egl/main/Makefile.am +++ b/src/egl/main/Makefile.am @@ -68,7 +68,6 @@ endif if HAVE_EGL_DRIVER

[Mesa-dev] [PATCH 06/14] egl: remove final Windows specific workaround

2015-07-14 Thread Emil Velikov
Signed-off-by: Emil Velikov --- src/egl/main/Android.mk | 3 +-- src/egl/main/Makefile.am | 3 +-- src/egl/main/SConscript | 1 - src/egl/main/egldriver.c | 5 - 4 files changed, 2 insertions(+), 10 deletions(-) diff --git a/src/egl/main/Android.mk b/src/egl/main/Android.mk index 0ba7295..

[Mesa-dev] [PATCH 04/14] egl: remove _EGL_PLATFORM_WINDOWS enum

2015-07-14 Thread Emil Velikov
Signed-off-by: Emil Velikov --- src/egl/main/egldisplay.c | 1 - src/egl/main/egldisplay.h | 1 - 2 files changed, 2 deletions(-) diff --git a/src/egl/main/egldisplay.c b/src/egl/main/egldisplay.c index f29f54e..f6db03a 100644 --- a/src/egl/main/egldisplay.c +++ b/src/egl/main/egldisplay.c @@ -6

[Mesa-dev] [PATCH 13/14] android: rework the EGL build

2015-07-14 Thread Emil Velikov
See previous two commits for details. Signed-off-by: Emil Velikov --- Android.mk | 3 +- src/egl/drivers/dri2/Android.mk | 63 - src/egl/main/Android.mk | 35 --- 3 files changed, 25 insertions(+), 76 delet

[Mesa-dev] [PATCH 14/14] egl: remove old makefile.sources

2015-07-14 Thread Emil Velikov
Signed-off-by: Emil Velikov --- src/egl/Makefile.am | 3 +-- src/egl/main/Makefile.sources | 29 - 2 files changed, 1 insertion(+), 31 deletions(-) delete mode 100644 src/egl/main/Makefile.sources diff --git a/src/egl/Makefile.am b/src/egl/Makefile.am inde

[Mesa-dev] [PATCH 01/14] egl: remove the non-haiku scons build

2015-07-14 Thread Emil Velikov
It has been broken since 2011 with commit c98ea26e16b(egl: Make egl_dri2 and egl_glx built-in drivers.). When the backends got merged into the main library each entry point was guarded by a _EGL_BUILT_IN_DRIVER_* define. As the define was missing, the linker kindly removed the whole of the dri2 ba

[Mesa-dev] [PATCH 12/14] scons: rework the EGL build

2015-07-14 Thread Emil Velikov
The scons equivalent of the previous commit - just fold the almost identical driver + main Sconscripts. Cc: Alexander von Gluck IV Signed-off-by: Emil Velikov --- src/SConscript | 3 +-- src/egl/Makefile.am | 5 ++--- src/egl/SConscript | 33 ++

[Mesa-dev] [PATCH 11/14] automake: rework the EGL build

2015-07-14 Thread Emil Velikov
Simplify things by merging the two makefiles. This way we can combine the duplicated HAVE_PLATFORM_ checks, and build the library without having a separate static library. Signed-off-by: Emil Velikov --- configure.ac | 3 +- src/Makefile.am | 8 +-- src/e

[Mesa-dev] [PATCH 00/14] EGL build system cleanups

2015-07-14 Thread Emil Velikov
Hello all, This series aims at folding the separate egl/main + egl/driver/foo build scripts into one. As a big hunk in either script is HAVE_PLATFORM_FOO dependant this allows us to remove the duplicated bits. While clearing it up I've noticed that the scons egl+x11 library was broken since 20

Re: [Mesa-dev] [RFC] loader: libudev vs sysfs vs libdrm

2015-07-14 Thread Emil Velikov
On 14 July 2015 at 07:48, Julien Isorce wrote: >>> - libdrm: used as a last resource fall-back after the above two. the >>> sole option used by *BSD, MacOS and Android. > > Hi, > > Unless I am missing something, libdrm is not used on MacOS. > > On osx, EGL_PLATFORM=x11 eglGetDisplay(NULL) calls dr

Re: [Mesa-dev] [PATCH 1/2] nouveau: always align buffers to 0x100

2015-07-14 Thread Ilia Mirkin
Actually any buffer can be bound as a constbuf, not just TFB. Reviewed-by: Ilia Mirkin On Tue, Jul 14, 2015 at 6:57 AM, Samuel Pitoiset wrote: > Only constbufs must be aligned to 0x100, but since a TFB buffer can be > rebinded as a constant buffer it must be also aligned. > > This patch prevent

Re: [Mesa-dev] [PATCH 11/13] mesa: add API dispatch for GL_ARB_get_texture_sub_image

2015-07-14 Thread Ilia Mirkin
On Tue, Jul 14, 2015 at 10:32 AM, Daniel Stone wrote: > Hi, > > On 14 July 2015 at 02:21, Brian Paul wrote: >> + And 165, not 96. >> + >> + > > Surely texture rather than program? > > Cheers, > Daniel > ___ > mesa-dev mailing list > mesa-d

Re: [Mesa-dev] [PATCH 11/13] mesa: add API dispatch for GL_ARB_get_texture_sub_image

2015-07-14 Thread Daniel Stone
Hi, On 14 July 2015 at 02:21, Brian Paul wrote: > + > + > + Surely texture rather than program? Cheers, Daniel ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 05/13] nir: Avoid double promition.

2015-07-14 Thread Emil Velikov
On 14 July 2015 at 00:22, Matt Turner wrote: > --- > src/glsl/nir/nir_opcodes.py | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/glsl/nir/nir_opcodes.py b/src/glsl/nir/nir_opcodes.py > index 56e96d9..df5b7e2 100644 > --- a/src/glsl/nir/nir_opcodes.py > +++ b/src/g

[Mesa-dev] [PATCH] glsl: replace null check with assert

2015-07-14 Thread Timothy Arceri
This was added in 54f583a20 since then error handling has improved. The test this was added to fix now fails earlier since 01822706ec --- src/glsl/ir_constant_expression.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/glsl/ir_constant_expression.cpp b/src/glsl/ir_c

Re: [Mesa-dev] [PATCH 06/13] gallium/auxiliary: Avoid double promotion.

2015-07-14 Thread Roland Scheidegger
gallium is already using fabsf in lots of other places. Supported by older msvc versions. Roland Am 14.07.2015 um 11:50 schrieb Iago Toral: > This one will need wrapping for fabsf. > > Reviewed-by: Iago Toral Quiroga > > On Mon, 2015-07-13 at 16:22 -0700, Matt Turner wrote: >> --- >> src/gall

Re: [Mesa-dev] [PATCH 2/5] i965/fs: fix stride and type for hw_reg's in regs_read()

2015-07-14 Thread Francisco Jerez
Connor Abbott writes: > sources with file == HW_REG get all their information from the > fixed_hw_reg field, so we need to get the stride and type from there > when computing the size. > > Signed-off-by: Connor Abbott > --- > src/mesa/drivers/dri/i965/brw_fs.cpp | 24 ++-- >

Re: [Mesa-dev] [PATCH 11/13] mesa: add API dispatch for GL_ARB_get_texture_sub_image

2015-07-14 Thread Brian Paul
On 07/13/2015 10:39 PM, Ilia Mirkin wrote: On Jul 13, 2015 9:21 PM, "Brian Paul" mailto:bri...@vmware.com>> wrote: > > This adds the new glGetTextureSubImage() and > glGetCompressedTextureSubImage() functions. Also update the > dispatch sanity test program. > --- > src/mapi/glapi/gen/ARB

Re: [Mesa-dev] [PATCH 13/13] mesa: Avoid double promotion.

2015-07-14 Thread Iago Toral
On Mon, 2015-07-13 at 16:22 -0700, Matt Turner wrote: > --- > src/mesa/main/ffvertex_prog.c | 10 +- > src/mesa/main/fog.c | 2 +- > src/mesa/main/get.c | 2 +- > src/mesa/main/light.c | 30 +++--- > src/mesa/main/lines.

Re: [Mesa-dev] [PATCH 12/13] mesa/math: Avoid double promotion.

2015-07-14 Thread Iago Toral
On Tue, 2015-07-14 at 13:19 +0200, Iago Toral wrote: > On Mon, 2015-07-13 at 16:22 -0700, Matt Turner wrote: > > --- > > src/mesa/math/m_clip_tmp.h | 20 ++--- > > src/mesa/math/m_matrix.c | 70 > > +++--- > > src/mesa/math/m_norm_tmp.h | 2 +- >

Re: [Mesa-dev] [PATCH 00/13] Avoid double promotion

2015-07-14 Thread Thomas Helland
Hi Matt, Just a small nitpick I noticed; s/promition/promotion in the commit message. -Thomas 2015-07-14 1:22 GMT+02:00 Matt Turner : > In the process of looking at the assembly generated from the OUT_BATCH > series, I noticed a bunch of float <-> double round trips. Mostly this > arises because

Re: [Mesa-dev] [PATCH 00/13] Avoid double promotion

2015-07-14 Thread Daniel Stone
Hi, On 14 July 2015 at 00:22, Matt Turner wrote: but it's not really > useful in general because float arguments are always cast to double > when passed as arguments to varargs functions like printf (why?), and > it warns about that, generating a lot of noise. It might shock you to learn that th

Re: [Mesa-dev] [PATCH 12/13] mesa/math: Avoid double promotion.

2015-07-14 Thread Iago Toral
On Mon, 2015-07-13 at 16:22 -0700, Matt Turner wrote: > --- > src/mesa/math/m_clip_tmp.h | 20 ++--- > src/mesa/math/m_matrix.c | 70 > +++--- > src/mesa/math/m_norm_tmp.h | 2 +- > 3 files changed, 46 insertions(+), 46 deletions(-) > > diff --g

Re: [Mesa-dev] [PATCH 11/13] program: Avoid double promotion.

2015-07-14 Thread Iago Toral
Needs wrappers for sinf, cosf, powf, logf. Reviewed-by: Iago Toral Quiroga On Mon, 2015-07-13 at 16:22 -0700, Matt Turner wrote: > --- > src/mesa/program/prog_execute.c | 30 +++--- > 1 file changed, 15 insertions(+), 15 deletions(-) > > diff --git a/src/mesa/program/pr

Re: [Mesa-dev] [PATCH 10/13] swrast: Avoid double promotion.

2015-07-14 Thread Iago Toral
Reviewed-by: Iago Toral Quiroga On Mon, 2015-07-13 at 16:22 -0700, Matt Turner wrote: > --- > src/mesa/swrast/s_aaline.c| 28 ++-- > src/mesa/swrast/s_aalinetemp.h| 4 ++-- > src/mesa/swrast/s_atifragshader.c | 4 ++-- > src/mesa/swrast/s_copypix.c |

[Mesa-dev] [PATCH 1/2] nouveau: always align buffers to 0x100

2015-07-14 Thread Samuel Pitoiset
Only constbufs must be aligned to 0x100, but since a TFB buffer can be rebinded as a constant buffer it must be also aligned. This patch prevents this behaviour by aligning everything to 256-byte increments at buffer creation. This fixes dmesg fails for the following piglit test: ext_transform_

[Mesa-dev] [PATCH 2/2] nv50/nvc0: force cache flush for constbufs

2015-07-14 Thread Samuel Pitoiset
This fixes the following piglit test: ext_transform_feedback-immediate-reuse-uniform-buffer I didn't test on nvc0 but this should work as expected. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nv50/nv50_shader_state.c | 2 ++ src/gallium/drivers/nouveau/nvc0/nvc0_state_val

Re: [Mesa-dev] [PATCH 09/13] tnl: Avoid double promotion.

2015-07-14 Thread Iago Toral
On Mon, 2015-07-13 at 16:22 -0700, Matt Turner wrote: > There are a couple of unrelated changes in t_vb_lighttmp.h that I hope > you'll excuse -- there's a block of code that's duplicated modulo a few > trivial differences that I took the liberty of fixing. > --- > src/mesa/tnl/t_draw.c

Re: [Mesa-dev] [PATCH v3 (part2) 54/56] docs: Mark ARB_shader_storage_buffer_object as done for i965.

2015-07-14 Thread Samuel Iglesias Gonsálvez
On 14/07/15 11:40, Iago Toral wrote: > Hi Mike, > > On Tue, 2015-07-14 at 09:30 +, Mike Lothian wrote: >> Hi Iago >> >> >> Nice work, was it an oversight this wasn't enabled for GLES 3.1? Or is >> the implementation slightly different? > > Good question, to be honest I don't remember right no

Re: [Mesa-dev] [PATCH 08/13] vbo: Avoid double promotion.

2015-07-14 Thread Iago Toral
Reviewed-by: Iago Toral Quiroga On Mon, 2015-07-13 at 16:22 -0700, Matt Turner wrote: > --- > src/mesa/vbo/vbo_context.c| 6 +++--- > src/mesa/vbo/vbo_exec_array.c | 4 ++-- > 2 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/src/mesa/vbo/vbo_context.c b/src/mesa/vbo/vbo_con

Re: [Mesa-dev] [PATCH 07/13] util: Avoid double promition.

2015-07-14 Thread Iago Toral
Reviewed-by: Iago Toral Quiroga On Mon, 2015-07-13 at 16:22 -0700, Matt Turner wrote: > --- > src/util/register_allocate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/util/register_allocate.c b/src/util/register_allocate.c > index 2ad8c3c..95be20f 100644 > --- a

Re: [Mesa-dev] [PATCH 06/13] gallium/auxiliary: Avoid double promotion.

2015-07-14 Thread Iago Toral
This one will need wrapping for fabsf. Reviewed-by: Iago Toral Quiroga On Mon, 2015-07-13 at 16:22 -0700, Matt Turner wrote: > --- > src/gallium/auxiliary/util/u_format_rgb9e5.h | 2 +- > src/gallium/auxiliary/util/u_math.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) >

Re: [Mesa-dev] [PATCH 05/13] nir: Avoid double promition.

2015-07-14 Thread Iago Toral
On Tue, 2015-07-14 at 11:30 +0200, Iago Toral wrote: > Reviewed-by: Iago Toral Quiroga BTW, ldexpf and copysignf are c99 too, so I guess you'll need to wrap these too. Iago > On Mon, 2015-07-13 at 16:22 -0700, Matt Turner wrote: > > --- > > src/glsl/nir/nir_opcodes.py | 4 ++-- > > 1 file chan

Re: [Mesa-dev] [PATCH v3 (part2) 54/56] docs: Mark ARB_shader_storage_buffer_object as done for i965.

2015-07-14 Thread Iago Toral
Hi Mike, On Tue, 2015-07-14 at 09:30 +, Mike Lothian wrote: > Hi Iago > > > Nice work, was it an oversight this wasn't enabled for GLES 3.1? Or is > the implementation slightly different? Good question, to be honest I don't remember right now, I think I checked this at some point and did no

Re: [Mesa-dev] [PATCH v3 (part2) 54/56] docs: Mark ARB_shader_storage_buffer_object as done for i965.

2015-07-14 Thread Mike Lothian
Hi Iago Nice work, was it an oversight this wasn't enabled for GLES 3.1? Or is the implementation slightly different? Cheers Mike On Tue, 14 Jul 2015 at 08:48 Iago Toral Quiroga wrote: > --- > docs/GL3.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/docs/GL3.txt

Re: [Mesa-dev] [PATCH 05/13] nir: Avoid double promition.

2015-07-14 Thread Iago Toral
Reviewed-by: Iago Toral Quiroga On Mon, 2015-07-13 at 16:22 -0700, Matt Turner wrote: > --- > src/glsl/nir/nir_opcodes.py | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/glsl/nir/nir_opcodes.py b/src/glsl/nir/nir_opcodes.py > index 56e96d9..df5b7e2 100644 > ---

Re: [Mesa-dev] [PATCH 04/13] i965: Use float calculations when double is unnecessary.

2015-07-14 Thread Iago Toral
Reviewed-by: Iago Toral Quiroga On Mon, 2015-07-13 at 16:22 -0700, Matt Turner wrote: > Literals without an f/F suffix are of type double, and implicit > conversion rules specify that the float in (float op double) be > converted to a double before the operation is performed. I believe float > ex

Re: [Mesa-dev] [PATCH v3 (part2) 10/56] glsl: Lower unsized array's length calculation expression

2015-07-14 Thread Samuel Iglesias Gonsálvez
On 14/07/15 11:05, Thomas Helland wrote: > 2015-07-14 9:46 GMT+02:00 Iago Toral Quiroga : >> From: Samuel Iglesias Gonsalvez >> >> Signed-off-by: Samuel Iglesias Gonsalvez >> --- >> src/glsl/lower_ubo_reference.cpp | 179 >> +++ > > ^ This is 80 characters

[Mesa-dev] [Bug 91020] Mesa's demo / tools won't compile since EGL changes

2015-07-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91020 --- Comment #4 from George Diamantopoulos --- Created attachment 117106 --> https://bugs.freedesktop.org/attachment.cgi?id=117106&action=edit Fix build against EGL implementations that don't support the EGL_MESA_screen_surface extension There

Re: [Mesa-dev] [PATCH v3 (part2) 10/56] glsl: Lower unsized array's length calculation expression

2015-07-14 Thread Thomas Helland
2015-07-14 9:46 GMT+02:00 Iago Toral Quiroga : > From: Samuel Iglesias Gonsalvez > > Signed-off-by: Samuel Iglesias Gonsalvez > --- > src/glsl/lower_ubo_reference.cpp | 179 > +++ ^ This is 80 characters wide in this case(for reference), so we're blowing the

[Mesa-dev] [Bug 90264] [Regression, bisected] Tooltip corruption in Chrome

2015-07-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90264 İsmail Dönmez changed: What|Removed |Added CC||ism...@donmez.ws -- You are receiving t

Re: [Mesa-dev] [PATCH v3 (part2) 00/56] ARB_shader_storage_buffer_object (mesa, i965)

2015-07-14 Thread Iago Toral
BTW, notice that patches 1-3, 5-7 and 51 have already been reviewed by Jordan. Iago On Tue, 2015-07-14 at 09:46 +0200, Iago Toral Quiroga wrote: > This is the second part of the v3 series including remaining frontend bits > like the optional unsized array at the bottom of SSBO definitions, layout

[Mesa-dev] [PATCH v3 (part2) 35/56] glsl: Add atomic functions from ARB_shader_storage_buffer_object

2015-07-14 Thread Iago Toral Quiroga
--- src/glsl/builtin_functions.cpp | 185 + 1 file changed, 185 insertions(+) diff --git a/src/glsl/builtin_functions.cpp b/src/glsl/builtin_functions.cpp index 4ba6d6f..c8ecefe 100644 --- a/src/glsl/builtin_functions.cpp +++ b/src/glsl/builtin_functions.cp

[Mesa-dev] [PATCH v3 (part2) 54/56] docs: Mark ARB_shader_storage_buffer_object as done for i965.

2015-07-14 Thread Iago Toral Quiroga
--- docs/GL3.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index 33a282e..6427616 100644 --- a/docs/GL3.txt +++ b/docs/GL3.txt @@ -164,7 +164,7 @@ GL 4.3, GLSL 4.30: GL_ARB_program_interface_query DONE (all drivers)

[Mesa-dev] [PATCH v3 (part2) 49/56] main: Add SHADER_STORAGE_BLOCK and BUFFER_VARIABLE support for ARB_program_interface_query

2015-07-14 Thread Iago Toral Quiroga
From: Samuel Iglesias Gonsalvez Including TOP_LEVEL_ARRAY_SIZE and TOP_LEVEL_ARRAY_STRIDE queries. Signed-off-by: Samuel Iglesias Gonsalvez --- src/glsl/ir_uniform.h| 5 + src/glsl/link_uniforms.cpp | 17 ++- src/glsl/linker.cpp | 10 +- src/mesa/main/program

[Mesa-dev] [PATCH v3 (part2) 45/56] glsl: Apply memory qualifiers to buffer variables

2015-07-14 Thread Iago Toral Quiroga
--- src/glsl/ast_to_hir.cpp | 25 + src/glsl/glsl_types.h | 10 ++ 2 files changed, 35 insertions(+) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index f0c2e5b..92bf414 100644 --- a/src/glsl/ast_to_hir.cpp +++ b/src/glsl/ast_to_hir.cpp @@ -5587,

  1   2   >