Re: [Mesa-dev] [PATCH 3/6] mesa: Add extension enable for OES_texture_storage_multisample_2d_array

2015-08-24 Thread Ilia Mirkin
On Fri, Aug 21, 2015 at 3:22 AM, Tapani Pälli tapani.pa...@intel.com wrote: Signed-off-by: Tapani Pälli tapani.pa...@intel.com --- src/mesa/main/extensions.c | 1 + src/mesa/main/mtypes.h | 1 + 2 files changed, 2 insertions(+) diff --git a/src/mesa/main/extensions.c

Re: [Mesa-dev] [PATCH v2 2/2] mesa/es3.1: Limit Framebuffer Parameter OpenGL ES 3.1 usage

2015-08-24 Thread Rogovin, Kevin
Reviewed-by: Kevin Rogovin kevin.rogovin at intel.com ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v4 (part2) 46/59] glsl: Allow use of memory qualifiers with ARB_shader_storage_buffer_object.

2015-08-24 Thread Samuel Iglesias Gonsálvez
On 13/08/15 10:05, Tapani Pälli wrote: Hi; I believe something more needs to be done here, it may be generic changes to the memory qualifier parsing. I wrote a Piglit test that fails with these changes (I tested against itoral-ARB_shader_storage_buffer_object-v4.1 branch), here:

Re: [Mesa-dev] vlVaQueryImageFormats and vlVdpVideoSurfaceQueryGetPutBitsYCbCrCapabilities also return unsupported formats

2015-08-24 Thread Christian König
On 24.08.2015 15:34, Julien Isorce wrote: Hi, Thx for your answers. Actually I also realized that vaQueryImageFormats is maybe more related to what formats vaCreateImage supports. And actually in mesa, vlVaCreateImage can create image for all formats NV12, YV12, YUYV, UYVY, BGRA. So what I

Re: [Mesa-dev] [PATCH v4 (part2) 53/59] glapi: add ARB_shader_storage_block_buffer_object

2015-08-24 Thread Emil Velikov
Hi Samuel, Iago, On 05/08/15 09:30, Iago Toral Quiroga wrote: From: Samuel Iglesias Gonsalvez sigles...@igalia.com v2: - Add ShaderStorageBlockBinding to static_data.py Why (see comment below) ? v4: - Ship ARB_shader_storage_buffer_object.xml in the tarball. Seems like other patches

[Mesa-dev] [Bug 91254] (regresion) video using VA-API on Intel slow and freeze system with mesa 10.6 or 10.6.1

2015-08-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91254 Chris Wilson ch...@chris-wilson.co.uk changed: What|Removed |Added CC||vogel...@vogel.cx

Re: [Mesa-dev] [PATCH v2 1/2] mesa/es3.1: Expose GL_ARB_framebuffer_no_attachments to GLES 3.1

2015-08-24 Thread Ilia Mirkin
On Mon, Aug 24, 2015 at 7:01 AM, Marta Lofstedt marta.lofst...@linux.intel.com wrote: From: Marta Lofstedt marta.lofst...@intel.com Signed-off-by: Marta Lofstedt marta.lofst...@intel.com --- src/mapi/glapi/gen/ARB_framebuffer_no_attachments.xml | 4 ++-- src/mapi/glapi/gen/apiexec.py

Re: [Mesa-dev] [PATCH v3 (part2) 08/56] glsl: add support for unsized arrays in shader storage blocks

2015-08-24 Thread Samuel Iglesias Gonsálvez
On 05/08/15 09:57, Iago Toral wrote: On Tue, 2015-08-04 at 14:08 -0700, Jordan Justen wrote: On 2015-07-14 00:46:10, Iago Toral Quiroga wrote: From: Samuel Iglesias Gonsalvez sigles...@igalia.com They only can be defined in the last position of the shader storage blocks. When an unsized

Re: [Mesa-dev] [PATCH v3 (part2) 08/56] glsl: add support for unsized arrays in shader storage blocks

2015-08-24 Thread Samuel Iglesias Gonsálvez
On 05/08/15 08:41, Iago Toral wrote: On Tue, 2015-08-04 at 14:08 -0700, Jordan Justen wrote: On 2015-07-14 00:46:10, Iago Toral Quiroga wrote: From: Samuel Iglesias Gonsalvez sigles...@igalia.com They only can be defined in the last position of the shader storage blocks. When an unsized

[Mesa-dev] [PATCH] mesa: uncomment checks in es31 computation, add texture_ms

2015-08-24 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- There's a patch on-list to uncomment the ARB_framebuffer_no_attachments one, so I'm leaving it alone. The other enables are all there. Also ARB_texture_multisample was missed in the requirement list. While not a perfect match, neither is

Re: [Mesa-dev] [PATCH] mesa: uncomment checks in es31 computation, add texture_ms

2015-08-24 Thread Martin Peres
On 24/08/15 16:36, Ilia Mirkin wrote: Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- There's a patch on-list to uncomment the ARB_framebuffer_no_attachments one, so I'm leaving it alone. The other enables are all there. Also ARB_texture_multisample was missed in the requirement list. While

Re: [Mesa-dev] [PATCH] mesa: uncomment checks in es31 computation, add texture_ms

2015-08-24 Thread Ilia Mirkin
On Mon, Aug 24, 2015 at 9:43 AM, Martin Peres martin.pe...@linux.intel.com wrote: On 24/08/15 16:36, Ilia Mirkin wrote: Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- There's a patch on-list to uncomment the ARB_framebuffer_no_attachments one, so I'm leaving it alone. The other

Re: [Mesa-dev] Fix saturation when coalescing registers in NIR-vec4

2015-08-24 Thread Antía Puentes
Hi! On vie, 2015-08-14 at 13:56 +0200, Antia Puentes wrote: With this fix, we can load the constants in NIR-vec4 as integers, as it is done in the FS backend. This is related to: http://lists.freedesktop.org/archives/mesa-dev/2015-July/089899.html I've been on holidays last week, as far I

Re: [Mesa-dev] [PATCH 5/6] mesa: enable enums for OES_texture_storage_multisample_2d_array

2015-08-24 Thread Ilia Mirkin
On Fri, Aug 21, 2015 at 3:22 AM, Tapani Pälli tapani.pa...@intel.com wrote: Signed-off-by: Tapani Pälli tapani.pa...@intel.com --- src/mesa/main/get_hash_params.py | 6 +++--- src/mesa/main/texobj.c | 6 -- src/mesa/main/texparam.c | 2 +- 3 files changed, 8

Re: [Mesa-dev] vlVaQueryImageFormats and vlVdpVideoSurfaceQueryGetPutBitsYCbCrCapabilities also return unsupported formats

2015-08-24 Thread Julien Isorce
Hi, Thx for your answers. Actually I also realized that vaQueryImageFormats is maybe more related to what formats vaCreateImage supports. And actually in mesa, vlVaCreateImage can create image for all formats NV12, YV12, YUYV, UYVY, BGRA. So what I am looking for is a way to retrieve what

Re: [Mesa-dev] [PATCH v2 1/2] mesa/es3.1: Expose GL_ARB_framebuffer_no_attachments to GLES 3.1

2015-08-24 Thread Ilia Mirkin
On Mon, Aug 24, 2015 at 9:59 AM, Lofstedt, Marta marta.lofst...@intel.com wrote: -Original Message- From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf Of Ilia Mirkin Sent: Monday, August 24, 2015 3:02 PM To: Marta Lofstedt Cc: mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH v2 1/2] mesa/es3.1: Expose GL_ARB_framebuffer_no_attachments to GLES 3.1

2015-08-24 Thread Rogovin, Kevin
Reviewed-by: Kevin Rogovin kevin.rogovin at intel.com ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v2] mesa: GetTexLevelParameter{if}v changes for OpenGL ES 3.1

2015-08-24 Thread Ilia Mirkin
Presumably something external will (continue to) prevent this from getting called for ES 3.1 right? Also, doesn't ES3.1 have texture buffers? Perhaps they can't be used here though. Please double-check. With all that verified, this patch is Reviewed-by: Ilia Mirkin imir...@alum.mit.edu On Mon,

Re: [Mesa-dev] [PATCH v2 1/2] mesa/es3.1: Expose GL_ARB_framebuffer_no_attachments to GLES 3.1

2015-08-24 Thread Lofstedt, Marta
-Original Message- From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf Of Ilia Mirkin Sent: Monday, August 24, 2015 3:02 PM To: Marta Lofstedt Cc: mesa-dev@lists.freedesktop.org Subject: Re: [Mesa-dev] [PATCH v2 1/2] mesa/es3.1: Expose

Re: [Mesa-dev] [PATCH v4 (part2) 53/59] glapi: add ARB_shader_storage_block_buffer_object

2015-08-24 Thread Emil Velikov
Hi Samuel, Iago, On 05/08/15 09:30, Iago Toral Quiroga wrote: From: Samuel Iglesias Gonsalvez sigles...@igalia.com v2: - Add ShaderStorageBlockBinding to static_data.py Why (see comment below) ? v4: - Ship ARB_shader_storage_buffer_object.xml in the tarball. Seems like other patches

Re: [Mesa-dev] [PATCH 0/8] add support for EGL_EXT_device_{base, query, enumeration}

2015-08-24 Thread Emil Velikov
Hi all, On 24 July 2015 at 15:19, Jonny Lamb jonny.l...@collabora.co.uk wrote: Here is an initial patchset implementing EGL_EXT_device_base (in practice nothing to do), device_enumeration (for listing devices), and device_query (for querying information about a device). I worked on this

Re: [Mesa-dev] [PATCH v3] mesa: Implement glMemoryBarrierByRegion

2015-08-24 Thread Rob Clark
ping? It would be kinda nice to have gles working again. Fwiw, issue seems to be an off-by-one in the dispatch table, resulting in (for example) glCheckFramebufferStatus() ending up in _mesa_DeleteFramebuffers(), which ends badly.. Program received signal SIGSEGV, Segmentation fault.

[Mesa-dev] [Bug 91724] GL/gl_mangle.h misses symbols from GLES/gl.h

2015-08-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91724 --- Comment #1 from Emil Velikov emil.l.veli...@gmail.com --- Hi Frederic, I could be missing something but I thought that mangling was only for GLX and desktop GL ? Thus I'm not sure that including GLES/* is the correct thing to do. As mangled

Re: [Mesa-dev] [PATCH] st/mesa: pass through 4th opcode argument in bitmap/pixel visitors

2015-08-24 Thread Brian Paul
On 08/20/2015 06:07 PM, Ilia Mirkin wrote: Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp

Re: [Mesa-dev] [Mesa-users] glClearColor is broken in a weird way if compiled with mangling enabled

2015-08-24 Thread Emil Velikov
On 24 August 2015 at 16:10, Brian Paul bri...@vmware.com wrote: Sounds like the file is being compiled without having proper prototypes for all the mgl functions. Do you see any compiler warnings when you build? What gcc compiler options are you using? Ftr I haven't been able to build mangled

Re: [Mesa-dev] [PATCH 2/2] amdgpu: serialize drmPrimeFDToHandle

2015-08-24 Thread Emil Velikov
[CCing mesa-dev as mesa will need similar fixes] Hi Christian, On 24/08/15 10:43, Christian König wrote: From: Christian König christian.koe...@amd.com Fixes the same problem as intel: Serialize drmPrimeFDToHandle with struct_mutex. Signed-off-by: Christian König

Re: [Mesa-dev] [PATCH] mesa: remove pointless es31 checks, fix indirect to only be in es31

2015-08-24 Thread Ilia Mirkin
On Mon, Aug 24, 2015 at 11:35 AM, Ilia Mirkin imir...@alum.mit.edu wrote: Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- src/mesa/main/get.c | 37 +--- src/mesa/main/get_hash_params.py | 46 2 files

Re: [Mesa-dev] [Mesa-users] glClearColor is broken in a weird way if compiled with mangling enabled

2015-08-24 Thread Brian Paul
Sounds like the file is being compiled without having proper prototypes for all the mgl functions. Do you see any compiler warnings when you build? What gcc compiler options are you using? -Brian On 08/19/2015 06:18 PM, Yuzhu Lu wrote: Update: All function with GLclampf and GLfloat are

Re: [Mesa-dev] [PATCH] mesa: Allow query of GL_VERTEX_BINDING_BUFFER

2015-08-24 Thread Brian Paul
On 08/19/2015 12:17 PM, Marta Lofstedt wrote: From: Marta Lofstedt marta.lofst...@intel.com According to OpenGL ES 3.1 specification table : 20.2 and OpenGL specification 4.4 table 23.4. The glGetIntegeri_v functions should report the name of the buffer bound when called with

Re: [Mesa-dev] [PATCH 01/15] gallium: add an interface for dumping debug driver state

2015-08-24 Thread Brian Paul
On 08/23/2015 06:04 AM, Marek Olšák wrote: From: Marek Olšák marek.ol...@amd.com --- src/gallium/include/pipe/p_context.h | 12 src/gallium/include/pipe/p_defines.h | 5 + 2 files changed, 17 insertions(+) diff --git a/src/gallium/include/pipe/p_context.h

Re: [Mesa-dev] [PATCH 00/15] gallium/radeonsi hang debugging and IB parser

2015-08-24 Thread Alex Deucher
On Mon, Aug 24, 2015 at 3:41 AM, Christian König deathsim...@vodafone.de wrote: Nice work! Finally something that goes into the direction of proper hang debugging for end users. I don't have time to completely review it but the whole set is Acked-by: Christian König christian.koe...@amd.com

[Mesa-dev] [PATCH] mesa: remove pointless es31 checks, fix indirect to only be in es31

2015-08-24 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- src/mesa/main/get.c | 37 +--- src/mesa/main/get_hash_params.py | 46 2 files changed, 24 insertions(+), 59 deletions(-) diff --git a/src/mesa/main/get.c

Re: [Mesa-dev] [PATCH 03/15] gallium/ddebug: new pipe for hang detection and driver state dumping (v2)

2015-08-24 Thread Emil Velikov
Hi Marek, On 23 August 2015 at 13:04, Marek Olšák mar...@gmail.com wrote: --- /dev/null +++ b/src/gallium/drivers/ddebug/Makefile.am @@ -0,0 +1,11 @@ +include Makefile.sources +include $(top_srcdir)/src/gallium/Automake.inc + +AM_CFLAGS = \ + $(GALLIUM_DRIVER_CFLAGS) +

[Mesa-dev] [PATCH] nv50: avoid using inline vertex data submit when gl_VertexID is used

2015-08-24 Thread Ilia Mirkin
The hardware only generates vertexid when vertices come from a VBO. This fixes: vertexid-drawelements vertexid-drawarrays Signed-off-by: Ilia Mirkin imir...@alum.mit.edu Cc: 11.0 mesa-sta...@lists.freedesktop.org --- src/gallium/drivers/nouveau/nv50/nv50_program.c| 1 +

Re: [Mesa-dev] [Nouveau] [PATCH] nv50: avoid using inline vertex data submit when gl_VertexID is used

2015-08-24 Thread Tobias Klausmann
On 24.08.2015 17:51, Ilia Mirkin wrote: The hardware only generates vertexid when vertices come from a VBO. This fixes: vertexid-drawelements vertexid-drawarrays Signed-off-by: Ilia Mirkin imir...@alum.mit.edu Cc: 11.0 mesa-sta...@lists.freedesktop.org ---

Re: [Mesa-dev] [Nouveau] [PATCH] nv50: avoid using inline vertex data submit when gl_VertexID is used

2015-08-24 Thread Ilia Mirkin
On Mon, Aug 24, 2015 at 11:57 AM, Tobias Klausmann tobias.johannes.klausm...@mni.thm.de wrote: On 24.08.2015 17:51, Ilia Mirkin wrote: The hardware only generates vertexid when vertices come from a VBO. This fixes: vertexid-drawelements vertexid-drawarrays Signed-off-by: Ilia

[Mesa-dev] [Bug 91724] GL/gl_mangle.h misses symbols from GLES/gl.h

2015-08-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91724 --- Comment #2 from Frederic Devernay frederic.dever...@m4x.org --- Hi Emil, I first tried updating the header, but the gl*x functions were still not mangled. I have build instructions for OSX on

Re: [Mesa-dev] [Mesa-users] glClearColor is broken in a weird way if compiled with mangling enabled

2015-08-24 Thread Brian Paul
On 08/24/2015 10:51 AM, Yuzhu Lu wrote: Hi Brian, It happens for all the configuration I tried. Here is one example: ./configure --disable-xvmc --disable-glx --disable-dri --with-dri-drivers= --with-gallium-drivers=swrast --enable-texture-float --enable-shared-glapi --disable-egl

Re: [Mesa-dev] [Mesa-users] glClearColor is broken in a weird way if compiled with mangling enabled

2015-08-24 Thread Yuzhu Lu
Sorry. Here it is: osboxes@osboxes:~/Documents/mesa-demos-8.2.0/src/osdemos$ gcc -o osdemo32 osdemo32.c -I/usr/local/include/ -I/home/osboxes/Documents/mesa-demos-8.2.0/src/util/ -L/usr/local/lib/ -lMangledOSMesa32 osdemo32.c: In function ‘Init’: osdemo32.c:122:32: warning: cast to

Re: [Mesa-dev] [Mesa-users] glClearColor is broken in a weird way if compiled with mangling enabled

2015-08-24 Thread Yuzhu Lu
Hi Brian, It happens for all the configuration I tried. Here is one example: ./configure --disable-xvmc --disable-glx --disable-dri --with-dri-drivers= --with-gallium-drivers=swrast --enable-texture-float --enable-shared-glapi --disable-egl --enable-mangling --with-egl-platforms=

[Mesa-dev] [Bug 91724] GL/gl_mangle.h misses symbols from GLES/gl.h

2015-08-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91724 --- Comment #3 from Frederic Devernay frederic.dever...@m4x.org --- just added the lines to build the demo. If you don't apply my patch to gl_mangle.h, you end up with undefined symbols. -- You are receiving this mail because: You are the QA

Re: [Mesa-dev] [PATCH v2 2/2] i965/vec4_nir: Load constants as integers

2015-08-24 Thread Jason Ekstrand
Could you please debase this patch (probably rewrite)? I *think* it should fix https://bugs.freedesktop.org/show_bug.cgi?id=91716. What were the shader-db results for it? On Aug 24, 2015 4:51 AM, Antia Puentes apuen...@igalia.com wrote: Loads constants using integer as their register type, this

[Mesa-dev] [PATCH] mesa: make _mesa_bind_texture_unit() static

2015-08-24 Thread Brian Paul
It's only called from the file it's defined in. --- src/mesa/main/texobj.c | 10 +- src/mesa/main/texobj.h | 4 2 files changed, 5 insertions(+), 9 deletions(-) diff --git a/src/mesa/main/texobj.c b/src/mesa/main/texobj.c index 395e4d3..c5d83e1 100644 --- a/src/mesa/main/texobj.c

Re: [Mesa-dev] [PATCH v3] mesa: Implement glMemoryBarrierByRegion

2015-08-24 Thread Rob Clark
fwiw, issue seems to be due to picking up installed libglapi.so vs. one in $MESA/lib (where I was pointing $LD_LIBRARY_PATH).. So this shouldn't be an issue running installed mesa. (Although I'm a bit curious how it ended up using installed libglapi.so vs the one in $LD_LIBRARY_PATH) BR, -R On

Re: [Mesa-dev] [Mesa-users] glClearColor is broken in a weird way if compiled with mangling enabled

2015-08-24 Thread Brian Paul
Looks like your code is not finding any mgl*() prototypes. What #includes do you have? I think you need to #include GL/gl_mangle.h and then GL/gl.h, IIRC. -Brian On 08/24/2015 11:42 AM, Yuzhu Lu wrote: Sorry. Here it is: osboxes@osboxes:~/Documents/mesa-demos-8.2.0/src/osdemos$ gcc -o

Re: [Mesa-dev] [PATCH 1/6] mesa: GetTexLevelParameter{if}v changes for OpenGL ES 3.1

2015-08-24 Thread Tapani Pälli
On 08/24/2015 08:38 AM, Ilia Mirkin wrote: On Aug 24, 2015 1:25 AM, Tapani Pälli tapani.pa...@intel.com mailto:tapani.pa...@intel.com wrote: On 08/24/2015 08:17 AM, Ilia Mirkin wrote: On Aug 24, 2015 1:07 AM, Tapani Pälli tapani.pa...@intel.com mailto:tapani.pa...@intel.com

Re: [Mesa-dev] [PATCH 1/6] mesa: GetTexLevelParameter{if}v changes for OpenGL ES 3.1

2015-08-24 Thread Ilia Mirkin
On Aug 24, 2015 2:01 AM, Tapani Pälli tapani.pa...@intel.com wrote: On 08/24/2015 08:38 AM, Ilia Mirkin wrote: On Aug 24, 2015 1:25 AM, Tapani Pälli tapani.pa...@intel.com mailto:tapani.pa...@intel.com wrote: On 08/24/2015 08:17 AM, Ilia Mirkin wrote: On Aug 24, 2015

Re: [Mesa-dev] [PATCH] mesa/es3.1: Allow GL_COMPUTE_WORK_GROUP_SIZE for OpenGL ES 3.1

2015-08-24 Thread Tapani Pälli
Reviewed-by: Tapani Pälli tapani.pa...@intel.com (let's get rid of the '/es3.1' in commit title) On 08/19/2015 04:30 PM, Marta Lofstedt wrote: From: Marta Lofstedt marta.lofst...@intel.com According to OpenGL ES specification section 7.12, GL_COMPUTE_WORK_GROUP_SIZE, is supported by the

Re: [Mesa-dev] [PATCH] mesa/es3.1: Enable getting MAX_COMPUTE_WORK_GROUP_ values for OpenGL ES 3.1

2015-08-24 Thread Tapani Pälli
Reviewed-by: Tapani Pälli tapani.pa...@intel.com On 08/19/2015 04:33 PM, Marta Lofstedt wrote: From: Marta Lofstedt marta.lofst...@intel.com According to the OpenGL ES 3.1 specification chapter 17, the MAX_COMPUTE_WORK_GROUP_COUNT and MAX_COMPUTE_WORK_GROUP_SIZE is available for

Re: [Mesa-dev] [PATCH 00/15] gallium/radeonsi hang debugging and IB parser

2015-08-24 Thread Christian König
Nice work! Finally something that goes into the direction of proper hang debugging for end users. I don't have time to completely review it but the whole set is Acked-by: Christian König christian.koe...@amd.com Regards, Christian. On 23.08.2015 14:04, Marek Olšák wrote: Hi, Setting

[Mesa-dev] [Bug 91254] (regresion) video using VA-API on Intel slow and freeze system with mesa 10.6 or 10.6.1

2015-08-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91254 Chris Wilson ch...@chris-wilson.co.uk changed: What|Removed |Added Status|NEW |RESOLVED

Re: [Mesa-dev] [PATCH] i965: Always re-emit the pipeline select during invariant state emission

2015-08-24 Thread Chris Wilson
On Sun, Aug 23, 2015 at 12:37:09PM -0700, Jordan Justen wrote: Can you also cc mesa-stable in the commit message? Cc: 10.6 11.0 mesa-sta...@lists.freedesktop.org Amendments made and pushed with Thomas' t-b. Thanks, -Chris -- Chris Wilson, Intel Open Source Technology Centre

Re: [Mesa-dev] [PATCH 3/6] mesa: Add extension enable for OES_texture_storage_multisample_2d_array

2015-08-24 Thread Lofstedt, Marta
Reviewed-by: Marta Lofstedt marta.lofst...@intel.com -Original Message- From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf Of Tapani Pälli Sent: Friday, August 21, 2015 9:22 AM To: mesa-dev@lists.freedesktop.org Subject: [Mesa-dev] [PATCH 3/6] mesa: Add

[Mesa-dev] [PATCH v2] mesa: GetTexLevelParameter{if}v changes for OpenGL ES 3.1

2015-08-24 Thread Tapani Pälli
Patch refactors existing parameters check to first check common enums between desktop GL and GLES 3.1 and modifies get_tex_level_parameter_image to be compatible with enums specified in 3.1. v2: remove extra is_gles31() checks (suggested by Ilia) Signed-off-by: Tapani Pälli

[Mesa-dev] [PATCH v2 2/2] mesa/es3.1: Limit Framebuffer Parameter OpenGL ES 3.1 usage

2015-08-24 Thread Marta Lofstedt
From: Marta Lofstedt marta.lofst...@intel.com According to OpenGL ES 3.1 specification, section 9.2.1 for glFramebufferParameter and section 9.2.3 for glGetFramebufferParameteriv: An INVALID_ENUM error is generated if pname is not FRAMEBUFFER_DEFAULT_WIDTH, FRAMEBUFFER_DEFAULT_HEIGHT,

[Mesa-dev] [PATCH v2 1/2] mesa/es3.1: Expose GL_ARB_framebuffer_no_attachments to GLES 3.1

2015-08-24 Thread Marta Lofstedt
From: Marta Lofstedt marta.lofst...@intel.com Signed-off-by: Marta Lofstedt marta.lofst...@intel.com --- src/mapi/glapi/gen/ARB_framebuffer_no_attachments.xml | 4 ++-- src/mapi/glapi/gen/apiexec.py | 4 ++-- src/mesa/main/get.c | 6

Re: [Mesa-dev] [PATCH 2/2] mesa/es3.1: Limit Framebuffer Parameter OpenGL ES 3.1 usage

2015-08-24 Thread Lofstedt, Marta
-Original Message- From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf Of Tapani Pälli Sent: Monday, August 24, 2015 12:05 PM To: Marta Lofstedt; mesa-dev@lists.freedesktop.org Subject: Re: [Mesa-dev] [PATCH 2/2] mesa/es3.1: Limit Framebuffer Parameter OpenGL ES

Re: [Mesa-dev] [PATCH 2/2] mesa/es3.1: Limit Framebuffer Parameter OpenGL ES 3.1 usage

2015-08-24 Thread Lofstedt, Marta
-Original Message- From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf Of Tapani Pälli Sent: Monday, August 24, 2015 11:22 AM To: Marta Lofstedt; mesa-dev@lists.freedesktop.org Subject: Re: [Mesa-dev] [PATCH 2/2] mesa/es3.1: Limit Framebuffer Parameter OpenGL ES

Re: [Mesa-dev] [PATCH 1/6] mesa: GetTexLevelParameter{if}v changes for OpenGL ES 3.1

2015-08-24 Thread Lofstedt, Marta
Reviewed-by: Marta Lofstedt marta.lofst...@intel.com -Original Message- From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf Of Tapani Pälli Sent: Friday, August 21, 2015 9:22 AM To: mesa-dev@lists.freedesktop.org Subject: [Mesa-dev] [PATCH 1/6] mesa:

Re: [Mesa-dev] [PATCH 5/6] mesa: enable enums for OES_texture_storage_multisample_2d_array

2015-08-24 Thread Lofstedt, Marta
Reviewed-by: Marta Lofstedt marta.lofst...@intel.com -Original Message- From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf Of Tapani Pälli Sent: Friday, August 21, 2015 9:22 AM To: mesa-dev@lists.freedesktop.org Subject: [Mesa-dev] [PATCH 5/6] mesa: enable

Re: [Mesa-dev] [PATCH 6/6] i965: enable OES_texture_storage_multisample_2d_array

2015-08-24 Thread Lofstedt, Marta
Reviewed-by: Marta Lofstedt marta.lofst...@intel.com -Original Message- From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf Of Tapani Pälli Sent: Friday, August 21, 2015 9:22 AM To: mesa-dev@lists.freedesktop.org Subject: [Mesa-dev] [PATCH 6/6] i965: enable

Re: [Mesa-dev] [PATCH 2/6] glapi: add GL_OES_texture_storage_multisample_2d_array extension

2015-08-24 Thread Lofstedt, Marta
Reviewed-by: Marta Lofstedt marta.lofst...@intel.com -Original Message- From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf Of Tapani Pälli Sent: Friday, August 21, 2015 9:22 AM To: mesa-dev@lists.freedesktop.org Subject: [Mesa-dev] [PATCH 2/6] glapi: add

Re: [Mesa-dev] [PATCH 4/6] glsl: add support for OES_texture_storage_multisample_2d_array

2015-08-24 Thread Lofstedt, Marta
Reviewed-by: Marta Lofstedt marta.lofst...@intel.com -Original Message- From: Palli, Tapani Sent: Monday, August 24, 2015 7:11 AM To: Lofstedt, Marta; mesa-dev@lists.freedesktop.org Subject: Re: [Mesa-dev] [PATCH 4/6] glsl: add support for OES_texture_storage_multisample_2d_array

[Mesa-dev] [PATCH 1/2] mesa/es3.1: Expose GL_ARB_framebuffer_no_attachments to GLES 3.1

2015-08-24 Thread Marta Lofstedt
From: Marta Lofstedt marta.lofst...@intel.com Signed-off-by: Marta Lofstedt marta.lofst...@intel.com --- src/mapi/glapi/gen/ARB_framebuffer_no_attachments.xml | 4 ++-- src/mapi/glapi/gen/apiexec.py | 4 ++-- src/mesa/main/get.c | 6

[Mesa-dev] [PATCH 2/2] mesa/es3.1: Limit Framebuffer Parameter OpenGL ES 3.1 usage

2015-08-24 Thread Marta Lofstedt
From: Marta Lofstedt marta.lofst...@intel.com According to OpenGL ES 3.1 specification, section 9.2.1 for glFramebufferParameter and section 9.2.3 for glGetFramebufferParameteriv: An INVALID_ENUM error is generated if pname is not FRAMEBUFFER_DEFAULT_WIDTH, FRAMEBUFFER_DEFAULT_HEIGHT,

Re: [Mesa-dev] [PATCH 2/2] mesa/es3.1: Limit Framebuffer Parameter OpenGL ES 3.1 usage

2015-08-24 Thread Tapani Pälli
On 08/24/2015 12:21 PM, Tapani Pälli wrote: On 08/24/2015 10:10 AM, Marta Lofstedt wrote: From: Marta Lofstedt marta.lofst...@intel.com According to OpenGL ES 3.1 specification, section 9.2.1 for glFramebufferParameter and section 9.2.3 for glGetFramebufferParameteriv: An INVALID_ENUM

Re: [Mesa-dev] [PATCH 2/2] mesa/es3.1: Limit Framebuffer Parameter OpenGL ES 3.1 usage

2015-08-24 Thread Tapani Pälli
On 08/24/2015 10:10 AM, Marta Lofstedt wrote: From: Marta Lofstedt marta.lofst...@intel.com According to OpenGL ES 3.1 specification, section 9.2.1 for glFramebufferParameter and section 9.2.3 for glGetFramebufferParameteriv: An INVALID_ENUM error is generated if pname is not

[Mesa-dev] [PATCH v2 2/2] i965/vec4_nir: Load constants as integers

2015-08-24 Thread Antia Puentes
Loads constants using integer as their register type, this is done for consistency with the FS backend. --- src/mesa/drivers/dri/i965/brw_vec4_nir.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4_nir.cpp

[Mesa-dev] [PATCH 2/2] mesa: limit scope of GL 1.0 compatibility shim

2015-08-24 Thread Erik Faye-Lund
OpenGL doesn't expect internalformat={1,2,3,4} to work elsewhere than glTexImage{1,2,3}D, as clearly stated in the spec of glCopyTexImage2D (taken from the OpenGL 1.1 spec, similar wording is present up to OpenGL 3.1 core, where OpenGL 1.0 compatibility was scrapped entirely): Parameters level,

Re: [Mesa-dev] [PATCH 2/2] mesa/formats: make format testing a gtest

2015-08-24 Thread Nanley Chery
On Fri, Aug 21, 2015 at 2:12 PM, Chad Versace chad.vers...@intel.com wrote: On Wed 19 Aug 2015, Nanley Chery wrote: From: Nanley Chery nanley.g.ch...@intel.com We currently check that our format info table is sane during context initialization in debug builds. Perform this check during

[Mesa-dev] [PATCH 1/2] mesa: only look up base-format once

2015-08-24 Thread Erik Faye-Lund
There's no point in repeatedly looking up the base-format of an internalformat. So let's cache it in a variable instead. Signed-off-by: Erik Faye-Lund kusmab...@gmail.com --- src/mesa/main/teximage.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 1/4] r600g: make all scissor states use single atom

2015-08-24 Thread Marek Olšák
The workaround for a missing scissor enable on r600 must be applied to all scissors, not just 0. That is, if scissor.enable is changed, all scissors must be marked as dirty. Marek On Mon, Aug 24, 2015 at 2:24 AM, Grazvydas Ignotas nota...@gmail.com wrote: As suggested by Marek Olšák, we can use

Re: [Mesa-dev] [PATCH 1/9] mesa: rework Driver.CopyImageSubData() and related code

2015-08-24 Thread Emil Velikov
On 24/08/15 21:42, Brian Paul wrote: I'm having trouble with git send-mail. One of the patches was authored by a VMware intern whose email address is no longer valid. When I send the series, I'm getting an error on the 4th patch and git send-email aborts. Trying to figure it out...

Re: [Mesa-dev] [PATCH] nir: Use !block_ends_in_jump() in a few places rather than open-coding.

2015-08-24 Thread Jason Ekstrand
R-B On Mon, Aug 24, 2015 at 1:39 PM, Kenneth Graunke kenn...@whitecape.org wrote: Connor introduced this helper recently; we should use it here too. I had to move the function earlier in the file for it to be available. Signed-off-by: Kenneth Graunke kenn...@whitecape.org ---

Re: [Mesa-dev] [PATCH] nv50: avoid using inline vertex data submit when gl_VertexID is used

2015-08-24 Thread Ilia Mirkin
Edge flag stuff is annoying. Pretty sure only blender uses it. shade model = flat should get fixed on nv50 before edge flags, since blender uses that too, and it's produces much worse visual artifacts. I'm having second thoughts about this patch. I think I'm going to go back to my previous

[Mesa-dev] [PATCH 1/9] mesa: rework Driver.CopyImageSubData() and related code

2015-08-24 Thread Brian Paul
Previously, core Mesa's _mesa_CopyImageSubData() created temporary textures to wrap renderbuffer sources/destinations. This caused a bit of a mess in the Mesa/gallium state tracker because we had to basically undo that wrapping. Instead, change ctx-Driver.CopyImageSubData() to take both

[Mesa-dev] [Bug 91747] Ubuntu 15.04/Oibaf PPA - Unity bar not transparent

2015-08-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91747 Bug ID: 91747 Summary: Ubuntu 15.04/Oibaf PPA - Unity bar not transparent Product: Mesa Version: unspecified Hardware: Other OS: Linux (All) Status: NEW

[Mesa-dev] [PATCH 3/9] st/mesa: tweak surface format mapping table

2015-08-24 Thread Brian Paul
1. Try to choose R8G8B8A8 unorm/srgb formats before other orders in an effort to try to match component ordering for UINT/SINT/etc. 2. If we can't get a format such as PIPE_FORMAT_A16_UNORM, try PIPE_FORMAT_R16G16B16A16_UNORM before shallower formats. --- src/mesa/state_tracker/st_format.c | 20

[Mesa-dev] [PATCH 2/9] util: update util_resource_copy_region() for GL_ARB_copy_image

2015-08-24 Thread Brian Paul
This primarily means added support for copying between compressed and uncompressed formats. --- src/gallium/auxiliary/util/u_surface.c | 106 +++-- 1 file changed, 88 insertions(+), 18 deletions(-) diff --git a/src/gallium/auxiliary/util/u_surface.c

Re: [Mesa-dev] [PATCH 1/9] mesa: rework Driver.CopyImageSubData() and related code

2015-08-24 Thread Brian Paul
I'm having trouble with git send-mail. One of the patches was authored by a VMware intern whose email address is no longer valid. When I send the series, I'm getting an error on the 4th patch and git send-email aborts. Trying to figure it out... Sorry for the spam. -Brian On 08/24/2015

Re: [Mesa-dev] [PATCH 1/9] mesa: rework Driver.CopyImageSubData() and related code

2015-08-24 Thread Emil Velikov
On 24/08/15 21:42, Brian Paul wrote: I'm having trouble with git send-mail. One of the patches was authored by a VMware intern whose email address is no longer valid. When I send the series, I'm getting an error on the 4th patch and git send-email aborts. Trying to figure it out...

Re: [Mesa-dev] [PATCH 3/9] st/mesa: tweak surface format mapping table

2015-08-24 Thread Brian Paul
On 08/24/2015 02:44 PM, Ilia Mirkin wrote: Not that I really care, but... why flip the order of bgra vs rgba? Because if an 8-bit RGBA integer texture is created, we'll use the gallium format PIPE_FORMAT_R8G8B8A8_SINT. If we create another non-integer surface with PIPE_FORMAT_B8G8R8A8_UNORM

Re: [Mesa-dev] [PATCH 3/9] st/mesa: tweak surface format mapping table

2015-08-24 Thread Ilia Mirkin
On Mon, Aug 24, 2015 at 4:54 PM, Brian Paul bri...@vmware.com wrote: On 08/24/2015 02:44 PM, Ilia Mirkin wrote: Not that I really care, but... why flip the order of bgra vs rgba? Because if an 8-bit RGBA integer texture is created, we'll use the gallium format PIPE_FORMAT_R8G8B8A8_SINT. If

Re: [Mesa-dev] [PATCH] nv50: avoid using inline vertex data submit when gl_VertexID is used

2015-08-24 Thread Samuel Pitoiset
On 08/24/2015 10:02 PM, Ilia Mirkin wrote: Edge flag stuff is annoying. Pretty sure only blender uses it. shade model = flat should get fixed on nv50 before edge flags, since blender uses that too, and it's produces much worse visual artifacts. No rush for this one though. I'm having

[Mesa-dev] [PATCH 2/9] util: update util_resource_copy_region() for GL_ARB_copy_image

2015-08-24 Thread Brian Paul
This primarily means added support for copying between compressed and uncompressed formats. --- src/gallium/auxiliary/util/u_surface.c | 106 +++-- 1 file changed, 88 insertions(+), 18 deletions(-) diff --git a/src/gallium/auxiliary/util/u_surface.c

[Mesa-dev] [PATCH 1/9] mesa: rework Driver.CopyImageSubData() and related code

2015-08-24 Thread Brian Paul
Previously, core Mesa's _mesa_CopyImageSubData() created temporary textures to wrap renderbuffer sources/destinations. This caused a bit of a mess in the Mesa/gallium state tracker because we had to basically undo that wrapping. Instead, change ctx-Driver.CopyImageSubData() to take both

[Mesa-dev] [PATCH 3/9] st/mesa: tweak surface format mapping table

2015-08-24 Thread Brian Paul
1. Try to choose R8G8B8A8 unorm/srgb formats before other orders in an effort to try to match component ordering for UINT/SINT/etc. 2. If we can't get a format such as PIPE_FORMAT_A16_UNORM, try PIPE_FORMAT_R16G16B16A16_UNORM before shallower formats. --- src/mesa/state_tracker/st_format.c | 20

[Mesa-dev] [PATCH] nir: Use !block_ends_in_jump() in a few places rather than open-coding.

2015-08-24 Thread Kenneth Graunke
Connor introduced this helper recently; we should use it here too. I had to move the function earlier in the file for it to be available. Signed-off-by: Kenneth Graunke kenn...@whitecape.org --- src/glsl/nir/nir_control_flow.c | 21 + 1 file changed, 9 insertions(+), 12

Re: [Mesa-dev] [PATCH 4/4] r600g: simplify dirty atom tracking

2015-08-24 Thread Marek Olšák
Except for the workaround in patch 1, this series looks good to me. Marek On Mon, Aug 24, 2015 at 2:24 AM, Grazvydas Ignotas nota...@gmail.com wrote: Now that R600_NUM_ATOMS is below 64, dirty atom tracking can be simplified. --- src/gallium/drivers/r600/r600_pipe.h | 41

Re: [Mesa-dev] [PATCH] nv50: avoid using inline vertex data submit when gl_VertexID is used

2015-08-24 Thread Samuel Pitoiset
Reviewed-by: Samuel Pitoiset samuel.pitoi...@gmail.com This fix is simpler than I was expected. What about the edge flag stuff now? :) On 08/24/2015 05:51 PM, Ilia Mirkin wrote: The hardware only generates vertexid when vertices come from a VBO. This fixes: vertexid-drawelements

Re: [Mesa-dev] [PATCH 3/9] st/mesa: tweak surface format mapping table

2015-08-24 Thread Ilia Mirkin
Not that I really care, but... why flip the order of bgra vs rgba? Also, do the ARB_texture_view piglits still pass? They're really sensitive to the relative consistency of this stuff. Note that this will really only affect glTexStorage since glTexImage is likely to hit the exact_format_*

Re: [Mesa-dev] [PATCH 08/21] nir/intrinsics: Add a second const index to load_uniform

2015-08-24 Thread Kenneth Graunke
On Wednesday, August 19, 2015 10:45:43 PM Jason Ekstrand wrote: In the i965 backend, we want to be able to pull apart the uniforms and push some of them into the shader through a different path. In order to do this effectively, we need to know which variable is actually being referred to by a

[Mesa-dev] [PATCH] prog_to_nir: Don't allocate nir_variable with type vec4[0] for uniforms.

2015-08-24 Thread Kenneth Graunke
If there are no parameters, we don't need to create a nir_variable to hold them...and allocating an array of length 0 is pretty bogus. Should avoid i965 backend assertions in future patches Jason and I are working on. Signed-off-by: Kenneth Graunke kenn...@whitecape.org ---

Re: [Mesa-dev] [PATCH 09/21] nir/lower_io: Separate driver_location and base offset for uniforms

2015-08-24 Thread Kenneth Graunke
On Monday, August 24, 2015 04:14:13 PM Jason Ekstrand wrote: On Mon, Aug 24, 2015 at 4:03 PM, Kenneth Graunke kenn...@whitecape.org wrote: On Wednesday, August 19, 2015 10:45:44 PM Jason Ekstrand wrote: v2 (Jason Ekstrand): Fix up image uniforms --- src/glsl/nir/nir_lower_io.c

Re: [Mesa-dev] [PATCH 7/8] i965/vs: Map scalar VS input locations properly; avoid tons of MOVs.

2015-08-24 Thread Kenneth Graunke
On Monday, August 17, 2015 09:48:13 PM Jason Ekstrand wrote: On Aug 17, 2015 4:08 PM, Kenneth Graunke kenn...@whitecape.org wrote: Previously, we used nir_lower_io with the scalar type_size function, which mapped VERT_ATTRIB_* locations to...some numbers. Then, in

Re: [Mesa-dev] [PATCH v3] mesa/formats: refactor by removing compressed formats

2015-08-24 Thread Nanley Chery
Thanks for pointing out these errors. I'll fix them in the next version. On Fri, Aug 21, 2015 at 2:34 PM, Chad Versace chad.vers...@intel.com wrote: On Wed 19 Aug 2015, Nanley Chery wrote: From: Nanley Chery nanley.g.ch...@intel.com All compressed formats return GL_FALSE and there isn't

[Mesa-dev] [PATCH v4] mesa/formats: remove compressed formats from matching function

2015-08-24 Thread Nanley Chery
From: Nanley Chery nanley.g.ch...@intel.com All compressed formats return GL_FALSE and there isn't any evidence to support that this behaviour would change. Remove all switch cases for compressed formats. v2. Since the exhaustive switch is removed, add a gtest to ensure all formats are

[Mesa-dev] [PATCH v2] mesa/formats: make format testing a gtest

2015-08-24 Thread Nanley Chery
From: Nanley Chery nanley.g.ch...@intel.com We currently check that our format info table is sane during context initialization in debug builds. Perform this check during `make check` instead. This enables format testing in release builds and removes the requirement of an exhuastive switch for

Re: [Mesa-dev] [PATCH 3/9] st/mesa: tweak surface format mapping table

2015-08-24 Thread Brian Paul
On 08/24/2015 04:34 PM, Ilia Mirkin wrote: On Mon, Aug 24, 2015 at 4:54 PM, Brian Paul bri...@vmware.com wrote: Also, do the ARB_texture_view piglits still pass? They're really sensitive to the relative consistency of this stuff. Hmm, one regression in arb_texture_view-lifetime-format on

Re: [Mesa-dev] [PATCH 09/21] nir/lower_io: Separate driver_location and base offset for uniforms

2015-08-24 Thread Jason Ekstrand
On Mon, Aug 24, 2015 at 4:03 PM, Kenneth Graunke kenn...@whitecape.org wrote: On Wednesday, August 19, 2015 10:45:44 PM Jason Ekstrand wrote: v2 (Jason Ekstrand): Fix up image uniforms --- src/glsl/nir/nir_lower_io.c | 9 +++-- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 13

  1   2   >