Re: [Mesa-dev] [PATCH demos] egl: Remove demos using EGL_MESA_screen_surface.

2015-09-01 18:55 GMT+02:00 Matt Turner : > On Tue, Sep 1, 2015 at 9:42 AM, Andreas Boll > wrote: >> Hi Matt, >> >> 2015-08-29 1:09 GMT+02:00 Matt Turner : >>> The remnants of the extension were removed from Mesa in commit

Re: [Mesa-dev] [RFC] Fix for clang compiler issue as reported in Bug 91826

On Tue, Sep 1, 2015 at 10:10 AM, Albert Freeman wrote: > Clang tryed to declare the non type member of struct module (enum type type) > (in clover/core/module.hpp) instead of a variable of type enum (enum type). > > Signed-off-by: Albert Freeman

Re: [Mesa-dev] [PATCH] r600g: Simplify out a couple of unnecessary branches

Please stop using a non-existent email address. alterapraxis.com doesn't exist. Marek On Tue, Sep 1, 2015 at 10:38 AM, Edward O'Callaghan wrote: > From: Edward O'Callaghan > > Signed-off-by: Edward O'Callaghan

Re: [Mesa-dev] [PATCH] mesa/pbo: Handle zero height or depth when validating PBO access

On Tue, Sep 1, 2015 at 1:40 PM, Neil Roberts wrote: > It's legal to call glTexSubImage with zero values for the width, > height or depth. Previously this was breaking the PBO access > validation because it tries to work out the last pixel accessed by > getting the pixel at

Re: [Mesa-dev] [PATCH 0/8] nouveau: add support for vaapi

On Tue, Sep 1, 2015 at 4:58 AM, Julien Isorce wrote: > Hi, > > Thx for the comments. I forgot to mention that there is nothing really new > in these patches. > All the low level code relative to nouveau was already there. > The patches are almost "just" moving code in

Re: [Mesa-dev] [PATCH] i965: Don't check for draw-time errors that cannot occur in core profile

Ilia Mirkin writes: > On Tue, Sep 1, 2015 at 12:15 PM, Ian Romanick wrote: >> For a bunch of the small changes, I don't care too much what the >> difference is. I just want to know whether after is better than before. > > And that gets back to my

Re: [Mesa-dev] [PATCH 00/12] bmake inspired fixes

On Tue, Sep 1, 2015 at 6:41 AM, Emil Velikov wrote: > If you'd like some objective justification why these patches make > things better, please give me some merits that I can check against. As I've stated... quite a few times now, I don't like that the series removes

Re: [Mesa-dev] [PATCH 12/12] auxiliary: fix the generated sources rules

On 07/17/2015 10:29 AM, Emil Velikov wrote: > Signed-off-by: Emil Velikov > --- > src/gallium/auxiliary/Makefile.am | 29 + > 1 file changed, 17 insertions(+), 12 deletions(-) > > diff --git a/src/gallium/auxiliary/Makefile.am >

[Mesa-dev] [PATCH 3/3] winsys/radeon: remove exported buffers from the cache

From: Marek Olšák Cc: 11.0 --- src/gallium/winsys/radeon/drm/radeon_drm_bo.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/winsys/radeon/drm/radeon_drm_bo.c b/src/gallium/winsys/radeon/drm/radeon_drm_bo.c index

[Mesa-dev] [PATCH 1/3] gallium/pb_bufmgr_cache: add a way to remove buffers from the cache explicitly

From: Marek Olšák This must be done before exporting a buffer as dmabuf fds, because we lose track of who is using it and can't trust the reference counter. Cc: 11.0 --- src/gallium/auxiliary/pipebuffer/pb_bufmgr.h | 5 +++

Re: [Mesa-dev] [PATCH] mesa/pbo: Handle zero height or depth when validating PBO access

On Tue, Sep 01, 2015 at 06:40:39PM +0100, Neil Roberts wrote: > It's legal to call glTexSubImage with zero values for the width, > height or depth. Previously this was breaking the PBO access > validation because it tries to work out the last pixel accessed by > getting the pixel at height-1 and

Re: [Mesa-dev] [PATCH] r600g: Simplify out a couple of unnecessary branches

Pushed, thanks. Marek On Tue, Sep 1, 2015 at 10:38 AM, Edward O'Callaghan wrote: > From: Edward O'Callaghan > > Signed-off-by: Edward O'Callaghan > --- > src/gallium/drivers/r600/r600_shader.c | 8

Re: [Mesa-dev] [PATCH] i965/vec4: fill src_reg type using the constructor type parameter

On Tue, Sep 1, 2015 at 8:02 AM, Alejandro Piñeiro wrote: > The src_reg constructor that received the glsl_type was using it > only to build the swizzle, but not to fill this->type as dst_reg > is doing. > > This caused some type mismatch between movs and alu operations > on

[Mesa-dev] [Bug 91840] Expose GL_KHR_debug to ES contexts

https://bugs.freedesktop.org/show_bug.cgi?id=91840 Jose Fonseca changed: What|Removed |Added CC||jfons...@vmware.com

Re: [Mesa-dev] [PATCH 6/6] mesa/formats: 8-bit channel integer formats addition

For 5&6, I didn't check every tiny detail, but looks good to me. Reviewed-by: Brian Paul On 08/25/2015 07:14 PM, Dave Airlie wrote: From: Dave Airlie Add enough 8-bit channel formats to handle all the different things CTS throws at us. Signed-off-by:

Re: [Mesa-dev] [PATCH] glapi: Inline x86_64_current_tls().

I looked at the change that added this (97185bf2), and there was no explanation why it was done this way... and the rest of the MAPI_MODE_BRIDGE stuff seems fairly nuts. This change, however, seems reasonable. Reviewed-by: Ian Romanick On 08/28/2015 11:47 AM, Matt

[Mesa-dev] [PATCH] mesa/pbo: Handle zero height or depth when validating PBO access

It's legal to call glTexSubImage with zero values for the width, height or depth. Previously this was breaking the PBO access validation because it tries to work out the last pixel accessed by getting the pixel at height-1 and depth-1 which would end up with bogus values. This was causing GL

Re: [Mesa-dev] [RFC] Fix for clang compiler issue as reported in Bug 91826

Matt Turner writes: > On Tue, Sep 1, 2015 at 10:10 AM, Albert Freeman > wrote: >> Clang tryed to declare the non type member of struct module (enum type type) >> (in clover/core/module.hpp) instead of a variable of type enum (enum type). >> >>

[Mesa-dev] [PATCH 2/3] winsys/amdgpu: remove exported buffers from the cache

From: Marek Olšák Cc: 11.0 --- src/gallium/winsys/amdgpu/drm/amdgpu_bo.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_bo.c b/src/gallium/winsys/amdgpu/drm/amdgpu_bo.c index 50c42e3..fe55dc3

Re: [Mesa-dev] [PATCH] i965: Don't check for draw-time errors that cannot occur in core profile

On Tue, Sep 1, 2015 at 3:45 PM, Eirik Byrkjeflot Anonsen wrote: > Ilia Mirkin writes: > >> On Tue, Sep 1, 2015 at 12:15 PM, Ian Romanick wrote: >>> For a bunch of the small changes, I don't care too much what the >>> difference is.

Re: [Mesa-dev] [PATCH] i965: Don't check for draw-time errors that cannot occur in core profile

On Tue, Sep 1, 2015 at 1:48 AM, Eirik Byrkjeflot Anonsen wrote: > Ian Romanick writes: > >> ping. :) >> >> On 08/10/2015 11:48 AM, Matt Turner wrote: >>> On Mon, Aug 10, 2015 at 10:12 AM, Ian Romanick wrote: From: Ian Romanick

[Mesa-dev] [PATCH 2/3] texcompress_s3tc: fix stride checks

From: Dave Airlie The fastpath currently checks the stride != width, but if you have a RowLength of 7, and Alignment of 4, then that shuoldn't match. align the rowlength to the pack alignment before comparing. This fixes compressed cases in CTS packed_pixels_pixelstore test

[Mesa-dev] [Bug 91826] Mesa 11.0.0-rc2 - state_trackers/clover does not build on FreeBSD

https://bugs.freedesktop.org/show_bug.cgi?id=91826 --- Comment #3 from Albert Freeman --- Well changing typename to enum seems to fix the problem: diff --git a/src/gallium/state_trackers/clover/llvm/invocation.cpp

Re: [Mesa-dev] [PATCH] i965: Don't check for draw-time errors that cannot occur in core profile

Ilia Mirkin writes: > On Tue, Sep 1, 2015 at 1:48 AM, Eirik Byrkjeflot Anonsen > wrote: >> Ian Romanick writes: >> >>> ping. :) >>> >>> On 08/10/2015 11:48 AM, Matt Turner wrote: On Mon, Aug 10, 2015 at 10:12 AM, Ian Romanick

Re: [Mesa-dev] [PATCH] i965: Don't check for draw-time errors that cannot occur in core profile

Ian Romanick writes: > ping. :) > > On 08/10/2015 11:48 AM, Matt Turner wrote: >> On Mon, Aug 10, 2015 at 10:12 AM, Ian Romanick wrote: >>> From: Ian Romanick >>> >>> On many CPU-limited applications, this is *the* hot path.

[Mesa-dev] [PATCH 1/3] st/readpixels: fix accel path for skipimages.

From: Dave Airlie We don't need to use the 3d image address here as that will include SKIP_IMAGES, and we are only blitting a single 2D anyways, so just use the 2D path. This fixes some memory overruns under CTS packed_pixels.packed_pixels_pixelstore when PACK_SKIP_IMAGES

[Mesa-dev] [PATCH 3/3] mesa/readpixels: check strides are equal before skipping conversion

From: Dave Airlie The CTS packed_pixels test checks that readpixels doesn't write into the space between rows, however we fail that here unless we check the format and stride match. This fixes all the core mesa problems with CTS packed_pixels tests. Signed-off-by: Dave

[Mesa-dev] [Bug 91826] Mesa 11.0.0-rc2 - state_trackers/clover does not build on FreeBSD

https://bugs.freedesktop.org/show_bug.cgi?id=91826 --- Comment #4 from Albert Freeman --- You should probably report this to the clang developers too. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.

[Mesa-dev] [RFC] Fix for clang compiler issue as reported in Bug 91826

Clang tryed to declare the non type member of struct module (enum type type) (in clover/core/module.hpp) instead of a variable of type enum (enum type). Signed-off-by: Albert Freeman --- src/gallium/state_trackers/clover/llvm/invocation.cpp | 2 +- 1 file changed, 1

Re: [Mesa-dev] [PATCH] Revert "i965: Stop aux data compare preventing program binary re-use"

On Fri, Aug 28, 2015 at 09:34:12AM -0700, Ben Widawsky wrote: > On Fri, Aug 28, 2015 at 10:15:30AM +0300, Pohjolainen, Topi wrote: > > On Fri, Aug 28, 2015 at 09:56:43AM +0300, Pohjolainen, Topi wrote: > > > On Thu, Aug 27, 2015 at 10:05:14AM -0700, Ben Widawsky wrote: > > > > On Thu, Aug 27, 2015

Re: [Mesa-dev] [PATCH] mesa/api: validate buffers are unmapped

On Tue, Sep 1, 2015 at 7:50 PM, Dave Airlie wrote: > On 2 September 2015 at 09:42, Ilia Mirkin wrote: >> On Tue, Sep 1, 2015 at 7:39 PM, Dave Airlie wrote: >>> From: Dave Airlie >>> >>> GL 3.2 introduced new

Re: [Mesa-dev] [PATCH 2/2] Revert "glsl: check total count of multi-slot double vertex attribs"

On 2 September 2015 at 08:57, Matt Turner wrote: > This reverts commit ad208d975a6d3aebe14f7c2c16039ee200d8b30c. > > This code attempted to ensure that we didn't use more than the maximum > number of attribute slots, but it did not consider attribute aliasing so > it would

Re: [Mesa-dev] [PATCH 1/2] glsl: Properly count doubles as taking twice the number of attrib slots.

On 2 September 2015 at 08:57, Matt Turner wrote: > --- > I checked the uses of count_attribute_slots() and it looks like they're > expecting this already, but these two patches definitely need testing on > a driver that supports fp64. > Don't think so, As Ilia said they can

[Mesa-dev] [PATCH] mesa/api: validate buffers are unmapped

From: Dave Airlie GL 3.2 introduced new language in this area, and CTS enforces it, this patches checks all the vertex buffers and the index buffer are mapped in the core profile case. I'm not sure what GLES expects here. This fixes

[Mesa-dev] [PATCH 1/2] dri/common: embed drirc into driver binaries

From: Marek Olšák People are having issues with apps because drirc wasn't installed into /etc. I've lost patience. --- src/mesa/drivers/dri/common/Makefile.am | 4 +- src/mesa/drivers/dri/common/Makefile.sources | 3 +- src/mesa/drivers/dri/common/drirc

[Mesa-dev] [PATCH 2/2] dri/common: drop loading /etc/drirc

From: Marek Olšák A user can be using Mesa 11.0, but /etc/drirc can be from Mesa 10.5. We don't want the old drirc to affect Mesa 11.0. There are 2 options: - use a different file name (e.g. /etc/drirc_global) for people wanting a global drirc file, but they must supply

[Mesa-dev] [PATCH 13/17 v2] glsl: Silence unused parameter warnings

From: Ian Romanick builtin_variables.cpp:1062:53: warning: unused parameter 'name_as_gs_input' [-Wunused-parameter] const char *name_as_gs_input) ^

[Mesa-dev] [Bug 91747] Ubuntu 15.04/Oibaf PPA - Unity bar not transparent

https://bugs.freedesktop.org/show_bug.cgi?id=91747 --- Comment #3 from Brian Paul --- Thanks to Sinclair Yeh's detective work, it appears that the unity shell is disabling transparency when it finds "LLVM" in the GL_RENDERER string. We've seen the same issue here with our

[Mesa-dev] [Bug 91840] Expose GL_KHR_debug to ES contexts

https://bugs.freedesktop.org/show_bug.cgi?id=91840 --- Comment #2 from Timothy Arceri --- There are patches on the list not sure if they still apply: http://lists.freedesktop.org/archives/mesa-dev/2014-August/066941.html The piglit tests have already been updated to

Re: [Mesa-dev] [PATCH] mesa/api: validate buffers are unmapped

On 2 September 2015 at 09:58, Brian Paul wrote: > On 09/01/2015 05:39 PM, Dave Airlie wrote: >> >> From: Dave Airlie >> >> GL 3.2 introduced new language in this area, and CTS enforces it, >> this patches checks all the vertex buffers and the index buffer

Re: [Mesa-dev] [PATCH V3] glsl: fix atomic buffer index for bindings other than 0

On Tue, 2015-09-01 at 14:46 +0100, Emil Velikov wrote: > On 29 July 2015 at 13:46, Timothy Arceri wrote: > > On Wed, 2015-07-29 at 09:57 +0200, Iago Toral wrote: > > > On Sun, 2015-07-26 at 18:35 +1000, Timothy Arceri wrote: > > > > Since commit c0cd5b var->data.binding was

Re: [Mesa-dev] [PATCH] mesa/api: validate buffers are unmapped

On Tue, Sep 1, 2015 at 7:39 PM, Dave Airlie wrote: > From: Dave Airlie > > GL 3.2 introduced new language in this area, and CTS enforces it, > this patches checks all the vertex buffers and the index buffer > are mapped in the core profile case. I'm not

Re: [Mesa-dev] [PATCH] mesa/api: validate buffers are unmapped

On 09/01/2015 05:39 PM, Dave Airlie wrote: From: Dave Airlie GL 3.2 introduced new language in this area, and CTS enforces it, this patches checks all the vertex buffers and the index buffer are mapped in the core profile case. I'm not sure what GLES s/mapped/unmapped/ ?

[Mesa-dev] [PATCH V3 5/6] nir: support indirect indexing samplers in struct arrays

As a bonus we get indirect support for arrays of arrays for free. V3: Use nir_instr_rewrite_src() with empty src rather then clearing the use_link list directly for the old indirects as suggested by Jason V2: Fixed validation error in debug build --- src/glsl/nir/nir_lower_samplers.cpp | 169

[Mesa-dev] [PATCH V3 2/6] glsl: assign hidden uniforms their slot id earlier

This is required so that the next patch can safely assign the slot id to the var. The ids are now assigned in the order we want before allocating storage so there is no need to sort the storage array and move things around. --- src/glsl/link_uniforms.cpp | 90

[Mesa-dev] [PATCH V3 1/6] glsl: order indices for samplers inside a struct array

This allows the correct offset to be easily calculated for indirect indexing when a struct array contains multiple samplers, or any crazy nesting. The indices for the folling struct will now look like this: Sampler index: 0 Name: s[0].tex Sampler index: 1 Name: s[1].tex Sampler index: 2 Name:

[Mesa-dev] [PATCH V3 4/6] glsl: make variables private

--- src/glsl/link_uniforms.cpp | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/src/glsl/link_uniforms.cpp b/src/glsl/link_uniforms.cpp index f68ea9d..c28ac52 100644 --- a/src/glsl/link_uniforms.cpp +++ b/src/glsl/link_uniforms.cpp @@ -805,6 +805,17 @@

[Mesa-dev] [PATCH V3 6/6] mesa: simplify sampler indexing

Removes another dependency on the UniformHash hash table. --- src/mesa/program/sampler.cpp | 123 +++ 1 file changed, 53 insertions(+), 70 deletions(-) diff --git a/src/mesa/program/sampler.cpp b/src/mesa/program/sampler.cpp index ea3024d..01150fa 100644

[Mesa-dev] [PATCH V3 3/6] glsl: store uniform slot id in var location field

This will allow us to access the uniform later on without resorting to building a name string and looking it up in UniformHash. V2: store slot number for all non-UBO uniforms to make code more consitent, renamed explicit_binding to explicit_location and added comment about what it does. Store the

[Mesa-dev] Indirect fixes for Samplers v3

The following patch series fixes the indirect sampler indexing piglit tests /tests/spec/arb_gpu_shader5/execution/sampler_array_indexing/* for nir. It also takes steps toward removing the use of the UniformHash table. There are no piglit regressions and I've also sent a couple more meaner

Re: [Mesa-dev] [PATCH] mesa/api: validate buffers are unmapped

On 2 September 2015 at 09:42, Ilia Mirkin wrote: > On Tue, Sep 1, 2015 at 7:39 PM, Dave Airlie wrote: >> From: Dave Airlie >> >> GL 3.2 introduced new language in this area, and CTS enforces it, >> this patches checks all the vertex

Re: [Mesa-dev] [PATCH 1/2] dri/common: embed drirc into driver binaries

I was actually going to suggest loading from the sysconfig dir instead of /etc a while back, but this works for me too. I haven't looked over the details, but the idea of this series is Acked-by: Ilia Mirkin On Tue, Sep 1, 2015 at 8:26 PM, Marek Olšák

[Mesa-dev] [PATCH] gallium: remove support for predicates from TGSI

From: Marek Olšák Neved used. --- Take 2. Let's see how people feel about TGSI now. src/gallium/auxiliary/gallivm/lp_bld_limits.h | 4 - src/gallium/auxiliary/gallivm/lp_bld_tgsi.h| 2 - src/gallium/auxiliary/gallivm/lp_bld_tgsi_aos.c| 46 ---

Re: [Mesa-dev] [PATCH 12/12] auxiliary: fix the generated sources rules

Hi Ian, On 1 September 2015 at 19:30, Ian Romanick wrote: > On 07/17/2015 10:29 AM, Emil Velikov wrote: >> Signed-off-by: Emil Velikov >> --- >> src/gallium/auxiliary/Makefile.am | 29 + >> 1 file changed, 17

Re: [Mesa-dev] [PATCH] gallium: remove support for predicates from TGSI

I'm all for TGIS simplification, but I just checked, and we rely on TGSI predicates for some of our internal state trackers. So I'll need more time to evaluate how much effort it would be to not rely on it, and when can it be done. Jose On 01/09/15 22:19, Marek Olšák wrote: From: Marek

Re: [Mesa-dev] [PATCH 1/2] glsl: Properly count doubles as taking twice the number of attrib slots.

On Tue, Sep 1, 2015 at 6:53 PM, Matt Turner wrote: > On Tue, Sep 1, 2015 at 3:57 PM, Matt Turner wrote: >> --- >> I checked the uses of count_attribute_slots() and it looks like they're >> expecting this already, but these two patches definitely need

[Mesa-dev] [PATCH] radeonsi: only use new versions of LLVM image and sample intrinsics

From: Marek Olšák Just a cleanup I had made a long time ago and forgot about. --- src/gallium/drivers/radeonsi/si_shader.c | 468 +-- 1 file changed, 191 insertions(+), 277 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c

Re: [Mesa-dev] [PATCH] gallium: remove support for predicates from TGSI

Hi, There is predication in direct3D9 HLSL, however we don't implement them and never had any complaint about that. Reason is that HLSL Microsoft compiler doesn't generate any predication. I read somewhere they did this choice because for drivers it is possible to lower efficiently if

[Mesa-dev] [Bug 91840] Expose GL_KHR_debug to ES contexts

https://bugs.freedesktop.org/show_bug.cgi?id=91840 --- Comment #1 from Ian Romanick --- I think the main effort would be in creating piglit tests. Someone would also need to run the Khronos conformance tests. Either I or someone at Intel should be able to do that once

Re: [Mesa-dev] [PATCH] mesa/pbo: Handle zero height or depth when validating PBO access

On 09/01/2015 11:17 AM, Chris Wilson wrote: > On Tue, Sep 01, 2015 at 06:40:39PM +0100, Neil Roberts wrote: >> It's legal to call glTexSubImage with zero values for the width, >> height or depth. Previously this was breaking the PBO access >> validation because it tries to work out the last pixel

[Mesa-dev] [PATCH 2/2] Revert "glsl: check total count of multi-slot double vertex attribs"

This reverts commit ad208d975a6d3aebe14f7c2c16039ee200d8b30c. This code attempted to ensure that we didn't use more than the maximum number of attribute slots, but it did not consider attribute aliasing so it would miscount slots used by aliased attributes and incorrectly reject valid shaders.

[Mesa-dev] [PATCH 1/2] glsl: Properly count doubles as taking twice the number of attrib slots.

--- I checked the uses of count_attribute_slots() and it looks like they're expecting this already, but these two patches definitely need testing on a driver that supports fp64. src/glsl/glsl_types.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/glsl/glsl_types.cpp

Re: [Mesa-dev] [RFC] Fix for clang compiler issue as reported in Bug 91826

On Tuesday 01 September 2015 17:10:33 Albert Freeman wrote: > Clang tryed to declare the non type member of struct module (enum type type) > (in clover/core/module.hpp) instead of a variable of type enum (enum type). > > Signed-off-by: Albert Freeman Reviewed by Serge

Re: [Mesa-dev] texstore byteswap allocation bug

Hey, On Tue, 2015-08-18 at 12:52 +1000, Dave Airlie wrote: > Hey, > > while running CTS under valgrind I got to see a lot of > > ==32256== Invalid read of size 2 > ==32256==at 0x5B53F07: convert_ushort (format_utils.c:1155) > ==32256==by 0x5B8523A: _mesa_swizzle_and_convert

[Mesa-dev] [PATCH] nir: UBO loads no longer use const_index[1]

Commit 2126c68e5cba killed the array elements parameter on load/store intrinsics that was stored in const_index[1]. It looks like that patch missed to remove this assignment in the UBO path. --- src/glsl/nir/glsl_to_nir.cpp | 1 - 1 file changed, 1 deletion(-) diff --git

[Mesa-dev] [Bug 91826] Mesa 11.0.0-rc2 - state_trackers/clover does not build on FreeBSD

https://bugs.freedesktop.org/show_bug.cgi?id=91826 --- Comment #6 from Albert Freeman --- Yeah, I don't know too much about C++11 but it MIGHT be a bug in clang. On 1 September 2015 at 09:30, wrote: > Comment # 5 on bug 91826 from

Re: [Mesa-dev] [PATCH 0/7] NIR dead control flow, take two

On Tuesday, July 21, 2015 09:53:25 PM Connor Abbott wrote: > This is another spin of my dead control flow elimination series, this > time based on the control flow modification series I sent out earlier. > It's much shorter, since it now uses the much-more-reusable modification > API, rather than

[Mesa-dev] [Bug 91826] Mesa 11.0.0-rc2 - state_trackers/clover does not build on FreeBSD

https://bugs.freedesktop.org/show_bug.cgi?id=91826 --- Comment #5 from Koop Mast --- The patch from #3 fixes the build with clang, thanks. Report what to clang upstream, that they error on this issue versus gcc which only gives a warning? -- You are receiving this mail

[Mesa-dev] [Bug 91826] Mesa 11.0.0-rc2 - state_trackers/clover does not build on FreeBSD

https://bugs.freedesktop.org/show_bug.cgi?id=91826 Albert Freeman changed: What|Removed |Added Status|NEW |RESOLVED

[Mesa-dev] [PATCH 1/3] mesa: enable query of PROGRAM_PIPELINE_BINDING for ES 3.1

Specified in OpenGL ES 3.1 spec, Table 23.32: Program Object State. Signed-off-by: Tapani Pälli --- src/mesa/main/get_hash_params.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/get_hash_params.py

[Mesa-dev] [PATCH 2/3] mesa: return initial value for PROGRAM_SEPARABLE when not linked

I haven't found clear spec evidence of this behaviour but this is expected by a conformance test that changes the value with glProgramParameteri but does not link the program. Test says: "The query for PROGRAM_SEPARABLE must query latched state. In other words, the state of the binary after it

[Mesa-dev] [PATCH 3/3] mesa: return initial value for VALIDATE_STATUS if pipe not bound

From OpenGL 4.5 Core spec (7.13): "If pipeline is a name that has been generated (without subsequent deletion) by GenProgramPipelines, but refers to a program pipeline object that has not been previously bound, the GL first creates a new state vector in the same manner as when

[Mesa-dev] [PATCH] r600g: Simplify out a couple of unnecessary branches

From: Edward O'Callaghan Signed-off-by: Edward O'Callaghan --- src/gallium/drivers/r600/r600_shader.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/r600/r600_shader.c

Re: [Mesa-dev] [PATCH 0/8] nouveau: add support for vaapi

Hi, Thx for the comments. I forgot to mention that there is nothing really new in these patches. All the low level code relative to nouveau was already there. The patches are almost "just" moving code in order to call nouveau_vp3_bsp and nvc0_decoder_bsp multiple times between each begin/end

[Mesa-dev] [Bug 91130] Mesa's cl.h defines CL_VERSION_1_2 even though it is missing some OpenCL 1.2 functions

https://bugs.freedesktop.org/show_bug.cgi?id=91130 Serge Martin changed: What|Removed |Added Status|NEW |RESOLVED

Re: [Mesa-dev] [PATCH] meta: Compute correct buffer size with SkipRows/SkipPixels

On Mon, Aug 31, 2015 at 10:29:51PM -0700, Jason Ekstrand wrote: >On Aug 31, 2015 6:48 AM, "Chris Wilson" <[1]ch...@chris-wilson.co.uk> >wrote: >> >> From: Jason Ekstrand <[2]jason.ekstr...@intel.com> >> >> If the user is specifying a subregion of a buffer using SKIP_ROWS

Re: [Mesa-dev] texstore byteswap allocation bug

On Tue, 2015-09-01 at 12:34 +0200, Iago Toral wrote: > Hey, > > On Tue, 2015-08-18 at 12:52 +1000, Dave Airlie wrote: > > Hey, > > > > while running CTS under valgrind I got to see a lot of > > > > ==32256== Invalid read of size 2 > > ==32256==at 0x5B53F07: convert_ushort

Re: [Mesa-dev] texstore byteswap allocation bug

On 1 September 2015 at 20:34, Iago Toral wrote: > Hey, > > On Tue, 2015-08-18 at 12:52 +1000, Dave Airlie wrote: >> Hey, >> >> while running CTS under valgrind I got to see a lot of >> >> ==32256== Invalid read of size 2 >> ==32256==at 0x5B53F07: convert_ushort

Re: [Mesa-dev] [PATCH] meta: Compute correct buffer size with SkipRows/SkipPixels

On Tue, Sep 01, 2015 at 01:09:33PM +0100, Neil Roberts wrote: > Good catch and it seems like a nice way to fix it. > > Reviewed-by: Neil Roberts > > I wonder if it might be worth avoiding copying the padding and pack the > rows more tightly in the temporary buffer. Ie, we

Re: [Mesa-dev] [PATCH] meta: Compute correct buffer size with SkipRows/SkipPixels

Good catch and it seems like a nice way to fix it. Reviewed-by: Neil Roberts I wonder if it might be worth avoiding copying the padding and pack the rows more tightly in the temporary buffer. Ie, we would allocate a buffer of align(width*cpp)*height*depth and copy the rows

Re: [Mesa-dev] No VAAPI driver hardlinks?

On 31 August 2015 at 13:32, Emil Velikov wrote: > On 30 August 2015 at 00:21, Matt Turner wrote: >> Hi Emil, >> >> src/gallium/targets/vdpau has a block that installs per-driver >> hardlinks, but src/gallium/targets/va does not (presumably because it

Re: [Mesa-dev] [PATCH] mesa: change 'SHADER_SUBST' facility to work with env variables

On 09/01/2015 04:40 PM, Brian Paul wrote: On 09/01/2015 06:04 AM, Tapani Pälli wrote: On 08/31/2015 05:56 PM, Brian Paul wrote: Looks good. Just some minor nitpicks below. Reviewed-by: Brian Paul Thanks! I have one comment below .. On 08/31/2015 01:23 AM, Tapani

Re: [Mesa-dev] [PATCH] i965: Don't check for draw-time errors that cannot occur in core profile

On Tue, Sep 1, 2015 at 12:15 PM, Ian Romanick wrote: > For a bunch of the small changes, I don't care too much what the > difference is. I just want to know whether after is better than before. And that gets back to my comment that you can't *measure* the impact of a

Re: [Mesa-dev] [PATCH v2] meta: Compute correct buffer size with SkipRows/SkipPixels

Looks good to me. Chris Wilson writes: > @@ -324,10 +340,9 @@ _mesa_meta_pbo_GetTexSubImage(struct gl_context *ctx, > GLuint dims, > * property. > */ > image_height = packing->ImageHeight == 0 ? height : packing->ImageHeight; > - full_height =

Re: [Mesa-dev] [PATCH demos] egl: Remove demos using EGL_MESA_screen_surface.

Hi Matt, 2015-08-29 1:09 GMT+02:00 Matt Turner : > The remnants of the extension were removed from Mesa in commit 7a58262e. > > Bugzilla: https://bugs.gentoo.org/show_bug.cgi?id=555186 > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91020 > Bugzilla:

Re: [Mesa-dev] [PATCH] st/dri: Use packed RGB formats

On Mon, Aug 10, 2015 at 5:44 AM, Michel Dänzer wrote: > From: Michel Dänzer > > Fixes Gallium based DRI drivers failing to load on big endian hosts > because they can't find any matching fbconfigs. > > Bugzilla:

Re: [Mesa-dev] [PATCH v2] meta: Compute correct buffer size with SkipRows/SkipPixels

On Tue, Sep 01, 2015 at 05:44:30PM +0100, Neil Roberts wrote: > Looks good to me. > > Chris Wilson writes: > > > @@ -324,10 +340,9 @@ _mesa_meta_pbo_GetTexSubImage(struct gl_context *ctx, > > GLuint dims, > > * property. > > */ > > image_height =

Re: [Mesa-dev] [PATCH demos] egl: Remove demos using EGL_MESA_screen_surface.

On Tue, Sep 1, 2015 at 9:42 AM, Andreas Boll wrote: > Hi Matt, > > 2015-08-29 1:09 GMT+02:00 Matt Turner : >> The remnants of the extension were removed from Mesa in commit 7a58262e. >> >> Bugzilla: https://bugs.gentoo.org/show_bug.cgi?id=555186 >>

Re: [Mesa-dev] [PATCH 2/2] mesa: handle SwapBytes in compressed texture get code.

On 08/31/2015 10:50 PM, Dave Airlie wrote: This case just wasn't handled, so add support for it. Signed-off-by: Dave Airlie --- src/mesa/main/texgetimage.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/mesa/main/texgetimage.c

Re: [Mesa-dev] [PATCH 1/2] mesa: fix SwapBytes handling in numerous places

Yeah, this looks better. Just minor nit-picks below. Otherwise, Reviewed-by: Brian Paul On 08/31/2015 10:50 PM, Dave Airlie wrote: From: Dave Airlie In a number of places the SwapBytes handling didn't handle cases with GL_(UN)PACK_ALIGNMENT set and 7

Re: [Mesa-dev] [PATCH 2/3] texcompress_s3tc: fix stride checks

On Tue, 2015-09-01 at 16:41 +1000, Dave Airlie wrote: > From: Dave Airlie > > The fastpath currently checks the stride != width, but Maybe replace stride with RowLength in the line above to make things more clear. > if you have a RowLength of 7, and Alignment of 4, then >

Re: [Mesa-dev] [PATCH] meta: Compute correct buffer size with SkipRows/SkipPixels

On Tue, Sep 1, 2015 at 5:30 AM, Chris Wilson wrote: > On Tue, Sep 01, 2015 at 01:09:33PM +0100, Neil Roberts wrote: >> Good catch and it seems like a nice way to fix it. >> >> Reviewed-by: Neil Roberts >> >> I wonder if it might be worth avoiding

[Mesa-dev] [PATCH] i965/vec4: fill src_reg type using the constructor type parameter

The src_reg constructor that received the glsl_type was using it only to build the swizzle, but not to fill this->type as dst_reg is doing. This caused some type mismatch between movs and alu operations on the NIR path, so copy propagation optimization was not applied to remove unneeded movs if

Re: [Mesa-dev] [PATCH 00/12] bmake inspired fixes

On 21 August 2015 at 19:09, Emil Velikov wrote: > On 03/08/15 19:09, Emil Velikov wrote: >> On 3 August 2015 at 17:17, Matt Turner wrote: >>> On Fri, Jul 17, 2015 at 11:53 AM, Emil Velikov >>> wrote: On 17 July 2015

Re: [Mesa-dev] [Mesa-stable] [PATCH 16/18] i965: Prevent coordinate overflow in intel_emit_linear_blit

On 1 August 2015 at 17:57, Emil Velikov wrote: > Hello all, > > On 20 July 2015 at 18:08, Anuj Phogat wrote: >> On Sat, Jul 18, 2015 at 1:24 AM, Chris Wilson >> wrote: >>> On Fri, Jul 17, 2015 at 05:12:54PM -0700, Anuj

Re: [Mesa-dev] [Mesa-stable] [PATCH] clover: Properly initialize LLVM targets when linking with component libs

On 8 August 2015 at 12:11, Francisco Jerez wrote: > Tom Stellard writes: > >> Calls to LLVMIntialize* fail when we are linking against individual >> component libraries rather than one large shared object, because >> we only include component

Re: [Mesa-dev] [PATCH] i965: Don't tell the hardware about our UAV access.

Francisco Jerez writes: > The hardware documentation relating to the UAV HW-assisted coherency > mechanism and UAV access enable bits is scarce and sometimes > contradictory, and there's quite some guesswork behind this commit, so > let me summarize the background first:

Re: [Mesa-dev] [PATCH] mesa: change 'SHADER_SUBST' facility to work with env variables

On 09/01/2015 06:04 AM, Tapani Pälli wrote: On 08/31/2015 05:56 PM, Brian Paul wrote: Looks good. Just some minor nitpicks below. Reviewed-by: Brian Paul Thanks! I have one comment below .. On 08/31/2015 01:23 AM, Tapani Pälli wrote: Patch modifies existing shader

Re: [Mesa-dev] [PATCH] mesa: Move gl_vert_attrib from mtypes.h to shader_enums.h

On 08/31/2015 03:57 PM, Jason Ekstrand wrote: It is a shader enum after all... --- src/glsl/shader_enums.h | 108 src/mesa/main/mtypes.h | 107 --- 2 files changed, 108 insertions(+), 107

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/2] clover: Use threadsafe wrappers for pipe_context v2

Hi guys On 11 July 2015 at 11:47, Francisco Jerez wrote: > Tom Stellard writes: > >> Events can be added to an OpenCL command queue concurrently from multiple >> threads, but pipe_context bjects are not threadsafe. The threadsafe >> wrappers

  1   2   >