Re: [Mesa-dev] [RFC] nir/opt_peephole_ffma: Bypass fusion if any operand of fadd and fmul is a const

On Sep 18, 2015 2:49 AM, "Eduardo Lima Mitev" wrote: > > When both fadd and fmul instructions have at least one operand that is a > constant and it is only used once, the total number of instructions can > be reduced from 3 (1 ffma + 2 load_const) to 2 (1 fmul + 1 fadd); because

[Mesa-dev] [PATCH 2/2] radeonsi: implement TXQS support

Signed-off-by: Ilia Mirkin Tested-by: Fredrik Bruhn --- Fredrik ran the ARB_shader_texture_image_samples tests and they passed. No further testing was done. docs/GL3.txt | 2 +- docs/relnotes/11.1.0.html| 2

[Mesa-dev] [PATCH 1/2] radeonsi: load fmask ptr relative to the resources array

res_ptr already contains the resource values. fmask_ptr needs to be looked up relative to the start of the resource params. Note that this only affects indirect loads of MS sampler arrays. Signed-off-by: Ilia Mirkin --- Untested. src/gallium/drivers/radeonsi/si_shader.c

Re: [Mesa-dev] [PATCH 2/2] radeonsi: implement TXQS support

This series is, Reviewed-by: Edward O'Callaghan -- Edward O'Callaghan edward.ocallag...@koparo.com On Sun, Sep 20, 2015, at 06:26 AM, Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin > Tested-by: Fredrik Bruhn > --- >

Re: [Mesa-dev] [PATCH v3] i965/vec4: Change types as needed to propagate source modifiers using from instruction

On 19/09/15 16:34, Jason Ekstrand wrote: > > > On Sep 18, 2015 10:12 AM, "Alejandro Piñeiro" > wrote: > > > > SEL and MOV instructions, as long as they don't have source > modifiers, are > > just copying bits around. So those kind of

Re: [Mesa-dev] [PATCH 2/2] radeonsi: implement TXQS support

The series is: Reviewed-by: Marek Olšák Marek On Sat, Sep 19, 2015 at 4:26 PM, Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin > Tested-by: Fredrik Bruhn > --- > > Fredrik ran the

Re: [Mesa-dev] [PATCH 3/9] nir: Report progress from lower_vec_to_movs().

On Sep 19, 2015 3:31 PM, "Jason Ekstrand" wrote: > > > On Sep 18, 2015 1:29 PM, "Kenneth Graunke" wrote: > > > > On Friday, September 18, 2015 10:55:34 AM Jason Ekstrand wrote: > > > Um, why? I'm sure you have some reason but I don't immediately see

Re: [Mesa-dev] [PATCH 2/9] nir/lower_vec_to_movs: Add a state struct

Go ahead and squash this in to the patch that adds the boolean return? On Sep 18, 2015 10:37 AM, "Kenneth Graunke" wrote: > From: Jason Ekstrand > > While we're here, we also fix up a couple of potential ralloc-parenting > bugs. In particular, we

Re: [Mesa-dev] [PATCH 9/9] nir: Report progress from nir_normalize_cubemap_coords().

On Sep 18, 2015 10:37 AM, "Kenneth Graunke" wrote: > > This also required adding a struct. > > Signed-off-by: Kenneth Graunke > --- > src/glsl/nir/nir.h | 2 +- > src/glsl/nir/nir_normalize_cubemap_coords.c | 28

[Mesa-dev] [PATCH v2 0/3] clover: implement clCreateImage

Francisco Jerez (1): clover: Move down canonicalization of memory object flags into validate_flags(). Serge Martin (2): clover: implement clCreateImage clover: implement clCreateImage?D w/ clCreateImage src/gallium/state_trackers/clover/api/memory.cpp | 215 +-- 1

[Mesa-dev] [PATCH v2 2/3] clover: implement clCreateImage

--- src/gallium/state_trackers/clover/api/memory.cpp | 101 --- 1 file changed, 91 insertions(+), 10 deletions(-) diff --git a/src/gallium/state_trackers/clover/api/memory.cpp b/src/gallium/state_trackers/clover/api/memory.cpp index 69c3e95..0c2d353 100644 ---

[Mesa-dev] [PATCH v2 1/3] clover: Move down canonicalization of memory object flags into validate_flags().

From: Francisco Jerez This will be used to share the same logic between buffer and image creation. Reviewed-by: Serge Martin --- src/gallium/state_trackers/clover/api/memory.cpp | 80 1 file changed, 41 insertions(+), 39

[Mesa-dev] [PATCH v2 3/3] clover: implement clCreateImage?D w/ clCreateImage

remplace clCreateImage2D and clCreateImage3D implementation with call to clCreateImage --- src/gallium/state_trackers/clover/api/memory.cpp | 60 1 file changed, 8 insertions(+), 52 deletions(-) diff --git a/src/gallium/state_trackers/clover/api/memory.cpp

[Mesa-dev] [PATCH] mesa: fix mipmap generation for immutable, compressed textures

From: Roland Scheidegger If the immutable compressed texture didn't have the full mip pyramid, this didn't work, because it tried to generate mip levels for non-existing levels. _mesa_prepare_mipmap_level() would correctly handle this by returning FALSE if the mip level

Re: [Mesa-dev] [PATCH 3/9] nir: Report progress from lower_vec_to_movs().

On Sep 18, 2015 1:29 PM, "Kenneth Graunke" wrote: > > On Friday, September 18, 2015 10:55:34 AM Jason Ekstrand wrote: > > Um, why? I'm sure you have some reason but I don't immediately see how a > > progress flag from lower_vec_to_movs is useful. Some of the others > >

Re: [Mesa-dev] [PATCH 2/4] mesa/cs: Support GL_DISPATCH_INDIRECT_BUFFER

On Sat, Sep 19, 2015 at 6:50 PM, Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > src/mesa/main/bufferobj.c| 17 + > src/mesa/main/get.c | 4 > src/mesa/main/get_hash_params.py | 1 + >

[Mesa-dev] [Bug 79783] Distorted output in obs-studio where other vendors "work"

https://bugs.freedesktop.org/show_bug.cgi?id=79783 --- Comment #9 from gregory.hain...@gmail.com --- (In reply to Ilia Mirkin from comment #8) > (In reply to gregory.hainaut from comment #5) > > Here the dump of the ASM (TGSI?). (Generated with the hack to disable flat > > optimization) > > TGSI

Re: [Mesa-dev] [PATCH 3/3] nir: rename nir_lower_samplers.c{pp,}

On Fri, Sep 18, 2015 at 10:52:35AM -0700, Jason Ekstrand wrote: > On Sep 18, 2015 12:40 PM, "Emil Velikov" wrote: > > > > Thanks for the review/testing guys. > > > > Just noticed that some typos/strange wording > > > > On 17 September 2015 at 16:25, Emil Velikov

Re: [Mesa-dev] [PATCH 3/3] nir: rename nir_lower_samplers.c{pp,}

Hi Jason, On 18 September 2015 at 18:52, Jason Ekstrand wrote: > > On Sep 18, 2015 12:40 PM, "Emil Velikov" wrote: >> >> Thanks for the review/testing guys. >> >> Just noticed that some typos/strange wording >> >> On 17 September 2015 at 16:25,

[Mesa-dev] [Bug 79783] Distorted output in obs-studio where other vendors "work"

https://bugs.freedesktop.org/show_bug.cgi?id=79783 --- Comment #10 from gregory.hain...@gmail.com --- Extrat of the GL4.5 spec: --- Chapter 7.4.1 With separable program objects, interfaces between shader stages may involve the outputs from one program

Re: [Mesa-dev] [PATCH 3/3] nir: rename nir_lower_samplers.c{pp,}

On Sat, Sep 19, 2015 at 1:28 AM, Jonathan Gray wrote: > On Fri, Sep 18, 2015 at 10:52:35AM -0700, Jason Ekstrand wrote: >> On Sep 18, 2015 12:40 PM, "Emil Velikov" wrote: >> > >> > Thanks for the review/testing guys. >> > >> > Just noticed that some

Re: [Mesa-dev] [PATCH v3] i965/vec4: Change types as needed to propagate source modifiers using from instruction

On Sep 18, 2015 10:12 AM, "Alejandro Piñeiro" wrote: > > SEL and MOV instructions, as long as they don't have source modifiers, are > just copying bits around. So those kind of instruction could be propagated > even if there are type mismatches. This is needed because NIR

[Mesa-dev] [PATCH 2/4] mesa/cs: Support GL_DISPATCH_INDIRECT_BUFFER

Signed-off-by: Jordan Justen --- src/mesa/main/bufferobj.c| 17 + src/mesa/main/get.c | 4 src/mesa/main/get_hash_params.py | 1 + src/mesa/main/mtypes.h | 1 + 4 files changed, 23 insertions(+) diff --git

[Mesa-dev] [PATCH 0/4] arb_compute_shader: Implement indirect dispatch support

git://people.freedesktop.org/~jljusten/mesa cs-indirect-dispatch-v1 http://patchwork.freedesktop.org/bundle/jljusten/cs-indirect-dispatch-v1 These patches allow piglit's arb_compute_shader-indirect-compute to pass. (Note, this is on the list now, and not yet in tree.) To test, I set

[Mesa-dev] [PATCH 3/4] mesa/cs: Implement glDispatchComputeIndirect

Signed-off-by: Jordan Justen --- src/mesa/main/api_validate.c | 64 src/mesa/main/api_validate.h | 4 +++ src/mesa/main/compute.c | 10 +++ src/mesa/main/dd.h | 1 + 4 files changed, 73 insertions(+), 6

[Mesa-dev] [PATCH 1/4] mesa/cs: Add _mesa_validate_DispatchCompute

Move API validation to _mesa_validate_DispatchCompute in api_validate.c. Signed-off-by: Jordan Justen --- src/mesa/main/api_validate.c | 44 src/mesa/main/api_validate.h | 4 src/mesa/main/compute.c | 28

[Mesa-dev] [PATCH 4/4] i965/cs: Implement DispatchComputeIndirect support

Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_compute.c | 57 ++--- src/mesa/drivers/dri/i965/brw_defines.h | 2 ++ src/mesa/drivers/dri/i965/intel_reg.h | 5 +++ 3 files changed, 60 insertions(+), 4 deletions(-) diff

[Mesa-dev] [Bug 79783] Distorted output in obs-studio where other vendors "work"

https://bugs.freedesktop.org/show_bug.cgi?id=79783 --- Comment #11 from gregory.hain...@gmail.com --- I ran some piglit tests with a new patch (see below) to only remove deadcode variable that doesn't have a location. Unfortunately it triggers various regression in piglit. 1/ Test

Re: [Mesa-dev] radeonsi bug in fmask calculation?

You're right. It's a bug. Marek On Fri, Sep 18, 2015 at 6:47 PM, Ilia Mirkin wrote: > Hi Marek, > > You weren't on IRC, and I'll forget if I don't write this down now. > Take a look at the code at: > >