Re: [Mesa-dev] [PATCH V6 10/27] i965: fix atomic buffer index for bindings other than 0

On Tue, Sep 29, 2015 at 2:26 AM, Timothy Arceri wrote: > On Tue, 2015-09-29 at 02:08 -0400, Ilia Mirkin wrote: >> On Tue, Sep 29, 2015 at 2:05 AM, Timothy Arceri < >> t_arc...@yahoo.com.au> wrote: >> > On Tue, 2015-09-29 at 01:05 -0400, Ilia Mirkin wrote: >> > > On Mon, Sep

Re: [Mesa-dev] [PATCH] util: implement strndup for WIN32

On 28/09/15 18:14, Emil Velikov wrote: > Hi Samuel, > > On 28 September 2015 at 15:19, Samuel Iglesias Gonsalvez > wrote: >> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92124 >> Cc: Jose Fonseca >> --- >> >> I tested it on MSVC but not

Re: [Mesa-dev] [PATCH 25/24] glsl: add std140 layout support for AoA

On Thu, 2015-09-24 at 11:31 +0200, Samuel Iglesias Gonsálvez wrote: > > On 24/09/15 02:16, Timothy Arceri wrote: > > On Wed, 2015-09-23 at 13:21 +0200, Samuel Iglesias Gonsálvez wrote: > > > On 22/09/15 15:30, Samuel Iglesias Gonsálvez wrote: > > > > Reviewed-by: Samuel Iglesias Gonsálvez

Re: [Mesa-dev] SSBO's in UniformBlocks list?

Hi ilia, On Tue, 2015-09-29 at 03:53 -0400, Ilia Mirkin wrote: > Hi Samuel, and any other onlookers, > > I was wondering why the decision was made to stick SSBO's onto the > same list as constbufs. Seems like they're entirely separate entities, > no? Perhaps I'm missing something? The reason

[Mesa-dev] [PATCH v2] nir: split SSBO min/max atomic instrinsics into signed/unsigned versions

NIR is typeless so this is the only way to keep track of the type to select the proper atomic to use. v2: - Use imin,imax,umin,umax for the intrinsic names (Connor Abbott) - Change message for unreachable paths (Michael Schellenberger) --- src/glsl/nir/glsl_to_nir.cpp | 22

Re: [Mesa-dev] [PATCH] util: implement strndup for WIN32

On 28/09/15 21:44, Jose Fonseca wrote: > Looks great Samuel. > > Just minor suggestions. > > Either way: > > Reviewed-by: Jose Fonseca > Thanks! > > On 28/09/15 15:19, Samuel Iglesias Gonsalvez wrote: >> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92124 >>

Re: [Mesa-dev] [PATCH 25/24] glsl: add std140 layout support for AoA

On 29/09/15 08:34, Timothy Arceri wrote: > On Thu, 2015-09-24 at 11:31 +0200, Samuel Iglesias Gonsálvez wrote: >> >> On 24/09/15 02:16, Timothy Arceri wrote: >>> On Wed, 2015-09-23 at 13:21 +0200, Samuel Iglesias Gonsálvez wrote: On 22/09/15 15:30, Samuel Iglesias Gonsálvez wrote: >

Re: [Mesa-dev] [PATCH V6 10/27] i965: fix atomic buffer index for bindings other than 0

On Tue, 2015-09-29 at 02:33 -0400, Ilia Mirkin wrote: > On Tue, Sep 29, 2015 at 2:26 AM, Timothy Arceri < > t_arc...@yahoo.com.au> wrote: > > On Tue, 2015-09-29 at 02:08 -0400, Ilia Mirkin wrote: > > > On Tue, Sep 29, 2015 at 2:05 AM, Timothy Arceri < > > > t_arc...@yahoo.com.au> wrote: > > > > On

Re: [Mesa-dev] [PATCH] nir: Don't set dest in SSBO store glsl_to_nir conversion

On 28/09/15 23:47, Jordan Justen wrote: > This matches the function signature created in > lower_ubo_reference_visitor::ssbo_store which has a void return. True! Good catch. Reviewed-by: Samuel Iglesias Gonsálvez Thanks, Sam > > Suggested-by: Jason Ekstrand

Re: [Mesa-dev] [PATCH 2/2] egl/dri2: don't require a context for ClientWaitSync

On 28 September 2015 at 08:10, Marek Olšák wrote: > On Mon, Sep 28, 2015 at 7:20 AM, Albert Freeman > wrote: >> On 28 September 2015 at 14:38, Albert Freeman >> wrote: >>> On 28 September 2015 at 04:12, Emil Velikov

Re: [Mesa-dev] [PATCH V6 10/27] i965: fix atomic buffer index for bindings other than 0

On Tue, Sep 29, 2015 at 3:32 AM, Timothy Arceri wrote: > On Tue, 2015-09-29 at 02:55 -0400, Ilia Mirkin wrote: >> On Tue, Sep 29, 2015 at 2:48 AM, Timothy Arceri < >> t_arc...@yahoo.com.au> wrote: >> > On Tue, 2015-09-29 at 02:33 -0400, Ilia Mirkin wrote: >> > > On Tue, Sep

Re: [Mesa-dev] [PATCH] i965/vec4/nir: add nir_intrinsic_memory_barrier support

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 28/09/15 17:48, Francisco Jerez wrote: > Samuel Iglesias Gonsalvez writes: > >> Fix OpenGL ES 3.1 conformance tests: >> advanced-readWrite-case1-vsfs and advanced-matrix-vsfs. >> >> Signed-off-by: Samuel Iglesias

Re: [Mesa-dev] [PATCH V6 10/27] i965: fix atomic buffer index for bindings other than 0

On Tue, Sep 29, 2015 at 2:05 AM, Timothy Arceri wrote: > On Tue, 2015-09-29 at 01:05 -0400, Ilia Mirkin wrote: >> On Mon, Sep 28, 2015 at 10:42 PM, Timothy Arceri < >> t_arc...@yahoo.com.au> wrote: >> > Since commit c0cd5b var->data.binding was being used as a >> >

Re: [Mesa-dev] [PATCH V6 10/27] i965: fix atomic buffer index for bindings other than 0

On Tue, 2015-09-29 at 02:08 -0400, Ilia Mirkin wrote: > On Tue, Sep 29, 2015 at 2:05 AM, Timothy Arceri < > t_arc...@yahoo.com.au> wrote: > > On Tue, 2015-09-29 at 01:05 -0400, Ilia Mirkin wrote: > > > On Mon, Sep 28, 2015 at 10:42 PM, Timothy Arceri < > > > t_arc...@yahoo.com.au> wrote: > > > >

Re: [Mesa-dev] [PATCH 5/6] glsl: apply shader storage block member rules when adding program resources

On 28/09/15 00:05, Timothy Arceri wrote: > On Fri, 2015-09-25 at 10:24 +0200, Samuel Iglesias Gonsalvez wrote: >> From ARB_program_interface_query: >> >> "For an active shader storage block member declared as an array, an >> entry will be generated only for the first array element, regardless

[Mesa-dev] [PATCH] nir: Use a system value for gl_PrimitiveIDIn.

At least on Intel hardware, gl_PrimitiveIDIn comes in as a special part of the payload rather than a normal input. This is typically what we use system values for. Dave and Ilia also agree that a system value would be nicer. At some point, we should change it at the GLSL IR level as well. But

Re: [Mesa-dev] List of unsupported extensions per driver

FMA isn't required really. R600 is mainly missing GS streams, which are complete on the mailing somewhere I think. Marek On Tue, Sep 29, 2015 at 7:32 AM, Romain Failliot wrote: > Hi! > > I'm diving into the unsupported extensions list and I'm wondering how is it >

Re: [Mesa-dev] [PATCH V6 10/27] i965: fix atomic buffer index for bindings other than 0

On Tue, 2015-09-29 at 01:05 -0400, Ilia Mirkin wrote: > On Mon, Sep 28, 2015 at 10:42 PM, Timothy Arceri < > t_arc...@yahoo.com.au> wrote: > > Since commit c0cd5b var->data.binding was being used as a > > replacement > > for atomic buffer index, but they don't have to be the same value > > they >

Re: [Mesa-dev] [PATCH V6 13/27] glsl: fix whitespace

Reviewed-by: Iago Toral Quiroga On Tue, 2015-09-29 at 12:42 +1000, Timothy Arceri wrote: > --- > src/glsl/ast_to_hir.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp > index a9696dc..2fd4443 100644

Re: [Mesa-dev] [PATCH 2/2] egl/dri2: don't require a context for ClientWaitSync

On 29 September 2015 at 07:25, Albert Freeman wrote: > On 28 September 2015 at 08:10, Marek Olšák wrote: >> On Mon, Sep 28, 2015 at 7:20 AM, Albert Freeman >> wrote: >>> On 28 September 2015 at 14:38, Albert Freeman

[Mesa-dev] SSBO's in UniformBlocks list?

Hi Samuel, and any other onlookers, I was wondering why the decision was made to stick SSBO's onto the same list as constbufs. Seems like they're entirely separate entities, no? Perhaps I'm missing something? Thanks, -ilia ___ mesa-dev mailing list

Re: [Mesa-dev] Pending issues of lollipop-x86

On 28 September 2015 at 20:25, Marek Olšák wrote: > On Mon, Sep 28, 2015 at 10:19 PM, Chad Versace wrote: >> On Fri 25 Sep 2015, Chih-Wei Huang wrote: >>> CC to mesa-dev for help. >>> >>> 2015-09-25 22:12 GMT+08:00 Chih-Wei Huang

Re: [Mesa-dev] [PATCH] nir: split SSBO min/max atomic instrinsics into signed/unsigned versions

Kristian Høgsberg writes: > On Mon, Sep 28, 2015 at 1:59 PM, Ilia Mirkin wrote: >> On Mon, Sep 28, 2015 at 4:55 PM, Kristian Høgsberg >> wrote: >>> On Mon, Sep 28, 2015 at 1:47 AM, Iago Toral Quiroga >>> wrote:

Re: [Mesa-dev] [PATCH V6 10/27] i965: fix atomic buffer index for bindings other than 0

On Tue, Sep 29, 2015 at 2:48 AM, Timothy Arceri wrote: > On Tue, 2015-09-29 at 02:33 -0400, Ilia Mirkin wrote: >> On Tue, Sep 29, 2015 at 2:26 AM, Timothy Arceri < >> t_arc...@yahoo.com.au> wrote: >> > On Tue, 2015-09-29 at 02:08 -0400, Ilia Mirkin wrote: >> > > On Tue, Sep

Re: [Mesa-dev] [PATCH V6 10/27] i965: fix atomic buffer index for bindings other than 0

On Tue, 2015-09-29 at 02:55 -0400, Ilia Mirkin wrote: > On Tue, Sep 29, 2015 at 2:48 AM, Timothy Arceri < > t_arc...@yahoo.com.au> wrote: > > On Tue, 2015-09-29 at 02:33 -0400, Ilia Mirkin wrote: > > > On Tue, Sep 29, 2015 at 2:26 AM, Timothy Arceri < > > > t_arc...@yahoo.com.au> wrote: > > > > On

Re: [Mesa-dev] [PATCH] nir: Use a system value for gl_PrimitiveIDIn.

On Mon, 2015-09-28 at 23:05 -0700, Kenneth Graunke wrote: > At least on Intel hardware, gl_PrimitiveIDIn comes in as a special part > of the payload rather than a normal input. This is typically what we > use system values for. Dave and Ilia also agree that a system value > would be nicer. > >

Re: [Mesa-dev] [PATCH] util: implement strndup for WIN32

I think this implementation will have problems if the string being copied is not null terminated. It's not clear from the man pages whether that is an allowed way to use the function but a quick Google shows up a few similar patches where they have later been fixed by using strnlen. It looks like

[Mesa-dev] [PATCH v2] mesa/meta: Use interpolateAtOffset for 16x MSAA copy blit

Previously there was a problem in i965 where if 16x MSAA is used then some of the sample positions are exactly on the 0 x or y axis. When the MSAA copy blit shader interpolates the texture coordinates at these sample positions it was possible that it would jump to a neighboring texel due to

Re: [Mesa-dev] [PATCH V6 10/27] i965: fix atomic buffer index for bindings other than 0

Ilia Mirkin writes: > On Tue, Sep 29, 2015 at 3:32 AM, Timothy Arceri wrote: >> On Tue, 2015-09-29 at 02:55 -0400, Ilia Mirkin wrote: >>> On Tue, Sep 29, 2015 at 2:48 AM, Timothy Arceri < >>> t_arc...@yahoo.com.au> wrote: >>> > On Tue, 2015-09-29 at

Re: [Mesa-dev] [PATCH] util: implement strndup for WIN32

On 29/09/15 15:21, Neil Roberts wrote: > I think this implementation will have problems if the string being > copied is not null terminated. It's not clear from the man pages whether > that is an allowed way to use the function but a quick Google shows up a > few similar patches where they have

Re: [Mesa-dev] Pending issues of lollipop-x86

btw, on the topic of lollipop issues, I don't suppose anyone reported yet (or started to debug) this issue: http://git.android-x86.org/?p=platform/frameworks/base.git;a=commitdiff;h=a0571d1e73a34251bf86de5ee85ac2c306c40ea3 I don't have the setup with me today, but I was still seeing a crash in

Re: [Mesa-dev] [PATCH V6 10/27] i965: fix atomic buffer index for bindings other than 0

On Tue, 2015-09-29 at 16:08 +0300, Francisco Jerez wrote: > Ilia Mirkin writes: > > > On Tue, Sep 29, 2015 at 3:32 AM, Timothy Arceri < > > t_arc...@yahoo.com.au> wrote: > > > On Tue, 2015-09-29 at 02:55 -0400, Ilia Mirkin wrote: > > > > On Tue, Sep 29, 2015 at 2:48 AM,

[Mesa-dev] [Bug 92124] shader_query.cpp:841:34: error: ‘strndup’ was not declared in this scope

https://bugs.freedesktop.org/show_bug.cgi?id=92124 --- Comment #5 from Samuel Iglesias --- Should be fixed by: commit bea66d22f2c0e97242c15652376ae4e82779f343 Author: Samuel Iglesias Gonsalvez Date: Mon Sep 28 14:23:34 2015 +0200 util:

Re: [Mesa-dev] [PATCH] mesa: fix ARRAY_SIZE query for GetProgramResourceiv

Hi guys, On 29 September 2015 at 10:30, Martin Peres wrote: > On 28/09/15 13:51, Tapani Pälli wrote: >> >> Patch also refactors name length queries which were using array size >> in computation, this has to be done in same time to avoid regression in >>

Re: [Mesa-dev] [PATCH] configure.ac: handle llvm built with cmake in one shared library.

On Tuesday, 29 September 2015, Dave Airlie wrote: > On 29 September 2015 at 11:31, Tom Stellard > wrote: > > On Mon, Sep 28, 2015 at 03:15:27PM +0100, Emil Velikov wrote: > >> Hi Laurent, > >> > >> On 27 September 2015 at 13:21, Laurent

Re: [Mesa-dev] [PATCH] mesa: fix ARRAY_SIZE query for GetProgramResourceiv

On 09/29/2015 01:42 PM, Emil Velikov wrote: Hi guys, On 29 September 2015 at 10:30, Martin Peres wrote: On 28/09/15 13:51, Tapani Pälli wrote: Patch also refactors name length queries which were using array size in computation, this has to be done in same

Re: [Mesa-dev] [PATCH] mesa/meta: Use interpolateAtSample for 16x MSAA copy blit

Ilia Mirkin writes: > A couple of fairly generic comments: > > - It is not at all clear to me why it's OK to interpolate at sample 0 Yes, this was cheating a little bit. At least on Intel hardware the samples are supposed to be sorted by order of distance from the centre

[Mesa-dev] [PATCH v2] i965/vec4/nir: add nir_intrinsic_memory_barrier support

Fix OpenGL ES 3.1 conformance tests: advanced-readWrite-case1-vsfs and advanced-matrix-vsfs. v2: - Fix SHADER_OPCODE_MEMORY_FENCE emission and the allocation of 'tmp' (Francisco). Signed-off-by: Samuel Iglesias Gonsalvez Tested-by: Tapani Pälli

[Mesa-dev] [PATCH v2] glsl: apply shader storage block member rules when adding program resources

From ARB_program_interface_query: "For an active shader storage block member declared as an array, an entry will be generated only for the first array element, regardless of its type. For arrays of aggregate types, the enumeration rules are applied recursively for the single enumerated array

[Mesa-dev] [PATCH] glsl: assert base_alignment > 0 for records

From GLSL 1.50 spec, section 4.1.8 "Structures": "Structures must have at least one member declaration." So the base_alignment should be higher than zero. Signed-off-by: Samuel Iglesias Gonsalvez Cc: Ilia Mirkin --- src/glsl/glsl_types.cpp | 1 + 1

Re: [Mesa-dev] glx-tls: Visibility hidden attribute and fix x86/x86_64 tls/tdsentry points

Am Samstag, 26. September 2015, 04:47:19 schrieb Sedat Dilek: > On Sat, Sep 26, 2015 at 1:59 AM, Sedat Dilek wrote: > > Hi, > > > > unfortunately, we still have no cool upstream fix for > > -fvisibility=hidden compiler flag handling. > > There is still no

Re: [Mesa-dev] [PATCH v2] i965/vec4/nir: add nir_intrinsic_memory_barrier support

Samuel Iglesias Gonsalvez writes: > Fix OpenGL ES 3.1 conformance tests: advanced-readWrite-case1-vsfs > and advanced-matrix-vsfs. > > v2: > - Fix SHADER_OPCODE_MEMORY_FENCE emission and the allocation of 'tmp' > (Francisco). > > Signed-off-by: Samuel Iglesias Gonsalvez

Re: [Mesa-dev] [PATCH] mesa: fix ARRAY_SIZE query for GetProgramResourceiv

On 28/09/15 13:51, Tapani Pälli wrote: Patch also refactors name length queries which were using array size in computation, this has to be done in same time to avoid regression in arb_program_interface_query-resource-query Piglit test. Fixes rest of the failures with

[Mesa-dev] [PATCH] util: use strnlen() in strndup() implementations

If the string being copied is not NULL-terminated the result of strlen() is undefined. Signed-off-by: Samuel Iglesias Gonsalvez --- src/util/ralloc.c | 5 + src/util/strndup.c | 6 ++ 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/src/util/ralloc.c

Re: [Mesa-dev] List of unsupported extensions per driver

On Tue, Sep 29, 2015 at 4:48 PM, Romain Failliot wrote: > What I don't understand is that all the lines starting with a "-" seems to > be part of the GL_ARB_gpu_shader5 extension. See the line here: > http://cgit.freedesktop.org/mesa/mesa/tree/docs/GL3.txt#n99 > > If

[Mesa-dev] [PATCH 3/3] mesa: clean up #includes in shaderapi.c

--- src/mesa/main/shaderapi.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c index 418121d..82a1ec3 100644 --- a/src/mesa/main/shaderapi.c +++ b/src/mesa/main/shaderapi.c @@ -37,6 +37,7 @@ */ +#include

[Mesa-dev] [PATCH 2/3] mesa: clean up the #includes in shader_query.cpp

--- src/mesa/main/shader_query.cpp | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/mesa/main/shader_query.cpp b/src/mesa/main/shader_query.cpp index 16b43e8..73dee85 100644 --- a/src/mesa/main/shader_query.cpp +++ b/src/mesa/main/shader_query.cpp @@ -30,14

Re: [Mesa-dev] SSBO's in UniformBlocks list?

On Tue, Sep 29, 2015 at 4:33 AM, Iago Toral wrote: > Hi ilia, > > On Tue, 2015-09-29 at 03:53 -0400, Ilia Mirkin wrote: >> Hi Samuel, and any other onlookers, >> >> I was wondering why the decision was made to stick SSBO's onto the >> same list as constbufs. Seems like they're

[Mesa-dev] [PATCH] configure.ac: handle llvm built with cmake in one shared library

llvm can be built with cmake in a libray with the name libLLVM.so.$version Tested with both llvm-3.7.0 and llvm-3.8.0svn v2: check and use llvm build-system feature, update comments Signed-off-by: Laurent Carlier --- configure.ac | 60

Re: [Mesa-dev] List of unsupported extensions per driver

What I don't understand is that all the lines starting with a "-" seems to be part of the GL_ARB_gpu_shader5 extension. See the line here: http://cgit.freedesktop.org/mesa/mesa/tree/docs/GL3.txt#n99 If I'm right, it means that, considering Ilia's web site, GL_ARB_gpu_shader5 is unsupported by

[Mesa-dev] [PATCH 1/3] mesa: remove an extern "C" wrapper in shader_query.cpp

The shaderapi.h header already has the extern "C" wrapper. --- src/mesa/main/shader_query.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/mesa/main/shader_query.cpp b/src/mesa/main/shader_query.cpp index b6d3677..16b43e8 100644 --- a/src/mesa/main/shader_query.cpp

Re: [Mesa-dev] List of unsupported extensions per driver

On Tue, 29 Sep 2015 17:00:31 +0200, Marek Olšák wrote: On Tue, Sep 29, 2015 at 4:48 PM, Romain Failliot wrote: What I don't understand is that all the lines starting with a "-" seems to be part of the GL_ARB_gpu_shader5 extension. See the

Re: [Mesa-dev] [PATCH 2/2] egl/dri2: don't require a context for ClientWaitSync

On 29 September 2015 at 07:28, Albert Freeman wrote: > On 29 September 2015 at 07:25, Albert Freeman > wrote: >> On 28 September 2015 at 08:10, Marek Olšák wrote: >>> On Mon, Sep 28, 2015 at 7:20 AM, Albert Freeman >>>

Re: [Mesa-dev] [PATCH v2] glsl: apply shader storage block member rules when adding program resources

On Tue, 2015-09-29 at 11:02 +0200, Samuel Iglesias Gonsalvez wrote: > From ARB_program_interface_query: > > "For an active shader storage block member declared as an array, an > entry will be generated only for the first array element, regardless > of its type. For arrays of aggregate types,

Re: [Mesa-dev] SSBO's in UniformBlocks list?

Ilia Mirkin writes: > On Tue, Sep 29, 2015 at 4:33 AM, Iago Toral wrote: >> Hi ilia, >> >> On Tue, 2015-09-29 at 03:53 -0400, Ilia Mirkin wrote: >>> Hi Samuel, and any other onlookers, >>> >>> I was wondering why the decision was made to stick SSBO's

[Mesa-dev] [PATCH] main: Fix block index when mixing UBO and SSBO blocks

Since we store both in UniformBlocks, we can't just compute the index by subtracting the array address start, we need to count the number of buffers of the approriate type. --- Or we can just fall back to calc_resource_index... that would also work. This should be a bit faster though since it

Re: [Mesa-dev] [PATCH 2/2] egl/dri2: don't require a context for ClientWaitSync

On Tue, Sep 29, 2015 at 4:54 PM, Albert Freeman wrote: > On 29 September 2015 at 07:28, Albert Freeman > wrote: >> On 29 September 2015 at 07:25, Albert Freeman >> wrote: >>> On 28 September 2015 at 08:10, Marek

[Mesa-dev] [PATCH 2/2] st/mesa: try PIPE_BIND_RENDER_TARGET when choosing float texture formats

For 8-bit RGB(A) texture formats we set the PIPE_BIND_RENDER_TARGET flag to try to get a hardware format which also supports rendering (for FBO textures). Do the same thing for floating point formats. This allows the Redway Flat demo to run. --- src/mesa/state_tracker/st_format.c | 6 +- 1

Re: [Mesa-dev] [PATCH] util: use strnlen() in strndup() implementations

Looks good to me. Thanks for doing that. Reviewed-by: Neil Roberts - Neil Samuel Iglesias Gonsalvez writes: > If the string being copied is not NULL-terminated the result of > strlen() is undefined. > > Signed-off-by: Samuel Iglesias Gonsalvez

Re: [Mesa-dev] [PATCH] util: use strnlen() in strndup() implementations

On 29/09/15 15:35, Samuel Iglesias Gonsalvez wrote: If the string being copied is not NULL-terminated the result of strlen() is undefined. Signed-off-by: Samuel Iglesias Gonsalvez --- src/util/ralloc.c | 5 + src/util/strndup.c | 6 ++ 2 files changed, 3

Re: [Mesa-dev] [PATCH 2/2] egl/dri2: don't require a context for ClientWaitSync

On 29 September 2015 at 15:01, Marek Olšák wrote: > On Tue, Sep 29, 2015 at 4:54 PM, Albert Freeman > wrote: >> On 29 September 2015 at 07:28, Albert Freeman >> wrote: >>> On 29 September 2015 at 07:25, Albert Freeman

Re: [Mesa-dev] [PATCH] glsl: assert base_alignment > 0 for records

On Tue, Sep 29, 2015 at 5:02 AM, Samuel Iglesias Gonsalvez wrote: > From GLSL 1.50 spec, section 4.1.8 "Structures": > > "Structures must have at least one member declaration." > > So the base_alignment should be higher than zero. > > Signed-off-by: Samuel Iglesias Gonsalvez

[Mesa-dev] [PATCH] radeonsi: don't set DATA_FORMAT if ADD_TID_ENABLE is set on VI

From: Marek Olšák This can cause incorrect address calculations and hangs. Cc: mesa-sta...@lists.freedesktop.org --- src/gallium/drivers/radeonsi/si_descriptors.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [Patchwork] The infrequent patchwork update #1

Hi all, You may have noticed already, patchwork.freedesktop.org looks different. That new version includes: - Some re-design. Design is very much an iterative process, thoughts and comments are welcome, - Showing the number of Reviewed-by, Acked-by, Tested-by tags, - Some cleanup of

[Mesa-dev] [PATCH 1/2] st/mesa: add some debugging code in st_ChooseTextureFormat()

I've temporarily added code like this many times. Wrap it in a conditional that can be enabled when needed. --- src/mesa/state_tracker/st_format.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_format.c

Re: [Mesa-dev] [PATCH 2/2] st/mesa: try PIPE_BIND_RENDER_TARGET when choosing float texture formats

Cc: 10.6 11.0 Reviewed-by: Marek Olšák Marek On Tue, Sep 29, 2015 at 5:39 PM, Brian Paul wrote: > For 8-bit RGB(A) texture formats we set the PIPE_BIND_RENDER_TARGET flag > to try to get a hardware format which also

Re: [Mesa-dev] [PATCH 1/3] mesa: remove an extern "C" wrapper in shader_query.cpp

All three are Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] List of unsupported extensions per driver

On 29 September 2015 at 14:48, Romain Failliot wrote: > What I don't understand is that all the lines starting with a "-" seems to > be part of the GL_ARB_gpu_shader5 extension. See the line here: > http://cgit.freedesktop.org/mesa/mesa/tree/docs/GL3.txt#n99 > > If

Re: [Mesa-dev] [PATCH 4/5] i965/miptree: Rename align_w, align_h -> halign, valign

On Sun 27 Sep 2015, Ben Widawsky wrote: > On Fri, Sep 25, 2015 at 12:05:49PM -0700, Chad Versace wrote: > > The values of intel_mipmap_tree::align_w and ::align_h correspond to the > > hardware enums HALIGN_* and VALIGN_*. > > > > See the confusion? > > align_h != HALIGN > > align_h ==

[Mesa-dev] [Bug 92183] linker.cpp:3187:46: error: ‘strtok_r’ was not declared in this scope

https://bugs.freedesktop.org/show_bug.cgi?id=92183 Bug ID: 92183 Summary: linker.cpp:3187:46: error: ‘strtok_r’ was not declared in this scope Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux

Re: [Mesa-dev] [PATCH 4/5] i965/miptree: Rename align_w, align_h -> halign, valign

On Tue, Sep 29, 2015 at 02:16:04PM -0700, Chad Versace wrote: > On Sun 27 Sep 2015, Ben Widawsky wrote: > > On Fri, Sep 25, 2015 at 12:05:49PM -0700, Chad Versace wrote: > > > The values of intel_mipmap_tree::align_w and ::align_h correspond to the > > > hardware enums HALIGN_* and VALIGN_*. > > >

Re: [Mesa-dev] [PATCH 08/70] i965: Remove early release of DRI2 miptree

On Mon 28 Sep 2015, Martin Peres wrote: > On 28/09/15 17:27, Emil Velikov wrote: > >Hi all, > > > >On 17 August 2015 at 19:06, Chad Versace wrote: > >>On Fri 14 Aug 2015, Chris Wilson wrote: > >>>On Thu, Aug 13, 2015 at 09:58:52PM -0700, Kenneth Graunke wrote: > On

Re: [Mesa-dev] [PATCH 4/5] i965/miptree: Rename align_w, align_h -> halign, valign

On Sun 27 Sep 2015, Ben Widawsky wrote: > On Fri, Sep 25, 2015 at 12:05:49PM -0700, Chad Versace wrote: > > The values of intel_mipmap_tree::align_w and ::align_h correspond to the > > hardware enums HALIGN_* and VALIGN_*. > > > > See the confusion? > > align_h != HALIGN > > align_h ==

[Mesa-dev] [PATCH] i965/cs: Upload UBO/SSBO surfaces

Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_context.h | 2 +- src/mesa/drivers/dri/i965/brw_state.h| 1 + src/mesa/drivers/dri/i965/brw_state_upload.c | 2 ++ src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 26

[Mesa-dev] [Bug 91889] Planetary Anihilation: Titans display content of other processes buffers

https://bugs.freedesktop.org/show_bug.cgi?id=91889 --- Comment #28 from Krzysztof A. Sobiecki --- So there was additional trace file hidden in a subfolder: Main: https://drive.google.com/file/d/0B3J0Mg89izcbYnpzVjhSeVRmNEk/view?usp=sharing Hidden one:

Re: [Mesa-dev] [PATCH] i965: store reference to the context within struct brw_fence

On Mon 28 Sep 2015, Marek Olšák wrote: > On Mon, Sep 28, 2015 at 1:29 PM, Emil Velikov > wrote: > > As the spec allows for {server,client}_wait_sync to be called without > > currently bound context, while our implementation requires context > > pointer. > > > >

Re: [Mesa-dev] [PATCH] configure.ac: handle llvm built with cmake in one shared library

On 30 September 2015 at 01:34, Laurent Carlier wrote: > llvm can be built with cmake in a libray with the name libLLVM.so.$version > Tested with both llvm-3.7.0 and llvm-3.8.0svn > > v2: check and use llvm build-system feature, update comments > just to reiterate, this

[Mesa-dev] [Bug 92183] linker.cpp:3187:46: error: ‘strtok_r’ was not declared in this scope

https://bugs.freedesktop.org/show_bug.cgi?id=92183 --- Comment #2 from Ilia Mirkin --- strtok isn't threadsafe -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. ___

[Mesa-dev] [PATCH] glsl: reduce memory footprint of uniform_storage struct

The uniform will only be of a single type so store the data for opaque types in a single array. --- src/glsl/ir_uniform.h| 6 +--- src/glsl/link_uniform_initializers.cpp | 12 +++ src/glsl/link_uniforms.cpp | 41

Re: [Mesa-dev] [PATCH] radeonsi: don't set DATA_FORMAT if ADD_TID_ENABLE is set on VI

On 29.09.2015 23:54, Marek Olšák wrote: > From: Marek Olšák > > This can cause incorrect address calculations and hangs. > > Cc: mesa-sta...@lists.freedesktop.org IIRC without "10.6 11.0" this only makes it a candidate for the 11.0 branch at this point[0]. Is that your

Re: [Mesa-dev] [PATCH 2/2] i965: Get rid of prog_data compare functions

On Tuesday, September 29, 2015 09:05:41 PM Jason Ekstrand wrote: > They are no longer used. > --- > src/mesa/drivers/dri/i965/brw_context.h | 26 -- > src/mesa/drivers/dri/i965/brw_cs.c | 21 - > src/mesa/drivers/dri/i965/brw_cs.h | 2 -- >

Re: [Mesa-dev] [PATCH] i965/copy_image: Fix a copy+past error

On Monday, September 28, 2015 05:39:54 PM Jason Ekstrand wrote: > Reported-by: Ilia Mirkin > --- > src/mesa/drivers/dri/i965/intel_copy_image.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/mesa/drivers/dri/i965/intel_copy_image.c >

[Mesa-dev] [PATCH 2/2] i965: Get rid of prog_data compare functions

They are no longer used. --- src/mesa/drivers/dri/i965/brw_context.h | 26 -- src/mesa/drivers/dri/i965/brw_cs.c | 21 - src/mesa/drivers/dri/i965/brw_cs.h | 2 -- src/mesa/drivers/dri/i965/brw_gs.c | 21 -

[Mesa-dev] [PATCH 1/2] i965/state_cache: Remove the aux_compare fields

They haven't been used since 1bba29ed403e735ba0bf04ed8aa2e571884fcaaf so there's no good reason to keep them around. --- src/mesa/drivers/dri/i965/brw_context.h | 7 --- src/mesa/drivers/dri/i965/brw_state_cache.c | 4 2 files changed, 11 deletions(-) diff --git

[Mesa-dev] [Bug 92183] linker.cpp:3187:46: error: ‘strtok_r’ was not declared in this scope

https://bugs.freedesktop.org/show_bug.cgi?id=92183 --- Comment #1 from Tapani Pälli --- it seems strtok_s would be the windows equivalent: https://msdn.microsoft.com/en-us/library/ftsafwz3.aspx I can make a patch that uses strtok_s when on windows or maybe just go for regular

[Mesa-dev] [Bug 92183] linker.cpp:3187:46: error: ‘strtok_r’ was not declared in this scope

https://bugs.freedesktop.org/show_bug.cgi?id=92183 --- Comment #3 from Tapani Pälli --- (In reply to Ilia Mirkin from comment #2) > strtok isn't threadsafe right I'll go for strtok_s, I was just wondering if the occurences of strtok should be converted to mesa_strtok which

Re: [Mesa-dev] List of unsupported extensions per driver

On Tue, Sep 29, 2015 at 1:29 PM, Romain Failliot wrote: > Le 29 sept. 2015 7:22 PM, "Ilia Mirkin" a écrit : >> R600/R700 will never support ARB_gpu_shader5. Evergreen and NI >> families (also driven by the r600g driver) will gain support for it

Re: [Mesa-dev] List of unsupported extensions per driver

On Tue, Sep 29, 2015 at 1:19 PM, Romain Failliot wrote: > @glenn:so, if I sum up, even though ARB_gpu_shader5 is marked unsupported > for R600 here > (https://secure.freedesktop.org/~imirkin/glxinfo/glxinfo.html), it doesn't > mean that it is really unsupported for

Re: [Mesa-dev] [PATCH 1/2] st/mesa: add some debugging code in st_ChooseTextureFormat()

Reviewed-by: Marek Olšák On Tue, Sep 29, 2015 at 5:39 PM, Brian Paul wrote: > I've temporarily added code like this many times. Wrap it in a > conditional that can be enabled when needed. > --- > src/mesa/state_tracker/st_format.c | 18

Re: [Mesa-dev] List of unsupported extensions per driver

On Tue, Sep 29, 2015 at 1:19 PM, Romain Failliot wrote: > @glenn:so, if I sum up, even though ARB_gpu_shader5 is marked unsupported > for R600 here > (https://secure.freedesktop.org/~imirkin/glxinfo/glxinfo.html), it doesn't > mean that it is really unsupported for

Re: [Mesa-dev] List of unsupported extensions per driver

On Tue, Sep 29, 2015 at 1:29 PM, Romain Failliot wrote: > Le 29 sept. 2015 7:22 PM, "Ilia Mirkin" a écrit : >> R600/R700 will never support ARB_gpu_shader5. Evergreen and NI >> families (also driven by the r600g driver) will gain support for it

Re: [Mesa-dev] [PATCH 2/2] st/mesa: try PIPE_BIND_RENDER_TARGET when choosing float texture formats

Probably makes sense. Albeit I'm not sure about the L/A/LA/I stuff, probably apps are aware that trying to render to that may fail (and hence potentially choosing some rgb format instead of a single-channel format is really not desirable for those). Roland Am 29.09.2015 um 19:50 schrieb Brian

Re: [Mesa-dev] List of unsupported extensions per driver

@glenn:so, if I sum up, even though ARB_gpu_shader5 is marked unsupported for R600 here (https://secure.freedesktop.org/~imirkin/glxinfo/glxinfo.html), it doesn't mean that it is really unsupported for this driver. @albert: thanks, I think I got that right in Mesamatrix ( http://mesamatrix.net)

Re: [Mesa-dev] [PATCH 2/2] st/mesa: try PIPE_BIND_RENDER_TARGET when choosing float texture formats

If that was due to some rgb vs. rgbx thing (that is, could texture from rgb but only render to rgbx) I wonder if the same logic shouldn't also apply to the integer formats. But either way (I guess the app should check fbo completeness in any case so strictly speaking for correctness this isn't

Re: [Mesa-dev] List of unsupported extensions per driver

Le 29 sept. 2015 7:22 PM, "Ilia Mirkin" a écrit : > R600/R700 will never support ARB_gpu_shader5. Evergreen and NI > families (also driven by the r600g driver) will gain support for it in > due time. Aaaah I think I understand my misunderstanding: the R600 drivers (in

Re: [Mesa-dev] [PATCH 2/2] st/mesa: try PIPE_BIND_RENDER_TARGET when choosing float texture formats

I was actually thinking of expanding this change to cover _all_ color formats but wanted to take a small step first. What do you think? -Brian On 09/29/2015 11:46 AM, Roland Scheidegger wrote: If that was due to some rgb vs. rgbx thing (that is, could texture from rgb but only render to

[Mesa-dev] [Bug 91797] [r600g] Company of Heroes 2 crash when zooming on the map

https://bugs.freedesktop.org/show_bug.cgi?id=91797 Benjamin Bellec changed: What|Removed |Added Status|NEW |NEEDINFO ---