Re: [Mesa-dev] [PATCH 1/3] mesa: remove unneeded error check in create_textures()

On 10/05/2015 05:18 PM, Mark Janes wrote: I tested this patch and found: regressions: spec.arb_shader_storage_buffer_object.layout-std140-write-shader (BDW only) expected[1] = 1.00. Read value: 0.00 spec.arb_copy_image.arb_copy_image-srgb-copy (assertion)

[Mesa-dev] Request to expose new AZDO exts: bindless, sparse tex+others exts..

Hi, seeing Mesa support up to GL4.3 is almost complete now would be nice if developers can implement some AZDO extensions which were released as optional ARB extensions in 2013 with GL4.4 release.. With that GL Mesa implementation should be able to compete better with new Vulkan API coming soon..

Re: [Mesa-dev] Request to expose new AZDO exts: bindless, sparse tex+others exts..

On Wednesday, October 07, 2015 05:11:21 AM oscar bg wrote: > Hi, > seeing Mesa support up to GL4.3 is almost complete now would be nice if > developers can implement some AZDO extensions which were released as > optional ARB extensions in 2013 with GL4.4 release.. > > With that GL Mesa

[Mesa-dev] [PATCH 2/2] egl: move memcpy to bring conf->base operations together

Signed-off-by: Varad Gautam --- src/egl/drivers/dri2/egl_dri2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c index aff2181..f600d1b 100644 --- a/src/egl/drivers/dri2/egl_dri2.c +++

[Mesa-dev] [PATCH 1/2] egl: restore surface type before linking config to its display

commit c2c2e9a (egl: implement EGL_KHR_gl_colorspace (v2)) leaves _EGLConfig->SurfaceType set incorrectly before calling _eglLinkConfig(), and the bad value is passed around to platform_android. set it to zero as earlier. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91596 Signed-off-by:

Re: [Mesa-dev] [PATCH 11.3/18] radeon: Don't override NewFramebuffer just to call _mesa_new_framebuffer

On 10/06/2015 11:28 AM, Alex Deucher wrote: > On Tue, Oct 6, 2015 at 2:13 PM, Ian Romanick wrote: >> From: Ian Romanick >> >> Signed-off-by: Ian Romanick > > Assuming the pointer is set correctly as per Brian's comments,

Re: [Mesa-dev] [PATCH] c11/threads: initialize timeout structure

On 10/06/2015 12:04 PM, Matt Turner wrote: > On Sat, Oct 3, 2015 at 5:19 PM, Jan Vesely wrote: >> Signed-off-by: Jan Vesely >> --- >> include/c11/threads_posix.h | 6 ++ >> 1 file changed, 6 insertions(+) >> >> diff --git

Re: [Mesa-dev] [PATCH 11.3/18] radeon: Don't override NewFramebuffer just to call _mesa_new_framebuffer

On Tue, Oct 6, 2015 at 2:13 PM, Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick Assuming the pointer is set correctly as per Brian's comments, this patch is: Reviewed-by: Alex Deucher

Re: [Mesa-dev] [PATCH] i965/cfg: Fix cfg_t::dump() when a block has no immediate dominator.

On Tue, Oct 6, 2015 at 10:01 AM, Kenneth Graunke wrote: > Switch statements introduce a bogus loop with an unconditional break at > the end of the loop, just before the while...so the while is unreachable > and has no immediate dominator. > > Signed-off-by: Kenneth Graunke

Re: [Mesa-dev] [PATCH] egl: restore surface type before linking config to its display

On 6 October 2015 at 17:24, Varad Gautam wrote: > commit c2c2e9a (egl: implement EGL_KHR_gl_colorspace (v2)) leaves > _EGLConfig->SurfaceType set incorrectly before calling _eglLinkConfig(), > and the bad value is passed around to platform_android. fix it. > Well done

Re: [Mesa-dev] [PATCH V6 01/27] glsl: Add support for linking uniform arrays of arrays

On 09/28/2015 07:42 PM, Timothy Arceri wrote: > V3: Fix setting of data.location for struct AoA UBO members > > V2: Handle arrays of arrays in the same way structures are handled > > The ARB_arrays_of_arrays spec doesn't give very many details on how > AoA uniforms are intended to be

Re: [Mesa-dev] [PATCH] mesa: Remove GL_ARB_sampler_object depth compare error checking.

Thanks for reposting. Look OK to me. I'll commit it later. Reviewed-by: Brian Paul On 10/05/2015 03:36 PM, Stefan Dösinger wrote: Version 3: Simplify the code comment, word wrap commit description. Version 2: Return GL_FALSE if ARB_shadow is unsupported instead of

Re: [Mesa-dev] [PATCH 11.4/18] st/mesa: Don't override NewFramebuffer just to call _mesa_new_framebuffer

On 10/06/2015 12:13 PM, Ian Romanick wrote: From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/state_tracker/st_cb_fbo.c | 12 1 file changed, 12 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_fbo.c

Re: [Mesa-dev] [PATCH V6 02/27] glsl: add support for initialising sampler AoA

This patch is Reviewed-by: Ian Romanick On 09/28/2015 07:42 PM, Timothy Arceri wrote: > --- > src/glsl/link_uniform_initializers.cpp | 83 > -- > 1 file changed, 49 insertions(+), 34 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH] c11/threads: initialize timeout structure

On Sat, Oct 3, 2015 at 5:19 PM, Jan Vesely wrote: > Signed-off-by: Jan Vesely > --- > include/c11/threads_posix.h | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/include/c11/threads_posix.h b/include/c11/threads_posix.h > index

[Mesa-dev] [PATCH 11.2/18] i915: Don't override NewFramebuffer just to call _mesa_new_framebuffer

From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/dri/i915/intel_buffers.h | 1 - src/mesa/drivers/dri/i915/intel_fbo.c | 14 -- 2 files changed, 15 deletions(-) diff --git

[Mesa-dev] [PATCH 11.1/18] i965: Don't override NewFramebuffer just to call _mesa_new_framebuffer

From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/dri/i965/intel_buffers.h | 2 -- src/mesa/drivers/dri/i965/intel_fbo.c | 14 -- 2 files changed, 16 deletions(-) diff --git

[Mesa-dev] [PATCH 11.3/18] radeon: Don't override NewFramebuffer just to call _mesa_new_framebuffer

From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/dri/radeon/radeon_fbo.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/src/mesa/drivers/dri/radeon/radeon_fbo.c b/src/mesa/drivers/dri/radeon/radeon_fbo.c index

[Mesa-dev] [PATCH 11.4/18] st/mesa: Don't override NewFramebuffer just to call _mesa_new_framebuffer

From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/state_tracker/st_cb_fbo.c | 12 1 file changed, 12 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_fbo.c b/src/mesa/state_tracker/st_cb_fbo.c index

Re: [Mesa-dev] [RFC] Vendor-neutral dispatch library for OpenGL

On 6 October 2015 at 16:39, Kyle Brenneman wrote: > On 10/06/2015 07:34 AM, Emil Velikov wrote: >> >> Hello Kyle, >> >> A few questions/points of discussion: >> >> * What is your take on having a libglvnd 'package', which provides >> the headers (and maybe other

Re: [Mesa-dev] [PATCH v2] nir: split SSBO min/max atomic instrinsics into signed/unsigned versions

Hi, On Tue, 2015-09-29 at 09:25 +0200, Iago Toral Quiroga wrote: > NIR is typeless so this is the only way to keep track of the > type to select the proper atomic to use. > > v2: > - Use imin,imax,umin,umax for the intrinsic names (Connor Abbott) > - Change message for unreachable paths

Re: [Mesa-dev] [PATCH v2 08/23] i965/vs: Fix a subtlety in the nr_attributes == 0 workaround.

On Mon, 2015-10-05 at 13:41 -0700, Kenneth Graunke wrote: > nr_attributes is used to compute first_non_payload_grf, which is the > first register we're allowed to use for ordinary register allocation. > > The hardware requires us to read at least one pair of values, but we're > completely free to

Re: [Mesa-dev] [PATCH 01/18] t_dd_dmatmp: Replace fprintf with unreachable

On Wed, 2015-09-30 at 13:57 -0700, Ian Romanick wrote: > From: Ian Romanick > > From http://lists.freedesktop.org/archives/mesa-dev/2015-May/084883.html: > > "There are no real error cases here, just dead code. > validate_render() is supposed to make sure we

Re: [Mesa-dev] [PATCH 12/18] mesa/i965: Refactor brw_is_front_buffer_{drawing, reading} to common code

On Wed, 2015-09-30 at 13:58 -0700, Ian Romanick wrote: > From: Ian Romanick > > There are multiple similar implementations of these functions, and a > later patch was going to add another. > > Signed-off-by: Ian Romanick > --- >

Re: [Mesa-dev] [PATCH V6 05/27] glsl: remove dead code in a single pass

On 09/28/2015 07:42 PM, Timothy Arceri wrote: > Currently only one ir assignment is removed for each var in a single > dead code optimisation pass. This means if a var has more than one > assignment, then it requires all the glsl optimisations to be run again > for each additional assignment to be

Re: [Mesa-dev] [PATCH V6 06/27] glsl: add AoA support for atmoic counters

This patch is Reviewed-by: Ian Romanick On 09/28/2015 07:42 PM, Timothy Arceri wrote: > This marks all counters in an AoA as active. > > For AoA all but the innermost array are treated as separate > counters/uniforms. The Nvidia binary also goes further and > finds

Re: [Mesa-dev] [PATCH 1/3] mesa: remove unneeded error check in create_textures()

On 10/06/2015 09:31 AM, Mark Janes wrote: > Mark Janes writes: > >> I tested this patch and found: >> >> regressions: >> spec.arb_shader_storage_buffer_object.layout-std140-write-shader (BDW >> only) >> expected[1] = 1.00. Read value: 0.00 > > In subsequent

Re: [Mesa-dev] Arrays of Arrays v6

Do you have these on a branch somewhere? On 09/28/2015 07:42 PM, Timothy Arceri wrote: > The following are standalone patches I would like to commit asap. > > [PATCH 05/27] glsl: remove dead code in a single pass > [PATCH 10/27] i965: fix atomic buffer index for bindings other than 0 > [PATCH

Re: [Mesa-dev] Arrays of Arrays v6

On Tue, Oct 6, 2015 at 1:13 PM, Ian Romanick wrote: > Do you have these on a branch somewhere? I think it's in his github: https://github.com/tarceri/Mesa_arrays_of_arrays/branches ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH] c11/threads: initialize timeout structure

On 06/10/15 20:30, Ian Romanick wrote: On 10/06/2015 12:04 PM, Matt Turner wrote: On Sat, Oct 3, 2015 at 5:19 PM, Jan Vesely wrote: Signed-off-by: Jan Vesely --- include/c11/threads_posix.h | 6 ++ 1 file changed, 6 insertions(+) diff

Re: [Mesa-dev] [PATCH 1/3] mesa: remove unneeded error check in create_textures()

On 10/06/2015 10:31 AM, Mark Janes wrote: Mark Janes writes: I tested this patch and found: regressions: spec.arb_shader_storage_buffer_object.layout-std140-write-shader (BDW only) expected[1] = 1.00. Read value: 0.00 In subsequent testing I found this BDW

Re: [Mesa-dev] [RFC] Vendor-neutral dispatch library for OpenGL

On 10/06/2015 12:43 PM, Emil Velikov wrote: On 6 October 2015 at 16:39, Kyle Brenneman wrote: On 10/06/2015 07:34 AM, Emil Velikov wrote: Hello Kyle, A few questions/points of discussion: * What is your take on having a libglvnd 'package', which provides the

Re: [Mesa-dev] [PATCH V6 11/27] glsl: calculate AoA uniform offset correctly for structs

On 09/28/2015 07:42 PM, Timothy Arceri wrote: > This allows the correct offset to be calculated for use in indirect > indexing of samplers. > --- > src/glsl/glsl_types.cpp | 16 +++- > 1 file changed, 15 insertions(+), 1 deletion(-) > > diff --git a/src/glsl/glsl_types.cpp

Re: [Mesa-dev] [PATCH V6 12/27] glsl: avoid hitting assert for arrays of arrays

When this lands we should probably also submit a bug report. It is likely to be forgotten otherwise. This patch is Reviewed-by: Ian Romanick On 09/28/2015 07:42 PM, Timothy Arceri wrote: > Also add TODO comment about adding proper support > > Signed-off-by: Timothy

Re: [Mesa-dev] [PATCH 3/3] mesa: move gl_texture_object::TargetIndex initializations

On 10/05/2015 11:18 AM, Brian Paul wrote: > Before, we were unconditionally assigning the TargetIndex field in > _mesa_BindTexture(), even if it was already set properly. Now we > initialize TargetIndex wherever we initialize the Target field, in > _mesa_initialize_texture_object(),

Re: [Mesa-dev] [PATCH V6 06/27] glsl: add AoA support for atmoic counters

Typo in the subject: atomic ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 3/3] mesa: move gl_texture_object::TargetIndex initializations

On 10/06/2015 01:00 PM, Ian Romanick wrote: > On 10/05/2015 11:18 AM, Brian Paul wrote: >> Before, we were unconditionally assigning the TargetIndex field in >> _mesa_BindTexture(), even if it was already set properly. Now we >> initialize TargetIndex wherever we initialize the Target field, in

Re: [Mesa-dev] [PATCH V6 19/27] glsl: add AoA support for linking interface blocks with unsized members

This patch is Reviewed-by: Ian Romanick On 09/28/2015 07:42 PM, Timothy Arceri wrote: > --- > src/glsl/ir.cpp | 4 ++-- > src/glsl/linker.cpp | 9 + > 2 files changed, 7 insertions(+), 6 deletions(-) > > diff --git a/src/glsl/ir.cpp b/src/glsl/ir.cpp >

Re: [Mesa-dev] [PATCH V6 18/27] glsl: add std140 layout support for AoA

On 09/28/2015 07:42 PM, Timothy Arceri wrote: > Reviewed-by: Samuel Iglesias Gonsálvez > --- > src/glsl/glsl_types.cpp | 15 --- > 1 file changed, 8 insertions(+), 7 deletions(-) > > diff --git a/src/glsl/glsl_types.cpp b/src/glsl/glsl_types.cpp > index

Re: [Mesa-dev] [PATCH V6 20/27] glsl: add AoA support for an inteface with unsized array members

This patch is Reviewed-by: Ian Romanick On 09/28/2015 07:42 PM, Timothy Arceri wrote: > Add support for setting the max access of an unsized member > of an interface array of arrays. > > For example ifc[j][k].foo[i] where foo is unsized. > --- >

Re: [Mesa-dev] [PATCH V6 11/27] glsl: calculate AoA uniform offset correctly for structs

On Tue, 2015-10-06 at 13:10 -0700, Ian Romanick wrote: > On 09/28/2015 07:42 PM, Timothy Arceri wrote: > > This allows the correct offset to be calculated for use in indirect > > indexing of samplers. > > --- > > src/glsl/glsl_types.cpp | 16 +++- > > 1 file changed, 15 insertions(+),

Re: [Mesa-dev] [PATCH 1/3] mesa: remove unneeded error check in create_textures()

yes, the assertions are still accurate. I haven't been able to get a stack trace yet. If I don't get to it perhaps Tapani can take a look this evening. Ian Romanick writes: > On 10/06/2015 09:31 AM, Mark Janes wrote: >> Mark Janes writes: >> >>>

Re: [Mesa-dev] Arrays of Arrays v6

On Tue, 2015-10-06 at 13:24 -0700, Matt Turner wrote: > On Tue, Oct 6, 2015 at 1:13 PM, Ian Romanick > wrote: > > Do you have these on a branch somewhere? > > I think it's in his github: > https://github.com/tarceri/Mesa_arrays_of_arrays/branches Yes AoA_v7 is the latest

[Mesa-dev] [PATCH] main: fix length of values written to glGetProgramResourceiv() for ACTIVE_VARIABLES

Return the number of values written. Signed-off-by: Samuel Iglesias Gonsalvez --- src/mesa/main/shader_query.cpp | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/src/mesa/main/shader_query.cpp b/src/mesa/main/shader_query.cpp index

[Mesa-dev] [PATCH v2] main: buffer array variables can have array size of 0 if they are unsized

From ARB_program_query_interface: For the property ARRAY_SIZE, a single integer identifying the number of active array elements of an active variable is written to . The array size returned is in units of the type associated with the property TYPE. For active variables not corresponding

[Mesa-dev] [PATCH v2] glsl: Add is_unsized_array flag to gl_uniform_storage

v2: - Fix uniform's is_unsized_array flag assignment Signed-off-by: Samuel Iglesias Gonsalvez --- src/glsl/ir_uniform.h | 5 + src/glsl/link_uniforms.cpp | 2 ++ 2 files changed, 7 insertions(+) diff --git a/src/glsl/ir_uniform.h b/src/glsl/ir_uniform.h index

[Mesa-dev] [PATCH 2/4] glsl: Add SSBO's load/store/unsize-array-length-calculation support for AoA

Signed-off-by: Samuel Iglesias Gonsalvez Cc: Timothy Arceri --- src/glsl/lower_ubo_reference.cpp | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/glsl/lower_ubo_reference.cpp b/src/glsl/lower_ubo_reference.cpp

[Mesa-dev] [PATCH 1/4] glsl: add std430 layout support for AoA

Signed-off-by: Samuel Iglesias Gonsalvez Cc: Timothy Arceri --- src/glsl/glsl_types.cpp | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/src/glsl/glsl_types.cpp b/src/glsl/glsl_types.cpp index c53ba20..3c7d257 100644

[Mesa-dev] [PATCH 3/4] glsl: fix std430's array_stride calculation for AoA

Signed-off-by: Samuel Iglesias Gonsalvez Cc: Timothy Arceri --- src/glsl/link_uniforms.cpp | 2 +- src/glsl/lower_ubo_reference.cpp | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/glsl/link_uniforms.cpp

[Mesa-dev] [PATCH 4/4] main: array stride for unsized arrays of arrays are calculated like records

Signed-off-by: Samuel Iglesias Gonsalvez Cc: Timothy Arceri --- src/mesa/main/shader_query.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/shader_query.cpp b/src/mesa/main/shader_query.cpp index a1c80b1..9f8adcb

[Mesa-dev] [PATCH 0/4] std430 layout support for AoA

Hello, This series adds std430 layour support for Arrays of Arrays. It should be applied on top of latest Timothy's work: http://lists.freedesktop.org/archives/mesa-dev/2015-September/094652.html Piglit patches will be sent soon. Thanks, Sam Samuel Iglesias Gonsalvez (4): glsl: add std430

Re: [Mesa-dev] [PATCH] mesa: Add missing _mm_mfence() before streaming loads.

On Mon, Oct 05, 2015 at 12:01:25PM -0700, Jordan Justen wrote: > On 2015-10-05 11:55:57, Matt Turner wrote: > > On Thu, Oct 1, 2015 at 11:20 AM, Jordan Justen > > wrote: > > > On 2015-10-01 10:11:33, Matt Turner wrote: > > >> According to the Intel Software Development

[Mesa-dev] [PATCH v2] main: fix TOP_LEVEL_ARRAY_SIZE and TOP_LEVEL_ARRAY_STRIDE

When the active variable is an array which is already a top-level shader storage block member, don't return its array size and stride when querying TOP_LEVEL_ARRAY_SIZE and TOP_LEVEL_ARRAY_STRIDE respectively. Fixes the following 12 dEQP-GLES31 tests:

Re: [Mesa-dev] [PATCH 12/18] mesa/i965: Refactor brw_is_front_buffer_{drawing, reading} to common code

On 10/06/2015 12:02 AM, Iago Toral wrote: > On Wed, 2015-09-30 at 13:58 -0700, Ian Romanick wrote: >> From: Ian Romanick >> >> There are multiple similar implementations of these functions, and a >> later patch was going to add another. >> >> Signed-off-by: Ian Romanick

[Mesa-dev] [PATCH] glsl: Restrict initializers for global variables to constant expression in ES

From: Ian Romanick It may be possible to consolodate this check with the existing check for uniform and const initializers, but a way that didn't require a huge amount of restructing was not obvious to me. Fixes: ES2-CTS.shaders.negative.initialize

[Mesa-dev] [Bug 91596] EGL_KHR_gl_colorspace (v2) causes problem with Android-x86 GUI

https://bugs.freedesktop.org/show_bug.cgi?id=91596 Mauro Rossi changed: What|Removed |Added Status|NEW |RESOLVED

Re: [Mesa-dev] [PATCH v4 1/2] intel: 48b ppgtt support (EXEC_OBJECT_SUPPORTS_48B_ADDRESS flag)

On 10/5/2015 7:06 PM, Kristian Høgsberg wrote: On Mon, Oct 5, 2015 at 7:03 AM, Michel Thierry wrote: On 9/14/2015 2:54 PM, Michał Winiarski wrote: On Thu, Sep 03, 2015 at 03:23:58PM +0100, Michel Thierry wrote: Gen8+ supports 48-bit virtual addresses, but some

Re: [Mesa-dev] [PATCH] mesa: Add missing _mm_mfence() before streaming loads.

The SDM reference is admittedly a little fuzzy on the required fencing, but an SFENCE has no impact on the streaming loads. MFENCE is required to enforce the ordering of the streaming loads. Joe -Original Message- From: Chris Wilson [mailto:ch...@chris-wilson.co.uk] Sent: Tuesday,

Re: [Mesa-dev] [PATCH] vc4: use nir two-sided-color lowering

Boyan Ding writes: > Similar to 9ffc1049ca (freedreno/ir3: use nir two-sided-color lowering). > No piglit regression. Pushed. Thanks! By the way, if you're interested in getting an fd.o account to push patches directly

Re: [Mesa-dev] [PATCH v3 2/2] i965/fs: Handle non-const sample number in interpolateAtSample

Neil Roberts writes: > If a non-const sample number is given to interpolateAtSample it will > now generate an indirect send message with the sample ID similar to > how non-const sampler array indexing works. Previously non-const > values were ignored and instead it ended up

Re: [Mesa-dev] [PATCH] freedreno: unreference resources on context destruction

r<#secure method=pgpmime mode=sign> Ilia Mirkin writes: > Signed-off-by: Ilia Mirkin It looks like cso_destroy_context should already be making you unreference a bunch of this stuff. Am I missing something?

[Mesa-dev] [PATCH V7 14/24] i965: add support for image AoA

--- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 44 -- src/mesa/drivers/dri/i965/brw_nir_uniforms.cpp | 2 ++ 2 files changed, 30 insertions(+), 16 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp index

[Mesa-dev] [PATCH V7 16/24] glsl: add AoA support for linking interface blocks with unsized members

Reviewed-by: Ian Romanick --- src/glsl/ir.cpp | 4 ++-- src/glsl/linker.cpp | 9 + 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/src/glsl/ir.cpp b/src/glsl/ir.cpp index 2c45b9e..ee80abb 100644 --- a/src/glsl/ir.cpp +++ b/src/glsl/ir.cpp @@

[Mesa-dev] [PATCH V7 21/24] glsl: build ubo name and indexing offset for AoA

--- src/glsl/lower_ubo_reference.cpp | 119 --- 1 file changed, 87 insertions(+), 32 deletions(-) diff --git a/src/glsl/lower_ubo_reference.cpp b/src/glsl/lower_ubo_reference.cpp index 247620e..7e983d0 100644 --- a/src/glsl/lower_ubo_reference.cpp +++

[Mesa-dev] [PATCH V7 13/24] glsl: set image access qualifiers for AoA

--- src/glsl/link_uniforms.cpp | 77 +- 1 file changed, 49 insertions(+), 28 deletions(-) diff --git a/src/glsl/link_uniforms.cpp b/src/glsl/link_uniforms.cpp index e2ee628..d34d612 100644 --- a/src/glsl/link_uniforms.cpp +++

[Mesa-dev] [PATCH V7 18/24] glsl: Add support for lowering interface block arrays of arrays

V2: make array processing functions static --- src/glsl/lower_named_interface_blocks.cpp | 51 ++- 1 file changed, 37 insertions(+), 14 deletions(-) diff --git a/src/glsl/lower_named_interface_blocks.cpp b/src/glsl/lower_named_interface_blocks.cpp index

[Mesa-dev] [PATCH V7 03/24] glsl: allow AoA to be sized by initializer or constructor

From Section 4.1.9 of the GLSL ES 3.10 spec: "Arrays are sized either at compile-time or at run-time. To size an array at compile-time, either the size must be specified within the brackets as above or must be inferred from the type of the initializer." --- src/glsl/ast.h |

[Mesa-dev] [PATCH V7 09/24] glsl: calculate AoA uniform offset correctly for structs

This allows the correct offset to be calculated for use in indirect indexing of samplers. --- src/glsl/glsl_types.cpp | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/src/glsl/glsl_types.cpp b/src/glsl/glsl_types.cpp index 25927f6..a1ee505 100644 ---

[Mesa-dev] [PATCH V7 10/24] glsl: avoid hitting assert for arrays of arrays

Also add TODO comment about adding proper support Signed-off-by: Timothy Arceri Reviewed-by: Ian Romanick --- src/glsl/ir_set_program_inouts.cpp | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/glsl/ir_set_program_inouts.cpp

[Mesa-dev] [PATCH V7 15/24] glsl: add std140 layout support for AoA

Reviewed-by: Samuel Iglesias Gonsálvez Reviewed-by: Ian Romanick --- src/glsl/glsl_types.cpp | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/src/glsl/glsl_types.cpp b/src/glsl/glsl_types.cpp index

[Mesa-dev] [PATCH V7 22/24] glsl: Allow arrays of arrays in GLSL ES 3.10 and GLSL 4.30

V3: use a check_*_allowed style function for requirements checking rather than has_* which doesn't encapsulate the error message V2: add missing 's' to the extension name in error messages and add decimal place in version string Reviewed-by: Marta Lofstedt ---

[Mesa-dev] [PATCH V7 17/24] glsl: add AoA support for an inteface with unsized array members

Add support for setting the max access of an unsized member of an interface array of arrays. For example ifc[j][k].foo[i] where foo is unsized. Reviewed-by: Ian Romanick --- src/glsl/ast_array_index.cpp | 16 1 file changed, 12 insertions(+), 4

[Mesa-dev] [PATCH V7 20/24] glsl: link uniform block arrays of arrays

This adds support for setting up the UniformBlock structures for AoA and also adds support for resizing AoA blocks with a packed layout. --- src/glsl/link_uniform_block_active_visitor.cpp | 168 - src/glsl/link_uniform_block_active_visitor.h | 13 +-

[Mesa-dev] [PATCH V7 12/24] i965: add arrays of arrays support for varyings

V2: get the correct vector elements value for outputs --- src/mesa/drivers/dri/i965/brw_fs.cpp | 4 ++-- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 7 +++ 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp

[Mesa-dev] Arrays of Arrays V7

Patches still needing review (11/24): 3, 8, 9, 11, 12, 13, 14, 18, 19, 20, 21 Series can be found in AoA_v7 branch here: https://github.com/tarceri/Mesa_arrays_of_arrays Changes in v7: - Some patches dropped as the old GLSL IR vec4 backend is now gone - Rebased on code refactors in master - Some

[Mesa-dev] [PATCH V7 01/24] glsl: Add support for linking uniform arrays of arrays

V3: Fix setting of data.location for struct AoA UBO members V2: Handle arrays of arrays in the same way structures are handled The ARB_arrays_of_arrays spec doesn't give very many details on how AoA uniforms are intended to be implemented. However in the ARB_program_interface_query spec there

[Mesa-dev] [PATCH V7 02/24] glsl: add support for initialising sampler AoA

Reviewed-by: Ian Romanick --- src/glsl/link_uniform_initializers.cpp | 83 -- 1 file changed, 49 insertions(+), 34 deletions(-) diff --git a/src/glsl/link_uniform_initializers.cpp b/src/glsl/link_uniform_initializers.cpp index

[Mesa-dev] [PATCH V7 08/24] nir: add atomic lowering support for AoA

--- src/glsl/nir/nir_lower_atomics.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/src/glsl/nir/nir_lower_atomics.c b/src/glsl/nir/nir_lower_atomics.c index 6f9ecc0..46e1376 100644 --- a/src/glsl/nir/nir_lower_atomics.c +++

[Mesa-dev] [PATCH V7 06/24] glsl: add AoA support for atomic counters

This marks all counters in an AoA as active. For AoA all but the innermost array are treated as separate counters/uniforms. The Nvidia binary also goes further and finds inactive counters in the AoA, in future we should do this too, however this gets things working for the time being. This

[Mesa-dev] [PATCH V7 07/24] nir: wrapper for glsl_type arrays_of_arrays_size()

Reviewed-by: Tapani Pälli Reviewed-by: Ian Romanick --- src/glsl/nir/nir_types.cpp | 6 ++ src/glsl/nir/nir_types.h | 2 ++ 2 files changed, 8 insertions(+) diff --git a/src/glsl/nir/nir_types.cpp b/src/glsl/nir/nir_types.cpp index

[Mesa-dev] [PATCH V7 11/24] glsl: add AoA support to subroutines

--- src/glsl/ast_function.cpp | 43 ++- src/glsl/lower_subroutine.cpp | 2 +- 2 files changed, 39 insertions(+), 6 deletions(-) diff --git a/src/glsl/ast_function.cpp b/src/glsl/ast_function.cpp index cf4e64a..402180b 100644 ---

[Mesa-dev] [PATCH V7 23/24] i965: enable ARB_arrays_of_arrays

Reviewed-by: Samuel Iglesias Gonsálvez --- src/mesa/drivers/dri/i965/intel_extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c b/src/mesa/drivers/dri/i965/intel_extensions.c index 3f9afd1..c1f3d0d 100644 ---

[Mesa-dev] [PATCH V7 04/24] glsl: dont allow gl_PerVertex to be redeclared as an array of arrays

V3: move patch after fixes to ast for AoA and add const to helper as suggested by Ian V2: move single dimensional array detection into a helper Signed-off-by: Timothy Arceri Reviewed-by: Ian Romanick --- src/glsl/ast.h | 6 ++

Re: [Mesa-dev] [PATCH] freedreno: unreference resources on context destruction

On Tue, Oct 6, 2015 at 6:39 PM, Eric Anholt wrote: > r<#secure method=pgpmime mode=sign> > Ilia Mirkin writes: > >> Signed-off-by: Ilia Mirkin > > It looks like cso_destroy_context should already be making you > unreference a bunch of

Re: [Mesa-dev] [PATCH 00/17] Rework Mesa/ST shader compilation logic (Part 1)

On 6 October 2015 at 11:26, Marek Olšák wrote: > Hi, > > This is a start of reworking how st/mesa translates and creates shaders. The > result of this patch series is this: > > In LinkShader or ProgramStringNotify, the shader is translated to TGSI as-is. > There are no shader

[Mesa-dev] [PATCH V7 19/24] glsl: Add AoA support when checking for non-const index

When checking for non-const indexing of interfaces take into account arrays of arrays --- src/glsl/ast_array_index.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/ast_array_index.cpp b/src/glsl/ast_array_index.cpp index 5927c91..74d403f 100644 ---

[Mesa-dev] [PATCH V7 05/24] glsl: remove dead code in a single pass

Currently only one ir assignment is removed for each var in a single dead code optimisation pass. This means if a var has more than one assignment, then it requires all the glsl optimisations to be run again for each additional assignment to be removed. Another pass is also required to remove the

[Mesa-dev] [PATCH V7 24/24] docs: Mark AoA as done for i965

Reviewed-by: Ian Romanick --- docs/GL3.txt | 4 ++-- docs/relnotes/11.1.0.html | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index e17e783..ffdc524 100644 --- a/docs/GL3.txt +++ b/docs/GL3.txt @@ -149,7

Re: [Mesa-dev] [PATCH v2] main: buffer array variables can have array size of 0 if they are unsized

On Tue, 2015-10-06 at 15:07 +0200, Samuel Iglesias Gonsálvez wrote: > On 06/10/15 12:59, Timothy Arceri wrote: > > On Tue, 2015-10-06 at 10:08 +0200, Samuel Iglesias Gonsalvez wrote: > > > From ARB_program_query_interface: > > > > > > For the property ARRAY_SIZE, a single integer identifying

Re: [Mesa-dev] [PATCH v2] main: buffer array variables can have array size of 0 if they are unsized

On Tue, 2015-10-06 at 10:08 +0200, Samuel Iglesias Gonsalvez wrote: > From ARB_program_query_interface: > > For the property ARRAY_SIZE, a single integer identifying the > number of > active array elements of an active variable is written to . > The > array size returned is in units of the

Re: [Mesa-dev] [PATCH 1/4] glsl: add std430 layout support for AoA

On Tue, 2015-10-06 at 10:26 +0200, Samuel Iglesias Gonsalvez wrote: > Signed-off-by: Samuel Iglesias Gonsalvez > Cc: Timothy Arceri This patch is Reviewed-by: Timothy Arceri Feel free to push this before the rest of my

Re: [Mesa-dev] [PATCH 4/4] main: array stride for unsized arrays of arrays are calculated like records

On 06/10/15 13:24, Timothy Arceri wrote: > On Tue, 2015-10-06 at 10:26 +0200, Samuel Iglesias Gonsalvez wrote: >> Signed-off-by: Samuel Iglesias Gonsalvez >> Cc: Timothy Arceri > > Reviewed-by: Timothy Arceri > Thanks,

Re: [Mesa-dev] [PATCH v2] main: buffer array variables can have array size of 0 if they are unsized

On 06/10/15 12:59, Timothy Arceri wrote: > On Tue, 2015-10-06 at 10:08 +0200, Samuel Iglesias Gonsalvez wrote: >> From ARB_program_query_interface: >> >> For the property ARRAY_SIZE, a single integer identifying the >> number of >> active array elements of an active variable is written to . >>

Re: [Mesa-dev] [RFC] Vendor-neutral dispatch library for OpenGL

Hello Kyle, A few questions/points of discussion: * What is your take on having a libglvnd 'package', which provides the headers (and maybe other materials), apart from the libraries ? I'm basically thinking about OpenGL.h, GLX.h, etc for programs that wish to use new ABI, and glvnd{Foo,Bar}.h

Re: [Mesa-dev] [PATCH 2/4] glsl: Add SSBO's load/store/unsize-array-length-calculation support for AoA

On Tue, 2015-10-06 at 10:26 +0200, Samuel Iglesias Gonsalvez wrote: > Signed-off-by: Samuel Iglesias Gonsalvez > Cc: Timothy Arceri I haven't looked at this too hard yet but just fyi I sent a v6 of my patchseries that added UBO AoA support that this

Re: [Mesa-dev] [PATCH 4/4] main: array stride for unsized arrays of arrays are calculated like records

On Tue, 2015-10-06 at 10:26 +0200, Samuel Iglesias Gonsalvez wrote: > Signed-off-by: Samuel Iglesias Gonsalvez > Cc: Timothy Arceri Reviewed-by: Timothy Arceri > --- > src/mesa/main/shader_query.cpp | 2 +- > 1 file changed,

Re: [Mesa-dev] [PATCH 2/4] glsl: Add SSBO's load/store/unsize-array-length-calculation support for AoA

On 06/10/15 13:14, Timothy Arceri wrote: > On Tue, 2015-10-06 at 10:26 +0200, Samuel Iglesias Gonsalvez wrote: >> Signed-off-by: Samuel Iglesias Gonsalvez >> Cc: Timothy Arceri > > > I haven't looked at this too hard yet but just fyi I sent a v6

Re: [Mesa-dev] [PATCH 3/4] glsl: fix std430's array_stride calculation for AoA

On 06/10/15 13:17, Timothy Arceri wrote: > On Tue, 2015-10-06 at 10:26 +0200, Samuel Iglesias Gonsalvez wrote: >> Signed-off-by: Samuel Iglesias Gonsalvez >> Cc: Timothy Arceri >> --- >> src/glsl/link_uniforms.cpp | 2 +- >>

Re: [Mesa-dev] [PATCH 3/4] glsl: fix std430's array_stride calculation for AoA

On Tue, 2015-10-06 at 10:26 +0200, Samuel Iglesias Gonsalvez wrote: > Signed-off-by: Samuel Iglesias Gonsalvez > Cc: Timothy Arceri > --- > src/glsl/link_uniforms.cpp | 2 +- > src/glsl/lower_ubo_reference.cpp | 6 +++--- > 2 files changed, 4

Re: [Mesa-dev] [PATCH 1/4] glsl: add std430 layout support for AoA

On 06/10/15 13:09, Timothy Arceri wrote: > On Tue, 2015-10-06 at 10:26 +0200, Samuel Iglesias Gonsalvez wrote: >> Signed-off-by: Samuel Iglesias Gonsalvez >> Cc: Timothy Arceri > > This patch is Reviewed-by: Timothy Arceri >

  1   2   >