Re: [Mesa-dev] [PATCH 0/4] i965: skip control-flow aware liveness analysis if we only have 1 block

2015-10-13 Thread Iago Toral
On Tue, 2015-10-13 at 09:44 -0700, Jordan Justen wrote: > On 2015-10-13 05:17:37, Francisco Jerez wrote: > > Iago Toral Quiroga writes: > > > > > This fixes the following test: > > > > > > [require] > > > GL >= 3.3 > > > GLSL >= 3.30 > > > GL_ARB_shader_storage_buffer_object > > > > > > [fragment

Re: [Mesa-dev] [PATCH 1/2] glsl: Support uint index in do_vec_index_to_cond_assign

2015-10-13 Thread Tapani Pälli
Series is Reviewed-by: Tapani Pälli (Note that due to recent changes, test won't pass but fails like: glcts: brw_nir.c:103: brw_nir_lower_inputs: Assertion `!"unsupported shader stage"' failed.) On 10/14/2015 12:27 AM, Jordan Justen wrote: The ES31-CTS.compute_shader.pipeline-compute-chain t

Re: [Mesa-dev] [PATCH 05/10] i965/meta/gen9: Individually fast clear color attachments

2015-10-13 Thread Matt Turner
On Tue, Oct 13, 2015 at 9:12 PM, Matt Turner wrote: > On Tue, Oct 13, 2015 at 8:50 PM, Ben Widawsky > wrote: >> The impetus for this patch comes from a seemingly benign statement within the >> spec (quoted within the patch). For me, this patch was at some point critical >> for getting stable pigl

Re: [Mesa-dev] [PATCH 05/10] i965/meta/gen9: Individually fast clear color attachments

2015-10-13 Thread Matt Turner
On Tue, Oct 13, 2015 at 8:50 PM, Ben Widawsky wrote: > The impetus for this patch comes from a seemingly benign statement within the > spec (quoted within the patch). For me, this patch was at some point critical > for getting stable piglit results (though this did not seem to be the case on > a

Re: [Mesa-dev] [PATCH 04/10] i965/skl: skip fast clears for certain surface formats

2015-10-13 Thread Matt Turner
On Tue, Oct 13, 2015 at 8:50 PM, Ben Widawsky wrote: > Initially I had this planned as a patch to be squashed in to the enabling > patch > because there is no point enabling fast clears without this. However, Chad > merged a patch which disables fast clears on gen9 explicitly, and so I can > hid

Re: [Mesa-dev] [PATCH 03/10] i965/skl: Enable fast color clears on SKL

2015-10-13 Thread Matt Turner
On Tue, Oct 13, 2015 at 8:50 PM, Ben Widawsky wrote: > Based on a patch originally from Kristian. Skylake has extended capabilities > with regard to fast clears, but that is saved for another patch. > > The same effect could be acheived with the following, however I think the way > I've done it is

Re: [Mesa-dev] [PATCH] i965/fs: Restore compute shader support in brw_nir_lower_inputs

2015-10-13 Thread Jordan Justen
On 2015-10-13 20:04:36, Kenneth Graunke wrote: > On Tuesday, October 13, 2015 01:44:55 PM Jordan Justen wrote: > > The commit shown below caused compute shaders to hit the unreachable > > in the default of the switch block. Restore compute shaders to use the > > fragment shader path. > > > > Also,

Re: [Mesa-dev] [RFC 2/2] gallium: add tegra support

2015-10-13 Thread Michel Dänzer
On 13.10.2015 12:44, Alexandre Courbot wrote: > On Mon, Oct 12, 2015 at 12:09 AM, Christian Gmeiner > wrote: >> >> diff --git a/src/gallium/winsys/tegra/drm/tegra_drm_winsys.c >> b/src/gallium/winsys/tegra/drm/tegra_drm_winsys.c >> new file mode 100644 >> index 000..e172407 >> --- /dev/null >

[Mesa-dev] [PATCH 04/10] i965/skl: skip fast clears for certain surface formats

2015-10-13 Thread Ben Widawsky
Initially I had this planned as a patch to be squashed in to the enabling patch because there is no point enabling fast clears without this. However, Chad merged a patch which disables fast clears on gen9 explicitly, and so I can hide this behind the revert of that patch. This is a nice I really wa

[Mesa-dev] [PATCH 09/10] i965/meta: Remove fast_clear_color variable

2015-10-13 Thread Ben Widawsky
It doesn't actually serve a purpose AFAICT (in fact, I'm not certain what it's meant to do). Cc: Kristian Høgsberg Signed-off-by: Ben Widawsky --- src/mesa/drivers/dri/i965/brw_meta_fast_clear.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/mesa/drivers/dri/i96

[Mesa-dev] [PATCH 08/10] i965/meta: Assert fast clears and rep clears never overlap

2015-10-13 Thread Ben Widawsky
There is nothing wrong with the code today, but as one modifies the code it turns out to be not too difficult to mess up the code, and this easy assertion should catch such driver implementation failures quickly. Cc: Kristian Høgsberg Signed-off-by: Ben Widawsky --- src/mesa/drivers/dri/i965/br

[Mesa-dev] [PATCH 06/10] Revert "i965/gen9: Disable MCS for 1x color surfaces"

2015-10-13 Thread Ben Widawsky
This reverts commit dcd59a9e322edeea74187bcad65a8e56c0bfaaa2. --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 8 1 file changed, 8 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c index f108b75..c723f79 100644 --

[Mesa-dev] [PATCH 07/10] Revert "i965/gen9: Enable rep clears on gen9"

2015-10-13 Thread Ben Widawsky
This reverts commit 8a0c85b25853decb4a110b6d36d79c4f095d437b. It's not a strict revert because I don't want to bring back the gen < 9 check at this point in time. --- src/mesa/drivers/dri/i965/brw_meta_fast_clear.c | 5 - 1 file changed, 5 deletions(-) diff --git a/src/mesa/drivers/dri/i965/

[Mesa-dev] [PATCH 03/10] i965/skl: Enable fast color clears on SKL

2015-10-13 Thread Ben Widawsky
Based on a patch originally from Kristian. Skylake has extended capabilities with regard to fast clears, but that is saved for another patch. The same effect could be acheived with the following, however I think the way I've done it is more in line with how the docs explain it. --- a/src/mesa/driv

[Mesa-dev] [PATCH 02/10] i965/gen8+: Extract color clear surface state

2015-10-13 Thread Ben Widawsky
On future generation platforms the color clear value is stored elsewhere in the surface state. By extracting this logic, we can cleanly implement the difference in an upcoming patch. Should have no functional impact. Signed-off-by: Ben Widawsky --- src/mesa/drivers/dri/i965/gen8_surface_state.c

[Mesa-dev] [PATCH 10/10] i965/gen9: Support fast clears for 32b float

2015-10-13 Thread Ben Widawsky
SKL supports the ability to do fast clears and resolves of 32b RGBA as both integer and floats. This patch only enables float color clears because we haven't yet enabled integer color clears, (HW support for that was added in BDW). This is enabled separate because it is a new feature to SKL and so

[Mesa-dev] [PATCH 01/10] i965/gen8+: Remove redundant zeroing of surface state

2015-10-13 Thread Ben Widawsky
The allocate_surface_state already zeroes out the surface state, and doing it later in the function is destructive for what we want to accomplish when we split out support for gen9 fast clears (next patch). NOTE: Only dword 12 actually needed to be fixed, but it seemed more consistent to remove th

[Mesa-dev] [PATCH 05/10] i965/meta/gen9: Individually fast clear color attachments

2015-10-13 Thread Ben Widawsky
The impetus for this patch comes from a seemingly benign statement within the spec (quoted within the patch). For me, this patch was at some point critical for getting stable piglit results (though this did not seem to be the case on a branch Chad was working on). It is very important for clearing

[Mesa-dev] [PATCH 00/10] Support Skylake MCS buffers (fast clears)

2015-10-13 Thread Ben Widawsky
This patch series adds support for fast color clears on SKL as it exists on previous generations of hardware minus the new hardware restriction on surface formats. Additionally, it adds support for utilizing clear values with up to 32b per color channel (see note at the bottom). It is based on work

Re: [Mesa-dev] [PATCH] i965/fs: Restore compute shader support in brw_nir_lower_inputs

2015-10-13 Thread Kenneth Graunke
On Tuesday, October 13, 2015 01:44:55 PM Jordan Justen wrote: > The commit shown below caused compute shaders to hit the unreachable > in the default of the switch block. Restore compute shaders to use the > fragment shader path. > > Also, simplify the fragment/compute path to only support scalar

Re: [Mesa-dev] [PATCH] mesa: remove unused functions in program.c

2015-10-13 Thread Matt Turner
On Tue, Oct 13, 2015 at 7:16 PM, Brian Paul wrote: > replace_registers() and adjust_param_indexes() were unused. > --- Yep, noticed this too. Found it strange that someone would have managed to find and delete unused functions that gcc doesn't warn about while leaving in place functions that it d

[Mesa-dev] [PATCH] mesa: remove unused functions in program.c

2015-10-13 Thread Brian Paul
replace_registers() and adjust_param_indexes() were unused. --- src/mesa/program/program.c | 51 -- 1 file changed, 51 deletions(-) diff --git a/src/mesa/program/program.c b/src/mesa/program/program.c index c35a89b..86de5e9 100644 --- a/src/mesa/program

[Mesa-dev] [PATCH] mesa: remove unused texUnit local in _mesa_BindTextureUnit()

2015-10-13 Thread Brian Paul
The texture unit is error-checked before this and the texUnit var is unused, so remove it. --- src/mesa/main/texobj.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/src/mesa/main/texobj.c b/src/mesa/main/texobj.c index b571b1b..3182920 100644 --- a/src/mesa/main/texobj.c +++ b/src/mesa/

Re: [Mesa-dev] [PATCH v2 6/7] radeonsi: Add DCC decompress.

2015-10-13 Thread Marek Olšák
On Tue, Oct 13, 2015 at 2:19 AM, Marek Olšák wrote: > On Mon, Oct 12, 2015 at 5:05 PM, Bas Nieuwenhuizen > wrote: >> Hi Marek, >> >> Thanks for the quick review. >> >> I do not think I understand the sharing semantics. We currently have >> fast clear for scanout surfaces with the CMASK and elimin

Re: [Mesa-dev] [PATCH] i965: Don't hardcode FS in "validation failed!" message.

2015-10-13 Thread Kristian Høgsberg
On Tue, Oct 13, 2015 at 3:17 PM, Kenneth Graunke wrote: > Instead, print "Scalar VS" or "Scalar FS". Otherwise it's really > confusing which stage is broken. > > Signed-off-by: Kenneth Graunke Reviewed-by: Kristian Høgsberg > --- > src/mesa/drivers/dri/i965/brw_fs_validate.cpp | 2 +- > 1 fi

Re: [Mesa-dev] [PATCH 0/4] Implement separate index spaces for UBOs and SSBOs

2015-10-13 Thread Kristian Høgsberg
On Fri, Oct 09, 2015 at 03:23:33PM +0200, Iago Toral Quiroga wrote: > See the rationale for this in [1], no piglit regressions observed in my > IvyBridge laptop. > > Patch 1: Renames {Num}UniformBlocks to {Num}BufferInterfaceBlocks. This is > more consistent with the current implementation, since

[Mesa-dev] [PATCH] i965: Don't hardcode FS in "validation failed!" message.

2015-10-13 Thread Kenneth Graunke
Instead, print "Scalar VS" or "Scalar FS". Otherwise it's really confusing which stage is broken. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_fs_validate.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_validate.cpp b

Re: [Mesa-dev] [PATCH v2] nir: split SSBO min/max atomic instrinsics into signed/unsigned versions

2015-10-13 Thread Kenneth Graunke
On Tuesday, September 29, 2015 09:25:27 AM Iago Toral Quiroga wrote: > NIR is typeless so this is the only way to keep track of the > type to select the proper atomic to use. > > v2: > - Use imin,imax,umin,umax for the intrinsic names (Connor Abbott) > - Change message for unreachable paths (M

Re: [Mesa-dev] [PATCH v4 1/2] intel: 48b ppgtt support (EXEC_OBJECT_SUPPORTS_48B_ADDRESS flag)

2015-10-13 Thread Kristian Høgsberg
On Tue, Oct 13, 2015 at 7:55 AM, Michel Thierry wrote: > On 10/13/2015 3:13 PM, Emil Velikov wrote: >> >> On 13 October 2015 at 13:16, Michel Thierry >> wrote: >>> >>> On 10/6/2015 2:12 PM, Michel Thierry wrote: On 10/5/2015 7:06 PM, Kristian Høgsberg wrote: > > > On Mo

Re: [Mesa-dev] [PATCH 2/5] i965/vec4: adding vec4_cmod_propagation optimization

2015-10-13 Thread Matt Turner
On Tue, Oct 13, 2015 at 1:49 AM, Alejandro Piñeiro wrote: > On 13/10/15 03:10, Matt Turner wrote: >> Looks like this is causing an intermittent failure on HSW in our >> Jenkins system (but I'm not able to reproduce locally) and a >> consistent failure on G45. I'll investigate that. > > Ok, will ho

[Mesa-dev] [PATCH 2/2] glsl: Support uint index in lower_vector_insert

2015-10-13 Thread Jordan Justen
The ES31-CTS.compute_shader.pipeline-compute-chain test case was generating an unsigned index by using gl_LocalInvocationID.x and gl_LocalInvocationID.y as array indices. Signed-off-by: Jordan Justen --- src/glsl/lower_vector_insert.cpp | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-)

[Mesa-dev] [PATCH 1/2] glsl: Support uint index in do_vec_index_to_cond_assign

2015-10-13 Thread Jordan Justen
The ES31-CTS.compute_shader.pipeline-compute-chain test case was generating an unsigned index by using gl_LocalInvocationID.x and gl_LocalInvocationID.y as array indices. Signed-off-by: Jordan Justen --- src/glsl/lower_vec_index_to_cond_assign.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 del

[Mesa-dev] [PATCH] i965/fs: Restore compute shader support in brw_nir_lower_inputs

2015-10-13 Thread Jordan Justen
The commit shown below caused compute shaders to hit the unreachable in the default of the switch block. Restore compute shaders to use the fragment shader path. Also, simplify the fragment/compute path to only support scalar mode. commit 2953c3d76178d7589947e6ea1dbd902b7b02b3d4 Author: Kenneth G

Re: [Mesa-dev] [PATCH] glsl: Fix variable_referenced() for vector_{extract, insert} expressions

2015-10-13 Thread Kristian Høgsberg
On Mon, Oct 05, 2015 at 11:42:43AM +0200, Iago Toral Quiroga wrote: > We get these when we operate on vector variables with array accessors > (i.e. things like a[0] where 'a' is a vec4). When we call > variable_referenced() > on these expressions we want to return a reference to 'a' instead of NUL

[Mesa-dev] [RFC 1/4] glsl IR: add always_active_io attribute to ir_variable

2015-10-13 Thread Gregory Hainaut
The value will be set in separate-shader program when an input/output must remains active (i.e. deadcode removal isn't allowed because it will create interface location/name-matching mismatch) v3: * Rename the attribute * Use ir_variable directly instead of ir_variable_refcount_visitor * Move the

[Mesa-dev] [RFC 4/4] glsl: don't sort varying in separate shader mode

2015-10-13 Thread Gregory Hainaut
Current issue is the addition of FLAT qualifier on varying_matches::record() which break the varying expected order Future issue is the removal of the interpolation qualifier matching constrain In my humble opinion, it is the responsability of the GL developer to optimize their slots assignment i

[Mesa-dev] [RFC 0/4] V3: Improve GLSL support of GL_ARB_separate_shader_objects

2015-10-13 Thread Gregory Hainaut
New version that improves previous code quality and fixes several outstanding issues. Piglit wasn't run yet. v3: Squash commit 1&2 * Use a better name for the new attribute: always_active_io * Use ir_variable directly instead of ir_variable_refcount_visitor * Put related code in linker.cpp Add 2

[Mesa-dev] [RFC 3/4] glsl: avoid linker and user varying location to overlap

2015-10-13 Thread Gregory Hainaut
Current behavior on the interface matching: layout (location = 0) out0; // Assigned to VARYING_SLOT_VAR0 by user out1; // Assigned to VARYING_SLOT_VAR0 by the linker New behavior on the interface matching: layout (location = 0) out0; // Assigned to VARYING_SLOT_VAR0 by user out1; // Assigned to

[Mesa-dev] [RFC 2/4] glsl IR: only allow optimization of interstage variable

2015-10-13 Thread Gregory Hainaut
GL_ARB_separate_shader_objects allow to match by name variable or block interface. Input varying can't be removed because it is will impact the location assignment. It fixes the bug 79783 and likely any application that uses GL_ARB_separate_shader_objects extension. piglit test: arb_separate_shad

Re: [Mesa-dev] [PATCH] mesa: pass caller name to create_textures()

2015-10-13 Thread Anuj Phogat
On Mon, Oct 12, 2015 at 7:44 PM, Brian Paul wrote: > Simpler than the dsa flag approach. > --- > src/mesa/main/texobj.c | 13 ++--- > 1 file changed, 6 insertions(+), 7 deletions(-) > > diff --git a/src/mesa/main/texobj.c b/src/mesa/main/texobj.c > index 60c55ae..b571b1b 100644 > --- a/sr

Re: [Mesa-dev] [PATCH v2] nir: split SSBO min/max atomic instrinsics into signed/unsigned versions

2015-10-13 Thread Kristian Høgsberg
On Tue, Sep 29, 2015 at 09:25:27AM +0200, Iago Toral Quiroga wrote: > NIR is typeless so this is the only way to keep track of the > type to select the proper atomic to use. > > v2: > - Use imin,imax,umin,umax for the intrinsic names (Connor Abbott) > - Change message for unreachable paths (Mi

Re: [Mesa-dev] llvmpipe broken on Skylake Pentium (LP_NATIVE_VECTOR_WIDTH=128)

2015-10-13 Thread Roland Scheidegger
Am 13.10.2015 um 19:59 schrieb Adam Jackson: > On Mon, 2015-10-12 at 22:55 +0200, Roland Scheidegger wrote: > >> I don't know that looks like a generic string you're getting back. >> x86-64 IIRC implies sse2 in llvm, but not the other sseX flags (and if >> we detected sse41 we're going to use intr

Re: [Mesa-dev] llvmpipe broken on Skylake Pentium (LP_NATIVE_VECTOR_WIDTH=128)

2015-10-13 Thread Adam Jackson
On Mon, 2015-10-12 at 22:55 +0200, Roland Scheidegger wrote: > I don't know that looks like a generic string you're getting back. > x86-64 IIRC implies sse2 in llvm, but not the other sseX flags (and if > we detected sse41 we're going to use intrinsics for these, which then > may not be available

Re: [Mesa-dev] [PATCH 0/4] i965: skip control-flow aware liveness analysis if we only have 1 block

2015-10-13 Thread Jordan Justen
On 2015-10-13 05:17:37, Francisco Jerez wrote: > Iago Toral Quiroga writes: > > > This fixes the following test: > > > > [require] > > GL >= 3.3 > > GLSL >= 3.30 > > GL_ARB_shader_storage_buffer_object > > > > [fragment shader] > > #version 330 > > #extension GL_ARB_shader_storage_buffer_object:

Re: [Mesa-dev] [Mesa-stable] [PATCH v2] configure.ac: ensure RM is set

2015-10-13 Thread Matt Turner
On Tue, Oct 13, 2015 at 3:25 AM, Emil Velikov wrote: > On 10 October 2015 at 07:42, Jonathan Gray wrote: >> GNU make predefines RM to rm -f but this is not required by POSIX >> so ensure that RM is set. This fixes "make clean" on OpenBSD. >> >> v2: use AC_CHECK_PROG >> > I'm ambivalent if we go

Re: [Mesa-dev] [PATCH 5/6] nir: remove dependency on glsl

2015-10-13 Thread Emil Velikov
On 13 October 2015 at 16:37, Rob Clark wrote: > On Tue, Oct 13, 2015 at 11:22 AM, Emil Velikov > wrote: >> Hi Rob, >> >> On 10 October 2015 at 19:47, Rob Clark wrote: >>> From: Rob Clark >>> >>> Move glsl_types into NIR, now that the dependency on glsl_symbol_table >>> has been split out. >>>

Re: [Mesa-dev] [PATCH 1/6] glsl: couple shader_enums cleanups

2015-10-13 Thread Jason Ekstrand
On Oct 13, 2015 8:26 AM, "Emil Velikov" wrote: > > On 10 October 2015 at 19:47, Rob Clark wrote: > > From: Rob Clark > > > > Add missing enum to gl_system_value_name() and move VARYING_SLOT_MAX / > > FRAG_RESULT_MAX / etc into shader_enums.h as suggested by Emil. > > > > v2: add STATIC_ASSERT()'

Re: [Mesa-dev] [PATCH 5/6] nir: remove dependency on glsl

2015-10-13 Thread Rob Clark
On Tue, Oct 13, 2015 at 11:22 AM, Emil Velikov wrote: > Hi Rob, > > On 10 October 2015 at 19:47, Rob Clark wrote: >> From: Rob Clark >> >> Move glsl_types into NIR, now that the dependency on glsl_symbol_table >> has been split out. >> >> Possibly makes sense to rename things at this point, but

Re: [Mesa-dev] [PATCH 1/6] glsl: couple shader_enums cleanups

2015-10-13 Thread Emil Velikov
On 10 October 2015 at 19:47, Rob Clark wrote: > From: Rob Clark > > Add missing enum to gl_system_value_name() and move VARYING_SLOT_MAX / > FRAG_RESULT_MAX / etc into shader_enums.h as suggested by Emil. > > v2: add STATIC_ASSERT()'s > > Reported-by: Emil Velikov > Signed-off-by: Rob Clark > -

Re: [Mesa-dev] [PATCH 5/6] nir: remove dependency on glsl

2015-10-13 Thread Emil Velikov
Hi Rob, On 10 October 2015 at 19:47, Rob Clark wrote: > From: Rob Clark > > Move glsl_types into NIR, now that the dependency on glsl_symbol_table > has been split out. > > Possibly makes sense to rename things at this point, but if we do that > I'd like to keep it split out into a separate patc

Re: [Mesa-dev] [PATCH v4 1/2] intel: 48b ppgtt support (EXEC_OBJECT_SUPPORTS_48B_ADDRESS flag)

2015-10-13 Thread Michel Thierry
On 10/13/2015 3:13 PM, Emil Velikov wrote: On 13 October 2015 at 13:16, Michel Thierry wrote: On 10/6/2015 2:12 PM, Michel Thierry wrote: On 10/5/2015 7:06 PM, Kristian Høgsberg wrote: On Mon, Oct 5, 2015 at 7:03 AM, Michel Thierry wrote: On 9/14/2015 2:54 PM, Michał Winiarski wrote:

Re: [Mesa-dev] [PATCH v4 1/2] intel: 48b ppgtt support (EXEC_OBJECT_SUPPORTS_48B_ADDRESS flag)

2015-10-13 Thread Michel Thierry
On 10/6/2015 2:12 PM, Michel Thierry wrote: On 10/5/2015 7:06 PM, Kristian Høgsberg wrote: On Mon, Oct 5, 2015 at 7:03 AM, Michel Thierry wrote: On 9/14/2015 2:54 PM, Michał Winiarski wrote: On Thu, Sep 03, 2015 at 03:23:58PM +0100, Michel Thierry wrote: Gen8+ supports 48-bit virtual addre

Re: [Mesa-dev] [RFC 2/2] gallium: add tegra support

2015-10-13 Thread Alexandre Courbot
On Mon, Oct 12, 2015 at 12:09 AM, Christian Gmeiner wrote: > This commit adds tegra support, which uses the renderonly driver > library. > > Signed-off-by: Christian Gmeiner > --- > configure.ac | 19 +++- > src/gallium/Makefile.am

[Mesa-dev] [Bug 90264] [Regression, bisected] Tooltip corruption in Chrome

2015-10-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90264 Patryk Zawadzki changed: What|Removed |Added CC||pat...@gmail.com -- You are receiving

Re: [Mesa-dev] [PATCH v4 1/2] intel: 48b ppgtt support (EXEC_OBJECT_SUPPORTS_48B_ADDRESS flag)

2015-10-13 Thread Emil Velikov
On 13 October 2015 at 13:16, Michel Thierry wrote: > On 10/6/2015 2:12 PM, Michel Thierry wrote: >> >> On 10/5/2015 7:06 PM, Kristian Høgsberg wrote: >>> >>> On Mon, Oct 5, 2015 at 7:03 AM, Michel Thierry >>> wrote: On 9/14/2015 2:54 PM, Michał Winiarski wrote: > > > On Thu,

Re: [Mesa-dev] [PATCH 0/4] i965: skip control-flow aware liveness analysis if we only have 1 block

2015-10-13 Thread Francisco Jerez
Iago Toral writes: > On Tue, 2015-10-13 at 15:17 +0300, Francisco Jerez wrote: >> Iago Toral Quiroga writes: >> >> > This fixes the following test: >> > >> > [require] >> > GL >= 3.3 >> > GLSL >= 3.30 >> > GL_ARB_shader_storage_buffer_object >> > >> > [fragment shader] >> > #version 330 >> > #e

Re: [Mesa-dev] [PATCH 0/4] i965: skip control-flow aware liveness analysis if we only have 1 block

2015-10-13 Thread Iago Toral
On Tue, 2015-10-13 at 15:17 +0300, Francisco Jerez wrote: > Iago Toral Quiroga writes: > > > This fixes the following test: > > > > [require] > > GL >= 3.3 > > GLSL >= 3.30 > > GL_ARB_shader_storage_buffer_object > > > > [fragment shader] > > #version 330 > > #extension GL_ARB_shader_storage_buff

Re: [Mesa-dev] Plan to work on opt_peephole_sel optimization for vec4

2015-10-13 Thread Francisco Jerez
Antía Puentes writes: > On lun, 2015-10-12 at 15:55 +0300, Francisco Jerez wrote: >> Antía Puentes writes: >> > On dom, 2015-10-11 at 10:35 -0700, Matt Turner wrote: >> >> I would expect big improvements in the vec4 backend from making its >> >> copy propagation pass global. >> > >> > I will be

Re: [Mesa-dev] [PATCH 0/4] i965: skip control-flow aware liveness analysis if we only have 1 block

2015-10-13 Thread Francisco Jerez
Iago Toral Quiroga writes: > This fixes the following test: > > [require] > GL >= 3.3 > GLSL >= 3.30 > GL_ARB_shader_storage_buffer_object > > [fragment shader] > #version 330 > #extension GL_ARB_shader_storage_buffer_object: require > > buffer SSBO { > mat4 sm4; > }; > > > mat4 um4; > > void

Re: [Mesa-dev] [PATCH 2/2] glsl: calculate TOP_LEVEL_ARRAY_SIZE and STRIDE when adding resources

2015-10-13 Thread Samuel Iglesias Gonsálvez
Series is: Reviewed-by: Samuel Iglesias Gonsálvez Thanks! Sam On 13/10/15 13:40, Tapani Pälli wrote: > Patch moves existing calculation code from shader_query.cpp to happen > during program resource list creation. > > No Piglit or CTS regressions were observed during testing. > > Signed-off-

Re: [Mesa-dev] [PATCH 01/11] vbo: get rid of needless NR_MAT_ATTRIBS constant

2015-10-13 Thread Marek Olšák
For the series: Reviewed-by: Marek Olšák Marek On Tue, Oct 13, 2015 at 4:45 AM, Brian Paul wrote: > --- > src/mesa/vbo/vbo_context.c | 9 +++-- > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/src/mesa/vbo/vbo_context.c b/src/mesa/vbo/vbo_context.c > index 802955d..b5dc4

[Mesa-dev] [PATCH 2/2] glsl: calculate TOP_LEVEL_ARRAY_SIZE and STRIDE when adding resources

2015-10-13 Thread Tapani Pälli
Patch moves existing calculation code from shader_query.cpp to happen during program resource list creation. No Piglit or CTS regressions were observed during testing. Signed-off-by: Tapani Pälli --- src/glsl/linker.cpp| 241 src/mesa/main/sh

[Mesa-dev] [PATCH 1/2] glsl: add top level array size and stride to gl_uniform_storage

2015-10-13 Thread Tapani Pälli
Patch adds 2 new fields to gl_uniform_storage so that we don't need to calculate these values during runtime shader queries. This is required by upcoming changes to free GLSL IR after linking. Patch moves 3 booleans inside structure so that structure size stays the same after this change. Signed-

[Mesa-dev] [PATCH 3/4] i965/vec4: fix indentation in vec4_visitor::calculate_live_intervals

2015-10-13 Thread Iago Toral Quiroga
--- src/mesa/drivers/dri/i965/brw_vec4_live_variables.cpp | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4_live_variables.cpp b/src/mesa/drivers/dri/i965/brw_vec4_live_variables.cpp index cc688ef..6782379 100644 --- a/src/mesa

[Mesa-dev] [PATCH 2/4] i965/fs: skip control-flow aware liveness analysis if we only have 1 block

2015-10-13 Thread Iago Toral Quiroga
Otherwise, what this is going to do is mark every variable alive in the single block we have, and thus, alive since its definition until the program ends, which is really bad in situations where register pressure is high. Of course, this does not address the real problem: that our liveness analysi

[Mesa-dev] [PATCH 4/4] i965/vec4: skip control-flow aware liveness analysis if we only have 1 block

2015-10-13 Thread Iago Toral Quiroga
Otherwise, what this is going to do is mark every variable alive in the single block we have, and thus, alive since its definition until the program ends, which is really bad in situations where register pressure is high. Of course, this does not address the real problem: that our liveness analysi

[Mesa-dev] [PATCH 1/4] i965/fs: Fix indentation in fs_live_variables::compute_start_end

2015-10-13 Thread Iago Toral Quiroga
--- src/mesa/drivers/dri/i965/brw_fs_live_variables.cpp | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_live_variables.cpp b/src/mesa/drivers/dri/i965/brw_fs_live_variables.cpp index 19aec92..ce066a9 100644 --- a/src/mesa/driv

[Mesa-dev] [PATCH 0/4] i965: skip control-flow aware liveness analysis if we only have 1 block

2015-10-13 Thread Iago Toral Quiroga
This fixes the following test: [require] GL >= 3.3 GLSL >= 3.30 GL_ARB_shader_storage_buffer_object [fragment shader] #version 330 #extension GL_ARB_shader_storage_buffer_object: require buffer SSBO { mat4 sm4; }; mat4 um4; void main() { sm4 *= um4; sm4[0][0] = 0.0; } [test] link

Re: [Mesa-dev] [PATCH] vbo: fix incorrect switch statement in init_mat_currval()

2015-10-13 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Tue, Oct 13, 2015 at 4:45 AM, Brian Paul wrote: > The variable 'i' is a value in [0, MAT_ATTRIB_MAX-1] so subtracting > VERT_ATTRIB_GENERIC0 gave a bogus value and we executed the default > switch clause for all loop iterations. > > This doesn't fix any known i

Re: [Mesa-dev] [PATCH 2/4] tgsi: try and handle overflowing shaders.

2015-10-13 Thread Marek Olšák
On Tue, Oct 13, 2015 at 6:40 AM, Dave Airlie wrote: > From: Dave Airlie > > This is used to detect error in virgl if we overflow the shader > dumping buffers. > > Signed-off-by: Dave Airlie > --- > src/gallium/auxiliary/tgsi/tgsi_dump.c | 10 -- > src/gallium/auxiliary/tgsi/tgsi_dump.h

Re: [Mesa-dev] [PATCH 1/4] tgsi: add option to dump floats as hex values

2015-10-13 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Tue, Oct 13, 2015 at 6:40 AM, Dave Airlie wrote: > This adds support to the parser to accept hex values as floats, > and then adds support to the dumper to allow the user to select > to dump float as 32-bit hex numbers. > > This is required to get accurate valu

Re: [Mesa-dev] [Mesa-stable] [PATCH v2] configure.ac: ensure RM is set

2015-10-13 Thread Jonathan Gray
On Tue, Oct 13, 2015 at 11:25:08AM +0100, Emil Velikov wrote: > On 10 October 2015 at 07:42, Jonathan Gray wrote: > > GNU make predefines RM to rm -f but this is not required by POSIX > > so ensure that RM is set. This fixes "make clean" on OpenBSD. > > > > v2: use AC_CHECK_PROG > > > I'm ambival

Re: [Mesa-dev] [PATCH] program: convert _mesa_init_gl_program() to take struct gl_program *

2015-10-13 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Tue, Oct 13, 2015 at 12:26 PM, Emil Velikov wrote: > Rather than accepting a void pointer, only to down and up cast around > it, convert the function to take the base (struct gl_program) pointer. > > Cc: Marek Olšák > Signed-off-by: Emil Velikov > --- > src/

Re: [Mesa-dev] [Mesa-stable] [PATCH v2] configure.ac: ensure RM is set

2015-10-13 Thread Emil Velikov
On 10 October 2015 at 07:42, Jonathan Gray wrote: > GNU make predefines RM to rm -f but this is not required by POSIX > so ensure that RM is set. This fixes "make clean" on OpenBSD. > > v2: use AC_CHECK_PROG > I'm ambivalent if we go the AC_CHECK_PROG vs ?= route. I'll let others pick their favo

[Mesa-dev] [PATCH] program: convert _mesa_init_gl_program() to take struct gl_program *

2015-10-13 Thread Emil Velikov
Rather than accepting a void pointer, only to down and up cast around it, convert the function to take the base (struct gl_program) pointer. Cc: Marek Olšák Signed-off-by: Emil Velikov --- src/mesa/drivers/dri/i915/i915_fragprog.c | 9 ++-- src/mesa/drivers/dri/i965/brw_program.c

Re: [Mesa-dev] [PATCH V4 2/6] glsl: assign hidden uniforms their slot id earlier

2015-10-13 Thread Marek Olšák
On Tue, Oct 13, 2015 at 10:13 AM, Timothy Arceri wrote: > On Mon, 2015-10-12 at 01:06 +0200, Marek Olšák wrote: >> On Sun, Oct 11, 2015 at 9:20 AM, Timothy Arceri < >> t_arc...@yahoo.com.au> wrote: >> > On Sat, 2015-10-10 at 18:06 +0200, Marek Olšák wrote: >> > > Hi Timothy, >> > > >> > > One of t

Re: [Mesa-dev] [PATCH] glsl: couple shader_enums cleanups

2015-10-13 Thread Emil Velikov
On 10 October 2015 at 01:56, Rob Clark wrote: > On Fri, Oct 9, 2015 at 8:07 PM, Emil Velikov wrote: >> On 9 October 2015 at 23:27, Rob Clark wrote: >>> On Fri, Oct 9, 2015 at 5:57 PM, Emil Velikov >>> wrote: On 9 October 2015 at 21:31, Rob Clark wrote: > From: Rob Clark > >

Re: [Mesa-dev] Plan to work on opt_peephole_sel optimization for vec4

2015-10-13 Thread Antía Puentes
On lun, 2015-10-12 at 15:55 +0300, Francisco Jerez wrote: > Antía Puentes writes: > > On dom, 2015-10-11 at 10:35 -0700, Matt Turner wrote: > >> I would expect big improvements in the vec4 backend from making its > >> copy propagation pass global. > > > > I will be working on global copy propagati

Re: [Mesa-dev] [PATCH 00/10] RadeonSI cleanups

2015-10-13 Thread Michel Dänzer
On 11.10.2015 10:11, Marek Olšák wrote: > Nothing special here other than cleanups. One patch disables NaNs for LS and > HS, and there's also one GS shader leak fix. > > Please review. Patches 1, 3-6 & 8 are Reviewed-by: Michel Dänzer -- Earthling Michel Dänzer |

Re: [Mesa-dev] [PATCH 07/10] radeonsi: unify shader delete functions

2015-10-13 Thread Michel Dänzer
On 11.10.2015 10:11, Marek Olšák wrote: > From: Marek Olšák > > --- > src/gallium/drivers/radeonsi/si_state_shaders.c | 84 > + > 1 file changed, 17 insertions(+), 67 deletions(-) > > diff --git a/src/gallium/drivers/radeonsi/si_state_shaders.c > b/src/gallium/drivers/

Re: [Mesa-dev] [PATCH 02/10] radeonsi: cleanup si_llvm_init_export_args

2015-10-13 Thread Michel Dänzer
On 11.10.2015 10:11, Marek Olšák wrote: > From: Marek Olšák The shortlog should say "clean up" (verb) instead of "cleanup" (noun). Same for patches 9 & 10. > diff --git a/src/gallium/drivers/radeonsi/si_shader.c > b/src/gallium/drivers/radeonsi/si_shader.c > index 32a702f..109a805 100644 > ---

Re: [Mesa-dev] [PATCH 00/10] RadeonSI: Better LLVM IR generation

2015-10-13 Thread Michel Dänzer
On 11.10.2015 10:29, Marek Olšák wrote: > > This patch series improves IR generation for radeonsi. Most of it removes > uses of AMDGPU intrinsics. Patches 3-7 are Reviewed-by: Michel Dänzer -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast

Re: [Mesa-dev] [PATCH] glsl: fix matrix stride calculation for std430's row_major matrices with two columns

2015-10-13 Thread Lofstedt, Marta
Thanks Samuel, This also fixes 10+ OpenGL ES 3.1 test cases. Reviewed-by: Marta Lofstedt > -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of Samuel Iglesias Gonsalvez > Sent: Tuesday, October 13, 2015 8:39 AM > To: mesa-dev@lists.freedesk

Re: [Mesa-dev] [PATCH 2/5] i965/vec4: adding vec4_cmod_propagation optimization

2015-10-13 Thread Alejandro Piñeiro
On 13/10/15 03:10, Matt Turner wrote: > On Mon, Oct 12, 2015 at 4:25 PM, Matt Turner wrote: >> On Sat, Oct 10, 2015 at 4:24 AM, Alejandro Piñeiro >> wrote: >>> vec4 port of fs_cmod_propagation. >>> >>> Shader-db results: >>> total instructions in shared programs: 6241226 -> 6224469 (-0.27%) >>

Re: [Mesa-dev] [PATCH 2/3] radeonsi: implement vertex color clamping

2015-10-13 Thread Michel Dänzer
On 11.10.2015 10:17, Marek Olšák wrote: > From: Marek Olšák > > This is only supported in the compatibility profile (without GS and tess). [...] > diff --git a/src/gallium/drivers/radeonsi/si_state.c > b/src/gallium/drivers/radeonsi/si_state.c > index 3aafe8a..a81060a 100644 > --- a/src/galliu

Re: [Mesa-dev] [PATCH V4 2/6] glsl: assign hidden uniforms their slot id earlier

2015-10-13 Thread Timothy Arceri
On Mon, 2015-10-12 at 01:06 +0200, Marek Olšák wrote: > On Sun, Oct 11, 2015 at 9:20 AM, Timothy Arceri < > t_arc...@yahoo.com.au> wrote: > > On Sat, 2015-10-10 at 18:06 +0200, Marek Olšák wrote: > > > Hi Timothy, > > > > > > One of these 3 commits breaks compilation for Talos shaders with > > > g

Re: [Mesa-dev] [PATCH V4 2/6] glsl: assign hidden uniforms their slot id earlier

2015-10-13 Thread Michel Dänzer
On 11.10.2015 16:20, Timothy Arceri wrote: > On Sat, 2015-10-10 at 18:06 +0200, Marek Olšák wrote: >> Hi Timothy, >> >> One of these 3 commits breaks compilation for Talos shaders with >> gallium. My piglit patch "glsl-1.30/sampler-bug: ..." contains a >> minimal test case. I can't say which commit

Re: [Mesa-dev] [PATCH V4 2/6] glsl: assign hidden uniforms their slot id earlier

2015-10-13 Thread Timothy Arceri
On Mon, 2015-10-12 at 01:06 +0200, Marek Olšák wrote: > On Sun, Oct 11, 2015 at 9:20 AM, Timothy Arceri < > t_arc...@yahoo.com.au> wrote: > > On Sat, 2015-10-10 at 18:06 +0200, Marek Olšák wrote: > > > Hi Timothy, > > > > > > One of these 3 commits breaks compilation for Talos shaders with > > > g