[Mesa-dev] [PATCH 2/2] glsl: set user defined varyings to smooth by default

This is usually handled by the backends in order to handle the various interactions with the gl_*Color built-ins. The problem is this means linking will fail if one side on the interface adds the smooth qualifier to the varying and the other side just uses the default even though they match.

[Mesa-dev] [PATCH 1/2] glsl: remove unused helper

Seems to have become unused when i965 moved to NIR. --- src/compiler/glsl/ir.cpp | 15 --- src/compiler/glsl/ir.h | 11 --- 2 files changed, 26 deletions(-) diff --git a/src/compiler/glsl/ir.cpp b/src/compiler/glsl/ir.cpp index c7a2496..750f617 100644 ---

[Mesa-dev] [PATCH v2] egl_dri2: set correct error code if swapbuffers fails

From: Daniel Czarnowski A return value of '-1' means that there was error during swap with a window drawable, in this case we set error as EGL_BAD_NATIVE_WINDOW. v2: coding style cleanup, better commit message Signed-off-by: Matt Roper

Re: [Mesa-dev] [PATCH 00/21] nir: Functions!

Adding Connor to the Cc just in case he missed it. On Sat, Feb 13, 2016 at 6:14 PM, Jason Ekstrand wrote: > This patch series adds actual function support to NIR. Previously all NIR > usage relied on GLSL to have lowered functions away entirely. As a result, > any

Re: [Mesa-dev] [PATCH 00/21] nir: Functions!

On Sat, Feb 13, 2016 at 10:01 PM, Jordan Justen wrote: > On 2016-02-13 18:14:17, Jason Ekstrand wrote: > > This patch series adds actual function support to NIR. Previously all > NIR > > usage relied on GLSL to have lowered functions away entirely. As a > result, > >

Re: [Mesa-dev] [PATCH] mesa: need to check resource and set length even if bufSize is 0

Reviewed-by: Tapani Pälli On 02/12/2016 07:19 PM, Ilia Mirkin wrote: This fixes a number of dEQP tests, such as: dEQP-GLES31.functional.program_interface_query.buffer_limited_query.resource_query It was expecting the length to be set even in the bufSize == 0 case.

[Mesa-dev] [PATCH] glsl: warn in GL as well as ES when varying not written

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93339 --- src/compiler/glsl/link_varyings.cpp | 23 +++ 1 file changed, 7 insertions(+), 16 deletions(-) diff --git a/src/compiler/glsl/link_varyings.cpp b/src/compiler/glsl/link_varyings.cpp index 2e84972..e3c2fa6

Re: [Mesa-dev] [PATCH] nv50, nvc0: enable/disable seamless cubemap texturing as requested

On Sun, Feb 14, 2016 at 6:23 PM, Samuel Pitoiset wrote: > > > On 02/14/2016 04:18 AM, Ilia Mirkin wrote: >> >> In a situation where the seamless setting isn't available on a >> per-texture basis (G200+ Teslas, and all Fermis), assume that all >> samplers will have it

Re: [Mesa-dev] [PATCH] nv{c, 5}0: Remove duplicate logic from nvc0_set_framebuffer_state()

Your patch doesn't compile because you forgot to include "util/u_framebuffer.h" nv50/nv50_state.c: In function ‘nv50_set_framebuffer_state’: nv50/nv50_state.c:942:4: error: implicit declaration of function ‘util_copy_framebuffer_state’ [-Werror=implicit-function-declaration]

Re: [Mesa-dev] [PATCH] i965: Set compute shared shared memory max to 64k

On Sun, Feb 14, 2016 at 12:39:32PM -0800, Jordan Justen wrote: > See Ivy Bridge PRM, Volume 2, Part 2, 1.8.4 INTERFACE_DESCRIPTOR_DATA: > > DWORD 5, bits 20:16: "This field indicates how much shared local > memory the thread group requires. The amount is specified in 4k > blocks, but only powers

[Mesa-dev] [PATCH] nv{c, 5}0: Remove duplicate logic from nvc0_set_framebuffer_state()

We already have this logic in the gallium/util functions so lets reduce some entropy while here. V.2: Apply change to nv50 also as suggested by Samuel Pitoiset. Signed-off-by: Edward O'Callaghan --- src/gallium/drivers/nouveau/nv50/nv50_state.c | 13

Re: [Mesa-dev] [PATCH] nv{c, 5}0: Remove duplicate logic from nvc0_set_framebuffer_state()

On 02/14/2016 10:54 PM, Edward O'Callaghan wrote: We already have this logic in the gallium/util functions so lets reduce some entropy while here. V.2: Apply change to nv50 also as suggested by Samuel Pitoiset. Signed-off-by: Edward O'Callaghan Could you

Re: [Mesa-dev] [PATCH] nv{c, 5}0: Remove duplicate logic from nvc0_set_framebuffer_state()

On 02/14/2016 11:04 PM, Ilia Mirkin wrote: On Sun, Feb 14, 2016 at 5:00 PM, Samuel Pitoiset wrote: On 02/14/2016 10:54 PM, Edward O'Callaghan wrote: We already have this logic in the gallium/util functions so lets reduce some entropy while here. V.2: Apply

[Mesa-dev] [PATCH] i965: Set compute shared shared memory max to 64k

See Ivy Bridge PRM, Volume 2, Part 2, 1.8.4 INTERFACE_DESCRIPTOR_DATA: DWORD 5, bits 20:16: "This field indicates how much shared local memory the thread group requires. The amount is specified in 4k blocks, but only powers of 2 are allowed: 0, 4k, 8k, 16k, 32k and 64k per half-slice." For

Re: [Mesa-dev] [PATCH] nv50, nvc0: enable/disable seamless cubemap texturing as requested

On 02/14/2016 04:18 AM, Ilia Mirkin wrote: In a situation where the seamless setting isn't available on a per-texture basis (G200+ Teslas, and all Fermis), assume that all samplers will have it identically set, and enable accordingly. This fixes arb_seamless_cubemap piglit test on Fermi and

Re: [Mesa-dev] [PATCH] nv{c, 5}0: Remove duplicate logic from nvc0_set_framebuffer_state()

On Sun, Feb 14, 2016 at 5:00 PM, Samuel Pitoiset wrote: > > > On 02/14/2016 10:54 PM, Edward O'Callaghan wrote: >> >> We already have this logic in the gallium/util functions so >> lets reduce some entropy while here. >> >> V.2: >>Apply change to nv50 also as

[Mesa-dev] V.2; nv{5,c}0: Remove duplicate logic from nvc0_set_framebuffer_state()

N.B., untested as I don't currently have access to this hw. V.2: Apply change also to nv50 as suggested by Samuel Pitoiset. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] nv{c, 5}0: Remove duplicate logic from nvc0_set_framebuffer_state()

Reviewed-by: Ilia Mirkin On Sun, Feb 14, 2016 at 4:54 PM, Edward O'Callaghan wrote: > We already have this logic in the gallium/util functions so > lets reduce some entropy while here. > > V.2: > Apply change to nv50 also as suggested by

Re: [Mesa-dev] [PATCH] mesa: allow multisampled format info to be returned on GLES 3.1

On Sun, Feb 14, 2016 at 5:36 AM, Timothy Arceri wrote: > On Sat, 2016-02-13 at 23:50 -0500, Ilia Mirkin wrote: >> Marta, perhaps you can have a look? It's pretty similar to your >> commit >> b6d014f0b (mesa/es3.1: Pass sample count check for multisampled >>

Re: [Mesa-dev] [PATCH] mesa: need to check resource and set length even if bufSize is 0

Hi Tapani, Looks like you added this function (and the logic I'm removing) in commit 2ab8de218 (mesa: implementation of glGetProgramResourceiv). Could you have a look at this change and see if it makes sense to you? Thanks, -ilia On Fri, Feb 12, 2016 at 12:19 PM, Ilia Mirkin

Re: [Mesa-dev] [PATCH 2/6] st/mesa: overhaul vertex setup for clearing, glDrawPixels, glBitmap

On Sun, Feb 14, 2016 at 9:47 AM, Brian Paul wrote: > On 02/13/2016 01:03 PM, Ilia Mirkin wrote: >> >> On Fri, Feb 12, 2016 at 10:43 AM, Brian Paul wrote: >>> >>> diff --git a/src/mesa/state_tracker/st_context.c >>> b/src/mesa/state_tracker/st_context.c >>>

[Mesa-dev] [Bug 94148] Framebuffer considered invalid when a draw call is done before glCheckFramebufferStatus

https://bugs.freedesktop.org/show_bug.cgi?id=94148 Bug ID: 94148 Summary: Framebuffer considered invalid when a draw call is done before glCheckFramebufferStatus Product: Mesa Version: git Hardware: x86-64 (AMD64)

[Mesa-dev] [PATCH] nvc0: Remove duplicate logic from nvc0_set_framebuffer_state()

We already have this logic in the gallium/util functions so lets reduce some entropy while here. N.B., untested as I don't currently have access to this hw. Signed-off-by: Edward O'Callaghan --- src/gallium/drivers/nouveau/nvc0/nvc0_state.c | 13 + 1

[Mesa-dev] [PATCH] mesa: move assertion in _mesa_cube_face_target()

Fixes piglit arb_texture_view-sampling-2d-array-as-2d-layer regression. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94134 --- src/mesa/main/teximage.h | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/teximage.h b/src/mesa/main/teximage.h index

Re: [Mesa-dev] [PATCH 1/7] cso: add new cso_save/restore_state() functions

On 02/13/2016 03:10 PM, Jose Fonseca wrote: On 12/02/16 15:44, Brian Paul wrote: cso_save_state() takes a bitmask of state items to save. Calling cso_restore_state() restores those states. --- src/gallium/auxiliary/cso_cache/cso_context.c | 109 ++

Re: [Mesa-dev] [PATCH 2/5] android: radeonsi: fix building error in si_shader.c

Hi, thanks, now they should be ok The macro name was changed to __STRCHRNUL_H Tested by building marshmallow-x86 M. >From c1fd979ee7b3e74c4d097b7b1941ebbe65f8d003 Mon Sep 17 00:00:00 2001 From: Mauro Rossi Date: Sun, 14 Feb 2016 15:34:16 +0100 Subject: [PATCH 1/2]

Re: [Mesa-dev] [PATCH 2/7] st/mesa: use new cso_save/restore_state() functions

On 02/14/2016 07:27 AM, Brian Paul wrote: On 02/13/2016 03:01 PM, Jose Fonseca wrote: On 12/02/16 15:44, Brian Paul wrote: --- src/mesa/state_tracker/st_cb_bitmap.c | 36 src/mesa/state_tracker/st_cb_clear.c | 46 +++

Re: [Mesa-dev] [PATCH] nvc0: Remove duplicate logic from nvc0_set_framebuffer_state()

This change can also be applied to nv50_set_framebuffer_state(). On 02/14/2016 01:46 PM, Edward O'Callaghan wrote: We already have this logic in the gallium/util functions so lets reduce some entropy while here. N.B., untested as I don't currently have access to this hw. Signed-off-by: Edward

Re: [Mesa-dev] [PATCH 2/7] st/mesa: use new cso_save/restore_state() functions

On 02/13/2016 03:01 PM, Jose Fonseca wrote: On 12/02/16 15:44, Brian Paul wrote: --- src/mesa/state_tracker/st_cb_bitmap.c | 36 src/mesa/state_tracker/st_cb_clear.c | 46 +++ src/mesa/state_tracker/st_cb_drawpixels.c | 46

Re: [Mesa-dev] [PATCH 2/6] st/mesa: overhaul vertex setup for clearing, glDrawPixels, glBitmap

On 02/13/2016 01:03 PM, Ilia Mirkin wrote: On Fri, Feb 12, 2016 at 10:43 AM, Brian Paul wrote: diff --git a/src/mesa/state_tracker/st_context.c b/src/mesa/state_tracker/st_context.c index 9016846..cb2c390 100644 --- a/src/mesa/state_tracker/st_context.c +++

Re: [Mesa-dev] [PATCH] mesa: move assertion in _mesa_cube_face_target()

On 14/02/16 14:18, Brian Paul wrote: Fixes piglit arb_texture_view-sampling-2d-array-as-2d-layer regression. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94134 --- src/mesa/main/teximage.h | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] mesa: move assertion in _mesa_cube_face_target()

Am 14.02.2016 um 15:18 schrieb Brian Paul: > Fixes piglit arb_texture_view-sampling-2d-array-as-2d-layer regression. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94134 > --- > src/mesa/main/teximage.h | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git

[Mesa-dev] [PATCH V2 3/3] glsl: reject invalid input layout qualifiers

Global in validation is already handled, this will do the validation for variables, blocks and block members. This fixes some CTS tests for the new enhanced layouts transform feedback qualifiers. V2: add some more valid input flags --- src/compiler/glsl/ast_type.cpp | 30

[Mesa-dev] [PATCH 1/3] glsl: don't apply uniform/buffer layouts to interface blocks

If the following patch we will stop setting these layouts by default on interface blocks, so we need to do this to avoid hitting the assert. --- src/compiler/glsl/ast_to_hir.cpp | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/compiler/glsl/ast_to_hir.cpp

[Mesa-dev] [PATCH 2/3] glsl: rework parsing of blocks

Previously interface blocks were giving the global default flags of uniform blocks. This meant we could not check for invalid qualifiers on interface blocks because they always contained invalid flags. This changes parsing so that interface blocks now get an empty set of layouts. ---

Re: [Mesa-dev] [PATCH] mesa: allow multisampled format info to be returned on GLES 3.1

On Sat, 2016-02-13 at 23:50 -0500, Ilia Mirkin wrote: > Marta, perhaps you can have a look? It's pretty similar to your > commit > b6d014f0b (mesa/es3.1: Pass sample count check for multisampled > textures). > > On Thu, Feb 11, 2016 at 3:04 PM, Ilia Mirkin > wrote: > > The

[Mesa-dev] [Bug 94137] build error - incompatible types in assignment of 'unsigned int*' to 'uint [3] {aka unsigned int [3]}'

https://bugs.freedesktop.org/show_bug.cgi?id=94137 Samuel Pitoiset changed: What|Removed |Added Status|NEW |RESOLVED

[Mesa-dev] [Bug 94137] build error - incompatible types in assignment of 'unsigned int*' to 'uint [3] {aka unsigned int [3]}'

https://bugs.freedesktop.org/show_bug.cgi?id=94137 Vinson Lee changed: What|Removed |Added Keywords||regression -- You

Re: [Mesa-dev] [PATCH 1/3] nvc0: fix compute state initialization on GK110+

On 02/14/2016 12:41 AM, Ilia Mirkin wrote: On Sat, Feb 13, 2016 at 6:31 PM, Samuel Pitoiset wrote: For some unknown reasons, the command 0x518, which is FIRMWARE[0x6] Please make a note that the blob calls it, along with the args passed in (usually via scratch