Re: [Mesa-dev] ANNOUNCE: An open-source Vulkan driver for Intel hardware

2016-02-16 Thread Iago Toral
Hey Jason, this is awesome news, congrats to all the people involved! Did you have a chance to try the new driver with anything other than conformance tests or small demos? I know it is still in a very early stage but I'd like to know your impressions about how much of an improvement it brings

Re: [Mesa-dev] Where do we put a Vulkan driver?

2016-02-16 Thread Jose Fonseca
On 16/02/16 22:19, Brian Paul wrote: On 02/16/2016 02:41 PM, Dave Airlie wrote: On 17 February 2016 at 04:39, Jason Ekstrand wrote: So, we just pushed a branch containing a Vulkan driver. Naturally, we would like to incorporate that driver into the upstream mesa tree.

Re: [Mesa-dev] [PATCH] i965/gen7: Use predicated rendering for indirect compute

2016-02-16 Thread Kenneth Graunke
On Tuesday, February 16, 2016 10:09:50 AM PST Jordan Justen wrote: > On gen7 (Ivy Bridge, Haswell), we will get a GPU hang if an indirect > dispatch is used, but one of the dimensions is 0. > > Therefore we use predicated rendering on the GPGPU_WALKER command to > handle this case. > > Fixes

Re: [Mesa-dev] ANNOUNCE: An open-source Vulkan driver for Intel hardware

2016-02-16 Thread Olivier Galibert
I'm actually interested about how one goes about debugging that kind of problem, if you have pointers. I would have an idea or two on how to go about it if it was in userspace only, but once it crosses into the kernel I'm not sure what strategies are best. Best, OG. On Wed, Feb 17, 2016 at

Re: [Mesa-dev] [PATCH] mesa: default DepthMode to GL_RED on ES 3.0

2016-02-16 Thread Kenneth Graunke
On Tuesday, February 16, 2016 6:29:39 PM PST Ilia Mirkin wrote: > See commit 9db2098d which did it internally to the i965 driver. No > reason not to have this more globally set though. > > This fixes depth in a bunch of dEQP EXT_texture_border_clamp tests. And > probably other items as well. > >

Re: [Mesa-dev] [PATCH] [v2] intel: Add missing SKL device IDs

2016-02-16 Thread Ben Widawsky
On Tue, Feb 16, 2016 at 03:42:45PM -0800, Ben Widawsky wrote: > A new list yielded new devices that apparently have shipped, or will ship. > > v2: I can't read. 0x192d is GT3 > > Signed-off-by: Ben Widawsky > --- > intel/intel_chipset.h | 11 --- > 1 file

[Mesa-dev] [Bug 94175] ilo driver fail to load for intel mobile gm45 Express chipset

2016-02-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94175 --- Comment #2 from jydc...@21cn.com --- got it, thanks for reply. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___ mesa-dev mailing

Re: [Mesa-dev] [PATCH 2/5] android: radeonsi: fix building error in si_shader.c

2016-02-16 Thread Michel Dänzer
On 16.02.2016 20:03, Emil Velikov wrote: > On 16 February 2016 at 07:02, Michel Dänzer wrote: >> On 14.02.2016 23:41, Mauro Rossi wrote: >>> >>> From: Mauro Rossi > >>> Date: Sun, 14 Feb 2016 15:34:16 +0100 >>> Subject:

[Mesa-dev] [PATCH] anv: fix warning about unused width variable.

2016-02-16 Thread Dave Airlie
From: Dave Airlie We don't use width outside the debug clause here. --- src/vulkan/gen_pack_header.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/vulkan/gen_pack_header.py b/src/vulkan/gen_pack_header.py index 3cabb58..75c4f26 100755 ---

Re: [Mesa-dev] [PATCH] [v2] i965/skl: Add two missing device IDs

2016-02-16 Thread Ben Widawsky
On Wed, Feb 17, 2016 at 04:02:32AM +0200, Grazvydas Ignotas wrote: > On Wed, Feb 17, 2016 at 1:45 AM, Ben Widawsky > wrote: > > The Iris part is left unbranded because we did not have these with original > > SKL. > > > > v2: 0x192d is gt3, not gt4 > > The name and

Re: [Mesa-dev] [PATCH] [v2] i965/skl: Add two missing device IDs

2016-02-16 Thread Grazvydas Ignotas
On Wed, Feb 17, 2016 at 1:45 AM, Ben Widawsky wrote: > The Iris part is left unbranded because we did not have these with original > SKL. > > v2: 0x192d is gt3, not gt4 The name and description still don't agree. > > Cc: "11.0 11.1"

Re: [Mesa-dev] ANNOUNCE: An open-source Vulkan driver for Intel hardware

2016-02-16 Thread Jason Ekstrand
On Tue, Feb 16, 2016 at 1:21 PM, Olivier Galibert wrote: > Hi, > > I'm getting gpu hangs with the lunarg examples (cube and tri) on my > Haswell (64 bits). I attach /sys/class/drm/card0/error fwiw. How > should I go about debugging that? > It's a depth-stencil issue and

Re: [Mesa-dev] ANNOUNCE: An open-source Vulkan driver for Intel hardware

2016-02-16 Thread Connor Abbott
The first thing I would do is to try running it under valgrind and see if there are any errors. Make sure to have the valgrind development headers installed when building mesa, as anvil has a lot of special valgrind hooks builtin that it will only use if it finds the header during the build. On

[Mesa-dev] [PATCH] anv: fix Get*MemoryRequirements for !LLC

2016-02-16 Thread Connor Abbott
AFAIK buffers and images can be backed by coherent or non-coherent memory types. Found by inspection, only compile tested. Signed-off-by: Connor Abbott --- src/vulkan/anv_device.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git

[Mesa-dev] [PATCH] [v2] i965/skl: Add two missing device IDs

2016-02-16 Thread Ben Widawsky
The Iris part is left unbranded because we did not have these with original SKL. v2: 0x192d is gt3, not gt4 Cc: "11.0 11.1" --- include/pci_ids/i965_pci_ids.h | 2 ++ 1 file changed, 2 insertions(+)

[Mesa-dev] [PATCH] [v2] i965/skl: Update Skylake renderer strings

2016-02-16 Thread Ben Widawsky
Also adds some of the Iris/Pro parts which we previously didn't have named. v2: 0x192d is gt3, not gt4 Signed-off-by: Ben Widawsky --- include/pci_ids/i965_pci_ids.h | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git

[Mesa-dev] [PATCH] [v2] intel: Add missing SKL device IDs

2016-02-16 Thread Ben Widawsky
A new list yielded new devices that apparently have shipped, or will ship. v2: I can't read. 0x192d is GT3 Signed-off-by: Ben Widawsky --- intel/intel_chipset.h | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/intel/intel_chipset.h

[Mesa-dev] [PATCH] mesa: default DepthMode to GL_RED on ES 3.0

2016-02-16 Thread Ilia Mirkin
See commit 9db2098d which did it internally to the i965 driver. No reason not to have this more globally set though. This fixes depth in a bunch of dEQP EXT_texture_border_clamp tests. And probably other items as well. Signed-off-by: Ilia Mirkin Cc: Ian Romanick

[Mesa-dev] [PATCH] intel: Add missing SKL device IDs

2016-02-16 Thread Ben Widawsky
A new list yielded new devices that apparently have shipped, or will ship. Signed-off-by: Ben Widawsky --- intel/intel_chipset.h | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/intel/intel_chipset.h b/intel/intel_chipset.h index

[Mesa-dev] [PATCH 2/2] i965/skl: Update Skylake renderer strings

2016-02-16 Thread Ben Widawsky
Also adds some of the Iris/Pro parts which we previously didn't have named. Signed-off-by: Ben Widawsky --- include/pci_ids/i965_pci_ids.h | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/include/pci_ids/i965_pci_ids.h

[Mesa-dev] [PATCH 1/2] i965/skl: Add two missing device IDs

2016-02-16 Thread Ben Widawsky
The Iris part is left unbranded because we did not have these with original SKL. Cc: "11.0 11.1" --- include/pci_ids/i965_pci_ids.h | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [Mesa-dev] [PATCH] anv: pCreateInfo->pApplicationInfo parameter to vkCreateInstance may be NULL

2016-02-16 Thread Jason Ekstrand
On Tue, Feb 16, 2016 at 1:55 PM, Philipp Zabel wrote: > Fix a NULL pointer dereference in anv_CreateInstance in case > the pApplicationInfo field of the supplied VkInstanceCreateInfo > structure is NULL [1]. > > [1] >

Re: [Mesa-dev] [PATCH 05/10] postprocess: fix new gcc6 warnings

2016-02-16 Thread Matt Turner
On Tue, Feb 16, 2016 at 10:58 AM, Rob Clark wrote: > In file included from src/gallium/state_trackers/dri/dri_screen.h:44:0, > from src/gallium/state_trackers/dri/dri_query_renderer.c:7: > src/gallium/auxiliary/postprocess/filters.h:54:33: warning:

Re: [Mesa-dev] [PATCH 01/10] util: fix new gcc6 warnings

2016-02-16 Thread Matt Turner
On Tue, Feb 16, 2016 at 11:37 AM, Ian Romanick wrote: > On 02/16/2016 10:57 AM, Rob Clark wrote: >> src/util/hash_table.h:111:23: warning: ‘_mesa_fnv32_1a_offset_bias’ defined >> but not used [-Wunused-const-variable] >> static const uint32_t _mesa_fnv32_1a_offset_bias =

Re: [Mesa-dev] Where do we put a Vulkan driver?

2016-02-16 Thread Brian Paul
On 02/16/2016 02:41 PM, Dave Airlie wrote: On 17 February 2016 at 04:39, Jason Ekstrand wrote: So, we just pushed a branch containing a Vulkan driver. Naturally, we would like to incorporate that driver into the upstream mesa tree. While we work on upstreaming the

Re: [Mesa-dev] [PATCH] i965/gen7: Use predicated rendering for indirect compute

2016-02-16 Thread Ben Widawsky
On Tue, Feb 16, 2016 at 12:21:02PM -0800, Jordan Justen wrote: > On 2016-02-16 12:03:10, Ben Widawsky wrote: > > On Tue, Feb 16, 2016 at 10:09:50AM -0800, Jordan Justen wrote: > > > On gen7 (Ivy Bridge, Haswell), we will get a GPU hang if an indirect > > > dispatch is used, but one of the

[Mesa-dev] [PATCH] anv: pCreateInfo->pApplicationInfo parameter to vkCreateInstance may be NULL

2016-02-16 Thread Philipp Zabel
Fix a NULL pointer dereference in anv_CreateInstance in case the pApplicationInfo field of the supplied VkInstanceCreateInfo structure is NULL [1]. [1] https://www.khronos.org/registry/vulkan/specs/1.0/apispec.html#VkInstanceCreateInfo Signed-off-by: Philipp Zabel ---

Re: [Mesa-dev] Where do we put a Vulkan driver?

2016-02-16 Thread Dave Airlie
On 17 February 2016 at 04:39, Jason Ekstrand wrote: > So, we just pushed a branch containing a Vulkan driver. Naturally, we > would like to incorporate that driver into the upstream mesa tree. While > we work on upstreaming the prerequisites in NIR and the i965 back-end >

Re: [Mesa-dev] [PATCH] nvc0: add MP performance counters for SM35 (GK110:GM107)

2016-02-16 Thread Samuel Pitoiset
On 02/16/2016 10:04 PM, Ilia Mirkin wrote: On Tue, Feb 16, 2016 at 3:59 PM, Samuel Pitoiset wrote: static inline const struct nvc0_hw_sm_query_cfg ** nvc0_hw_sm_get_queries(struct nvc0_screen *screen) { + const struct nvc0_hw_sm_query_cfg **queries = NULL;

Re: [Mesa-dev] [PATCH] nvc0: add MP performance counters for SM35 (GK110:GM107)

2016-02-16 Thread Ilia Mirkin
On Tue, Feb 16, 2016 at 3:59 PM, Samuel Pitoiset wrote: > static inline const struct nvc0_hw_sm_query_cfg ** > nvc0_hw_sm_get_queries(struct nvc0_screen *screen) > { > + const struct nvc0_hw_sm_query_cfg **queries = NULL; > struct nouveau_device *dev =

[Mesa-dev] [PATCH] nvc0: add MP performance counters for SM35 (GK110:GM107)

2016-02-16 Thread Samuel Pitoiset
Because compute support is not enabled by default for these chipsets, NVF0_COMPUTE=1 needs to be used, along with GALLIUM_HUD to enable performance counters. Signed-off-by: Samuel Pitoiset --- .../drivers/nouveau/nvc0/nvc0_query_hw_sm.c| 755

Re: [Mesa-dev] [PATCH] Revert "i965: Restore vbo after color resolve during brw_try_draw_prims()"

2016-02-16 Thread Mark Janes
Ben Widawsky writes: > On Mon, Feb 15, 2016 at 11:34:03AM +0200, Topi Pohjolainen wrote: >> This got pushed accidentally in the first place but wasn't reverted >> as it didn't regress piglit but instead fixed one newly introduced >> test exercising a corner in case

Re: [Mesa-dev] [PATCH] st/mesa: add missing ETC2 entries to format_map

2016-02-16 Thread Ilia Mirkin
Sounds reasonable. The original patch is Reviewed-by: Ilia Mirkin On Tue, Feb 16, 2016 at 3:46 PM, Rob Clark wrote: > gave that a quick try.. and, well, I think that may just be the start > of the rabbit-hole.. > > 0xb69eb92c in __memcpy_neon () from

Re: [Mesa-dev] [PATCH] st/mesa: add missing ETC2 entries to format_map

2016-02-16 Thread Rob Clark
gave that a quick try.. and, well, I think that may just be the start of the rabbit-hole.. 0xb69eb92c in __memcpy_neon () from /lib/libc.so.6 (gdb) bt #0 0xb69eb92c in __memcpy_neon () from /lib/libc.so.6 #1 0xb5ea63e0 in _mesa_store_compressed_texsubimage (ctx=0x2ff970, dims=2,

[Mesa-dev] [Bug 94175] ilo driver fail to load for intel mobile gm45 Express chipset

2016-02-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94175 Timothy Arceri changed: What|Removed |Added Status|NEW |RESOLVED

Re: [Mesa-dev] [PATCH 08/10] glsl: fix new gcc6 warnings

2016-02-16 Thread Rob Clark
On Tue, Feb 16, 2016 at 2:32 PM, Ian Romanick wrote: > On 02/16/2016 10:58 AM, Rob Clark wrote: >> src/compiler/glsl/lower_discard_flow.cpp:79:1: warning: ‘ir_visitor_status >> {anonymous}::lower_discard_flow_visitor::visit_enter(ir_loop_jump*)’ defined >> but not used

Re: [Mesa-dev] [PATCH] i965/gen7: Use predicated rendering for indirect compute

2016-02-16 Thread Jordan Justen
On 2016-02-16 12:03:10, Ben Widawsky wrote: > On Tue, Feb 16, 2016 at 10:09:50AM -0800, Jordan Justen wrote: > > On gen7 (Ivy Bridge, Haswell), we will get a GPU hang if an indirect > > dispatch is used, but one of the dimensions is 0. > > > > Therefore we use predicated rendering on the

Re: [Mesa-dev] [PATCH] Revert "i965: Restore vbo after color resolve during brw_try_draw_prims()"

2016-02-16 Thread Ben Widawsky
On Mon, Feb 15, 2016 at 11:34:03AM +0200, Topi Pohjolainen wrote: > This got pushed accidentally in the first place but wasn't reverted > as it didn't regress piglit but instead fixed one newly introduced > test exercising a corner in case in i965 driver. However, saving and > restoring vertex

Re: [Mesa-dev] [PATCH] i965/gen7: Use predicated rendering for indirect compute

2016-02-16 Thread Ben Widawsky
On Tue, Feb 16, 2016 at 10:09:50AM -0800, Jordan Justen wrote: > On gen7 (Ivy Bridge, Haswell), we will get a GPU hang if an indirect > dispatch is used, but one of the dimensions is 0. > > Therefore we use predicated rendering on the GPGPU_WALKER command to > handle this case. > > Fixes piglit

Re: [Mesa-dev] [PATCH] glsl: set user defined varyings to smooth by default in ES

2016-02-16 Thread Ian Romanick
On 02/15/2016 11:26 PM, Iago Toral wrote: > On Tue, 2016-02-16 at 11:03 +1100, Timothy Arceri wrote: >> This is usually handled by the backends in order to handle the >> various interactions with the gl_*Color built-ins. >> >> The problem is this means linking will fail if one side on the >>

Re: [Mesa-dev] [PATCH 2/2] glsl: set user defined varyings to smooth by default

2016-02-16 Thread Ian Romanick
On 02/15/2016 07:12 AM, Iago Toral wrote: > On Mon, 2016-02-15 at 18:38 +1100, Timothy Arceri wrote: >> This is usually handled by the backends in order to handle the >> various interactions with the gl_*Color built-ins. >> >> The problem is this means linking will fail if one side on the >>

Re: [Mesa-dev] [PATCH 01/10] util: fix new gcc6 warnings

2016-02-16 Thread Rob Clark
On Tue, Feb 16, 2016 at 2:37 PM, Ian Romanick wrote: > On 02/16/2016 10:57 AM, Rob Clark wrote: >> src/util/hash_table.h:111:23: warning: ‘_mesa_fnv32_1a_offset_bias’ defined >> but not used [-Wunused-const-variable] >> static const uint32_t _mesa_fnv32_1a_offset_bias =

[Mesa-dev] [PATCH] mesa: add GL_OES_sample_shading support

2016-02-16 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- The dEQP tests expect this to enable per-sample interpolation, so I had to undo some of the changes in st/mesa from earlier to get it to pass. docs/GL3.txt| 2 +- src/mapi/glapi/gen/es_EXT.xml | 6 ++

Re: [Mesa-dev] [PATCH 01/10] util: fix new gcc6 warnings

2016-02-16 Thread Ian Romanick
On 02/16/2016 10:57 AM, Rob Clark wrote: > src/util/hash_table.h:111:23: warning: ‘_mesa_fnv32_1a_offset_bias’ defined > but not used [-Wunused-const-variable] > static const uint32_t _mesa_fnv32_1a_offset_bias = 2166136261u; >^~ > >

Re: [Mesa-dev] Where do we put a Vulkan driver?

2016-02-16 Thread Jason Ekstrand
On Tue, Feb 16, 2016 at 11:25 AM, Rob Clark wrote: > On Tue, Feb 16, 2016 at 1:39 PM, Jason Ekstrand > wrote: > > So, we just pushed a branch containing a Vulkan driver. Naturally, we > > would like to incorporate that driver into the upstream mesa

Re: [Mesa-dev] [PATCH 08/10] glsl: fix new gcc6 warnings

2016-02-16 Thread Ian Romanick
On 02/16/2016 10:58 AM, Rob Clark wrote: > src/compiler/glsl/lower_discard_flow.cpp:79:1: warning: ‘ir_visitor_status > {anonymous}::lower_discard_flow_visitor::visit_enter(ir_loop_jump*)’ defined > but not used [-Wunused-function] > lower_discard_flow_visitor::visit_enter(ir_loop_jump *ir) >

Re: [Mesa-dev] Where do we put a Vulkan driver?

2016-02-16 Thread Rob Clark
On Tue, Feb 16, 2016 at 1:39 PM, Jason Ekstrand wrote: > So, we just pushed a branch containing a Vulkan driver. Naturally, we > would like to incorporate that driver into the upstream mesa tree. While > we work on upstreaming the prerequisites in NIR and the i965 back-end

Re: [Mesa-dev] [PATCH 4/4] st/mesa: add OES_sample_variables support

2016-02-16 Thread Ilia Mirkin
On Tue, Feb 16, 2016 at 1:42 PM, Ian Romanick wrote: > On 02/16/2016 09:12 AM, Ilia Mirkin wrote: >> On Tue, Feb 16, 2016 at 12:02 PM, Ian Romanick wrote: >>> On 02/15/2016 10:31 PM, Ilia Mirkin wrote: Basically the same thing as

Re: [Mesa-dev] [PATCH 07/10] i965: fix new gcc6 warnings

2016-02-16 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick On 02/16/2016 10:58 AM, Rob Clark wrote: > src/mesa/drivers/dri/i965/brw_fs_copy_propagation.cpp:244:1: warning: > ‘void {anonymous}::fs_copy_prop_dataflow::dump_block_data() const’ defined > but not used [-Wunused-function] >

Re: [Mesa-dev] [PATCH 10/10] mesa: fix new gcc6 warnings

2016-02-16 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick On 02/16/2016 10:58 AM, Rob Clark wrote: > src/mesa/main/texstore.c:92:22: warning: ‘map_1032’ defined but not used > [-Wunused-const-variable] > static const GLubyte map_1032[6] = { 1, 0, 3, 2, ZERO, ONE }; >

Re: [Mesa-dev] [PATCH 09/10] glsl: fix new gcc6 warnings

2016-02-16 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick On 02/16/2016 10:58 AM, Rob Clark wrote: > src/compiler/glsl/ast_to_hir.cpp: In function ‘unsigned int > ast_process_struct_or_iface_block_members(exec_list*, > _mesa_glsl_parse_state*, exec_list*, glsl_struct_field**, bool, >

[Mesa-dev] [PATCH 06/10] freedreno/ir3: fix new gcc6 errors

2016-02-16 Thread Rob Clark
src/gallium/drivers/freedreno/ir3/ir3_compiler_nir.c: In function ‘emit_tex’: src/gallium/drivers/freedreno/ir3/ir3_compiler_nir.c:1368:26: warning: unused variable ‘const_off’ [-Wunused-variable] struct ir3_instruction *const_off[4]; ^ unused since: commit

[Mesa-dev] [PATCH 10/10] mesa: fix new gcc6 warnings

2016-02-16 Thread Rob Clark
src/mesa/main/texstore.c:92:22: warning: ‘map_1032’ defined but not used [-Wunused-const-variable] static const GLubyte map_1032[6] = { 1, 0, 3, 2, ZERO, ONE }; ^~~~ src/mesa/main/texstore.c:91:22: warning: ‘map_3210’ defined but not used [-Wunused-const-variable]

[Mesa-dev] [PATCH 05/10] postprocess: fix new gcc6 warnings

2016-02-16 Thread Rob Clark
In file included from src/gallium/state_trackers/dri/dri_screen.h:44:0, from src/gallium/state_trackers/dri/dri_query_renderer.c:7: src/gallium/auxiliary/postprocess/filters.h:54:33: warning: ‘pp_filters’ defined but not used [-Wunused-const-variable] static const struct

[Mesa-dev] [PATCH 04/10] trace: fix new gcc6 warnings

2016-02-16 Thread Rob Clark
src/gallium/drivers/trace/tr_context.c:1713:39: warning: ‘rbug_blocker_flags’ defined but not used [-Wunused-const-variable] static const struct debug_named_value rbug_blocker_flags[] = { ^~ Note that use of rbug_blocker_flags was removed

[Mesa-dev] [PATCH 07/10] i965: fix new gcc6 warnings

2016-02-16 Thread Rob Clark
src/mesa/drivers/dri/i965/brw_fs_copy_propagation.cpp:244:1: warning: ‘void {anonymous}::fs_copy_prop_dataflow::dump_block_data() const’ defined but not used [-Wunused-function] fs_copy_prop_dataflow::dump_block_data() const ^ From looking at git history, it looks like this

[Mesa-dev] [PATCH 08/10] glsl: fix new gcc6 warnings

2016-02-16 Thread Rob Clark
src/compiler/glsl/lower_discard_flow.cpp:79:1: warning: ‘ir_visitor_status {anonymous}::lower_discard_flow_visitor::visit_enter(ir_loop_jump*)’ defined but not used [-Wunused-function] lower_discard_flow_visitor::visit_enter(ir_loop_jump *ir) ^~ Note, not sure if this

[Mesa-dev] [PATCH 09/10] glsl: fix new gcc6 warnings

2016-02-16 Thread Rob Clark
src/compiler/glsl/ast_to_hir.cpp: In function ‘unsigned int ast_process_struct_or_iface_block_members(exec_list*, _mesa_glsl_parse_state*, exec_list*, glsl_struct_field**, bool, glsl_matrix_layout, bool, ir_variable_mode, ast_type_qualifier*, unsigned int, unsigned int)’:

[Mesa-dev] [PATCH 01/10] util: fix new gcc6 warnings

2016-02-16 Thread Rob Clark
src/util/hash_table.h:111:23: warning: ‘_mesa_fnv32_1a_offset_bias’ defined but not used [-Wunused-const-variable] static const uint32_t _mesa_fnv32_1a_offset_bias = 2166136261u; ^~ Signed-off-by: Rob Clark ---

[Mesa-dev] [PATCH 02/10] gallium/hud: fix new gcc6 warnings

2016-02-16 Thread Rob Clark
src/gallium/auxiliary/hud/font.c:234:22: warning: ‘Fixed8x13_Character_159’ defined but not used [-Wunused-const-variable] static const GLubyte Fixed8x13_Character_159[] = { 9, 0, 0, 0, 0, 0, 0,170, 0, 0, 0,130, 0, 0, 0,130, 0, 0, 0,130, 0, 0, 0,170, 0, 0, 0, 0, 0};

[Mesa-dev] [PATCH 00/10] Clean up most of the new gcc6 warnings

2016-02-16 Thread Rob Clark
From: Rob Clark gcc6 landed in rawhide, and all of a sudden building mesa got very noisy. This patchset cleans up most of the warnings (especially the first one which shows up everywhere that #includes hash_table.h) There are two remaining:

[Mesa-dev] [PATCH 03/10] gallium/auxiliary: fix new gcc6 warnings

2016-02-16 Thread Rob Clark
src/gallium/auxiliary/pipebuffer/pb_bufmgr_mm.c: In function ‘mm_bufmgr_create_from_buffer’: src/gallium/auxiliary/pipebuffer/pb_bufmgr_mm.c:288:4: warning: statement is indented as if it were guarded by... [-Wmisleading-indentation] if(mm->map) ^~

Re: [Mesa-dev] [PATCH 4/4] st/mesa: add OES_sample_variables support

2016-02-16 Thread Ian Romanick
On 02/16/2016 09:12 AM, Ilia Mirkin wrote: > On Tue, Feb 16, 2016 at 12:02 PM, Ian Romanick wrote: >> On 02/15/2016 10:31 PM, Ilia Mirkin wrote: >>> Basically the same thing as ARB_sample_shading except that it also needs >>> gl_SampleMaskIn support as well as not enable

[Mesa-dev] Where do we put a Vulkan driver?

2016-02-16 Thread Jason Ekstrand
So, we just pushed a branch containing a Vulkan driver. Naturally, we would like to incorporate that driver into the upstream mesa tree. While we work on upstreaming the prerequisites in NIR and the i965 back-end compiler, there is a question that needs answering: Where do we put it? The

Re: [Mesa-dev] [PATCH] st/mesa: use cso_set_viewport_dims() in try_pbo_upload_common()

2016-02-16 Thread Roland Scheidegger
Am 16.02.2016 um 18:01 schrieb Brian Paul: > Note that this results in a different transformation for the viewport's > Z axis (depth range), but that doesn't matter for this case. > --- > src/mesa/state_tracker/st_cb_texture.c | 13 + > 1 file changed, 1 insertion(+), 12 deletions(-)

[Mesa-dev] [PATCH] i965/gen7: Use predicated rendering for indirect compute

2016-02-16 Thread Jordan Justen
On gen7 (Ivy Bridge, Haswell), we will get a GPU hang if an indirect dispatch is used, but one of the dimensions is 0. Therefore we use predicated rendering on the GPGPU_WALKER command to handle this case. Fixes piglit test: spec/arb_compute_shader/zero-dispatch-size Bugzilla:

[Mesa-dev] [PATCH] configure.ac: enable_asm=yes when x-compiling across same X86 arch

2016-02-16 Thread Dongwon Kim
Currently, configure script is forcing 'enable_asm' to be 'no' whenever cross-compilation is performed on X86 host. This is based on an assumption that target architecture is different from host's (i.e. ARM). But there's always a case that we do cross-compilation for target that is also X86 based

Re: [Mesa-dev] [PATCH] gm107/ir: add ATOM CAS emission

2016-02-16 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Tue, Feb 16, 2016 at 12:53 PM, Samuel Pitoiset wrote: > From: Samuel Pitoiset > > This fixes the following dEQP test and the other compswap variants. > >

[Mesa-dev] [PATCH] gm107/ir: add ATOM CAS emission

2016-02-16 Thread Samuel Pitoiset
From: Samuel Pitoiset This fixes the following dEQP test and the other compswap variants. dEQP-GLES31.functional.ssbo.atomic.compswap.highp_int Signed-off-by: Samuel Pitoiset --- .../drivers/nouveau/codegen/nv50_ir_emit_gm107.cpp | 42

Re: [Mesa-dev] [PATCH 16/25] radeonsi: add PS prolog

2016-02-16 Thread Marek Olšák
On Tue, Feb 16, 2016 at 5:31 PM, Nicolai Hähnle wrote: > So, patches 12-16 also look good to me except for the comments I've sent on > 12-14. > > I'm a bit worried though that there is a lot of "almost code duplication" > around the handling of input and output positions etc.,

Re: [Mesa-dev] [PATCH] st/mesa: add missing ETC2 entries to format_map

2016-02-16 Thread Ilia Mirkin
Should be noted that, not at all due to this patch, glTexStorage(ETC1/ETC2) is broken on gallium drivers that don't implement those formats in HW (i.e. use the sw fallback). This patch makes it work for drivers that *do* support it in HW, but more work needed for the other drivers. Maybe we should

Re: [Mesa-dev] [PATCH 4/4] st/mesa: add OES_sample_variables support

2016-02-16 Thread Ilia Mirkin
On Tue, Feb 16, 2016 at 12:02 PM, Ian Romanick wrote: > On 02/15/2016 10:31 PM, Ilia Mirkin wrote: >> Basically the same thing as ARB_sample_shading except that it also needs >> gl_SampleMaskIn support as well as not enable per-sample interpolation >> whenever doing

Re: [Mesa-dev] [PATCH 11/25] radeonsi: first bits for non-monolithic shaders

2016-02-16 Thread Nicolai Hähnle
On 16.02.2016 11:39, Marek Olšák wrote: On Tue, Feb 16, 2016 at 5:01 PM, Nicolai Hähnle wrote: On 15.02.2016 18:59, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeonsi/si_pipe.c | 1 + src/gallium/drivers/radeonsi/si_pipe.h

[Mesa-dev] [PATCH] st/mesa: add missing ETC2 entries to format_map

2016-02-16 Thread Rob Clark
From: Rob Clark Noticed by Ilia when I was trying to figure out why some app was failing to use ETC2. Signed-off-by: Rob Clark Reviewed-by: Ilia Mirkin --- src/mesa/state_tracker/st_format.c | 42

Re: [Mesa-dev] [PATCH 24/25] gallium/radeon: remove unused radeon_shader_binary_free_* functions

2016-02-16 Thread Nicolai Hähnle
Patches 22-24 are also Reviewed-by: Nicolai Hähnle Very nice series overall! On 15.02.2016 18:59, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeon/radeon_elf_util.c | 19 ---

Re: [Mesa-dev] [PATCH 4/4] st/mesa: add OES_sample_variables support

2016-02-16 Thread Ian Romanick
On 02/15/2016 10:31 PM, Ilia Mirkin wrote: > Basically the same thing as ARB_sample_shading except that it also needs > gl_SampleMaskIn support as well as not enable per-sample interpolation > whenever doing per-sample shading. This is done explicitly in another > extension. > > Signed-off-by:

Re: [Mesa-dev] [PATCH 25/25] radeonsi: implement binary shaders & shader cache in memory

2016-02-16 Thread Nicolai Hähnle
On 15.02.2016 18:59, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeonsi/si_pipe.c | 5 +- src/gallium/drivers/radeonsi/si_pipe.h | 16 ++ src/gallium/drivers/radeonsi/si_shader.h| 4 +-

[Mesa-dev] [PATCH] st/mesa: use cso_set_viewport_dims() in try_pbo_upload_common()

2016-02-16 Thread Brian Paul
Note that this results in a different transformation for the viewport's Z axis (depth range), but that doesn't matter for this case. --- src/mesa/state_tracker/st_cb_texture.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_texture.c

Re: [Mesa-dev] [PATCH 14/25] radeonsi: add TCS epilog

2016-02-16 Thread Marek Olšák
On Tue, Feb 16, 2016 at 5:14 PM, Nicolai Hähnle wrote: > On 15.02.2016 18:59, Marek Olšák wrote: >> >> From: Marek Olšák >> >> --- >> src/gallium/drivers/radeonsi/si_pipe.c | 1 + >> src/gallium/drivers/radeonsi/si_pipe.h | 1 + >>

Re: [Mesa-dev] [PATCH 21/25] radeonsi: use smaller types for some si_shader members

2016-02-16 Thread Nicolai Hähnle
On 15.02.2016 18:59, Marek Olšák wrote: From: Marek Olšák in order to decrease the shader size for a shader cache. --- src/gallium/drivers/radeonsi/si_shader.c | 3 +++ src/gallium/drivers/radeonsi/si_shader.h | 6 +++--- 2 files changed, 6 insertions(+), 3

Re: [Mesa-dev] [PATCH] mesa: Don't call driver when there is no compute work

2016-02-16 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin (somehow I was sure this was done already... but apparently not.) On Tue, Feb 16, 2016 at 11:24 AM, Jordan Justen wrote: > The ARB_compute_shader spec says: > > "If the work group count in any dimension is zero, no

Re: [Mesa-dev] [PATCH 11/25] radeonsi: first bits for non-monolithic shaders

2016-02-16 Thread Marek Olšák
On Tue, Feb 16, 2016 at 5:01 PM, Nicolai Hähnle wrote: > On 15.02.2016 18:59, Marek Olšák wrote: >> >> From: Marek Olšák >> >> --- >> src/gallium/drivers/radeonsi/si_pipe.c | 1 + >> src/gallium/drivers/radeonsi/si_pipe.h | 3 ++ >>

Re: [Mesa-dev] [PATCH 13/25] radeonsi: add VS epilog

2016-02-16 Thread Marek Olšák
On Tue, Feb 16, 2016 at 5:12 PM, Nicolai Hähnle wrote: > On 15.02.2016 18:59, Marek Olšák wrote: >> >> From: Marek Olšák >> >> It only exports the primitive ID. >> Also used by TES when it's compiled as VS. >> >> The VS input location of the primitive ID

Re: [Mesa-dev] [PATCH] mesa: add GL_OES_texture_border_clamp support

2016-02-16 Thread Ilia Mirkin
On Tue, Feb 16, 2016 at 11:24 AM, Ian Romanick wrote: > On 02/15/2016 04:14 PM, Ilia Mirkin wrote: >> Only minor differences to the existing ARB_texture_border_clamp support. >> >> Signed-off-by: Ilia Mirkin >> --- >> >> I get 53 failures (and 548

Re: [Mesa-dev] [PATCH v2] egl/wayland: Try to use wl_surface.damage_buffer for SwapBuffersWithDamage

2016-02-16 Thread Daniel Stone
Hi, On 16 February 2016 at 16:34, Derek Foreman wrote: > +try_damage_buffer(struct dri2_egl_surface *dri2_surf, > + const EGLint *rects, > + EGLint n_rects) > +{ > +/* The WL_SURFACE_DAMAGE_BUFFER_SINCE_VERSION macro and > + *

Re: [Mesa-dev] intel skylake gpu support

2016-02-16 Thread Jarkko Korpi
Well I have few years of linux experience, but I find this system still so new to me when it comes to modifying system files (or something similar). Got 17.3 Mint here and oibaf ppa for mesa. I used this for r9 290 radeon, but I am upgrading that card. Meanwhile I noticed that I can really play

[Mesa-dev] [PATCH v2] egl/wayland: Try to use wl_surface.damage_buffer for SwapBuffersWithDamage

2016-02-16 Thread Derek Foreman
Since commit d1314de293e9e4a63c35f094c3893aaaed8580b4 we ignore damage passed to SwapBuffersWithDamage. Wayland 1.10 now has functionality that allows us to properly process those damage rectangles, and a way to query if it's available. Now we can use wl_surface.damage_buffer and interpret the

Re: [Mesa-dev] intel skylake gpu support

2016-02-16 Thread Rob Clark
On Tue, Feb 16, 2016 at 11:09 AM, Ben Widawsky wrote: > On Tue, Feb 16, 2016 at 10:39:23AM -0500, Rob Clark wrote: >> Try xf86-video-modesetting instead of xf86-video-intel.. > > Might I inquire the thought behind this? It's my impression that unless one is > using glamor,

Re: [Mesa-dev] [PATCH 16/25] radeonsi: add PS prolog

2016-02-16 Thread Nicolai Hähnle
So, patches 12-16 also look good to me except for the comments I've sent on 12-14. I'm a bit worried though that there is a lot of "almost code duplication" around the handling of input and output positions etc., and maintaining the two different code paths for monolithic and non-monolithic

Re: [Mesa-dev] intel skylake gpu support

2016-02-16 Thread Eero Tamminen
Hi, On 16.02.2016 09:24, Jarkko Korpi wrote: Then the other question. My cpu is skylake 6600k which has powersaving on that it drops its speed when not doing much. It can drop cores at 800mhz. Most of youtube videos if not all are in vp9 format, that's the info I get when i look at the video

[Mesa-dev] [PATCH] mesa: Don't call driver when there is no compute work

2016-02-16 Thread Jordan Justen
The ARB_compute_shader spec says: "If the work group count in any dimension is zero, no work groups are dispatched." Signed-off-by: Jordan Justen --- src/mesa/main/compute.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/main/compute.c

Re: [Mesa-dev] [PATCH] mesa: add GL_OES_texture_border_clamp support

2016-02-16 Thread Ian Romanick
On 02/15/2016 04:14 PM, Ilia Mirkin wrote: > Only minor differences to the existing ARB_texture_border_clamp support. > > Signed-off-by: Ilia Mirkin > --- > > I get 53 failures (and 548 passes) in the dEQP tests, they appear to expect > all-red for depth texturing while

Re: [Mesa-dev] [PATCH 14/25] radeonsi: add TCS epilog

2016-02-16 Thread Nicolai Hähnle
On 15.02.2016 18:59, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeonsi/si_pipe.c | 1 + src/gallium/drivers/radeonsi/si_pipe.h | 1 + src/gallium/drivers/radeonsi/si_shader.c | 163 ---

Re: [Mesa-dev] [PATCH 13/25] radeonsi: add VS epilog

2016-02-16 Thread Nicolai Hähnle
On 15.02.2016 18:59, Marek Olšák wrote: From: Marek Olšák It only exports the primitive ID. Also used by TES when it's compiled as VS. The VS input location of the primitive ID input is v2. So the reason for having two unused outputs/return values of the main VS is so

Re: [Mesa-dev] [PATCH 09/25] radeonsi: add code for combining and uploading shaders from 3 shader parts

2016-02-16 Thread Nicolai Hähnle
On 16.02.2016 11:10, Marek Olšák wrote: On Tue, Feb 16, 2016 at 4:53 PM, Nicolai Hähnle wrote: On 15.02.2016 18:59, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c | 35

Re: [Mesa-dev] [PATCH 09/25] radeonsi: add code for combining and uploading shaders from 3 shader parts

2016-02-16 Thread Marek Olšák
On Tue, Feb 16, 2016 at 4:53 PM, Nicolai Hähnle wrote: > On 15.02.2016 18:59, Marek Olšák wrote: >> >> From: Marek Olšák >> >> --- >> src/gallium/drivers/radeonsi/si_shader.c | 35 >> >>

Re: [Mesa-dev] intel skylake gpu support

2016-02-16 Thread Ben Widawsky
On Tue, Feb 16, 2016 at 10:39:23AM -0500, Rob Clark wrote: > Try xf86-video-modesetting instead of xf86-video-intel.. Might I inquire the thought behind this? It's my impression that unless one is using glamor, modesetting won't ever outperform xf86-video-intel (which defaults to the hardware

Re: [Mesa-dev] [PATCH 12/25] radeonsi: add VS prolog

2016-02-16 Thread Nicolai Hähnle
On 15.02.2016 18:59, Marek Olšák wrote: From: Marek Olšák This is disabled with use_monolithic_shaders = true. --- src/gallium/drivers/radeonsi/si_pipe.c | 19 +++ src/gallium/drivers/radeonsi/si_pipe.h | 3 + src/gallium/drivers/radeonsi/si_shader.c | 236

Re: [Mesa-dev] [PATCH 11/25] radeonsi: first bits for non-monolithic shaders

2016-02-16 Thread Nicolai Hähnle
On 15.02.2016 18:59, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeonsi/si_pipe.c | 1 + src/gallium/drivers/radeonsi/si_pipe.h | 3 ++ src/gallium/drivers/radeonsi/si_shader.c | 53

Re: [Mesa-dev] [PATCH 09/25] radeonsi: add code for combining and uploading shaders from 3 shader parts

2016-02-16 Thread Nicolai Hähnle
On 15.02.2016 18:59, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c | 35 src/gallium/drivers/radeonsi/si_shader.h | 9 2 files changed, 36 insertions(+), 8 deletions(-) diff --git

  1   2   >