[Mesa-dev] [Bug 95005] Unreal engine demos segfault after shader compilation error with OpenGL 4.3

2016-04-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95005 Michel Dänzer changed: What|Removed |Added CC|

Re: [Mesa-dev] [PATCH] loader: add a libdrm case for loader_get_device_name_for_fd

2016-04-18 Thread Jonathan Gray
Any objections to this? On Mon, Dec 21, 2015 at 04:39:55PM +1100, Jonathan Gray wrote: > Use dev_node_from_fd() with HAVE_LIBDRM to provide an implmentation > of loader_get_device_name_for_fd() for non-linux systems that > use libdrm but don't have udev or sysfs. > > Signed-off-by: Jonathan Gray

Re: [Mesa-dev] [PATCH] configure.ac: fix the --disable-llvm-shared-libs build

2016-04-18 Thread Jonathan Gray
This patch is still required for master. On Sun, Feb 28, 2016 at 02:47:03PM +1100, Jonathan Gray wrote: > When building with --disable-llvm-shared-libs use llvm-config --libfiles > instead of of --libs so the full path to the .a files is used instead of > -lname. > > Otherwise at install time

Re: [Mesa-dev] [PATCH 05/18] anv/cmd_buffer: Use the new emit macro for DEPTH/STENCIL_BUFFER

2016-04-18 Thread Jason Ekstrand
On Mon, Apr 18, 2016 at 5:37 PM, Ian Romanick wrote: > On 04/18/2016 05:10 PM, Jason Ekstrand wrote: > > --- > > src/intel/vulkan/genX_cmd_buffer.c | 76 > +- > > 1 file changed, 42 insertions(+), 34 deletions(-) > > > > diff --git

[Mesa-dev] [PATCH] i965/tiled_memcpy: don't unconditionally use __builtin_bswap32

2016-04-18 Thread Jonathan Gray
Use the defines Mesa configure sets to indicate presence of the bswap32 builtins. This lets i965 work on OpenBSD again after the changes that were made in 0a5d8d9af42fd77fce1492d55f958da97816961a. Signed-off-by: Jonathan Gray --- src/mesa/drivers/dri/i965/intel_tiled_memcpy.c |

Re: [Mesa-dev] [PATCH 07/18] anv/cmd_buffer: Use the new emit macro for compute shader dispatch

2016-04-18 Thread Jason Ekstrand
On Mon, Apr 18, 2016 at 5:30 PM, Ian Romanick wrote: > On 04/18/2016 05:10 PM, Jason Ekstrand wrote: > > --- > > src/intel/vulkan/genX_cmd_buffer.c | 116 > - > > 1 file changed, 64 insertions(+), 52 deletions(-) > > > > diff --git

[Mesa-dev] [PATCH] egl/x11: authenticate before doing chipset id ioctls

2016-04-18 Thread Jonathan Gray
For systems without udev or sysfs that use drm ioctls in the loader drm authentication must take place earlier or the loader will fail "MESA-LOADER: failed to get param for i915". Patch from Mark Kettenis. Cc: "11.2 11.1" Signed-off-by: Mark Kettenis

Re: [Mesa-dev] [PATCH 01/18] anv: Add a short style guide

2016-04-18 Thread Jason Ekstrand
On Mon, Apr 18, 2016 at 5:35 PM, Ian Romanick wrote: > On 04/18/2016 05:10 PM, Jason Ekstrand wrote: > > --- > > src/intel/vulkan/STYLE | 67 > ++ > > 1 file changed, 67 insertions(+) > > create mode 100644

[Mesa-dev] [PATCH 2/5] anv/apply_dynamic_offsets: Provide a range on the load_uniform

2016-04-18 Thread Jason Ekstrand
--- src/intel/vulkan/anv_nir_apply_dynamic_offsets.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_nir_apply_dynamic_offsets.c b/src/intel/vulkan/anv_nir_apply_dynamic_offsets.c index 234855c..06fe8aa 100644 ---

[Mesa-dev] [PATCH 3/5] i965/vec4: Use nir_intrinsic_base in the load_uniform implementation

2016-04-18 Thread Jason Ekstrand
We shouldn't be reading the const_index directly --- src/mesa/drivers/dri/i965/brw_vec4_nir.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4_nir.cpp b/src/mesa/drivers/dri/i965/brw_vec4_nir.cpp index e199d96..b5c23c9 100644 ---

[Mesa-dev] [PATCH 4/5] i965/vec4: Use the correct offset for the swizzle shift in push constants

2016-04-18 Thread Jason Ekstrand
This was actually caught by Ken in review the first time around but somehow didn't get fixed before the patches were pushed. :-( --- src/mesa/drivers/dri/i965/brw_vec4_nir.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4_nir.cpp

[Mesa-dev] [PATCH 5/5] i965/vec4: Always split uniforms in array_access_to_pull_constants

2016-04-18 Thread Jason Ekstrand
Normally, we split uniforms at the end but in Vulkan, we bail because we don't want pull constants. However, we still need them split because pack_uniforms relies on it. I really don't like this patch not because it doesn't work (it does) but because now that we're using MOV_INDIRECT, uniform

[Mesa-dev] [PATCH 1/5] anv/lower_push_constants: Stop treating scalar specially

2016-04-18 Thread Jason Ekstrand
All of the code that did something special based on vec4 vs. scalar is bogus. In the backend, everything is now in units of bytes and the vec4 backend can handle full std140 packing so we don't need to do anything special anymore. --- src/intel/vulkan/anv_nir.h | 2 +-

Re: [Mesa-dev] [PATCH 01/18] anv: Add a short style guide

2016-04-18 Thread Ian Romanick
On 04/18/2016 05:56 PM, Dave Airlie wrote: > On 19 April 2016 at 10:35, Ian Romanick wrote: >> On 04/18/2016 05:10 PM, Jason Ekstrand wrote: >>> --- >>> src/intel/vulkan/STYLE | 67 >>> ++ >>> 1 file changed, 67 insertions(+)

Re: [Mesa-dev] [PATCH 01/18] anv: Add a short style guide

2016-04-18 Thread Dave Airlie
On 19 April 2016 at 10:35, Ian Romanick wrote: > On 04/18/2016 05:10 PM, Jason Ekstrand wrote: >> --- >> src/intel/vulkan/STYLE | 67 >> ++ >> 1 file changed, 67 insertions(+) >> create mode 100644 src/intel/vulkan/STYLE >>

Re: [Mesa-dev] [PATCH 4/4] i965: Properly handle integer types in opt_vector_float().

2016-04-18 Thread Kenneth Graunke
On Monday, April 18, 2016 11:50:53 AM PDT Matt Turner wrote: > On Sun, Apr 17, 2016 at 11:14 PM, Kenneth Graunke wrote: > > Previously, opt_vector_float() always interpreted MOV sources as > > floating point, and always created a MOV with a F-type destination. > > > > This

Re: [Mesa-dev] [PATCH] glsl: do not raise uninitialized variable warning with gl_GlobalInvocationID/gl_LocalInvocationIndex

2016-04-18 Thread Timothy Arceri
On Mon, 2016-04-18 at 17:12 -0700, Ian Romanick wrote: > Since the whole gl_* namespace is reserved, it might be better / > easier > to strncmp(var->name, "gl_", 3) instead. We even have a helper is_gl_identifier() > > On 03/31/2016 02:48 AM, Alejandro Piñeiro wrote: > > > > Most GLSL

Re: [Mesa-dev] [PATCH 05/18] anv/cmd_buffer: Use the new emit macro for DEPTH/STENCIL_BUFFER

2016-04-18 Thread Ian Romanick
On 04/18/2016 05:10 PM, Jason Ekstrand wrote: > --- > src/intel/vulkan/genX_cmd_buffer.c | 76 > +- > 1 file changed, 42 insertions(+), 34 deletions(-) > > diff --git a/src/intel/vulkan/genX_cmd_buffer.c > b/src/intel/vulkan/genX_cmd_buffer.c > index

Re: [Mesa-dev] [PATCH 01/18] anv: Add a short style guide

2016-04-18 Thread Ian Romanick
On 04/18/2016 05:10 PM, Jason Ekstrand wrote: > --- > src/intel/vulkan/STYLE | 67 > ++ > 1 file changed, 67 insertions(+) > create mode 100644 src/intel/vulkan/STYLE > > diff --git a/src/intel/vulkan/STYLE b/src/intel/vulkan/STYLE > new file

Re: [Mesa-dev] [PATCH 07/18] anv/cmd_buffer: Use the new emit macro for compute shader dispatch

2016-04-18 Thread Ian Romanick
On 04/18/2016 05:10 PM, Jason Ekstrand wrote: > --- > src/intel/vulkan/genX_cmd_buffer.c | 116 > - > 1 file changed, 64 insertions(+), 52 deletions(-) > > diff --git a/src/intel/vulkan/genX_cmd_buffer.c > b/src/intel/vulkan/genX_cmd_buffer.c > index

Re: [Mesa-dev] [PATCH 02/18] anv: Add a new block-based batch emit macro

2016-04-18 Thread Ian Romanick
On 04/18/2016 05:19 PM, Ian Romanick wrote: > On 04/18/2016 05:10 PM, Jason Ekstrand wrote: >> This new macro uses a for loop to create an actual code block in which to >> place the macro setup code. One advantage of this is that you syntatically >

[Mesa-dev] [PATCH] glsl: add forgotten textureOffset function for sampler2DArrayShadow

2016-04-18 Thread sroland
From: Roland Scheidegger This was part of EXT_gpu_shader4 - as such it should have been supported by glsl 130. It was however forgotten, and not added until glsl 430 - with the wrong syntax no less (glsl 430 mentions it was overlooked). glsl 440 (but revision 8 only) fixed

Re: [Mesa-dev] [PATCH 01/18] anv: Add a short style guide

2016-04-18 Thread Matt Turner
On Mon, Apr 18, 2016 at 5:10 PM, Jason Ekstrand wrote: > --- > src/intel/vulkan/STYLE | 67 > ++ > 1 file changed, 67 insertions(+) > create mode 100644 src/intel/vulkan/STYLE > > diff --git a/src/intel/vulkan/STYLE

Re: [Mesa-dev] [PATCH 02/18] anv: Add a new block-based batch emit macro

2016-04-18 Thread Ian Romanick
On 04/18/2016 05:10 PM, Jason Ekstrand wrote: > This new macro uses a for loop to create an actual code block in which to > place the macro setup code. One advantage of this is that you syntatically syntactically > use braces

Re: [Mesa-dev] [PATCH 1/2] i965/vec4: Lower integer multiplication after optimizations.

2016-04-18 Thread Matt Turner
On Mon, Apr 18, 2016 at 5:08 PM, Ian Romanick wrote: > On 04/18/2016 04:14 PM, Matt Turner wrote: >> Analogous to commit 1e4e17fbd in the i965/fs backend. >> >> Because the copy propagation pass in the vec4 backend is strictly local, >> we look at the immediate values coming

Re: [Mesa-dev] [PATCH] glsl: do not raise uninitialized variable warning with gl_GlobalInvocationID/gl_LocalInvocationIndex

2016-04-18 Thread Ian Romanick
Since the whole gl_* namespace is reserved, it might be better / easier to strncmp(var->name, "gl_", 3) instead. On 03/31/2016 02:48 AM, Alejandro Piñeiro wrote: > Most GLSL built-ins variables are filtered out because they have > the mode ir_var_system_value, but those two not. Those two are >

[Mesa-dev] [PATCH 05/18] anv/cmd_buffer: Use the new emit macro for DEPTH/STENCIL_BUFFER

2016-04-18 Thread Jason Ekstrand
--- src/intel/vulkan/genX_cmd_buffer.c | 76 +- 1 file changed, 42 insertions(+), 34 deletions(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c index 932ba65..713de82 100644 --- a/src/intel/vulkan/genX_cmd_buffer.c +++

[Mesa-dev] [PATCH 02/18] anv: Add a new block-based batch emit macro

2016-04-18 Thread Jason Ekstrand
This new macro uses a for loop to create an actual code block in which to place the macro setup code. One advantage of this is that you syntatically use braces instead of parentheses. Another is that the code in the block doesn't even get executed if anv_batch_emit_dwords fails. ---

[Mesa-dev] [PATCH 14/18] anv/device: Use the new emit macro

2016-04-18 Thread Jason Ekstrand
--- src/intel/vulkan/anv_batch_chain.c | 17 + src/intel/vulkan/anv_device.c | 8 2 files changed, 13 insertions(+), 12 deletions(-) diff --git a/src/intel/vulkan/anv_batch_chain.c b/src/intel/vulkan/anv_batch_chain.c index 034f3fd..3bf0cd0 100644 ---

[Mesa-dev] [PATCH 15/18] anv/gen7_cmd_buffer: Use the new emit macro

2016-04-18 Thread Jason Ekstrand
--- src/intel/vulkan/gen7_cmd_buffer.c | 122 + 1 file changed, 70 insertions(+), 52 deletions(-) diff --git a/src/intel/vulkan/gen7_cmd_buffer.c b/src/intel/vulkan/gen7_cmd_buffer.c index 5130a40..88964da 100644 --- a/src/intel/vulkan/gen7_cmd_buffer.c +++

[Mesa-dev] [PATCH 03/18] anv/cmd_buffer: Use the new emit macro for 3DPRIMITIVE commands

2016-04-18 Thread Jason Ekstrand
--- src/intel/vulkan/genX_cmd_buffer.c | 52 -- 1 file changed, 28 insertions(+), 24 deletions(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c index d642832..b21ff97 100644 --- a/src/intel/vulkan/genX_cmd_buffer.c +++

[Mesa-dev] [PATCH 01/18] anv: Add a short style guide

2016-04-18 Thread Jason Ekstrand
--- src/intel/vulkan/STYLE | 67 ++ 1 file changed, 67 insertions(+) create mode 100644 src/intel/vulkan/STYLE diff --git a/src/intel/vulkan/STYLE b/src/intel/vulkan/STYLE new file mode 100644 index 000..4eb8f79 --- /dev/null +++

[Mesa-dev] [PATCH 10/18] anv/gen8_cmd_buffer: Use the new emit macro

2016-04-18 Thread Jason Ekstrand
--- src/intel/vulkan/gen8_cmd_buffer.c | 161 - 1 file changed, 87 insertions(+), 74 deletions(-) diff --git a/src/intel/vulkan/gen8_cmd_buffer.c b/src/intel/vulkan/gen8_cmd_buffer.c index 3956a58..96ef846 100644 --- a/src/intel/vulkan/gen8_cmd_buffer.c +++

[Mesa-dev] [PATCH 12/18] anv/gen8_pipeline: Use the new emit macro

2016-04-18 Thread Jason Ekstrand
--- src/intel/vulkan/gen8_pipeline.c | 368 --- 1 file changed, 191 insertions(+), 177 deletions(-) diff --git a/src/intel/vulkan/gen8_pipeline.c b/src/intel/vulkan/gen8_pipeline.c index 6f6868e..f4224e0 100644 --- a/src/intel/vulkan/gen8_pipeline.c +++

[Mesa-dev] [PATCH 09/18] anv/cmd_buffer: Use the new emit macro for quaries

2016-04-18 Thread Jason Ekstrand
--- src/intel/vulkan/genX_cmd_buffer.c | 56 ++ 1 file changed, 32 insertions(+), 24 deletions(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c index abf0961..5c00b1d 100644 --- a/src/intel/vulkan/genX_cmd_buffer.c +++

[Mesa-dev] [PATCH 16/18] anv/gen7_pipeline: Use the new emit macro

2016-04-18 Thread Jason Ekstrand
--- src/intel/vulkan/gen7_pipeline.c | 237 --- 1 file changed, 124 insertions(+), 113 deletions(-) diff --git a/src/intel/vulkan/gen7_pipeline.c b/src/intel/vulkan/gen7_pipeline.c index d6d5ce6..62e43ad 100644 --- a/src/intel/vulkan/gen7_pipeline.c +++

[Mesa-dev] [PATCH 17/18] anv: Remove the old emit macro

2016-04-18 Thread Jason Ekstrand
--- src/intel/vulkan/anv_private.h | 10 -- 1 file changed, 10 deletions(-) diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_private.h index d59b7ed..a682587 100644 --- a/src/intel/vulkan/anv_private.h +++ b/src/intel/vulkan/anv_private.h @@ -829,16 +829,6 @@

[Mesa-dev] [PATCH 07/18] anv/cmd_buffer: Use the new emit macro for compute shader dispatch

2016-04-18 Thread Jason Ekstrand
--- src/intel/vulkan/genX_cmd_buffer.c | 116 - 1 file changed, 64 insertions(+), 52 deletions(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c index 45b009b..4a75825 100644 --- a/src/intel/vulkan/genX_cmd_buffer.c +++

[Mesa-dev] [PATCH 04/18] anv/cmd_buffer: Use the new emit macro for PIPE_CONTROL and STATE_BASE_ADDRESS

2016-04-18 Thread Jason Ekstrand
--- src/intel/vulkan/genX_cmd_buffer.c | 138 - 1 file changed, 76 insertions(+), 62 deletions(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c index b21ff97..932ba65 100644 --- a/src/intel/vulkan/genX_cmd_buffer.c +++

[Mesa-dev] [PATCH 18/18] anv: s/anv_batch_emit_blk/anv_batch_emit/

2016-04-18 Thread Jason Ekstrand
--- src/intel/vulkan/anv_batch_chain.c| 6 +-- src/intel/vulkan/anv_device.c | 8 ++-- src/intel/vulkan/anv_private.h| 2 +- src/intel/vulkan/gen7_cmd_buffer.c| 39 src/intel/vulkan/gen7_pipeline.c | 27 ++-

[Mesa-dev] [PATCH 06/18] anv/cmd_buffer: Use the new emit macro for 3DSTATE_CONSTANT

2016-04-18 Thread Jason Ekstrand
--- src/intel/vulkan/genX_cmd_buffer.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c index 713de82..45b009b 100644 --- a/src/intel/vulkan/genX_cmd_buffer.c +++

[Mesa-dev] [PATCH 08/18] anv/cmd_buffer: Use the new emit macro for DRAWING_RECTANGLE

2016-04-18 Thread Jason Ekstrand
--- src/intel/vulkan/genX_cmd_buffer.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c index 4a75825..abf0961 100644 --- a/src/intel/vulkan/genX_cmd_buffer.c +++

[Mesa-dev] [PATCH 11/18] anv/genX_pipeline: Use the new emit macro

2016-04-18 Thread Jason Ekstrand
--- src/intel/vulkan/genX_pipeline.c | 25 +++ src/intel/vulkan/genX_pipeline_util.h | 58 +++ 2 files changed, 45 insertions(+), 38 deletions(-) diff --git a/src/intel/vulkan/genX_pipeline.c b/src/intel/vulkan/genX_pipeline.c index

[Mesa-dev] [PATCH 13/18] anv/state: Use the new emit macro

2016-04-18 Thread Jason Ekstrand
--- src/intel/vulkan/genX_state.c | 155 +- 1 file changed, 78 insertions(+), 77 deletions(-) diff --git a/src/intel/vulkan/genX_state.c b/src/intel/vulkan/genX_state.c index 900f6dc..b997e1b 100644 --- a/src/intel/vulkan/genX_state.c +++

[Mesa-dev] [PATCH 00/18] anv: Switch to a new emit macro

2016-04-18 Thread Jason Ekstrand
The first patch in this series adds a short style guide for the Vulkan driver. The rest adds a new emit macro and updates the entire driver to use it and, while we're there, makes the style more consistent. Jason Ekstrand (18): anv: Add a short style guide anv: Add a new block-based batch

Re: [Mesa-dev] [PATCH 1/2] i965/vec4: Lower integer multiplication after optimizations.

2016-04-18 Thread Ian Romanick
On 04/18/2016 04:14 PM, Matt Turner wrote: > Analogous to commit 1e4e17fbd in the i965/fs backend. > > Because the copy propagation pass in the vec4 backend is strictly local, > we look at the immediate values coming from NIR and emit the multiplies > we need directly. If the copy propagation

Re: [Mesa-dev] [PATCH] glsl: add forgotten textureOffset function for sampler2DArrayShadow

2016-04-18 Thread Roland Scheidegger
Am 19.04.2016 um 00:43 schrieb Ian Romanick: > On 04/18/2016 02:05 PM, srol...@vmware.com wrote: >> From: Roland Scheidegger >> >> This was part of EXT_gpu_shader4 - as such it should have been supported >> by glsl 130. >> It was however forgotten, and not added until glsl 430

Re: [Mesa-dev] [PATCH 4/4] i965: Properly handle integer types in opt_vector_float().

2016-04-18 Thread Kenneth Graunke
On Monday, April 18, 2016 4:20:50 PM PDT Iago Toral wrote: > On Sun, 2016-04-17 at 23:14 -0700, Kenneth Graunke wrote: > > Previously, opt_vector_float() always interpreted MOV sources as > > floating point, and always created a MOV with a F-type destination. > > > > This meant that we could mess

[Mesa-dev] [PATCH v3 1/2] radeonsi: do not do two full flushes on every compute dispatch

2016-04-18 Thread Bas Nieuwenhuizen
v2: Add more CS_PARTIAL_FLUSH events. Essentially every place with waits on finishing for pixel shaders also has a write after read hazard with compute shaders. Invalidating L2 waits implicitly on pixel and compute shaders, so, we don't need a CS_PARTIAL_FLUSH for switching FBO. v3: Add

Re: [Mesa-dev] [PATCH 3/4] [rfc] gallivm/llvmpipe dynamic samplers support.

2016-04-18 Thread Roland Scheidegger
Am 18.04.2016 um 23:10 schrieb Dave Airlie: > On 19 April 2016 at 03:40, Roland Scheidegger wrote: >> Am 18.04.2016 um 04:49 schrieb Dave Airlie: >>> From: Dave Airlie >>> >>> This is a first attempt at adding support for dynamic indexing >>> of samplers

[Mesa-dev] [PATCH v3 0/2] Remainder radeonsi compute patches.

2016-04-18 Thread Bas Nieuwenhuizen
I added some CS_PARTIAL_FLUSH events after MArek's response. I haven't been able to detect anything wrong without them. However at least theoretically some event has to wait on CS shaders at the new points.(e.g fbo change clearly has a potential write after read hazard otherwise). I also

[Mesa-dev] [PATCH v3 2/2] radeonsi: enable TGSI support cap for compute shaders

2016-04-18 Thread Bas Nieuwenhuizen
v2: Use chip_class instead of family. v3: Check kernel version for SI. Signed-off-by: Bas Nieuwenhuizen --- docs/GL3.txt | 4 ++-- docs/relnotes/11.3.0.html | 1 + src/gallium/drivers/radeon/r600_pipe_common.c |

[Mesa-dev] [PATCH 1/2] i965/vec4: Lower integer multiplication after optimizations.

2016-04-18 Thread Matt Turner
Analogous to commit 1e4e17fbd in the i965/fs backend. Because the copy propagation pass in the vec4 backend is strictly local, we look at the immediate values coming from NIR and emit the multiplies we need directly. If the copy propagation pass becomes smarter in the future, we can reduce the

[Mesa-dev] [PATCH] swr: fix resource backed constant buffers

2016-04-18 Thread Tim Rowley
Code was using an incorrect address for the base pointer. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94979 --- src/gallium/drivers/swr/swr_state.cpp | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/swr/swr_state.cpp

[Mesa-dev] [PATCH 2/2] i965/vec4: Unrestrict constant propagation into integer multiply.

2016-04-18 Thread Matt Turner
Analogous to commit 81deefc45b in the i965/fs backend. --- No shader-db changes because the vec4 copy propagation pass is local-only. src/mesa/drivers/dri/i965/brw_vec4_copy_propagation.cpp | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH] glsl: Checks for interpolation into its own function.

2016-04-18 Thread Timothy Arceri
On Mon, 2016-04-18 at 19:44 +0300, Andres Gomez wrote: > Hi, > > I would really appreciate if you could find some time to review this > patch. Is there a patch somewhere that makes use of this change?  > > Thanks! > > On Mon, 2016-04-04 at 19:50 +0300, Andres Gomez wrote: > > > > This

Re: [Mesa-dev] [PATCH] glsl: add forgotten textureOffset function for sampler2DArrayShadow

2016-04-18 Thread Ian Romanick
On 04/18/2016 02:05 PM, srol...@vmware.com wrote: > From: Roland Scheidegger > > This was part of EXT_gpu_shader4 - as such it should have been supported > by glsl 130. > It was however forgotten, and not added until glsl 430 - with the wrong > syntax no less (glsl 430

Re: [Mesa-dev] [PATCH] radeonsi: enable GLSL 4.30 and therefore OpenGL 4.3

2016-04-18 Thread Bas Nieuwenhuizen
On Mon, Apr 18, 2016 at 7:58 PM, Ian Romanick wrote: > On 04/15/2016 03:33 AM, Marek Olšák wrote: >> The same thing Nicolai said: This can be committed before the UE4 >> compile failure is fixed. > > Is there a bug filed for that problem? Has anyone diagnosed the issue? >

[Mesa-dev] [PATCH] anv_device: Set the compressed texture feature flags correctly

2016-04-18 Thread Nanley Chery
From: Nanley Chery Sampling from an ETC2 texture is supported from Gen8 onwards. While ASTC_LDR is supported on Gen9, the logic to handle such formats has not yet been implemented in the driver. Fixes dEQP-VK.api.info.format_properties.compressed_formats. Bugzilla:

Re: [Mesa-dev] [PATCH 3/4] [rfc] gallivm/llvmpipe dynamic samplers support.

2016-04-18 Thread Dave Airlie
On 19 April 2016 at 03:40, Roland Scheidegger wrote: > Am 18.04.2016 um 04:49 schrieb Dave Airlie: >> From: Dave Airlie >> >> This is a first attempt at adding support for dynamic indexing >> of samplers to llvmpipe. This is needed for ARB_gpu_shader5

[Mesa-dev] [PATCH] glsl: add forgotten textureOffset function for sampler2DArrayShadow

2016-04-18 Thread sroland
From: Roland Scheidegger This was part of EXT_gpu_shader4 - as such it should have been supported by glsl 130. It was however forgotten, and not added until glsl 430 - with the wrong syntax no less (glsl 430 mentions it was overlooked). glsl 440 (but revision 8 only) fixed

Re: [Mesa-dev] [PATCH] swr: dereference cbuf/zbuf/views on context destroy

2016-04-18 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin It has been pointed out to me on several occasions that the state tracker should be unbinding all these, and I seem to recall finding that code. But for some reason I've had to do the same thing to avoid leaks. On Mon, Apr 18, 2016 at 4:29 PM, Tim

[Mesa-dev] [PATCH] swr: dereference cbuf/zbuf/views on context destroy

2016-04-18 Thread Tim Rowley
Fixes resource memory leaks. --- src/gallium/drivers/swr/swr_context.cpp | 15 +++ 1 file changed, 15 insertions(+) diff --git a/src/gallium/drivers/swr/swr_context.cpp b/src/gallium/drivers/swr/swr_context.cpp index 46c79a1..5d311dd 100644 ---

[Mesa-dev] [Bug 95003] [Clover / OpenCL] CL_DEVICE_WAVEFRONT_WIDTH_AMD - 0x4043 unimplemented

2016-04-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95003 Bug ID: 95003 Summary: [Clover / OpenCL] CL_DEVICE_WAVEFRONT_WIDTH_AMD - 0x4043 unimplemented Product: Mesa Version: 11.2 Hardware: x86-64 (AMD64) OS:

[Mesa-dev] [Bug 94271] oclHashcat fails with ERROR: clGetDeviceInfo() : -30 : CL_INVALID_VALUE

2016-04-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94271 ros...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH v2 2/2] glsl: raise warning when using uninitialized variables

2016-04-18 Thread Alejandro Piñeiro
On 18/04/16 16:11, Alejandro Piñeiro wrote: > On 18/04/16 00:47, Ilia Mirkin wrote: >> On Mon, Mar 28, 2016 at 2:50 PM, Alejandro Piñeiro >> wrote: >>> v2: >>> * Take into account out varyings too (Timothy Arceri) >>> * Fix style (Timothy Arceri) >>> * Use a new

Re: [Mesa-dev] [PATCH 00/13] i965/compiler: Use ISL for image_load_store format

2016-04-18 Thread Emil Velikov
On 17 April 2016 at 00:47, Jason Ekstrand wrote: > On Sat, Apr 16, 2016 at 4:40 PM, Emil Velikov > wrote: >> >> On 16 April 2016 at 20:45, Jason Ekstrand wrote: >> > This little series switches our back-end compiler to use

Re: [Mesa-dev] [PATCH 4/4] i965: Properly handle integer types in opt_vector_float().

2016-04-18 Thread Matt Turner
On Sun, Apr 17, 2016 at 11:14 PM, Kenneth Graunke wrote: > Previously, opt_vector_float() always interpreted MOV sources as > floating point, and always created a MOV with a F-type destination. > > This meant that we could mess up sequences of integer loads, such as: > >

[Mesa-dev] [Bug 94955] Uninitialized variables leads to random segfaults (valgrind log, apitrace attached)

2016-04-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94955 David Lonie changed: What|Removed |Added Status|RESOLVED|REOPENED

Re: [Mesa-dev] [PATCH 4/4] i965: Properly handle integer types in opt_vector_float().

2016-04-18 Thread Matt Turner
On Mon, Apr 18, 2016 at 7:20 AM, Iago Toral wrote: > On Sun, 2016-04-17 at 23:14 -0700, Kenneth Graunke wrote: >> Previously, opt_vector_float() always interpreted MOV sources as >> floating point, and always created a MOV with a F-type destination. >> >> This meant that we

[Mesa-dev] [Bug 94955] Uninitialized variables leads to random segfaults (valgrind log, apitrace attached)

2016-04-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94955 --- Comment #8 from Roland Scheidegger --- (In reply to David Lonie from comment #7) > > Comment # 4 on bug 94955 from Roland Scheidegger > > FWIW the trace has some issues, namely it requests a 4.5 context thus needs > >

Re: [Mesa-dev] [PATCH 1/4] i965: Rework opt_vector_float() control flow.

2016-04-18 Thread Matt Turner
On Sun, Apr 17, 2016 at 11:14 PM, Kenneth Graunke wrote: > This reworks opt_vector_float() so that there's only one place that > flushes out any accumulated state and emits a VF. > > Signed-off-by: Kenneth Graunke > --- >

Re: [Mesa-dev] [PATCH 0/4] Removing all double semi-colons

2016-04-18 Thread Ian Romanick
With the one typo in the commit message of patch 1 fixed, the series is Reviewed-by: Ian Romanick If there are no objections or other comments, I'll go ahead and fix it and push the series in the next day or so. On 04/14/2016 09:07 AM, Jakob Sinclair wrote: > This

Re: [Mesa-dev] [PATCH 1/4] egl: Remove every double semi-colon

2016-04-18 Thread Ian Romanick
On 04/14/2016 09:07 AM, Jakob Sinclair wrote: > Removes all acidental semi-colons in egl. accidental > > Signed-off-by: Jakob Sinclair > --- > src/egl/drivers/dri2/platform_android.c | 2 +- > src/egl/drivers/dri2/platform_surfaceless.c | 2 +-

Re: [Mesa-dev] [PATCH 1/7] util: add MAYBE_UNUSED for config dependent variables

2016-04-18 Thread Ian Romanick
On 04/18/2016 08:06 AM, Emil Velikov wrote: > On 18 April 2016 at 04:43, Francisco Jerez wrote: >> Grazvydas Ignotas writes: >> >>> On Sun, Apr 17, 2016 at 2:50 AM, Emil Velikov >>> wrote: On 16 April 2016 at 02:00,

Re: [Mesa-dev] [PATCH] radeonsi: enable GLSL 4.30 and therefore OpenGL 4.3

2016-04-18 Thread Ian Romanick
On 04/15/2016 03:33 AM, Marek Olšák wrote: > The same thing Nicolai said: This can be committed before the UE4 > compile failure is fixed. Is there a bug filed for that problem? Has anyone diagnosed the issue? > Marek > > On Fri, Apr 15, 2016 at 2:10 AM, Edward O'Callaghan >

[Mesa-dev] [Bug 94955] Uninitialized variables leads to random segfaults (valgrind log, apitrace attached)

2016-04-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94955 --- Comment #7 from David Lonie --- > Comment # 1 on bug 94955 from Brian Paul > (In reply to David Lonie from comment #0) > > ==32054== Conditional jump or move depends on uninitialised value(s) > > ==32054==    at

Re: [Mesa-dev] [PATCH 1/7] util: add MAYBE_UNUSED for config dependent variables

2016-04-18 Thread Francisco Jerez
Emil Velikov writes: > On 18 April 2016 at 04:43, Francisco Jerez wrote: >> Grazvydas Ignotas writes: >> >>> On Sun, Apr 17, 2016 at 2:50 AM, Emil Velikov >>> wrote: On 16 April 2016 at 02:00,

Re: [Mesa-dev] [PATCH] docs: correct name for GL_OES_primitive_bounding_box

2016-04-18 Thread Kenneth Graunke
On Monday, April 18, 2016 5:26:33 PM PDT Erik Faye-Lund wrote: > When this extension was added, an underscore were mistakenly replaced > by a space. Let's correct this, so it's a tad easier to grep for this > extension. > > Signed-off-by: Erik Faye-Lund > --- > > Just a

Re: [Mesa-dev] [PATCH 3/4] [rfc] gallivm/llvmpipe dynamic samplers support.

2016-04-18 Thread Roland Scheidegger
Am 18.04.2016 um 04:49 schrieb Dave Airlie: > From: Dave Airlie > > This is a first attempt at adding support for dynamic indexing > of samplers to llvmpipe. This is needed for ARB_gpu_shader5 support. > > This uses the sampler function generator to generate functions > for

Re: [Mesa-dev] [PATCH] glsl: Checks for interpolation into its own function.

2016-04-18 Thread Andres Gomez
Hi, I would really appreciate if you could find some time to review this patch. Thanks! On Mon, 2016-04-04 at 19:50 +0300, Andres Gomez wrote: > This generalizes the validation also to be done for variables inside > interface blocks, which, for some cases, was missing. > > For a discussion

Re: [Mesa-dev] [PATCH 2/4] gallivm: prepare for dynamic texture sizes

2016-04-18 Thread Roland Scheidegger
Am 18.04.2016 um 04:49 schrieb Dave Airlie: > From: Dave Airlie > > Currently the texture member functions take a texture unit > number, in order for TXQ to work we want to use a dynamic > value here, so we need to pass in an value reference. > > This means we can't do the

Re: [Mesa-dev] i965: The future of blorp

2016-04-18 Thread Pohjolainen, Topi
On Sat, Apr 16, 2016 at 12:12:46PM -0700, Jason Ekstrand wrote: >All, >With Topi's gen8/9 blorp patches on the list, I wanted to start a brief >discussion about the future of blorp in the hopes of us all being on >the same page and not stepping on each other's toes. I think

[Mesa-dev] [Bug 94994] OSMesaGetProcAdress always fails on mangled OSMesa

2016-04-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94994 Frederic Devernay changed: What|Removed |Added Depends on||91724

[Mesa-dev] [Bug 91724] GL/gl_mangle.h misses symbols from GLES/gl.h

2016-04-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91724 Frederic Devernay changed: What|Removed |Added Blocks||94994 --

[Mesa-dev] [Bug 94994] OSMesaGetProcAdress always fails on mangled OSMesa

2016-04-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94994 Bug ID: 94994 Summary: OSMesaGetProcAdress always fails on mangled OSMesa Product: Mesa Version: 11.2 Hardware: All OS: All Status: NEW Severity: normal

Re: [Mesa-dev] [PATCH v2 0/2] Fix Gallium RGB565 image support

2016-04-18 Thread Nicolas Dufresne
Le lundi 18 avril 2016 à 11:40 +0900, Michel Dänzer a écrit : > On 17.04.2016 09:49, nico...@ndufresne.ca wrote: > > > > From: Nicolas Dufresne > > > > Sorry for the long delay breaking down this patch. I have now > > rebased > > on top recent mesa tree. First

Re: [Mesa-dev] [PATCH v2 04/11] gallium: add endian_format field to struct pipe_resource

2016-04-18 Thread Marek Olšák
On Mon, Apr 18, 2016 at 5:03 PM, Ilia Mirkin wrote: > On Mon, Apr 18, 2016 at 10:47 AM, Oded Gabbay wrote: >> On Thu, Apr 14, 2016 at 6:44 PM, Ilia Mirkin wrote: >>> On Thu, Apr 14, 2016 at 11:08 AM, Oded Gabbay

Re: [Mesa-dev] [PATCH 8/9] llvmpipe: Test more vector lengths.

2016-04-18 Thread Tom Stellard
On Mon, Apr 18, 2016 at 10:14:35AM +0100, Jose Fonseca wrote: > All power of two of up native vector length. > > There is actually a bug in lp_build_round for v2, whereby it doesn't > round to nearest. Fixing is left to the future, but the test is now > able to expect it to fail. > --- >

[Mesa-dev] [PATCH] docs: correct name for GL_OES_primitive_bounding_box

2016-04-18 Thread Erik Faye-Lund
When this extension was added, an underscore were mistakenly replaced by a space. Let's correct this, so it's a tad easier to grep for this extension. Signed-off-by: Erik Faye-Lund --- Just a tiny nit I noticed while reading docs... docs/GL3.txt | 2 +- 1 file changed, 1

Re: [Mesa-dev] [PATCH 1/4] gallivm: convert size query to using a set of parameters.

2016-04-18 Thread Roland Scheidegger
Am 18.04.2016 um 04:49 schrieb Dave Airlie: > From: Dave Airlie > > This isn't currently that easy to expand, so fix it up > before expanding it later to include dynamic samplers. > > Signed-off-by: Dave Airlie > --- >

Re: [Mesa-dev] [PATCH 1/7] util: add MAYBE_UNUSED for config dependent variables

2016-04-18 Thread Emil Velikov
On 18 April 2016 at 04:43, Francisco Jerez wrote: > Grazvydas Ignotas writes: > >> On Sun, Apr 17, 2016 at 2:50 AM, Emil Velikov >> wrote: >>> On 16 April 2016 at 02:00, Grazvydas Ignotas wrote: This

Re: [Mesa-dev] [PATCH v2 04/11] gallium: add endian_format field to struct pipe_resource

2016-04-18 Thread Ilia Mirkin
On Mon, Apr 18, 2016 at 10:47 AM, Oded Gabbay wrote: > On Thu, Apr 14, 2016 at 6:44 PM, Ilia Mirkin wrote: >> On Thu, Apr 14, 2016 at 11:08 AM, Oded Gabbay wrote: Wouldn't it make more sense to handle such issues in

Re: [Mesa-dev] [PATCH v2 04/11] gallium: add endian_format field to struct pipe_resource

2016-04-18 Thread Rob Clark
On Mon, Apr 18, 2016 at 10:47 AM, Oded Gabbay wrote: > On Thu, Apr 14, 2016 at 6:44 PM, Ilia Mirkin wrote: >> On Thu, Apr 14, 2016 at 11:08 AM, Oded Gabbay wrote: Wouldn't it make more sense to handle such issues in

Re: [Mesa-dev] [PATCH 4/7] radeonsi: don't use ACQUIRE_MEM on the graphics ring

2016-04-18 Thread Alex Deucher
On Sun, Apr 17, 2016 at 12:11 PM, Marek Olšák wrote: > From: Marek Olšák > > It's only required on the compute ring. This matches the closed driver. > > The compute flag is removed to prevent confusion and Bas's compute shader > patches remove it in the

Re: [Mesa-dev] [PATCH v2 04/11] gallium: add endian_format field to struct pipe_resource

2016-04-18 Thread Oded Gabbay
On Thu, Apr 14, 2016 at 6:44 PM, Ilia Mirkin wrote: > On Thu, Apr 14, 2016 at 11:08 AM, Oded Gabbay wrote: >>> Wouldn't it make more sense to handle such issues in transfer_map? >>> (i.e. create a staging memory area, and decode into it)? This assumes

Re: [Mesa-dev] [PATCH 1/4] i965: Rework opt_vector_float() control flow.

2016-04-18 Thread Iago Toral
Patches 1-3 are: Reviewed-by: Iago Toral Quiroga On Sun, 2016-04-17 at 23:14 -0700, Kenneth Graunke wrote: > This reworks opt_vector_float() so that there's only one place that > flushes out any accumulated state and emits a VF. > > Signed-off-by: Kenneth Graunke

Re: [Mesa-dev] [PATCH 4/4] i965: Properly handle integer types in opt_vector_float().

2016-04-18 Thread Iago Toral
On Sun, 2016-04-17 at 23:14 -0700, Kenneth Graunke wrote: > Previously, opt_vector_float() always interpreted MOV sources as > floating point, and always created a MOV with a F-type destination. > > This meant that we could mess up sequences of integer loads, such as: > >mov vgrf6.0.x:D, 0D

Re: [Mesa-dev] [PATCH 1/9] gallivm: Use LLVMPrintValueToString where available.

2016-04-18 Thread Roland Scheidegger
Series looks great to me. Thanks for the cleanup. Reviewed-by: Roland Scheidegger Am 18.04.2016 um 11:14 schrieb Jose Fonseca: > And llvm::raw_string_ostream where not (LLVM 3.3). > > Thereby eliminating yet another dependency on unstable LLVM interfaces. > > As a bonus

Re: [Mesa-dev] [PATCH 2/9] gallivm: Use LLVMSetTarget.

2016-04-18 Thread Emil Velikov
On 18 April 2016 at 14:16, Jose Fonseca wrote: > On 18/04/16 13:27, Emil Velikov wrote: >> >> Hi Jose, >> >> On 18 April 2016 at 10:14, Jose Fonseca wrote: >>> >>> Instead of LLVM C++ interfaces. >>> --- >>>

  1   2   >