[Mesa-dev] [PATCH] glsl: use linked shaders rather than compiled shaders

2016-07-10 Thread Timothy Arceri
At this point there is no reason not to be using the linked shaders, using the linked shaders should be faster and will make things simpler for upcoming shader cache work. The previous variable name suggests the linked shaders were intended to be used here anyway. --- src/compiler/glsl/linker.cpp

Re: [Mesa-dev] mesa from git fails to compile

2016-07-10 Thread Jason Ekstrand
This smells like strange Python problems. Ccing the resident Python expert. Hello, compiling mesa from git is failing on this error: Making all in isl make[5]: Entering directory `/«PKGBUILDDIR»/build/dri/src/intel/isl' python2.7 ../../../../../src/intel/isl/gen_format_layout.py \ --

[Mesa-dev] mesa from git fails to compile

2016-07-10 Thread Pali Rohár
Hello, compiling mesa from git is failing on this error: Making all in isl make[5]: Entering directory `/«PKGBUILDDIR»/build/dri/src/intel/isl' python2.7 ../../../../../src/intel/isl/gen_format_layout.py \ --csv ../../../../../src/intel/isl/isl_format_layout.csv --out isl_format_layo

[Mesa-dev] [PATCH Mesa] egl/wayland: check drmGetMagic for failure

2016-07-10 Thread Eric Engestrom
Coverity (CovID 1255672) noticed that all the other calls to drmGetMagic were checked for failure, but not this one. Fix this, and return before an invalid magic token is used to authenticate the device. Signed-off-by: Eric Engestrom --- src/egl/drivers/dri2/platform_wayland.c | 5 - 1 file

Re: [Mesa-dev] [PATCH] glsl: look for frag data bindings with [0] tacked onto the end for arrays

2016-07-10 Thread Corentin Wallez
Not sure how reviews work in Mesa, but this patch LGTM. I also tested that it fixes the relevant tests failures it is supposed to address. On Wed, Jul 6, 2016 at 7:40 PM, Ilia Mirkin wrote: > The GL spec is very unclear on this point. Apparently this is discussed > without resolution in the clos

Re: [Mesa-dev] [PATCH 20/47] clover/llvm: Clean up codestyle of get_kernel_args().

2016-07-10 Thread Jan Vesely
On Sat, 2016-07-09 at 14:32 -0700, Francisco Jerez wrote: > Jan Vesely writes: > > > On Mon, 2016-07-04 at 12:31 -0700, Francisco Jerez wrote: > > > Jan Vesely writes: > > > > > > > On Sun, 2016-07-03 at 17:51 -0700, Francisco Jerez wrote: > > > > > Reviewed-by: Serge Martin > > > > > --- > >

[Mesa-dev] glxinfo page - you too can now update it

2016-07-10 Thread Ilia Mirkin
Hi everyone, As many of you are no doubt aware, I've been maintaining my glxinfo page which shows, by hardware group, which extensions are supported. If you haven't seen it already, this is available at https://people.freedesktop.org/~imirkin/glxinfo/ . The hope is that this information can be use

Re: [Mesa-dev] [PATCH 04/13] todo! dri: Questions about fence fd ownership

2016-07-10 Thread Rob Clark
On Fri, Jul 8, 2016 at 8:00 PM, Chad Versace wrote: > See the comments. > --- > include/GL/internal/dri_interface.h | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/include/GL/internal/dri_interface.h > b/include/GL/internal/dri_interface.h > index 99c83ec..051ddb4 100644 > ---

Re: [Mesa-dev] [PATCH] nvc0/ir: fix images indirect access on Fermi

2016-07-10 Thread Samuel Pitoiset
On 07/10/2016 04:23 PM, Ilia Mirkin wrote: Do you also need to zero out su->tex.r ? Nope, because it's only used when rIndirectSrc < 0 (ie. no indirection). On Jul 10, 2016 10:19 AM, "Samuel Pitoiset" mailto:samuel.pitoi...@gmail.com>> wrote: This fixes the following piglits: ar

Re: [Mesa-dev] [PATCH] nvc0/ir: fix images indirect access on Fermi

2016-07-10 Thread Ilia Mirkin
Do you also need to zero out su->tex.r ? On Jul 10, 2016 10:19 AM, "Samuel Pitoiset" wrote: > This fixes the following piglits: > > arb_arrays_of_arrays-basic-imagestore-mixed-const-non-const-uniform-index > arb_arrays_of_arrays-basic-imagestore-mixed-const-non-const-uniform-index2 > > Signed-of

[Mesa-dev] [PATCH] radeonsi: silence Coverity warning

2016-07-10 Thread Nicolai Hähnle
From: Nicolai Hähnle Coverity's analysis is too weak to understand that r600_init_flushed_depth(_, _, NULL) only returns true when flushed_depth_texture was assigned a non-NULL value. --- src/gallium/drivers/radeonsi/si_blit.c | 2 ++ src/gallium/drivers/radeonsi/si_state.c | 2 ++ 2 files chan

[Mesa-dev] [PATCH] nvc0/ir: fix images indirect access on Fermi

2016-07-10 Thread Samuel Pitoiset
This fixes the following piglits: arb_arrays_of_arrays-basic-imagestore-mixed-const-non-const-uniform-index arb_arrays_of_arrays-basic-imagestore-mixed-const-non-const-uniform-index2 Signed-off-by: Samuel Pitoiset Cc: 12.0 --- Expect minor conflicts because I did refactor that logic but the pa