Re: [Mesa-dev] [PATCH 08/10] egl/android: Make get_fourcc() accept HAL formats

2016-07-16 Thread Tomasz Figa
Hi Rob, On Sun, Jul 17, 2016 at 5:57 AM, Rob Herring wrote: > On Fri, Jul 15, 2016 at 2:53 AM, Tomasz Figa wrote: >> There are DRI_IMAGE_FOURCC macros, for which there are no corresponding >> DRI_IMAGE_FORMAT macros. To support such formats we need to make the >> lookup function take the native

Re: [Mesa-dev] [PATCH] glsl: use linked shaders rather than compiled shaders

2016-07-16 Thread Timothy Arceri
Ping. On Mon, 2016-07-11 at 12:11 +1000, Timothy Arceri wrote: > At this point there is no reason not to be using the linked shaders, > using the linked shaders should be faster and will make things > simpler > for upcoming shader cache work. > > The previous variable name suggests the linked sha

[Mesa-dev] [Bug 56741] Software rendering and Wayland clients no longer work

2016-07-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=56741 n3rdopolis changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

Re: [Mesa-dev] [PATCH 4/4] i965: Move pulls_bary setting to emit_pixel_interpolator_send().

2016-07-16 Thread Timothy Arceri
On Fri, 2016-07-15 at 23:43 -0700, Kenneth Graunke wrote: > pulls_bary should be set when the shader uses a pixel interpolator > message.  So, setting it from the function that emits pixel > interpolator > messages makes a lot of sense. > > Signed-off-by: Kenneth Graunke >  Reviewed-by: Timothy

Re: [Mesa-dev] [PATCH 3/4] i965: Write gl_FragCoord directly to the destination.

2016-07-16 Thread Timothy Arceri
On Fri, 2016-07-15 at 23:43 -0700, Kenneth Graunke wrote: > This patch makes emit_general_interpolation take a destination > register > as an argument, and write directly to that.  This is simpler than the > old approach of ralloc'ing a register, writing to that temporary, and > then making the cal

Re: [Mesa-dev] [PATCH 2/4] i965: Drop has_pln checks in unlit centroid workaround.

2016-07-16 Thread Timothy Arceri
On Sun, 2016-07-17 at 09:14 +1000, Timothy Arceri wrote: > On Fri, 2016-07-15 at 23:43 -0700, Kenneth Graunke wrote: > > The unlit centroid workaround starts being necessary on Gen6, which > > is the first platform with multisampling.  PLN exists on G45+, so > > all > > platforms which need this wo

Re: [Mesa-dev] [PATCH 2/4] i965: Drop has_pln checks in unlit centroid workaround.

2016-07-16 Thread Timothy Arceri
On Fri, 2016-07-15 at 23:43 -0700, Kenneth Graunke wrote: > The unlit centroid workaround starts being necessary on Gen6, which > is the first platform with multisampling.  PLN exists on G45+, so all > platforms which need this workaround have PLN. > > Signed-off-by: Kenneth Graunke > --- >  src/

Re: [Mesa-dev] [PATCH 1/4] i965: Drop VARYING_SLOT_FACE special case in barycentric setup.

2016-07-16 Thread Timothy Arceri
On Fri, 2016-07-15 at 23:43 -0700, Kenneth Graunke wrote: > glsl_to_nir always produces a system value for gl_FrontFacing, rather > than an input.  So there should never be an input with this slot, > making this code dead. > > Signed-off-by: Kenneth Graunke Reviewed-by: Timothy Arceri

Re: [Mesa-dev] [PATCH] gallium: add a cap for VIEWPORT_SUBPIXEL_BITS

2016-07-16 Thread Ilia Mirkin
On Sat, Jul 16, 2016 at 7:47 AM, Józef Kucia wrote: > This allows Gallium drivers to advertise the subpixel precision > for floating point viewports bounds. > > Signed-off-by: Józef Kucia > --- > > Currently all Mesa drivers return 0 for GL_VIEWPORT_SUBPIXEL_BITS > regardless whether floating poi

Re: [Mesa-dev] [PATCH v4 29/34] i965/gen4-6: Use the generic ISL-based path for texture surfaces

2016-07-16 Thread Alejandro Piñeiro
On 16/07/16 16:29, Jason Ekstrand wrote: > > On Jul 16, 2016 3:59 AM, "Alejandro Piñeiro" > wrote: > > > > Don't know if there are still some missing patches to be submitted to > > master, but this patch caused regressions on skylake on the following > > CTS tests: > >

Re: [Mesa-dev] [PATCH 08/10] egl/android: Make get_fourcc() accept HAL formats

2016-07-16 Thread Rob Herring
On Fri, Jul 15, 2016 at 2:53 AM, Tomasz Figa wrote: > There are DRI_IMAGE_FOURCC macros, for which there are no corresponding > DRI_IMAGE_FORMAT macros. To support such formats we need to make the > lookup function take the native format directly. As a side effect, it > simplifies all existing cal

Re: [Mesa-dev] [PATCH v2 2/2] st/mesa: provide GL_OES_copy_image support by caching the original ETC data

2016-07-16 Thread Ilia Mirkin
On Sat, Jul 16, 2016 at 4:29 PM, Matt Turner wrote: > On Sat, Jul 16, 2016 at 9:21 AM, Ilia Mirkin wrote: >> The additional provision of GL_OES_copy_image is that it work for ETC. >> However many desktop GPUs don't have native ETC support, so st/mesa does >> the decoding by hand. Instead of disca

Re: [Mesa-dev] [PATCH v2 2/2] st/mesa: provide GL_OES_copy_image support by caching the original ETC data

2016-07-16 Thread Matt Turner
On Sat, Jul 16, 2016 at 9:21 AM, Ilia Mirkin wrote: > The additional provision of GL_OES_copy_image is that it work for ETC. > However many desktop GPUs don't have native ETC support, so st/mesa does > the decoding by hand. Instead of discarding the compressed data, keep it > around in CPU memory.

Re: [Mesa-dev] [PATCH 01/12] vl: add parameters for VAAPI encode

2016-07-16 Thread Andy Furniss
Andy Furniss wrote: Zhang, Boyuan wrote: Hi Andy, The memory issue is fixed. Please try the new patch set I just submitted. Should NOT have hard lock anymore. And thanks for providing the rate control info, I will do some test about it. Another issue is decode -> encode, this works OK with o

[Mesa-dev] [PATCH] nvc0: add support for BGRA8 images

2016-07-16 Thread Ilia Mirkin
This is useful for pbo downloads, which are now accelerated with images. BGRA8 is a moderately common format to do that in. Signed-off-by: Ilia Mirkin --- This needs testing on SM20 and SM30. I've tested it on SM35 and bin/pbo-readpixels-small -auto worked fine. (Didn't until I properly fixed

[Mesa-dev] [PATCH 1/2] radeonsi: fix Polaris MSAA regression

2016-07-16 Thread Nicolai Hähnle
From: Nicolai Hähnle The regression was introduced by commit d938b8c. The problem here is that in order to use the small primitive filter, we need to explicitly set the sample locations to 0. But the DB doesn't properly process the change of sample locations without a flush, and so we can end up

[Mesa-dev] [PATCH 2/2] radeonsi: ensure sample locations are set for line and polygon smoothing

2016-07-16 Thread Nicolai Hähnle
From: Nicolai Hähnle Since commit d938b8c, the sample locations are no longer set unconditionally, so we need to set the atom to dirty on all chips, not just Polaris. Cc: 12.0 --- src/gallium/drivers/radeonsi/si_state_shaders.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --gi

[Mesa-dev] [PATCH v2 1/2] st/mesa: refactor duplicated etc fallback checks

2016-07-16 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin Reviewed-by: Marek Olšák --- v1 -> v2: - fix return type - make into global function (used in next patch) src/mesa/state_tracker/st_cb_texture.c | 15 +-- src/mesa/state_tracker/st_texture.h| 3 +++ 2 files changed, 12 insertions(+), 6 deletions(-)

[Mesa-dev] [PATCH v2 2/2] st/mesa: provide GL_OES_copy_image support by caching the original ETC data

2016-07-16 Thread Ilia Mirkin
The additional provision of GL_OES_copy_image is that it work for ETC. However many desktop GPUs don't have native ETC support, so st/mesa does the decoding by hand. Instead of discarding the compressed data, keep it around in CPU memory. Use it when performing image copies. Signed-off-by: Ilia Mi

Re: [Mesa-dev] [PATCH 1/4] mesa: avoid valgrind warning due to opaque only being set sometimes

2016-07-16 Thread Ilia Mirkin
ping On Fri, Jul 8, 2016 at 2:48 AM, Ilia Mirkin wrote: > Valgrind complains with a "Conditional jump or move depends on > uninitialised value(s)" warning due to opaque being conditionally > initialized. However in the punchthrough_alpha == true case, it is > always initialized, so just flip the

Re: [Mesa-dev] [PATCH 0/4] RadeonSI: Multithreaded shader compilation

2016-07-16 Thread Grazvydas Ignotas
On Sat, Jul 16, 2016 at 2:00 AM, Marek Olšák wrote: > On Wed, Jul 13, 2016 at 10:50 AM, Vedran Miletić wrote: >> On 07/13/2016 05:19 AM, Timothy Arceri wrote: >>> >>> So I finally got around to setting up my new polaris card on fedora. I >>> was curious to see how Talos performed compared to i965

Re: [Mesa-dev] [PATCH 07/10] egl/android: Make drm_gralloc headers optional

2016-07-16 Thread Tomasz Figa
On Sat, Jul 16, 2016 at 11:17 PM, Rob Herring wrote: > On Fri, Jul 15, 2016 at 2:53 AM, Tomasz Figa wrote: >> We can support render nodes alone without any private headers, so let's >> make support for control nodes depend on presence of private drm_gralloc >> headers. > > This is a complicated c

[Mesa-dev] [PATCH] gallium/util: Fix debug_printf under Haiku

2016-07-16 Thread Alexander von Gluck IV
--- src/gallium/auxiliary/util/u_debug.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/util/u_debug.h b/src/gallium/auxiliary/util/u_debug.h index 7da7f53..7dc4ce8 100644 --- a/src/gallium/auxiliary/util/u_debug.h +++ b/src/gallium/auxiliary/util/u_

Re: [Mesa-dev] [PATCH v4 29/34] i965/gen4-6: Use the generic ISL-based path for texture surfaces

2016-07-16 Thread Jason Ekstrand
On Jul 16, 2016 3:59 AM, "Alejandro Piñeiro" wrote: > > Don't know if there are still some missing patches to be submitted to > master, but this patch caused regressions on skylake on the following > CTS tests: > > * > GL44-CTS.texture_cube_map_array.image_texture_size.texture_size_compute_s

Re: [Mesa-dev] [PATCH 07/10] egl/android: Make drm_gralloc headers optional

2016-07-16 Thread Rob Herring
On Fri, Jul 15, 2016 at 2:53 AM, Tomasz Figa wrote: > We can support render nodes alone without any private headers, so let's > make support for control nodes depend on presence of private drm_gralloc > headers. This is a complicated change for what amounts to just needing the flink name out of t

Re: [Mesa-dev] [PATCH 00/12] render reordering for optimized tile buffer usage

2016-07-16 Thread Rob Clark
On Fri, Jul 8, 2016 at 12:14 PM, Rob Clark wrote: > One of the annoying things, since pipe_resource is per-screen, not > per-context, I end up having to push batch_cache down into screen. > Which means that, for example, one context switching fb state could > force flushing a batch from another co

Re: [Mesa-dev] [PATCH 01/12] vl: add parameters for VAAPI encode

2016-07-16 Thread Andy Furniss
Zhang, Boyuan wrote: Hi Andy, The memory issue is fixed. Please try the new patch set I just submitted. Should NOT have hard lock anymore. And thanks for providing the rate control info, I will do some test about it. Another issue is decode -> encode, this works OK with omx, but with someth

[Mesa-dev] [PATCH] gallium: add a cap for VIEWPORT_SUBPIXEL_BITS

2016-07-16 Thread Józef Kucia
This allows Gallium drivers to advertise the subpixel precision for floating point viewports bounds. Signed-off-by: Józef Kucia --- Currently all Mesa drivers return 0 for GL_VIEWPORT_SUBPIXEL_BITS regardless whether floating point viewport bounds are supported. From the ARB_viewport_array spec

Re: [Mesa-dev] [PATCH shader-db 4/4] si-report.py: add completely new shader statistics reporting

2016-07-16 Thread Nicolai Hähnle
Series is Acked-by: Nicolai Hähnle On 14.07.2016 16:28, Marek Olšák wrote: From: Marek Olšák We can remove the old reporting if people are OK with that. The old reporting has a bug that it reports 0->N changes as 0 % in several places. (should be inf %) The new reporting shows: - VGPR spill

Re: [Mesa-dev] [PATCH] main: memcpy larger chunks in _mesa_propagate_uniforms_to_driver_storage

2016-07-16 Thread Nicolai Hähnle
On 13.07.2016 13:53, Nils Wallménius wrote: When possible, do the memcpy on larger blocks. This reduces cycles spent in _mesa_propagate_uniforms_to_driver_storage from 1.51 % to 0.62% according to perf during the Unigine Heaven benchmark. It did not affect the framerate of the benchmark. The syst

Re: [Mesa-dev] [PATCH] gallium/u_queue: add optional cleanup callback

2016-07-16 Thread Nicolai Hähnle
Reviewed-by: Nicolai Hähnle On 14.07.2016 21:08, Rob Clark wrote: Adds a second optional cleanup callback, called after the fence is signaled. This is needed if, for example, the queue has the last reference to the object that embeds the util_queue_fence. In this case we cannot drop the ref i

Re: [Mesa-dev] [PATCH v4 29/34] i965/gen4-6: Use the generic ISL-based path for texture surfaces

2016-07-16 Thread Alejandro Piñeiro
Don't know if there are still some missing patches to be submitted to master, but this patch caused regressions on skylake on the following CTS tests: * GL44-CTS.texture_cube_map_array.image_texture_size.texture_size_compute_sh * GL44-CTS.texture_cube_map_array.image_texture_size.textu

Re: [Mesa-dev] [PATCH] radeonsi: remove the DRAW_PREAMBLE packet

2016-07-16 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Thu, Jul 14, 2016 at 4:40 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > According to firmware guys, the new sequence that we added for Polaris should > work on all CIK parts, and should actually be faster on some parts. > --- > src/gallium/drivers/rade

[Mesa-dev] [Bug 96950] Another regression from bc4e0c486: vbo: Use a bitmask to track the active arrays in vbo_exec*.

2016-07-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96950 --- Comment #4 from Mathias Fröhlich --- The remaining thing that I could see to get into this situation would be that newSize is equal to zero on entry to in vbo_exec_wrap_upgrade_vertex. The only case where I could not rule out newSize being z

[Mesa-dev] [Bug 96950] Another regression from bc4e0c486: vbo: Use a bitmask to track the active arrays in vbo_exec*.

2016-07-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96950 --- Comment #3 from Mathias Fröhlich --- Created attachment 125104 --> https://bugs.freedesktop.org/attachment.cgi?id=125104&action=edit Patch for debugging -- You are receiving this mail because: You are the assignee for the bug. You are the