Re: [Mesa-dev] [PATCH v2 25/35] i965/blorp: Map 1-D render targets with DIM_LAYOUT_GEN4_2D as 2D on gen9

On Thu, Jul 28, 2016 at 06:35:58PM -0700, Jason Ekstrand wrote: >On Jul 28, 2016 2:41 AM, "Pohjolainen, Topi" ><[1]topi.pohjolai...@intel.com> wrote: >> >> On Tue, Jul 26, 2016 at 03:02:16PM -0700, Jason Ekstrand wrote: >> > The sampling hardware can handle them ok. It just

Re: [Mesa-dev] [PATCH v2 21/35] i965/blorp: Use the isl_view from the blorp_surface_info

On Tue, Jul 26, 2016 at 03:02:12PM -0700, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/brw_blorp.c | 18 +- > 1 file changed, 1 insertion(+), 17 deletions(-) Reviewed-by: Topi Pohjolainen > > diff --git

Re: [Mesa-dev] [PATCH v2 01/35] isl: Fix the parameter names for get_intratile_offset

On Tue, Jul 26, 2016 at 03:01:52PM -0700, Jason Ekstrand wrote: > It's been in elements for a while but, for whatever reason, the parameter > names in the header file never got updated. > --- > src/intel/isl/isl.h | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Topi

Re: [Mesa-dev] [PATCH 5/5] i965/sched: Change the scheduling heuristics to favor early program termination.

On Tue, Aug 16, 2016 at 1:54 PM, Francisco Jerez wrote: > This uses the unblocked time of the exit assigned to each available > node to attempt to unblock exit nodes as early as possible, > potentially reducing the runtime of the shader when an exit branch is > taken.

Re: [Mesa-dev] [PATCH 4/5] i965/sched: Assign a preferred exit node to each node of the dependency graph.

On Tue, Aug 16, 2016 at 1:54 PM, Francisco Jerez wrote: > This adds a bit of metadata to schedule_node that will be used to > compare available nodes in the scheduling heuristic code based on > which of them unblocks the earliest successor exit node. Note that > assigning

Re: [Mesa-dev] [PATCH 1/5] i965/fs: Drop bogus writemasking disable bit from HALT instructions.

On Tue, Aug 16, 2016 at 1:54 PM, Francisco Jerez wrote: > This may have been the reason people ran into problems with > non-uniform HALT instructions and ended up using the inefficient > ANY16H/ANY8H predicates instead of ANY4H or NORMAL in order to prevent > non-uniform

Re: [Mesa-dev] [PATCH 2/5] i965/fs: Switch to per-subspan discard jumps.

This makes a lot of sense Reviewed-by: Jason Ekstrand On Tue, Aug 16, 2016 at 1:54 PM, Francisco Jerez wrote: > ANY4H is more efficient than ANY8H and ANY16H because it makes sure > that whenever a whole subspan hits a discard statement it gets >

Re: [Mesa-dev] [PATCH 05/23] mesa: Convert string_to_uint_map to the util hash table

On Tue, 2016-08-16 at 22:10 +0200, Thomas Helland wrote: > And remove the now unused hash_table_replace. As far as I can tell your not doing the equivalent hash_table_replace() here you are just leaking memory. See comments below. > > Signed-off-by: Thomas Helland >

Re: [Mesa-dev] [PATCH 3/5] i965/sched: Calculate the critical path of scheduling nodes non-recursively.

Reviewed-by: Jason Ekstrand On Tue, Aug 16, 2016 at 1:54 PM, Francisco Jerez wrote: > The critical path of each node is calculated by induction based on the > critical paths of its children, which can be done in a post-order > depth-first traversal

Re: [Mesa-dev] [PATCH 02/23] mesa: Replace hashing functions of prog_hash_table

On Tue, 2016-08-16 at 22:10 +0200, Thomas Helland wrote: > This will make it functionally equivalent to the one in util. > This enables us to do a step-by-step replacement of the table. > > Signed-off-by: Thomas Helland You should really just move these to the header

Re: [Mesa-dev] [PATCH 22/23] glsl: Convert glcpp-parse to the util hash table

On Tue, 2016-08-16 at 22:10 +0200, Thomas Helland wrote: > And change the include in glcpp.h accordingly. > > Signed-off-by: Thomas Helland > --- >  src/compiler/glsl/glcpp/glcpp-parse.y | 54 ++--- > -- >  src/compiler/glsl/glcpp/glcpp.h 

Re: [Mesa-dev] [PATCH 14/16] i965: Enable GL_KHR_blend_equation_advanced on G45 and later.

Kenneth Graunke writes: > Signed-off-by: Kenneth Graunke Reviewed-by: Francisco Jerez > --- > src/mesa/drivers/dri/i965/brw_link.cpp | 2 ++ > src/mesa/drivers/dri/i965/intel_extensions.c | 4 +++- > 2 files changed,

Re: [Mesa-dev] [PATCH 16/16] i965: Implement GL_KHR_blend_equation_advanced_coherent on Gen9+.

Kenneth Graunke writes: > We always use a coherent read, and ignore the "opt out" enable flag. > > Signed-off-by: Kenneth Graunke Reviewed-by: Francisco Jerez > --- > src/mesa/drivers/dri/i965/intel_extensions.c | 1 + > 1

Re: [Mesa-dev] [PATCH 15/16] mesa: Implement GL_KHR_blend_equation_advanced_coherent.

Kenneth Graunke writes: > This adds the extension enable (so drivers can advertise it) and the > extra boolean state flag, GL_BLEND_ADVANCED_COHERENT_KHR, which can > be set to request coherent blending. > > Signed-off-by: Kenneth Graunke

Re: [Mesa-dev] [PATCH 08/16] mesa: Allow advanced blending enums in glBlendEquation[i].

Kenneth Graunke writes: > Don't allow them in glBlendEquationSeparate[i], though, as required > by the spec. > > Signed-off-by: Kenneth Graunke Reviewed-by: Francisco Jerez > --- > src/mesa/main/blend.c | 64 >

Re: [Mesa-dev] [PATCH 10/16] compiler: Add a new STATE_VAR_ADVANCED_BLENDING_MODE built-in uniform.

Kenneth Graunke writes: > This will be used for emulating GL_KHR_advanced_blend_equation features > in shader code. We'll pass in the blending mode that's in use, and use > that in (effectively) a switch statement in the shader. > > Signed-off-by: Kenneth Graunke

Re: [Mesa-dev] [PATCH 06/16] glsl: Rename link_fs_input_layout_qualifiers to "inout".

Kenneth Graunke writes: > We're going to handle output qualifiers here too, and calling it "inout" > seems to be the going convention. > > Signed-off-by: Kenneth Graunke Reviewed-by: Francisco Jerez > --- >

Re: [Mesa-dev] [PATCH 07/16] glsl: Merge blend_support qualifiers when linking.

Kenneth Graunke writes: > Since each qualifier represents a blending mode the shader can be used > with, we take the union of all possible modes when linking. > > Signed-off-by: Kenneth Graunke Reviewed-by: Francisco Jerez

Re: [Mesa-dev] [PATCH 05/16] glsl: process blend_support_* qualifiers

Kenneth Graunke writes: > From: Ilia Mirkin > > v2 (Ken): Add a BLEND_NONE enum value (no qualifiers in use). > > Signed-off-by: Ilia Mirkin > Reviewed-by: Kenneth Graunke Reviewed-by: Francisco Jerez

Re: [Mesa-dev] [PATCH 02/16] glapi: add KHR_blend_equation_advanced dispatch

Kenneth Graunke writes: > From: Ilia Mirkin > > v2 (Ken): Fix enum values, drop _mesa_BlendBarrierKHR stub as Curro has > already implemented it. > > Signed-off-by: Ilia Mirkin > Signed-off-by: Kenneth Graunke

Re: [Mesa-dev] [PATCH 04/16] glsl: add basic KHR_blend_equation_advanced infrastructure

Kenneth Graunke writes: > From: Ilia Mirkin > > Signed-off-by: Ilia Mirkin > Reviewed-by: Kenneth Graunke Reviewed-by: Francisco Jerez > --- >

Re: [Mesa-dev] [PATCH 01/16] mesa: Rename _mesa_BlendBarrierMESA to _mesa_BlendBarrierKHR.

Kenneth Graunke writes: > Note that _mesa_BlendBarrierMESA is not currently hooked up in the > glapi XML, so we can just rename it. We'll hook it up for the > KHR_blend_equation_advanced extension shortly. > > XXX: sort out exactly what patches Curro plans to push and

[Mesa-dev] [PATCH 5/5] i965/sched: Change the scheduling heuristics to favor early program termination.

This uses the unblocked time of the exit assigned to each available node to attempt to unblock exit nodes as early as possible, potentially reducing the runtime of the shader when an exit branch is taken. There is a natural trade-off between terminating the program as early as possible and

[Mesa-dev] [PATCH 2/5] i965/fs: Switch to per-subspan discard jumps.

ANY4H is more efficient than ANY8H and ANY16H because it makes sure that whenever a whole subspan hits a discard statement it gets disabled by the EU until the end of the program, regardless of whether the discard condition is uniform across all channels of the SIMD8-16 thread. OTOH ANY8H/ANY16H

[Mesa-dev] [PATCH 1/5] i965/fs: Drop bogus writemasking disable bit from HALT instructions.

This may have been the reason people ran into problems with non-uniform HALT instructions and ended up using the inefficient ANY16H/ANY8H predicates instead of ANY4H or NORMAL in order to prevent non-uniform discard. The HALT instruction is able to handle non-uniform execution masks just fine.

[Mesa-dev] [PATCH 3/5] i965/sched: Calculate the critical path of scheduling nodes non-recursively.

The critical path of each node is calculated by induction based on the critical paths of its children, which can be done in a post-order depth-first traversal of the dependency graph. The current code implements graph traversal by iterating over all nodes of the graph and then recursing into its

[Mesa-dev] [PATCH 0/5] i965: Assorted discard-related performance improvements.

This series contains two independent discard-related optimizations: PATCH 1-2 change the i965 back-end to do per-subspan instead of per-SIMD-thread discard jumps, which can save bandwidth and ALU cycles in some scenarios. This improves the FPS of a very simple microbenchmark that does a costly

[Mesa-dev] [PATCH 4/5] i965/sched: Assign a preferred exit node to each node of the dependency graph.

This adds a bit of metadata to schedule_node that will be used to compare available nodes in the scheduling heuristic code based on which of them unblocks the earliest successor exit node. Note that assigning exit nodes wouldn't be necessary in a bottom-up scheduler because we could achieve the

[Mesa-dev] [PATCH 11/23] glsl: Convert link_functions to the util hash table

Signed-off-by: Thomas Helland --- src/compiler/glsl/link_functions.cpp | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/src/compiler/glsl/link_functions.cpp b/src/compiler/glsl/link_functions.cpp index 079f3b9..69bdef1

[Mesa-dev] [PATCH 22/23] glsl: Convert glcpp-parse to the util hash table

And change the include in glcpp.h accordingly. Signed-off-by: Thomas Helland --- src/compiler/glsl/glcpp/glcpp-parse.y | 54 ++- src/compiler/glsl/glcpp/glcpp.h | 2 +- 2 files changed, 35 insertions(+), 21 deletions(-) diff

[Mesa-dev] [PATCH 23/23] mesa/glsl: Move string_to_uint_map into the util folder

This clears the last bits of the usecases of the hash table located in mesa/program, allowing us to remove it. Signed-off-by: Thomas Helland --- src/compiler/glsl/link_uniform_initializers.cpp| 2 +- src/compiler/glsl/link_uniforms.cpp| 2 +-

[Mesa-dev] [PATCH 14/23] glsl: Convert linker to the util hash table

We are getting the util hash table through the include in program/hash_table.h for the moment until we migrate the string_to_uint_map to a separate file. Signed-off-by: Thomas Helland --- src/compiler/glsl/linker.cpp | 29 + 1 file changed,

[Mesa-dev] [PATCH 15/23] glsl: Convert if lowering to use the util hash table

Also do some miner whitespace cleanups Signed-off-by: Thomas Helland --- src/compiler/glsl/lower_if_to_cond_assign.cpp | 44 ++- 1 file changed, 23 insertions(+), 21 deletions(-) diff --git a/src/compiler/glsl/lower_if_to_cond_assign.cpp

[Mesa-dev] [PATCH 18/23] glsl: Convert output read lowering to the util hash table

Signed-off-by: Thomas Helland --- src/compiler/glsl/lower_output_reads.cpp | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/src/compiler/glsl/lower_output_reads.cpp b/src/compiler/glsl/lower_output_reads.cpp index 79488df..732f4d3

[Mesa-dev] [PATCH 20/23] mesa: Convert symbol table to the util hash table

Signed-off-by: Thomas Helland --- src/mesa/program/symbol_table.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/src/mesa/program/symbol_table.c b/src/mesa/program/symbol_table.c index 5b22745..3e58432 100644 ---

[Mesa-dev] [PATCH 21/23] glsl: Convert loop analysis to the util hash table

Signed-off-by: Thomas Helland --- src/compiler/glsl/loop_analysis.cpp | 25 ++--- src/compiler/glsl/loop_analysis.h | 8 2 files changed, 18 insertions(+), 15 deletions(-) diff --git a/src/compiler/glsl/loop_analysis.cpp

[Mesa-dev] [PATCH 19/23] glsl: Convert varying test to the util hash table

Signed-off-by: Thomas Helland --- src/compiler/glsl/tests/varyings_test.cpp | 73 --- 1 file changed, 29 insertions(+), 44 deletions(-) diff --git a/src/compiler/glsl/tests/varyings_test.cpp b/src/compiler/glsl/tests/varyings_test.cpp

[Mesa-dev] [PATCH 16/23] glsl: Convert if lowering to use a set

Signed-off-by: Thomas Helland --- src/compiler/glsl/lower_if_to_cond_assign.cpp | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/src/compiler/glsl/lower_if_to_cond_assign.cpp b/src/compiler/glsl/lower_if_to_cond_assign.cpp

[Mesa-dev] [PATCH 17/23] glsl: Convert interface block lowering to the util hash table

Signed-off-by: Thomas Helland --- src/compiler/glsl/lower_named_interface_blocks.cpp | 27 +++--- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/src/compiler/glsl/lower_named_interface_blocks.cpp

[Mesa-dev] [PATCH 07/23] glsl: Convert ir_clone to the util hash table

Signed-off-by: Thomas Helland --- src/compiler/glsl/ir_clone.cpp | 31 --- 1 file changed, 16 insertions(+), 15 deletions(-) diff --git a/src/compiler/glsl/ir_clone.cpp b/src/compiler/glsl/ir_clone.cpp index ef2c4c3..b1e5ea8 100644 ---

[Mesa-dev] [PATCH 13/23] glsl: Convert link_varyings to the util hash table

Signed-off-by: Thomas Helland --- src/compiler/glsl/link_varyings.cpp | 58 + 1 file changed, 33 insertions(+), 25 deletions(-) diff --git a/src/compiler/glsl/link_varyings.cpp b/src/compiler/glsl/link_varyings.cpp index

[Mesa-dev] [PATCH 08/23] glsl: Convert ast_to_hir to the util hash table

Signed-off-by: Thomas Helland --- src/compiler/glsl/ast_to_hir.cpp | 26 +++--- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/src/compiler/glsl/ast_to_hir.cpp b/src/compiler/glsl/ast_to_hir.cpp index e03a6e3..01a8a7f 100644 ---

[Mesa-dev] [PATCH 09/23] glsl: Convert constant_expression to the util hash table

Signed-off-by: Thomas Helland --- src/compiler/glsl/ir_constant_expression.cpp | 24 +--- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/src/compiler/glsl/ir_constant_expression.cpp b/src/compiler/glsl/ir_constant_expression.cpp

[Mesa-dev] [PATCH 03/23] mesa: Remove prog_hash_table.c

By now it is just wrapping some hashing functions. This can just as well be done in the header file. Go with static instead of extern for string hashing. Signed-off-by: Thomas Helland --- src/Makefile.am| 1 - src/compiler/SConscript.glsl

[Mesa-dev] [PATCH 02/23] mesa: Replace hashing functions of prog_hash_table

This will make it functionally equivalent to the one in util. This enables us to do a step-by-step replacement of the table. Signed-off-by: Thomas Helland --- src/mesa/program/prog_hash_table.c | 22 -- 1 file changed, 8 insertions(+), 14

[Mesa-dev] [PATCH 05/23] mesa: Convert string_to_uint_map to the util hash table

And remove the now unused hash_table_replace. Signed-off-by: Thomas Helland --- src/mesa/program/hash_table.h | 62 +-- 1 file changed, 18 insertions(+), 44 deletions(-) diff --git a/src/mesa/program/hash_table.h

[Mesa-dev] [PATCH 01/23] mesa: Remove unused hash table includes

This should prevent us from rebuilding the world. Signed-off-by: Thomas Helland --- src/compiler/glsl/link_atomics.cpp | 1 - src/compiler/glsl/link_uniforms.cpp | 1 - src/compiler/glsl/lower_discard_flow.cpp | 1 - src/mesa/main/uniform_query.cpp

[Mesa-dev] [PATCH 06/23] glsl: Convert function inlining to the util hash table

Signed-off-by: Thomas Helland --- src/compiler/glsl/opt_function_inlining.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/compiler/glsl/opt_function_inlining.cpp b/src/compiler/glsl/opt_function_inlining.cpp index 19f5fae..83534bf

[Mesa-dev] [PATCH 10/23] glsl: Convert recursion detection to the util hash table

Signed-off-by: Thomas Helland --- src/compiler/glsl/ir_function_detect_recursion.cpp | 30 -- 1 file changed, 17 insertions(+), 13 deletions(-) diff --git a/src/compiler/glsl/ir_function_detect_recursion.cpp

[Mesa-dev] [PATCH 04/23] util: Move hash_table_call_foreach to util hash table

It is included through the util/hash_table include in the program hash_table, so this should be safe. This will be needed when we start converting each use of the program_hash_table, as some places need this function. Signed-off-by: Thomas Helland ---

[Mesa-dev] [PATCH 12/23] glsl: Change link_functions to use a set

The "locals" hash table is used as a set, so use a set to avoid confusion and also spare some minor memory. Signed-off-by: Thomas Helland --- src/compiler/glsl/link_functions.cpp | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git

[Mesa-dev] [PATCH 00/23] Remove the hash table in mesa/program

This patch series is inspired by Eric's latest work. This should allow us to get rid of the hash table completely. It has been compile tested to ensure every commit compiles, but not it has not seen a piglit run yet. I have ran shader-db at sporadic intervals to ensure things work, and that the

Re: [Mesa-dev] [PATCH] nv50/ir: fix bb positions after exit instructions

On 08/14/2016 04:22 AM, Ilia Mirkin wrote: It's fairly rare that the BB layout puts BBs after the exit block, which is likely the reason these issues lingered for so long. This fixes a fraction of issues with the giant pixmark piano shader. This sounds reasonable to me. Reviewed-by: Samuel

Re: [Mesa-dev] [PATCH] configure: additional libs for OpenCL with LLVM static linking

I am marking this patch as (de-facto) rejected at Patchwork. Reason: The patch moved from the 1st page to the 2nd page of https://patchwork.freedesktop.org/project/mesa/series/?ordering=-last_updated Although I am letting it go you can still merge it to master if you want to. On Wed, Jul 27,

[Mesa-dev] [PATCH] install: check for undefined symbols in shared libraries

This patch ensures that shared libraries installed by Mesa do not contain any undefined symbols. The patch should help lowering the number of users experiencing undefined symbol errors with OpenGL apps. [http://google.sk/search?q=undefined+symbol:+_glapi_tls_Dispatch] 1250 results The patched

Re: [Mesa-dev] [PATCH v3] st/vdpau: change the order in which filters are applied(v3)

Nayan Deshmukh wrote: Hi Andy, So can you please it try it again by replacing VL_MAX_SURFACES with 1 in the for loop. It should probably fix the problems. Yea, I should have though of that - it does fix, but I see things have moved on anyway.

[Mesa-dev] [Bug 89043] undefined symbol: _glapi_tls_Dispatch

https://bugs.freedesktop.org/show_bug.cgi?id=89043 Christian König changed: What|Removed |Added Resolution|--- |INVALID

Re: [Mesa-dev] [PATCH v3] st/vdpau: change the order in which filters are applied(v3)

Am 16.08.2016 um 19:29 schrieb Nayan Deshmukh: Hi Andy, Thanks for testing. On Tue, Aug 16, 2016 at 9:14 PM, Andy Furniss wrote: Nayan Deshmukh wrote: Hi Andy, You are right :( It messes up chroma but only in case of sharpen at least for me. Retested and denoise is

Re: [Mesa-dev] [PATCH v3] st/vdpau: change the order in which filters are applied(v3)

Am 16.08.2016 um 19:50 schrieb Nayan Deshmukh: Hi Christian, On Tue, Aug 16, 2016 at 11:02 PM, Christian König wrote: Am 16.08.2016 um 19:29 schrieb Nayan Deshmukh: Hi Andy, Thanks for testing. On Tue, Aug 16, 2016 at 9:14 PM, Andy Furniss

Re: [Mesa-dev] [PATCH v3] st/vdpau: change the order in which filters are applied(v3)

Hi Christian, On Tue, Aug 16, 2016 at 11:02 PM, Christian König wrote: > Am 16.08.2016 um 19:29 schrieb Nayan Deshmukh: >> >> Hi Andy, >> >> Thanks for testing. >> >> On Tue, Aug 16, 2016 at 9:14 PM, Andy Furniss wrote: >>> >>> Nayan Deshmukh

Re: [Mesa-dev] [PATCH] dri2: Insert a synchronisation point for glXWaitX

On Tue, 2016-08-16 at 15:55 +0100, Chris Wilson wrote: > On Mon, Aug 17, 2015 at 03:17:30PM -0700, Eric Anholt wrote: > > > > I think XSync makes more sense.  It's cheaper, and it does exactly what > > you're supposed to do at this point -- make sure that all your X > > requests have been

[Mesa-dev] [Bug 89043] undefined symbol: _glapi_tls_Dispatch

https://bugs.freedesktop.org/show_bug.cgi?id=89043 Jan Ziak <0xe2.0x9a.0...@gmail.com> changed: What|Removed |Added CC|

[Mesa-dev] [Bug 89043] undefined symbol: _glapi_tls_Dispatch

https://bugs.freedesktop.org/show_bug.cgi?id=89043 --- Comment #6 from Jan Ziak <0xe2.0x9a.0...@gmail.com> --- This issue seems obsoleted due to the 1.5 years of time elapsed since the last comment. Can I mark it as RESOLVED--WONTFIX ? -- You are receiving this mail because: You are the

Re: [Mesa-dev] [PATCH v3] st/vdpau: change the order in which filters are applied(v3)

Hi Andy, Thanks for testing. On Tue, Aug 16, 2016 at 9:14 PM, Andy Furniss wrote: > Nayan Deshmukh wrote: >> >> Hi Andy, > > >> You are right :( It messes up chroma but only in case of sharpen at >> least for me. > > > Retested and denoise is also affected for me. > >> I

[Mesa-dev] [RFC] gbm: wire up fence extension

I noticed that fence extension wasn't exposed for drm/gbm, which sort of defeats the purpose of using fence fd's for synchronizing rendering and atomic pageflip. I suppose that somewhere or other, there needs to be a similar change to .../state_trackers/dri/dri2.c to avoid breaking things on

Re: [Mesa-dev] [PATCH v3] st/vdpau: change the order in which filters are applied(v3)

Nayan Deshmukh wrote: Hi Andy, You are right :( It messes up chroma but only in case of sharpen at least for me. Retested and denoise is also affected for me. I tried some changes and the chroma effects are fixed if we apply the sharpness filter to only to the first surface instead of all

Re: [Mesa-dev] [PATCH] dri2: Insert a synchronisation point for glXWaitX

On Mon, Aug 17, 2015 at 03:17:30PM -0700, Eric Anholt wrote: > Chris Wilson writes: > > > "X rendering calls made prior to glXWaitX are guaranteed to be > > executed before GL rendering calls made after glXWaitX." > > > > The goal is to implement that without adding a

Re: [Mesa-dev] [PATCH] st/vdpau: use temporary buffers while applying filters

Hi, I sent out the patch in a hurry and later noticed that the coding style is off at some places especially the ifs. I will send a new patch with fixes once the patch before this is verified by Andy. Regards, Nayan. On Tue, Aug 16, 2016 at 2:53 PM, Nayan Deshmukh

Re: [Mesa-dev] [PATCH v3] st/vdpau: change the order in which filters are applied(v3)

Hi Andy, On Tue, Aug 16, 2016 at 3:20 PM, Andy Furniss wrote: > Christian König wrote: >> >> Am 12.08.2016 um 16:02 schrieb Nayan Deshmukh: >>> >>> Apply the median and matrix filter before the compostioning >>> we apply the deinterlacing first to avoid the extra overhead

[Mesa-dev] [PATCH] mesa/st: use llabs instead of abs for long args (v2)

v2: long has 32bit on Windows (Marek) Signed-off-by: Francesco Ansanelli --- src/mesa/state_tracker/st_atom_array.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_atom_array.c b/src/mesa/state_tracker/st_atom_array.c index

Re: [Mesa-dev] [PATCH] mesa: Fix uf10_to_f32() scale factor in the E == 0 and M != 0 case.

The patch looks good to me. Reviewed-by: Antia Puentes On lun, 2016-08-15 at 23:50 -0700, Kenneth Graunke wrote: > GL_EXT_packed_float, 2.1.B Unsigned 10-Bit Floating-Point Numbers: > > 0.0,  if E == 0 and M == 0, > 2^-14 * (M / 32), 

Re: [Mesa-dev] [PATCH] egl/x11: avoid using freed memory if dri2 init fails

On Mon, Aug 15, 2016 at 11:46:40AM -0700, Kristian Høgsberg wrote: > On Mon, Aug 15, 2016 at 11:33 AM, ⚛ <0xe2.0x9a.0...@gmail.com> wrote: > > On Mon, Aug 15, 2016 at 8:08 PM, Emil Velikov > > wrote: > >> > >> On 4 August 2016 at 03:13, Nicolas Boichat

Re: [Mesa-dev] [PATCH 4/4] st/mesa: use pipe var instead of st->pipe in st_create_context_priv()

For the series: Reviewed-by: Marek Olšák Marek On Tue, Aug 16, 2016 at 12:07 AM, Brian Paul wrote: > As is done in most other places in the function. > --- > src/mesa/state_tracker/st_context.c | 8 > 1 file changed, 4 insertions(+), 4

Re: [Mesa-dev] [PATCH] mesa/st: use labs instead of abs for long args Signed-off-by: Francesco Ansanelli <franci...@gmail.com>

This is not portable, because long has 32 bits on Windows. Alternative solutions: - llabs - MAX2(a, -a) Marek On Tue, Aug 16, 2016 at 10:15 AM, Francesco Ansanelli wrote: > --- > src/mesa/state_tracker/st_atom_array.c |2 +- > 1 file changed, 1 insertion(+), 1

Re: [Mesa-dev] [PATCH v3] st/vdpau: change the order in which filters are applied(v3)

Christian König wrote: Am 12.08.2016 um 16:02 schrieb Nayan Deshmukh: Apply the median and matrix filter before the compostioning we apply the deinterlacing first to avoid the extra overhead in processing the past and the future surfaces in deinterlacing. v2: apply the filters on all the

Re: [Mesa-dev] [PATCH 1/3] gallium: change pipe_sampler_view::first_element/last_element -> offset/size

On Tue, Aug 16, 2016 at 1:14 AM, Roland Scheidegger wrote: > Am 15.08.2016 um 19:48 schrieb Marek Olšák: >> On Sun, Aug 14, 2016 at 11:38 AM, Marek Olšák wrote: >>> On Aug 12, 2016 8:49 PM, "Roland Scheidegger" wrote: I can't

Re: [Mesa-dev] [PATCH 3/6] gallium/u_blitter: split out a helper for common clear state

On Tue, Aug 16, 2016 at 4:02 AM, Rob Clark wrote: > On Mon, Aug 15, 2016 at 10:44 AM, Marek Olšák wrote: >> On Sat, Aug 13, 2016 at 8:57 PM, Rob Clark wrote: >>> On Sat, Aug 13, 2016 at 2:23 PM, Rob Clark wrote:

[Mesa-dev] [PATCH] st/vdpau: use temporary buffers while applying filters

We temporary buffers so that we don't read and write to the same surface at the same time. Signed-off-by: Nayan Deshmukh --- src/gallium/state_trackers/vdpau/mixer.c | 54 ++-- 1 file changed, 45 insertions(+), 9 deletions(-) diff --git

[Mesa-dev] [Bug 97214] X not running with error "Failed to make EGL context current"

https://bugs.freedesktop.org/show_bug.cgi?id=97214 Michel Dänzer changed: What|Removed |Added Resolution|--- |FIXED

Re: [Mesa-dev] [PATCH v2] egl/dri2: dri2_make_current: Release previous context's display

On 11/08/16 05:43 PM, Nicolas Boichat wrote: > eglMakeCurrent can also be used to change the active display. In that > case, we need to decrement ref_count of the previous display (possibly > destroying it), and increment it on the next display. > > Also, old_dsurf/old_rsurf cannot be non-NULL if

[Mesa-dev] [PATCH] mesa/st: use labs instead of abs for long args Signed-off-by: Francesco Ansanelli <franci...@gmail.com>

--- src/mesa/state_tracker/st_atom_array.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_atom_array.c b/src/mesa/state_tracker/st_atom_array.c index dcead27..70247b9 100644 --- a/src/mesa/state_tracker/st_atom_array.c +++

Re: [Mesa-dev] [PATCH v3] st/vdpau: change the order in which filters are applied(v3)

Am 12.08.2016 um 16:02 schrieb Nayan Deshmukh: Apply the median and matrix filter before the compostioning we apply the deinterlacing first to avoid the extra overhead in processing the past and the future surfaces in deinterlacing. v2: apply the filters on all the surfaces (Christian) v3: use

Re: [Mesa-dev] [PATCH] glx: Don't use current context in __glXSendError

On 08/16/2016 10:23 AM, Michel Dänzer wrote: On 16/08/16 04:11 PM, Tapani Pälli wrote: On 08/16/2016 09:49 AM, Michel Dänzer wrote: From: Michel Dänzer There's no guarantee that there is one, and we don't need one anyway. Fixes piglit tests: glx@glx-fbconfig-bad

Re: [Mesa-dev] [PATCH] glx: Don't use current context in __glXSendError

On 16/08/16 04:11 PM, Tapani Pälli wrote: > On 08/16/2016 09:49 AM, Michel Dänzer wrote: >> From: Michel Dänzer >> >> There's no guarantee that there is one, and we don't need one anyway. >> >> Fixes piglit tests: >> >> glx@glx-fbconfig-bad > > this one passes for me with

Re: [Mesa-dev] [PATCH] glx: Don't use current context in __glXSendError

Hi; On 08/16/2016 09:49 AM, Michel Dänzer wrote: From: Michel Dänzer There's no guarantee that there is one, and we don't need one anyway. Fixes piglit tests: glx@glx-fbconfig-bad this one passes for me with and without the patch glx@glx_ext_import_context@import

[Mesa-dev] [PATCH] mesa: Fix uf10_to_f32() scale factor in the E == 0 and M != 0 case.

GL_EXT_packed_float, 2.1.B Unsigned 10-Bit Floating-Point Numbers: 0.0, if E == 0 and M == 0, 2^-14 * (M / 32), if E == 0 and M != 0, 2^(E-15) * (1 + M/32),if 0 < E < 31, INF, if E == 31 and M == 0, or

[Mesa-dev] [PATCH] glx: Don't use current context in __glXSendError

From: Michel Dänzer There's no guarantee that there is one, and we don't need one anyway. Fixes piglit tests: glx@glx-fbconfig-bad glx@glx_ext_import_context@import context, multi process glx@glx_ext_import_context@import context, single process Fixes: 2e3f067458e4

[Mesa-dev] [PATCH] i965: use nir_lower_indirect_derefs() for GLSL

This moves the nir_lower_indirect_derefs() call into brw_preprocess_nir() so thats is called by both OpenGL and Vulkan and removes that call to the old GLSL IR pass lower_variable_index_to_cond_assign() We want to do this pass in nir to be able to move loop unrolling to nir. There is a increase