Re: [Mesa-dev] [PATCH] nir/phi_builder: Don't recurse in value_get_block_def

2016-08-24 Thread Thomas Helland
2016-08-25 7:49 GMT+02:00 Jason Ekstrand : > In some programs, we can have very deep dominance trees and the recursion > can cause us to risk stack overflows. Instead, we replace the recursion > with a pair of loops, one at the start and one at the end. This is >

Re: [Mesa-dev] [PATCH 00/16] Enable OpenGLES 3.1 on Haswell

2016-08-24 Thread Pohjolainen, Topi
On Wed, Aug 24, 2016 at 05:51:22PM -0700, Ian Romanick wrote: > On 08/24/2016 04:54 PM, Jordan Justen wrote: > > git://people.freedesktop.org/~jljusten/mesa hsw-es31-v1 > > > > Since gen7 doesn't support sampling from a stencil buffer, we copy the > > stencil texture to an R8_UINT texture, and

[Mesa-dev] [Bug 97444] mesa git crashes in libxshmfence

2016-08-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97444 Michel Dänzer changed: What|Removed |Added Component|Other |Driver/AMDgpu

[Mesa-dev] [PATCH] nir/phi_builder: Don't recurse in value_get_block_def

2016-08-24 Thread Jason Ekstrand
In some programs, we can have very deep dominance trees and the recursion can cause us to risk stack overflows. Instead, we replace the recursion with a pair of loops, one at the start and one at the end. This is functionally equivalent to what we had before and it's actually a bit easier to

Re: [Mesa-dev] [PATCH] i965: Safely iterate the predecessors of the end block.

2016-08-24 Thread Connor Abbott
On Thu, Aug 25, 2016 at 1:25 AM, Kenneth Graunke wrote: > We want to insert code in each of the predecessors of the end block. > This code includes a nir_if, which would split the block, altering > the set. To avoid that, I emitted a dead constant at the end of each >

Re: [Mesa-dev] [PATCH 10/16] i965: Add function to copy a stencil miptree to an R8_UINT miptree

2016-08-24 Thread Pohjolainen, Topi
On Wed, Aug 24, 2016 at 04:55:02PM -0700, Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 55 > ++- > src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 4 ++ > 2 files changed, 58

Re: [Mesa-dev] [PATCH 12/16] i965/gen7: Use R8_UINT stencil copy when sampling the stencil texture

2016-08-24 Thread Jordan Justen
On 2016-08-24 17:40:42, Ian Romanick wrote: > On 08/24/2016 04:55 PM, Jordan Justen wrote: > > Signed-off-by: Jordan Justen > > --- > > src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 13 +++-- > > 1 file changed, 11 insertions(+), 2 deletions(-) > > > >

Re: [Mesa-dev] [PATCH 10/16] i965: Add function to copy a stencil miptree to an R8_UINT miptree

2016-08-24 Thread Jordan Justen
On 2016-08-24 17:44:44, Matt Turner wrote: > On Wed, Aug 24, 2016 at 4:55 PM, Jordan Justen > wrote: > > Signed-off-by: Jordan Justen > > --- > > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 55 > > ++- > >

Re: [Mesa-dev] [PATCH 04/16] i965/hsw: Adjust uploading default color for stencil surfaces

2016-08-24 Thread Jordan Justen
On 2016-08-24 17:54:23, Kenneth Graunke wrote: > On Wednesday, August 24, 2016 5:49:53 PM PDT Ian Romanick wrote: > > On 08/24/2016 05:46 PM, Matt Turner wrote: > > > On Wed, Aug 24, 2016 at 4:54 PM, Jordan Justen > > > wrote: > > >> - if

[Mesa-dev] [PATCH] i965: Safely iterate the predecessors of the end block.

2016-08-24 Thread Kenneth Graunke
We want to insert code in each of the predecessors of the end block. This code includes a nir_if, which would split the block, altering the set. To avoid that, I emitted a dead constant at the end of each block before splitting it, so that the set of predecessors remained unchanged. This was

Re: [Mesa-dev] [PATCH 04/16] i965/hsw: Adjust uploading default color for stencil surfaces

2016-08-24 Thread Pohjolainen, Topi
On Wed, Aug 24, 2016 at 05:34:49PM -0700, Ian Romanick wrote: > On 08/24/2016 04:54 PM, Jordan Justen wrote: > > Signed-off-by: Jordan Justen > > --- > > src/mesa/drivers/dri/i965/brw_sampler_state.c | 8 ++-- > > 1 file changed, 6 insertions(+), 2 deletions(-) > >

Re: [Mesa-dev] [PATCH v1 00/13] Implement sw_sync test

2016-08-24 Thread Gustavo Padovan
2016-08-24 Daniel Vetter : > On Tue, Aug 23, 2016 at 01:56:02PM -0400, robert.f...@collabora.com wrote: > > From: Robert Foss > > > > This series implements the sw_sync test and the lib/sw_sync helper functions > > for said test. > > > > Gustavo

Re: [Mesa-dev] [PATCH] meta: Always do GenerateMipmaps in linear colorspace.

2016-08-24 Thread Kenneth Graunke
On Friday, August 12, 2016 3:59:35 PM PDT Kenneth Graunke wrote: > When generating mipmaps for sRGB textures, force both decode and encode, > so the filtering is done in linear colorspace, regardless of settings. > > Fixes a WebGL conformance test in Chrome: >

Re: [Mesa-dev] [PATCH 2/3] glsl: Fix incorrect hard-coded location of the gl_SecondaryFragColorEXT built-in.

2016-08-24 Thread Francisco Jerez
Ilia Mirkin writes: > On Thu, Aug 25, 2016 at 12:45 AM, Francisco Jerez > wrote: >> Ilia Mirkin writes: >> >>> On Wed, Aug 24, 2016 at 4:30 PM, Francisco Jerez >>> wrote: Ilia Mirkin

Re: [Mesa-dev] [PATCH 2/3] glsl: Fix incorrect hard-coded location of the gl_SecondaryFragColorEXT built-in.

2016-08-24 Thread Ilia Mirkin
On Thu, Aug 25, 2016 at 12:45 AM, Francisco Jerez wrote: > Ilia Mirkin writes: > >> On Wed, Aug 24, 2016 at 4:30 PM, Francisco Jerez >> wrote: >>> Ilia Mirkin writes: >>> I had trouble getting these

Re: [Mesa-dev] [PATCH 2/3] glsl: Fix incorrect hard-coded location of the gl_SecondaryFragColorEXT built-in.

2016-08-24 Thread Francisco Jerez
Ilia Mirkin writes: > On Wed, Aug 24, 2016 at 4:30 PM, Francisco Jerez > wrote: >> Ilia Mirkin writes: >> >>> I had trouble getting these to apply, perhaps they were meant to go on >>> top of something else. Anyways, should be

Re: [Mesa-dev] Intel: Please help define the common rectangle primitive type

2016-08-24 Thread Jason Ekstrand
On Wed, Aug 24, 2016 at 2:42 PM, Marek Olšák wrote: > On Wed, Aug 24, 2016 at 10:42 PM, Jason Ekstrand > wrote: > > On Wed, Aug 24, 2016 at 11:46 AM, Marek Olšák wrote: > >> > >> On Fri, Aug 5, 2016 at 1:22 AM, Kenneth Graunke

[Mesa-dev] [PATCH 2/3] nir: Change nir_shader_get_entrypoint to return an impl.

2016-08-24 Thread Kenneth Graunke
Jason suggested adding an assert(function->impl) here. All callers of this function actually want ->impl, so I decided just to change the API. We also change the nir_lower_io_to_temporaries API here. All but one caller passed nir_shader_get_entrypoint(), and with the previous commit, it now

[Mesa-dev] [PATCH 3/3] nir: Use nir_shader_get_entrypoint in TCS quad workaround code.

2016-08-24 Thread Kenneth Graunke
We want to insert the code at the end of the program. Looping over all the functions (of which there was only one) was the old way of doing this, but now we have nir_shader_get_entrypoint(), so let's use it. Suggested by Connor Abbott. v2: Update for nir_shader_get_entrypoint API change.

[Mesa-dev] [PATCH 1/3] nir: Make nir_lower_io_to_temporaries store an impl internally.

2016-08-24 Thread Kenneth Graunke
This changes the pass internals to work with a nir_function_impl directly rather than a nir_function. The next patch will change the API. Signed-off-by: Kenneth Graunke Reviewed-by: Jason Ekstrand --- src/compiler/nir/nir_lower_io_to_temporaries.c

Re: [Mesa-dev] [PATCH 2/3] glsl: Fix incorrect hard-coded location of the gl_SecondaryFragColorEXT built-in.

2016-08-24 Thread Ilia Mirkin
On Wed, Aug 24, 2016 at 4:30 PM, Francisco Jerez wrote: > Ilia Mirkin writes: > >> I had trouble getting these to apply, perhaps they were meant to go on >> top of something else. Anyways, should be fairly easy for you to test >> out with llvmpipe. >>

[Mesa-dev] [PATCH] nir: Walk blocks in source code order in lower_vars_to_ssa.

2016-08-24 Thread Matt Turner
Prior to this commit rename_variables_block() is recursively called, performing a depth-first traversal of the control flow graph. The function uses a non-trivial amount of stack space for local variables, which puts us in danger of smashing the stack, given a sufficiently deep dominance tree.

Re: [Mesa-dev] [Mesa-stable] [PATCH] glsl: remove ARB_compute_shader ext, always allow local_size_* qualifiers

2016-08-24 Thread Ilia Mirkin
On Wed, Aug 24, 2016 at 6:19 PM, Ian Romanick wrote: > On 08/24/2016 12:57 PM, Ilia Mirkin wrote: >> On Wed, Aug 24, 2016 at 3:40 PM, Ian Romanick wrote: >>> On 08/24/2016 10:40 AM, Ilia Mirkin wrote: The GL_ARB_compute_shader spec does not make a

Re: [Mesa-dev] [PATCH 1/4] i965: move subreg_offset to backend_reg

2016-08-24 Thread Francisco Jerez
Iago Toral writes: > On Tue, 2016-08-23 at 12:58 -0700, Francisco Jerez wrote: >> Iago Toral Quiroga writes: >> >> > >> > So we can access it in the vec4 backend to handle byte offsets into >> > registers. >> This change has deep implications in the

[Mesa-dev] [Bug 97444] mesa git crashes in libxshmfence

2016-08-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97444 --- Comment #4 from Fabian Maurer --- I managed to downgrade mesa to 11.2.2, but the issue persisted. Figured out it can be fixed by downgrading "xf86-video-amdgpu" from git to stable. Now I'm not sure wheter this bug is a

Re: [Mesa-dev] [PATCH 15/17] i965: Enable OES_texture_cube_map on Gen8+

2016-08-24 Thread Ian Romanick
On 08/24/2016 03:59 PM, Ilia Mirkin wrote: > Subject should say OES_texture_cube_map_array Heh... fixed locally. :) > On Wed, Aug 24, 2016 at 6:12 PM, Ian Romanick wrote: >> From: Ian Romanick >> >> These are the only platforms that current

Re: [Mesa-dev] [PATCH 04/16] i965/hsw: Adjust uploading default color for stencil surfaces

2016-08-24 Thread Kenneth Graunke
On Wednesday, August 24, 2016 5:49:53 PM PDT Ian Romanick wrote: > On 08/24/2016 05:46 PM, Matt Turner wrote: > > On Wed, Aug 24, 2016 at 4:54 PM, Jordan Justen > > wrote: > >> Signed-off-by: Jordan Justen > >> --- > >>

Re: [Mesa-dev] [PATCH 14/17] mesa: Add support for OES_texture_cube_map_array

2016-08-24 Thread Ian Romanick
On 08/24/2016 03:59 PM, Ilia Mirkin wrote: > On Wed, Aug 24, 2016 at 6:12 PM, Ian Romanick wrote: >> From: Ian Romanick >> >> This has a separate enable flag because this extension also requires >> OES_geometry_shader. It is possible that some

Re: [Mesa-dev] [PATCH 00/16] Enable OpenGLES 3.1 on Haswell

2016-08-24 Thread Ian Romanick
On 08/24/2016 04:54 PM, Jordan Justen wrote: > git://people.freedesktop.org/~jljusten/mesa hsw-es31-v1 > > Since gen7 doesn't support sampling from a stencil buffer, we copy the > stencil texture to an R8_UINT texture, and sample from it instead. > > This allows us to enable

Re: [Mesa-dev] [PATCH 04/16] i965/hsw: Adjust uploading default color for stencil surfaces

2016-08-24 Thread Ian Romanick
On 08/24/2016 05:46 PM, Matt Turner wrote: > On Wed, Aug 24, 2016 at 4:54 PM, Jordan Justen > wrote: >> Signed-off-by: Jordan Justen >> --- >> src/mesa/drivers/dri/i965/brw_sampler_state.c | 8 ++-- >> 1 file changed, 6 insertions(+), 2

Re: [Mesa-dev] [PATCH 04/16] i965/hsw: Adjust uploading default color for stencil surfaces

2016-08-24 Thread Matt Turner
On Wed, Aug 24, 2016 at 4:54 PM, Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > src/mesa/drivers/dri/i965/brw_sampler_state.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH 10/16] i965: Add function to copy a stencil miptree to an R8_UINT miptree

2016-08-24 Thread Matt Turner
On Wed, Aug 24, 2016 at 4:55 PM, Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 55 > ++- > src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 4 ++ > 2

Re: [Mesa-dev] [PATCH 12/16] i965/gen7: Use R8_UINT stencil copy when sampling the stencil texture

2016-08-24 Thread Ian Romanick
On 08/24/2016 04:55 PM, Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 13 +++-- > 1 file changed, 11 insertions(+), 2 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH 10/16] i965: Add function to copy a stencil miptree to an R8_UINT miptree

2016-08-24 Thread Ian Romanick
On 08/24/2016 04:55 PM, Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 55 > ++- > src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 4 ++ > 2 files changed, 58 insertions(+), 1

Re: [Mesa-dev] [PATCH 04/16] i965/hsw: Adjust uploading default color for stencil surfaces

2016-08-24 Thread Ian Romanick
On 08/24/2016 04:54 PM, Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > src/mesa/drivers/dri/i965/brw_sampler_state.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_sampler_state.c >

Re: [Mesa-dev] [PATCH 1/2] anv: Add a --disable-vulkan-icd-full-driver-path option

2016-08-24 Thread Dave Airlie
On 23 August 2016 at 11:11, Jason Ekstrand wrote: > This option makes installed Vulkan ICD files contain only a driver library > name and not a path. This is intended for distros to help them work around > multi-arch issues. Can we at least push this for now? Reviewed-by:

Re: [Mesa-dev] [PATCH] anv: Include the pipeline layout in the shader hash

2016-08-24 Thread Kristian Høgsberg
On Wed, Aug 24, 2016 at 5:16 PM, Jason Ekstrand wrote: > The pipeline layout affects shader compilation because it is what > determines binding table locations as well as whether or not a particular > buffer has dynamic offsets. Since this affects the generated shader, it >

Re: [Mesa-dev] [PATCH mesa] configure.ac: raise Mako required version to 0.8.0

2016-08-24 Thread Dave Airlie
On 24 August 2016 at 20:43, Emil Velikov wrote: > On 19 July 2016 at 13:41, Eric Engestrom wrote: >> It seems [0] old versions of Mako are no longer supported. Emil mentioned it >> might need v0.8.0 [1] for isl_format_layout [2], although I

[Mesa-dev] [PATCH] anv: Include the pipeline layout in the shader hash

2016-08-24 Thread Jason Ekstrand
The pipeline layout affects shader compilation because it is what determines binding table locations as well as whether or not a particular buffer has dynamic offsets. Since this affects the generated shader, it needs to be in the hash. This fixes a bunch of CTS tests now that the CTS is using a

Re: [Mesa-dev] [PATCH 17/17] glsl: Don't monkey about with the interpolation modes

2016-08-24 Thread Timothy Arceri
On Thu, 2016-08-25 at 10:00 +1000, Timothy Arceri wrote: > On Wed, 2016-08-24 at 15:12 -0700, Ian Romanick wrote: > > > > From: Ian Romanick > > > > Previously we'd munge the interpolation mode so that later checks > > in > > the > > GLSL linker would pass.  The caused

Re: [Mesa-dev] [PATCH 17/17] glsl: Don't monkey about with the interpolation modes

2016-08-24 Thread Kenneth Graunke
On Wednesday, August 24, 2016 3:12:43 PM PDT Ian Romanick wrote: > From: Ian Romanick > > Previously we'd munge the interpolation mode so that later checks in the > GLSL linker would pass. The caused problems for similar checks in SSO > IO validation. Instead, make

Re: [Mesa-dev] [PATCH 17/17] glsl: Don't monkey about with the interpolation modes

2016-08-24 Thread Timothy Arceri
On Wed, 2016-08-24 at 15:12 -0700, Ian Romanick wrote: > From: Ian Romanick > > Previously we'd munge the interpolation mode so that later checks in > the > GLSL linker would pass.  The caused problems for similar checks in > SSO > IO validation.  Instead, make the

[Mesa-dev] [PATCH 02/16] main: Add MESA_VERBOSE=api support for glClearStencil

2016-08-24 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/main/stencil.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/main/stencil.c b/src/mesa/main/stencil.c index 409b2f0..b303bb7 100644 --- a/src/mesa/main/stencil.c +++ b/src/mesa/main/stencil.c @@ -109,6 +109,9

[Mesa-dev] [PATCH 14/16] i965: Enable ARB_texture_stencil8 for Haswell

2016-08-24 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/intel_extensions.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c b/src/mesa/drivers/dri/i965/intel_extensions.c index aaebd08..756f04d 100644

[Mesa-dev] [PATCH 01/16] main: Add MESA_VERBOSE=api support for glTexImage

2016-08-24 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/main/teximage.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index 8869b3d..efde114 100644 --- a/src/mesa/main/teximage.c +++ b/src/mesa/main/teximage.c @@ -5341,6

[Mesa-dev] [PATCH 13/16] i965: Enable ARB_stencil_texturing for Haswell

2016-08-24 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/intel_extensions.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c b/src/mesa/drivers/dri/i965/intel_extensions.c index 466c384..aaebd08

[Mesa-dev] [PATCH 15/16] i965: Enable OpenGLES 3.1 for Haswell

2016-08-24 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/intel_screen.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/mesa/drivers/dri/i965/intel_screen.c b/src/mesa/drivers/dri/i965/intel_screen.c index 7876652..3ffbf39 100644 ---

[Mesa-dev] [PATCH 07/16] i965: Track that the stencil data was updated when clearing

2016-08-24 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_clear.c | 8 1 file changed, 8 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_clear.c b/src/mesa/drivers/dri/i965/brw_clear.c index 1dfff09..18b8fcb 100644 ---

[Mesa-dev] [PATCH 12/16] i965/gen7: Use R8_UINT stencil copy when sampling the stencil texture

2016-08-24 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_wm_surface_state.c b/src/mesa/drivers/dri/i965/brw_wm_surface_state.c

[Mesa-dev] [PATCH 03/16] i965/hsw: Don't advertise more than 64 threads for compute shaders

2016-08-24 Thread Jordan Justen
thread_width_max in the GPGPU walker command limits us to a maximum of 64 threads. This fixes a crash on Haswell in the OpenGLES 3.1 conformance test suite which tests the advertised limits of the max invocation counts. Signed-off-by: Jordan Justen ---

[Mesa-dev] [PATCH 04/16] i965/hsw: Adjust uploading default color for stencil surfaces

2016-08-24 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_sampler_state.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_sampler_state.c b/src/mesa/drivers/dri/i965/brw_sampler_state.c index

[Mesa-dev] [PATCH 16/16] docs: Update stencil texturing & ES 3.1 status for i965 Haswell

2016-08-24 Thread Jordan Justen
Signed-off-by: Jordan Justen --- docs/GL3.txt | 6 +++--- docs/relnotes/12.1.0.html | 3 +++ 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index 084c17e..5dd9e41 100644 --- a/docs/GL3.txt +++ b/docs/GL3.txt @@

[Mesa-dev] [PATCH 06/16] i965/gen7: Add R8_UINT stencil miptree copy for sampling

2016-08-24 Thread Jordan Justen
For gen < 8, we can't sample from the stencil buffer, which is required for the ARB_stencil_texturing extension. We'll make a copy of the stencil data into a new texture that we can sample using the R8_UINT surface type. Signed-off-by: Jordan Justen ---

[Mesa-dev] [PATCH 09/16] i965: Track that the stencil data was updated when using Tex*Image

2016-08-24 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/intel_tex_image.c| 3 +++ src/mesa/drivers/dri/i965/intel_tex_subimage.c | 7 +-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_tex_image.c

[Mesa-dev] [PATCH 11/16] i965/gen7: Copy stencil when sampling the stencil texture

2016-08-24 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_context.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_context.c b/src/mesa/drivers/dri/i965/brw_context.c index d8a3723..d38b483 100644 ---

[Mesa-dev] [PATCH 00/16] Enable OpenGLES 3.1 on Haswell

2016-08-24 Thread Jordan Justen
git://people.freedesktop.org/~jljusten/mesa hsw-es31-v1 Since gen7 doesn't support sampling from a stencil buffer, we copy the stencil texture to an R8_UINT texture, and sample from it instead. This allows us to enable ARB_stencil_texturing and OpenGLES 3.1 on Haswell. Ivy Bridge and Baytrail

[Mesa-dev] [PATCH 10/16] i965: Add function to copy a stencil miptree to an R8_UINT miptree

2016-08-24 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 55 ++- src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 4 ++ 2 files changed, 58 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 08/16] i965: Track that the stencil data was updated when rendering

2016-08-24 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/gen7_misc_state.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/gen7_misc_state.c b/src/mesa/drivers/dri/i965/gen7_misc_state.c index ffdf6f2..271d962 100644 ---

[Mesa-dev] [PATCH 05/16] i965: Fix assert with multisampling and cubemaps

2016-08-24 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c index

Re: [Mesa-dev] [PATCH 00/17] Enable

2016-08-24 Thread Ilia Mirkin
Patches 1-16 are Reviewed-by: Ilia Mirkin I left a few comments on a handful, but other than the one you've already addressed, none are particularly important. You'll have to sucker someone else into looking at patch 17, I'm afraid. On Wed, Aug 24, 2016 at 6:12 PM, Ian

Re: [Mesa-dev] [PATCH 15/17] i965: Enable OES_texture_cube_map on Gen8+

2016-08-24 Thread Ilia Mirkin
Subject should say OES_texture_cube_map_array On Wed, Aug 24, 2016 at 6:12 PM, Ian Romanick wrote: > From: Ian Romanick > > These are the only platforms that current expose OES_geometry_shader. > Once OpenGL ES 3.1 and OES_geometry_shader are

Re: [Mesa-dev] [PATCH 14/17] mesa: Add support for OES_texture_cube_map_array

2016-08-24 Thread Ilia Mirkin
On Wed, Aug 24, 2016 at 6:12 PM, Ian Romanick wrote: > From: Ian Romanick > > This has a separate enable flag because this extension also requires > OES_geometry_shader. It is possible that some drivers may support > OpenGL ES 3.1 and

Re: [Mesa-dev] [PATCH 13/17] mesa: Add and use _mesa_has_texture_cube_map_array helper

2016-08-24 Thread Ilia Mirkin
On Wed, Aug 24, 2016 at 6:12 PM, Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick > --- > src/mesa/main/context.h | 5 + > src/mesa/main/teximage.c | 12 ++-- >

Re: [Mesa-dev] [PATCH 03/17] glsl: Allow gl_InvocationID and gl_Layer with GL_OES_geometry_shader

2016-08-24 Thread Ian Romanick
On 08/24/2016 03:18 PM, Ilia Mirkin wrote: > On Wed, Aug 24, 2016 at 6:12 PM, Ian Romanick wrote: >> From: Ian Romanick >> >> Fixes >> >> dEQP-GLES31.functional.geometry_shading.layered.fragment_layer_2d_array >>

Re: [Mesa-dev] [Mesa-stable] [PATCH] glsl: remove ARB_compute_shader ext, always allow local_size_* qualifiers

2016-08-24 Thread Ian Romanick
On 08/24/2016 12:57 PM, Ilia Mirkin wrote: > On Wed, Aug 24, 2016 at 3:40 PM, Ian Romanick wrote: >> On 08/24/2016 10:40 AM, Ilia Mirkin wrote: >>> The GL_ARB_compute_shader spec does not make a mention of a #extension >>> enable, nor a #define with the ext name. It follows

Re: [Mesa-dev] [PATCH 03/17] glsl: Allow gl_InvocationID and gl_Layer with GL_OES_geometry_shader

2016-08-24 Thread Ilia Mirkin
On Wed, Aug 24, 2016 at 6:12 PM, Ian Romanick wrote: > From: Ian Romanick > > Fixes > > dEQP-GLES31.functional.geometry_shading.layered.fragment_layer_2d_array > dEQP-GLES31.functional.geometry_shading.layered.fragment_layer_2d_multisample_array >

[Mesa-dev] [PATCH 17/17] glsl: Don't monkey about with the interpolation modes

2016-08-24 Thread Ian Romanick
From: Ian Romanick Previously we'd munge the interpolation mode so that later checks in the GLSL linker would pass. The caused problems for similar checks in SSO IO validation. Instead, make the check smarter, use the same check in both places, and don't modify the

[Mesa-dev] [PATCH 09/17] glsl: Add and use has_texture_cube_map_array helper

2016-08-24 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/compiler/glsl/builtin_functions.cpp | 6 ++ src/compiler/glsl/glsl_parser_extras.h | 6 ++ 2 files changed, 8 insertions(+), 4 deletions(-) diff --git

[Mesa-dev] [PATCH 07/17] glsl: Silence unused parameter warning

2016-08-24 Thread Ian Romanick
From: Ian Romanick glsl/lower_buffer_access.cpp:324:55: warning: unused parameter ‘var’ [-Wunused-parameter] ir_variable *var, ^ Signed-off-by: Ian Romanick

[Mesa-dev] [PATCH 16/17] mesa/version: OpenGL ES 3.2 depends on OES_texture_cube_map_array

2016-08-24 Thread Ian Romanick
From: Ian Romanick This has a separate enable from ARB_texture_cube_map_array. Signed-off-by: Ian Romanick --- src/mesa/main/version.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/version.c

[Mesa-dev] [PATCH 00/17] Enable

2016-08-24 Thread Ian Romanick
This series enables GL_OES_geometry_shader and GL_OES_texutre_cube_map_array. There are still a number of failures with this series, but I would like to land it anyway so that I don't have to keep rebasing it. Here is my analysis of the failures:

[Mesa-dev] [PATCH 14/17] mesa: Add support for OES_texture_cube_map_array

2016-08-24 Thread Ian Romanick
From: Ian Romanick This has a separate enable flag because this extension also requires OES_geometry_shader. It is possible that some drivers may support OpenGL ES 3.1 and ARB_texture_cube_map but not support OES_geometry_shader. Signed-off-by: Ian Romanick

[Mesa-dev] [PATCH 13/17] mesa: Add and use _mesa_has_texture_cube_map_array helper

2016-08-24 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/main/context.h | 5 + src/mesa/main/teximage.c | 12 ++-- src/mesa/main/texobj.c | 4 ++-- 3 files changed, 13 insertions(+), 8 deletions(-) diff --git

[Mesa-dev] [PATCH 12/17] mesa: Use _mesa_has_ARB_texture_cube_map_array instead of open-coding it

2016-08-24 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/main/genmipmap.c | 3 +-- src/mesa/main/get.c | 2 +- src/mesa/main/texobj.c| 2 +- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/src/mesa/main/genmipmap.c

[Mesa-dev] [PATCH 02/17] mesa: Allow GL_EXT_geometry_shader and GL_EXT_geometry_point_size

2016-08-24 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/compiler/glsl/builtin_variables.cpp | 3 ++- src/compiler/glsl/glsl_parser_extras.cpp | 2 ++ src/compiler/glsl/glsl_parser_extras.h | 8 +++- src/mapi/glapi/gen/es_EXT.xml

[Mesa-dev] [PATCH 03/17] glsl: Allow gl_InvocationID and gl_Layer with GL_OES_geometry_shader

2016-08-24 Thread Ian Romanick
From: Ian Romanick Fixes dEQP-GLES31.functional.geometry_shading.layered.fragment_layer_2d_array dEQP-GLES31.functional.geometry_shading.layered.fragment_layer_2d_multisample_array dEQP-GLES31.functional.geometry_shading.layered.fragment_layer_3d

[Mesa-dev] [PATCH 06/17] i965: Enable GL_OES_geometry_shader on Gen8+

2016-08-24 Thread Ian Romanick
From: Ian Romanick Gen7 can get this extension (and GL_OES_shader_io_blocks) as soon as the rest of OpenGL ES 3.1 is enabled. Signed-off-by: Ian Romanick --- docs/features.txt| 2 +- docs/relnotes/12.1.0.html

[Mesa-dev] [PATCH 01/17] mesa: Document reasons for allowing XFB drawing modes in GLES 3.1 w/GL_OES_geometry_shader

2016-08-24 Thread Ian Romanick
From: Ian Romanick Originally this patch added the checks to allow the draw calls with XFB, but commit 2dabd497 beat me to it. Signed-off-by: Ian Romanick --- src/mesa/main/api_validate.c | 33 +++-- 1 file

[Mesa-dev] [PATCH 11/17] mesa: Cosmetic changes in legal_texobj_target

2016-08-24 Thread Ian Romanick
From: Ian Romanick Use bool instead of GLboolean and constify ctx. Signed-off-by: Ian Romanick --- src/mesa/main/texstorage.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git

[Mesa-dev] [PATCH 08/17] glsl: Mark cube map array sampler types as reserved in GLSL ES 3.10

2016-08-24 Thread Ian Romanick
From: Ian Romanick All the GLSL 4.x keywords were added to the list of reserved keywords in GLSL ES 3.10. As far as I can tell, these are the only ones that were missed. Signed-off-by: Ian Romanick Cc: mesa-sta...@lists.freedesktop.org ---

[Mesa-dev] [PATCH 04/17] glsl: Allow invocations layout qualifier with GL_OES_geometry_shader

2016-08-24 Thread Ian Romanick
From: Ian Romanick Fixes dEQP-GLES31.functional.geometry_shading.instanced.geometry_1_invocations dEQP-GLES31.functional.geometry_shading.instanced.invocation_per_layer_2d_array dEQP-GLES31.functional.geometry_shading.instanced.invocation_per_layer_2d_multisample_array

[Mesa-dev] [PATCH 05/17] glsl/linker: Fail linking on ES if uniform precision qualifiers don't match

2016-08-24 Thread Ian Romanick
From: Ian Romanick When GL_OES_geometry_shader is enabled, this fixes dEQP-GLES31.functional.shaders.linkage.geometry.uniform.rules.type_mismatch_1. Signed-off-by: Ian Romanick --- src/compiler/glsl/linker.cpp | 7 +++ 1 file changed, 7

[Mesa-dev] [PATCH 10/17] mesa: Rearrange legal_texobj_target to look more like _mesa_legal_get_tex_level_parameter_target

2016-08-24 Thread Ian Romanick
From: Ian Romanick This makes it a bit easier to add support for more features in different APIs. Signed-off-by: Ian Romanick --- src/mesa/main/texstorage.c | 37 ++--- 1 file changed, 26 insertions(+), 11

[Mesa-dev] [PATCH 15/17] i965: Enable OES_texture_cube_map on Gen8+

2016-08-24 Thread Ian Romanick
From: Ian Romanick These are the only platforms that current expose OES_geometry_shader. Once OpenGL ES 3.1 and OES_geometry_shader are enabled on Gen7, this extension can be enabled there as well. Gen6 will never get OpenGL ES 3.1, so it will never get this

Re: [Mesa-dev] Intel: Please help define the common rectangle primitive type

2016-08-24 Thread Marek Olšák
On Wed, Aug 24, 2016 at 10:42 PM, Jason Ekstrand wrote: > On Wed, Aug 24, 2016 at 11:46 AM, Marek Olšák wrote: >> >> On Fri, Aug 5, 2016 at 1:22 AM, Kenneth Graunke >> wrote: >> > On Thursday, August 4, 2016 11:28:28 AM PDT Jason

[Mesa-dev] [PATCH] radeonsi: disable SDMA on Carrizo

2016-08-24 Thread Marek Olšák
From: Marek Olšák Cc: 12.0 --- src/gallium/drivers/radeonsi/cik_sdma.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/gallium/drivers/radeonsi/cik_sdma.c b/src/gallium/drivers/radeonsi/cik_sdma.c index 2eade50..e1fd050

Re: [Mesa-dev] Intel: Please help define the common rectangle primitive type

2016-08-24 Thread Jason Ekstrand
On Wed, Aug 24, 2016 at 11:46 AM, Marek Olšák wrote: > On Fri, Aug 5, 2016 at 1:22 AM, Kenneth Graunke > wrote: > > On Thursday, August 4, 2016 11:28:28 AM PDT Jason Ekstrand wrote: > >> > > - No cut index (GS is supposed to be fine and Tess looks OK

[Mesa-dev] [PATCH v2 8/13] tests/sw_sync: Add subtest test_sync_merge_same

2016-08-24 Thread robert . foss
From: Robert Foss This subtest verifies merging a fence with itself does not fail. Signed-off-by: Robert Foss Reviewed-by: Eric Engestrom --- tests/sw_sync.c | 27 +++ 1 file changed, 27

[Mesa-dev] [PATCH v2 6/13] tests/sw_sync: Add subtest test_sync_wait

2016-08-24 Thread robert . foss
From: Robert Foss This subtest verifies that waiting on fences works properly. Signed-off-by: Robert Foss Reviewed-by: Eric Engestrom --- tests/sw_sync.c | 38 ++ 1 file changed, 38

[Mesa-dev] [PATCH v2 3/13] tests/sw_sync: Add subtest test_alloc_fence

2016-08-24 Thread robert . foss
From: Robert Foss Add subtest alloc_fence that verifies that it's possible to allocate a fence on a timeline. Signed-off-by: Robert Foss Reviewed-by: Eric Engestrom --- tests/sw_sync.c | 16 1 file

[Mesa-dev] [PATCH v2 7/13] tests/sw_sync: Add subtest test_sync_merge

2016-08-24 Thread robert . foss
From: Robert Foss Add subtest test_sync_merge that tests merging fences and the validity of the resulting merged fence. Signed-off-by: Robert Foss Reviewed-by: Eric Engestrom --- tests/sw_sync.c | 67

[Mesa-dev] [PATCH v2 12/13] tests/sw_sync: Add subtest test_sync_multi_timeline_wait

2016-08-24 Thread robert . foss
From: Robert Foss This subtest verifies that waiting, timing out on a wait and that counting fences in various states works. Signed-off-by: Robert Foss Reviewed-by: Eric Engestrom --- tests/sw_sync.c | 66

[Mesa-dev] [PATCH v2 9/13] tests/sw_sync: Add subtest test_sync_multi_consumer

2016-08-24 Thread robert . foss
From: Robert Foss This subtest verifies the access ordering of multiple consumer threads. Signed-off-by: Robert Foss Reviewed-by: Eric Engestrom --- tests/sw_sync.c | 103

[Mesa-dev] [Bug 97285] Darkness in Dota 2 after Patch "Make Gallium's BlitFramebuffer follow the GL 4.4 sRGB rules"

2016-08-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97285 --- Comment #20 from Edmondo Tommasina --- @Vladimir: I've updated to mesa master (c9c989763aa7ad636407cb33c27d586e6f559d7a) and the issue is not fixed for me. -- You are receiving this mail because: You are the QA Contact

[Mesa-dev] [PATCH v2 4/13] tests/sw_sync: Add subtest test_alloc_fence_invalid_timeline

2016-08-24 Thread robert . foss
From: Robert Foss This subtests tests that creating fences on negative timelines fail. Signed-off-by: Robert Foss Reviewed-by: Eric Engestrom --- tests/sw_sync.c | 7 +++ 1 file changed, 7 insertions(+), 0

[Mesa-dev] [PATCH v2 11/13] tests/sw_sync: Add subtest test_sync_random_merge

2016-08-24 Thread robert . foss
From: Robert Foss This subtest verifies that creating many timelines and merging random fences from each timeline with eachother results in merged fences that are fully functional. Signed-off-by: Robert Foss Reviewed-by: Eric Engestrom

[Mesa-dev] [PATCH v2 5/13] tests/sw_sync: Add subtest test_alloc_merge_fence

2016-08-24 Thread robert . foss
From: Robert Foss This subtest verifies that merging two fences works in the simples possible case. Signed-off-by: Robert Foss Reviewed-by: Eric Engestrom --- tests/sw_sync.c | 23 +++ 1 file

[Mesa-dev] [PATCH v2 13/13] tests/sw_sync: Add subtest test_sync_multi_producer_single_consumer

2016-08-24 Thread robert . foss
From: Robert Foss This subtest runs a single consumer thread and multiple producer thread that are synchronized using multiple timelines. Signed-off-by: Robert Foss Reviewed-by: Eric Engestrom --- tests/sw_sync.c | 139

[Mesa-dev] [PATCH v2 10/13] tests/sw_sync: Add subtest test_sync_multi_consumer_producer

2016-08-24 Thread robert . foss
From: Robert Foss This test verifies that stressing the kernel by creating multiple consumer/producer threads that wait on a single timeline to be incremented by another conumer/producer thread does not fail. And that the order amongst the threads is maintained.

[Mesa-dev] [PATCH v2 2/13] tests/sw_sync: Add sw_sync test

2016-08-24 Thread robert . foss
From: Robert Foss Add initial tests for sw_sync. Signed-off-by: Robert Foss Signed-off-by: Gustavo Padovan Reviewed-by: Eric Engestrom --- tests/Makefile.sources | 1 +-

  1   2   3   >