Re: [Mesa-dev] [PATCH 3/3] mesa: implement GL_OES_texture_view (V2)

Hi, I sent this series to have some feedback (rfc prefix failed) and the comment will be addressed as soon as the tests are done. I started checking the piglit part that you suggested in a previous mail.. I'll ask you also about them if I don't bother too much :) Il 31 ago 2016 01:44, "Ilia

Re: [Mesa-dev] [PATCH 2/3] mesa: Add and use _mesa_has_texture_view helper(v2)

Hi, to switch to the macro would mean to check also the version. I'd prefer to keep the original behaviour but, if it's necessary I'll change it.. Francesco Il 31 ago 2016 01:39, "Ilia Mirkin" ha scritto: On Mon, Aug 29, 2016 at 1:25 AM, Francesco Ansanelli

Re: [Mesa-dev] Improving ralloc performance for the GLSL compiler

On Tuesday, August 30, 2016 3:52:12 PM PDT Ian Romanick wrote: [snip] > I don't recall any native Linux games encountering this, but my memory > may have faded. There were some Windows DirectX games that would > exhaust VMA when run inside VMware. Once we got to the point where the > GLSL IR was

[Mesa-dev] [PATCH 3/2] i965: Merge gen7_clip_state atom into gen6_clip_state atom.

The original motivation was that gen6_clip_state ignored _NEW_POLYGON as it didn't care about early culling. The only other change was that Gen6 ignored BRW_NEW_TES_PROG_DATA as it doesn't have tessellation shaders, but listening to this is harmless as it'll never be signalled. Now that we've

[Mesa-dev] [PATCH v2 1/2] i965: Fix missing dirty bits related to is_drawing_points/lines.

calculate_attr_overrides() uses is_drawing_points(), which depends on tessellation and geometry program state, as well as polygon state. v2: Add missing _NEW_POLYGON as well. Caught by Iago Toral. Signed-off-by: Kenneth Graunke Reviewed-by: Iago Toral Quiroga

Re: [Mesa-dev] Improving ralloc performance for the GLSL compiler

On 30/08/16 06:51 PM, Marek Olšák wrote: > > If we don't care about memory usage, let's use my allocator. If we do, > let's import jemalloc into the Mesa tree and use it for ralloc. Instead of importing jemalloc into Mesa, could we use the shared libjemalloc.so.1? -- Earthling Michel Dänzer

[Mesa-dev] [PATCH 1/3] a3xx: make sure to actually clamp depth as requested

We were previously ... not clamping. I guess this meant that everything got clamped to 1/0, which was enough to pass the existing tests. Or perhaps the clamping would only happen to the rasterized depth value and not the frag shader's output depth value. Bugzilla:

[Mesa-dev] [PATCH 3/3] a3xx: use window scissor to simulate viewport xy clip

Unfortunately a3xx does not have a separate disable for depth clipping, so when depth clamp is enabled, we disable the whole 3d clipper logic. This in turn also gets rid of the xy clip that it would normally do. When we detect this would happen, instead we integrate the viewport into the window

[Mesa-dev] [PATCH 2/3] a3xx: make use of software clipping when hw can't handle it

The hw clipper only handles up to 6 UCPs. If there are more than 6 UCPs, or a clip vertex, or clip distances are in use, then we must use the fallback discard-based clipping from the frag shader. Signed-off-by: Ilia Mirkin Cc: mesa-sta...@lists.freedesktop.org ---

[Mesa-dev] [Bug 97542] mesa-12.0.1 with llvm-3.9.0_rc3 - src/gallium/state_trackers/clover/llvm/invocation.cpp:212:75: error: no matching function for call to clang::CompilerInvocation::setLangDefault

https://bugs.freedesktop.org/show_bug.cgi?id=97542 --- Comment #5 from Michel Dänzer --- (In reply to Vedran Miletić from comment #4) > We could do that once LLVM 3.9 is out. Michel, thoughts? It would require backporting all changes from master which are needed for LLVM

Re: [Mesa-dev] [PATCH] i965: enable OES_primitive_bounding_box with the no-op implementation

On Tue, Aug 30, 2016 at 6:07 PM, Ilia Mirkin wrote: > On Tue, Aug 30, 2016 at 9:01 PM, Matt Turner wrote: >> On Tue, Aug 30, 2016 at 5:09 PM, Ilia Mirkin wrote: >>> Signed-off-by: Ilia Mirkin >>> --- >>> >>>

Re: [Mesa-dev] [PATCH] i965: enable OES_primitive_bounding_box with the no-op implementation

On Tue, Aug 30, 2016 at 9:01 PM, Matt Turner wrote: > On Tue, Aug 30, 2016 at 5:09 PM, Ilia Mirkin wrote: >> Signed-off-by: Ilia Mirkin >> --- >> >> This passes a jenkins run except for 2 tests: >> >>

Re: [Mesa-dev] [PATCH] i965: enable OES_primitive_bounding_box with the no-op implementation

On Tue, Aug 30, 2016 at 5:09 PM, Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin > --- > > This passes a jenkins run except for 2 tests: > > dEQP-GLES31.functional.primitive_bounding_box.call_order.bbox_first_viewport_second >

[Mesa-dev] [PATCH 3/3] gallium: Fix incorrect unreachable call

Signed-off-by: Michael Schellenberger Costa --- src/gallium/state_trackers/nine/nine_shader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/nine/nine_shader.c b/src/gallium/state_trackers/nine/nine_shader.c index

[Mesa-dev] [PATCH] mesa/st: Standardize some asserts to use !"foo"

These are the final asserts in the tree that do not follow the pattern assert(!"foo"). To simplify spotting of (mostly) incorrect asserts via git grep "assert(\"" rewrite them into the standard form. Signed-off-by: Michael Schellenberger Costa ---

[Mesa-dev] [PATCH 2/3] glsl: Fix incorrect unreachable call

Signed-off-by: Michael Schellenberger Costa --- src/compiler/glsl/ir_print_visitor.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/glsl/ir_print_visitor.cpp b/src/compiler/glsl/ir_print_visitor.cpp index 0dd1c35..4cb8069

[Mesa-dev] [PATCH 1/3] anv: Fix incorrect unreachable call

Signed-off-by: Michael Schellenberger Costa --- src/intel/vulkan/anv_meta_blit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_meta_blit.c b/src/intel/vulkan/anv_meta_blit.c index d2e375a..6f73102 100644 ---

[Mesa-dev] [PATCH] anv: Fix incorrect assert in anv_wsi_wayland.c

Signed-off-by: Michael Schellenberger Costa --- src/intel/vulkan/anv_wsi_wayland.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_wsi_wayland.c b/src/intel/vulkan/anv_wsi_wayland.c index a9e1617..d210e79 100644 ---

[Mesa-dev] [PATCH] i965: enable OES_primitive_bounding_box with the no-op implementation

Signed-off-by: Ilia Mirkin --- This passes a jenkins run except for 2 tests: dEQP-GLES31.functional.primitive_bounding_box.call_order.bbox_first_viewport_second dEQP-GLES31.functional.primitive_bounding_box.call_order.viewport_first_bbox_second In both cases, they assume

Re: [Mesa-dev] [PATCH mesa 2/2] docs/helpwanted: fix GL3.txt/features.txt link

Am 30.08.2016 22:16, schrieb Eric Engestrom: Fixes: f926cf5bd0ade3273b32 ("docs: Rename GL3.txt to features.txt") CC: Ian Romanick CC: Andreas Boll Signed-off-by: Eric Engestrom --- docs/helpwanted.html | 4 ++-- 1 file

[Mesa-dev] [PATCH] i965: Allow creating image from different dma_buf fds

From: "Kristian H. Kristensen" As long as the dma_buf fds import to the same drm_intel_bo, we're fine. Reviewed-by: Stéphane Marchesin --- src/mesa/drivers/dri/i965/intel_screen.c | 36 +++- 1 file changed, 26

Re: [Mesa-dev] [PATCH 3/3] mesa: implement GL_OES_texture_view (V2)

On Mon, Aug 29, 2016 at 1:25 AM, Francesco Ansanelli wrote: > XXX still need to figure how to treat the removed VIEW_CLASS* > and formats. Can you elaborate what this comment means? You definitely need to add piglit tests for testing ETC2 stuff - it's not supported in

Re: [Mesa-dev] [PATCH 2/3] mesa: Add and use _mesa_has_texture_view helper(v2)

On Mon, Aug 29, 2016 at 1:25 AM, Francesco Ansanelli wrote: > V2:use the same tokens of the desktop version > (Ilia Mirkin, Chris Forbes) > > Signed-off-by: Francesco Ansanelli > --- > src/mesa/main/context.h |7 +++ >

Re: [Mesa-dev] ARB_gpu_shader_int64 second posting (softpipe/llvmpipe/radeonsi)

I have rebased this on current master, and I pushed the branch to https://cgit.freedesktop.org/~idr/mesa/log/?h=arb_gpu_shader_int64. My plan is to start working on i965 support. On 06/19/2016 10:06 PM, Dave Airlie wrote: > Okay this is the second posting for the ARB_gpu_shader_int64 series. >

Re: [Mesa-dev] [PATCH v3] clover: fix getting scalar args api size

Serge Martin writes: > This fix getting the size of a struct arg. vec3 types still work ok. > Only buit-in args need to have power of two alignment, getTypeAllocSize > reports the correct size in all cases. > --- > > This v3 is v1.1 modified for the curent ToT I'm still

Re: [Mesa-dev] [PATCH] st/mesa: expose OES_geometry_shader and OES_texture_cube_map_array

On Mon, Aug 29, 2016 at 11:49 AM, Marek Olšák wrote: > On Mon, Aug 29, 2016 at 5:41 PM, Ilia Mirkin wrote: >> On Mon, Aug 29, 2016 at 11:35 AM, Marek Olšák wrote: >>> On Sat, Aug 27, 2016 at 11:53 PM, Ilia Mirkin

Re: [Mesa-dev] Improving ralloc performance for the GLSL compiler

On Tue, 2016-08-30 at 15:52 -0700, Ian Romanick wrote: > On 08/30/2016 07:06 AM, Marek Olšák wrote: > > > > On Tue, Aug 30, 2016 at 3:21 PM, Eero Tamminen > > wrote: > > > > > > Hi, > > > > > > > > > On 30.08.2016 12:51, Marek Olšák wrote: > > > > > > > > > > > >

Re: [Mesa-dev] Improving ralloc performance for the GLSL compiler

On Tue, 2016-08-30 at 16:14 -0400, Connor Abbott wrote: > On Tue, Aug 30, 2016 at 10:06 AM, Marek Olšák > wrote: > > > > On Tue, Aug 30, 2016 at 3:21 PM, Eero Tamminen > > wrote: > > > > > > Hi, > > > > > > > > > On 30.08.2016 12:51, Marek Olšák

Re: [Mesa-dev] Improving ralloc performance for the GLSL compiler

On 08/30/2016 07:06 AM, Marek Olšák wrote: > On Tue, Aug 30, 2016 at 3:21 PM, Eero Tamminen > wrote: >> Hi, >> >> >> On 30.08.2016 12:51, Marek Olšák wrote: >>> >>> Recently I discovered that our GLSL compiler spends a lot of time in >>> rzalloc_size, so I looked at

[Mesa-dev] What happened to the stable releases?

The biweekly stable releases have stopped without any indication why. 11.2.2 was nearly four months ago, and there effectively hasn't been a stable release in the 12.0 series. Can we resume these as soon as possible? ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH 4/4] glsl: Fix gl_program::OutputsWritten computation for dual-source blending.

Series is Reviewed-by: Ilia Mirkin Thanks for teasing these issues apart. On Tue, Aug 30, 2016 at 6:17 PM, Francisco Jerez wrote: > In the fragment shader OutputsWritten is a bitset of FRAG_RESULT_* > enumerants, which represent the location of

[Mesa-dev] [PATCH 2/4] st/glsl_to_tgsi: Use SecondaryOutputsWritten to determine dual-source fragment outputs.

Currently the mesa state tracker relies on there being two bits set per dual-source output in the gl_program::OutputsWritten bitset, but that only worked due to a GLSL front-end bug that caused it to set the OutputsWritten bit for both location and location+1 even though at the GLSL level the

[Mesa-dev] [PATCH 4/4] glsl: Fix gl_program::OutputsWritten computation for dual-source blending.

In the fragment shader OutputsWritten is a bitset of FRAG_RESULT_* enumerants, which represent the location of each color output written by the shader. The secondary and primary color outputs of a given render target using dual-source blending have the same location, so the 'idx' computation

[Mesa-dev] [PATCH 3/4] glsl: Fix incorrect hard-coded location of the gl_SecondaryFragColorEXT built-in.

gl_SecondaryFragColorEXT should have the same location as gl_FragColor for the secondary fragment color to be replicated to all fragment outputs. The incorrect location of gl_SecondaryFragColorEXT would cause the linker to mark both FRAG_RESULT_COLOR and FRAG_RESULT_DATA0 as being written to,

[Mesa-dev] [PATCH 1/4] glsl: Calculate bitset of secondary outputs written in ir_set_program_inouts.

--- src/compiler/glsl/ir_set_program_inouts.cpp | 9 +++-- src/mesa/main/mtypes.h | 1 + 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/compiler/glsl/ir_set_program_inouts.cpp b/src/compiler/glsl/ir_set_program_inouts.cpp index fcfbcd4..06d9973 100644

Re: [Mesa-dev] [PATCH mesa 2/2] docs/helpwanted: fix GL3.txt/features.txt link

Oops. Pushed. Thanks. On 08/30/2016 01:16 PM, Eric Engestrom wrote: > Fixes: f926cf5bd0ade3273b32 ("docs: Rename GL3.txt to features.txt") > CC: Ian Romanick > CC: Andreas Boll > Signed-off-by: Eric Engestrom > --- >

Re: [Mesa-dev] [PATCH mesa 3/3] anv/meta: fix unreachable() typo

On Tue, Aug 30, 2016 at 12:18 PM, Eric Engestrom wrote: > On Tue, Aug 30, 2016 at 10:10:41AM -0700, Anuj Phogat wrote: >> On Tue, Aug 30, 2016 at 3:36 AM, Eric Engestrom >> wrote: >> > Signed-off-by: Eric Engestrom >> >

Re: [Mesa-dev] [PATCH mesa v2] Introduce .editorconfig

Thanks for the update. Reviewed-by: Jose Fonseca If you need and there's no outstanding objections, I can push this change for you. Jose On 30/08/16 21:02, Eric Engestrom wrote: A few weeks ago, Jose Fonseca suggested [0] we use .editorconfig files to try and enforce

Re: [Mesa-dev] [PATCH mesa 1/2] get_reviewer.pl: fix mesa check

thanks, pushed :-) BR, -R On Tue, Aug 30, 2016 at 4:16 PM, Eric Engestrom wrote: > This script was broken for the last few days and I couldn't figure out why. > Turns out it was checking for the existence of a file that got renamed, > so rename it in here too. > > Fixes:

[Mesa-dev] [PATCH mesa 2/2] docs/helpwanted: fix GL3.txt/features.txt link

Fixes: f926cf5bd0ade3273b32 ("docs: Rename GL3.txt to features.txt") CC: Ian Romanick CC: Andreas Boll Signed-off-by: Eric Engestrom --- docs/helpwanted.html | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[Mesa-dev] [PATCH mesa 1/2] get_reviewer.pl: fix mesa check

This script was broken for the last few days and I couldn't figure out why. Turns out it was checking for the existence of a file that got renamed, so rename it in here too. Fixes: f926cf5bd0ade3273b32 ("docs: Rename GL3.txt to features.txt") CC: Ian Romanick CC: Rob

Re: [Mesa-dev] Improving ralloc performance for the GLSL compiler

On Tue, Aug 30, 2016 at 10:06 AM, Marek Olšák wrote: > On Tue, Aug 30, 2016 at 3:21 PM, Eero Tamminen > wrote: >> Hi, >> >> >> On 30.08.2016 12:51, Marek Olšák wrote: >>> >>> Recently I discovered that our GLSL compiler spends a lot of time in >>>

[Mesa-dev] [PATCH mesa v2] Introduce .editorconfig

A few weeks ago, Jose Fonseca suggested [0] we use .editorconfig files to try and enforce the formatting of the code, to which Michel Dänzer suggested [1] we start by importing the existing .dir-locals.el settings. The first draft was discussed in the RFC [2]. These .editorconfig are a first

Re: [Mesa-dev] Improving ralloc performance for the GLSL compiler

On Tue, Aug 30, 2016 at 4:06 PM, Marek Olšák wrote: > On Tue, Aug 30, 2016 at 3:21 PM, Eero Tamminen > wrote: >> Hi, >> >> >> On 30.08.2016 12:51, Marek Olšák wrote: >>> >>> Recently I discovered that our GLSL compiler spends a lot of time in >>>

Re: [Mesa-dev] [PATCH mesa 3/3] anv/meta: fix unreachable() typo

On Tue, Aug 30, 2016 at 10:10:41AM -0700, Anuj Phogat wrote: > On Tue, Aug 30, 2016 at 3:36 AM, Eric Engestrom > wrote: > > Signed-off-by: Eric Engestrom > > --- > > src/intel/vulkan/anv_meta_blit.c | 2 +- > > 1 file changed, 1

[Mesa-dev] [PATCH] i965: Pass start_offset to brw_set_uip_jip().

Without this, we would pass over the instructions in the SIMD8 program (which is located earlier in the buffer) when brw_set_uip_jip() is called to handle the SIMD16 program. The assertion about compacted control flow was bogus: halt, cont, break cannot be compacted because they have both JIP and

Re: [Mesa-dev] [PATCH v2] egl: return corresponding offset of EGLImage instead of 0.

On 30 August 2016 at 18:39, Weng, Chuanbo wrote: > Hi Emil, > Thanks for your review! > Please see my comments and questions below. > > -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf Of > Emil Velikov

Re: [Mesa-dev] [PATCH 1/2] anv: pipeline: use NIR macros to apply passes

On Tue, Aug 30, 2016 at 10:24 AM, Lionel Landwerlin wrote: > It seems the i965 GL driver uses macros in most places and I found it pretty > handy to be able to put a printf in a single file (nir.h) to compare the > passes applied between the 2 drivers. It would be nice to

Re: [Mesa-dev] [PATCH v2] egl: return corresponding offset of EGLImage instead of 0.

Hi Emil, Thanks for your review! Please see my comments and questions below. -Original Message- From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf Of Emil Velikov Sent: Tuesday, August 30, 2016 6:29 PM To: Weng, Chuanbo Cc:

Re: [Mesa-dev] [PATCH mesa] Introduce .editorconfig

On 29/08/16 22:30, Eric Engestrom wrote: A few weeks ago, Jose Fonseca suggested [0] we use .editorconfig files to try and enforce the formatting of the code, to which Michel Dänzer suggested [1] we start by importing the existing .dir-locals.el settings. The first draft was discussed in the RFC

[Mesa-dev] [PATCH 2/2] anv: pipeline: reorder NIR passes closer to the i965 driver

While comparing similar programs on both the vulkan driver and i965 GL, like : varying vec4 tex_coord; varying vec4 color_in; uniform sampler2D sampler; vec4 temp; void func() { temp = texture2D(sampler, tex_coord) * color_in; } void main() { func(); temp = vec4(gl_PointCoord.x,

[Mesa-dev] [PATCH 1/2] anv: pipeline: use NIR macros to apply passes

It seems the i965 GL driver uses macros in most places and I found it pretty handy to be able to put a printf in a single file (nir.h) to compare the passes applied between the 2 drivers. Signed-off-by: Lionel Landwerlin Cc: Jason Ekstrand

Re: [Mesa-dev] [PATCH mesa] anv/wayland: fix assert typo

On Tue, Aug 30, 2016 at 3:30 AM, Eric Engestrom wrote: > Signed-off-by: Eric Engestrom > --- > src/intel/vulkan/anv_wsi_wayland.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/intel/vulkan/anv_wsi_wayland.c >

Re: [Mesa-dev] [PATCH mesa 3/3] anv/meta: fix unreachable() typo

On Tue, Aug 30, 2016 at 3:36 AM, Eric Engestrom wrote: > Signed-off-by: Eric Engestrom > --- > src/intel/vulkan/anv_meta_blit.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/intel/vulkan/anv_meta_blit.c >

Re: [Mesa-dev] [RFC] New dma_buf -> EGLImage EGL extension - Final spec published!

Tom, hmm, I wonder if it was a bug/oversight for the YUV capabilities of this extension to not depend on OES_EGL_image_external (which unfortunately, doesn't seem to have a GL counterpart)? I think this currently implies that you could sample from an imported YUV eglimg using (for example)

Re: [Mesa-dev] [PATCH mesa] Introduce .editorconfig

On Tue, Aug 30, 2016 at 12:16 PM, Emil Velikov wrote: > On 29 August 2016 at 22:30, Eric Engestrom wrote: > >> A couple of people have also suggested I add `tab_width`, but IMO this >> concept >> should die: it comes from the confusion between

Re: [Mesa-dev] [PATCH 2/3] nvc0: check return value of nvc0_screen_resize_tls_area()

On 08/30/2016 04:53 PM, Ilia Mirkin wrote: On Tue, Aug 30, 2016 at 10:45 AM, Samuel Pitoiset wrote: While we are at it, make it static and change the return values policy to be consistent. Signed-off-by: Samuel Pitoiset ---

Re: [Mesa-dev] [PATCH mesa] Introduce .editorconfig

On 29 August 2016 at 22:30, Eric Engestrom wrote: > A couple of people have also suggested I add `tab_width`, but IMO this concept > should die: it comes from the confusion between indentation (a logic concept > meant to convey code structure) and alignment (an aesthetic

Re: [Mesa-dev] [PATCH 20/30] egl/dri2: rework dri2_egl_display::extensions storage

On 25 August 2016 at 17:18, Emil Velikov wrote: > From: Emil Velikov > > Remove the error prone fixed size array. > While we're here also rename to loader_extensions like in the GLX code. > > Signed-off-by: Emil Velikov

Re: [Mesa-dev] [PATCH 3/3] nvc0: fix indentation in nvc0_screen_init()

With the minor nit in 2/3 fixed (1 -> -1), this series is Reviewed-by: Ilia Mirkin On Tue, Aug 30, 2016 at 10:45 AM, Samuel Pitoiset wrote: > Trivial. > > Signed-off-by: Samuel Pitoiset > --- >

Re: [Mesa-dev] [PATCH 2/3] nvc0: check return value of nvc0_screen_resize_tls_area()

On Tue, Aug 30, 2016 at 10:45 AM, Samuel Pitoiset wrote: > While we are at it, make it static and change the return values > policy to be consistent. > > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/nouveau/nvc0/nvc0_screen.c |

[Mesa-dev] [PATCH 3/3] nvc0: fix indentation in nvc0_screen_init()

Trivial. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c b/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c index

[Mesa-dev] [PATCH 2/3] nvc0: check return value of nvc0_screen_resize_tls_area()

While we are at it, make it static and change the return values policy to be consistent. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 16 src/gallium/drivers/nouveau/nvc0/nvc0_screen.h | 3 --- 2 files changed,

[Mesa-dev] [PATCH 1/3] nvc0: make use of FAIL_SCREEN_INIT in nvc0_screen_create()

Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c b/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c index

Re: [Mesa-dev] [PATCH 1/3] anv: Fix incorrect unreachable call

Reviewed-by: Jason Ekstrand On Tue, Aug 30, 2016 at 12:37 AM, Michael Schellenberger Costa < mschellenbergerco...@googlemail.com> wrote: > Signed-off-by: Michael Schellenberger Costa com> > --- > src/intel/vulkan/anv_meta_blit.c | 2 +- > 1

Re: [Mesa-dev] [PATCH] intel/blorp: Inline get_vs_entry_size into emit_urb_config

On Mon, Aug 29, 2016 at 11:39 PM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Mon, Aug 29, 2016 at 09:00:33AM -0700, Jason Ekstrand wrote: > > Topi asked to have the prefix removed because there's nothing gen7 about > > it. However, now that everything is in a single file, there

Re: [Mesa-dev] [PATCH] anv: Fix incorrect assert in anv_wsi_wayland.c

Reviewed-by: Jason Ekstrand On Tue, Aug 30, 2016 at 12:26 AM, Michael Schellenberger Costa < mschellenbergerco...@googlemail.com> wrote: > Signed-off-by: Michael Schellenberger Costa com> > --- > src/intel/vulkan/anv_wsi_wayland.c | 2 +- >

Re: [Mesa-dev] [PATCH 07/30] egl/dri2: call static functions directly, not via _EGLDriver::API

On 25 August 2016 at 17:18, Emil Velikov wrote: > From: Emil Velikov > > The indirection is meant to be used by the core EGL implementation in > main. Not in the drivers themselves. > > Move the dri2_destroy_surface definition to avoid

Re: [Mesa-dev] Improving ralloc performance for the GLSL compiler

On Tue, Aug 30, 2016 at 3:21 PM, Eero Tamminen wrote: > Hi, > > > On 30.08.2016 12:51, Marek Olšák wrote: >> >> Recently I discovered that our GLSL compiler spends a lot of time in >> rzalloc_size, so I looked at possible options to optimize that. It's >> worth noting

Re: [Mesa-dev] [PATCH 2/4] glapi/hgl: remove the final user of _glapi_check_table()

On 25 August 2016 at 16:58, Emil Velikov wrote: > From: Emil Velikov > > The symbol is a no-op since, the EXTRA_DEBUG macro is not set in the > build. Unused by !Haiku people/platforms since 2010 (commit >

Re: [Mesa-dev] [PATCH 0/4] Resolving Android + desktop OpenGL 'hack'

On 27 August 2016 at 13:04, Tomasz Figa wrote: > On Sat, Aug 27, 2016 at 4:12 AM, Ilia Mirkin wrote: >> On Fri, Aug 26, 2016 at 3:01 PM, Ryan Houdek wrote: >>> Most of the Tegra devices (K1 and above) provide desktop GL, except

Re: [Mesa-dev] [PATCH 3/3] gallium: Fix incorrect unreachable call

Minor nit: the subject should probably be prefixed with "st/nine:" -Brian On 08/30/2016 01:37 AM, Michael Schellenberger Costa wrote: Signed-off-by: Michael Schellenberger Costa --- src/gallium/state_trackers/nine/nine_shader.c | 2 +- 1 file changed, 1

Re: [Mesa-dev] [PATCH] mesa/st: Standardize some asserts to use !"foo"

On 08/30/2016 04:09 AM, Michael Schellenberger Costa wrote: These are the final asserts in the tree that do not follow the pattern assert(!"foo"). To simplify spotting of (mostly) incorrect asserts via git grep "assert(\"" rewrite them into the standard form. Signed-off-by: Michael

Re: [Mesa-dev] Improving ralloc performance for the GLSL compiler

Hi, On 30.08.2016 12:51, Marek Olšák wrote: Recently I discovered that our GLSL compiler spends a lot of time in rzalloc_size, so I looked at possible options to optimize that. It's worth noting that too many existing allocations slow down subsequent malloc calls, which in turn slows down the

Re: [Mesa-dev] [PATCH mesa] Introduce .editorconfig

On Mon, Aug 29, 2016 at 11:43:49PM +0200, Serge Martin wrote: > On Monday 29 August 2016 22:30:58 Eric Engestrom wrote: > > A few weeks ago, Jose Fonseca suggested [0] we use .editorconfig files > > to try and enforce the formatting of the code, to which Michel Dänzer > > suggested [1] we start by

[Mesa-dev] [Bug 97542] mesa-12.0.1 with llvm-3.9.0_rc3 - src/gallium/state_trackers/clover/llvm/invocation.cpp:212:75: error: no matching function for call to clang::CompilerInvocation::setLangDefault

https://bugs.freedesktop.org/show_bug.cgi?id=97542 --- Comment #4 from Vedran Miletić --- (In reply to Dennis Schridde from comment #3) > (In reply to Michel Dänzer from comment #2) > > Mesa releases can't support unreleased version of LLVM. > > As the code in the affected

Re: [Mesa-dev] Improving ralloc performance for the GLSL compiler

Results for single-threaded shader-db (using shaders from one game only) including LLVM compilation: Default: real0m59.606s user0m59.488s sys0m0.104s Only ralloc is using jemalloc: real0m55.284s (7.2% less time) user0m55.032s sys0m0.244s Ralloc is using my linear

Re: [Mesa-dev] [PATCH] automake: egl: Android: Add libEGL dependencies

On 30 August 2016 at 05:59, Tapani Pälli wrote: > I could try to push .pc files in to those projects but I'm not sure how that > should work. Should those projects then install the .pc files somewhere > during Android build or would we mess with the PKG_CONFIG_PATH to be

[Mesa-dev] [PATCH mesa 3/3] anv/meta: fix unreachable() typo

Signed-off-by: Eric Engestrom --- src/intel/vulkan/anv_meta_blit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_meta_blit.c b/src/intel/vulkan/anv_meta_blit.c index d2e375a..6f73102 100644 ---

[Mesa-dev] [PATCH mesa 1/3] glsl: fix unreachable() typo

Signed-off-by: Eric Engestrom --- src/compiler/glsl/ir_print_visitor.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/glsl/ir_print_visitor.cpp b/src/compiler/glsl/ir_print_visitor.cpp index 0dd1c35..4cb8069 100644 ---

[Mesa-dev] [PATCH mesa 2/3] st/nine: fix unreachable() typo

Signed-off-by: Eric Engestrom --- src/gallium/state_trackers/nine/nine_shader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/nine/nine_shader.c b/src/gallium/state_trackers/nine/nine_shader.c index bd373d7..4c58a6d

[Mesa-dev] [PATCH mesa] anv/wayland: fix assert typo

Signed-off-by: Eric Engestrom --- src/intel/vulkan/anv_wsi_wayland.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_wsi_wayland.c b/src/intel/vulkan/anv_wsi_wayland.c index a9e1617..d210e79 100644 ---

Re: [Mesa-dev] [PATCH v2] egl: return corresponding offset of EGLImage instead of 0.

On 25 August 2016 at 18:50, Chuanbo Weng wrote: > The offset should not always be 0. For example, if EGLImage is > created from a 2D texture with EGL_GL_TEXTURE_LEVEL=1, then the > offset should be the actual start of miplevel 1 in drm bo. > > v2: version bump on the EGL

[Mesa-dev] Improving ralloc performance for the GLSL compiler

Hi, Recently I discovered that our GLSL compiler spends a lot of time in rzalloc_size, so I looked at possible options to optimize that. It's worth noting that too many existing allocations slow down subsequent malloc calls, which in turn slows down the GLSL compiler. When I kept 5 instances of

Re: [Mesa-dev] [PATCH 3/5] i965: use new subroutine index uploader.

On Tue, 2016-08-23 at 10:45 +1000, Dave Airlie wrote: > > > > > #include "main/mtypes.h" > > > #include "program/prog_parameter.h" > > > - > > > +#include "main/shaderapi.h" > > > > Why the extra empty line? If so, I would put it after the new include. > > It actually removes the empty line,

Re: [Mesa-dev] [PATCH 16/20] radeonsi: fix variable naming in si_emit_cache_flush

Reviewed-by: Edward O'Callaghan On 08/30/2016 01:28 AM, Marek Olšák wrote: > From: Marek Olšák > > --- > src/gallium/drivers/radeonsi/si_state_draw.c | 62 > ++-- > 1 file changed, 31 insertions(+), 31 deletions(-) >

Re: [Mesa-dev] [PATCH 18/20] gallium/radeon: unify viewport emission code

Nice cleanup, Reviewed-by: Edward O'Callaghan On 08/30/2016 01:28 AM, Marek Olšák wrote: > From: Marek Olšák > > --- > src/gallium/drivers/radeon/r600_viewport.c | 30 > -- > 1 file changed, 16 insertions(+), 14

Re: [Mesa-dev] [PATCH 05/20] radeonsi: return correct eviction stats for NVX_gpu_memory_info

Reviewed-by: Edward O'Callaghan On 08/30/2016 01:28 AM, Marek Olšák wrote: > From: Marek Olšák > > --- > src/gallium/drivers/radeon/r600_pipe_common.c | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH 14/20] radeonsi: add HUD queries for counting VS/PS/CS partial flushes

Reviewed-by: Edward O'Callaghan On 08/30/2016 01:28 AM, Marek Olšák wrote: > From: Marek Olšák > > --- > src/gallium/drivers/radeon/r600_pipe_common.h | 3 +++ > src/gallium/drivers/radeon/r600_query.c | 21 + >

Re: [Mesa-dev] [PATCH 19/20] gallium/radeon: set VPORT_ZMIN/MAX registers correctly

On Tue, Aug 30, 2016 at 9:06 AM, Marek Olšák wrote: > On Mon, Aug 29, 2016 at 10:33 PM, Bas Nieuwenhuizen > wrote: >> On Mon, Aug 29, 2016 at 5:28 PM, Marek Olšák wrote: >>> From: Marek Olšák >>> >>> Calculate

Re: [Mesa-dev] [PATCH 1/3] noop: simplify some functions

On Mon, Aug 29, 2016 at 7:23 PM, Emil Velikov wrote: > On 29 August 2016 at 16:29, Marek Olšák wrote: >> From: Marek Olšák >> >> --- >> src/gallium/drivers/noop/noop_state.c | 56 >> +-- >> 1 file

[Mesa-dev] [PATCH v3] clover: fix getting scalar args api size

This fix getting the size of a struct arg. vec3 types still work ok. Only buit-in args need to have power of two alignment, getTypeAllocSize reports the correct size in all cases. --- This v3 is v1.1 modified for the curent ToT src/gallium/state_trackers/clover/llvm/codegen/common.cpp | 7

Re: [Mesa-dev] [PATCH 2/2] i965: Use gs_prog_data in is_drawing_points/lines().

Reviewed-by: Iago Toral Quiroga On Mon, 2016-08-29 at 15:05 -0700, Kenneth Graunke wrote: > State upload code should use prog_data rather than poking at core > Mesa shader data structures wherever possible. > > Signed-off-by: Kenneth Graunke > --- >  

[Mesa-dev] [Bug 97542] mesa-12.0.1 with llvm-3.9.0_rc3 - src/gallium/state_trackers/clover/llvm/invocation.cpp:212:75: error: no matching function for call to clang::CompilerInvocation::setLangDefault

https://bugs.freedesktop.org/show_bug.cgi?id=97542 --- Comment #3 from Dennis Schridde --- (In reply to Michel Dänzer from comment #2) > Mesa releases can't support unreleased version of LLVM. As the code in the affected area is guarded with #if HAVE_LLVM >= 0x0309, I

Re: [Mesa-dev] [PATCH] clover: Introduce CLOVER_COMPILER_OPTIONS

On Tuesday 30 August 2016 01:20:55 Vedran Miletić wrote: > Options specified via the CLOVER_COMPILER_OPTIONS shell variable are > appended to the compiler options specified by the OpenCL program (if > any). > > Signed-off-by: Vedran Miletić > --- > docs/envvars.html

Re: [Mesa-dev] [PATCH 1/2] i965: Fix missing dirty bits related to is_drawing_points/lines.

I think we might also be missing a few _NEW_POLYGON flags which I note below, otherwise: Reviewed-by: Iago Toral Quiroga On Mon, 2016-08-29 at 15:05 -0700, Kenneth Graunke wrote: > calculate_attr_overrides() uses is_drawing_points(), which depends > on tessellation and

[Mesa-dev] [Bug 97542] mesa-12.0.1 with llvm-3.9.0_rc3 - src/gallium/state_trackers/clover/llvm/invocation.cpp:212:75: error: no matching function for call to clang::CompilerInvocation::setLangDefault

https://bugs.freedesktop.org/show_bug.cgi?id=97542 Michel Dänzer changed: What|Removed |Added Status|NEW |RESOLVED

Re: [Mesa-dev] [PATCH 19/20] gallium/radeon: set VPORT_ZMIN/MAX registers correctly

On Mon, Aug 29, 2016 at 10:33 PM, Bas Nieuwenhuizen wrote: > On Mon, Aug 29, 2016 at 5:28 PM, Marek Olšák wrote: >> From: Marek Olšák >> >> Calculate depth ranges from viewport states and >> pipe_rasterizer_state::clip_halfz. >>

[Mesa-dev] [Bug 97542] mesa-12.0.1 with llvm-3.9.0_rc3 - src/gallium/state_trackers/clover/llvm/invocation.cpp:212:75: error: no matching function for call to clang::CompilerInvocation::setLangDefault

https://bugs.freedesktop.org/show_bug.cgi?id=97542 --- Comment #1 from Dennis Schridde --- Created attachment 126118 --> https://bugs.freedesktop.org/attachment.cgi?id=126118=edit mesa-12.0.1-llvm-3.9.0_rc3-compatibility.patch Attached patch fixes the issue. -- You are

[Mesa-dev] [Bug 97542] mesa-12.0.1 with llvm-3.9.0_rc3 - src/gallium/state_trackers/clover/llvm/invocation.cpp:212:75: error: no matching function for call to clang::CompilerInvocation::setLangDefault

https://bugs.freedesktop.org/show_bug.cgi?id=97542 Bug ID: 97542 Summary: mesa-12.0.1 with llvm-3.9.0_rc3 - src/gallium/state_trackers/clover/llvm/invocation.cpp: 212:75: error: no matching function for call to

  1   2   >